@devflow-tools/cli 0.16.10 → 0.16.12

package/dist/commands/doctor.d.ts

@@ -1,4 +1,5 @@
 import type { DoctorReportV1 } from "@devflow-tools/sdk";
+import type { EmbeddingModelStatus } from "@devflow-tools/memory-engine";
 export type { DoctorMetric, DoctorReportV1, DoctorSection, DoctorSeverity, DoctorStatus, } from "@devflow-tools/sdk";
 export type DoctorResult = DoctorReportV1;
 export interface DoctorOptions {
@@ -31,6 +32,10 @@ export interface DoctorDependencies {
     httpGet?: (url: string) => Promise<{
         status: number;
     }>;
+    inspectEmbeddingModel?: (options: {
+        homeDir?: string;
+        env?: NodeJS.ProcessEnv;
+    }) => Promise<EmbeddingModelStatus>;
 }
 export interface DoctorCommandIO {
     stdout(output: string): void;

package/dist/commands/doctor.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"doctor.d.ts","sourceRoot":"","sources":["../../src/commands/doctor.ts"],"names":[],"mappings":"AA2BA,OAAO,KAAK,EAEV,cAAc,EAIf,MAAM,oBAAoB,CAAC;AAM5B,YAAY,EACV,YAAY,EACZ,cAAc,EACd,aAAa,EACb,cAAc,EACd,YAAY,GACb,MAAM,oBAAoB,CAAC;AAoC5B,MAAM,MAAM,YAAY,GAAG,cAAc,CAAC;AAE1C,MAAM,WAAW,aAAa;IAC5B,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,IAAI,CAAC,EAAE,OAAO,CAAC;IACf,MAAM,CAAC,EAAE,OAAO,CAAC;CAClB;AAED,UAAU,eAAe;IACvB,GAAG,CAAC,GAAG,MAAM,EAAE,OAAO,EAAE,GAAG,OAAO,EAAE,CAAC;IACrC,GAAG,CAAC,GAAG,MAAM,EAAE,OAAO,EAAE,GAAG,OAAO,CAAC;IACnC,cAAc,CAAC,CAAC,OAAO,EAAE,OAAO,GAAG,IAAI,CAAC;CACzC;AAED,UAAU,cAAc;IACtB,OAAO,CAAC,GAAG,EAAE,MAAM,GAAG,eAAe,CAAC;IACtC,KAAK,IAAI,IAAI,CAAC;CACf;AAED,MAAM,WAAW,kBAAkB;IACjC,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,mBAAmB,CAAC,EAAE,SAAS,MAAM,EAAE,CAAC;IACxC,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,kBAAkB,CAAC,EAAE,MAAM,CAAC;IAC5B,oBAAoB,CAAC,EAAE,MAAM,CAAC;IAC9B,qBAAqB,CAAC,EAAE,MAAM,CAAC;IAC/B,eAAe,CAAC,EAAE,MAAM,CAAC;IACzB,gBAAgB,CAAC,EAAE,MAAM,CAAC;IAC1B,GAAG,CAAC,EAAE,MAAM,CAAC,UAAU,CAAC;IACxB,GAAG,CAAC,EAAE,MAAM,MAAM,CAAC;IACnB,YAAY,CAAC,EAAE,CAAC,IAAI,EAAE,MAAM,KAAK,cAAc,CAAC;IAChD,sBAAsB,CAAC,EAAE,MAAM,CAAC;IAChC,OAAO,CAAC,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,OAAO,CAAC;QAAE,MAAM,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;CACxD;AAED,MAAM,WAAW,eAAe;IAC9B,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,IAAI,CAAC;IAC7B,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,IAAI,CAAC;CAC9B;AAu/ID,wBAAsB,mBAAmB,CACvC,OAAO,GAAE,aAAkB,EAC3B,YAAY,GAAE,kBAAuB,GACpC,OAAO,CAAC,YAAY,CAAC,CA4BvB;AAED,wBAAgB,SAAS,IAAI,OAAO,CAAC,YAAY,CAAC,CAAC;AACnD,wBAAgB,SAAS,CACvB,OAAO,EAAE,aAAa,EACtB,YAAY,CAAC,EAAE,kBAAkB,GAChC,OAAO,CAAC,YAAY,CAAC,CAAC;AAezB,wBAAgB,gBAAgB,CAAC,MAAM,EAAE,YAAY,GAAG,MAAM,CAoB7D;AAED,wBAAsB,gBAAgB,CACpC,OAAO,GAAE,aAAkB,EAC3B,EAAE,GAAE,eAGH,EACD,YAAY,GAAE,kBAAuB,GACpC,OAAO,CAAC,MAAM,CAAC,CAIjB;AAED,MAAM,WAAW,YAAY;IAC3B,KAAK,EAAE;QAAE,UAAU,EAAE,MAAM,CAAC;QAAC,YAAY,EAAE,MAAM,CAAC;QAAC,QAAQ,EAAE,OAAO,CAAA;KAAE,CAAC;IACvE,KAAK,EAAE;QAAE,KAAK,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,MAAM,CAAA;KAAE,CAAC;IACxC,MAAM,EAAE;QAAE,YAAY,EAAE,OAAO,CAAC;QAAC,SAAS,EAAE,MAAM,CAAA;KAAE,CAAC;IACrD,SAAS,EAAE;QAAE,OAAO,EAAE,MAAM,CAAA;KAAE,CAAC;IAC/B,OAAO,EAAE;QAAE,SAAS,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,MAAM,EAAE,CAAA;KAAE,CAAC;IAChD,SAAS,EAAE;QAAE,UAAU,EAAE,MAAM,CAAA;KAAE,CAAC;IAClC,MAAM,EAAE;QAAE,OAAO,EAAE,OAAO,CAAA;KAAE,CAAC;IAC7B,SAAS,EAAE;QAAE,KAAK,EAAE,MAAM,CAAC;QAAC,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;KAAE,CAAC;IAC7D,UAAU,EAAE,MAAM,CAAC;CACpB;AAOD,wBAAsB,qBAAqB,CACzC,OAAO,SAAgB,GACtB,OAAO,CAAC,YAAY,CAAC,CA8DvB;AAED,wBAAsB,cAAc,IAAI,OAAO,CAAC;IAC9C,KAAK,EAAE,OAAO,CAAC;IACf,QAAQ,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,UAAU,EAAE,MAAM,CAAC;CACpB,CAAC,CAiBD;AAED,wBAAsB,iBAAiB,IAAI,OAAO,CAAC;IAAE,OAAO,EAAE,OAAO,CAAA;CAAE,CAAC,CAevE;AAED,wBAAsB,mBAAmB,CAAC,IAAI,CAAC,EAAE,MAAM,GAAG,OAAO,CAAC;IAChE,UAAU,EAAE,KAAK,CAAC;QAChB,IAAI,EAAE,MAAM,CAAC;QACb,QAAQ,EAAE,MAAM,CAAC;QACjB,MAAM,EAAE,MAAM,GAAG,IAAI,CAAC;QACtB,EAAE,EAAE,MAAM,CAAC;QACX,SAAS,EAAE,MAAM,CAAC;KACnB,CAAC,CAAC;CACJ,CAAC,CAsBD;AAED,wBAAgB,iBAAiB,IAAI;IAAE,SAAS,EAAE,MAAM,CAAC;IAAC,IAAI,EAAE,OAAO,CAAA;CAAE,CASxE"}
+{"version":3,"file":"doctor.d.ts","sourceRoot":"","sources":["../../src/commands/doctor.ts"],"names":[],"mappings":"AA4BA,OAAO,KAAK,EAEV,cAAc,EAIf,MAAM,oBAAoB,CAAC;AAM5B,OAAO,KAAK,EAAE,oBAAoB,EAAE,MAAM,8BAA8B,CAAC;AAEzE,YAAY,EACV,YAAY,EACZ,cAAc,EACd,aAAa,EACb,cAAc,EACd,YAAY,GACb,MAAM,oBAAoB,CAAC;AAoC5B,MAAM,MAAM,YAAY,GAAG,cAAc,CAAC;AAE1C,MAAM,WAAW,aAAa;IAC5B,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,IAAI,CAAC,EAAE,OAAO,CAAC;IACf,MAAM,CAAC,EAAE,OAAO,CAAC;CAClB;AAED,UAAU,eAAe;IACvB,GAAG,CAAC,GAAG,MAAM,EAAE,OAAO,EAAE,GAAG,OAAO,EAAE,CAAC;IACrC,GAAG,CAAC,GAAG,MAAM,EAAE,OAAO,EAAE,GAAG,OAAO,CAAC;IACnC,cAAc,CAAC,CAAC,OAAO,EAAE,OAAO,GAAG,IAAI,CAAC;CACzC;AAED,UAAU,cAAc;IACtB,OAAO,CAAC,GAAG,EAAE,MAAM,GAAG,eAAe,CAAC;IACtC,KAAK,IAAI,IAAI,CAAC;CACf;AAED,MAAM,WAAW,kBAAkB;IACjC,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,mBAAmB,CAAC,EAAE,SAAS,MAAM,EAAE,CAAC;IACxC,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,kBAAkB,CAAC,EAAE,MAAM,CAAC;IAC5B,oBAAoB,CAAC,EAAE,MAAM,CAAC;IAC9B,qBAAqB,CAAC,EAAE,MAAM,CAAC;IAC/B,eAAe,CAAC,EAAE,MAAM,CAAC;IACzB,gBAAgB,CAAC,EAAE,MAAM,CAAC;IAC1B,GAAG,CAAC,EAAE,MAAM,CAAC,UAAU,CAAC;IACxB,GAAG,CAAC,EAAE,MAAM,MAAM,CAAC;IACnB,YAAY,CAAC,EAAE,CAAC,IAAI,EAAE,MAAM,KAAK,cAAc,CAAC;IAChD,sBAAsB,CAAC,EAAE,MAAM,CAAC;IAChC,OAAO,CAAC,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,OAAO,CAAC;QAAE,MAAM,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IACvD,qBAAqB,CAAC,EAAE,CAAC,OAAO,EAAE;QAChC,OAAO,CAAC,EAAE,MAAM,CAAC;QACjB,GAAG,CAAC,EAAE,MAAM,CAAC,UAAU,CAAC;KACzB,KAAK,OAAO,CAAC,oBAAoB,CAAC,CAAC;CACrC;AAED,MAAM,WAAW,eAAe;IAC9B,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,IAAI,CAAC;IAC7B,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,IAAI,CAAC;CAC9B;AA04JD,wBAAsB,mBAAmB,CACvC,OAAO,GAAE,aAAkB,EAC3B,YAAY,GAAE,kBAAuB,GACpC,OAAO,CAAC,YAAY,CAAC,CA4BvB;AAED,wBAAgB,SAAS,IAAI,OAAO,CAAC,YAAY,CAAC,CAAC;AACnD,wBAAgB,SAAS,CACvB,OAAO,EAAE,aAAa,EACtB,YAAY,CAAC,EAAE,kBAAkB,GAChC,OAAO,CAAC,YAAY,CAAC,CAAC;AAezB,wBAAgB,gBAAgB,CAAC,MAAM,EAAE,YAAY,GAAG,MAAM,CAoB7D;AAED,wBAAsB,gBAAgB,CACpC,OAAO,GAAE,aAAkB,EAC3B,EAAE,GAAE,eAGH,EACD,YAAY,GAAE,kBAAuB,GACpC,OAAO,CAAC,MAAM,CAAC,CAIjB;AAED,MAAM,WAAW,YAAY;IAC3B,KAAK,EAAE;QAAE,UAAU,EAAE,MAAM,CAAC;QAAC,YAAY,EAAE,MAAM,CAAC;QAAC,QAAQ,EAAE,OAAO,CAAA;KAAE,CAAC;IACvE,KAAK,EAAE;QAAE,KAAK,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,MAAM,CAAA;KAAE,CAAC;IACxC,MAAM,EAAE;QAAE,YAAY,EAAE,OAAO,CAAC;QAAC,SAAS,EAAE,MAAM,CAAA;KAAE,CAAC;IACrD,SAAS,EAAE;QAAE,OAAO,EAAE,MAAM,CAAA;KAAE,CAAC;IAC/B,OAAO,EAAE;QAAE,SAAS,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,MAAM,EAAE,CAAA;KAAE,CAAC;IAChD,SAAS,EAAE;QAAE,UAAU,EAAE,MAAM,CAAA;KAAE,CAAC;IAClC,MAAM,EAAE;QAAE,OAAO,EAAE,OAAO,CAAA;KAAE,CAAC;IAC7B,SAAS,EAAE;QAAE,KAAK,EAAE,MAAM,CAAC;QAAC,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAA;KAAE,CAAC;IAC7D,UAAU,EAAE,MAAM,CAAC;CACpB;AAOD,wBAAsB,qBAAqB,CACzC,OAAO,SAAgB,GACtB,OAAO,CAAC,YAAY,CAAC,CA8DvB;AAED,wBAAsB,cAAc,IAAI,OAAO,CAAC;IAC9C,KAAK,EAAE,OAAO,CAAC;IACf,QAAQ,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,UAAU,EAAE,MAAM,CAAC;CACpB,CAAC,CAiBD;AAED,wBAAsB,iBAAiB,IAAI,OAAO,CAAC;IAAE,OAAO,EAAE,OAAO,CAAA;CAAE,CAAC,CAevE;AAED,wBAAsB,mBAAmB,CAAC,IAAI,CAAC,EAAE,MAAM,GAAG,OAAO,CAAC;IAChE,UAAU,EAAE,KAAK,CAAC;QAChB,IAAI,EAAE,MAAM,CAAC;QACb,QAAQ,EAAE,MAAM,CAAC;QACjB,MAAM,EAAE,MAAM,GAAG,IAAI,CAAC;QACtB,EAAE,EAAE,MAAM,CAAC;QACX,SAAS,EAAE,MAAM,CAAC;KACnB,CAAC,CAAC;CACJ,CAAC,CAsBD;AAED,wBAAgB,iBAAiB,IAAI;IAAE,SAAS,EAAE,MAAM,CAAC;IAAC,IAAI,EAAE,OAAO,CAAA;CAAE,CASxE"}

package/dist/commands/doctor.js

@@ -6,11 +6,12 @@ import { basename, dirname, extname, isAbsolute, join, relative, resolve, sep }
 import { spawnSync } from "node:child_process";
 import { fileURLToPath } from "node:url";
 import chalk from "chalk";
-import { DOCTOR_SCHEMA_VERSION, checkMcpHealth, loadPluginsWithDiagnostics, readMcpInventory, redactMcpInventory, } from "@devflow-tools/sdk";
+import { DOCTOR_SCHEMA_VERSION, checkMcpHealth, loadPluginsWithDiagnostics, readMcpInventory, redactMcpInventory, selectHostAdapter, } from "@devflow-tools/sdk";
 import { resolveActivePlugin, scanClaudeSkillShadowing } from "../lib/plugin-setup.js";
 import { serverStatus } from "./server.js";
 import { inspectSkillHealth } from "./skill-health.js";
 import { getGlobalDevFlowDbPath } from "@devflow-tools/database";
+import { inspectEmbeddingModel } from "@devflow-tools/memory-engine";
 function getProjectHash(rootPath) {
     return createHash("sha256").update(rootPath).digest("hex").slice(0, 16);
 }
@@ -47,6 +48,41 @@ function sectionStatus(metrics) {
 async function checkRuntimeControlPlane(project, dependencies) {
     const home = dependencies.homePath ?? homedir();
     const metrics = [];
+    const hostSelection = await selectHostAdapter({
+        projectRoot: project,
+        homeDir: home,
+        env: dependencies.env ?? process.env,
+        explicitHost: (dependencies.env ?? process.env).DEVFLOW_HOST_ADAPTER,
+    });
+    metrics.push({
+        key: "host_adapter",
+        value: hostSelection.status === "selected"
+            ? { id: hostSelection.adapter.id, candidates: hostSelection.candidates, explicit: hostSelection.explicit }
+            : {
+                status: "failed",
+                code: hostSelection.code,
+                candidates: hostSelection.candidates,
+                reason: hostSelection.reason,
+                action: hostSelection.action,
+            },
+        target: "one explicitly selected or uniquely detected host",
+        ok: hostSelection.status === "selected",
+        severity: "warning",
+    });
+    if (hostSelection.status === "selected") {
+        const capabilities = await hostSelection.adapter.capabilities({
+            projectRoot: project,
+            homeDir: home,
+            env: dependencies.env ?? process.env,
+        });
+        metrics.push({
+            key: "host_capabilities",
+            value: capabilities,
+            target: "unsupported capabilities have explicit degradation",
+            ok: capabilities.every(entry => entry.status === "supported" || Boolean(entry.reason && entry.fallback)),
+            severity: "error",
+        });
+    }
     const loaded = await loadPluginsWithDiagnostics({ projectRoot: project, homeDir: home });
     const failedPlugins = loaded.diagnostics.filter((diagnostic) => diagnostic.status === "failed");
     metrics.push({
@@ -56,7 +92,9 @@ async function checkRuntimeControlPlane(project, dependencies) {
         ok: failedPlugins.length === 0,
         severity: "warning",
     });
-    const inventory = redactMcpInventory(readMcpInventory(project, home));
+    const inventory = redactMcpInventory(readMcpInventory(project, home, {
+        env: dependencies.env ?? process.env,
+    }));
     metrics.push({
         key: "mcp_inventory",
         value: { servers: inventory.servers.length, duplicates: inventory.duplicates.length, unreadable: inventory.unreadable.length },
@@ -517,10 +555,64 @@ function doctorCount(db, sql, ...params) {
     const row = db.prepare(sql).get(...params);
     return Number(row?.count ?? 0);
 }
+function parseDoctorJson(value) {
+    if (typeof value !== "string")
+        return value;
+    try {
+        return JSON.parse(value);
+    }
+    catch {
+        return undefined;
+    }
+}
+function doctorRecord(value) {
+    return typeof value === "object" && value !== null && !Array.isArray(value)
+        ? value
+        : undefined;
+}
+function semanticToolOutcome(row) {
+    const output = doctorRecord(parseDoctorJson(row.output));
+    const data = doctorRecord(output?.data);
+    const status = typeof output?.status === "string" ? output.status : undefined;
+    const metricStatus = typeof row.metric_status === "string" ? row.metric_status : undefined;
+    const failed = Boolean(row.error)
+        || Boolean(row.failure_category)
+        || output?.ok === false
+        || output?.success === false
+        || output?.isError === true
+        || Boolean(output?.error)
+        || status === "failed"
+        || status === "rejected"
+        || metricStatus === "error";
+    const degraded = !failed && (output?.degraded === true
+        || Boolean(output?.degradation)
+        || data?.degraded === true
+        || status === "degraded"
+        || metricStatus === "degraded");
+    return { failed, degraded };
+}
+function fallbackReasons(value) {
+    const parsed = parseDoctorJson(value);
+    if (typeof parsed === "string" && parsed.trim())
+        return [parsed.trim()];
+    if (Array.isArray(parsed)) {
+        return parsed.filter((reason) => typeof reason === "string" && reason.trim().length > 0)
+            .map(reason => reason.trim());
+    }
+    const record = doctorRecord(parsed);
+    return record
+        ? Object.entries(record)
+            .filter(([, count]) => typeof count === "number" && count > 0)
+            .map(([reason]) => reason)
+        : [];
+}
+function rate(count, total) {
+    return total === 0 ? 0 : count / total;
+}
 function coverage(total, vectors) {
     return total === 0 ? 1 : vectors / total;
 }
-function checkVectors(project, dependencies) {
+async function checkVectors(project, dependencies) {
     const metrics = [];
     let codegraphNodes = null;
     let symbolVectors = null;
@@ -646,11 +738,18 @@ function checkVectors(project, dependencies) {
                 metrics.push({ key: "observation_vector_schema", value: "observations/embeddings missing", target: "Batch 2 vector schema", ok: false, severity: "warning" });
             }
             else {
-                const observations = doctorCount(db, "SELECT COUNT(*) count FROM observations");
+                const observationColumns = doctorTableColumns(db, "observations");
+                const hasEligibilityColumns = observationColumns.has("quality_status")
+                    && observationColumns.has("resolution_state");
+                const eligibilityClause = hasEligibilityColumns
+                    ? "WHERE quality_status = 'accepted' AND resolution_state <> 'superseded'"
+                    : "";
+                const observations = doctorCount(db, `SELECT COUNT(*) count FROM observations ${eligibilityClause}`);
                 const vectors = doctorCount(db, `
           SELECT COUNT(DISTINCT e.source_id) count
           FROM embeddings e JOIN observations o ON o.id = e.source_id
           WHERE e.source_type = 'observation'
+          ${hasEligibilityColumns ? "AND o.quality_status = 'accepted' AND o.resolution_state <> 'superseded'" : ""}
         `);
                 const missing = Math.max(0, observations - vectors);
                 metrics.push({ key: "observations", value: observations, ok: true, severity: "info" });
@@ -681,6 +780,49 @@ function checkVectors(project, dependencies) {
         }
     }
     metrics.push({ key: "embedder_errors_24h", value: recentErrors, target: 0, ok: recentErrors === 0, severity: "warning" });
+    try {
+        const model = await (dependencies.inspectEmbeddingModel ?? inspectEmbeddingModel)({
+            homeDir: dependencies.homePath,
+            env: dependencies.env ?? process.env,
+        });
+        metrics.push({
+            key: "embedding_model_state",
+            value: {
+                state: model.state,
+                modelId: model.modelId,
+                revision: model.revision,
+            },
+            target: { state: "ready" },
+            ok: model.ready,
+            severity: "warning",
+        });
+        metrics.push({
+            key: "embedding_model_cache_root",
+            value: model.cacheRoot,
+            target: "stable shared DevFlow cache",
+            ok: true,
+            severity: "info",
+        });
+        metrics.push({
+            key: "embedding_model_integrity",
+            value: {
+                missingFiles: model.missingFiles,
+                corruptFiles: model.corruptFiles,
+            },
+            target: { missingFiles: [], corruptFiles: [] },
+            ok: model.missingFiles.length === 0 && model.corruptFiles.length === 0,
+            severity: "warning",
+        });
+    }
+    catch (error) {
+        metrics.push({
+            key: "embedding_model_inspection",
+            value: error.message,
+            target: "readable verified shared model cache",
+            ok: false,
+            severity: "warning",
+        });
+    }
     return { name: "Vectors", status: sectionStatus(metrics), metrics };
 }
 function checkTelemetry(project, strict, dependencies) {
@@ -690,6 +832,7 @@ function checkTelemetry(project, strict, dependencies) {
         ? join(home, ".devflow", "global", "devflow.db")
         : getGlobalDevFlowDbPath(home);
     const cutoff = (dependencies.now ?? Date.now)() - 24 * 60 * 60 * 1000;
+    const now = (dependencies.now ?? Date.now)();
     const strictSeverity = strict ? "error" : "warning";
     if (!existsSync(globalDbPath)) {
         metrics.push({ key: "global_telemetry_db", value: "missing", target: globalDbPath, ok: false, severity: "warning" });
@@ -744,6 +887,67 @@ function checkTelemetry(project, strict, dependencies) {
                     ok: staleSessions === 0,
                     severity: "error",
                 });
+                const closureRows = db.prepare(`
+          SELECT status, COUNT(*) count
+          FROM sessions
+          WHERE project_root = ?
+          GROUP BY status
+        `).all(project);
+                const closureCounts = { running: 0, completed: 0, failed: 0 };
+                for (const row of closureRows) {
+                    if (row.status in closureCounts) {
+                        closureCounts[row.status] = Number(row.count);
+                    }
+                }
+                const totalSessions = closureCounts.running + closureCounts.completed + closureCounts.failed;
+                const closedSessions = closureCounts.completed + closureCounts.failed;
+                metrics.push({
+                    key: "project_session_closure_state",
+                    value: {
+                        total: totalSessions,
+                        ...closureCounts,
+                        closed: closedSessions,
+                        closureRate: totalSessions === 0 ? 1 : closedSessions / totalSessions,
+                    },
+                    target: "running sessions close through SessionEnd",
+                    ok: true,
+                    severity: "info",
+                });
+                if (doctorTableExists(db, "devflow_session_closures")) {
+                    const durableRows = db.prepare(`
+            SELECT state, COUNT(*) count
+            FROM devflow_session_closures
+            WHERE project_root = ?
+            GROUP BY state
+          `).all(project);
+                    const durable = { active: 0, closing: 0, closed: 0, closed_with_pending_work: 0 };
+                    for (const row of durableRows) {
+                        if (row.state in durable) {
+                            durable[row.state] = Number(row.count);
+                        }
+                    }
+                    const staleClosing = doctorCount(db, `
+            SELECT COUNT(*) count
+            FROM devflow_session_closures
+            WHERE project_root = ? AND state = 'closing' AND updated_at < ?
+          `, project, now - SESSION_STALE_MS);
+                    metrics.push({
+                        key: "durable_session_closure_state",
+                        value: { ...durable, staleClosing },
+                        target: { active: 0, closing: 0, staleClosing: 0 },
+                        ok: durable.active === 0 && durable.closing === 0 && staleClosing === 0,
+                        severity: strictSeverity,
+                    });
+                }
+                else {
+                    metrics.push({
+                        key: "durable_session_closure_state",
+                        value: "closure table missing",
+                        target: "active -> closing -> closed | closed_with_pending_work",
+                        ok: false,
+                        severity: strictSeverity,
+                    });
+                }
                 let orphanToolEvents = 0;
                 if (toolEventColumns.has("session_id")) {
                     orphanToolEvents = doctorCount(db, `
@@ -769,20 +973,172 @@ function checkTelemetry(project, strict, dependencies) {
                     ok: orphanToolEvents === 0 && orphanExecutions === 0,
                     severity: "error",
                 });
+                const staleExecutionSchemaReady = ["session_id", "status", "started_at"]
+                    .every(column => executionColumns.has(column));
+                if (staleExecutionSchemaReady) {
+                    const staleCutoff = now - 30 * 60 * 1000;
+                    const staleExecutions = db.prepare(`
+            SELECT
+              COUNT(*) total,
+              COALESCE(SUM(CASE WHEN execution.started_at < ? THEN 1 ELSE 0 END), 0) older_than_30m,
+              COALESCE(SUM(CASE WHEN session.status <> 'running' THEN 1 ELSE 0 END), 0) non_running_session
+            FROM skill_executions execution
+            JOIN sessions session ON session.id = execution.session_id
+            WHERE session.project_root = ?
+              AND execution.status = 'running'
+              AND (execution.started_at < ? OR session.status <> 'running')
+          `).get(staleCutoff, project, staleCutoff);
+                    const staleTotal = Number(staleExecutions?.total ?? 0);
+                    metrics.push({
+                        key: "stale_skill_executions",
+                        value: {
+                            total: staleTotal,
+                            olderThan30m: Number(staleExecutions?.older_than_30m ?? 0),
+                            attachedToNonRunningSession: Number(staleExecutions?.non_running_session ?? 0),
+                        },
+                        target: { total: 0 },
+                        ok: staleTotal === 0,
+                        severity: "error",
+                    });
+                }
+                else {
+                    metrics.push({
+                        key: "skill_execution_schema",
+                        value: "status, started_at, or session_id column missing",
+                        target: "canonical Skill execution lifecycle schema",
+                        ok: false,
+                        severity: "warning",
+                    });
+                }
+            }
+            if (!doctorTableExists(db, "devflow_work_items")) {
+                metrics.push({
+                    key: "work_queue_schema",
+                    value: "devflow_work_items table missing; queue diagnostics degraded",
+                    target: "canonical global work queue schema",
+                    ok: false,
+                    severity: "error",
+                });
+            }
+            else {
+                const queueColumns = doctorTableColumns(db, "devflow_work_items");
+                const requiredQueueColumns = [
+                    "project_root", "state", "lease_expires_at", "created_at", "completed_at",
+                ];
+                const missingQueueColumns = requiredQueueColumns.filter(column => !queueColumns.has(column));
+                if (missingQueueColumns.length > 0) {
+                    metrics.push({
+                        key: "work_queue_schema",
+                        value: { missingColumns: missingQueueColumns, diagnostic: "queue diagnostics degraded" },
+                        target: "canonical global work queue schema",
+                        ok: false,
+                        severity: "error",
+                    });
+                }
+                else {
+                    const queue = db.prepare(`
+            SELECT
+              COALESCE(SUM(CASE WHEN state IN ('pending', 'leased', 'failed') THEN 1 ELSE 0 END), 0) queue_depth,
+              COALESCE(SUM(CASE WHEN state = 'pending' THEN 1 ELSE 0 END), 0) pending,
+              COALESCE(SUM(CASE WHEN state = 'leased' THEN 1 ELSE 0 END), 0) leased,
+              COALESCE(SUM(CASE WHEN state = 'failed' THEN 1 ELSE 0 END), 0) failed,
+              COALESCE(SUM(CASE WHEN state = 'dead_letter' THEN 1 ELSE 0 END), 0) dead_letters,
+              COALESCE(SUM(CASE WHEN state = 'leased' AND lease_expires_at <= ? THEN 1 ELSE 0 END), 0) expired_leases,
+              MIN(CASE WHEN state IN ('pending', 'leased', 'failed') THEN created_at END) oldest_pending_at,
+              MAX(CASE WHEN state = 'completed' THEN completed_at END) last_successful_drain_at
+            FROM devflow_work_items
+            WHERE project_root = ?
+          `).get(now, project);
+                    const queueDepth = Number(queue?.queue_depth ?? 0);
+                    const pending = Number(queue?.pending ?? 0);
+                    const leased = Number(queue?.leased ?? 0);
+                    const failed = Number(queue?.failed ?? 0);
+                    const deadLetters = Number(queue?.dead_letters ?? 0);
+                    const expiredLeases = Number(queue?.expired_leases ?? 0);
+                    const oldestPendingAt = queue?.oldest_pending_at == null
+                        ? undefined
+                        : Number(queue.oldest_pending_at);
+                    const lastSuccessfulDrainAt = queue?.last_successful_drain_at == null
+                        ? undefined
+                        : Number(queue.last_successful_drain_at);
+                    metrics.push({ key: "work_queue_schema", value: "canonical", target: "canonical global work queue schema", ok: true, severity: "info" });
+                    metrics.push({ key: "work_queue_depth", value: queueDepth, ok: true, severity: "info" });
+                    metrics.push({ key: "work_queue_pending", value: pending, ok: true, severity: "info" });
+                    metrics.push({ key: "work_queue_leased", value: leased, ok: true, severity: "info" });
+                    metrics.push({ key: "work_queue_failed", value: failed, target: 0, ok: failed === 0, severity: "warning" });
+                    metrics.push({
+                        key: "work_queue_oldest_pending_age_ms",
+                        value: oldestPendingAt === undefined ? 0 : Math.max(0, now - oldestPendingAt),
+                        ok: true,
+                        severity: "info",
+                    });
+                    metrics.push({ key: "work_queue_dead_letters", value: deadLetters, target: 0, ok: deadLetters === 0, severity: "error" });
+                    metrics.push({ key: "work_queue_expired_leases", value: expiredLeases, target: 0, ok: expiredLeases === 0, severity: "error" });
+                    metrics.push({ key: "work_queue_last_successful_drain_at", value: lastSuccessfulDrainAt ?? null, ok: true, severity: "info" });
+                }
             }
+            const hookStateDir = dependencies.env?.DEVFLOW_STATE_DIR
+                ?? join(home, ".devflow", "state", getProjectHash(project));
+            const spoolKinds = ["session-start-pending", "memory-turn-pending", "session-finalize-pending"];
+            const spoolBacklog = Object.fromEntries(spoolKinds.map(kind => {
+                const directory = join(hookStateDir, kind);
+                const count = existsSync(directory)
+                    ? readdirSync(directory).filter(name => name.includes(".json")).length
+                    : 0;
+                return [kind, count];
+            }));
+            const totalSpoolBacklog = Object.values(spoolBacklog).reduce((sum, count) => sum + count, 0);
+            metrics.push({
+                key: "hook_spool_backlog",
+                value: { total: totalSpoolBacklog, ...spoolBacklog },
+                target: { total: 0 },
+                ok: totalSpoolBacklog === 0,
+                severity: strictSeverity,
+            });
             if (doctorTableExists(db, "tool_call_events")) {
+                const canProjectFilterEvents = sessionSchemaReady && toolEventColumns.has("session_id");
+                const metricColumns = doctorTableColumns(db, "tool_metrics");
+                const canJoinMetrics = toolEventColumns.has("event_id")
+                    && metricColumns.has("tool_call_event_id")
+                    && metricColumns.has("status");
+                const selectedColumns = [
+                    toolEventColumns.has("error") ? "event.error" : "NULL error",
+                    toolEventColumns.has("failure_category") ? "event.failure_category" : "NULL failure_category",
+                    toolEventColumns.has("output") ? "event.output" : "NULL output",
+                    canJoinMetrics ? "metric.status metric_status" : "NULL metric_status",
+                ].join(", ");
+                const eventRows = db.prepare(`
+          SELECT ${selectedColumns}
+          FROM tool_call_events event
+          ${canJoinMetrics ? "LEFT JOIN tool_metrics metric ON metric.tool_call_event_id = event.event_id" : ""}
+          ${canProjectFilterEvents ? "JOIN sessions event_session ON event_session.id = event.session_id" : ""}
+          WHERE event.timestamp >= ?
+          ${canProjectFilterEvents ? "AND event_session.project_root = ?" : ""}
+        `).all(...(canProjectFilterEvents ? [cutoff, project] : [cutoff]));
+                const semantic = eventRows.map(semanticToolOutcome);
+                const semanticFailures = semantic.filter(outcome => outcome.failed).length;
+                const semanticDegradations = semantic.filter(outcome => outcome.degraded).length;
+                metrics.push({ key: "semantic_tool_calls_24h", value: eventRows.length, ok: true, severity: "info" });
+                metrics.push({ key: "semantic_tool_failures_24h", value: semanticFailures, target: 0, ok: semanticFailures === 0, severity: strictSeverity });
+                metrics.push({ key: "semantic_tool_degradations_24h", value: semanticDegradations, target: 0, ok: semanticDegradations === 0, severity: strictSeverity });
+                metrics.push({ key: "semantic_tool_failure_rate_24h", value: rate(semanticFailures, eventRows.length), target: 0, ok: semanticFailures === 0, severity: strictSeverity });
+                metrics.push({ key: "semantic_tool_degradation_rate_24h", value: rate(semanticDegradations, eventRows.length), target: 0, ok: semanticDegradations === 0, severity: strictSeverity });
+                metrics.push({
+                    key: "semantic_tool_project_scope",
+                    value: canProjectFilterEvents ? "project" : "global fallback; session identity unavailable",
+                    target: "project",
+                    ok: canProjectFilterEvents,
+                    severity: "warning",
+                });
                 if (toolEventColumns.has("failure_category")) {
-                    const rows = db.prepare(`
-            SELECT failure_category category, COUNT(*) count
-            FROM tool_call_events
-            WHERE timestamp >= ? AND failure_category IS NOT NULL
-            GROUP BY failure_category
-            ORDER BY failure_category
-          `).all(cutoff);
-                    const distribution = Object.fromEntries(rows.map(row => [row.category, Number(row.count)]));
-                    const failedEvents = doctorCount(db, "SELECT COUNT(*) count FROM tool_call_events WHERE timestamp >= ? AND error IS NOT NULL", cutoff);
-                    const classifiedEvents = rows.reduce((sum, row) => sum + Number(row.count), 0);
-                    const classificationCoverage = failedEvents === 0 ? 1 : classifiedEvents / failedEvents;
+                    const distribution = {};
+                    for (const row of eventRows) {
+                        if (typeof row.failure_category !== "string" || !row.failure_category.trim())
+                            continue;
+                        distribution[row.failure_category] = (distribution[row.failure_category] ?? 0) + 1;
+                    }
+                    const classifiedEvents = Object.values(distribution).reduce((sum, count) => sum + count, 0);
+                    const classificationCoverage = semanticFailures === 0 ? 1 : classifiedEvents / semanticFailures;
                     metrics.push({
                         key: "failure_categories_24h",
                         value: distribution,
@@ -807,6 +1163,42 @@ function checkTelemetry(project, strict, dependencies) {
                     });
                 }
             }
+            const skillFallbackSchemaReady = sessionSchemaReady
+                && ["session_id", "started_at", "fallback_count", "fallback_reasons"]
+                    .every(column => executionColumns.has(column));
+            let skillFallbackCount = 0;
+            const fallbackReasonCounts = {};
+            if (skillFallbackSchemaReady) {
+                const rows = db.prepare(`
+          SELECT execution.fallback_count, execution.fallback_reasons
+          FROM skill_executions execution
+          JOIN sessions session ON session.id = execution.session_id
+          WHERE session.project_root = ? AND execution.started_at >= ?
+        `).all(project, cutoff);
+                for (const row of rows) {
+                    skillFallbackCount += Number(row.fallback_count ?? 0);
+                    for (const reason of fallbackReasons(row.fallback_reasons)) {
+                        fallbackReasonCounts[reason] = (fallbackReasonCounts[reason] ?? 0) + 1;
+                    }
+                }
+            }
+            let hookFallbackCount = 0;
+            if (doctorTableExists(db, "devflow_hook_fallbacks")) {
+                const rows = db.prepare(`
+          SELECT reason, COUNT(*) count
+          FROM devflow_hook_fallbacks
+          WHERE project_root = ? AND created_at >= ?
+          GROUP BY reason ORDER BY reason
+        `).all(project, cutoff);
+                for (const row of rows) {
+                    const count = Number(row.count);
+                    hookFallbackCount += count;
+                    fallbackReasonCounts[`hook:${row.reason}`] = count;
+                }
+            }
+            metrics.push({ key: "skill_fallbacks_24h", value: skillFallbackCount, target: 0, ok: skillFallbackCount === 0, severity: "warning" });
+            metrics.push({ key: "hook_fallbacks_24h", value: hookFallbackCount, target: 0, ok: hookFallbackCount === 0, severity: "warning" });
+            metrics.push({ key: "fallback_reasons_24h", value: fallbackReasonCounts, target: {}, ok: Object.keys(fallbackReasonCounts).length === 0, severity: "warning" });
         }
         catch (error) {
             metrics.push({ key: "global_telemetry_db_read", value: error.message, target: "readable SQLite database", ok: false, severity: "error" });
@@ -4226,7 +4618,7 @@ export async function runStructuredDoctor(options = {}, dependencies = {}) {
         checkIsolation(requestedProject, dependencies),
         checkDistill(canonical.path, dependencies),
         checkLegacyPaths(canonical.path, dependencies),
-        checkVectors(canonical.path, dependencies),
+        await checkVectors(canonical.path, dependencies),
         checkTelemetry(canonical.path, Boolean(options.strict), dependencies),
         checkInjection(canonical.path, dependencies),
         checkMemoryQuality(canonical.path, dependencies),