@devdogsuga/devtools 0.1.44 → 0.1.46

package/dist/{cli-B_AiECh4.js → cli-CTw2q3TP.js}

@@ -121,7 +121,7 @@ async function checkEnv(root) {
 			"PLATFORM_SENTRY_DSN",
 			"PUBLISHABLE_KEY",
 			"SCHEDULE_BUILDER_SENTRY_DSN"
-		];
+		].filter((key) => registry.has(key));
 		if (JSON.stringify(build) !== JSON.stringify(expectedBuild)) problems.push(`The build set is [${build.join(", ")}]; expected exactly [${expectedBuild.join(", ")}]. A change here changes what the build workflows read from \`<tier>-build\`: update both deliberately.`);
 		for (const key of build) if (!variableSet.has(key)) problems.push(`${key} is build: true but is not in variableKeys(), so push cannot write it to the build environment.`);
 	}
@@ -223,6 +223,8 @@ function git$1(root, args) {
 function basenames(output) {
 	return output.split("\n").map((line) => line.trim()).filter(Boolean).map((path) => path.split("/").at(-1));
 }
+/** `baseRef` names nothing in the repo being checked. */
+var MigrationBaseError = class extends Error {};
 /**
 * Reads the two file lists from git and runs the pure check.
 *
@@ -233,6 +235,16 @@ function basenames(output) {
 * an edit to an existing migration, both legitimate, does not trip this.
 */
 function checkMigrationOrder(root, baseRef) {
+	try {
+		git$1(root, [
+			"rev-parse",
+			"--verify",
+			"--quiet",
+			`${baseRef}^{commit}`
+		]);
+	} catch {
+		throw new MigrationBaseError(`${baseRef} is not a commit in ${root}. Migrations live in DevDogsUGA, so the base is a ref of that checkout (a Backstage CI checkout has only the pinned commit): pass --base <ref>, e.g. the previous devdogsuga.lock SHA.`);
+	}
 	const baseFiles = basenames(git$1(root, [
 		"ls-tree",
 		"-r",
@@ -379,6 +391,14 @@ function deployMatrixApps(yamlText) {
 	}
 	return blocks;
 }
+/**
+* Apps with a `wrangler.jsonc` that are deliberately NOT in `workers.json`:
+* `workers.json` is the managed set (deploy matrix, smoke tests, env registry,
+* secret orphan sweep), and these are deployed by hand and have none of that.
+* `apps/slides` is the hosted workshop deck, shipped with `pnpm run deploy`
+* from its own directory (its `wrangler.jsonc` says so).
+*/
+const HAND_DEPLOYED_APPS = ["apps/slides"];
 function sameSet(a, b) {
 	return a.length === b.length && a.every((item) => b.includes(item));
 }
@@ -409,7 +429,7 @@ function checkWorkers(root, layout = layoutAt(root)) {
 	}))];
 	const dirOf = (relative) => join(roots.find((dir) => existsSync(join(dir, relative))) ?? root, relative);
 	const withWrangler = scanned.filter((relative) => existsSync(join(dirOf(relative), "wrangler.jsonc")));
-	for (const path of withWrangler.filter((p) => !paths.includes(p))) problems.push(`${path} has a wrangler.jsonc but is not in workers.json.`);
+	for (const path of withWrangler.filter((p) => !paths.includes(p) && !HAND_DEPLOYED_APPS.includes(p))) problems.push(`${path} has a wrangler.jsonc but is not in workers.json.`);
 	for (const path of paths.filter((p) => !withWrangler.includes(p))) problems.push(`workers.json lists ${path}, which has no wrangler.jsonc.`);
 	for (const path of paths) {
 		const manifest = join(dirOf(path), "package.json");
@@ -453,6 +473,13 @@ function checkWorkers(root, layout = layoutAt(root)) {
 * beside it and a Vitest `test` needs a `test:watch`.
 *
 * The root package also carries the CLI runners (`devtools`, `backstage`).
+*
+* A repo can allow a name outside the vocabulary, with a reason, in the root
+* `package.json`: `"devdogs": { "scriptExceptions": { "<package>#<script>":
+* "<why>" } }`, where `<package>` is the package's name (`root` for the root
+* package). The exception also covers the script's `pre`/`post` hooks.
+* Exceptions that match no script are themselves a problem, so the list
+* cannot rot.
 */
 const FIXED = /* @__PURE__ */ new Set([
 	"dev",
@@ -508,18 +535,29 @@ function isAllowedScript(name, isRoot = false) {
 	return pre?.[2] !== void 0 && isAllowedName(pre[2]);
 }
 /** One readable line per violation. Empty means the vocabulary holds. */
-function checkScriptVocabulary(packages) {
+function checkScriptVocabulary(packages, exceptions = {}) {
 	const problems = [];
-	for (const { dir, scripts } of packages) {
+	const used = /* @__PURE__ */ new Set();
+	for (const { dir, name: packageName, scripts } of packages) {
 		const names = Object.keys(scripts);
+		const owner = dir === "." ? "root" : packageName;
 		for (const name of names) {
 			if (isAllowedScript(name, dir === ".")) continue;
+			const excepted = [name, /^(?:pre|post)(.+)$/.exec(name)?.[1]].find((candidate) => candidate && `${owner}#${candidate}` in exceptions);
+			if (excepted) {
+				used.add(`${owner}#${excepted}`);
+				continue;
+			}
 			const replacement = BANNED[name];
 			problems.push(`${dir}: script "${name}" is not in the vocabulary` + (replacement ? ` (${replacement}).` : "."));
 		}
 		if (names.includes("lint") && !names.includes("lint:fix")) problems.push(`${dir}: has "lint" but no "lint:fix".`);
 		if (/\bvitest\b/.test(scripts.test ?? "") && !names.includes("test:watch")) problems.push(`${dir}: runs Vitest in "test" but has no "test:watch".`);
 	}
+	for (const key of Object.keys(exceptions)) {
+		if (used.has(key)) continue;
+		if (!packages.some(({ dir, name, scripts }) => `${dir === "." ? "root" : name}#` === key.slice(0, key.indexOf("#") + 1) && key.slice(key.indexOf("#") + 1) in scripts)) problems.push(`scriptExceptions: "${key}" matches no script.`);
+	}
 	return problems;
 }
 /** The root and every workspace package's scripts. */
@@ -537,8 +575,14 @@ function readScriptPackages(root) {
 	const workspace = join(root, "pnpm-workspace.yaml");
 	return [".", ...existsSync(workspace) ? expandWorkspacePackages(root, workspaceGlobs(readFileSync(workspace, "utf8"))) : []].map(read).filter((pkg) => pkg !== null);
 }
+/** The root manifest's `devdogs.scriptExceptions`, empty when it has none. */
+function readScriptExceptions(root) {
+	const file = join(root, "package.json");
+	if (!existsSync(file)) return {};
+	return JSON.parse(readFileSync(file, "utf8")).devdogs?.scriptExceptions ?? {};
+}
 function checkScripts(root) {
-	return checkScriptVocabulary(readScriptPackages(root));
+	return checkScriptVocabulary(readScriptPackages(root), readScriptExceptions(root));
 }
 //#endregion
 //#region src/check/commands.ts
@@ -561,7 +605,14 @@ function report(name, problems, ok) {
 }
 function migrations(rest) {
 	const base = flagValue(rest, "--base") ?? DEFAULT_BASE;
-	const { baseLatest, violations } = checkMigrationOrder(resolveLayout().devdogsugaRoot, base);
+	let result;
+	try {
+		result = checkMigrationOrder(resolveLayout().devdogsugaRoot, base);
+	} catch (error) {
+		if (!(error instanceof MigrationBaseError)) throw error;
+		return report("migrations", [error.message], "");
+	}
+	const { baseLatest, violations } = result;
 	return report("migrations", violations.map((v) => `${v.filename} (${v.timestamp}) sorts before ${base}'s newest migration (${baseLatest}). Recreate it with a fresh timestamp (\`devtools new-migration\`) and regenerate types.`), `in order (${base}'s newest: ${baseLatest ?? "none"}).`);
 }
 async function run(rest) {

package/dist/launch.js

@@ -166,7 +166,7 @@ async function startStack() {
 * post-tier-resolution path.
 */
 async function dispatch(argv) {
-	const { main } = await import("./cli-B_AiECh4.js");
+	const { main } = await import("./cli-CTw2q3TP.js");
 	try {
 		await main(argv);
 	} catch (err) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@devdogsuga/devtools",
-  "version": "0.1.44",
+  "version": "0.1.46",
   "private": false,
   "type": "module",
   "description": "Contributor CLI for a DevDogsUGA checkout: the real tools with the session's tier filled in, a menu over them, and the checks CI runs. Ships built JS; run via `pnpm dlx @devdogsuga/devtools` (or the `devtools` bin once installed) from inside a DevDogsUGA clone.",
@@ -52,10 +52,10 @@
     "tsdown": "^0.23.0",
     "vitest": "^4.1.11",
     "@devdogsuga/config": "0.1.3",
-    "@devdogsuga/cli-core": "0.0.0",
     "@devdogsuga/db": "0.1.5",
     "@devdogsuga/env": "0.1.8",
-    "@devdogsuga/telemetry": "0.1.5"
+    "@devdogsuga/telemetry": "0.1.5",
+    "@devdogsuga/cli-core": "0.0.0"
   },
   "scripts": {
     "build": "tsdown && node scripts/write-build-info.mjs && node ../../scripts/check-bundle-imports.mjs",