@dev.fast/whiteboard 0.5.2-preview.20261104.147 → 0.5.2-preview.20261109.149

package/dist/{stored-document-migration-vg0NAzXG.js → stored-document-migration-BQcUyXO8.js}

@@ -1,82 +1,13 @@
 import { C as renderVcsArgs, v as parseGitRemote, w as runVcs } from "./src-Y30gweiK.js";
 import { d as isBooleanValue, f as isNumberValue, l as jsonValueSchema, m as isStringValue, n as isJsonObject } from "./src-X9phtB2j.js";
-import { C as respellLinks, H as lensTargetsSchema, W as label, et as formatAnchor, ot as unionIntervals, st as ReviewInputError } from "./src-DirPN_Qh.js";
-import "./src-B-91Rd2d.js";
-import "./review-home-paths-BmZX2qiz.js";
+import { E as respellLinks, G as lensTargetsSchema, X as label, at as formatAnchor, mt as ReviewInputError } from "./src-BPrngiWX.js";
+import "./review-home-paths-B8909D07.js";
 import { t as errorMessage } from "./error-message-OtiDonty.js";
+import "./src-B-91Rd2d.js";
 import { randomUUID } from "node:crypto";
 import { z } from "zod";
 import { execFile } from "node:child_process";
 import { promisify } from "node:util";
-//#region src/viewed-coverage.ts
-const coverageSchema = z.object({
-	base: z.array(z.tuple([z.number().int().nonnegative(), z.number().int().nonnegative()])),
-	head: z.array(z.tuple([z.number().int().nonnegative(), z.number().int().nonnegative()]))
-});
-const emptyCoverage = () => ({
-	base: [],
-	head: []
-});
-function intersectIntervals(left, right) {
-	const result = [];
-	const a = unionIntervals(left), b = unionIntervals(right);
-	let i = 0, j = 0;
-	while (i < a.length && j < b.length) {
-		const start = Math.max(a[i][0], b[j][0]), end = Math.min(a[i][1], b[j][1]);
-		if (start < end) result.push([start, end]);
-		if (a[i][1] < b[j][1]) i++;
-		else j++;
-	}
-	return result;
-}
-function subtractIntervals(left, right) {
-	const result = [];
-	const removed = unionIntervals(right);
-	for (const [start, end] of unionIntervals(left)) {
-		let cursor = start;
-		for (const [from, to] of removed) {
-			if (to <= cursor) continue;
-			if (from >= end) break;
-			if (from > cursor) result.push([cursor, from]);
-			cursor = Math.min(end, Math.max(cursor, to));
-		}
-		if (cursor < end) result.push([cursor, end]);
-	}
-	return result;
-}
-function updateCoverage(current, scope, viewed) {
-	const apply = (side) => viewed ? unionIntervals([...current[side], ...scope[side]]) : subtractIntervals(current[side], scope[side]);
-	return {
-		base: apply("base"),
-		head: apply("head")
-	};
-}
-function scopedCoverage(file, sources) {
-	if (!sources) return file.changed;
-	const side = (side) => intersectIntervals(file.changed[side], sources.flatMap((source) => source.side === side && source.file === (side === "base" ? file.previousPath ?? file.path : file.path) ? [[source.fromLine - 1, source.toLine]] : []));
-	return {
-		base: side("base"),
-		head: side("head")
-	};
-}
-/** Each file's own sources, grouped once. */
-function sourcesForFile(sources) {
-	if (!sources) return () => void 0;
-	const byFile = Map.groupBy(sources, (source) => source.file);
-	return (file) => {
-		const base = byFile.get(file.previousPath ?? file.path) ?? [];
-		return file.previousPath && file.previousPath !== file.path ? [...base, ...byFile.get(file.path) ?? []] : base;
-	};
-}
-function coverageSources(file, coverage = file.viewed) {
-	return ["base", "head"].flatMap((side) => coverage[side].map(([start, end]) => ({
-		side,
-		file: side === "base" ? file.previousPath ?? file.path : file.path,
-		fromLine: start + 1,
-		toLine: end
-	})));
-}
-//#endregion
 //#region src/evidence.ts
 /** Quote matching shared by legacy publish and JSON accept: authors paste
 * transcript text with arbitrary line wrapping, so both sides compare on
@@ -1254,4 +1185,4 @@ function liftFileLenses(document) {
 	};
 }
 //#endregion
-export { emptyCoverage as C, subtractIntervals as D, sourcesForFile as E, updateCoverage as O, coverageSources as S, scopedCoverage as T, fetchPullRequest as _, SoftwareModelValidationError as a, textIncludesQuote as b, traceSchema as c, setPullRequest as d, sourceBranchName as f, defaultPullRequestDeps as g, GitHubRefusedRead as h, readStoredDocument as i, pullRequestKey as l, resolvePullRequest as m, migrateStoredDocument as n, defineSoftwareMap as o, pullRequestProvider as p, migrateStoredLenses as r, softwareModelDataSchema as s, liftFileLenses as t, pullRequestUrl as u, remoteUrls as v, intersectIntervals as w, coverageSchema as x, azureRepositoryOf as y };
+export { fetchPullRequest as _, SoftwareModelValidationError as a, textIncludesQuote as b, traceSchema as c, setPullRequest as d, sourceBranchName as f, defaultPullRequestDeps as g, GitHubRefusedRead as h, readStoredDocument as i, pullRequestKey as l, resolvePullRequest as m, migrateStoredDocument as n, defineSoftwareMap as o, pullRequestProvider as p, migrateStoredLenses as r, softwareModelDataSchema as s, liftFileLenses as t, pullRequestUrl as u, remoteUrls as v, azureRepositoryOf as y };

package/dist/{tool-failure-BLBwcl3H.js → tool-failure-Cgjidoud.js}

@@ -1,10 +1,10 @@
 import { m as isStringValue, n as isJsonObject, u as parseJsonText } from "./src-X9phtB2j.js";
-import { M as checkReferences, j as blocks, st as ReviewInputError } from "./src-DirPN_Qh.js";
-import { l as boardTitle } from "./src-B-91Rd2d.js";
-import "./review-home-paths-BmZX2qiz.js";
-import { n as callAuthoringTool, s as ReviewApiError, t as ToolText } from "./agent-client-BFtYm3Ng.js";
+import { F as checkReferences, P as blocks, mt as ReviewInputError } from "./src-BPrngiWX.js";
 import { N as devReviewHome } from "./s3-config-CjcLyFV5.js";
-import { t as findReviewPackageRoot } from "./package-paths-Dk7MOXxN.js";
+import "./review-home-paths-B8909D07.js";
+import { t as findReviewPackageRoot } from "./package-paths-wobHueCx.js";
+import { l as boardTitle } from "./src-B-91Rd2d.js";
+import { n as callAuthoringTool, s as ReviewApiError, t as ToolText } from "./agent-client-CgnEo6lf.js";
 import { m as isMissingFileError } from "./thread-state-Jxoh1hde.js";
 import { createHash } from "node:crypto";
 import { z } from "zod";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dev.fast/whiteboard",
-  "version": "0.5.2-preview.20261104.147",
+  "version": "0.5.2-preview.20261109.149",
   "private": false,
   "license": "MIT",
   "repository": {
@@ -53,7 +53,6 @@
     "mdast-util-gfm": "3.1.0",
     "mdast-util-math": "3.0.0",
     "micromark-extension-gfm": "3.0.0",
-    "minimatch": "10.2.6",
     "pi-acp": "0.0.34",
     "pino": "10.3.1",
     "semver": "7.8.5",
@@ -76,12 +75,12 @@
     "tsx": "4.21.0",
     "typescript": "6.0.3",
     "vitest": "4.1.12",
-    "@dev.fast/review-protocol": "0.0.0",
     "@dev.fast/json": "0.0.0",
-    "@dev.fast/review-share-protocol": "0.6.0",
     "@dev.fast/trace-core": "0.0.0",
+    "@dev.fast/review-share-protocol": "0.6.0",
     "@dev.fast/trace-protocol": "0.5.0",
-    "@dev.fast/whiteboard-document": "0.2.2"
+    "@dev.fast/review-protocol": "0.0.0",
+    "@dev.fast/whiteboard-document": "0.3.0"
   },
   "engines": {
     "node": ">=24 <25"
@@ -91,7 +90,7 @@
     "repo": "devdotfast/review",
     "docs": "packages/review/instructions/authoring.md"
   },
-  "gitHead": "07deb9e521a2e372643d2d13350f9868b41fd264",
+  "gitHead": "4c0a0af9c57fe774cc885574b7e4236309456dc1",
   "scripts": {
     "prebuild": "pnpm run build:workspace-deps",
     "build": "node --max-old-space-size=8192 node_modules/tsdown/dist/run.mjs",

package/src/review-api/comparison-coverage.ts

@@ -9,20 +9,18 @@ import {
 } from "@dev.fast/review-protocol";
 import {
   type AlignmentRow,
-  type FileLineRange,
-  type Pins,
-  patchRows,
-} from "@dev.fast/whiteboard-document";
-import { parseUnifiedPatch } from "@review/unified-diff.js";
-import {
   type Coverage,
   type CoverageFile,
+  type FileLineRange,
   type LineInterval,
+  type Pins,
   emptyCoverage,
   intersectIntervals,
+  patchChanges,
+  patchRows,
   subtractIntervals,
   unionIntervals,
-} from "@review/viewed-coverage.js";
+} from "@dev.fast/whiteboard-document";
 
 import type { LocalReviewData } from "./local-data.js";
 
@@ -60,19 +58,7 @@ export async function comparisonCoverage(
       patches?.get(file.path) ??
       (await data.changes(pins, file.path, file.previousPath));
 
-    const changed = emptyCoverage();
-
-    for (const hunk of parseUnifiedPatch(file.path, patch))
-      for (const line of hunk.lines) {
-        if (line.kind === "add")
-          changed.head.push([line.newLine! - 1, line.newLine!]);
-
-        if (line.kind === "remove")
-          changed.base.push([line.oldLine! - 1, line.oldLine!]);
-      }
-
-    changed.base = unionIntervals(changed.base);
-    changed.head = unionIntervals(changed.head);
+    const changed = patchChanges(file.path, patch);
 
     const [base, head] = await Promise.all([
       file.status === "added"

package/src/review-api/http.ts

@@ -25,8 +25,12 @@ import { errorMessage } from "@dev.fast/trace-core";
 import {
   ReviewInputError,
   type ReviewTarget,
+  type UncategorizedReport,
   boardRepositoryId,
   elements,
+  lensReport,
+  scopedCoverage,
+  uncategorizedReport,
 } from "@dev.fast/whiteboard-document";
 import {
   type AgentSelection,
@@ -63,7 +67,6 @@ import {
 } from "@review/sharing/host.js";
 import { forgetSharedCommits } from "@review/sharing/repository.js";
 import type { ReviewSessionAgent } from "@review/ui-telemetry-events.js";
-import { scopedCoverage } from "@review/viewed-coverage.js";
 import { type Context, Hono, type MiddlewareHandler } from "hono";
 import { z } from "zod";
 
@@ -91,12 +94,9 @@ import {
   reviewRequestOrigin,
 } from "./request-origin.js";
 import {
-  type UncategorizedReport,
   legacyModeSchema,
-  lensReport,
   progressUpdateSchema,
   reviewProgress,
-  uncategorizedReport,
 } from "./review-progress.js";
 import {
   type Author,
@@ -456,12 +456,16 @@ export function createReviewApi(
 
     const snapshot = readReview(context.req.param("id"));
 
+    const progress = await reviewProgress(
+      store,
+      data,
+      snapshot,
+      context.req.raw.signal,
+    );
+
     return context.json({
       version: snapshot.version,
-      ...lensReport(
-        snapshot.lenses ?? [],
-        await reviewProgress(store, data, snapshot, context.req.raw.signal),
-      ),
+      ...lensReport(snapshot.lenses ?? [], progress.lenses, progress.files),
     });
   });
   app.get("/status", async (context) =>
@@ -2155,15 +2159,15 @@ export function createReviewApi(
     if (!data) return {};
 
     try {
+      const progress = await reviewProgress(
+        store,
+        data,
+        store.read(reviewId, version),
+        request.signal,
+      );
+
       return {
-        uncategorized: uncategorizedReport(
-          await reviewProgress(
-            store,
-            data,
-            store.read(reviewId, version),
-            request.signal,
-          ),
-        ),
+        uncategorized: uncategorizedReport(progress.lenses, progress.files),
       };
     } catch (error) {
       return {

package/src/review-api/review-progress.ts

@@ -1,9 +1,9 @@
 import {
-  type DiffLens,
+  type CoverageFile,
   type FileLineRange,
-  type Lens,
   type LensSource,
   type Pins,
+  type ResolvedLens,
   ReviewInputError,
   SelectionUnavailableError,
   type SelectionUnavailableReason,
@@ -11,22 +11,18 @@ import {
   anchorPins,
   boardRepositoryId,
   comparisonKey,
+  emptyCoverage,
   fileLineRangeSchema,
   lensSelections,
   patchRows,
   resolveDiffSelection,
+  resolveLenses,
   selectionKey,
   selectionReferences,
 } from "@dev.fast/whiteboard-document";
-import { type CoverageFile, emptyCoverage } from "@review/viewed-coverage.js";
 import { z } from "zod";
 
 import type { ComparisonCoverage } from "./comparison-coverage.js";
-import {
-  changedPath,
-  resolveFileLens,
-  uncategorizedSources,
-} from "./file-lenses.js";
 import type { LocalReviewData } from "./local-data.js";
 import type { ReviewStore, Snapshot } from "./store.js";
 
@@ -60,7 +56,7 @@ export interface ReviewProgress {
   referenceFiles?: Record<string, Record<string, CoverageFile>>;
   resolvedSelections: Record<string, FileLineRange[]>;
   /** The review's file lenses, then the automatic "Uncategorized changes". */
-  lenses: (DiffLens & { unavailable?: string; pending?: boolean })[];
+  lenses: (ResolvedLens & { pending?: boolean })[];
   /** Untracked files a live worktree review leaves out of its comparison. */
   untrackedFiles?: number;
 }
@@ -243,40 +239,17 @@ export async function reviewProgress(
     }
   };
 
-  const lenses: ReviewProgress["lenses"] = await Promise.all(
+  // Explicit ranges use the same pin validation as diagram evidence.
+  await Promise.all(
     (snapshot.lenses ?? []).map(async (authored) => {
-      const lens = { id: authored.id, title: authored.title };
-
       try {
-        // Explicit ranges use the same pin validation as diagram evidence.
         await Promise.all(
           lensSelections([authored]).map(({ source }) =>
             resolveAvailable(source),
           ),
         );
-
-        const resolved = resolveFileLens(
-          authored,
-          files,
-          fileSources,
-          (source) => resolvedSelections[selectionKey(source)] ?? [],
-        );
-
-        return {
-          ...lens,
-          ...resolved,
-          pending: counting,
-          unavailable:
-            counting || resolved.fileCount
-              ? undefined
-              : "No files match these targets",
-        };
       } catch {
-        return {
-          ...lens,
-          sources: [],
-          unavailable: "Source links need updating at these pins",
-        };
+        /* resolveLenses reports a lens whose anchors don't parse. */
       }
     }),
   );
@@ -295,27 +268,19 @@ export async function reviewProgress(
     }),
   );
 
-  const uncategorized = counting
-    ? []
-    : uncategorizedSources(
-        files,
-        lenses
-          .filter((lens) => !lens.unavailable)
-          .flatMap((lens) => lens.sources),
-      );
-
-  lenses.push({
-    id: UNCATEGORIZED_LENS_ID,
-    title: "Uncategorized changes",
-    sources: uncategorized,
-    wholeFiles: false,
-    fileCount: new Set(uncategorized.map(changedPath(files))).size,
-    pending: counting,
-    unavailable:
-      counting || uncategorized.length
-        ? undefined
-        : "All changed lines are covered by lenses",
-  });
+  const lenses = pendingLenses(
+    resolveLenses(
+      snapshot.lenses ?? [],
+      files,
+      fileSources,
+      (source) =>
+        unavailableSelections[selectionKey(source)]
+          ? undefined
+          : (resolvedSelections[selectionKey(source)] ?? []),
+      { nocase: process.platform === "darwin" || process.platform === "win32" },
+    ),
+    counting,
+  );
 
   const progress: ReviewProgress = {
     complete: !counting && !pendingSources.size,
@@ -333,71 +298,21 @@ export async function reviewProgress(
   return progress;
 }
 
-/** The most files an uncategorized report names; the rest are counted. */
-const REPORT_FILES = 50;
-
-export interface UncategorizedReport {
-  /** Changed lines, counting each side, that no lens selects. */
-  lines: number;
-  files: {
-    path: string;
-    lines: number;
-    ranges: Pick<FileLineRange, "side" | "fromLine" | "toLine">[];
-  }[];
-  /** Files past the first REPORT_FILES, left out of `files`. */
-  moreFiles?: number;
-}
-
-/** What a lens author still has to place: the changed lines no lens selects,
- * grouped by file. */
-export function uncategorizedReport(
-  progress: ReviewProgress,
-): UncategorizedReport {
-  const sources =
-    progress.lenses.find((lens) => lens.id === UNCATEGORIZED_LENS_ID)
-      ?.sources ?? [];
-
-  const byPath = new Map<string, UncategorizedReport["files"][number]>();
-  const pathOf = changedPath(progress.files);
-
-  for (const source of sources) {
-    const path = pathOf(source);
-
-    const entry = byPath.get(path) ?? { path, lines: 0, ranges: [] };
-    entry.lines += source.toLine - source.fromLine + 1;
-    entry.ranges.push({
-      side: source.side,
-      fromLine: source.fromLine,
-      toLine: source.toLine,
-    });
-    byPath.set(path, entry);
-  }
-
-  const files = [...byPath.values()];
-
-  const report: UncategorizedReport = {
-    lines: files.reduce((total, file) => total + file.lines, 0),
-    files: files.slice(0, REPORT_FILES),
-  };
-
-  if (files.length > REPORT_FILES)
-    report.moreFiles = files.length - REPORT_FILES;
-
-  return report;
-}
-
-/** Each lens as authored, with what it resolves to, for a lens author. */
-export function lensReport(lenses: readonly Lens[], progress: ReviewProgress) {
-  return {
-    lenses: lenses.map((lens) => {
-      const resolved = progress.lenses.find((item) => item.id === lens.id);
-
-      return {
-        ...lens,
-        fileCount: resolved?.fileCount ?? 0,
-        ...(resolved?.unavailable && { unavailable: resolved.unavailable }),
-      };
-    }),
-    uncategorized: uncategorizedReport(progress),
-  };
+/** A lens with no fileCount failed to resolve, so it is never pending. */
+export function pendingLenses(
+  lenses: readonly ResolvedLens[],
+  counting: boolean,
+): ReviewProgress["lenses"] {
+  return lenses.map((lens) => {
+    if (lens.fileCount === undefined) return lens;
+
+    if (!counting) return { ...lens, pending: false };
+
+    return {
+      ...lens,
+      ...(lens.id === UNCATEGORIZED_LENS_ID && { sources: [], fileCount: 0 }),
+      unavailable: undefined,
+      pending: true,
+    };
+  });
 }

package/src/review-api/store.ts

@@ -17,6 +17,7 @@ import {
   type Applied,
   type Block,
   type BoardLinkRef,
+  type Coverage,
   type EditSummary,
   type Element,
   type FileLineRange,
@@ -39,6 +40,7 @@ import {
   documentSchema,
   editSchema,
   elements,
+  emptyCoverage,
   explicitPins,
   lensEditSchema,
   lensSchema,
@@ -53,18 +55,14 @@ import {
   sourceAnchors,
   sourceReferences,
   summarizeEdit,
+  updateCoverage,
 } from "@dev.fast/whiteboard-document";
 import type { GitHubPullRequest } from "@review/github-pr-graph.js";
 import {
   migrateStoredLenses,
   readStoredDocument,
 } from "@review/stored-document-migration.js";
-import {
-  type Coverage,
-  coverageSchema,
-  emptyCoverage,
-  updateCoverage,
-} from "@review/viewed-coverage.js";
+import { coverageSchema } from "@review/viewed-coverage.js";
 import { z } from "zod";
 
 import { ReviewActivity } from "./activity.js";

package/src/server/review-gateway-pushes.ts

@@ -20,6 +20,7 @@ const REMOTE_VERBS = new Set<ReviewVerbRequest["name"]>([
   "authoringCapabilities",
   "openApiReview",
   "focusWindow",
+  "renderAnimation",
 ]);
 
 export function createGatewayPushes(input: {
@@ -41,7 +42,10 @@ export function createGatewayPushes(input: {
         error: `${request.name} is not available from another machine.`,
       };
 
-    if (request.name === "openApiReview") {
+    if (
+      request.name === "openApiReview" ||
+      request.name === "renderAnimation"
+    ) {
       const refused = await input.claim(remote, request.args.reviewId);
 
       if (refused) return { ok: false, error: refused };

package/src/server/review-gateway.ts

@@ -63,6 +63,20 @@ const REMOTE_ROUTES: readonly RemoteRoute[] = [
   { method: "GET", path: "diff" },
   { method: "GET", path: "structural-diff" },
   { method: "GET", path: "stack" },
+  { method: "GET", path: "place" },
+  { method: "GET", path: "project" },
+  { method: "GET", path: "inspect" },
+  { method: "GET", path: "history" },
+  { method: "GET", path: "lenses" },
+  { method: "GET", path: "activity" },
+  { method: "POST", path: "activity/:action{begin|update|end}" },
+  { method: "POST", path: "person-edit" },
+  { method: "POST", path: "focus" },
+  { method: "POST", path: "animation-run" },
+  { method: "GET", path: "render", slow: true },
+  { method: "GET", path: "links" },
+  { method: "GET", path: "links/peek" },
+  { method: "GET", path: "commit/:commit" },
   { method: "GET", path: "tree" },
   { method: "GET", path: "file" },
   { method: "GET", path: "resources/:name" },
@@ -85,7 +99,7 @@ const REMOTE_ROUTES: readonly RemoteRoute[] = [
   },
   {
     method: "POST",
-    path: "ask/:thread/:action{prompt|permission|files|retry|cancel|close}",
+    path: "ask/:thread/:action{prompt|permission|files|retry|cancel|close|viewed}",
   },
   { method: "DELETE", path: "ask/:thread" },
 ];

package/src/software-map-diff-counts.ts

@@ -3,8 +3,10 @@ import {
   diff as readLocalVcsDiff,
 } from "@dev.fast/local-vcs";
 import { jsonString, parseJsonText } from "@dev.fast/review-protocol";
-
-import { type DiffHunkLine, parseUnifiedPatch } from "./unified-diff";
+import {
+  type DiffHunkLine,
+  parseUnifiedPatch,
+} from "@dev.fast/whiteboard-document";
 
 export interface SoftwareMapDiffLineCount {
   additions: number;