@dev.fast/whiteboard 0.5.1 → 0.5.2-preview.20261104.147

package/src/sharing/import.ts

@@ -21,7 +21,10 @@ import {
 import { textIncludesQuote } from "@review/evidence.js";
 import type { LocalReviewData } from "@review/review-api/local-data.js";
 import { pullRequestUrl } from "@review/review-api/origin.js";
-import type { ReviewStore } from "@review/review-api/store.js";
+import type {
+  ReviewStore,
+  SharedProvenance,
+} from "@review/review-api/store.js";
 import { traceSchema } from "@review/review-api/trace-schema.js";
 import {
   devReviewHome,
@@ -45,7 +48,7 @@ import {
   sharedGit,
 } from "./repository.js";
 
-export const sharedSnapshotSchema = z.strictObject({
+export const sharedSnapshotSchema = z.object({
   reviewId: z.string().min(1),
   version: z.number().int().nonnegative(),
   /** Empty for a board never named; it reads "Untitled". */
@@ -60,7 +63,7 @@ export const sharedSnapshotSchema = z.strictObject({
   lenses: z.array(lensSchema).optional(),
   createdAt: z.string(),
   origin: z
-    .strictObject({
+    .object({
       branch: z.string().optional(),
       baseRef: z.string().optional(),
       baseBranch: z.string().optional(),
@@ -75,7 +78,7 @@ export const sharedSnapshotSchema = z.strictObject({
 
 const count = z.number().int().nonnegative();
 
-const counts = z.strictObject({ additions: count, deletions: count });
+const counts = z.object({ additions: count, deletions: count });
 
 const mapSchema = softwareModelDataSchema.extend({
   commit: z.string().regex(COMMIT_ID),
@@ -88,10 +91,10 @@ const mapSchema = softwareModelDataSchema.extend({
         counts.extend({
           file: z.string(),
           hunks: z.array(
-            z.strictObject({
+            z.object({
               startLine: count,
               lines: z.array(
-                z.strictObject({
+                z.object({
                   kind: z.enum(["add", "remove"]),
                   oldLine: count.nullable(),
                   newLine: count.nullable(),
@@ -106,7 +109,7 @@ const mapSchema = softwareModelDataSchema.extend({
   ),
 });
 
-export const sharePresentationSchema = z.strictObject({
+export const sharePresentationSchema = z.object({
   maps: z.record(z.string(), mapSchema),
 });
 
@@ -129,6 +132,12 @@ export function needsRepository(
 
 export function validateShareBundle(input: ShareBundle) {
   const bundle = shareBundleSchema.parse(input);
+
+  if (bundle.frozen)
+    throw new ReviewInputError(
+      "This whiteboard is a read-only snapshot of uncommitted changes. View it in the browser.",
+      409,
+    );
   // SAFETY: a bundle is parsed from JSON, so its snapshot is a JSON object.
   const stored = bundle.snapshot as JsonObject;
 
@@ -235,18 +244,99 @@ export interface ShareImport {
   onStage?: (stage: "fetching" | "validating") => void;
 }
 
-/** Imports a share as an ordinary board, once per link: the link's copy
- * comes back while it exists, even from Trash. */
+export const FRESH_IMPORT_VERSION = 0;
+
+/** The revision a link serves and its share's latest. */
+export interface ServedRevision {
+  revision: { id: string; version: number; createdAt: number };
+  latest: string;
+}
+
+export type ShareCopyPlan =
+  | { kind: "open"; reviewId: string }
+  | { kind: "refresh"; reviewId: string; version: number }
+  | { kind: "import" };
+
+/** Which copy a served revision opens or refreshes in place; otherwise a new copy. */
+export function planShareCopy(
+  copies: ReturnType<ReviewStore["copiesOf"]>,
+  served: ServedRevision,
+  pinned = false,
+): ShareCopyPlan {
+  const same = copies.find(({ shared }) =>
+    shared.revisionId === undefined
+      ? shared.sharedAt === served.revision.createdAt
+      : shared.revisionId === served.revision.id,
+  );
+
+  if (same) return { kind: "open", reviewId: same.reviewId };
+
+  const unedited =
+    !pinned &&
+    served.revision.id === served.latest &&
+    copies.find(
+      (copy) =>
+        !copy.shared.pinned &&
+        copy.version === (copy.shared.importedVersion ?? FRESH_IMPORT_VERSION),
+    );
+
+  return unedited
+    ? {
+        kind: "refresh",
+        reviewId: unedited.reviewId,
+        version: unedited.version,
+      }
+    : { kind: "import" };
+}
+
+/** Opens, refreshes or copies a link's board by the revision it serves. */
+export async function receiveShare(
+  input: ShareImport,
+  key: string,
+  served: ServedRevision,
+  download: () => Promise<{
+    bundle: ShareBundle;
+    attribution: ShareAttribution;
+  }>,
+  pinned = false,
+): Promise<string> {
+  const plan = planShareCopy(input.store.copiesOf(key), served, pinned);
+
+  if (plan.kind === "open") return plan.reviewId;
+  const { bundle, attribution } = await download();
+
+  const provenance = {
+    ...attribution,
+    revisionId: served.revision.id,
+    ...(pinned && { pinned }),
+  };
+
+  if (plan.kind === "import")
+    return importShare(input, key, bundle, provenance);
+
+  try {
+    return await importShare(input, key, bundle, provenance, plan);
+  } catch (error) {
+    // The board was edited or deleted since the plan read it.
+    if (
+      error instanceof ReviewInputError &&
+      (error.status === 409 || error.status === 404)
+    )
+      return importShare(input, key, bundle, provenance);
+    throw error;
+  }
+}
+
+/** Imports a share as an ordinary board, or into a copy of its link. */
 export async function importShare(
   input: ShareImport,
   key: string,
   received: ShareBundle,
-  attribution?: ShareAttribution,
+  provenance?: ShareAttribution &
+    Pick<SharedProvenance, "revisionId" | "pinned">,
+  into?: { reviewId: string; version: number },
 ): Promise<string> {
   const { store, data } = input;
-  const existing = store.copyOf(key);
-
-  if (existing) return existing;
   const { bundle, snapshot, maps } = validateShareBundle(received);
   const cloneUrl = bundle.repository?.cloneUrl;
   let repositoryId: string | undefined;
@@ -319,27 +409,29 @@ export async function importShare(
 
   for (const [id, copy] of ids) document = document.replaceAll(id, copy);
 
-  const { reviewId } = await store.execute(
-    {
-      operation: {
-        type: "create",
-        ...(snapshot.title && { title: snapshot.title }),
-        ...(pins
-          ? { target: { kind: "commits", ...pins } }
-          : repositoryId && {
-              target: { kind: "project", repositoryId },
-            }),
-      },
+  const create = {
+    operation: {
+      type: "create",
+      ...(snapshot.title && { title: snapshot.title }),
+      ...(pins
+        ? { target: { kind: "commits", ...pins } }
+        : repositoryId && {
+            target: { kind: "project", repositoryId },
+          }),
     },
-    {
-      document: JSON.parse(document),
-      lenses: snapshot.lenses,
-      origin: snapshot.origin,
-      shared: { ...attribution, cloneUrl, key },
-      copiedFrom: snapshot.reviewId,
-    },
-    { kind: "person" },
-  );
+  };
+
+  const seed = {
+    document: JSON.parse(document),
+    lenses: snapshot.lenses,
+    origin: snapshot.origin,
+    shared: { ...provenance, cloneUrl, key },
+    copiedFrom: snapshot.reviewId,
+  };
+
+  const { reviewId } = into
+    ? await store.refreshCopy(into.reviewId, into.version, create, seed)
+    : await store.execute(create, seed, { kind: "person" });
 
   return reviewId;
 }

package/src/ui-telemetry-events.ts

@@ -21,6 +21,7 @@ import {
   REVIEW_COLOR_THEME_KINDS,
   REVIEW_DIFF_LAYOUTS,
   REVIEW_DIFF_LAYOUT_SCOPES,
+  REVIEW_OPEN_FILES_IN_CHOICES,
   isJsonObject,
   jsonBoolean,
   jsonNumber,
@@ -93,7 +94,12 @@ export const LSP_FEATURE = [
 
 export const LSP_VIA = ["command", "mouse"] as const;
 
-export const LSP_EDITOR_KIND = ["files_tab", "inline_peek", "diff"] as const;
+export const LSP_EDITOR_KIND = [
+  "files_tab",
+  "inline_peek",
+  "diff",
+  "definition_peek",
+] as const;
 
 export const LSP_LANGUAGE = [
   "typescript",
@@ -212,6 +218,17 @@ const MAP_LEVEL = ["system", "container", "component", "code"] as const;
 
 const SOURCE_TREE_OPENED_VIA = ["topbar", "home"] as const;
 
+const SOURCE_OPENED_DESTINATION = [
+  "source_window",
+  "vscode",
+  "cursor",
+  "zed",
+  "intellij",
+  "application",
+] as const;
+
+const SOURCE_OPENED_KIND = ["file", "diff", "references", "tree"] as const;
+
 /** Tab names the dwell beacon reports. Shared with its request parser. */
 export const REVIEW_TELEMETRY_TABS = [
   "review",
@@ -431,6 +448,13 @@ export const UI_TELEMETRY_EVENTS = {
     event: "review_source_tree_opened",
     properties: { via: SOURCE_TREE_OPENED_VIA },
   },
+  source_opened: {
+    event: "review_source_opened",
+    properties: {
+      destination: SOURCE_OPENED_DESTINATION,
+      kind: SOURCE_OPENED_KIND,
+    },
+  },
   whiteboard_file_exported: {
     event: "review_whiteboard_file_exported",
     properties: {},
@@ -571,6 +595,7 @@ export const UI_TELEMETRY_EVENTS = {
       setting: SETTING_NAME,
       enabled: "boolean",
       value: REVIEW_COLOR_THEME_KINDS,
+      choice: REVIEW_OPEN_FILES_IN_CHOICES,
     },
   },
   review_opened: {

package/dist/agent-cli-B8KBHuh_.js

@@ -1,2 +0,0 @@
-import { n as runReviewAgentCli } from "./agent-cli-kHRrwO4n.js";
-export { runReviewAgentCli };

package/dist/profile-BjcXi-oH.js

@@ -1,2 +0,0 @@
-import { t as openReviewProfile } from "./profile--BYIjPkc.js";
-export { openReviewProfile };

package/src/review-api/lens-alignment.ts

@@ -1,52 +0,0 @@
-import type { AlignmentRow } from "@dev.fast/whiteboard-document";
-import { parseUnifiedPatch } from "@review/unified-diff.js";
-
-/** Project the already-computed patch's runs, including unchanged gaps. */
-export function textualRows(
-  path: string,
-  patch: string,
-  baseCount: number,
-  headCount: number,
-): AlignmentRow[] {
-  const rows: AlignmentRow[] = [];
-
-  let base = 0,
-    head = 0;
-
-  const append = (baseEnd: number, headEnd: number) => {
-    while (base < baseEnd || head < headEnd)
-      rows.push([
-        base < baseEnd ? base++ : null,
-        head < headEnd ? head++ : null,
-      ]);
-  };
-
-  for (const hunk of parseUnifiedPatch(path, patch)) {
-    append(
-      hunk.oldLines ? hunk.oldStart - 1 : hunk.oldStart,
-      hunk.newLines ? hunk.newStart - 1 : hunk.newStart,
-    );
-
-    let removed = 0,
-      added = 0;
-
-    const flush = () => {
-      append(base + removed, head + added);
-      removed = added = 0;
-    };
-
-    for (const line of hunk.lines) {
-      if (line.kind === "context") {
-        flush();
-        append(base + 1, head + 1);
-      } else if (line.kind === "add") added++;
-      else removed++;
-    }
-
-    flush();
-  }
-
-  append(baseCount, headCount);
-
-  return rows;
-}