@dev.fast/whiteboard 0.3.4-preview.20261019.126 → 0.3.4

package/src/sharing/repository.ts

@@ -2,25 +2,12 @@ import { mkdir, mkdtemp, rm } from "node:fs/promises";
 import { tmpdir } from "node:os";
 import path from "node:path";
 
-import { type VcsArg, gitAt } from "@dev.fast/local-vcs";
+import { gitAt } from "@dev.fast/local-vcs";
 import { normalizeGitHubRemote } from "@dev.fast/review-share-protocol";
 import { type Pins, ReviewInputError } from "@review/review-api/document.js";
 
-/** A full commit id, SHA-1 or SHA-256. */
-export const COMMIT_ID = /^(?:[a-f0-9]{40}|[a-f0-9]{64})$/;
-
-/** Refuses anything but full commit ids, before any of them reaches git:
- * a shared board's commits come from someone else, and one spelled as an
- * option or a refspec would make git do something else. */
-export function assertCommitIds(commits: readonly string[]) {
-  if (!commits.every((commit) => COMMIT_ID.test(commit)))
-    throw new ReviewInputError(
-      "The shared whiteboard names a commit that isn't a full commit id.",
-    );
-}
-
 /** Keep credential helpers but prevent the calling shell from redirecting Git's object store. */
-export function sharedGit(cwd: string, args: VcsArg[]) {
+export function sharedGit(cwd: string, args: string[]) {
   const env = Object.fromEntries(
     Object.entries(process.env).filter(
       ([key]) =>
@@ -38,7 +25,7 @@ export function sharedGit(cwd: string, args: VcsArg[]) {
     cwd,
     ["-c", "core.hooksPath=/dev/null", "-c", "core.fsmonitor=false", ...args],
     {
-      env,
+      env: { ...env, GIT_TERMINAL_PROMPT: "0" },
       timeout: 300_000,
     },
   );
@@ -59,28 +46,18 @@ function fetchError(stderr: string, publishing: boolean): ReviewInputError {
   );
 }
 
-/** Recipients need complete history; publication only checks that the commits exist.
- * `commits` are other commits the board's references read at; a plan has
- * only those. */
+/** Recipients need complete history; publication only checks that the commits exist. */
 export async function fetchPinnedRepository(
   root: string,
   url: string,
-  pins: Pick<Pins, "base" | "head"> | undefined,
+  pins: Pick<Pins, "base" | "head">,
   publishing = false,
-  commits: readonly string[] = [],
 ) {
-  // Each commit and the ref it is fetched to.
-  const named = [
-    ...(pins
-      ? [
-          { commit: pins.base, ref: "base" },
-          { commit: pins.head, ref: "head" },
-        ]
-      : []),
-    ...commits.map((commit) => ({ commit, ref: `commits/${commit}` })),
-  ];
-
-  if (!named.every(({ commit }) => COMMIT_ID.test(commit)))
+  if (
+    ![pins.base, pins.head].every((commit) =>
+      /^(?:[a-f0-9]{40}|[a-f0-9]{64})$/.test(commit),
+    )
+  )
     throw new ReviewInputError(
       "Sharing requires immutable base and head commits.",
     );
@@ -90,7 +67,7 @@ export async function fetchPinnedRepository(
   if (!publishing) {
     await sharedGit(root, ["config", "core.hooksPath", "/dev/null"]);
     await sharedGit(root, ["config", "core.fsmonitor", "false"]);
-    await sharedGit(root, ["remote", "add", "origin", { remote: url }]);
+    await sharedGit(root, ["remote", "add", "origin", url]);
   }
 
   // Branch refs make Git reject non-commit objects during the fetch itself.
@@ -102,10 +79,9 @@ export async function fetchPinnedRepository(
       "--no-tags",
       "--force",
       ...(publishing ? ["--depth=1", "--filter=tree:0"] : []),
-      { remote: publishing ? url : "origin" },
-      ...named.map(({ commit, ref }) => ({
-        refspec: { from: commit, to: `${refs}/${ref}` },
-      })),
+      publishing ? url : "origin",
+      `${pins.base}:${refs}/base`,
+      `${pins.head}:${refs}/head`,
     ]);
   } catch (error) {
     throw fetchError(
@@ -115,104 +91,21 @@ export async function fetchPinnedRepository(
   }
 
   if (!publishing)
-    for (const { commit } of named)
-      await sharedGit(root, ["cat-file", "-e", { rev: `${commit}^{commit}` }]);
-}
-
-/** Fetches the commits a shared board's links read at into a checkout of
- * its repository, from its origin unless it has them, and keeps each under
- * `refs/review/shared/<share>/<commit>`, so `git gc` can't prune one the
- * board still quotes. */
-export async function fetchSharedCommits(
-  root: string,
-  commits: readonly string[],
-  share: string,
-) {
-  assertCommitIds(commits);
-
-  const ref = (commit: string) => `refs/review/shared/${share}/${commit}`;
-  const missing: string[] = [];
-
-  for (const commit of commits)
-    try {
-      await sharedGit(root, ["cat-file", "-e", { rev: `${commit}^{commit}` }]);
-      await sharedGit(root, ["update-ref", { ref: ref(commit) }, { commit }]);
-    } catch {
-      missing.push(commit);
-    }
-
-  if (!missing.length) return;
-
-  try {
-    await sharedGit(root, [
-      "fetch",
-      "--no-tags",
-      "origin",
-      ...missing.map((commit) => ({
-        refspec: { from: commit, to: ref(commit), force: true },
-      })),
-    ]);
-  } catch (error) {
-    throw fetchError(
-      error instanceof Error && "stderr" in error ? String(error.stderr) : "",
-      false,
-    );
-  }
-}
-
-/** Drops the refs `fetchSharedCommits` kept for a share, once the share is
- * gone, so `git gc` can prune what only it quoted. */
-export async function forgetSharedCommits(root: string, share: string) {
-  const { stdout } = await sharedGit(root, [
-    "for-each-ref",
-    "--format=%(refname)",
-    { ref: `refs/review/shared/${share}/` },
-  ]);
-
-  for (const ref of stdout.split("\n").filter(Boolean))
-    await sharedGit(root, ["update-ref", "-d", { ref }]);
-}
-
-/** A managed clone of a repository's default branch, for a shared board
- * with no pins whose repository the receiver has no checkout of. */
-export async function cloneSharedRepository(root: string, url: string) {
-  await mkdir(root, { recursive: true, mode: 0o700 });
-  await sharedGit(root, ["init", "--quiet"]);
-  await sharedGit(root, ["config", "core.hooksPath", "/dev/null"]);
-  await sharedGit(root, ["config", "core.fsmonitor", "false"]);
-  await sharedGit(root, ["remote", "add", "origin", { remote: url }]);
-
-  try {
-    await sharedGit(root, ["fetch", "--no-tags", "origin", "HEAD"]);
-  } catch (error) {
-    throw fetchError(
-      error instanceof Error && "stderr" in error ? String(error.stderr) : "",
-      false,
-    );
-  }
-
-  await sharedGit(root, ["checkout", "--detach", "FETCH_HEAD"]);
+    for (const commit of [pins.base, pins.head])
+      await sharedGit(root, ["cat-file", "-e", `${commit}^{commit}`]);
 }
 
 export async function repositoryReady(
   root: string,
   pins: Pick<Pins, "base" | "head">,
-  commits: readonly string[] = [],
 ): Promise<boolean> {
-  if (
-    ![pins.base, pins.head, ...commits].every((commit) =>
-      COMMIT_ID.test(commit),
-    )
-  )
-    return false;
-
   try {
     const head = await sharedGit(root, ["rev-parse", "HEAD"]);
 
     if (head.stdout.trim() !== pins.head) return false;
 
-    for (const commit of [pins.base, pins.head, ...commits])
-      await sharedGit(root, ["cat-file", "-e", { rev: `${commit}^{commit}` }]);
+    for (const commit of [pins.base, pins.head])
+      await sharedGit(root, ["cat-file", "-e", `${commit}^{commit}`]);
 
     return true;
   } catch {
@@ -236,15 +129,14 @@ export async function readShareRepository(root: string) {
 
 export async function verifyShareRepository(
   root: string,
-  pins: Pins | undefined,
+  pins: Pins,
   repository?: { cloneUrl: string },
-  commits: readonly string[] = [],
 ) {
   const { cloneUrl } = repository ?? (await readShareRepository(root));
   const temporary = await mkdtemp(path.join(tmpdir(), "review-share-check-"));
 
   try {
-    await fetchPinnedRepository(temporary, cloneUrl, pins, true, commits);
+    await fetchPinnedRepository(temporary, cloneUrl, pins, true);
   } finally {
     await rm(temporary, { recursive: true, force: true });
   }

package/src/startup-trace.ts

@@ -221,9 +221,9 @@ if (traceEnabled) {
   // Every git/jj spawn inside @dev.fast/local-vcs becomes a `$ …` span under
   // whatever span is active in the caller's async context.
   setLocalVcsCommandObserver({
-    start({ tool, args, cwd }) {
-      const handle = startSpan(commandSpanName(tool, args), {
-        detail: commandDetail(tool, args, cwd),
+    start({ file, args, cwd }) {
+      const handle = startSpan(commandSpanName(file, args), {
+        detail: commandDetail(file, args, cwd),
       });
 
       return ({ ok }) => (ok ? handle.end() : handle.fail());

package/src/stored-document-migration.ts

@@ -1,124 +1,18 @@
-import {
-  type JsonObject,
-  type JsonValue,
-  isBooleanValue,
-  isJsonObject,
-  isNumberValue,
-  isStringValue,
-} from "@dev.fast/review-protocol";
+import { type JsonValue, isJsonObject } from "@dev.fast/review-protocol";
 import { z } from "zod";
 
-import {
-  ATTACHMENT_KEYS,
-  migrateDiffSelections,
-  retiredSelection,
-} from "./diff-selection-migration.js";
+import { migrateDiffSelections } from "./diff-selection-migration.js";
 import { formatAnchor } from "./lens-selection.js";
 import { label } from "./review-api/blocks/definition.js";
 import { type Lens, lensTargetsSchema } from "./review-api/diff-lenses.js";
-import { respellLinks } from "./review-api/document.js";
 
 /** Upgrade a saved or shared Review document to the current block schema at the
  * read/import boundary. New edits use the strict schema and never accept these
- * retired forms. One walk makes a fresh copy: retired attachments become
- * selections, anchors become strings, sections lose their status, and
- * Markdown links are spelled the current way. */
+ * retired forms. */
 // This is the decoder boundary for stored documents in retired wire formats.
 // oxlint-disable-next-line anti-slop/no-unknown-parameters
 export function migrateStoredDocument(input: unknown): JsonValue {
-  return upgradeNode(input, { attachment: false, anchors: true });
-}
-
-/** Where a node sits: under a key that held a retired attachment, and
- * whether its anchors still need converting (not inside an anchor). */
-interface NodePlace {
-  attachment: boolean;
-  anchors: boolean;
-  blockPins?: JsonValue;
-}
-
-// oxlint-disable-next-line anti-slop/no-unknown-parameters -- Decoder boundary: every value is checked to be JSON as it is copied.
-function upgradeNode(value: unknown, place: NodePlace): JsonValue {
-  if (isStringValue(value) || isBooleanValue(value) || value === null)
-    return value;
-
-  if (isNumberValue(value) && Number.isFinite(value)) return value;
-
-  if (Array.isArray(value))
-    return value.map((child) => upgradeNode(child, place));
-
-  if (!isJsonObject(value)) throw new TypeError("A document must be JSON.");
-
-  const selection = place.attachment ? retiredSelection(value) : undefined;
-
-  if (selection)
-    return upgradeNode(selection, { attachment: false, anchors: false });
-
-  const inherited = place.anchors ? (value.pins ?? place.blockPins) : undefined;
-  let pins: JsonValue | undefined;
-
-  const convert = (anchor: JsonValue): JsonValue => {
-    // Most anchors are strings already.
-    if (isStringValue(anchor)) return anchor;
-
-    const parsed = selectionObjectSchema.safeParse(anchor);
-
-    if (!parsed.success) return anchor;
-
-    const { pins: own, ...anchorAt } = parsed.data;
-
-    if (own) pins = own;
-
-    return formatAnchor(anchorAt);
-  };
-
-  const entries: [string, JsonValue][] = [];
-
-  for (const [key, child] of Object.entries(value)) {
-    if (key === "status" && value.type === "section") continue;
-
-    if (key === "markdown" && isStringValue(child)) {
-      entries.push([key, respellLinks(child)]);
-      continue;
-    }
-
-    const attachment = ATTACHMENT_KEYS.includes(key);
-
-    if (place.anchors && ANCHOR_KEYS.includes(key)) {
-      const anchors = upgradeNode(child, { attachment, anchors: false });
-
-      entries.push([
-        key,
-        Array.isArray(anchors) ? anchors.map(convert) : convert(anchors),
-      ]);
-    } else
-      entries.push([
-        key,
-        upgradeNode(child, {
-          attachment,
-          anchors: place.anchors,
-          blockPins: inherited,
-        }),
-      ]);
-  }
-
-  const upgraded: JsonObject = Object.fromEntries(entries);
-
-  if (
-    pins !== undefined &&
-    value.kind !== "ranges" &&
-    JSON.stringify(pins) !== JSON.stringify(place.blockPins)
-  )
-    upgraded.pins = pins;
-
-  return upgraded;
-}
-
-/** A stored document as the store reads it: retired forms upgraded, and
- * lens blocks lifted out to the snapshot's own lenses. */
-// oxlint-disable-next-line anti-slop/no-unknown-parameters -- Decoder boundary for stored documents in retired formats.
-export function readStoredDocument(input: unknown): LiftedLenses {
-  return liftFileLenses(migrateStoredDocument(input));
+  return anchorStrings(dropSectionStatus(migrateDiffSelections(input)));
 }
 
 /** Lenses saved before ranges were anchor strings. */
@@ -188,6 +82,21 @@ export function anchorStrings(
   return migrated;
 }
 
+/** Sections once carried an optional `status` (pending, in_progress or
+ * complete). The authoring lease is now the only signal of work in progress,
+ * so versions saved before it was retired drop the field when read. */
+function dropSectionStatus(value: JsonValue): JsonValue {
+  if (Array.isArray(value)) return value.map(dropSectionStatus);
+
+  if (!isJsonObject(value)) return value;
+
+  return Object.fromEntries(
+    Object.entries(value)
+      .filter(([key]) => !(value.type === "section" && key === "status"))
+      .map(([key, child]) => [key, dropSectionStatus(child)]),
+  );
+}
+
 /** A saved `file_lens` block, from before lenses left the document. */
 const legacyFileLensSchema = z.object({
   type: z.literal("file_lens"),

package/src/ui-telemetry-events.ts

@@ -29,7 +29,6 @@ import {
 import { z } from "zod";
 
 import { askAgentIds } from "./ask/thread-state";
-import { SELECTION_UNAVAILABLE_REASONS } from "./lens-selection";
 import { containsFilePath, hasPossibleUserInfo } from "./telemetry-clean-text";
 
 /** Property value validators: an enum of allowed strings, or a scalar type. */
@@ -71,13 +70,6 @@ const PEEK_VIA = [
 
 export const PEEK_ROOT_KIND = ["range"] as const;
 
-/** `unresolved`: progress finished without this selection; `error`: progress failed. */
-export const PEEK_FAILURE_REASON = [
-  ...SELECTION_UNAVAILABLE_REASONS,
-  "error",
-  "unresolved",
-] as const;
-
 export const LSP_FEATURE = [
   "hover",
   "goto_definition",
@@ -145,6 +137,7 @@ export const SETTING_NAME = [
   "telemetry_enabled",
   "keymap",
   "software_map_enabled",
+  "scratchpad_enabled",
   "diffr_config",
   "theme",
   "ctrl_tab",
@@ -156,8 +149,12 @@ export const SETTING_NAME = [
 
 export const REVIEW_OPENED_VIA = ["home", "cli", "other"] as const;
 
-/** Where a review's source comes from: its target's kind. */
-export const SESSION_SOURCE_KIND = ["worktree", "commits", "project"] as const;
+/** Where a review's source comes from: its target's kind, or the one scratchpad. */
+export const SESSION_SOURCE_KIND = [
+  "worktree",
+  "commits",
+  "scratchpad",
+] as const;
 
 /**
  * The authoring agent a review session is attributed to. This is the one
@@ -249,7 +246,6 @@ export const INSTALL_LOCATION = [
 
 export const DIFF_OPENED_VIA = [
   "topbar",
-  "sidebar",
   "lens",
   "locate",
   "file_picker",
@@ -258,15 +254,6 @@ export const DIFF_OPENED_VIA = [
 /** Which diff opened: a commit's, or a file diff drawn plain or structural. */
 export const DIFF_OPENED_KIND = ["commit", "structural"] as const;
 
-export const DIFF_FAILED_REASON = [
-  "missing_binary",
-  "process_exit",
-  "stream_ended",
-  "aborted",
-  "file_error",
-  "other",
-] as const;
-
 /** GitHub Enterprise is any GitHub host but github.com. */
 export const PR_PROVIDER = [
   "github",
@@ -290,9 +277,7 @@ export const ONBOARDING_STEP = ["welcome", "install", "run"] as const;
 
 export const RUN_MODE = ["draw", "copy"] as const;
 
-export const NEW_WHITEBOARD_VIA = ["button", "command", "sidebar"] as const;
-
-export const NEW_WHITEBOARD_MODE = [...RUN_MODE, "empty"] as const;
+export const NEW_WHITEBOARD_VIA = ["button", "command"] as const;
 
 export const FIND_SURFACE = ["review", "diff"] as const;
 
@@ -609,10 +594,7 @@ export const UI_TELEMETRY_EVENTS = {
     event: "review_diff_opened",
     properties: { kind: DIFF_OPENED_KIND, via: DIFF_OPENED_VIA },
   },
-  diff_failed: {
-    event: "review_diff_failed",
-    properties: { reason: DIFF_FAILED_REASON, files: "number" },
-  },
+  scratchpad_opened: { event: "review_scratchpad_opened", properties: {} },
   discord_clicked: {
     event: "review_discord_clicked",
     properties: { via: DISCORD_VIA },
@@ -631,7 +613,7 @@ export const UI_TELEMETRY_EVENTS = {
   },
   peek_resolve_failed: {
     event: "review_peek_resolve_failed",
-    properties: { root_kind: PEEK_ROOT_KIND, reason: PEEK_FAILURE_REASON },
+    properties: { root_kind: PEEK_ROOT_KIND },
   },
   review_deleted: {
     event: "review_review_deleted",
@@ -670,11 +652,7 @@ export const UI_TELEMETRY_EVENTS = {
   },
   new_whiteboard_started: {
     event: "review_new_whiteboard_started",
-    properties: {
-      mode: NEW_WHITEBOARD_MODE,
-      embedded: "boolean",
-      agent: askAgentIds,
-    },
+    properties: { mode: RUN_MODE, embedded: "boolean", agent: askAgentIds },
   },
   remote_host_installed: {
     event: "review_remote_host_installed",

package/dist/agent-cli-_YyMIMRY.js

@@ -1,2 +0,0 @@
-import { n as runReviewAgentCli } from "./agent-cli-CohHf6Ua.js";
-export { runReviewAgentCli };