@dev.fast/whiteboard 0.2.4 → 0.2.5-preview.20261013.109

package/dist/{local-data-Bm84Xdck.js → local-data-BlERtVm2.js}

@@ -1,16 +1,15 @@
-import { _ as readFileAtCommit, b as resolveRevision, c as diffTrees, f as gitCommonDir, g as parseGitRemote, h as listTrackedFilesAtCommit, i as diff, l as diffWorkingTree, m as listCommitRange, n as createBlobBatchReader, o as diffFileSummariesTrees, p as jjRevisionIsConflicted, r as detectLocalVcs, s as diffFileSummariesWorkingTree, t as LocalVcsToolsMissingError, u as git, v as resolveRepoContext, y as resolveRepoContextSync } from "./src-CmdiBL20.js";
+import { C as ReviewInputError, _ as readFileAtCommit, b as resolveRevision, c as diffTrees, f as gitCommonDir, g as parseGitRemote, h as listTrackedFilesAtCommit, i as diff, l as diffWorkingTree, m as listCommitRange, n as createBlobBatchReader, o as diffFileSummariesTrees, p as jjRevisionIsConflicted, r as detectLocalVcs, s as diffFileSummariesWorkingTree, t as LocalVcsToolsMissingError, u as git, v as resolveRepoContext, y as resolveRepoContextSync } from "./src-DiHP11l3.js";
 import { c as jsonString, o as jsonObject, u as parseJsonText } from "./src-X9phtB2j.js";
 import { _ as SCRATCHPAD_REVIEW_ID, b as structuralChangeCounts, g as ReviewSelectedDiffSchema, m as ReviewApiSelectionSourceSchema, y as decodeStructuralDiffEvent } from "./src-WCbabvdS.js";
-import { $ as unionIntervals, A as applyLensEdit, C as resourceReferences, D as summarizeEdit, E as sourceReferences, F as checkSourcePath, I as fileLineRangeSchema, K as sourceAnchors, L as requireVisibleSource, N as lensSelections, O as checkReferences, P as SourceRangeError, Q as subtractIntervals, R as sliceSourceRange, S as resourceReference, X as intersectIntervals, Y as emptyCoverage, a as defineSoftwareMap, b as pinsSchema, c as traceSchema, d as applyEdit, et as updateCoverage, f as assignFreshIds, g as explicitPins, h as elements, i as SoftwareModelValidationError, j as lensEditSchema, l as textIncludesQuote, m as editSchema, n as migrateStoredDocument, p as documentSchema, q as coverageSchema, r as migrateStoredLenses, t as liftFileLenses, u as anchorPins, v as isUnit, w as reviewTargetSchema } from "./stored-document-migration-BxZWQQjv.js";
-import { t as ReviewInputError } from "./input-error-OLgB_h31.js";
+import { s as safeStorageSegment } from "./review-home-paths-Y9mYWkCI.js";
+import { $ as unionIntervals, A as applyLensEdit, C as resourceReferences, D as summarizeEdit, E as sourceReferences, F as checkSourcePath, I as fileLineRangeSchema, K as sourceAnchors, L as requireVisibleSource, N as lensSelections, O as checkReferences, P as SourceRangeError, Q as subtractIntervals, R as sliceSourceRange, S as resourceReference, X as intersectIntervals, Y as emptyCoverage, a as defineSoftwareMap, b as pinsSchema, c as traceSchema, d as applyEdit, et as updateCoverage, f as assignFreshIds, g as explicitPins, h as elements, i as SoftwareModelValidationError, j as lensEditSchema, l as textIncludesQuote, m as editSchema, n as migrateStoredDocument, p as documentSchema, q as coverageSchema, r as migrateStoredLenses, t as liftFileLenses, u as anchorPins, v as isUnit, w as reviewTargetSchema } from "./stored-document-migration-u4L_1VZa.js";
 import { D as processIsAlive, O as withFileLock, P as writePrivateJsonAtomic } from "./s3-config-CAxhO9u_.js";
 import { t as errorMessage } from "./error-message-OtiDonty.js";
-import { s as safeStorageSegment } from "./review-home-paths-6zZH-1c9.js";
 import { r as isMissingFileError } from "./fs-utils-BMPLt0cr.js";
 import { createRequire } from "node:module";
 import crypto, { createHash, randomUUID } from "node:crypto";
 import { z } from "zod";
-import { existsSync, realpathSync, rmSync, watch } from "node:fs";
+import { existsSync, realpathSync, rmSync, statSync } from "node:fs";
 import * as fs$1 from "node:fs/promises";
 import { lstat, mkdir, readFile, readdir, realpath, rm, stat, writeFile } from "node:fs/promises";
 import path, { dirname, isAbsolute, relative, resolve, sep } from "node:path";
@@ -1015,11 +1014,12 @@ async function comparisonCoverage(data, reviewId, pins, mode, signal, publish) {
 		counted: true
 	};
 	if (mode === "textual") return coverage;
-	const publishCurrent = () => publish?.({
+	const unsupported = /* @__PURE__ */ new Set();
+	const current = () => ({
 		...coverage,
-		files: [...coverage.files]
+		files: coverage.files.filter((file) => !unsupported.has(file.path))
 	});
-	publishCurrent();
+	publish?.(current());
 	const baseFiles = new Map(coverage.files.map((file, index) => [file.previousPath ?? file.path, index]));
 	const headFiles = new Map(coverage.files.map((file, index) => [file.path, index]));
 	const remaining = /* @__PURE__ */ new Set();
@@ -1037,8 +1037,11 @@ async function comparisonCoverage(data, reviewId, pins, mode, signal, publish) {
 		if (event.type !== "file") continue;
 		const path = (event.file.rhs ?? event.file.lhs).path;
 		if (!remaining.delete(path)) throw new Error(`Unexpected structural result: ${path}`);
+		const baseIndex = event.file.lhs && baseFiles.get(event.file.lhs.path);
+		const headIndex = event.file.rhs && headFiles.get(event.file.rhs.path);
 		if (event.error) {
 			if (event.error.code !== "unsupported_file_type" && event.error.code !== "not_utf8") throw new Error(`Cannot count ${path}: ${event.error.message}`);
+			for (const index of [baseIndex, headIndex]) if (index !== void 0) unsupported.add(coverage.files[index].path);
 		} else if (event.diff.type === "text") {
 			const diff = event.diff;
 			const folded = foldedChanges(diff);
@@ -1056,17 +1059,16 @@ async function comparisonCoverage(data, reviewId, pins, mode, signal, publish) {
 					}
 				};
 			}
-			const baseIndex = event.file.lhs && baseFiles.get(event.file.lhs.path);
-			const index = (event.file.rhs && headFiles.get(event.file.rhs.path)) ?? baseIndex;
+			const index = headIndex ?? baseIndex;
 			if (index !== void 0) {
 				if ((coverage.fileSources.get(coverage.files[index].path) ?? []).every((source) => source.file === (source.side === "base" ? event.file.lhs : event.file.rhs)?.path)) coverage.alignments = new Map(coverage.alignments).set(coverage.files[index].path, structuralRows(diff));
 			}
-			publishCurrent();
 		}
+		publish?.(current());
 		if (!remaining.size) break;
 	}
 	if (remaining.size) throw new Error("Structural coverage is incomplete.");
-	return coverage;
+	return current();
 }
 /**
 * The changed lines diffr folds by default. A file it hides (lockfiles,
@@ -1831,6 +1833,11 @@ const askUsageSchema = z.object({
 		currency: z.string()
 	}).optional()
 });
+/** A follow-up waiting for the turn under way to end. */
+const askQueuedSchema = z.object({
+	id: z.string(),
+	text: z.string()
+});
 const statusSchema = z.enum([
 	"starting",
 	"running",
@@ -1867,7 +1874,10 @@ const askThreadStateSchema = z.object({
 		title: z.string(),
 		quote: z.string().optional()
 	}),
-	entries: z.array(askEntrySchema)
+	entries: z.array(askEntrySchema),
+	/** Follow-ups asked while the agent answered, which it could not take
+	* then: each goes as its own question once the turn ends. */
+	queued: z.array(askQueuedSchema).optional()
 });
 /** One change to a thread. Answer text arrives as `append`, so a streamed
 * token costs its own length, not the thread's. */
@@ -1882,6 +1892,8 @@ const askChangeSchema = z.discriminatedUnion("type", [
 		accepts: askAcceptsSchema.optional(),
 		usage: askUsageSchema.optional(),
 		title: z.string().optional(),
+		/** Replaces the queue; empty clears it. */
+		queued: z.array(askQueuedSchema).optional(),
 		/** `null` clears the error; absent leaves it. */
 		error: z.string().nullable().optional(),
 		/** `null` clears it; absent leaves it. */
@@ -1925,7 +1937,7 @@ z.union([z.object({
 function applyAskChange(state, change) {
 	switch (change.type) {
 		case "set": {
-			const { error: _error, signIn: _signIn, ...rest } = state;
+			const { error: _error, signIn: _signIn, queued: _queued, ...rest } = state;
 			const next = {
 				...rest,
 				status: change.status ?? state.status,
@@ -1942,6 +1954,8 @@ function applyAskChange(state, change) {
 			if (usage) next.usage = usage;
 			const title = change.title ?? state.title;
 			if (title) next.title = title;
+			const queued = change.queued ?? state.queued;
+			if (queued?.length) next.queued = queued;
 			const error = change.error === void 0 ? state.error : change.error;
 			if (error) next.error = error;
 			const signIn = change.signIn === void 0 ? state.signIn : change.signIn;
@@ -2032,6 +2046,10 @@ const rowSchema = z.object({
 * `reviews`, so there is no foreign key; deleting a review deletes its rows. */
 var AskHistory = class {
 	db;
+	externalWriteGuard;
+	setExternalWriteGuard(guard) {
+		this.externalWriteGuard = guard;
+	}
 	constructor(db) {
 		this.db = db;
 		db.exec(`CREATE TABLE IF NOT EXISTS ask_conversations(
@@ -2054,25 +2072,42 @@ var AskHistory = class {
 		db.exec("CREATE TABLE IF NOT EXISTS ask_agent_offers(agent TEXT PRIMARY KEY, offer TEXT NOT NULL)");
 		db.exec("CREATE TABLE IF NOT EXISTS ask_agent_model_offers(agent TEXT NOT NULL, model TEXT NOT NULL, offer TEXT NOT NULL, PRIMARY KEY(agent, model))");
 	}
+	assertWritable(reviewId) {
+		if (reviewId.startsWith("shared-")) this.externalWriteGuard?.(reviewId);
+		const row = this.db.prepare("SELECT deleted_at FROM review_attention WHERE review_id=?").get(reviewId);
+		if (row?.deleted_at) throw new ReviewInputError(`This whiteboard was moved to Trash on ${new Date(String(row.deleted_at)).toLocaleDateString("en-US", {
+			month: "short",
+			day: "numeric"
+		})}. Restore it with session_lifecycle({"sessionId":"${reviewId}","state":"active"}) to continue.`, 409);
+	}
+	assertThreadWritable(id) {
+		const record = this.get(id);
+		if (record) this.assertWritable(record.reviewId);
+	}
 	save(record) {
+		this.assertWritable(record.reviewId);
 		this.db.prepare(`INSERT OR REPLACE INTO ask_conversations(id,review_id,agent,session_id,version,head,cwd,selection,title,created_at,updated_at,bypass)
         VALUES(?,?,?,?,?,?,?,?,?,?,?,?)`).run(record.id, record.reviewId, record.agent, record.sessionId, record.version, record.head, record.cwd, JSON.stringify(record.selection), record.title, record.createdAt, record.updatedAt, record.bypass ? 1 : 0);
 	}
 	/** Whether reopening the conversation bypasses permissions. */
 	setBypass(id, bypass) {
+		this.assertThreadWritable(id);
 		this.db.prepare("UPDATE ask_conversations SET bypass=? WHERE id=?").run(bypass ? 1 : 0, id);
 	}
 	/** Points a conversation at a new session, when its agent could not
 	* reopen the one it had. */
 	updateSession(id, sessionId) {
+		this.assertThreadWritable(id);
 		this.db.prepare("UPDATE ask_conversations SET session_id=? WHERE id=?").run(sessionId, id);
 	}
 	/** Keeps what the panel shows, so a reopen need not wait on the agent. */
 	saveEntries(id, entries) {
+		this.assertThreadWritable(id);
 		this.db.prepare("UPDATE ask_conversations SET entries=? WHERE id=?").run(JSON.stringify(entries), id);
 	}
 	/** The agent's name for the conversation, which the list shows. */
 	rename(id, title) {
+		this.assertThreadWritable(id);
 		this.db.prepare("UPDATE ask_conversations SET title=? WHERE id=?").run(title.slice(0, 200), id);
 	}
 	saveOffer(agent, offer) {
@@ -2092,6 +2127,7 @@ var AskHistory = class {
 		return row && askOfferSchema.safeParse(JSON.parse(row.offer)).data;
 	}
 	touch(id, at = (/* @__PURE__ */ new Date()).toISOString()) {
+		this.assertThreadWritable(id);
 		this.db.prepare("UPDATE ask_conversations SET updated_at=? WHERE id=?").run(at, id);
 	}
 	/** Newest first. */
@@ -2107,7 +2143,11 @@ var AskHistory = class {
 		const row = this.db.prepare("SELECT * FROM ask_conversations WHERE id=?").get(id);
 		return row ? rowSchema.parse(row) : void 0;
 	}
+	removeReview(reviewId) {
+		this.db.prepare("DELETE FROM ask_conversations WHERE review_id=?").run(reviewId);
+	}
 	delete(id) {
+		this.assertThreadWritable(id);
 		this.db.prepare("DELETE FROM ask_conversations WHERE id=?").run(id);
 	}
 };
@@ -2145,7 +2185,7 @@ function initializeReviewStoreSchema(db) {
     CREATE TABLE IF NOT EXISTS versions(review_id TEXT REFERENCES reviews(id), version INTEGER, snapshot TEXT NOT NULL,
       PRIMARY KEY(review_id,version));
     DROP TABLE IF EXISTS receipts;
-    CREATE TABLE IF NOT EXISTS review_attention(review_id TEXT PRIMARY KEY REFERENCES reviews(id), viewed_at TEXT, dismissed_at TEXT);
+    CREATE TABLE IF NOT EXISTS review_attention(review_id TEXT PRIMARY KEY REFERENCES reviews(id), viewed_at TEXT, deleted_at TEXT);
     CREATE TABLE IF NOT EXISTS repositories(id TEXT PRIMARY KEY, path TEXT NOT NULL UNIQUE, name TEXT NOT NULL);
     CREATE TABLE IF NOT EXISTS resources(id TEXT PRIMARY KEY, repository_id TEXT NOT NULL REFERENCES repositories(id),
       kind TEXT NOT NULL, mime_type TEXT NOT NULL, data BLOB NOT NULL);
@@ -2156,6 +2196,17 @@ function initializeReviewStoreSchema(db) {
     CREATE TABLE IF NOT EXISTS server_identity(one INTEGER PRIMARY KEY CHECK(one=1), id TEXT NOT NULL);
     DROP TABLE IF EXISTS authoring_drafts;
   `);
+	db.exec("BEGIN IMMEDIATE");
+	try {
+		if (db.prepare("PRAGMA table_info(review_attention)").all().some((column) => column.name === "dismissed_at")) {
+			db.exec("ALTER TABLE review_attention RENAME COLUMN dismissed_at TO deleted_at");
+			db.prepare("UPDATE review_attention SET deleted_at=? WHERE deleted_at IS NOT NULL").run((/* @__PURE__ */ new Date()).toISOString());
+		}
+		db.exec("COMMIT");
+	} catch (error) {
+		db.exec("ROLLBACK");
+		throw error;
+	}
 }
 //#endregion
 //#region src/review-api/store.ts
@@ -2176,14 +2227,15 @@ const commandSchema = z.strictObject({ operation: z.discriminatedUnion("type", [
 		type: z.literal("delete"),
 		reviewId
 	}),
+	z.strictObject({
+		type: z.literal("lifecycle"),
+		reviewId,
+		state: z.enum(["active", "trash"])
+	}),
 	z.strictObject({
 		type: z.literal("attention"),
 		reviewId,
-		action: z.enum([
-			"view",
-			"dismiss",
-			"restore"
-		])
+		action: z.literal("view")
 	}),
 	z.strictObject({
 		type: z.literal("create"),
@@ -2241,6 +2293,7 @@ var ReviewStore = class {
 	liveSources = /* @__PURE__ */ new Map();
 	refreshTimer;
 	refreshSubscribers = 0;
+	purgeTimer;
 	watchWorktrees() {
 		this.refreshSubscribers++;
 		this.refreshTimer ??= setInterval(() => {
@@ -2284,6 +2337,7 @@ var ReviewStore = class {
 		if (this.refreshPending) return this.refreshPending;
 		const run = this.pending.then(async () => {
 			for (const summary of this.list()) {
+				if (summary.trashedAt) continue;
 				const snapshot = this.read(summary.reviewId, summary.version);
 				try {
 					const live = this.liveSources.get(summary.reviewId);
@@ -2324,6 +2378,7 @@ var ReviewStore = class {
 	externalChanges;
 	observedDataVersion;
 	observedVersions = /* @__PURE__ */ new Map();
+	observedDeletions = /* @__PURE__ */ new Map();
 	subscribeCatalog(listener) {
 		this.catalogListeners.add(listener);
 		return () => {
@@ -2346,10 +2401,14 @@ var ReviewStore = class {
 		this.providers = providers;
 		this.db = new DatabaseSync(databasePath, { timeout: 5e3 });
 		initializeReviewStoreSchema(this.db);
-		this.activity = new ReviewActivity(this.db, (id) => this.assertExists(id));
+		this.activity = new ReviewActivity(this.db, (id) => this.assertWritable(id));
 		this.askHistory = new AskHistory(this.db);
+		this.purgeExpired();
+		this.purgeTimer = setInterval(() => this.purgeExpired(), 6e4);
+		this.purgeTimer.unref();
 		this.observedDataVersion = this.dataVersion();
 		this.observedVersions = this.currentVersions();
+		this.observedDeletions = this.currentDeletions();
 		this.externalChanges = setInterval(() => this.refreshExternalChanges(), 250);
 		this.externalChanges.unref();
 	}
@@ -2359,17 +2418,29 @@ var ReviewStore = class {
 	currentVersions() {
 		return new Map(this.db.prepare("SELECT id,version FROM reviews").all().map((row) => [String(row.id), Number(row.version)]));
 	}
+	currentDeletions() {
+		return new Map(this.db.prepare("SELECT review_id,deleted_at FROM review_attention WHERE deleted_at IS NOT NULL").all().map((row) => [String(row.review_id), String(row.deleted_at)]));
+	}
 	refreshExternalChanges() {
 		const version = this.dataVersion();
 		if (version === this.observedDataVersion) return;
 		this.observedDataVersion = version;
 		const current = this.currentVersions();
 		const previous = this.observedVersions;
+		const deletions = this.currentDeletions();
+		const previousDeletions = this.observedDeletions;
+		this.observedDeletions = deletions;
 		this.observedVersions = current;
 		for (const [reviewId, savedVersion] of current) if (previous.get(reviewId) !== savedVersion) this.notify({
 			reviewId,
 			version: savedVersion
 		});
+		else if (previousDeletions.get(reviewId) !== deletions.get(reviewId)) this.notify({
+			reviewId,
+			version: savedVersion,
+			lifecycle: true,
+			attention: true
+		});
 		for (const [reviewId, savedVersion] of previous) if (!current.has(reviewId)) {
 			this.activity.deleted(reviewId);
 			this.notify({
@@ -2392,9 +2463,10 @@ var ReviewStore = class {
 		}]));
 	}
 	updateViewedCoverage(reviewId, files, viewed) {
-		this.assertExists(reviewId);
+		this.assertWritable(reviewId);
 		this.db.exec("BEGIN IMMEDIATE");
 		try {
+			this.assertWritable(reviewId);
 			const current = this.viewedCoverage(reviewId);
 			for (const file of files) {
 				const previous = current.get(file.path);
@@ -2473,6 +2545,7 @@ var ReviewStore = class {
 		this.closing = true;
 		clearInterval(this.externalChanges);
 		clearInterval(this.refreshTimer);
+		clearInterval(this.purgeTimer);
 		await this.pending;
 		this.listeners.clear();
 		this.catalogListeners.clear();
@@ -2498,6 +2571,53 @@ var ReviewStore = class {
 	assertExists(id) {
 		if (!this.db.prepare("SELECT 1 FROM reviews WHERE id=?").get(id)) throw new ReviewInputError("Review not found. If this is an old Whiteboard review, ask your agent to migrate your old Whiteboard reviews.", 404);
 	}
+	assertWritable(id) {
+		this.assertExists(id);
+		const trashedAt = this.trashTime(id);
+		if (trashedAt) throw new ReviewInputError(`This whiteboard was moved to Trash on ${new Date(trashedAt).toLocaleDateString("en-US", {
+			month: "short",
+			day: "numeric"
+		})}. Restore it with session_lifecycle({"sessionId":"${id}","state":"active"}) to continue.`, 409);
+	}
+	trashTime(id) {
+		const row = this.db.prepare("SELECT deleted_at FROM review_attention WHERE review_id=?").get(id);
+		return row?.deleted_at ? String(row.deleted_at) : null;
+	}
+	removePermanently(id) {
+		for (const table of [
+			"ask_conversations",
+			"authoring_presences",
+			"review_coverage",
+			"review_attention",
+			"versions"
+		]) this.db.prepare(`DELETE FROM ${table} WHERE review_id=?`).run(id);
+		this.db.prepare("DELETE FROM reviews WHERE id=?").run(id);
+		this.liveSources.delete(id);
+	}
+	purgeExpired() {
+		const cutoff = (/* @__PURE__ */ new Date(Date.now() - 2592e6)).toISOString();
+		const expired = [];
+		this.db.exec("BEGIN IMMEDIATE");
+		try {
+			for (const row of this.db.prepare("SELECT review_id,version FROM review_attention JOIN reviews ON reviews.id=review_id WHERE deleted_at <= ?").all(cutoff)) {
+				const reviewId = String(row.review_id);
+				expired.push({
+					reviewId,
+					version: Number(row.version),
+					deleted: true
+				});
+				this.removePermanently(reviewId);
+			}
+			this.db.exec("COMMIT");
+		} catch (error) {
+			this.db.exec("ROLLBACK");
+			throw error;
+		}
+		for (const result of expired) {
+			this.activity.deleted(result.reviewId);
+			this.notify(result);
+		}
+	}
 	read(id, version) {
 		const row = version === void 0 ? this.db.prepare("SELECT snapshot FROM versions JOIN reviews ON reviews.id=review_id AND reviews.version=versions.version WHERE reviews.id=?").get(id) : this.db.prepare("SELECT snapshot FROM versions WHERE review_id=? AND version=?").get(id, version);
 		if (!row) {
@@ -2516,7 +2636,11 @@ var ReviewStore = class {
 			head: snapshot.pins.head
 		};
 		const live = version === void 0 ? this.liveSources.get(id) : void 0;
-		if (live?.version === snapshot.version) return structuredClone(live);
+		if (live?.version === snapshot.version) return {
+			...structuredClone(live),
+			trashedAt: this.trashTime(id)
+		};
+		snapshot.trashedAt = this.trashTime(id);
 		return snapshot;
 	}
 	setDiffStats(pins, stats, mode = "structural") {
@@ -2540,7 +2664,7 @@ var ReviewStore = class {
 	summaries(mode, id) {
 		const reviews = this.db.prepare(`SELECT json_remove(versions.snapshot,'$.document') AS summary,
           (SELECT json_extract(first.snapshot,'$.createdAt') FROM versions AS first WHERE first.review_id=reviews.id ORDER BY first.version LIMIT 1) AS first_created_at,
-          review_attention.viewed_at, review_attention.dismissed_at, repositories.name AS repository_name, repositories.path AS repository_path
+          review_attention.viewed_at, review_attention.deleted_at, repositories.name AS repository_name, repositories.path AS repository_path
         FROM reviews
         JOIN versions ON versions.review_id=reviews.id AND versions.version=reviews.version
         LEFT JOIN review_attention ON review_attention.review_id=reviews.id
@@ -2564,7 +2688,7 @@ var ReviewStore = class {
 				repositoryGroup: row.repository_path ? this.repositoryGroup(String(row.repository_path)) : void 0,
 				repositoryName: row.repository_name ? String(row.repository_name) : summary.pins?.repositoryId ?? "",
 				viewedAt: row.viewed_at ? String(row.viewed_at) : null,
-				dismissedAt: row.dismissed_at ? String(row.dismissed_at) : null,
+				trashedAt: row.deleted_at ? String(row.deleted_at) : null,
 				working: this.activity.isWorking(summary.reviewId)
 			};
 			if (summary.kind === "scratchpad") listed.contents = this.scratchpadContents();
@@ -2621,6 +2745,8 @@ var ReviewStore = class {
 		pullRequest?.catch(() => {});
 		const run = this.pending.then(async () => {
 			const op = command.operation;
+			this.purgeExpired();
+			if (op.type !== "create" && op.type !== "delete" && op.type !== "lifecycle") this.assertWritable(op.reviewId);
 			if (op.type !== "create" && op.type !== "edit" && op.type !== "lens_edit" && op.type !== "restore" && this.read(op.reviewId).kind === "scratchpad") throw new ReviewInputError("The scratchpad has no lifecycle, title or pins of its own.", 409);
 			if (op.type === "create" && op.kind === "scratchpad") {
 				if (op.target) throw new ReviewInputError("A scratchpad has no target of its own.");
@@ -2639,39 +2765,37 @@ var ReviewStore = class {
 				if (found) return this.existingReview(found, others, resolvedTarget.pins);
 			}
 			if (op.type === "delete") {
+				this.assertExists(op.reviewId);
+				if (!this.trashTime(op.reviewId)) throw new ReviewInputError("Move this whiteboard to Trash before deleting it.", 409);
 				const result = {
 					reviewId: op.reviewId,
 					version: this.read(op.reviewId).version,
 					deleted: true
 				};
-				this.commitCommand(result, () => {
-					for (const table of [
-						"ask_conversations",
-						"authoring_presences",
-						"review_coverage",
-						"review_attention",
-						"versions"
-					]) this.db.prepare(`DELETE FROM ${table} WHERE review_id=?`).run(op.reviewId);
-					this.db.prepare("DELETE FROM reviews WHERE id=?").run(op.reviewId);
-				}, () => this.assertMutation(op.reviewId, result.version));
+				this.commitCommand(result, () => this.removePermanently(op.reviewId), () => this.assertMutation(op.reviewId, result.version));
 				return result;
 			}
-			if (op.type === "attention") {
+			if (op.type === "attention" || op.type === "lifecycle") {
 				const result = {
 					reviewId: op.reviewId,
 					version: this.read(op.reviewId).version,
-					attention: true
+					attention: true,
+					...op.type === "lifecycle" && { lifecycle: true }
 				};
 				this.commitCommand(result, () => {
 					this.db.prepare("INSERT OR IGNORE INTO review_attention(review_id) VALUES(?)").run(op.reviewId);
-					if (op.action === "view") this.db.prepare("UPDATE review_attention SET viewed_at=? WHERE review_id=?").run((/* @__PURE__ */ new Date()).toISOString(), op.reviewId);
-					else this.db.prepare("UPDATE review_attention SET dismissed_at=? WHERE review_id=?").run(op.action === "dismiss" ? (/* @__PURE__ */ new Date()).toISOString() : null, op.reviewId);
+					if (op.type === "attention") this.db.prepare("UPDATE review_attention SET viewed_at=? WHERE review_id=?").run((/* @__PURE__ */ new Date()).toISOString(), op.reviewId);
+					else {
+						const timestamp = op.state === "trash" ? (/* @__PURE__ */ new Date()).toISOString() : null;
+						this.db.prepare("UPDATE review_attention SET deleted_at=CASE WHEN ? IS NULL THEN NULL ELSE COALESCE(deleted_at, ?) END WHERE review_id=?").run(timestamp, timestamp, op.reviewId);
+					}
 				});
 				return result;
 			}
 			const id = op.type !== "create" ? op.reviewId : op.kind === "scratchpad" ? SCRATCHPAD_ID : randomUUID();
 			const previous = op.type === "create" ? void 0 : this.read(id);
 			let snapshot = op.type === "create" ? createdSnapshot(id, op, resolvedTarget, fromPullRequest?.title) : structuredClone(previous);
+			delete snapshot.trashedAt;
 			delete snapshot.sourceUnavailable;
 			delete snapshot.lastEdit;
 			let nextId = previous ? Number(this.db.prepare("SELECT next_id FROM reviews WHERE id=?").get(id).next_id) : 0;
@@ -2760,7 +2884,10 @@ var ReviewStore = class {
 			this.commitCommand(result, () => {
 				this.db.prepare("INSERT INTO reviews(id,version,next_id) VALUES(?,?,?) ON CONFLICT(id) DO UPDATE SET version=excluded.version,next_id=excluded.next_id").run(id, snapshot.version, nextId);
 				this.db.prepare("INSERT INTO versions(review_id,version,snapshot) VALUES(?,?,?)").run(id, snapshot.version, JSON.stringify(snapshot));
-			}, previous ? () => this.assertMutation(id, previous.version) : void 0, op.type === "edit" || op.type === "lens_edit" ? {
+			}, previous ? () => {
+				this.assertWritable(id);
+				this.assertMutation(id, previous.version);
+			} : void 0, op.type === "edit" || op.type === "lens_edit" ? {
 				surface: op.type === "edit" ? "document" : "lenses",
 				activityId: op.activityId,
 				owned: (owner) => {
@@ -2778,6 +2905,11 @@ var ReviewStore = class {
 		if (op.type !== "create" || op.kind || op.target || !op.pullRequestUrl) return void 0;
 		if (!this.providers.resolvePullRequest) return Promise.reject(new ReviewInputError("Pull request targets are unavailable."));
 		const [existing] = op.reuseExisting === false ? [] : this.reviewsForPullRequest(op.pullRequestUrl);
+		if (existing) try {
+			this.assertReusableReview(existing);
+		} catch (error) {
+			return Promise.reject(error);
+		}
 		return this.providers.resolvePullRequest(op.pullRequestUrl, {
 			id: op.repositoryId,
 			preferred: existing && this.read(existing).pins?.repositoryId
@@ -2791,10 +2923,14 @@ var ReviewStore = class {
           AND COALESCE(json_extract(versions.snapshot,'$.origin.tutorial'), 0) = 0
         ORDER BY json_extract(versions.snapshot,'$.createdAt') DESC, reviews.rowid DESC`).all(pullRequestKey(url)).map((row) => String(row.id));
 	}
+	assertReusableReview(reviewId) {
+		if (this.trashTime(reviewId)) throw new ReviewInputError(`This PR's whiteboard is in Trash. Restore it to continue:\n\nsession_lifecycle({"sessionId":"${reviewId}","state":"active"})`, 409);
+	}
 	/** The answer to a create that found its PR's review. Its target stays:
 	* moving it would silently point existing links at different code. */
 	existingReview(reviewId, others, requested) {
 		const snapshot = this.read(reviewId);
+		this.assertReusableReview(reviewId);
 		const headMoved = snapshot.pins?.repositoryId !== requested.repositoryId || snapshot.pins?.head !== requested.head;
 		const working = this.activity.read(reviewId).activities ?? [];
 		return {
@@ -2840,16 +2976,16 @@ var ReviewStore = class {
 	notify(result) {
 		if (result.deleted) this.observedVersions.delete(result.reviewId);
 		else if (!result.attention) this.observedVersions.set(result.reviewId, result.version);
-		if (!result.attention) for (const listener of this.listeners) try {
+		if (!result.attention || result.lifecycle) for (const listener of this.listeners) try {
 			listener(result);
 		} catch {}
 		for (const listener of this.catalogListeners) try {
 			listener();
 		} catch {}
 	}
-	/** Dismissed reviews, as Home lists them; only a restore clears it, not a view. */
-	dismissedIds() {
-		return this.db.prepare("SELECT review_id FROM review_attention WHERE dismissed_at IS NOT NULL").all().map((row) => String(row.review_id));
+	/** Viewing a review in Trash does not restore it. */
+	trashedIds() {
+		return this.db.prepare("SELECT review_id FROM review_attention WHERE deleted_at IS NOT NULL").all().map((row) => String(row.review_id));
 	}
 	has(reviewId) {
 		return this.db.prepare("SELECT 1 FROM reviews WHERE id=?").get(reviewId) !== void 0;
@@ -2986,23 +3122,23 @@ var ReviewWorkspaces = class {
 		}
 		this.stop = store.subscribeCatalog(() => {
 			this.collect();
-			this.releaseDismissed();
+			this.releaseTrashed();
 		});
 		this.collect();
-		this.releaseDismissed();
+		this.releaseTrashed();
 	}
-	dismissed;
+	trashed;
 	releasing = /* @__PURE__ */ new Map();
 	/**
-	* Frees a newly dismissed review's checkouts to save disk. The review itself
+	* Frees a newly trashed review's checkouts to save disk. The review itself
 	* stays; reopening it rebuilds them. Checkouts rebuilt by peeking at a
-	* dismissed review are kept until the next startup or dismissal, since
+	* trashed review are kept until the next startup or move to Trash, since
 	* the Desktop's canvas tabs and source windows may still show them.
 	*/
-	releaseDismissed() {
-		const dismissed = new Set(this.store.dismissedIds());
-		const released = [...dismissed].filter((id) => !this.dismissed?.has(id));
-		this.dismissed = dismissed;
+	releaseTrashed() {
+		const trashed = new Set(this.store.trashedIds());
+		const released = [...trashed].filter((id) => !this.trashed?.has(id));
+		this.trashed = trashed;
 		if (!released.length) return;
 		const repositories = this.repositoryDirs();
 		repositories.catch(() => void 0);
@@ -3026,7 +3162,7 @@ var ReviewWorkspaces = class {
 			await Promise.allSettled(requests);
 			await this.releaseCheckouts(reviewId, await repositories);
 		}).catch((error) => {
-			console.error(`Could not free the pinned checkouts of dismissed review ${reviewId}:`, error);
+			console.error(`Could not free the pinned checkouts of trashed review ${reviewId}:`, error);
 		}).finally(() => {
 			if (this.releasing.get(reviewId) === done) this.releasing.delete(reviewId);
 		});
@@ -3034,7 +3170,7 @@ var ReviewWorkspaces = class {
 		this.cleanup = done;
 	}
 	async releaseCheckouts(reviewId, repositories) {
-		if (!this.store.dismissedIds().includes(reviewId)) return;
+		if (!this.store.trashedIds().includes(reviewId)) return;
 		const environments = this.all().filter((item) => item.reviewId === reviewId);
 		const checkouts = repositories.filter((repository) => existsSync(reviewManagedCheckoutRoot(repository, reviewId)));
 		if (!environments.length && !checkouts.length || !this.claim(reviewId)) return;
@@ -3350,7 +3486,43 @@ function rootEventMatters(name, tracked) {
 	if (file === ".git" || file.startsWith(".git/")) return false;
 	return !tracked || tracked.has(parent(file));
 }
+/** A directory appearing at the edge of the tracked tree may be newly ignored. */
+function atTrackedEdge(name, tracked) {
+	const file = normalize(name);
+	return !!tracked && tracked.has(parent(file)) && !tracked.has(file);
+}
+/** Wholly ignored directories, so watchers can skip them. */
+async function ignoredDirectories(rootPath, gitDirectory) {
+	try {
+		const { stdout } = await exec$1("git", [
+			"-C",
+			rootPath,
+			...gitDirectory ? [
+				"--git-dir",
+				gitDirectory,
+				"--work-tree",
+				rootPath
+			] : [],
+			"ls-files",
+			"-z",
+			"--others",
+			"--ignored",
+			"--exclude-standard",
+			"--directory"
+		], { maxBuffer: 33554432 });
+		return stdout.split("\0").filter((entry) => entry.endsWith("/") && entry !== ".jj/").map((entry) => entry.slice(0, -1));
+	} catch {
+		return [];
+	}
+}
 const CHECKOUT_STATE = /^(?:index|[A-Z_]+|(?:rebase-merge|rebase-apply|sequencer|refs\/(?:bisect|worktree|rewritten))(?:\/.*)?)$/;
+/** Objects, reflogs, LFS objects and Review's own checkouts; never watched. */
+const INERT_GIT_PATHS = [
+	"objects",
+	"logs",
+	"lfs",
+	"dev-fast"
+];
 /** Objects, reflogs, locks and other checkouts' state cannot change this one. */
 function gitEventMatters(name, prefix) {
 	const file = normalize(name);
@@ -3762,7 +3934,7 @@ var LocalReviewData = class {
 	worktrees = /* @__PURE__ */ new Map();
 	forgetWorktree(repositoryId) {
 		const entry = this.worktrees.get(repositoryId);
-		if (entry) for (const watcher of entry.watchers) watcher.close();
+		if (entry) unwatch(entry);
 		this.worktrees.delete(repositoryId);
 	}
 	async worktreeState(repositoryId, vcs) {
@@ -3771,33 +3943,59 @@ var LocalReviewData = class {
 			entry = {
 				epoch: 0,
 				inspectedEpoch: -1,
-				watchers: [],
+				subscriptions: /* @__PURE__ */ new Map(),
 				healthy: true,
 				forks: /* @__PURE__ */ new Map()
 			};
 			this.worktrees.set(repositoryId, entry);
 			const state = entry;
+			const current = () => this.worktrees.get(repositoryId) === state;
 			const common = await gitCommonDir(vcs.rootPath);
 			const prefix = vcs.kind === "git" && common ? await gitDirectoryPrefix(vcs.rootPath, common) : null;
-			const roots = /* @__PURE__ */ new Map([[vcs.rootPath, (name) => prefix === null || rootEventMatters(name, state.tracked)]]);
-			if (common) roots.set(common, (name) => prefix === null || gitEventMatters(name, prefix));
-			for (const [root, matters] of roots) try {
-				const watcher = (this.options.watch ?? watch)(root, { recursive: true }, (_event, name) => {
-					if (name === null || matters(String(name))) state.epoch++;
-				});
-				watcher.on("error", () => {
-					state.epoch++;
-					state.inspectedEpoch = -1;
+			const watch = async (root, ignore, matters) => {
+				try {
+					const subscription = await (this.options.subscribe ?? (await import("@parcel/watcher")).subscribe)(root, (error, events) => {
+						if (error) {
+							state.healthy = false;
+							const failed = state.subscriptions.get(root);
+							if (failed) release(failed);
+							state.subscriptions.delete(root);
+						} else if (events.map((event) => matters(path.relative(root, event.path), event)).includes(true)) state.epoch++;
+					}, { ignore });
+					if (!current()) return void release(subscription);
+					const previous = state.subscriptions.get(root);
+					state.subscriptions.set(root, subscription);
+					if (previous) release(previous);
+				} catch {
 					state.healthy = false;
-					watcher.close();
-				});
-				watcher.unref();
-				state.watchers.push(watcher);
-			} catch {
-				state.healthy = false;
-			}
+				}
+			};
+			const rootIgnore = async () => [...common ? [".git"] : [], ...await ignoredDirectories(vcs.rootPath, vcs.kind === "jj" ? common ?? void 0 : void 0)].map((directory) => path.join(vcs.rootPath, directory));
+			let ignored = await rootIgnore();
+			const refreshIgnored = () => {
+				clearTimeout(state.ignoring);
+				state.ignoring = setTimeout(async () => {
+					const next = await rootIgnore();
+					if (!current() || next.join("\0") === ignored.join("\0")) return;
+					ignored = next;
+					const previous = state.subscriptions.get(vcs.rootPath);
+					state.subscriptions.delete(vcs.rootPath);
+					if (previous) await release(previous);
+					await watch(vcs.rootPath, ignored, rootMatters);
+					state.epoch++;
+				}, 1e3);
+				state.ignoring.unref();
+			};
+			const rootMatters = (name, event) => {
+				if (path.basename(name) === ".gitignore" || event.type === "create" && atTrackedEdge(name, state.tracked) && statSync(event.path, { throwIfNoEntry: false })?.isDirectory()) refreshIgnored();
+				return prefix === null || rootEventMatters(name, state.tracked);
+			};
+			await Promise.all([watch(vcs.rootPath, ignored, rootMatters), common && watch(common, INERT_GIT_PATHS.map((directory) => path.join(common, directory)), (name) => {
+				if (name === path.join("info", "exclude")) refreshIgnored();
+				return prefix === null || gitEventMatters(name, prefix);
+			})]);
 		}
-		if (entry.inspection && entry.inspectedEpoch === entry.epoch && entry.healthy && entry.watchers.length) return {
+		if (entry.inspection && entry.inspectedEpoch === entry.epoch && entry.healthy && entry.subscriptions.size) return {
 			...entry.inspection,
 			forks: entry.forks
 		};
@@ -3820,7 +4018,7 @@ var LocalReviewData = class {
 		this.structuralComparisons.close();
 		this.closed = true;
 		await this.workspaceManager?.close();
-		for (const entry of this.worktrees.values()) for (const watcher of entry.watchers) watcher.close();
+		await Promise.all([...this.worktrees.values()].map(unwatch));
 		this.worktrees.clear();
 		const readers = [...this.readers.values()];
 		this.readers.clear();
@@ -4445,6 +4643,14 @@ function inputError(run) {
 		throw error;
 	}
 }
+async function unwatch(entry) {
+	clearTimeout(entry.ignoring);
+	const subscriptions = [...entry.subscriptions.values()];
+	entry.subscriptions.clear();
+	await Promise.all(subscriptions.map(release));
+}
+/** Linux fails to unwatch a directory that is already gone. */
+const release = (subscription) => subscription.unsubscribe().catch(() => {});
 function openLocalReviewStore(databasePath, options = {}) {
 	const store = new ReviewStore(databasePath, {
 		projectSource: (snapshot, pins) => data.projectSource(snapshot, pins),