@dev-loops/core 1.0.2-pre.0 → 1.0.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +3 -1
- package/src/analysis/diff-analyzer.mjs +85 -137
- package/src/claude/asset-generation.mjs +7 -7
- package/src/claude/hook-decisions.mjs +29 -36
- package/src/config/config.mjs +410 -787
- package/src/config/extension-defaults.yaml +17 -0
- package/src/github/closing-ref-guard.mjs +80 -0
- package/src/github/comment-id-guard.mjs +2 -2
- package/src/github/copilot-helpers.mjs +90 -158
- package/src/loop/bash-command-classify.mjs +34 -49
- package/src/loop/conductor-routing.mjs +15 -23
- package/src/loop/copilot-loop-state.mjs +46 -94
- package/src/loop/gate-carry-forward.mjs +2 -2
- package/src/loop/gate-fanin.mjs +252 -442
- package/src/loop/handoff-envelope.mjs +132 -25
- package/src/loop/issue-refinement-artifact.mjs +188 -263
- package/src/loop/lifecycle-state.mjs +10 -21
- package/src/loop/pr-gate-coordination.mjs +37 -37
- package/src/loop/queue-board-sync.mjs +16 -55
- package/src/loop/retrospective-checkpoint.mjs +7 -8
- package/src/loop/review-dispatch-plan.mjs +60 -122
- package/src/loop/review-lineage.mjs +19 -44
- package/src/loop/spec-authority.mjs +39 -69
- package/src/loop/steering.mjs +16 -68
- package/src/loop/worktree-guard.mjs +80 -13
- package/src/projects/list-queue-items.mjs +16 -146
- package/src/projects/move-queue-item.mjs +15 -141
- package/src/projects/projects-access.mjs +202 -0
|
@@ -195,6 +195,17 @@ gates:
|
|
|
195
195
|
fanout:
|
|
196
196
|
maxAnglesPerGroup: 3
|
|
197
197
|
maxConcurrent: 4
|
|
198
|
+
# The table is global; a group is only emitted for a gate that actually
|
|
199
|
+
# resolves at least one of its angles, so a group naming preApproval-only
|
|
200
|
+
# angles is inert for the draft/spike gates (their angle sets never include
|
|
201
|
+
# these), and vice versa. The first four groups name draft-gate surfaces;
|
|
202
|
+
# the design-* and finalization groups name preApproval-exclusive angles so
|
|
203
|
+
# a grouped preApproval round collapses to one reviewer per group instead of
|
|
204
|
+
# scattering those angles across arbitrary auto-chunked leftover units.
|
|
205
|
+
# finalization names only correctness-final/ui-validation: contradiction-lens
|
|
206
|
+
# is deliberately NOT grouped here because it is also a draft-gate angle, and
|
|
207
|
+
# a global group naming it would peel it into a finalization unit in the draft
|
|
208
|
+
# gate too. It stays an auto-chunk leftover in both gates.
|
|
198
209
|
groups:
|
|
199
210
|
- name: docs-surface
|
|
200
211
|
angles: [docs, link-check, config-drift, contract-surface]
|
|
@@ -204,6 +215,12 @@ gates:
|
|
|
204
215
|
angles: [correctness, input-validation]
|
|
205
216
|
- name: determinism-state
|
|
206
217
|
angles: [determinism, state-concurrency]
|
|
218
|
+
- name: design-simplicity
|
|
219
|
+
angles: [dry, kiss, yagni, deep]
|
|
220
|
+
- name: design-solid
|
|
221
|
+
angles: [srp, soc, ocp, lsp, isp, dip]
|
|
222
|
+
- name: finalization
|
|
223
|
+
angles: [correctness-final, ui-validation]
|
|
207
224
|
preApproval:
|
|
208
225
|
angles:
|
|
209
226
|
- name: dry
|
|
@@ -0,0 +1,80 @@
|
|
|
1
|
+
// Canonical closing-reference primitives shared by the create-pr / edit-pr
|
|
2
|
+
// wrappers so both guard a body's closing reference against the branch's own
|
|
3
|
+
// resolved issue with one implementation. A body swap that re-points the
|
|
4
|
+
// reference at a different issue would otherwise pass silently, and a merge
|
|
5
|
+
// would then close the wrong issue — this is the fail-closed backstop against
|
|
6
|
+
// that data-integrity hole.
|
|
7
|
+
|
|
8
|
+
import { extractClosingIssueNumbers as extractCanonicalClosingRefs } from "../loop/issue-refinement-artifact.mjs";
|
|
9
|
+
|
|
10
|
+
// Every issue number the body's closing references name. Delegates to the ONE
|
|
11
|
+
// canonical body-spec parser so the closing-keyword vocabulary (close/closes/
|
|
12
|
+
// closed, fix/fixes/fixed, resolve/resolves/resolved, any case), the cross-repo
|
|
13
|
+
// `owner/repo#N` form, fenced/inline-code stripping (a `Closes #N` inside a
|
|
14
|
+
// ```fenced``` example or `inline code` span does not auto-close on GitHub and
|
|
15
|
+
// must not spoof the guard), and de-duplication stay owned in ONE place — the
|
|
16
|
+
// guard never re-implements them.
|
|
17
|
+
export function extractClosingIssueNumbers(body) {
|
|
18
|
+
if (!body || typeof body !== "string") return [];
|
|
19
|
+
return extractCanonicalClosingRefs(body);
|
|
20
|
+
}
|
|
21
|
+
|
|
22
|
+
// True when the body carries any closing keyword.
|
|
23
|
+
export function detectClosingKeyword(body) {
|
|
24
|
+
return extractClosingIssueNumbers(body).length > 0;
|
|
25
|
+
}
|
|
26
|
+
|
|
27
|
+
// The issue number from the body's first closing reference, or null when the
|
|
28
|
+
// body carries none. Back-compat surface (create-pr's `--issue` missing-reference
|
|
29
|
+
// check); the mismatch guard uses extractClosingIssueNumbers to see every one.
|
|
30
|
+
export function extractClosingIssueNumber(body) {
|
|
31
|
+
const all = extractClosingIssueNumbers(body);
|
|
32
|
+
return all.length > 0 ? all[0] : null;
|
|
33
|
+
}
|
|
34
|
+
|
|
35
|
+
// Branch slug `[<prefix>/]issue-<N>[-<slug>]` -> N. Matches the dev-loop
|
|
36
|
+
// worktree default branch name and the prefixed form (e.g. a `dl/`-prefixed
|
|
37
|
+
// slug). Returns null when the branch encodes no issue number.
|
|
38
|
+
const BRANCH_ISSUE_PATTERN = /(?:^|\/)issue-(\d+)(?:-|$)/u;
|
|
39
|
+
export function extractIssueFromBranchSlug(branch) {
|
|
40
|
+
if (!branch || typeof branch !== "string") return null;
|
|
41
|
+
const match = BRANCH_ISSUE_PATTERN.exec(branch.trim());
|
|
42
|
+
return match ? Number(match[1]) : null;
|
|
43
|
+
}
|
|
44
|
+
|
|
45
|
+
// Resolve the issue a PR is expected to close from its own facts. The branch
|
|
46
|
+
// slug is authoritative (it encodes the issue the loop cut the branch for);
|
|
47
|
+
// the PR's GitHub-derived closingIssuesReferences is the fallback. Returns null
|
|
48
|
+
// when neither yields an issue — a genuinely issue-less PR, which is exempt.
|
|
49
|
+
export function resolveExpectedIssueFromPrContext(ctx) {
|
|
50
|
+
if (!ctx || typeof ctx !== "object") return null;
|
|
51
|
+
const fromBranch = extractIssueFromBranchSlug(ctx.headRefName);
|
|
52
|
+
if (fromBranch !== null) return fromBranch;
|
|
53
|
+
const refs = Array.isArray(ctx.closingIssuesReferences) ? ctx.closingIssuesReferences : [];
|
|
54
|
+
for (const ref of refs) {
|
|
55
|
+
const n = typeof ref === "number" ? ref : Number(ref?.number);
|
|
56
|
+
if (Number.isInteger(n) && n > 0) return n;
|
|
57
|
+
}
|
|
58
|
+
return null;
|
|
59
|
+
}
|
|
60
|
+
|
|
61
|
+
// Compare the body's closing reference against the branch's resolved issue.
|
|
62
|
+
// Returns a named refusal string when they disagree, else null. A waiver
|
|
63
|
+
// bypasses; an unresolved expected issue (issue-less) is exempt; a body with no
|
|
64
|
+
// closing reference has nothing to mislink and is exempt (only a present-and-
|
|
65
|
+
// disagreeing reference is refused, never a missing one).
|
|
66
|
+
export function resolveClosingRefMismatch({ body, expectedIssue, allowCrossIssue = false }) {
|
|
67
|
+
if (allowCrossIssue) return null;
|
|
68
|
+
if (!Number.isInteger(expectedIssue)) return null;
|
|
69
|
+
const closing = extractClosingIssueNumbers(body);
|
|
70
|
+
if (closing.length === 0) return null;
|
|
71
|
+
// Refuse when ANY closing reference disagrees — GitHub closes every one, so a
|
|
72
|
+
// correct first reference does not excuse a wrong second (a single-issue
|
|
73
|
+
// dev-loop PR closes only its branch's issue; a deliberate multi/cross-issue
|
|
74
|
+
// reference uses the waiver).
|
|
75
|
+
const disagreeing = closing.find((n) => n !== expectedIssue);
|
|
76
|
+
if (disagreeing !== undefined) {
|
|
77
|
+
return `CLOSING-REF-BRANCH-MISMATCH: the body closes #${disagreeing} but the branch resolves to issue #${expectedIssue} — refusing a mismatched closing reference (pass --allow-cross-issue to record a deliberate cross-issue reference)`;
|
|
78
|
+
}
|
|
79
|
+
return null;
|
|
80
|
+
}
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
/**
|
|
2
2
|
* ISSUE/PR-ID GUARD for generated comment bodies.
|
|
3
3
|
*
|
|
4
|
-
* Mandate (
|
|
4
|
+
* Mandate (operator directive): generated gate/review/verdict comment
|
|
5
5
|
* bodies must NEVER emit raw issue or PR ids. Public comment surfaces are
|
|
6
6
|
* world-readable, and a bare `#<digits>` in a comment body is auto-linked by
|
|
7
7
|
* GitHub to that issue/PR — leaking internal cross-references and violating
|
|
@@ -119,7 +119,7 @@ export function extractIssuePrIds(body) {
|
|
|
119
119
|
const BARE_ISSUE_PR_ID_RE = /#+(?=\d)/g;
|
|
120
120
|
|
|
121
121
|
/**
|
|
122
|
-
* The sanctioned pre-guard transform for GENERATED comment bodies
|
|
122
|
+
* The sanctioned pre-guard transform for GENERATED comment bodies:
|
|
123
123
|
* neutralize a bare `#<digits>` auto-link token to a guard-safe, non-auto-linking
|
|
124
124
|
* form by stripping the leading `#` (`#123` -> `123`). Auto-link syntax requires
|
|
125
125
|
* the leading `#`, so the result neither auto-links on GitHub nor trips
|
|
@@ -1,44 +1,34 @@
|
|
|
1
1
|
/**
|
|
2
2
|
* Shared deterministic helpers for Copilot-related GitHub data.
|
|
3
|
-
*
|
|
4
|
-
* These are pure functions with no filesystem or network dependencies.
|
|
5
|
-
* Owner: packages/core — reusable deterministic logic consumed by both
|
|
6
|
-
* scripts and other packages/core modules.
|
|
3
|
+
* Pure functions with no filesystem or network dependencies.
|
|
7
4
|
*/
|
|
8
5
|
|
|
9
6
|
import { GATE_REVIEW_VERDICT_SET } from "../loop/policy-constants.mjs";
|
|
10
7
|
import { trimmedOrNull } from "../loop/normalize.mjs";
|
|
11
8
|
|
|
12
|
-
//
|
|
13
|
-
// whitelist as the loop-state reader — two copies could drift, and a guard
|
|
9
|
+
// Same whitelist as the loop-state reader: two copies could drift, and a guard
|
|
14
10
|
// acting on the gate's behalf must agree with the gate about what a submitted
|
|
15
11
|
// review is.
|
|
16
12
|
export const SUBMITTED_REVIEW_STATES = new Set(["APPROVED", "CHANGES_REQUESTED", "COMMENTED", "DISMISSED"]);
|
|
17
13
|
const GATE_REVIEW_NAMES = new Set(["draft_gate", "pre_approval_gate"]);
|
|
18
|
-
// `review`
|
|
19
|
-
//
|
|
20
|
-
//
|
|
21
|
-
//
|
|
22
|
-
//
|
|
23
|
-
//
|
|
24
|
-
//
|
|
25
|
-
// let a `review` verdict whose findings text merely MENTIONED "draft_gate"
|
|
26
|
-
// get recorded as real draft-gate evidence (a draft-gate bypass).
|
|
14
|
+
// `review` is a RECOGNIZED gate header that carries no draft/pre-approval
|
|
15
|
+
// evidence by design. Recognizing it lets
|
|
16
|
+
// parseGateReviewCommentFields short-circuit to null on a `review` header
|
|
17
|
+
// instead of falling through to the lenient draft_gate/pre_approval_gate token
|
|
18
|
+
// scan — the fallthrough that would otherwise record a `review` verdict whose
|
|
19
|
+
// findings merely mention "draft_gate" as real draft-gate evidence (a
|
|
20
|
+
// draft-gate bypass).
|
|
27
21
|
const NON_EVIDENCE_GATE_NAMES = new Set(["review"]);
|
|
28
22
|
const RECOGNIZED_GATE_NAMES = new Set([...GATE_REVIEW_NAMES, ...NON_EVIDENCE_GATE_NAMES]);
|
|
29
23
|
const GATE_EXECUTION_MODES = new Set(["fanout_fanin", "inline_single_agent"]);
|
|
30
|
-
// Size-budget outcome vocabulary
|
|
31
|
-
//
|
|
32
|
-
// never recomputes the outcome, only round-trips it through the verdict
|
|
33
|
-
// comment.
|
|
24
|
+
// Size-budget outcome vocabulary; mirrors check-size-budget.mjs's
|
|
25
|
+
// computeSizeBudget outcome enum exactly. This file only round-trips it.
|
|
34
26
|
const GATE_SIZE_OUTCOMES = new Set(["pass", "escalate", "block"]);
|
|
35
27
|
|
|
36
|
-
// The literal header line the gate review body
|
|
37
|
-
//
|
|
38
|
-
//
|
|
39
|
-
//
|
|
40
|
-
// the same producer-owned literal instead of restating it. Line-start anchored
|
|
41
|
-
// (`m`) so a quoted header in a reply/blockquote can't match.
|
|
28
|
+
// The literal header line the gate review body emits first (producer:
|
|
29
|
+
// upsert-checkpoint-verdict.mjs's renderGateReviewCommentBody). Owned here so
|
|
30
|
+
// every consumer reads the same literal instead of restating it. Line-start
|
|
31
|
+
// anchored (`m`) so a quoted header in a reply/blockquote can't match.
|
|
42
32
|
export const GATE_REVIEW_COMMENT_HEADER_RE = /^###\s+Gate review:\s*`(draft_gate|pre_approval_gate)`\s*$/m;
|
|
43
33
|
|
|
44
34
|
/** Returns the matched gate name when `body` carries a genuine gate verdict header, else null. */
|
|
@@ -49,48 +39,31 @@ export function matchGateReviewCommentHeader(body) {
|
|
|
49
39
|
}
|
|
50
40
|
|
|
51
41
|
// Machine-authored gate artifacts that must never win the newest-gate-marker
|
|
52
|
-
// tie-break in
|
|
53
|
-
//
|
|
54
|
-
//
|
|
55
|
-
//
|
|
56
|
-
//
|
|
57
|
-
// historical deferred-summary PR comment quoted a gate name plus a sha-shaped
|
|
58
|
-
// id in its table rows the same way. Both are excluded HERE, inside the two
|
|
59
|
-
// shared summarizers, because this module is the true merge point: every
|
|
60
|
-
// consumer (detect-checkpoint-evidence.mjs, pre-pr-ready-gate.mjs,
|
|
61
|
-
// ready-for-review.mjs, request-copilot-review.mjs) calls
|
|
62
|
-
// summarizeGateReviewComments/summarizeGateReviewCommentMarkers to turn a raw
|
|
63
|
-
// comment/review list into a gate verdict, so filtering here — rather than
|
|
64
|
-
// per-caller — covers all of them by construction.
|
|
42
|
+
// tie-break in the two summarizers below: a historical standalone findings
|
|
43
|
+
// review or deferred-summary comment embeds a gate name and a sha-shaped id
|
|
44
|
+
// that the lenient parseGateReviewCommentFields fallback would otherwise match.
|
|
45
|
+
// Excluded here because this module is the merge point every consumer routes
|
|
46
|
+
// through.
|
|
65
47
|
//
|
|
66
|
-
//
|
|
67
|
-
//
|
|
68
|
-
//
|
|
69
|
-
//
|
|
70
|
-
//
|
|
71
|
-
//
|
|
72
|
-
//
|
|
73
|
-
//
|
|
74
|
-
//
|
|
75
|
-
// deferred-summary comment. Without the findings-comment marker, that comment
|
|
76
|
-
// parses as a verdict marker candidate (its "Gate fan-out findings:"/
|
|
77
|
-
// "Reviewed head:" lines yield gate+headSha) and the verdict upsert claims
|
|
78
|
-
// and overwrites it in place, silently destroying the round's visible
|
|
79
|
-
// findings record. Every branch is delimiter-anchored — the token must be
|
|
80
|
-
// followed by whitespace or the closing `-->` — so no suffixed `<token>-<x>`
|
|
81
|
-
// variant ever matches.
|
|
48
|
+
// Line-anchored (`^` with `m`) so only a marker at column 0 is excluded; a
|
|
49
|
+
// genuine verdict whose findings merely QUOTE the marker mid-line still counts.
|
|
50
|
+
// The set covers exactly three tokens: the per-round review marker
|
|
51
|
+
// (gate-findings-review), post-gate-findings.mjs's findings-COMMENT marker
|
|
52
|
+
// (gate-findings), and the deferred-summary comment. Without the
|
|
53
|
+
// findings-comment marker, that comment parses as a verdict candidate and the
|
|
54
|
+
// verdict upsert overwrites it in place, silently destroying the round's
|
|
55
|
+
// findings record. Every branch is delimiter-anchored (token followed by
|
|
56
|
+
// whitespace or `-->`) so no suffixed `<token>-<x>` variant matches.
|
|
82
57
|
const GATE_MACHINE_ARTIFACT_MARKER_RE = /^<!--\s*dev-loops:(?:gate-findings-review|gate-findings|deferred-summary)(?=\s|-->)/mu;
|
|
83
58
|
|
|
84
59
|
export function isGateMachineArtifactBody(body) {
|
|
85
60
|
if (typeof body !== "string" || !GATE_MACHINE_ARTIFACT_MARKER_RE.test(body)) {
|
|
86
61
|
return false;
|
|
87
62
|
}
|
|
88
|
-
// A gate round
|
|
89
|
-
//
|
|
90
|
-
//
|
|
91
|
-
//
|
|
92
|
-
// marker-bearing body with NO genuine verdict header (a historical standalone
|
|
93
|
-
// findings review or deferred-summary comment) stays excluded.
|
|
63
|
+
// A gate round posts ONE PR review carrying BOTH the verdict header and the
|
|
64
|
+
// gate-findings-review marker. Such a body IS the verdict, so the
|
|
65
|
+
// producer-owned header wins over the artifact marker. Only a marker-bearing
|
|
66
|
+
// body with NO verdict header stays excluded.
|
|
94
67
|
return matchGateReviewCommentHeader(body) === null;
|
|
95
68
|
}
|
|
96
69
|
|
|
@@ -101,16 +74,10 @@ export function isCopilotLogin(login) {
|
|
|
101
74
|
/**
|
|
102
75
|
* Resolve whether Copilot is present as a reviewer on a PR from the REVIEW
|
|
103
76
|
* surface only — requested reviewers plus submitted reviews — never from
|
|
104
|
-
* assignees
|
|
105
|
-
*
|
|
106
|
-
*
|
|
107
|
-
*
|
|
108
|
-
* (`copilot-pull-request-reviewer[bot]`) that submits an actual review without
|
|
109
|
-
* ever appearing in `requested_reviewers`. Both are review-surface facts.
|
|
110
|
-
* Assignment is a disjoint surface and must never decide presence: on a
|
|
111
|
-
* reviewer-configured repo Copilot is never an assignee, so an assignee-based
|
|
112
|
-
* proxy would falsely report a fully-configured Copilot reviewer as absent and
|
|
113
|
-
* could let the gate skip the Copilot-convergence requirement on a false premise.
|
|
77
|
+
* assignees. Assignment is a disjoint surface: on a reviewer-configured
|
|
78
|
+
* repo Copilot is never an assignee, so an assignee-based proxy would falsely
|
|
79
|
+
* report a configured Copilot reviewer as absent and let the gate skip the
|
|
80
|
+
* Copilot-convergence requirement on a false premise.
|
|
114
81
|
*
|
|
115
82
|
* @param {object} params
|
|
116
83
|
* @param {boolean} [params.requested] - Copilot is listed in the PR's requested_reviewers
|
|
@@ -129,12 +96,12 @@ export function resolveCopilotReviewPresence({ requested = false, reviews = [] }
|
|
|
129
96
|
return { present: sources.length > 0, sources };
|
|
130
97
|
}
|
|
131
98
|
|
|
132
|
-
// Anti-summon literal: bare-text `@copilot` or a `/copilot*` slash command.
|
|
133
|
-
// the write-side sanitizer and the read-side guard
|
|
134
|
-
// gate-evidence comment can quote the rule (
|
|
135
|
-
//
|
|
136
|
-
//
|
|
137
|
-
//
|
|
99
|
+
// Anti-summon literal: bare-text `@copilot` or a `/copilot*` slash command.
|
|
100
|
+
// Both the write-side sanitizer and the read-side guard key off this shape so a
|
|
101
|
+
// gate-evidence comment can quote the rule (in a code span/fence) without arming
|
|
102
|
+
// the request-copilot-review.mjs anti-summon guard. The token regex carries the
|
|
103
|
+
// same left word-boundary as the guard regex so the sanitizer never mangles text
|
|
104
|
+
// the guard would not arm on (e.g. user@copilot.example).
|
|
138
105
|
const COPILOT_SUMMON_TOKEN_RE = /(?<=^|\W)(@copilot|\/copilot[a-z0-9_-]*)/gi;
|
|
139
106
|
const COPILOT_SUMMON_WORD_BOUNDARY_RE = /(?:^|\W)(@copilot|\/copilot)(?:$|\W)/i;
|
|
140
107
|
// GFM inline code span: an N-backtick run, lazy content, closed by a same-length
|
|
@@ -145,8 +112,6 @@ const ZERO_WIDTH_JOINER = "\u200D";
|
|
|
145
112
|
|
|
146
113
|
// Apply `transformLine` to every markdown line OUTSIDE a fenced code block
|
|
147
114
|
// (```/~~~), leaving fence-delimiter lines and fenced content untouched.
|
|
148
|
-
// Mirrors the fenced-block tracking scripts/docs/validate-rule-ownership.mjs
|
|
149
|
-
// uses for its own lexical scan.
|
|
150
115
|
function transformNonFencedLines(text, transformLine) {
|
|
151
116
|
const lines = String(text).split(/\r?\n/);
|
|
152
117
|
let inFencedBlock = false;
|
|
@@ -207,19 +172,15 @@ function lineArmsSummonGuard(line) {
|
|
|
207
172
|
const ZWJ_FALLBACK_RE = /(?<=^|\W)([@/])(copilot)/gi;
|
|
208
173
|
|
|
209
174
|
// Sanitize one line, verifying against the guard scan. Backtick-wrapping is the
|
|
210
|
-
// primary neutralization (visible, greppable), but pre-existing backticks
|
|
211
|
-
//
|
|
212
|
-
//
|
|
213
|
-
//
|
|
214
|
-
//
|
|
215
|
-
//
|
|
216
|
-
//
|
|
217
|
-
//
|
|
218
|
-
//
|
|
219
|
-
// spans — invisible, guard-inert, and idempotent (the joined token no longer
|
|
220
|
-
// matches the summon shape). Working on the wrapped line (not the original)
|
|
221
|
-
// preserves every stable backtick wrap and keeps the joiner out of legitimate
|
|
222
|
-
// pre-existing code spans.
|
|
175
|
+
// primary neutralization (visible, greppable), but pre-existing backticks can
|
|
176
|
+
// destabilize it: an unbalanced stray backtick re-exposes the token to the
|
|
177
|
+
// guard's span-stripping, and adjacent spans can make the wrapped line
|
|
178
|
+
// re-tokenize on the next pass and grow by a backtick per rewrite. So the
|
|
179
|
+
// wrapped result is accepted only when it is BOTH guard-inert AND a fixed point
|
|
180
|
+
// of the wrapper; otherwise fall back to a zero-width joiner in the residual
|
|
181
|
+
// tokens outside the wrapped line's spans — invisible, guard-inert, and
|
|
182
|
+
// idempotent. Working on the wrapped line preserves stable wraps and keeps the
|
|
183
|
+
// joiner out of legitimate pre-existing code spans.
|
|
223
184
|
function sanitizeSummonLine(line) {
|
|
224
185
|
const wrapped = wrapBareSummonTokensInLine(line);
|
|
225
186
|
if (!lineArmsSummonGuard(wrapped) && wrapBareSummonTokensInLine(wrapped) === wrapped) {
|
|
@@ -232,12 +193,10 @@ export function sanitizeCopilotSummonTokens(text) {
|
|
|
232
193
|
return transformNonFencedLines(String(text), sanitizeSummonLine);
|
|
233
194
|
}
|
|
234
195
|
|
|
235
|
-
// Drop all markdown code content (fenced blocks entirely, inline
|
|
236
|
-
//
|
|
237
|
-
// transformNonFencedLines
|
|
238
|
-
//
|
|
239
|
-
// must be REMOVED rather than kept: leaving it in place would let bare text
|
|
240
|
-
// inside a fence still match the anti-summon scan.
|
|
196
|
+
// Drop all markdown code content (fenced blocks entirely, inline spans per
|
|
197
|
+
// line) from `text`, leaving only bare-text markdown to scan. Unlike
|
|
198
|
+
// transformNonFencedLines, fenced content here must be REMOVED, not kept:
|
|
199
|
+
// leaving it would let bare text inside a fence still match the summon scan.
|
|
241
200
|
function stripMarkdownCodeForScan(text) {
|
|
242
201
|
const lines = String(text).split(/\r?\n/);
|
|
243
202
|
let inFencedBlock = false;
|
|
@@ -306,11 +265,10 @@ function stripGateCommentMarkdown(rawLine) {
|
|
|
306
265
|
return line.trim();
|
|
307
266
|
}
|
|
308
267
|
|
|
309
|
-
// Recognizes BOTH evidence gates
|
|
310
|
-
//
|
|
311
|
-
//
|
|
312
|
-
//
|
|
313
|
-
// null and falling through to the lenient token-scan fallback.
|
|
268
|
+
// Recognizes BOTH evidence gates and the non-evidence `review` gate:
|
|
269
|
+
// parseGateReviewCommentFields relies on `review` coming back identified (not
|
|
270
|
+
// null) so it can short-circuit rather than fall through to the lenient
|
|
271
|
+
// token-scan fallback.
|
|
314
272
|
function normalizeGateReviewName(value) {
|
|
315
273
|
const normalized = stripOptionalCodeTicks(value).toLowerCase();
|
|
316
274
|
return RECOGNIZED_GATE_NAMES.has(normalized) ? normalized : null;
|
|
@@ -383,21 +341,13 @@ function parseGateReviewCommentFields(body) {
|
|
|
383
341
|
}
|
|
384
342
|
const line = stripped;
|
|
385
343
|
|
|
386
|
-
// First-NON-EMPTY-wins per field:
|
|
387
|
-
// block
|
|
388
|
-
//
|
|
389
|
-
//
|
|
390
|
-
//
|
|
391
|
-
//
|
|
392
|
-
//
|
|
393
|
-
// `\s*(.+)$` also matches a label followed by nothing but whitespace,
|
|
394
|
-
// capturing an empty string — for the enum fields (gate/headSha/verdict/
|
|
395
|
-
// executionMode) an empty capture normalizes to null already, so the
|
|
396
|
-
// `=== null` guard below naturally stays open for a later, genuine line.
|
|
397
|
-
// The two free-text fields (findingsSummary, nextAction) do NOT normalize
|
|
398
|
-
// through an enum, so an empty capture must be checked for explicitly:
|
|
399
|
-
// treat it as no-capture (leave the field open) rather than locking it to
|
|
400
|
-
// "" and hiding a real line that renders after it.
|
|
344
|
+
// First-NON-EMPTY-wins per field: the first column-0 match is the genuine
|
|
345
|
+
// structured block. A later free-text field (findings, next action) can
|
|
346
|
+
// embed a spoofed "Verdict: clean" at column 0; capturing only the first
|
|
347
|
+
// match stops that from flipping the field. Enum fields normalize an empty
|
|
348
|
+
// capture (label + whitespace only) to null, so their `=== null` guard
|
|
349
|
+
// stays open for a later genuine line; the two free-text fields do NOT, so
|
|
350
|
+
// an empty capture is checked explicitly and treated as no-capture.
|
|
401
351
|
let match = line.match(/^(?:[-*]\s*)?(?:gate(?:\s+name)?|gate\s+review)\s*:\s*(.+)$/iu);
|
|
402
352
|
if (match) {
|
|
403
353
|
if (fields.gate === null) {
|
|
@@ -426,9 +376,7 @@ function parseGateReviewCommentFields(body) {
|
|
|
426
376
|
if (match) {
|
|
427
377
|
if (fields.findingsSummary === null) {
|
|
428
378
|
const candidate = match[1].trim();
|
|
429
|
-
//
|
|
430
|
-
// no-capture: leave the field open so a later, genuine line can still
|
|
431
|
-
// win instead of first-wins locking it to "".
|
|
379
|
+
// Empty capture treated as no-capture (see first-non-empty-wins above).
|
|
432
380
|
if (candidate.length > 0) {
|
|
433
381
|
fields.findingsSummary = candidate;
|
|
434
382
|
}
|
|
@@ -457,9 +405,8 @@ function parseGateReviewCommentFields(body) {
|
|
|
457
405
|
const modeToken = sepMatch ? sepMatch[1].trim() : rest;
|
|
458
406
|
const reasonToken = sepMatch ? sepMatch[2].trim() : "";
|
|
459
407
|
fields.executionMode = normalizeGateExecutionMode(modeToken);
|
|
460
|
-
// Only record an inline reason for inline_single_agent
|
|
461
|
-
// "— text" on
|
|
462
|
-
// inconsistent mode/reason pair, so leave inlineReason null otherwise.
|
|
408
|
+
// Only record an inline reason for inline_single_agent; a trailing
|
|
409
|
+
// "— text" on any other mode must not surface an inconsistent pair.
|
|
463
410
|
if (reasonToken.length > 0 && fields.executionMode === "inline_single_agent") {
|
|
464
411
|
fields.inlineReason = reasonToken;
|
|
465
412
|
}
|
|
@@ -496,18 +443,11 @@ function parseGateReviewCommentFields(body) {
|
|
|
496
443
|
}
|
|
497
444
|
}
|
|
498
445
|
|
|
499
|
-
//
|
|
500
|
-
//
|
|
501
|
-
//
|
|
502
|
-
//
|
|
503
|
-
//
|
|
504
|
-
// below only fires when `!fields.gate` — so a *recognized* `review` gate
|
|
505
|
-
// would otherwise skip the fallback yet still return non-null fields keyed
|
|
506
|
-
// to "review", which is harmless for the two summarizers here (they only
|
|
507
|
-
// read `.draft_gate`/`.pre_approval_gate`) but leaves the non-evidence
|
|
508
|
-
// contract implicit rather than explicit. Stated plainly: an identified
|
|
509
|
-
// non-evidence gate must never be treated as an unidentified body, and an
|
|
510
|
-
// unidentified body is the ONLY case the token-scan fallback exists for.
|
|
446
|
+
// A recognized `review` gate is authoritative and returns null before the
|
|
447
|
+
// lenient token-scan fallback runs: a `review` verdict carries no
|
|
448
|
+
// draft/pre-approval evidence by design. An identified
|
|
449
|
+
// non-evidence gate must never be treated as an unidentified body, which is
|
|
450
|
+
// the only case the token-scan fallback exists for.
|
|
511
451
|
if (NON_EVIDENCE_GATE_NAMES.has(fields.gate)) {
|
|
512
452
|
return null;
|
|
513
453
|
}
|
|
@@ -528,9 +468,8 @@ function parseGateReviewCommentFields(body) {
|
|
|
528
468
|
}
|
|
529
469
|
|
|
530
470
|
if (!fields.headSha) {
|
|
531
|
-
// Prefer SHA following a "head" context marker to avoid false
|
|
532
|
-
//
|
|
533
|
-
// Example: "pre_approval_gate for head e284c2e341" or "commit abc1234def"
|
|
471
|
+
// Prefer SHA following a "head" context marker to avoid false matches on
|
|
472
|
+
// plain-text numeric IDs (issue/comment IDs, etc.).
|
|
534
473
|
const ctxShaMatch = flatBody.match(
|
|
535
474
|
/\b(?:head|sha|commit)\b\s*(?:sha)?\s*[:=]?\s*`?\b([0-9a-f]{7,64})\b`?/iu
|
|
536
475
|
);
|
|
@@ -586,14 +525,12 @@ export function parseGateReviewCommentMarkerBody(body) {
|
|
|
586
525
|
};
|
|
587
526
|
}
|
|
588
527
|
|
|
589
|
-
// Which GitHub surface carries a gate verdict
|
|
590
|
-
//
|
|
591
|
-
//
|
|
592
|
-
//
|
|
593
|
-
//
|
|
594
|
-
//
|
|
595
|
-
// misses a future third surface would silently route its body to the
|
|
596
|
-
// issue-comment endpoint, where it does not live.
|
|
528
|
+
// Which GitHub surface carries a gate verdict; the poster uses it to pick the
|
|
529
|
+
// in-place correction endpoint on a same-head rerun (review → PUT
|
|
530
|
+
// pulls/{pr}/reviews/{id}; issue comment → PATCH issues/comments/{id}).
|
|
531
|
+
// Anything not the review surface (including a payload with no `surface` field)
|
|
532
|
+
// is issue_comment. SINGLE definition: a restatement missing a future third
|
|
533
|
+
// surface would misroute its body to the issue-comment endpoint.
|
|
597
534
|
export function normalizeVerdictSurface(value) {
|
|
598
535
|
return value === "review" ? "review" : "issue_comment";
|
|
599
536
|
}
|
|
@@ -711,18 +648,13 @@ export function summarizeGateReviewCommentMarkers(comments, { headSha } = {}) {
|
|
|
711
648
|
}
|
|
712
649
|
|
|
713
650
|
/**
|
|
714
|
-
* Resolve the draft-gate round-reset timestamp (ms) used to suppress stale
|
|
715
|
-
* review rounds from the count
|
|
716
|
-
*
|
|
717
|
-
*
|
|
718
|
-
*
|
|
719
|
-
*
|
|
720
|
-
*
|
|
721
|
-
* the clean draft gate is already on the current head).
|
|
722
|
-
*
|
|
723
|
-
* Both detect-pr-gate-coordination-state and request-copilot-review must derive the
|
|
724
|
-
* reset identically, or the two scripts disagree on the completed round count and
|
|
725
|
-
* the cap (the inconsistency reported in #896). This is the single shared source.
|
|
651
|
+
* Resolve the draft-gate round-reset timestamp (ms) used to suppress stale
|
|
652
|
+
* Copilot review rounds from the count. When the draft gate re-passed
|
|
653
|
+
* clean on a DIFFERENT head, only Copilot reviews after that re-pass count
|
|
654
|
+
* toward the round cap; returning the re-pass `updatedAt` (ms) lets
|
|
655
|
+
* summarizeCopilotReviews drop earlier rounds. Null when no reset applies.
|
|
656
|
+
* Single shared source: detect-pr-gate-coordination-state and
|
|
657
|
+
* request-copilot-review must derive the reset identically.
|
|
726
658
|
*
|
|
727
659
|
* @param {object} params
|
|
728
660
|
* @param {{ verdict?: string|null, headSha?: string|null, updatedAt?: string|null }|null} params.draftGate
|