@dev-loops/core 1.0.0-rc.2 → 1.0.0-rc.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dev-loops/core",
-  "version": "1.0.0-rc.2",
+  "version": "1.0.0-rc.4",
   "type": "module",
   "engines": {
     "node": ">=24"
@@ -21,6 +21,8 @@
     "./debt/shape": "./src/debt/shape.mjs",
     "./debt/signal": "./src/debt/debt-signal.mjs",
     "./github/copilot-helpers": "./src/github/copilot-helpers.mjs",
+    "./github/issue-ops": "./src/github/issue-ops.mjs",
+    "./github/ownership-helpers": "./src/github/ownership-helpers.mjs",
     "./github/repo-slug": "./src/github/repo-slug.mjs",
     "./github/review-threads": "./src/github/review-threads.mjs",
     "./loop/async-start-contract": "./src/loop/async-start-contract.mjs",
@@ -43,8 +45,10 @@
     "./loop/pr-lifecycle": "./src/loop/pr-lifecycle.mjs",
     "./loop/pr-title-markers": "./src/loop/pr-title-markers.mjs",
     "./loop/public-dev-loop-routing": "./src/loop/public-dev-loop-routing.mjs",
+    "./loop/public-dev-loop-routing-contract": "./src/loop/public-dev-loop-routing-contract.mjs",
     "./loop/refinement-grill-state": "./src/loop/refinement-grill-state.mjs",
     "./loop/queue-board-ordering": "./src/loop/queue-board-ordering.mjs",
+    "./loop/default-branch-guard": "./src/loop/default-branch-guard.mjs",
     "./loop/queue-board-sync": "./src/loop/queue-board-sync.mjs",
     "./loop/queue-driver": "./src/loop/queue-driver.mjs",
     "./loop/queue-membership": "./src/loop/queue-membership.mjs",
@@ -68,7 +72,9 @@
     "./projects/move-queue-item": "./src/projects/move-queue-item.mjs",
     "./projects/resolve-project": "./src/projects/resolve-project.mjs",
     "./harness": "./src/harness/index.mjs",
+    "./tracker": "./src/tracker/index.mjs",
     "./loop/worktree-guard": "./src/loop/worktree-guard.mjs",
+    "./loop/main-checkout-ff": "./src/loop/main-checkout-ff.mjs",
     "./loop/tracker-first-loop-state": "./src/loop/tracker-first-loop-state.mjs"
   },
   "bin": {

package/src/analysis/diff-analyzer.mjs

@@ -13,13 +13,21 @@
 // T0: File-level analysis
 // ---------------------------------------------------------------------------
 
+// Extensionless dotfile configs: static allowlist, no content sniffing. Matched
+// against the basename only, never a prefix/suffix guess. Deliberately just
+// .devloops (the reported consumer shape): runtime-version files like .nvmrc
+// were considered and REJECTED — classifying them config would let ci-guard/
+// determinism carry stale clean verdicts across a runtime bump; unknown
+// fails closed toward a full re-review, which is what a version bump needs.
+const DOTFILE_CONFIG_BASENAMES = new Set([".devloops"]);
+
 /**
  * @typedef {object} T0Result
  * @property {string[]} files — flat file paths
  * @property {string[]} extensions — unique file extensions (lowercase, with dot)
  * @property {string[]} directories — unique top-level path segments
  * @property {boolean} renameOnly — true when all entries are renames (no adds/deletes/modifies)
- * @property {boolean} allDocs — true when all files are under docs/ or are .md
+ * @property {boolean} allDocs — true when all files are under docs/ or have a docs extension (.md/.markdown)
  */
 
 /**
@@ -106,6 +114,9 @@ export function classifyFile(filePath) {
   ) {
     return "config";
   }
+  if (DOTFILE_CONFIG_BASENAMES.has(fp.split("/").pop())) {
+    return "config";
+  }
   if (fp.includes(".test.") || fp.startsWith("test/")) {
     return "test";
   }
@@ -115,7 +126,10 @@ export function classifyFile(filePath) {
   ) {
     return "code";
   }
-  if (fp.startsWith("docs/") || fp.endsWith(".md") || fp === "README.md") {
+  if (
+    fp.startsWith("docs/") || fp.endsWith(".md") || fp.endsWith(".markdown") ||
+    fp === "README.md"
+  ) {
     return "docs";
   }
   return "unknown";
@@ -242,7 +256,9 @@ export function diffHasSecuritySeam(diffOutput) {
  *
  * Detects:
  * - COMMENT_ONLY: only comment lines changed
- * - DOCS_ONLY: only .md files changed (from extensions)
+ * - DOCS_ONLY: emitted when docs files are PRESENT in the diff (docs extensions
+ *   .md/.markdown, or prose under docs/) — presence-based via
+ *   t0PresentSurfaceCategories, not exclusivity
  * - CONFIG_ONLY: only config files changed
  * - TEST_ONLY: only test files changed
  * - RENAME_ONLY: all renames, no content changes
@@ -265,6 +281,16 @@ export function analyzeT1(diffOutput, t0) {
   let allChangedLinesAreNonLogic = true;
 
   for (const line of lines) {
+    // A new file's header block (diff --git, index, --- a/..., +++ b/...) ends
+    // the previous file's hunk run. Resetting here is what lets the counting
+    // below treat EVERY +/- line inside a hunk as content: a removed line whose
+    // content itself starts with "--" (a CLI flag, a YAML document separator)
+    // renders as "---…" in the diff, and a prefix-based header exclusion would
+    // silently drop it from the counts.
+    if (line.startsWith("diff --git ")) {
+      inHunk = false;
+      continue;
+    }
     // Track hunk headers
     if (line.startsWith("@@")) {
       hunkCount++;
@@ -275,7 +301,7 @@ export function analyzeT1(diffOutput, t0) {
     if (!inHunk) continue;
 
     // Track line stats and classify
-    if (line.startsWith("+") && !line.startsWith("+++")) {
+    if (line.startsWith("+")) {
       added++;
       hasAnyChangedLine = true;
       const content = line.slice(1).trim();
@@ -283,7 +309,7 @@ export function analyzeT1(diffOutput, t0) {
         hasLogicChange = true;
         allChangedLinesAreNonLogic = false;
       }
-    } else if (line.startsWith("-") && !line.startsWith("---")) {
+    } else if (line.startsWith("-")) {
       deleted++;
       hasAnyChangedLine = true;
       const content = line.slice(1).trim();

package/src/claude/hook-decisions.mjs

@@ -21,6 +21,7 @@ import {
   extractRepoFlagsFromGhPrCreateSegments,
   commandContainsRawExternalWrite,
   extractRepoFlagsFromExternalWriteSegments,
+  commandContainsGitStash,
   TARGET_REPO_SLUG,
 } from "../loop/bash-command-classify.mjs";
 
@@ -84,6 +85,19 @@ export function decideBashGate({ command, repoSlug = null, gatePassed = false, g
   if (typeof command !== "string") {
     return ALLOW;
   }
+  // `git stash` writes to `refs/stash`, one ref shared by every worktree over this repo's single
+  // `.git` directory — a stash from one worktree can pop into another's. Block it outright on the
+  // target repo; see skills/docs/worktree-guidance.md#never-git-stash-in-a-shared-git-layout for the
+  // stash-free alternative (git diff / a patch file / a scratch checkout).
+  if (commandContainsGitStash(command) && (repoSlug ?? "").toLowerCase() === TARGET_REPO_SLUG.toLowerCase()) {
+    return {
+      decision: "deny",
+      reason:
+        "git stash blocked: refs/stash is shared across every worktree over this repo's one .git directory, " +
+        "so a stash can pop into a different worktree. Use `git diff` (or `git diff --staged`), save changes " +
+        "to a patch file, or use a separate scratch worktree instead of stashing.",
+    };
+  }
   // Subagent-scoped external-write guard: block ad-hoc `gh issue create`/`gh issue comment`/
   // `gh issue edit`/`gh pr comment` on the target repo from a subagent, so external writes flow through the
   // sanctioned node wrappers. The main-agent/operator path (agentType null) is unaffected (#1051).

package/src/cli/primitives.mjs

@@ -126,13 +126,21 @@ export function parseIssueNumber(value, parseError = null) {
   return parsePositiveInteger(value, "--issue", parseError);
 }
 
-export function runChild(command, args, env = process.env) {
+// `stdinText` is optional and additive: omit it and stdin stays closed exactly
+// as before. Supply it (a `gh api ... --input -` payload) and it is piped in,
+// so a caller that needs stdin no longer has to reach for a second, separately
+// injected runner — every gh call in a script can route through the ONE
+// runChild its tests already stub.
+export function runChild(command, args, env = process.env, stdinText = undefined) {
   return new Promise((resolve, reject) => {
-    const child = spawn(command, args, { env, stdio: ["ignore", "pipe", "pipe"] });
+    const child = spawn(command, args, { env, stdio: [stdinText === undefined ? "ignore" : "pipe", "pipe", "pipe"] });
     let stdout = "";
     let stderr = "";
     child.stdout.on("data", (chunk) => { stdout += String(chunk); });
     child.stderr.on("data", (chunk) => { stderr += String(chunk); });
+    if (stdinText !== undefined) {
+      child.stdin.end(stdinText);
+    }
     child.on("error", reject);
     child.on("close", (code) => { resolve({ code, stdout, stderr }); });
   });

package/src/cli/retry-wrapper.mjs

@@ -8,10 +8,14 @@
  * Only retries on usage/flag errors — NOT on network/auth/data errors.
  *
  * Detection contract:
- *   A usage/flag error is stderr JSON with { ok: false, usage: "..." }
- *   OR stderr text matching known argument-error patterns.
+ *   A usage/flag error is stderr JSON with either the legacy
+ *   { ok: false, usage: "..." } shape or the current short-error envelope
+ *   { ok: false, hint: "..." } (formatCliError's `usage` presence check
+ *   renders as `hint`, never the full usage text — see
+ *   packages/core/src/github/review-threads.mjs's formatCliError), OR stderr
+ *   text matching known argument-error patterns.
  *
- * Non-retryable: runtime errors ({ ok: false } without usage field),
+ * Non-retryable: runtime errors ({ ok: false } with neither usage nor hint),
  *   network errors, auth errors, data errors, signal exits.
  *
  * Issue: #483
@@ -36,11 +40,15 @@ export function isUsageError(stderr) {
 
   const trimmed = stderr.trim();
 
-  // Try JSON parse first: { ok: false, usage: "..." }
+  // Try JSON parse first: legacy { ok: false, usage: "..." }, or the current
+  // short-error envelope { ok: false, hint: "..." } (formatCliError never
+  // emits `usage` text anymore — a non-empty `hint` is its replacement
+  // presence signal that a usage string exists, fetchable via --help).
   try {
     const parsed = JSON.parse(trimmed);
-    if (parsed && parsed.ok === false && typeof parsed.usage === 'string' && parsed.usage.length > 0) {
-      return true;
+    if (parsed && parsed.ok === false) {
+      if (typeof parsed.usage === 'string' && parsed.usage.length > 0) return true;
+      if (typeof parsed.hint === 'string' && parsed.hint.length > 0) return true;
     }
   } catch {
     // Not JSON — fall through to pattern matching