@dev-loops/core 0.5.0 → 0.7.1

package/src/debt/deep-persona-signals.mjs

@@ -1,266 +0,0 @@
-import { randomUUID } from "node:crypto";
-import { DebtSignalSchema } from "./debt-signal.mjs";
-import { loadDevLoopConfig } from "../config/config.mjs";
-
-// ============================================================================
-// Flag phrase inventory — derived from personas.deep prompt in defaults.yaml
-//
-// Confidence values use the canonical DebtSignalSchema 0..1 range (0.9 = 90%).
-// This matches the schema default: z.number().min(0).max(1).default(1).
-// ============================================================================
-
-/** @type {Array<{ phrase: RegExp, category: string, severity: string, confidence: number }>} */
-const FLAG_PATTERNS = [
-  {
-    phrase: /(?:crossing|crossed|exceeds?)\s+(?:1000|1,000)\+?\s+lines/i,
-    category: "file_size",
-    severity: "high",
-    confidence: 0.9,
-  },
-  {
-    phrase: /conditionals?\s+bolted\s+onto\s+unrelated\s+paths/i,
-    category: "spaghetti_branching",
-    severity: "high",
-    confidence: 0.9,
-  },
-  {
-    phrase: /\bspaghetti\b/i,
-    category: "spaghetti_branching",
-    severity: "high",
-    confidence: 0.9,
-  },
-  {
-    phrase: /thin\s+wrapper/i,
-    category: "thin_wrapper",
-    severity: "medium",
-    confidence: 0.9,
-  },
-  {
-    phrase: /re-export\s*[- ]?only/i,
-    category: "thin_wrapper",
-    severity: "medium",
-    confidence: 0.9,
-  },
-  {
-    phrase: /identity\s+abstraction/i,
-    category: "thin_wrapper",
-    severity: "medium",
-    confidence: 0.9,
-  },
-  {
-    phrase: /feature\s+logic\s+leaking\s+into/i,
-    category: "leaky_feature_logic",
-    severity: "high",
-    confidence: 0.9,
-  },
-  {
-    phrase: /leaking\s+into\s+shared/i,
-    category: "leaky_feature_logic",
-    severity: "high",
-    confidence: 0.9,
-  },
-  {
-    phrase: /cast[- ]?heavy/i,
-    category: "weak_contract",
-    severity: "medium",
-    confidence: 0.9,
-  },
-  {
-    phrase: /optionality[- ]?heavy/i,
-    category: "weak_contract",
-    severity: "medium",
-    confidence: 0.9,
-  },
-  {
-    phrase: /any[- ]?typed\s+contract/i,
-    category: "weak_contract",
-    severity: "medium",
-    confidence: 0.9,
-  },
-  {
-    phrase: /code\s+judo/i,
-    category: "simplification_opportunity",
-    severity: "medium",
-    confidence: 0.9,
-  },
-  {
-    phrase: /prefer\s+deletion\s+over\s+addition/i,
-    category: "simplification_opportunity",
-    severity: "medium",
-    confidence: 0.9,
-  },
-];
-
-const FILE_PATH_RE = /[\w/\-.]+\.(?:m?js|ts|tsx|jsx|mjs)/i;
-
-// ============================================================================
-// Helpers
-// ============================================================================
-
-/**
- * Match a comment body against known deep-persona flag phrases.
- * Returns the match when a specific pattern matches, or null when no
- * patterns match the body.
- *
- * @param {string} body
- * @returns {{ category: string, severity: string, confidence: number, matchedPhrase: string|null }|null}
- */
-function matchDeepPersonaFlags(body) {
-  for (const pattern of FLAG_PATTERNS) {
-    if (pattern.phrase.test(body)) {
-      return {
-        category: pattern.category,
-        severity: pattern.severity,
-        confidence: pattern.confidence,
-        matchedPhrase: pattern.phrase.source,
-      };
-    }
-  }
-
-  return null;
-}
-
-/**
- * Extract a file path from a comment body, or return an empty string if none found.
- *
- * @param {string} body
- * @returns {string}
- */
-function extractFilePath(body) {
-  const match = body.match(FILE_PATH_RE);
-  return match ? match[0] : "";
-}
-
-/**
- * Build a debt_signal object from a matched deep-persona comment.
- *
- * @param {object} comment - Normalized comment from parseReviewThreads output
- * @param {string} category - Inferred category
- * @param {string} severity - Severity hint
- * @param {number} confidence - Confidence score (0..1)
- * @param {string|null} matchedPhrase - The regex source that matched
- * @param {{ prNumber: string|number, prUrl: string }} prMeta
- * @returns {object}
- */
-function buildDebtSignal(comment, category, severity, confidence, matchedPhrase, prMeta) {
-  const filePath = extractFilePath(comment.body);
-
-  return {
-    id: randomUUID(),
-    sourceType: "pr_review_deep_persona",
-    signalKind: category,
-    location: filePath ? { filePath } : {},
-    severityHint: severity,
-    timestamp: new Date().toISOString(),
-    confidence,
-    rawPayload: {
-      description: comment.body,
-      metadata: {
-        prNumber: String(prMeta.prNumber),
-        prUrl: prMeta.prUrl,
-        commentId: comment.id,
-        threadId: comment.threadId,
-        isResolved: comment.isResolved ?? false,
-        category,
-        matchedPhrase,
-      },
-    },
-  };
-}
-
-// ============================================================================
-// Public API
-// ============================================================================
-
-/**
- * Extract deep-persona debt_signal artifacts from normalized review-thread JSON.
- *
- * Accepts the output of `parseReviewThreads()` (the `comments` array with
- * normalized `{ id, threadId, author, body, isActionable }` entries).
- *
- * Filters to only bot-authored comments that match known deep-persona flag
- * phrases. Bots are identified by `author.isBot === true` or `author.type === "Bot"`.
- *
- * @param {{ comments: Array<{ id: string, threadId: string, author: { login: string, type: string, isBot: boolean }, body: string, isActionable?: boolean, isResolved?: boolean }>, threads?: Array<{ id: string, isResolved: boolean }> }} parsedOutput - parseReviewThreads() output
- * @param {{ prNumber: string|number, prUrl: string }} prMeta
- * @returns {Array<object>} Array of debt_signal objects compatible with DebtSignalSchema
- */
-export function extractDeepPersonaSignals(parsedOutput, prMeta) {
-  if (!parsedOutput || !Array.isArray(parsedOutput.comments)) {
-    throw new Error("Invalid parsed output: expected { comments: [...] } from parseReviewThreads()");
-  }
-
-  // Build a thread-id → isResolved map for fast lookup
-  const threadResolved = new Map();
-  if (Array.isArray(parsedOutput.threads)) {
-    for (const thread of parsedOutput.threads) {
-      threadResolved.set(thread.id, Boolean(thread.isResolved));
-    }
-  }
-
-  const signals = [];
-
-  for (const comment of parsedOutput.comments) {
-    // Only process bot-authored comments (all Copilot personas emit as bots)
-    if (!comment.author || (!comment.author.isBot && comment.author.type !== "Bot")) {
-      continue;
-    }
-
-    if (!comment.body || comment.body.trim().length === 0) {
-      continue;
-    }
-
-    const match = matchDeepPersonaFlags(comment.body);
-    if (!match) {
-      continue;
-    }
-
-    // Enrich comment with isResolved from thread data
-    const isResolved = threadResolved.has(comment.threadId)
-      ? threadResolved.get(comment.threadId)
-      : (comment.isResolved ?? false);
-
-    const signal = buildDebtSignal(
-      { ...comment, isResolved },
-      match.category,
-      match.severity,
-      match.confidence,
-      match.matchedPhrase,
-      prMeta,
-    );
-
-    // Validate against canonical schema — throw on regression
-    signals.push(DebtSignalSchema.parse(signal));
-  }
-
-  return signals;
-}
-
-/**
- * Return the known deep-persona flag phrase regex sources for inspection.
- *
- * @returns {Array<string>}
- */
-export function getDeepPersonaFlagPhrases() {
-  return FLAG_PATTERNS.map((p) => p.phrase.source);
-}
-
-/**
- * Verify that all known deep-persona flag phrase regex patterns match
- * the loaded deep persona prompt text. Returns an array of regex sources
- * whose patterns did not find any match in the prompt (empty = all match).
- *
- * @returns {Promise<Array<string>>}
- */
-export async function verifyPromptStability() {
-  const { config, errors } = await loadDevLoopConfig();
-  if (errors.length > 0) {
-    throw new Error("Cannot verify prompt stability: config load errors: " +
-      errors.map(e => e.message).join("; "));
-  }
-  const deepPrompt = config?.personas?.deep?.prompt ?? "";
-
-  return FLAG_PATTERNS
-    .filter((p) => !p.phrase.test(deepPrompt))
-    .map((p) => p.phrase.source);
-}

package/src/harness/claude-extension-adapter.mjs

@@ -1,102 +0,0 @@
-import { execFile } from "node:child_process";
-
-import { createExtensionHarnessAdapter } from "./extension-adapter.mjs";
-
-/**
- * Create the Claude Code extension-surface adapter.
- *
- * Implements the same `ExtensionHarnessAdapter` interface as the Pi adapter so
- * `executeDevLoopsCommand` and the extension wiring run unchanged under Claude.
- *
- * - `exec` shells out via `bash -lc` (Claude has no native exec API in core).
- * - lifecycle `on(...)` registrations are stored in `listeners` for hook-driven
- *   dispatch (wired in CA4 / #773); they are not auto-fired here.
- * - `registerCommand(...)` registrations are stored in `commands`.
- * - Claude core has no interactive widget/status surface, so the default
- *   `HarnessContext` reports `hasUI: false` and routes `ui` calls to a sink.
- *
- * @param {Object} [options]
- * @param {string} [options.cwd] - Default cwd for exec and contexts (default: process.cwd()).
- * @param {NodeJS.ProcessEnv} [options.env] - Env for exec (default: process.env).
- * @param {(message: string, level: string) => void} [options.onNotify] - Optional sink for
- *   `ui.notify` (e.g. console). Defaults to a no-op.
- * @returns {import("./extension-adapter.mjs").ExtensionHarnessAdapter & {
- *   listeners: Map<string, Function>,
- *   commands: Map<string, import("./extension-adapter.mjs").HarnessCommandConfig>,
- *   makeContext: (overrides?: {cwd?: string}) => import("./extension-adapter.mjs").HarnessContext,
- * }}
- */
-export function createClaudeExtensionAdapter({
-  cwd = process.cwd(),
-  env = process.env,
-  onNotify = () => {},
-} = {}) {
-  const listeners = new Map();
-  const commands = new Map();
-
-  function exec(command, options = {}) {
-    return new Promise((resolve) => {
-      execFile(
-        "bash",
-        ["-lc", command],
-        {
-          cwd: options.cwd ?? cwd,
-          env,
-          timeout: options.timeout ?? 0,
-          encoding: "utf8",
-          maxBuffer: 64 * 1024 * 1024,
-        },
-        (error, stdout, stderr) => {
-          if (error) {
-            // Match the documented HarnessExecResult contract: `code` is undefined when
-            // the process was killed (e.g. timeout). Consumers branch on `killed` first.
-            const killed = Boolean(error.killed);
-            resolve({
-              code: killed ? undefined : (typeof error.code === "number" ? error.code : 1),
-              stdout: stdout ?? "",
-              stderr: stderr ?? "",
-              killed,
-            });
-            return;
-          }
-          resolve({ code: 0, stdout: stdout ?? "", stderr: stderr ?? "", killed: false });
-        },
-      );
-    });
-  }
-
-  function makeContext({ cwd: ctxCwd } = {}) {
-    return {
-      cwd: ctxCwd ?? cwd,
-      hasUI: false,
-      ui: {
-        notify(message, level = "info") {
-          onNotify(message, level);
-        },
-        setWidget() {},
-        setStatus() {},
-      },
-    };
-  }
-
-  const adapter = createExtensionHarnessAdapter({
-    exec,
-    on(event, handler) {
-      listeners.set(event, handler);
-    },
-    registerCommand(name, config) {
-      commands.set(name, config);
-    },
-  });
-
-  // Freeze the composite so the validated interface guarantee from the factory carries
-  // through to the returned object (which also exposes the #773 dispatch registries).
-  return Object.freeze({
-    exec: adapter.exec,
-    on: adapter.on,
-    registerCommand: adapter.registerCommand,
-    listeners,
-    commands,
-    makeContext,
-  });
-}

package/src/refinement/ac-dod-matrix.mjs

@@ -1,95 +0,0 @@
-import { z } from "zod";
-
-// ---------------------------------------------------------------------------
-// AC/DoD matrix item — one row in the refinement coverage matrix
-// ---------------------------------------------------------------------------
-
-export const AC_DOD_ITEM_TYPE = Object.freeze({
-  AC: "AC",
-  DOD: "DoD",
-  NON_GOAL: "Non-goal",
-});
-
-export const AC_DOD_ITEM_STATUS = Object.freeze({
-  MET: "Met",
-  PARTIAL: "Partial",
-  UNMET: "Unmet",
-  UNVERIFIED: "Unverified",
-});
-
-/**
- * A single row in the AC/DoD coverage matrix.
- * Matches the refiner persona's required table output shape.
- */
-export const AcDodMatrixItemSchema = z.strictObject({
-  /** Exact item text from the source issue/plan/spec */
-  item: z.string().trim().min(1),
-  /** Type classification */
-  type: z.enum(Object.values(AC_DOD_ITEM_TYPE)),
-  /** Verification status */
-  status: z.enum(Object.values(AC_DOD_ITEM_STATUS)),
-  /** Reference to supporting evidence (file, test, doc path, or URL) */
-  evidence: z.string(),
-  /** Additional context or caveats */
-  notes: z.string(),
-});
-
-/**
- * The full AC/DoD/Non-goal coverage matrix.
- * Emitted by the refiner during issue refinement, consumed by implementation
- * agents via the handoff envelope as a structured contract.
- */
-export const AcDodMatrixSchema = z.strictObject({
-  /** Schema identifier for dispatch and validation */
-  schema: z.literal("ac-dod-matrix/v1"),
-  /** Ordered list of matrix items */
-  items: z.array(AcDodMatrixItemSchema).min(1),
-  /** Source reference (issue URL, plan-doc path, etc.) */
-  source: z.string().trim().min(1).optional(),
-  /** ISO 8601 timestamp of matrix generation */
-  generatedAt: z.string().datetime(),
-  /**
-   * True when every item has status "Met" — the contract is fully satisfied.
-   * Implementation agents use this to gate merge-readiness.
-   */
-  isComplete: z.boolean(),
-}).refine(
-  (data) => isMatrixComplete(data) === data.isComplete,
-  {
-    message: "isComplete must be true when (and only when) every item has status 'Met'",
-    path: ["isComplete"],
-  }
-);
-
-// ---------------------------------------------------------------------------
-// Convenience helpers
-// ---------------------------------------------------------------------------
-
-/**
- * Check whether a matrix is fully satisfied (all items Met).
- * Pure function — does not require a parsed Zod result.
- */
-export function isMatrixComplete(matrix) {
-  if (!matrix || !Array.isArray(matrix.items) || matrix.items.length === 0) {
-    return false;
-  }
-  return matrix.items.every((item) => item.status === AC_DOD_ITEM_STATUS.MET);
-}
-
-/**
- * Collect all items that are not "Met" — the outstanding work contract.
- */
-export function outstandingItems(matrix) {
-  if (!matrix || !Array.isArray(matrix.items)) {
-    return [];
-  }
-  return matrix.items.filter((item) => item.status !== AC_DOD_ITEM_STATUS.MET);
-}
-
-/**
- * Validate raw data against the AC/DoD matrix schema.
- * Returns a Zod safeParse result.
- */
-export function validateAcDodMatrix(data) {
-  return AcDodMatrixSchema.safeParse(data);
-}