@dev-blinq/cucumber_client 1.0.1519-dev → 1.0.1521-dev

package/bin/client/recorderv3/bvt_recorder.js

@@ -352,6 +352,15 @@ export class BVTRecorder {
     this.web.tryAllStrategies = true;
     this.page = bvtContext.page;
     this.pageSet.add(this.page);
+    if (process.env.REMOTE_RECORDER === "true") {
+      this.remoteBrowser = new RemoteBrowserService({
+        CDP_CONNECT_URL: `http://localhost:${this.#remoteDebuggerPort}`,
+        currentPage: this.page,
+      });
+      this.remoteBrowser.on("debugURLChange", (url) => {
+        this.sendEvent(this.events.onDebugURLChange, url);
+      });
+    }
     this.lastKnownUrlPath = this._updateUrlPath();
     const browser = await this.context.browser();
     this.browser = browser;
@@ -403,15 +412,6 @@ export class BVTRecorder {
     // add listeners for new pages
     this._addPagelisteners(this.context);
 
-    if (process.env.REMOTE_RECORDER === "true") {
-      this.remoteBrowser = new RemoteBrowserService({
-        CDP_CONNECT_URL: `http://localhost:${this.#remoteDebuggerPort}`,
-        currentPage: this.page,
-      });
-      this.remoteBrowser.on("debugURLChange", (url) => {
-        this.sendEvent(this.events.onDebugURLChange, url);
-      });
-    }
     await this.page.goto(url, {
       waitUntil: "domcontentloaded",
     });
@@ -631,6 +631,7 @@ export class BVTRecorder {
 
   _addPagelisteners(context) {
     context.on("page", async (page) => {
+      console.log("New page opened");
       try {
         if (page.isClosed()) return;
         this.pageSet.add(page);

package/bin/client/recorderv3/services.js

@@ -150,47 +150,33 @@ export class NamesService {
 }
 export class RemoteBrowserService extends EventEmitter {
     CDP_CONNECT_URL;
-    pageMap = new Map();
     _selectedPage;
     logger = socketLogger;
     constructor({ CDP_CONNECT_URL, currentPage }) {
         super();
         this.CDP_CONNECT_URL = CDP_CONNECT_URL;
         this._selectedPage = currentPage;
-        this.getDebugURLs()
-            .then((debugData) => {
-            debugData.forEach((page) => {
-                if (page.type === "page") {
-                    this.pageMap.set(page.url, page.id);
+        this.emitSelectedPageId();
+    }
+    async emitSelectedPageId() {
+        let id = null;
+        try {
+            const debugData = await this.getDebugURLs();
+            for (const pageData of debugData) {
+                if (pageData.type === "page" && pageData.url === this._selectedPage.url()) {
+                    id = pageData.id;
+                    break;
                 }
-            });
-        })
-            .catch((error) => {
-            this.logger.error("Error fetching debug URLs: ", error instanceof Error ? error.message : error);
-        });
+            }
+            this.emit("debugURLChange", id);
+        }
+        catch (error) {
+            this.logger.error("Error fetching debug URLs: ", error instanceof Error ? error.message : JSON.stringify(error));
+        }
     }
     set selectedPage(page) {
         this._selectedPage = page;
-        const pageUrl = page.url();
-        const pageEntry = this.pageMap.get(pageUrl);
-        if (!pageEntry) {
-            this.getDebugURLs()
-                .then((debugData) => {
-                console.log("Fetched debug data: ", debugData);
-                debugData.forEach((page) => {
-                    this.pageMap.set(page.url, page.id);
-                });
-                const url = this.pageMap.get(pageUrl);
-                this.emit("debugURLChange", url);
-            })
-                .catch((error) => {
-                this.logger.error("Error fetching debug URLs: ", error instanceof Error ? error.message : JSON.stringify(error));
-            });
-        }
-        else {
-            const url = this.pageMap.get(pageUrl);
-            this.emit("debugURLChange", url);
-        }
+        this.emitSelectedPageId();
     }
     get selectedPage() {
         return this._selectedPage;
@@ -203,7 +189,6 @@ export class RemoteBrowserService extends EventEmitter {
         });
         if (response.status !== 200) {
             throw new Error("Error while fetching debug URL");
-            return [];
         }
         return response.data;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dev-blinq/cucumber_client",
-  "version": "1.0.1519-dev",
+  "version": "1.0.1521-dev",
   "description": " ",
   "main": "bin/index.js",
   "types": "bin/index.d.ts",
@@ -39,7 +39,7 @@
     "@cucumber/tag-expressions": "^6.1.1",
     "@dev-blinq/cucumber-js": "1.0.195-dev",
     "@faker-js/faker": "^8.4.1",
-    "automation_model": "1.0.870-dev",
+    "automation_model": "1.0.871-dev",
     "axios": "^1.7.4",
     "chokidar": "^3.6.0",
     "create-require": "^1.1.1",