@dev-blinq/cucumber_client 1.0.1475-dev → 1.0.1475-stage

package/bin/client/code_cleanup/codemod/find_harcoded_locators.js

@@ -0,0 +1,173 @@
+#!/usr/bin/env node
+import { promises as fs } from "node:fs";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import { parse } from "@babel/parser";
+import traverseImport from "@babel/traverse";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+
+const ROOT = process.cwd();
+const ALLOWED_HARDCODE_RATIO = 0.2;
+const IGNORED_RATIO = 1.0;
+const PLACEHOLDER_REGEX = /{[^}]+}/;
+const IGNORE_DIRS = new Set(["node_modules", ".git", ".idea"]);
+
+const results = [];
+
+function hasPlaceholder(str) {
+  return PLACEHOLDER_REGEX.test(str);
+}
+
+function stringFromNode(node) {
+  if (!node) return undefined;
+  if (node.type === "StringLiteral") return node.value;
+  if (node.type === "TemplateLiteral") {
+    const raw = node.quasis.map((q) => q.value.cooked ?? q.value.raw).join("${}");
+    return raw;
+  }
+  return undefined;
+}
+
+function locatorIsParameterized(objNode) {
+  if (objNode.type !== "ObjectExpression") return false;
+  return objNode.properties.some((prop) => {
+    if (prop.type !== "ObjectProperty") return false;
+    const valueString = stringFromNode(prop.value);
+    return typeof valueString === "string" && hasPlaceholder(valueString);
+  });
+}
+
+function analyzeMjsFile(filePath, code) {
+  const ast = parse(code, {
+    sourceType: "module",
+    plugins: ["jsx", "typescript", "classProperties", "optionalChaining", "nullishCoalescingOperator", "topLevelAwait"],
+  });
+
+  const traverse = typeof traverseImport === "function" ? traverseImport : traverseImport.default;
+
+  traverse(ast, {
+    ObjectExpression(pathObj) {
+      const props = pathObj.node.properties;
+      const locatorProp = props.find(
+        (p) =>
+          p.type === "ObjectProperty" &&
+          ((p.key.type === "Identifier" && p.key.name === "locators") ||
+            (p.key.type === "StringLiteral" && p.key.value === "locators"))
+      );
+      if (!locatorProp || locatorProp.value.type !== "ArrayExpression") return;
+
+      const locators = locatorProp.value.elements.filter(Boolean);
+      if (locators.length === 0) return;
+
+      const total = locators.length;
+      const hardcoded = locators.filter((loc) => !locatorIsParameterized(loc)).length;
+      if (hardcoded / total === IGNORED_RATIO) return; // Skip if all locators are hardcoded (likely a non-locator object)
+      if (hardcoded / total <= ALLOWED_HARDCODE_RATIO) return;
+
+      const nameProp = props.find(
+        (p) =>
+          p.type === "ObjectProperty" &&
+          ((p.key.type === "Identifier" && (p.key.name === "element_name" || p.key.name === "element_key")) ||
+            (p.key.type === "StringLiteral" && (p.key.value === "element_name" || p.key.value === "element_key")))
+      );
+      const elementNameValue = nameProp ? stringFromNode(nameProp.value) : undefined;
+      const loc = pathObj.node.loc?.start;
+      results.push({
+        file: filePath,
+        line: loc?.line ?? 0,
+        element: elementNameValue ?? "<unknown>",
+        hardcoded,
+        total,
+      });
+    },
+  });
+}
+
+function locatorIsParameterizedJson(locator) {
+  if (locator && typeof locator === "object") {
+    return Object.values(locator).some((val) => typeof val === "string" && hasPlaceholder(val));
+  }
+  return false;
+}
+
+function findLineNumber(content, searchValue) {
+  const idx = content.indexOf(searchValue);
+  if (idx === -1) return 0;
+  return content.slice(0, idx).split("\n").length;
+}
+
+function analyzeJsonFile(filePath, content) {
+  let data;
+  try {
+    data = JSON.parse(content);
+  } catch (err) {
+    console.warn(`Skipping ${filePath}: invalid JSON`);
+    return;
+  }
+
+  const visit = (node) => {
+    if (!node || typeof node !== "object") return;
+    if (Array.isArray(node)) {
+      node.forEach(visit);
+      return;
+    }
+
+    if (Array.isArray(node.locators) && node.locators.length > 0) {
+      const total = node.locators.length;
+      const hardcoded = node.locators.filter((loc) => !locatorIsParameterizedJson(loc)).length;
+
+      if (hardcoded / total > ALLOWED_HARDCODE_RATIO) {
+        if (hardcoded / total === IGNORED_RATIO) return; // Skip if all locators are hardcoded (likely a non-locator object)
+        const name = node.element_name || node.element_key || "<unknown>";
+        const line = findLineNumber(content, name);
+        results.push({ file: filePath, line, element: name, hardcoded, total });
+      }
+    }
+
+    Object.values(node).forEach(visit);
+  };
+
+  visit(data);
+}
+
+async function walk(dir) {
+  const entries = await fs.readdir(dir, { withFileTypes: true });
+  for (const entry of entries) {
+    if (IGNORE_DIRS.has(entry.name)) continue;
+    const resolved = path.join(dir, entry.name);
+    if (entry.isDirectory()) {
+      await walk(resolved);
+    } else if (entry.isFile() && (entry.name.endsWith(".mjs") || entry.name.endsWith(".json"))) {
+      const content = await fs.readFile(resolved, "utf8");
+      try {
+        if (entry.name.endsWith(".mjs")) {
+          analyzeMjsFile(resolved, content);
+        } else {
+          analyzeJsonFile(resolved, content);
+        }
+      } catch (err) {
+        console.error(`Failed to analyze ${resolved}:`, err.message);
+      }
+    }
+  }
+}
+
+async function main() {
+  await walk(ROOT);
+  if (results.length === 0) {
+    console.log("No elements exceeded 20% hardcoded locator threshold.");
+    return;
+  }
+
+  for (const r of results) {
+    console.log(`${r.file}:${r.line} — ${r.element} (${r.hardcoded}/${r.total} hardcoded)`);
+  }
+  process.exitCode = 1;
+}
+
+main().catch((err) => {
+  console.error(err);
+  process.exit(1);
+});

package/bin/client/code_cleanup/codemod/fix_hardcoded_locators.js

@@ -0,0 +1,247 @@
+#!/usr/bin/env node
+/**
+ * Codemod to drop hardcoded locators flagged by find_harcoded_locators.mjs.
+ * - Default: clones workspace to a temp dir, git init + baseline commit, applies fixes, prints diffs.
+ * - --inplace: modifies files in the current workspace.
+ *
+ * Behavior:
+ *   For each reported file, in every object with a `locators` array,
+ *   remove locator entries that contain no placeholders ({...}).
+ *   If all locators are hardcoded, the array is left unchanged to avoid emptying it.
+ *   JSON files are handled similarly.
+ *
+ * Usage:
+ *   node find_harcoded_locators.mjs | node fix-hardcoded-locators.mjs
+ *   node find_harcoded_locators.mjs | node fix-hardcoded-locators.mjs --inplace
+ */
+
+import fs from "node:fs";
+import { promises as fsPromises } from "node:fs";
+import path from "node:path";
+import os from "node:os";
+import { parse } from "@babel/parser";
+import traverseImport from "@babel/traverse";
+import { spawnSync } from "node:child_process";
+
+const traverse = typeof traverseImport === "function" ? traverseImport : traverseImport.default;
+const PLACEHOLDER_REGEX = /{[^}]+}/;
+const ROOT = process.cwd();
+
+const INPUT = await readStdin();
+if (!INPUT.trim()) {
+  console.error("No input provided. Pipe find_harcoded_locators.mjs into this script.");
+  process.exit(1);
+}
+
+const filesToFix = parseInputLines(INPUT);
+if (filesToFix.size === 0) {
+  console.log("No actionable lines detected.");
+  process.exit(0);
+}
+
+const INPLACE = process.argv.includes("--inplace");
+const { cloneRoot, mapper } = INPLACE ? { cloneRoot: ROOT, mapper: (p) => p } : await cloneWorkspace(ROOT);
+if (!INPLACE) {
+  console.log(`Cloned workspace to: ${cloneRoot}`);
+  await initGitRepo(cloneRoot);
+} else {
+  console.log("Running in-place (original files will be modified).");
+}
+
+const changes = [];
+
+for (const originalPath of filesToFix) {
+  const clonedPath = mapper(originalPath);
+  const ext = path.extname(clonedPath).toLowerCase();
+  const original = await fsPromises.readFile(clonedPath, "utf8");
+  let fixed = original;
+
+  if (ext === ".json") {
+    fixed = fixJson(original);
+  } else if (ext === ".mjs" || ext === ".js") {
+    fixed = fixJs(original);
+  }
+
+  if (fixed === original) continue;
+
+  const diff = makeDiff(originalPath, clonedPath, fixed);
+  await fsPromises.writeFile(clonedPath, fixed, "utf8");
+  changes.push({ filePath: originalPath, diff });
+}
+
+if (changes.length === 0) {
+  console.log("No changes needed.");
+  process.exit(0);
+}
+
+for (const { filePath, diff } of changes) {
+  console.log(`\n=== ${filePath} (cloned) ===`);
+  console.log(diff.trimEnd());
+}
+
+process.exit(1);
+
+// ---------- helpers ----------
+
+function parseInputLines(text) {
+  const set = new Set();
+  for (const line of text.split(/\r?\n/)) {
+    const m = line.match(/^(.*?):\d+ — /);
+    if (m) set.add(m[1]);
+  }
+  return set;
+}
+
+function hasPlaceholder(str) {
+  return PLACEHOLDER_REGEX.test(str);
+}
+
+function locatorHasPlaceholderNode(node) {
+  if (!node || node.type !== "ObjectExpression") return false;
+  return node.properties.some((prop) => {
+    if (prop.type !== "ObjectProperty") return false;
+    const val = prop.value;
+    if (val.type === "StringLiteral") return hasPlaceholder(val.value);
+    if (val.type === "TemplateLiteral") {
+      const raw = val.quasis.map((q) => q.value.cooked ?? q.value.raw).join("${}");
+      return hasPlaceholder(raw);
+    }
+    return false;
+  });
+}
+
+function propName(prop) {
+  if (prop.type !== "ObjectProperty") return undefined;
+  const k = prop.key;
+  if (k.type === "Identifier") return k.name;
+  if (k.type === "StringLiteral") return k.value;
+  return undefined;
+}
+
+function leadingWhitespace(text, index) {
+  const lineStart = text.lastIndexOf("\n", index - 1) + 1;
+  const m = text.slice(lineStart, index).match(/^[ \t]*/);
+  return m ? m[0] : "";
+}
+
+function fixJs(code) {
+  let touched = false;
+  const replacements = [];
+
+  const ast = parse(code, {
+    sourceType: "module",
+    plugins: ["jsx", "typescript", "classProperties", "optionalChaining", "nullishCoalescingOperator", "topLevelAwait"],
+    ranges: true,
+  });
+
+  traverse(ast, {
+    ObjectExpression(pathObj) {
+      const props = pathObj.node.properties.filter((p) => p.type === "ObjectProperty");
+      if (!props.length) return;
+      const locProp = props.find((p) => propName(p) === "locators" && p.value.type === "ArrayExpression");
+      if (!locProp) return;
+      const elements = locProp.value.elements.filter(Boolean);
+      if (elements.length === 0) return;
+
+      const keep = elements.filter(locatorHasPlaceholderNode);
+      if (keep.length === elements.length) return;
+      if (keep.length === 0) return; // avoid emptying; leave as-is
+
+      if (typeof locProp.value.start !== "number" || typeof locProp.value.end !== "number") return;
+
+      const valueStart = locProp.value.start;
+      const valueEnd = locProp.value.end;
+      const indent = leadingWhitespace(code, valueStart) + "  ";
+      const keepTexts = keep.map((el) => code.slice(el.start, el.end));
+      const newArray =
+        "[\n" + keepTexts.map((t) => indent + t.trim()).join(",\n") + "\n" + leadingWhitespace(code, valueStart) + "]";
+
+      replacements.push({ start: valueStart, end: valueEnd, text: newArray });
+      touched = true;
+    },
+  });
+
+  if (!touched) return code;
+
+  let out = code;
+  replacements
+    .sort((a, b) => b.start - a.start)
+    .forEach(({ start, end, text }) => {
+      out = out.slice(0, start) + text + out.slice(end);
+    });
+  return out;
+}
+
+function locatorHasPlaceholderJson(locator) {
+  if (locator && typeof locator === "object") {
+    return Object.values(locator).some((val) => typeof val === "string" && hasPlaceholder(val));
+  }
+  return false;
+}
+
+function fixJson(content) {
+  let data;
+  try {
+    data = JSON.parse(content);
+  } catch {
+    return content;
+  }
+  let touched = false;
+
+  const visit = (node) => {
+    if (!node || typeof node !== "object") return;
+    if (Array.isArray(node)) return node.forEach(visit);
+
+    if (Array.isArray(node.locators) && node.locators.length > 0) {
+      const keep = node.locators.filter(locatorHasPlaceholderJson);
+      if (keep.length > 0 && keep.length < node.locators.length) {
+        node.locators = keep;
+        touched = true;
+      }
+    }
+    Object.values(node).forEach(visit);
+  };
+
+  visit(data);
+  return touched ? JSON.stringify(data, null, 2) + "\n" : content;
+}
+
+async function cloneWorkspace(root) {
+  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "codemod-clone-"));
+  const cloneRoot = path.join(tmpDir, path.basename(root));
+
+  if (fsPromises.cp) {
+    await fsPromises.cp(root, cloneRoot, { recursive: true, force: true });
+  } else {
+    const res = spawnSync("cp", ["-R", ".", cloneRoot], { cwd: root, stdio: "inherit" });
+    if (res.status !== 0) throw new Error("Failed to clone workspace");
+  }
+
+  const mapper = (orig) => path.join(cloneRoot, path.relative(root, orig));
+  return { cloneRoot, mapper };
+}
+
+async function initGitRepo(cloneRoot) {
+  if (fs.existsSync(path.join(cloneRoot, ".git"))) return;
+  const run = (args) => spawnSync("git", args, { cwd: cloneRoot, stdio: "inherit" });
+  run(["init"]);
+  run(["add", "."]);
+  run(["commit", "-m", "chore: baseline before codemod"]);
+}
+
+function makeDiff(originalPath, clonedPath, fixed) {
+  const tmpOutDir = fs.mkdtempSync(path.join(os.tmpdir(), "codemod-out-"));
+  const fixedPath = path.join(tmpOutDir, path.basename(clonedPath));
+  fs.writeFileSync(fixedPath, fixed, "utf8");
+  const diff = spawnSync("diff", ["-u", originalPath, fixedPath], { encoding: "utf8" });
+  return diff.stdout || diff.stderr || "";
+}
+
+async function readStdin() {
+  return await new Promise((resolve) => {
+    let d = "";
+    process.stdin.setEncoding("utf8");
+    process.stdin.on("data", (c) => (d += c));
+    process.stdin.on("end", () => resolve(d));
+  });
+}

package/bin/client/code_cleanup/utils.js

@@ -10,7 +10,7 @@ import * as t from "@babel/types";
 import { CucumberExpression, ParameterTypeRegistry } from "@cucumber/cucumber-expressions";
 import { existsSync, readFileSync, writeFileSync } from "fs";
 import { getAiConfig } from "../code_gen/page_reflection.js";
-import socketLogger from "../utils/socket_logger.js";
+import socketLogger, { getErrorMessage } from "../utils/socket_logger.js";
 
 const STEP_KEYWORDS = new Set(["Given", "When", "Then"]);
 
@@ -308,18 +308,27 @@ export function getDefaultPrettierConfig() {
       const configContent = readFileSync(prettierConfigPath, "utf-8");
       prettierConfig = JSON.parse(configContent);
     } catch (error) {
-      socketLogger.error("Error parsing Prettier config file", error);
-      console.error(`Error parsing Prettier config file: ${error}`);
+      socketLogger.error(
+        `Error parsing Prettier config file: ${getErrorMessage(error)}`,
+        undefined,
+        "getDefaultPrettierConfig"
+      );
     }
   } else {
     // save the default config to .prettierrc
     try {
       writeFileSync(prettierConfigPath, JSON.stringify(prettierConfig, null, 2), "utf-8");
-      socketLogger.info(`Created default Prettier config at ${prettierConfigPath}`);
-      console.log(`Created default Prettier config at ${prettierConfigPath}`);
+      socketLogger.info(
+        `Created default Prettier config at ${prettierConfigPath}`,
+        undefined,
+        "getDefaultPrettierConfig"
+      );
     } catch (error) {
-      socketLogger.error(`Error writing Prettier config file: ${error}`);
-      console.error(`Error writing Prettier config file: ${error}`);
+      socketLogger.error(
+        `Error writing Prettier config file: ${getErrorMessage(error)}`,
+        undefined,
+        "getDefaultPrettierConfig"
+      );
     }
   }
   return prettierConfig;