@deuriib/dgii-ecf 0.3.2 → 0.4.1

package/dist/index.js

@@ -611,27 +611,11 @@ var P12Reader = class {
 // src/signing.ts
 import crypto from "crypto";
 import { DOMParser } from "@xmldom/xmldom";
-import { C14nCanonicalization, SignedXml } from "xml-crypto";
+import { SignedXml } from "xml-crypto";
 var C14N_INCLUSIVE = "http://www.w3.org/TR/2001/REC-xml-c14n-20010315";
 var RSA_SHA256 = "http://www.w3.org/2001/04/xmldsig-more#rsa-sha256";
 var SHA256 = "http://www.w3.org/2001/04/xmlenc#sha256";
 var ENVELOPED = "http://www.w3.org/2000/09/xmldsig#enveloped-signature";
-var CUSTOM_DIGEST_URI = "http://dgii.gov.do/digest/sha256-c14n";
-var DgiiDigest = class {
-  getHash(xml) {
-    const doc = new DOMParser().parseFromString(
-      xml
-    );
-    const canonical = new C14nCanonicalization().process(
-      doc,
-      {}
-    );
-    return crypto.createHash("sha256").update(canonical, "utf8").digest("base64");
-  }
-  getAlgorithmName() {
-    return SHA256;
-  }
-};
 var parseStrict = (xml) => {
   const errors = [];
   const doc = new DOMParser({
@@ -700,12 +684,10 @@ var Signature = class {
         signatureAlgorithm: RSA_SHA256,
         canonicalizationAlgorithm: C14N_INCLUSIVE
       });
-      const hashAlgorithms = sig.HashAlgorithms;
-      hashAlgorithms[CUSTOM_DIGEST_URI] = DgiiDigest;
       sig.addReference({
         xpath: `//*[local-name(.)='${elementName}']`,
         transforms: [ENVELOPED],
-        digestAlgorithm: CUSTOM_DIGEST_URI,
+        digestAlgorithm: SHA256,
         isEmptyUri: true
       });
       cleanNodes(doc);
@@ -1034,8 +1016,39 @@ var ECF = class {
   }
   buildIdempotencyKey(signedXml) {
     const rnc = extractElementText(signedXml, "RNCEmisor") ?? "unknown-rnc";
-    const encf = extractElementText(signedXml, "eNCF") ?? "unknown-encf";
-    return `${rnc}:${encf}:${sha256Hex(signedXml)}`;
+    const ncf = extractElementText(signedXml, "eNCF") ?? extractElementText(signedXml, "RangoNCF") ?? "unknown-ncf";
+    return `${rnc}:${ncf}:${sha256Hex(signedXml)}`;
+  }
+  /**
+   * Run a submission through the persist-before-transmit idempotency flow.
+   *
+   * The pending marker is written first so an interrupted send can be
+   * reconciled instead of re-issued; a successful response replaces it, and
+   * a failure clears it so the caller can retry.
+   */
+  async submitIdempotent(key, send) {
+    const cached = await this.idempotency.get(key);
+    if (cached !== void 0) {
+      if (isPendingSubmission(cached)) {
+        return err(
+          new DgiiError(
+            "A submission with this key is already pending; reconcile via a status lookup before retrying",
+            { code: "IDEMPOTENCY" }
+          )
+        );
+      }
+      return ok(cached);
+    }
+    return this.singleFlight(key, async () => {
+      await this.idempotency.set(key, PENDING_SUBMISSION);
+      const result = await send();
+      if (result.isOk()) {
+        await this.idempotency.set(key, result.value);
+      } else {
+        await this.idempotency.delete(key);
+      }
+      return result;
+    });
   }
   async singleFlight(key, task) {
     const existing = this.inFlight.get(key);
@@ -1108,66 +1121,28 @@ var ECF = class {
    */
   async sendElectronicDocument(signedXml, fileName, buyerHost) {
     const key = this.buildIdempotencyKey(signedXml);
-    const cached = await this.idempotency.get(key);
-    if (cached !== void 0) {
-      if (isPendingSubmission(cached)) {
-        return err(
-          new DgiiError(
-            "A submission with this key is already pending; reconcile via a status lookup before retrying",
-            { code: "IDEMPOTENCY" }
-          )
-        );
-      }
-      return ok(cached);
-    }
-    return this.singleFlight(key, async () => {
-      await this.idempotency.set(key, PENDING_SUBMISSION);
+    return this.submitIdempotent(key, () => {
       const url = buyerHost ? buildSenderReceiverUrl(buyerHost, "fe/recepcion/api/ecf" /* SendInvoice */) : buildUrl(this.environment, "recepcion/api/FacturasElectronicas" /* SendInvoice */);
-      const result = await this.http.postMultipart(
+      return this.http.postMultipart(
         url,
         fileName,
         signedXml,
         { absoluteUrl: true, resource: "recepcion/api/FacturasElectronicas" /* SendInvoice */ }
       );
-      if (result.isOk()) {
-        await this.idempotency.set(key, result.value);
-      } else {
-        await this.idempotency.delete(key);
-      }
-      return result;
     });
   }
   /** Submit a signed summary invoice (RFCE). Idempotent like submissions. */
   async sendSummary(signedXml, fileName) {
     const key = this.buildIdempotencyKey(signedXml);
-    const cached = await this.idempotency.get(key);
-    if (cached !== void 0) {
-      if (isPendingSubmission(cached)) {
-        return err(
-          new DgiiError(
-            "A submission with this key is already pending; reconcile via a status lookup before retrying",
-            { code: "IDEMPOTENCY" }
-          )
-        );
-      }
-      return ok(cached);
-    }
-    return this.singleFlight(key, async () => {
-      await this.idempotency.set(key, PENDING_SUBMISSION);
-      const url = buildUrl(this.environment, "recepcionfc/api/recepcion/ecf" /* SendSummary */, BaseUrl.CF);
-      const result = await this.http.postMultipart(
-        url,
+    return this.submitIdempotent(
+      key,
+      () => this.http.postMultipart(
+        buildUrl(this.environment, "recepcionfc/api/recepcion/ecf" /* SendSummary */, BaseUrl.CF),
         fileName,
         signedXml,
         { absoluteUrl: true, resource: "recepcionfc/api/recepcion/ecf" /* SendSummary */ }
-      );
-      if (result.isOk()) {
-        await this.idempotency.set(key, result.value);
-      } else {
-        await this.idempotency.delete(key);
-      }
-      return result;
-    });
+      )
+    );
   }
   statusTrackId(trackId) {
     const url = buildUrl(this.environment, "consultaresultado/api/Consultas/Estado" /* TrackResultStatus */);
@@ -1227,21 +1202,37 @@ var ECF = class {
       { absoluteUrl: true, resource: "consultarfce/api/Consultas/Consulta" /* InquiryInvoiceSummary */ }
     );
   }
+  /**
+   * Submit a signed commercial approval (ACECF). Idempotent like submissions,
+   * keyed on `RNC + eNCF + SHA-256(signed XML)`.
+   */
   sendCommercialApproval(signedXml, fileName) {
-    const url = buildUrl(this.environment, "aprobacionComercial/api/AprobacionComercial" /* CommercialApproval */);
-    return this.http.postMultipart(
-      url,
-      fileName,
-      signedXml,
-      { absoluteUrl: true, resource: "aprobacionComercial/api/AprobacionComercial" /* CommercialApproval */ }
+    const key = this.buildIdempotencyKey(signedXml);
+    return this.submitIdempotent(
+      key,
+      () => this.http.postMultipart(
+        buildUrl(this.environment, "aprobacionComercial/api/AprobacionComercial" /* CommercialApproval */),
+        fileName,
+        signedXml,
+        { absoluteUrl: true, resource: "aprobacionComercial/api/AprobacionComercial" /* CommercialApproval */ }
+      )
     );
   }
+  /**
+   * Submit a signed range-voiding request (ANECF). Idempotent like
+   * submissions, keyed on `RNC + RangoNCF + SHA-256(signed XML)`.
+   */
   voidENCF(signedXml, fileName) {
-    const url = buildUrl(this.environment, "anulacionrangos/api/operaciones/anularrango" /* Void */);
-    return this.http.postMultipart(url, fileName, signedXml, {
-      absoluteUrl: true,
-      resource: "anulacionrangos/api/operaciones/anularrango" /* Void */
-    });
+    const key = this.buildIdempotencyKey(signedXml);
+    return this.submitIdempotent(
+      key,
+      () => this.http.postMultipart(
+        buildUrl(this.environment, "anulacionrangos/api/operaciones/anularrango" /* Void */),
+        fileName,
+        signedXml,
+        { absoluteUrl: true, resource: "anulacionrangos/api/operaciones/anularrango" /* Void */ }
+      )
+    );
   }
 };
 export {