@detergent-software/conductor 1.4.0 → 1.5.0-dev.1

package/mod/hooks/model.ts

@@ -2,7 +2,7 @@
 // the band and pane show, and what each event asks the mod to do. register.tsx does
 // the engine's part (only its top-level functions may take `$`); vitest tests this file in CI
 // (apps/conductor/mod/tests/model.spec.ts).
-import type { ConductorInboxItem, ConductorNotify, ConductorSnapshot, ConductorWorker } from '../types';
+import type { ConductorInboxItem, ConductorLink, ConductorNotify, ConductorSnapshot, ConductorWorker } from '../types';
 
 // A daemon API answer: its status and parsed JSON body.
 export type ApiAnswer = { body: unknown; status: number };
@@ -222,7 +222,7 @@ export function inboxText(inbox: readonly ConductorInboxItem[], now: number): st
       `#${i.id}  ${i.kind}  ${i.item ?? ''}${i.project ? ` (${i.project})` : ''}  ${age(i.raisedAt, now)}`,
       `    ${i.text}`,
       ...i.commands.map((c) => `    $ ${c}`),
-      ...i.links.map((l) => `    ${l}`),
+      ...i.links.map((l) => `    ${l.label}: ${l.href}`),
     ])
     .join('\n');
 }
@@ -367,7 +367,7 @@ export function parseInbox(body: unknown): ConductorInboxItem[] | null {
         id: i.id,
         item: typeof i.item === 'string' ? i.item : null,
         kind: i.kind,
-        links: strings(i.links),
+        links: links(i.links),
         project: typeof i.project === 'string' ? i.project : null,
         raisedAt: typeof i.raisedAt === 'string' ? i.raisedAt : '',
         text: i.text,
@@ -627,6 +627,14 @@ function isRecord(value: unknown): value is Record<string, unknown> {
   return typeof value === 'object' && value !== null && !Array.isArray(value);
 }
 
+// An inbox item's named links; one without an href or a label is left out.
+function links(value: unknown): ConductorLink[] {
+  if (!Array.isArray(value)) return [];
+  return value.flatMap((l: unknown) =>
+    isRecord(l) && typeof l.href === 'string' && typeof l.label === 'string' ? [{ href: l.href, label: l.label }] : [],
+  );
+}
+
 function strings(value: unknown): string[] {
   return Array.isArray(value) ? value.filter((v): v is string => typeof v === 'string') : [];
 }

package/mod/hooks/register.tsx

@@ -809,15 +809,13 @@ export const register: Register = (on) => {
                   onPress={(press) => copy($, command, press.surface)}
                 />
               ))}
-              {item.links
-                .slice(0, 2)
-                .map((href, n) =>
-                  e.surface === 'terminal' && isWindows && isWebLink(href) ? (
-                    <Button key={`link-${item.id}-${n}`} label='open' onPress={() => openLink($, href)} />
-                  ) : (
-                    <Link href={href} key={`link-${item.id}-${n}`} label='open' />
-                  ),
-                )}
+              {item.links.map(({ href, label }, n) =>
+                e.surface === 'terminal' && isWindows && isWebLink(href) ? (
+                  <Button key={`link-${item.id}-${n}`} label={`open ${label}`} onPress={() => openLink($, href)} />
+                ) : (
+                  <Link href={href} key={`link-${item.id}-${n}`} label={`open ${label}`} />
+                ),
+              )}
               {item.kind !== 'plan' && (
                 <Button
                   key={`done-${item.id}`}

package/mod/types/index.d.ts

@@ -20,12 +20,18 @@ export type ConductorInboxItem = {
   id: number;
   item: string | null;
   kind: string;
-  links: string[];
+  // Each named by the daemon (ATK-509), such as { label: 'PR 2078', href: 'https://…' }.
+  links: ConductorLink[];
   project: string | null;
   raisedAt: string;
   text: string;
 };
 
+export type ConductorLink = {
+  href: string;
+  label: string;
+};
+
 // GET /notify as the mod draws it: the profile, the others to switch to, Remote Control's state.
 export type ConductorNotify = {
   held: number;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@detergent-software/conductor",
-	"version": "1.4.0",
+	"version": "1.5.0-dev.1",
 	"description": "Conductor: the local daemon that runs conducted projects' work loops (conduct serve) and its conduct CLI.",
 	"type": "module",
 	"bin": {