@detergent-software/conductor 1.4.0-dev.14 → 1.4.0-dev.15

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 Releases are tagged `conductor-v<version>` and staged on npm by `atk-conductor-release` (`pipelines/release-conductor.yml`), which writes each section below. `scripts/check-changelog.mjs` fails when a tag has no section here.
 
+## [1.4.0-dev.15](https://emergentcode.visualstudio.com/Emergent%20Software/_git/Emergent.AgenticToolkit/branchCompare?baseVersion=GTconductor-v1.4.0-dev.14&targetVersion=GTconductor-v1.4.0-dev.15) (2026-10-15)
+
+### Bug Fixes
+
+* **conductor:** approve and revise from the console through conduct (ATK-508) ([f3f1785](https://emergentcode.visualstudio.com/Emergent%20Software/_git/Emergent.AgenticToolkit/commit/f3f1785136e152ade05cad8cab8e938c5eefef08))
+* **conductor:** say when an approve may have posted, on every path (ATK-508) ([8278f23](https://emergentcode.visualstudio.com/Emergent%20Software/_git/Emergent.AgenticToolkit/commit/8278f23a6adfe6a73904674802c6026a54bba983))
+
 ## [1.4.0-dev.14](https://emergentcode.visualstudio.com/Emergent%20Software/_git/Emergent.AgenticToolkit/branchCompare?baseVersion=GTconductor-v1.4.0-dev.13&targetVersion=GTconductor-v1.4.0-dev.14) (2026-10-15)
 
 ### Bug Fixes

package/mod/hooks/model.ts

@@ -383,9 +383,15 @@ export function errorOf(answer: ApiAnswer): string {
   return `the conductor answered ${answer.status}`;
 }
 
+// What `conduct approve|revise` adds when the daemon can't say whether it posted the comment.
+export const MAYBE_POSTED = 'the comment may be on the item already: look before answering again';
+
 // POST /inbox/:id/resolve's answer as the line to show, as `conduct approve|revise|done` says it.
 export function answerText(action: 'approve' | 'done' | 'revise', id: number, answer: ApiAnswer): string {
-  if (answer.status !== 200) return `not ${action === 'done' ? 'done' : `${action}d`}: ${errorOf(answer)}`;
+  if (answer.status !== 200) {
+    const unknown = answer.status === 502 && isRecord(answer.body) && answer.body.posted === 'unknown';
+    return `not ${action === 'done' ? 'done' : `${action}d`}: ${errorOf(answer)}${unknown ? `; ${MAYBE_POSTED}` : ''}`;
+  }
   const body = isRecord(answer.body) ? answer.body : {};
   const key = isRecord(body.item) && typeof body.item.item === 'string' ? body.item.item : `#${id}`;
   if (action === 'done') return `done: ${key}`;
@@ -395,23 +401,26 @@ export function answerText(action: 'approve' | 'done' | 'revise', id: number, an
   return `${action === 'approve' ? 'approved' : 'asked for a revision of'} ${key}: ${where}`;
 }
 
-// A `conduct attach` run as the line to show: what it printed when it attached (`woke …`, and how
-// to open the tab when none opened), else its error and details without the `conduct: ` prefix, and
-// without anything node wrote before it (a warning).
-export function attachRunText(name: string, run: { exitCode: number; stderr: string; stdout: string }): string {
+// A `conduct` run (attach, approve, revise) as the line to show: what it printed when it succeeded
+// (`woke …`, `approved …`), else `failed`, then its error and details without the `conduct: `
+// prefix, and without anything node wrote before it (a warning).
+export function runText(
+  run: { exitCode: number; stderr: string; stdout: string },
+  says: { failed: string; ok: string },
+): string {
   const lines = (text: string): string[] =>
     text
       .split('\n')
       .map((l) => l.trim())
       .filter((l) => l !== '');
-  if (run.exitCode === 0) return lines(run.stdout).join('; ') || `attached to ${name}`;
+  if (run.exitCode === 0) return lines(run.stdout).join('; ') || says.ok;
   const stderr = lines(run.stderr);
   const from = stderr.findIndex((l) => l.startsWith('conduct: '));
   const error = stderr
     .slice(Math.max(from, 0))
     .map((l) => l.replace(/^conduct: /, ''))
     .join('; ');
-  return `could not attach to ${name}: ${error || `conduct attach exited ${run.exitCode}`}`;
+  return `${says.failed}: ${error || `conduct exited ${run.exitCode}`}`;
 }
 
 // The daemon's home as the CLI finds it (apps/conductor/src/paths.ts): CONDUCTOR_HOME, else

package/mod/hooks/register.tsx

@@ -7,7 +7,6 @@ import {
   age,
   type ApiAnswer,
   answerText,
-  attachRunText,
   bandEntries,
   clearedText,
   CONSOLE_SKILL,
@@ -20,6 +19,7 @@ import {
   idleAction,
   inboxText,
   isWebLink,
+  MAYBE_POSTED,
   NO_SKILL_CONTEXT,
   NO_SKILL_WARNING,
   notifyArgs,
@@ -37,6 +37,7 @@ import {
   pushWarning,
   reaction,
   reportedState,
+  runText,
   snapshotOf,
   spendToday,
   statusText,
@@ -60,6 +61,9 @@ const CONFIRM_MS = 30_000;
 // gives up on an answer not complete within 30 s (ATK-507). `conduct attach` waits that long, and
 // $.process.run allows a command ten minutes at most.
 const ATTACH_RUN_MS = 10 * 60_000;
+// An approve or a revise asks Linear twice, and `conduct approve|revise` allows that 60 s (ATK-508);
+// this adds node's start.
+const ANSWER_RUN_MS = 2 * 60_000;
 const NOT_RUNNING = 'the conductor is not running (conduct serve)';
 
 const snapshot = atom({ plugin: 'conductor', key: 'snapshot' } as const, null);
@@ -363,13 +367,38 @@ async function follow($: EngineInterface): Promise<void> {
 }
 
 // Jason's answer to an inbox item, as `conduct approve|revise|done` posts it; the line to show.
+// Approve and revise run `conduct` (ANSWER_RUN_MS), by inbox id. Without the CLI, the API, which
+// $.http.fetch cuts off after 30 s, possibly after the comment was posted. Done doesn't ask Linear.
 async function answer(
   $: EngineInterface,
   id: number,
   body: { action: 'approve' | 'done' } | { action: 'revise'; text: string },
 ): Promise<string> {
   try {
-    const result = await callApi($, 'POST', `/inbox/${id}/resolve`, body);
+    const cli = cliOf($);
+    if (body.action !== 'done' && (await $.fs.exists(cli))) {
+      const failed = `not ${body.action}d`;
+      const argv = body.action === 'approve' ? ['approve', `#${id}`] : ['revise', `#${id}`, body.text];
+      let run;
+      try {
+        run = await $.process.run(['node', cli, ...argv], { timeoutMs: ANSWER_RUN_MS });
+      } catch (error) {
+        return `${failed}: ${error instanceof Error ? error.message : String(error)}`;
+      }
+      refreshSoon($);
+      return runText(run, {
+        failed,
+        ok: `${body.action === 'approve' ? 'approved' : 'asked for a revision of'} #${id}`,
+      });
+    }
+    const at = await endpoint($);
+    let result: ApiAnswer;
+    try {
+      result = await callApi($, 'POST', `/inbox/${id}/resolve`, body, at);
+    } catch (error) {
+      if (body.action === 'done') throw error;
+      return `not ${body.action}d: ${error instanceof Error ? error.message : String(error)}; ${MAYBE_POSTED}`;
+    }
     refreshSoon($);
     return answerText(body.action, id, result);
   } catch (error) {
@@ -415,7 +444,7 @@ async function attach($: EngineInterface, id: number, name: string): Promise<str
       $.ui.toast(`attaching to ${name}…`);
       const run = await $.process.run(['node', cli, 'attach', `#${id}`], { timeoutMs: ATTACH_RUN_MS });
       refreshSoon($);
-      return attachRunText(name, run);
+      return runText(run, { failed: `could not attach to ${name}`, ok: `attached to ${name}` });
     }
     const result = await callApi($, 'POST', `/workers/${id}/attach`);
     refreshSoon($);

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@detergent-software/conductor",
-	"version": "1.4.0-dev.14",
+	"version": "1.4.0-dev.15",
 	"description": "Conductor: the local daemon that runs conducted projects' work loops (conduct serve) and its conduct CLI.",
 	"type": "module",
 	"bin": {