@detergent-software/conductor 1.4.0-dev.1 → 1.4.0-dev.11

package/mod/hooks/register.tsx

@@ -18,6 +18,7 @@ import {
   homeOf,
   idleAction,
   inboxText,
+  isWebLink,
   NO_SKILL_CONTEXT,
   NO_SKILL_WARNING,
   notifyArgs,
@@ -80,6 +81,8 @@ let warms = 0;
 let turnsStarted = 0;
 const pingTurns = new Set<string>();
 let isClearing = false;
+// ATK-494: on Windows the terminal's [open] runs the browser itself; elsewhere it stays a Link.
+let isWindows = false;
 
 type Endpoint = { port: number; token: string };
 
@@ -411,6 +414,18 @@ async function copy(
   $.ui.toast(copied.isCopied ? `copied: ${text}` : `not copied: ${text}`);
 }
 
+// The Windows terminal's [open]: the default browser, run once (ATK-494). A Link there is an OSC 8
+// span, which a ctrl+click in a pane opened twice: the pane and Windows Terminal each opened it.
+// rundll32 hands the URL over whole (explorer.exe would split it at a comma) and exits 0.
+async function openLink($: EngineInterface, href: string): Promise<void> {
+  try {
+    const run = await $.process.run(['rundll32.exe', 'url.dll,FileProtocolHandler', href]);
+    if (run.exitCode !== 0) $.ui.toast(`not opened: ${href}`);
+  } catch {
+    $.ui.toast(`not opened: ${href}`);
+  }
+}
+
 // Stages a band approve for its `y`; it lapses unless pressed within CONFIRM_MS.
 async function confirm($: EngineInterface, id: number): Promise<void> {
   await update($, confirming, () => id);
@@ -469,6 +484,7 @@ export const register: Register = (on) => {
     if (!e.isInteractive) return started;
     isConsole = (await $.env.get('CONDUCTOR_CONSOLE')) === '1';
     if (!isConsole) return started;
+    isWindows = (await $.env.get('OS')) === 'Windows_NT';
     $.clock.every(POLL_MS, () => void refresh($));
     await refresh($);
     await registerCommands($);
@@ -744,9 +760,15 @@ export const register: Register = (on) => {
                   onPress={(press) => copy($, command, press.surface)}
                 />
               ))}
-              {item.links.slice(0, 2).map((href, n) => (
-                <Link href={href} key={`link-${item.id}-${n}`} label='open' />
-              ))}
+              {item.links
+                .slice(0, 2)
+                .map((href, n) =>
+                  e.surface === 'terminal' && isWindows && isWebLink(href) ? (
+                    <Button key={`link-${item.id}-${n}`} label='open' onPress={() => openLink($, href)} />
+                  ) : (
+                    <Link href={href} key={`link-${item.id}-${n}`} label='open' />
+                  ),
+                )}
               {item.kind !== 'plan' && (
                 <Button
                   key={`done-${item.id}`}

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@detergent-software/conductor",
-	"version": "1.4.0-dev.1",
+	"version": "1.4.0-dev.11",
 	"description": "Conductor: the local daemon that runs conducted projects' work loops (conduct serve) and its conduct CLI.",
 	"type": "module",
 	"bin": {