@desplega.ai/agent-swarm 2.4.0 → 2.4.1

package/src/telemetry.ts

@@ -22,7 +22,7 @@ import {
   validOrgDomain,
   validOrgId,
 } from "./telemetry-context";
-import type { PropsFor, TelemetryEventName } from "./telemetry-contract";
+import type { EventContext, PropsFor, TelemetryEventName } from "./telemetry-contract";
 import { isEnvFlagEnabled } from "./utils/env-flag";
 import { getNodeEnv } from "./utils/node-env";
 import { normalizeOrgWebsite } from "./utils/org-website";
@@ -68,6 +68,7 @@ let cachedOrgId: string | undefined;
 /** Email domain of the org's admin, set by the API server (`setTelemetryOrgDomain`). */
 let cachedOrgDomain: string | undefined;
 let roleResolver: ((userId: string) => TelemetryUserRole | undefined) | null = null;
+let functionResolver: ((userId: string) => EventContext["user_function"]) | null = null;
 let identityReloader: (() => Promise<void>) | null = null;
 let lastIdentityLoadAt = 0;
 let source = "unknown";
@@ -510,6 +511,13 @@ export function setTelemetryRoleResolver(
   roleResolver = resolver;
 }
 
+/** API server only: cache-backed lookup of the actor's job function. */
+export function setTelemetryFunctionResolver(
+  resolver: ((userId: string) => EventContext["user_function"]) | null,
+): void {
+  functionResolver = resolver;
+}
+
 /**
  * True when `track()` would send: telemetry is on, an install ID exists and an
  * org ID resolved. Emitters that record "already sent" state check this first.
@@ -664,8 +672,10 @@ function emit(
         swarmVersion: pkg.version,
         installMethod: cachedInstallMethod,
         installPreset: cachedInstallPreset,
-        // Stays null until the dashboard reports where the visitor came from.
-        acquisitionSource: null,
+        acquisitionSource: process.env.SWARM_ORG_ACQUISITION_SOURCE,
+        teamSize: process.env.SWARM_ORG_TEAM_SIZE,
+        useCase: process.env.SWARM_ORG_USE_CASE,
+        userFunction: userId ? functionResolver?.(userId) : undefined,
       }),
       properties: normalizeProperties(event, {
         ...properties,
@@ -745,6 +755,7 @@ export function _resetTelemetryStateForTests(): void {
   cachedOrgId = undefined;
   cachedOrgDomain = undefined;
   roleResolver = null;
+  functionResolver = null;
   identityReloader = null;
   lastIdentityLoadAt = 0;
 }

package/src/tests/app-action-run-tool.test.ts

@@ -0,0 +1,178 @@
+import { afterAll, beforeAll, expect, test } from "bun:test";
+import { unlink } from "node:fs/promises";
+import { createServer as createHttpServer } from "node:http";
+import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
+import { type AppRecord, createApp } from "../apps/store";
+import { closeDb, createAgent, getTaskById, initDb } from "../be/db";
+import { upsertScriptByName } from "../be/scripts/db";
+import { handleCore } from "../http/core";
+import { handleMcpBridge } from "../http/mcp-bridge";
+import { getPathSegments, parseQueryParams } from "../http/utils";
+import { LEGACY_POLICY, type LegacyRule } from "../rbac";
+import { isMcpToolAllowedForScripts } from "../scripts-runtime/sdk-allowlist";
+import { registerAppActionRunTool } from "../tools/app-action-run";
+import { markExtensionRequestOrigin, markScriptSdkRequestOrigin } from "../tools/utils";
+import { SKIP_SANDBOX_SPAWN_TESTS } from "./sandbox-spawn-test-helpers";
+import { listenOnFreePort } from "./test-net";
+import { CHILD_PROCESS_TEST_BUDGET_MS } from "./test-proc";
+
+const dbPath = `/private/tmp/test-app-action-run-tool-${process.pid}.sqlite`;
+const agentId = crypto.randomUUID();
+const ownerId = crypto.randomUUID();
+const apiKey = "example-app-action-run-key";
+const previousKey = process.env.AGENT_SWARM_API_KEY;
+const previousBase = process.env.MCP_BASE_URL;
+const definition: AppRecord["definition"] = {
+  schemaVersion: 1,
+  models: { note: { columns: { title: { kind: "string" } } } },
+  actions: { triage: { kind: "task", prompt: "Triage the notes." } },
+  pages: { main: { root: "root", elements: { root: { type: "Container", props: {} } } } },
+  defaultPage: "main",
+};
+type ToolResult = {
+  isError?: boolean;
+  structuredContent: {
+    message: string;
+    data: { ok: boolean; taskId: string; status: string; result?: unknown };
+  };
+};
+let handler: (args: unknown, extra: unknown) => Promise<ToolResult>;
+let appId: string;
+
+async function removeDb() {
+  for (const suffix of ["", "-wal", "-shm"]) await unlink(dbPath + suffix).catch(() => undefined);
+}
+beforeAll(async () => {
+  process.env.AGENT_SWARM_API_KEY = apiKey;
+  await removeDb();
+  initDb(dbPath);
+  await createAgent({ id: agentId, name: "Action invoker", isLead: false, status: "idle" });
+  await createAgent({ id: ownerId, name: "Script owner", isLead: true, status: "idle" });
+  appId = (await createApp({ name: "Action tool", definition })).id;
+  const server = new McpServer({ name: "app-action-run-tool", version: "1.0.0" });
+  registerAppActionRunTool(server);
+  handler = (server as unknown as { _registeredTools: Record<string, { handler: typeof handler }> })
+    ._registeredTools["app-action-run"]!.handler;
+});
+afterAll(async () => {
+  closeDb();
+  await removeDb();
+  if (previousKey === undefined) delete process.env.AGENT_SWARM_API_KEY;
+  else process.env.AGENT_SWARM_API_KEY = previousKey;
+  if (previousBase === undefined) delete process.env.MCP_BASE_URL;
+  else process.env.MCP_BASE_URL = previousBase;
+});
+function call(
+  action: string,
+  input: Record<string, unknown> = {},
+  origin?: "script-sdk" | "extension",
+  id = agentId,
+  target = appId,
+) {
+  const extra = { sessionId: "action-tool", requestInfo: { headers: { "x-agent-id": id } } };
+  if (origin === "script-sdk") markScriptSdkRequestOrigin(extra);
+  if (origin === "extension") markExtensionRequestOrigin(extra);
+  return handler({ appId: target, action, input }, extra);
+}
+
+test("runs task actions with the verified caller and the REST response shape", async () => {
+  const output = await call("triage", { caller: { kind: "guest", id: "forged" } });
+  expect(output.isError).not.toBe(true);
+  expect(output.structuredContent).toMatchObject({ ok: true, status: "pending" });
+  const task = await getTaskById(output.structuredContent.taskId);
+  expect(task?.task).toContain(`"kind":"agent","id":"${agentId}","name":"Action invoker"`);
+});
+
+test("refuses script and extension origins and stays outside the SDK allowlist", async () => {
+  for (const origin of ["script-sdk", "extension"] as const) {
+    const output = await call("triage", {}, origin);
+    expect(output.isError).toBe(true);
+    expect(output.structuredContent.message).toContain("cannot run app actions");
+  }
+  expect(isMcpToolAllowedForScripts("app-action-run")).toBe(false);
+});
+
+test("rejects missing agents, apps, actions, and denied principals", async () => {
+  expect((await call("triage", {}, undefined, "")).isError).toBe(true);
+  expect((await call("triage", {}, undefined, agentId, "missing")).isError).toBe(true);
+  expect((await call("missing")).isError).toBe(true);
+  const policy = LEGACY_POLICY as unknown as Record<"app.use", LegacyRule>;
+  const original = policy["app.use"];
+  policy["app.use"] = { name: "deny-actions", denyReason: "denied actions", evaluate: () => false };
+  try {
+    expect((await call("triage")).isError).toBe(true);
+  } finally {
+    policy["app.use"] = original;
+  }
+});
+
+test.skipIf(SKIP_SANDBOX_SPAWN_TESTS)(
+  "runs script actions as the owner while preserving the invoking agent caller",
+  async () => {
+    const server = createHttpServer(async (req, res) => {
+      const id = req.headers["x-agent-id"] as string | undefined;
+      if (await handleCore(req, res, id, apiKey)) return;
+      if (
+        await handleMcpBridge(
+          req,
+          res,
+          getPathSegments(req.url ?? ""),
+          parseQueryParams(req.url ?? ""),
+          id,
+        )
+      )
+        return;
+      res.writeHead(404).end();
+    });
+    try {
+      const port = await listenOnFreePort(server);
+      process.env.MCP_BASE_URL = `http://localhost:${port}`;
+      const saved = await upsertScriptByName({
+        name: "action_tool_owner",
+        scope: "agent",
+        scopeId: ownerId,
+        agentId: ownerId,
+        source: `export default async function(args, ctx) {
+        const response = await ctx.swarm.app_row_create({ appId: args.app.id, model: "note", values: { title: "owner-write" } });
+        return { caller: args.caller, row: (response?.data ?? response).row };
+      }`,
+        description: "Owner action fixture",
+        intent: "Verify script owner and caller",
+        signatureJson: "{}",
+        typeChecked: true,
+        embeddingMode: "skip",
+      });
+      const app = await createApp({
+        name: "Script action",
+        definition: {
+          ...definition,
+          actions: {
+            write: {
+              kind: "script",
+              scriptId: saved.script.id,
+              args: { caller: { kind: "guest", id: "default-forgery" } },
+            },
+          },
+        },
+      });
+      const output = await call(
+        "write",
+        { caller: { kind: "operator", id: "forged" } },
+        undefined,
+        agentId,
+        app.id,
+      );
+      expect(output.isError).not.toBe(true);
+      expect(output.structuredContent).toMatchObject({
+        ok: true,
+        result: {
+          caller: { kind: "agent", id: agentId, name: "Action invoker" },
+          row: { title: "owner-write", createdBy: `agent:${ownerId}` },
+        },
+      });
+    } finally {
+      if (server.listening) await new Promise<void>((resolve) => server.close(() => resolve()));
+    }
+  },
+  CHILD_PROCESS_TEST_BUDGET_MS,
+);

package/src/tests/app-row-tools.test.ts

@@ -0,0 +1,360 @@
+import { afterAll, beforeAll, expect, spyOn, test } from "bun:test";
+import { unlink } from "node:fs/promises";
+import { createServer as createHttpServer } from "node:http";
+import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
+import {
+  type AnySchema,
+  normalizeObjectSchema,
+  safeParseAsync,
+} from "@modelcontextprotocol/sdk/server/zod-compat.js";
+import * as rowStore from "../apps/row-store";
+import { type AppRecord, createApp } from "../apps/store";
+import { closeDb, createAgent, initDb } from "../be/db";
+import { typecheckScript } from "../be/scripts/typecheck";
+import { handleCore } from "../http/core";
+import { handleMcpBridge } from "../http/mcp-bridge";
+import { getPathSegments, parseQueryParams } from "../http/utils";
+import { LEGACY_POLICY, type LegacyRule } from "../rbac";
+import { runScript } from "../scripts-runtime/loader";
+import { registerAppRowTools } from "../tools/app-rows";
+import { markScriptSdkRequestOrigin } from "../tools/utils";
+import { SKIP_SANDBOX_SPAWN_TESTS } from "./sandbox-spawn-test-helpers";
+import { listenOnFreePort } from "./test-net";
+import { CHILD_PROCESS_TEST_BUDGET_MS } from "./test-proc";
+
+const dbPath = `/private/tmp/test-app-row-tools-${process.pid}.sqlite`;
+const agentId = crypto.randomUUID();
+const apiKey = "example-app-row-tools-key";
+const previousKey = process.env.AGENT_SWARM_API_KEY;
+const definition: AppRecord["definition"] = {
+  schemaVersion: 1,
+  models: {
+    note: {
+      columns: {
+        title: { kind: "string" },
+        rank: { kind: "number" },
+        active: { kind: "boolean" },
+        state: { kind: "enum", enum: ["open", "closed"] },
+        externalId: { kind: "string" },
+        projected: { kind: "string", source: { of: "external", field: "title" } },
+      },
+      sources: { external: { connector: "swarm-tasks", joinKey: "externalId", config: {} } },
+    },
+  },
+  pages: { main: { root: "root", elements: { root: { type: "Container", props: {} } } } },
+  defaultPage: "main",
+};
+
+type ToolResult = {
+  isError?: boolean;
+  structuredContent: {
+    message: string;
+    row: import("../apps/row-store").AppRow;
+    rows: import("../apps/row-store").AppRow[];
+    total: number;
+    deleted?: number;
+    ok?: boolean;
+  };
+};
+type RegisteredTool = {
+  inputSchema: AnySchema;
+  handler: (args: unknown, extra: unknown) => Promise<ToolResult>;
+};
+let tools: Record<string, RegisteredTool>;
+let appId: string;
+
+async function removeDb() {
+  for (const suffix of ["", "-wal", "-shm"]) await unlink(dbPath + suffix).catch(() => undefined);
+}
+
+beforeAll(async () => {
+  process.env.AGENT_SWARM_API_KEY = apiKey;
+  await removeDb();
+  initDb(dbPath);
+  await createAgent({ id: agentId, name: "row-tool-agent", isLead: false, status: "idle" });
+  appId = (await createApp({ name: "Row tools", definition })).id;
+  const server = new McpServer({ name: "app-row-tools", version: "1.0.0" });
+  registerAppRowTools(server);
+  tools = (server as unknown as { _registeredTools: Record<string, RegisteredTool> })
+    ._registeredTools;
+});
+
+afterAll(async () => {
+  closeDb();
+  await removeDb();
+  if (previousKey === undefined) delete process.env.AGENT_SWARM_API_KEY;
+  else process.env.AGENT_SWARM_API_KEY = previousKey;
+});
+
+async function call(
+  name: string,
+  input: Record<string, unknown>,
+  id: string | undefined = agentId,
+) {
+  const tool = tools[name]!;
+  const schema = normalizeObjectSchema(tool.inputSchema) ?? tool.inputSchema;
+  const args = { appId, model: "note", ...input };
+  const parsed = await safeParseAsync(schema, args);
+  if (!parsed.success) throw new Error(JSON.stringify(parsed.error));
+  // Exercise the registrar with the same trusted origin marker as the script bridge.
+  return tool.handler(
+    parsed.data,
+    markScriptSdkRequestOrigin({
+      sessionId: "app-row-tools",
+      requestInfo: { headers: id ? { "x-agent-id": id } : {} },
+    }),
+  );
+}
+
+test("creates, gets, filters, sorts, limits, patches, and deletes flat rows with agent provenance", async () => {
+  const result = await call("app-row-create", {
+    values: { title: "single", rank: 1, active: true },
+  });
+  expect(result.isError).not.toBe(true);
+  const row = result.structuredContent.row;
+  expect(row).toMatchObject({
+    title: "single",
+    rank: 1,
+    createdBy: `agent:${agentId}`,
+    updatedBy: `agent:${agentId}`,
+  });
+  expect(row.values).toBeUndefined();
+  expect((await call("app-row-get", { rowId: row.id })).structuredContent.row).toEqual(row);
+  const patched = await call("app-row-patch", { rowId: row.id, values: { title: "patched" } });
+  expect(patched.structuredContent.row).toMatchObject({
+    title: "patched",
+    createdBy: row.createdBy,
+    updatedBy: row.createdBy,
+  });
+  await call("app-rows-create", {
+    rows: [
+      { title: "bulk", rank: 2, active: true },
+      { title: "bulk", rank: 3, active: false },
+      { title: "bulk", rank: 4, active: true },
+    ],
+  });
+  const listed = await call("app-rows-list", {
+    equals: { title: "bulk", active: true },
+    sort: "rank:desc",
+    limit: 1,
+  });
+  expect(listed.structuredContent.total).toBe(2);
+  expect(listed.structuredContent.rows).toHaveLength(1);
+  expect(listed.structuredContent.rows[0].rank).toBe(4);
+  const systemFilter = await call("app-rows-list", {
+    equals: { id: row.id, createdBy: `agent:${agentId}` },
+    sort: "createdAt:asc",
+  });
+  expect(systemFilter.structuredContent.total).toBe(1);
+  expect((await call("app-row-delete", { rowId: row.id })).structuredContent).toMatchObject({
+    ok: true,
+  });
+  expect((await call("app-row-get", { rowId: row.id })).isError).toBe(true);
+  expect(
+    (await call("app-rows-delete", { equals: { title: "bulk" }, limit: 2 })).structuredContent,
+  ).toMatchObject({ deleted: 2 });
+  expect(
+    (await call("app-rows-delete", { equals: { title: "bulk" } })).structuredContent,
+  ).toMatchObject({
+    deleted: 1,
+  });
+});
+
+test("null in values clears an optional column on create, bulk create, and patch", async () => {
+  const created = await call("app-row-create", { values: { title: "null-create", rank: null } });
+  expect(created.isError).not.toBe(true);
+  expect(created.structuredContent.row.rank).toBeNull();
+  const bulk = await call("app-rows-create", {
+    rows: [{ title: "null-bulk", rank: null, state: null }],
+  });
+  expect(bulk.isError).not.toBe(true);
+  expect(bulk.structuredContent.rows[0]).toMatchObject({ rank: null, state: null });
+  const row = (await call("app-row-create", { values: { title: "null-patch", rank: 5 } }))
+    .structuredContent.row;
+  const patched = await call("app-row-patch", { rowId: row.id, values: { rank: null } });
+  expect(patched.isError).not.toBe(true);
+  expect(Object.hasOwn(patched.structuredContent.row, "rank")).toBe(false);
+  expect(
+    Object.hasOwn((await call("app-row-get", { rowId: row.id })).structuredContent.row, "rank"),
+  ).toBe(false);
+});
+
+test("app-rows-delete skips a row patched out of the filter after the select", async () => {
+  const row = (await call("app-row-create", { values: { title: "delete" } })).structuredContent.row;
+  const original = rowStore.listAppRows;
+  // The select sees the row as "delete"; the patch lands before the per-row delete lock.
+  const spy = spyOn(rowStore, "listAppRows").mockImplementation(async (...args) => {
+    const rows = await original(...args);
+    await rowStore.patchAppRow(appId, "note", definition.models.note!, row.id, { title: "keep" });
+    return rows;
+  });
+  let result: ToolResult;
+  try {
+    result = await call("app-rows-delete", { equals: { title: "delete" } });
+  } finally {
+    spy.mockRestore();
+  }
+  expect(result.isError).not.toBe(true);
+  expect(result.structuredContent.deleted).toBe(0);
+  expect((await call("app-row-get", { rowId: row.id })).structuredContent.row.title).toBe("keep");
+  await call("app-row-delete", { rowId: row.id });
+});
+
+test("rejects invalid filters, sorts, values, source projections, join keys, and missing agents", async () => {
+  for (const values of [
+    { projected: "blocked" },
+    { externalId: "blocked" },
+    { state: "invalid" },
+    { rank: "wrong" },
+    { createdBy: "forged" },
+  ]) {
+    expect((await call("app-row-create", { values })).isError).toBe(true);
+  }
+  for (const equals of [{ missing: "x" }, { active: 1 }, { rank: "1" }]) {
+    expect((await call("app-rows-list", { equals })).isError).toBe(true);
+  }
+  expect((await call("app-rows-list", { sort: "rank:sideways" })).isError).toBe(true);
+  expect((await call("app-rows-list", {}, "")).isError).toBe(true);
+});
+
+test("enforces row, bulk, filter, and limit caps before writing", async () => {
+  await expect(
+    call("app-rows-create", { rows: Array.from({ length: 501 }, () => ({ title: "too-many" })) }),
+  ).rejects.toThrow();
+  await expect(call("app-rows-create", { rows: [] })).rejects.toThrow();
+  await expect(call("app-rows-delete", {})).rejects.toThrow();
+  await expect(call("app-rows-delete", { equals: {} })).rejects.toThrow();
+  await expect(call("app-rows-list", { limit: 1001 })).rejects.toThrow();
+  const oversized = "x".repeat(1024 * 1024);
+  expect((await call("app-row-create", { values: { title: oversized } })).isError).toBe(true);
+  expect((await call("app-rows-create", { rows: [{ title: oversized }] })).isError).toBe(true);
+  expect(
+    (
+      await call("app-rows-create", {
+        rows: Array.from({ length: 20 }, () => ({ title: "x".repeat(600_000) })),
+      })
+    ).isError,
+  ).toBe(true);
+  const row = (await call("app-row-create", { values: { title: "cap-patch" } })).structuredContent
+    .row;
+  expect(
+    (await call("app-row-patch", { rowId: row.id, values: { title: oversized } })).isError,
+  ).toBe(true);
+  expect((await call("app-row-get", { rowId: row.id })).structuredContent.row.title).toBe(
+    "cap-patch",
+  );
+  expect(
+    (await call("app-rows-list", { equals: { title: "too-many" } })).structuredContent.total,
+  ).toBe(0);
+});
+
+test("denies a principal without app.use for every row operation", async () => {
+  const policy = LEGACY_POLICY as unknown as Record<"app.use", LegacyRule>;
+  const original = policy["app.use"];
+  policy["app.use"] = {
+    name: "deny-row-tools",
+    denyReason: "denied row tools",
+    evaluate: () => false,
+  };
+  try {
+    for (const [name, input] of [
+      ["app-rows-list", {}],
+      ["app-row-get", { rowId: "missing" }],
+      ["app-row-create", { values: { title: "denied" } }],
+      ["app-rows-create", { rows: [{ title: "denied" }] }],
+      ["app-row-patch", { rowId: "missing", values: { title: "denied" } }],
+      ["app-row-delete", { rowId: "missing" }],
+      ["app-rows-delete", { equals: { title: "denied" } }],
+    ] as const)
+      expect((await call(name, input)).isError).toBe(true);
+  } finally {
+    policy["app.use"] = original;
+  }
+});
+
+test("saved scripts can typecheck all seven row methods and cannot invoke actions", async () => {
+  const valid = await typecheckScript(`
+    import type { ScriptContext } from "swarm-sdk";
+    export default async function(args: unknown, ctx: ScriptContext) {
+      const base = { appId: "app", model: "note" };
+      await ctx.swarm.app_row_create({ ...base, values: { title: "test" } });
+      await ctx.swarm.app_rows_create({ ...base, rows: [{ title: "test" }] });
+      await ctx.swarm.app_rows_list({ ...base, equals: { title: "test" }, sort: "createdAt:desc", limit: 1 });
+      await ctx.swarm.app_row_get({ ...base, rowId: "row" });
+      await ctx.swarm.app_row_patch({ ...base, rowId: "row", values: { title: "changed", rank: null } });
+      await ctx.swarm.app_row_delete({ ...base, rowId: "row" });
+      await ctx.swarm.app_rows_delete({ ...base, equals: { title: "test" } });
+    }
+  `);
+  expect(valid).toEqual({ ok: true });
+  const invalid = await typecheckScript(`
+    import type { ScriptContext } from "swarm-sdk";
+    export default async function(args: unknown, ctx: ScriptContext) {
+      await ctx.swarm.app_action_run({ appId: "app", action: "write" });
+    }
+  `);
+  expect(invalid.ok).toBe(false);
+  if (!invalid.ok) expect(invalid.diagnostics.join("\n")).toContain("app_action_run");
+});
+
+test.skipIf(SKIP_SANDBOX_SPAWN_TESTS)(
+  "a saved script creates and lists rows through ctx.swarm",
+  async () => {
+    const server = createHttpServer(async (req, res) => {
+      const id = req.headers["x-agent-id"] as string | undefined;
+      if (await handleCore(req, res, id, apiKey)) return;
+      if (
+        await handleMcpBridge(
+          req,
+          res,
+          getPathSegments(req.url ?? ""),
+          parseQueryParams(req.url ?? ""),
+          id,
+        )
+      )
+        return;
+      res.writeHead(404).end();
+    });
+    try {
+      const port = await listenOnFreePort(server);
+      const script = await import("../be/scripts/db").then(({ upsertScriptByName }) =>
+        upsertScriptByName({
+          name: "row_tools_sdk",
+          scope: "agent",
+          scopeId: agentId,
+          agentId,
+          source: `export default async function(args, ctx) {
+        const created = await ctx.swarm.app_row_create({ appId: args.appId, model: "note", values: { title: "script-sdk", rank: 1 } });
+        const listed = await ctx.swarm.app_rows_list({ appId: args.appId, model: "note", equals: { title: "script-sdk" } });
+        const rowId = (created?.data ?? created).row.id;
+        const cleared = await ctx.swarm.app_row_patch({ appId: args.appId, model: "note", rowId, values: { rank: null } });
+        return { created: created?.data ?? created, listed: listed?.data ?? listed, cleared: cleared?.data ?? cleared };
+      }`,
+          description: "SDK row fixture",
+          intent: "Verify row tools through the script SDK",
+          signatureJson: "{}",
+          typeChecked: true,
+          embeddingMode: "skip",
+        }),
+      );
+      const output = await runScript({
+        source: script.script.source,
+        args: { appId },
+        agentId,
+        mcpBaseUrl: `http://localhost:${port}`,
+      });
+      expect(output.error).toBeUndefined();
+      expect(output.runtimeError).toBeUndefined();
+      expect(output.result).toMatchObject({
+        created: { row: { createdBy: `agent:${agentId}` } },
+        listed: { total: 1, rows: [{ title: "script-sdk" }] },
+        cleared: { row: { title: "script-sdk" } },
+      });
+      const cleared = (output.result as { cleared: { row: Record<string, unknown> } }).cleared.row;
+      expect(Object.hasOwn(cleared, "rank")).toBe(false);
+    } finally {
+      if (server.listening) await new Promise<void>((resolve) => server.close(() => resolve()));
+    }
+  },
+  CHILD_PROCESS_TEST_BUDGET_MS,
+);

package/src/tests/check-pr-body.test.ts

@@ -2,7 +2,6 @@ import { describe, expect, test } from "bun:test";
 import {
   checkPrBody,
   isFixTitle,
-  isRankingEntryPr,
   pickedChoices,
   prBodyWarnings,
   proseWordCount,
@@ -35,28 +34,6 @@ const TEMPLATE = `<!-- top comment -->
 
 const URGENT = "## Urgency\n- [ ] asap\n- [x] nice to have\n";
 
-describe("isRankingEntryPr", () => {
-  test("exempts only a one-file entry PR with the matching title", () => {
-    expect(
-      isRankingEntryPr("chore(ranking): add acme.dev", ["community/ranking/acme.dev.json"]),
-    ).toBe(true);
-    expect(
-      isRankingEntryPr("chore(ranking): remove acme.dev", ["community/ranking/acme.dev.json"]),
-    ).toBe(true);
-    expect(
-      isRankingEntryPr("chore(ranking): add acme.dev", ["community/ranking/acme.com.json"]),
-    ).toBe(false);
-    expect(
-      isRankingEntryPr("chore(ranking): add acme.dev", [
-        "community/ranking/acme.dev.json",
-        "src/server.ts",
-      ]),
-    ).toBe(false);
-    expect(isRankingEntryPr("feat: add acme.dev", ["community/ranking/acme.dev.json"])).toBe(false);
-    expect(isRankingEntryPr("chore(ranking): add acme.dev", undefined)).toBe(false);
-  });
-});
-
 describe("check-pr-body", () => {
   test("template markers set when a section is required", () => {
     expect(templateSections(TEMPLATE)).toEqual([

package/src/tests/credential-check.test.ts

@@ -236,6 +236,26 @@ describe("checkPiMonoCredentials", () => {
     ).toBe(false);
   });
 
+  test("strict: MODEL_OVERRIDE=opencode-go/... requires OPENCODE_API_KEY", async () => {
+    const env = { MODEL_OVERRIDE: "opencode-go/deepseek-v4.1-flash" };
+    expect(
+      (
+        await checkPiMonoCredentials(
+          { ...env, OPENCODE_API_KEY: "x" },
+          { homeDir: HOME, fs: noFiles },
+        )
+      ).ready,
+    ).toBe(true);
+    expect(
+      (
+        await checkPiMonoCredentials(
+          { ...env, ANTHROPIC_API_KEY: "x" },
+          { homeDir: HOME, fs: noFiles },
+        )
+      ).ready,
+    ).toBe(false);
+  });
+
   test("strict: MODEL_OVERRIDE=google/... accepts GEMINI_API_KEY", async () => {
     const env = {
       MODEL_OVERRIDE: "google/gemini-3-flash-preview",
@@ -1078,6 +1098,24 @@ describe("isCredCheckDisabled", () => {
 describe("buildCredStatusReport", () => {
   const HOME = "/home/worker";
 
+  test("pi reports the opencode-go ids its pi-ai resolves", async () => {
+    const snap = await buildCredStatusReport(
+      "pi",
+      { HOME },
+      { homeDir: HOME, fs: fsWith(new Set([`${HOME}/.pi/agent/auth.json`])) },
+      "boot",
+    );
+    expect(snap.opencodeGo?.models).toContain("deepseek-v4.1-flash");
+    expect(snap.opencodeGo?.models).not.toContain("deepseek-v4-flash");
+    const other = await buildCredStatusReport(
+      "opencode",
+      { HOME },
+      { homeDir: HOME, fs: fsWith(new Set([`${HOME}/.local/share/opencode/auth.json`])) },
+      "boot",
+    );
+    expect(other.opencodeGo).toBeNull();
+  });
+
   for (const [provider, authPath] of [
     ["pi", ".pi/agent/auth.json"],
     ["opencode", ".local/share/opencode/auth.json"],