@desplega.ai/agent-swarm 1.72.1 → 1.73.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@desplega.ai/agent-swarm",
-  "version": "1.72.1",
+  "version": "1.73.0",
   "description": "Multi-agent orchestration for Claude Code, Codex, Gemini CLI, and other AI coding assistants",
   "license": "MIT",
   "author": "desplega.sh <contact@desplega.sh>",

package/src/http/trackers/jira.ts

@@ -136,6 +136,11 @@ function getWebhookUrl(req: IncomingMessage): string {
 }
 
 function getRedirectUri(req: IncomingMessage): string {
+  // Mirror src/jira/app.ts: prefer the explicit JIRA_REDIRECT_URI override,
+  // otherwise derive from the API base URL. Keeps the UI display consistent
+  // with the URI persisted into oauth_apps and used in the actual OAuth flow.
+  const override = process.env.JIRA_REDIRECT_URI?.trim();
+  if (override) return override;
   return `${deriveApiBaseUrl(req)}/api/trackers/jira/callback`;
 }
 

package/src/slack/blocks.ts

@@ -5,7 +5,7 @@
  * across responses.ts, handlers.ts, thread-buffer.ts).
  */
 
-const appUrl = process.env.APP_URL || "";
+import { getAppUrl } from "../utils/constants";
 
 // Slack limits section text to 3000 chars; we use 2900 for safety
 const MAX_SECTION_LENGTH = 2900;
@@ -16,24 +16,21 @@ type SlackBlock = any;
 // --- Shared utilities ---
 
 /**
- * Get a Slack-formatted link to the task in the dashboard, or just the short ID.
+ * Get a Slack-formatted clickable link to the task in the dashboard.
+ * Always returns Slack mrkdwn link syntax (`<url|label>`) so partial task
+ * IDs are clickable in every message — falls back to the public dashboard
+ * when APP_URL is not configured.
  */
 export function getTaskLink(taskId: string): string {
   const shortId = taskId.slice(0, 8);
-  if (appUrl) {
-    return `<${appUrl}?tab=tasks&task=${taskId}&expand=true|\`${shortId}\`>`;
-  }
-  return `\`${shortId}\``;
+  return `<${getTaskUrl(taskId)}|\`${shortId}\`>`;
 }
 
 /**
  * Get a raw dashboard URL for a task (for link buttons).
  */
 export function getTaskUrl(taskId: string): string {
-  if (appUrl) {
-    return `${appUrl}?tab=tasks&task=${taskId}&expand=true`;
-  }
-  return "";
+  return `${getAppUrl()}/tasks/${taskId}`;
 }
 
 /**
@@ -214,9 +211,9 @@ export function buildProgressBlocks(opts: {
   taskId: string;
   progress: string;
 }): SlackBlock[] {
-  const shortId = opts.taskId.slice(0, 8);
+  const taskLink = getTaskLink(opts.taskId);
   return [
-    sectionBlock(`*${opts.agentName}* (\`${shortId}\`): ${opts.progress}`),
+    sectionBlock(`*${opts.agentName}* (${taskLink}): ${opts.progress}`),
     cancelActionBlock(opts.taskId),
   ];
 }

package/src/tests/slack-blocks.test.ts

@@ -44,22 +44,65 @@ describe("markdownToSlack", () => {
 });
 
 describe("getTaskLink", () => {
-  test("returns short ID when no APP_URL", () => {
-    // APP_URL is not set in test env
-    const link = getTaskLink("abcdef12-3456-7890-abcd-ef1234567890");
-    expect(link).toContain("abcdef12");
+  test("always returns a Slack hyperlink with clickable short ID", () => {
+    const taskId = "abcdef12-3456-7890-abcd-ef1234567890";
+    const link = getTaskLink(taskId);
+    // Slack mrkdwn link syntax: <url|label>
+    expect(link).toMatch(
+      /^<https?:\/\/.+\/tasks\/abcdef12-3456-7890-abcd-ef1234567890\|`abcdef12`>$/,
+    );
+    expect(link).toContain("|`abcdef12`>");
+    expect(link).toContain(taskId);
+  });
+
+  test("uses APP_URL when set", () => {
+    const original = process.env.APP_URL;
+    process.env.APP_URL = "https://my-custom-dashboard.example.com";
+    try {
+      const link = getTaskLink("abcdef12-3456-7890-abcd-ef1234567890");
+      expect(link).toContain(
+        "https://my-custom-dashboard.example.com/tasks/abcdef12-3456-7890-abcd-ef1234567890",
+      );
+    } finally {
+      if (original === undefined) delete process.env.APP_URL;
+      else process.env.APP_URL = original;
+    }
+  });
+
+  test("strips trailing slash from APP_URL", () => {
+    const original = process.env.APP_URL;
+    process.env.APP_URL = "https://dashboard.example.com/";
+    try {
+      const link = getTaskLink("abcdef12-3456-7890-abcd-ef1234567890");
+      expect(link).toContain("https://dashboard.example.com/tasks/");
+      expect(link).not.toContain("//tasks/");
+    } finally {
+      if (original === undefined) delete process.env.APP_URL;
+      else process.env.APP_URL = original;
+    }
+  });
+
+  test("falls back to public dashboard when APP_URL is unset", () => {
+    const original = process.env.APP_URL;
+    delete process.env.APP_URL;
+    try {
+      const link = getTaskLink("abcdef12-3456-7890-abcd-ef1234567890");
+      expect(link).toContain(
+        "https://app.agent-swarm.dev/tasks/abcdef12-3456-7890-abcd-ef1234567890",
+      );
+      expect(link.startsWith("<")).toBe(true);
+      expect(link.endsWith(">")).toBe(true);
+    } finally {
+      if (original !== undefined) process.env.APP_URL = original;
+    }
   });
 });
 
 describe("getTaskUrl", () => {
-  test("returns URL with task ID or empty string", () => {
+  test("always returns a non-empty URL containing the task ID", () => {
     const url = getTaskUrl("some-id");
-    // When APP_URL is set, URL contains the task ID; when not set, returns ""
-    if (url) {
-      expect(url).toContain("some-id");
-    } else {
-      expect(url).toBe("");
-    }
+    expect(url).toContain("/tasks/some-id");
+    expect(url).toMatch(/^https?:\/\//);
   });
 });
 
@@ -93,6 +136,17 @@ describe("buildCompletedBlocks", () => {
     expect(blocks[0].text.text).toContain("45s");
   });
 
+  test("partial task ID is rendered as a clickable Slack hyperlink", () => {
+    const blocks = buildCompletedBlocks({
+      agentName: "Alpha",
+      taskId: "abcdef12-3456-7890-abcd-ef1234567890",
+      body: "Done",
+    });
+    expect(blocks[0].text.text).toMatch(
+      /<https?:\/\/[^|>]+\/tasks\/abcdef12-3456-7890-abcd-ef1234567890\|`abcdef12`>/,
+    );
+  });
+
   test("splits long body into multiple sections", () => {
     const longBody = "x".repeat(6000);
     const blocks = buildCompletedBlocks({
@@ -148,7 +202,7 @@ describe("buildProgressBlocks", () => {
     });
 
     expect(blocks.length).toBe(2);
-    // Single line: *Gamma* (`aabbccdd`): Analyzing codebase...
+    // Single line: *Gamma* (<URL|`aabbccdd`>): Analyzing codebase...
     // (no ⏳ prefix — progress strings now carry their own emoji)
     expect(blocks[0].type).toBe("section");
     expect(blocks[0].text.text).not.toContain("⏳");
@@ -161,6 +215,19 @@ describe("buildProgressBlocks", () => {
     expect(blocks[1].elements[0].style).toBe("danger");
     expect(blocks[1].elements[0].confirm).toBeDefined();
   });
+
+  test("partial task ID is rendered as a clickable Slack hyperlink", () => {
+    const taskId = "aabbccdd-1234-5678-9012-abcdefabcdef";
+    const blocks = buildProgressBlocks({
+      agentName: "Gamma",
+      taskId,
+      progress: "Working...",
+    });
+    // Slack mrkdwn link syntax: <url|`shortId`>
+    expect(blocks[0].text.text).toMatch(
+      /<https?:\/\/[^|>]+\/tasks\/aabbccdd-1234-5678-9012-abcdefabcdef\|`aabbccdd`>/,
+    );
+  });
 });
 
 describe("buildAssignmentSummaryBlocks", () => {

package/src/utils/constants.ts

@@ -0,0 +1,19 @@
+/**
+ * Shared constants used across worker- and server-side code.
+ */
+
+/**
+ * Default dashboard URL used when `APP_URL` is unset. Points at the public
+ * production dashboard so links (Slack messages, approval URLs, etc.) are
+ * always renderable. Self-hosted operators should set `APP_URL` to override.
+ */
+export const DEFAULT_APP_URL = "https://app.agent-swarm.dev";
+
+/**
+ * Resolve the effective app/dashboard URL from `APP_URL` (with trailing
+ * slashes stripped), falling back to {@link DEFAULT_APP_URL}.
+ */
+export function getAppUrl(): string {
+  const raw = process.env.APP_URL?.trim();
+  return (raw || DEFAULT_APP_URL).replace(/\/+$/, "");
+}

package/src/workflows/executors/human-in-the-loop.ts

@@ -1,5 +1,6 @@
 import { z } from "zod";
 import type { ExecutorMeta } from "../../types";
+import { getAppUrl } from "../../utils/constants";
 import type { ExecutorResult } from "./base";
 import { BaseExecutor } from "./base";
 
@@ -173,7 +174,7 @@ export class HumanInTheLoopExecutor extends BaseExecutor<
   ): Promise<void> {
     if (!config.notifications?.length) return;
 
-    const approvalUrl = `https://app.agent-swarm.dev/approval-requests/${requestId}`;
+    const approvalUrl = `${getAppUrl()}/approval-requests/${requestId}`;
     const updatedChannels = [...config.notifications] as Array<
       z.infer<typeof NotificationConfigSchema> & { messageTs?: string }
     >;