@deslop/coding-standards 0.1.804 → 0.1.843

package/dist/install.js

@@ -24685,7 +24685,7 @@ const runWith = (command, config) => {
 };
 //#endregion
 //#region package.json
-var version = "0.1.804";
+var version = "0.1.843";
 //#endregion
 //#region src/install.ts
 const cli = pipe(make("deslop-coding-standards", {}, fnUntraced(function* () {

package/dist/oxlint.d.ts

@@ -4511,6 +4511,11 @@ export declare const oxlint: {
       disallowArithmeticOperators: true;
     }];
     'no-unused-expressions': "error";
+    'no-unused-vars': ["error", {
+      argsIgnorePattern: string;
+      ignoreRestSiblings: true;
+      reportUsedIgnorePattern: true;
+    }];
     'no-useless-assignment': "error";
     'no-useless-backreference': "error";
     'no-useless-call': "error";

package/dist/oxlint.js

@@ -3043,6 +3043,11 @@ const oxlint = defineConfig({
 		"no-unsafe-finally": "error",
 		"no-unsafe-optional-chaining": ["error", { disallowArithmeticOperators: true }],
 		"no-unused-expressions": "error",
+		"no-unused-vars": ["error", {
+			argsIgnorePattern: "^_",
+			ignoreRestSiblings: true,
+			reportUsedIgnorePattern: true
+		}],
 		"no-useless-assignment": "error",
 		"no-useless-backreference": "error",
 		"no-useless-call": "error",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deslop/coding-standards",
-  "version": "0.1.804",
+  "version": "0.1.843",
   "repository": {
     "type": "git",
     "url": "https://github.com/MP281X/deslop",

package/skills/design/SKILL.md

@@ -33,6 +33,8 @@ Do not remove necessary names, status, comfortable hit targets or instructions m
 
 ## Build
 
+These rules apply to product UI. A rendered explanation follows the host's rendering contract and the rules below.
+
 **Canonical components.** Reuse the existing renderer, states and interactions for the same role. Inspect its relevant source/API, not a full catalogue; add missing primitives through the repository registry command. Fix wrong shared patterns at their owner when delivering retained code, not before an exploratory preview. Without a sibling, use the supplied reference and component defaults within settled preferences.
 
 ```tsx
@@ -73,8 +75,7 @@ Do not remove necessary names, status, comfortable hit targets or instructions m
 | Accents/tall scripts clip          | Tight line height or text-box clipping        | Fix the owning type-scale/overflow choice; don't shrink the font to fit                            |
 | Missing metadata leaves separators | Empty optional slots still render             | Omit orphaned separators/lines; reserve space only when the layout needs it                        |
 
-**Interaction and state.** Controls remain discoverable, never hover-only. Use the canonical selected-row/active-tab treatment; do not add a second badge or check column that echoes it. Keep pending/error feedback beside its owner and preserve recoverable input. No redundant refresh, copied state or polling shortcut around the existing reactive integration.
-
+**Prevent before rejecting.** When the app already knows an action is not allowed, such as a missing permission, a referenced record or invalid input, disable or hide the control and show the reason beside it. Never let the user act and then show an error the app could have predicted.\n
 **Motion.** Explain change without delaying input or moving content just for decoration. Reuse existing tokens/components; no new library for a fade or universal curve, duration, bounce or press scale.
 
 | Interaction                            | Treatment                                                                                          |
@@ -108,10 +109,52 @@ Touch and mouse can coexist; do not infer capabilities from user-agent strings o
 
 **Inspect retained UI.** Open actual captures at the sizes needed for the task. Compare related edges, columns, baselines and equivalent controls across rows/screens—not just successful clicks. Use realistic long names/URLs, translated labels, Unicode, missing fields and relevant 0/1/many records at the actual container width. Respect schema/API limits; never add a validation limit to make layout pass. Mix cases across rows. Check selected/focus/error states and scrolling; a clean default row can hide misalignment. Inspect hierarchy, density, legibility and clipping. Exercise the relevant keyboard/touch, narrow/wide, zoom and focus-return journeys; run axe where applicable. A clean scan does not prove contrast or usability. Inspect meaningful video frames and sequence; a playable file is not proof of a good composition. Batch relevant inspection/repairs; recheck affected views rather than restart a whole audit after each micro-edit. Visible misalignment, inconsistent controls or redundant elements remain defects even when types/tests pass; fix them before claiming acceptance.
 
-**Show the design.** Use inspected screenshots for layout and short video for behavior. Compare at consistent sizes with states needed for the decision; no variant switcher just to see the options. A visual must add spatial or interactive information, not reproduce prose, a file list or a fake runtime screenshot. Link useful existing evidence rather than render another explanation page. Use the user's theme and verify the actual browser color preference. Preserve useful media and retire settled attempts; persistent previews are opt-in.
+**Show the design.** Use inspected screenshots for layout and short video for behavior. Compare at consistent sizes with states needed for the decision; no variant switcher just to see the options. A visual must add spatial or interactive information, not reproduce prose, a file list or a fake runtime screenshot. Link useful existing evidence rather than render another explanation page. For diagrams, review pages and rendered answers, follow Visual explanations below. Use the user's theme and verify the actual browser color preference. Preserve useful media and retire settled attempts; persistent previews are opt-in.
 
 **Review surfaces.** Open on the outcome the user needs to judge, with technical detail available on demand. Group by changed behavior, not files or agent stages. A selected example, diagram or diff must reveal its scope; never make curated evidence look like complete coverage. Do not build a custom review dashboard when existing captures and the PR can answer the question. A design-skill edit is not a product-screen change.
 
+## Visual explanations
+
+These rules cover diagrams, review pages and rendered agent answers. A visual earns its place only when it shows what text or a table cannot: space, flow, time, a visible comparison or a measurement.
+
+**Pick the exhibit from the question.**
+
+| The reader asks                      | Exhibit                                                        |
+| ------------------------------------ | -------------------------------------------------------------- |
+| What changed on screen?              | Before and after pair with the same data, the old state left   |
+| Which transitions are allowed?       | State machine with forbidden edges marked                      |
+| What happens in order, and who acts? | Sequence in swimlanes, one lane per actor                      |
+| Where did the time go?               | Timeline with bars on one time axis                            |
+| How much faster, bigger or cheaper?  | Bars on a shared axis, values printed on the bars              |
+| Where exactly is the defect?         | Annotated capture with numbered markers and short notes        |
+| Which requirement has which proof?   | Coverage grid of requirements against proof, colored by state  |
+| Where does the change live?          | Change map: a tree with sizes, added and removed parts colored |
+| How do the parts relate?             | Node and link map with few, labeled links                      |
+| Which option is better?              | Options side by side at the same size and with the same data   |
+| What will a video show?              | Storyboard of chapter frames, the outcome frame marked         |
+
+When none fits, choose the form that matches the data's shape, not the first card layout that comes to mind. Draw a list as a list.
+
+- **One message.** Each page answers one question. Its title states the conclusion, such as "The catalog loads 26 times faster", not the topic.
+- **One dominant element.** Size, weight and position show importance. Mute the context and make secondary detail smaller.
+- **Color means something.** Use the theme's status colors only for states and the chart colors only for series. Keep one accent, and never color for decoration.
+- **Label directly.** Put names and values on the data instead of a distant legend. Show units, and use one scale per comparison.
+- **Real content.** Use real names, numbers and captures. Show the scope, so a sample never looks like full coverage.
+
+- **Grid and rhythm.** Align to one grid. Use a spacing scale of 4, 8, 12 and 16 pixels, two or three type sizes, and one corner radius.
+- **Little text.** Labels and captions stay under twelve words. A visual holds no paragraphs.
+- **Small multiples.** Compare several cases with repeated small exhibits on the same scale, rather than one crowded chart.
+- **Both themes and widths.** Use the host's theme variables, check light and dark, and keep the page readable at phone width.
+- **Inspect before showing.** Look at the rendered page for clipping, overlap, contrast and empty areas, and fix them first.
+
+**Avoid** these:
+
+- A table or bullet list redrawn as styled boxes.
+- A card, badge or icon for every fact.
+- Gradients, shadows and illustrations that carry no information.
+- Crossing links, when an ordered list or lanes would show the same relation.
+- A visual that repeats the text around it.
+
 ## Image assets
 
 Use image generation only for a needed illustrative asset, atmosphere, texture or icon exploration—not ordinary text, exact diagrams or fake working UI. Use the native tool exposed by the harness; no invented invocation or replacement API client when unavailable. Report missing capability honestly.

package/skills/engineering/SKILL.md

@@ -11,7 +11,7 @@ description: 'TypeScript and Effect code conventions paired with shared lint. Us
 
 ## Simplicity
 
-**Clarity.** Plain, explicit, idiomatic code, names and files; read top to bottom without commentary or cleverness.
+**Clarity.** Plain, explicit, idiomatic code, names and files; read top to bottom without commentary or cleverness. Match the surrounding code's naming, idiom and comment density.
 
 **Experiments.** Write with these idioms; reserve the full refactor/cleanup pass for retained delivery. Keep disposable source isolated and shared rules intact.
 
@@ -54,7 +54,7 @@ Math.floor(Duration.toDays(DateTime.distance(oldest.timestamp, newest.timestamp)
 import {glob} from 'glob' // a dependency Effect's FileSystem replaces
 ```
 
-**Whole values.** Pass whole values or spread them. No parameter/callback/loop destructuring except labeled tuple parameters, useState and component ref; project fields only to exclude data the recipient must not receive.
+**Whole values.** Pass whole values or spread them. No parameter/callback/loop destructuring except labeled tuple parameters, useState and component ref; project fields only to exclude data the recipient must not receive. Name the whole value by its role; a leading underscore marks only a parameter the body never reads, and no name gains an underscore or a number to dodge shadowing.
 
 ```ts
 // good
@@ -62,11 +62,13 @@ server => ({server: {...server, forwardConsole: true, warmup}})
 for (const schema of schemas) report(schema.name)
 Record.map(groups, entries => entries.length)
 upload({scope: input.scope, type: input.type}) // input also holds the bearer token
+submission => onSubmit(submission.value)
 // bad
 ({host, port}) => ({server: {forwardConsole: true, host, port, warmup}})
 server: {forwardConsole: true, host: config.host, port: config.port, warmup}
 for (const {name} of schemas) report(name)
 Array.map(Record.toEntries(groups), ([key, entries]) => entries.length)
+_input => onSubmit(_input.value) // or input2: an outer input is shadowed
 ```
 
 **Nearest sibling.** Extend the nearest implementation; match permissions, errors, refresh and tests. Reuse its helpers and change only affected state.
@@ -294,7 +296,7 @@ export const EntryKind = Schema.Literals(['income', 'expense']) // no importer
 // oxlint-disable-next-line typescript/consistent-type-assertions
 // oxlint-disable-next-line sort-keys -- keeps the printed order
 // bad
-files: ['packages/components/src/components/agent-browser.tsx', 'packages/components/src/components/form.tsx'],
+files: ['packages/components/src/components/dev-tools.tsx', 'packages/components/src/components/form.tsx'],
 ```
 
 ## Effect

package/skills/testing/SKILL.md

@@ -58,8 +58,9 @@ assert.strictEqual(Array.flatMap(attioProvider.groups, group => group.actions).l
 
 ## Run and reconcile
 
-- **Run.** Use root check/fix commands and documented test selectors; confirm intended collection/execution. Zero tests/setup-only/exit0 alone is not proof; no invented final suite.
+- **Run.** Use the repository's check commands scoped to the affected packages, fix commands scoped to the files the change touches, and documented test selectors; confirm intended collection/execution. Zero tests/setup-only/exit0 alone is not proof; no invented final suite.
 - **Inventory.** Collect independent failures once instead of cancelling the suite at the first failure. Distinguish separate cases from repeated observations. A timeout receives one isolated rerun of that same test; after a genuine pass, stop investigating it. Do not call a bypassed selector or a skipped operation flaky.
 - **Evidence.** Preserve the first failure, exact command, execution count and exit status. Separate cause from hypothesis, product defect from setup failure, and a skipped criterion from a passing one. A source read or overall green command never substitutes for a missing behavior check.
 - **Stable inputs.** No writer changes a running check's source, dependencies, configuration or build inputs. A relevant edit invalidates its prior result; rerun affected criteria and reuse unaffected evidence. Independent research or browser journeys may continue without mutating those inputs.
-- **Final proof.** Reconcile every required behavior on the final code. Screenshots/video prove visible outcomes; public-seam execution proves nonvisual behavior; use fresh agents for changed instructions only when they can settle a consequential unresolved uncertainty, not routine wording edits. Keep the result and useful evidence, not disposable drivers, fixture installs, reports or preview services.
+- **Final proof.** Reconcile every required behavior on the final code. Screenshots/video prove visible outcomes; public-seam execution proves nonvisual behavior; use fresh agents for changed instructions only when they can settle a consequential unresolved uncertainty, not routine wording edits. Keep the result and useful evidence, not disposable drivers, fixture installs, reports or unrequested preview services.
+- **Visual proof.** A capture proves one claim and ends on its outcome, held long enough to read: the run, the file or the rejection. Seed data first, and keep loading states off camera unless loading is the claim. Show realistic journeys end to end, cropped to the element at a readable scale; speed up waits instead of cutting steps. A capture is stale once any component it shows changes.