@deslop/coding-standards 0.1.1243 → 0.1.1245

package/README.md

@@ -1,6 +1,6 @@
 # @deslop/coding-standards
 
-A Vite+ lint preset, a strict TypeScript configuration with Effect diagnostics, and the `lint-companion`, `pull-requests` and `review` skills for Claude Code and Codex.
+A Vite+ lint preset that runs the Effect rules and TypeScript diagnostics in Oxlint on tsrs, a strict TypeScript configuration, and the `lint-companion`, `pull-requests` and `review` skills for Claude Code and Codex.
 
 ```bash
 vpx @deslop/coding-standards@latest                                  # installs the skills
@@ -20,13 +20,14 @@ export default defineConfig({lint: {extends: [lint]}})
 // package.json
 {
 	"scripts": {
-		"prepare": "effect-tsgo patch --no-typescript --tsrs",
-		"typecheck": "tsrs --checkerAssignment go --pretty false",
-		"check": "vp check && vp run typecheck"
+		"prepare": "effect-tsgo patch --no-typescript --tsrs --oxlint",
+		"check": "effect-tsgo --tsrs-lint vp lint --type-aware --type-check"
 	}
 }
 ```
 
+The preset leaves type-aware lint and type checking off, so a syntax-only pass stays possible; the two flags turn them on, and `--tsrs-lint` runs them on tsrs instead of Oxlint's tsgolint backend.
+
 ```jsonc
 // tsconfig.json
 {"extends": "@deslop/coding-standards/tsconfig.json"}

package/dist/install.js

@@ -27604,7 +27604,7 @@ const runWith = (command, config) => {
 	}, ({ error, userMessage }) => andThen(showUserError(error, userMessage), fail$3(error))), catchFilter((e) => isQuitError(e) ? succeed$6(e) : fail$8(e), (_) => interrupt$1));
 };
 // package.json
-var version = "0.1.1243";
+var version = "0.1.1245";
 // src/install.ts
 const cli = pipe(make("deslop-coding-standards", {}, fnUntraced(function* () {
 	const fs = yield* FileSystem;

package/dist/lint.js

@@ -2929,7 +2929,7 @@ const noPipeMethod = defineRule({
 			});
 			return;
 		}
-		if (call.parent?.type === "MemberExpression" && isNotNullish(call.parent.parent) && pipeCall(call.parent.parent)) {
+		if (call.parent.type === "MemberExpression" && isNotNullish(call.parent.parent) && pipeCall(call.parent.parent)) {
 			context.report({
 				message: MESSAGE$5,
 				node
@@ -4146,12 +4146,7 @@ function skips(context, node) {
 			context,
 			node: chain.root,
 			source: TEST_RUNNERS
-		}) || !contains([
-			"describe",
-			"it",
-			"suite",
-			"test"
-		], chain.root.name) || hasEffectMember(chain.members));
+		}) || hasEffectMember(chain.members));
 	}));
 }
 const noSkippedTest = defineRule({
@@ -5299,12 +5294,15 @@ const lint = {
 		{
 			files: ["**/*.tsx"],
 			rules: {
+				"effecttsgo/async-function": "off",
 				"eslint/require-await": "error",
+				"typescript/strict-void-return": "off",
 				"unicorn/no-null": "off"
 			}
 		}
 	],
 	plugins: [
+		"effecttsgo",
 		"eslint",
 		"typescript",
 		"oxc",
@@ -5316,6 +5314,123 @@ const lint = {
 	],
 	rules: {
 		...mapEntries(RULES, (_, name) => [`@deslop/coding-standards/${name}`, "error"]),
+		"effecttsgo/any-unknown-in-error-context": "error",
+		"effecttsgo/class-self-mismatch": "error",
+		"effecttsgo/duplicate-package": "error",
+		"effecttsgo/effect-fn-implicit-any": "error",
+		"effecttsgo/error-payload-shadows-name": "error",
+		"effecttsgo/floating-effect": "error",
+		"effecttsgo/floating-effect-in-vitest": "error",
+		"effecttsgo/missing-effect-context": "error",
+		"effecttsgo/missing-effect-error": "error",
+		"effecttsgo/missing-layer-context": "error",
+		"effecttsgo/missing-return-yield-star": "error",
+		"effecttsgo/missing-star-in-yield-effect-gen": "error",
+		"effecttsgo/obsolete-match-import": "error",
+		"effecttsgo/obsolete-schema-import": "error",
+		"effecttsgo/outdated-api": "error",
+		"effecttsgo/overridden-schema-constructor": "error",
+		"effecttsgo/promise-in-effect-success": "error",
+		"effecttsgo/schema-class-object-literal": "error",
+		"effecttsgo/schema-literal-non-finite": "error",
+		"effecttsgo/unsafe-effect-type-assertion": "error",
+		"effecttsgo/catch-unfailable-effect": "error",
+		"effecttsgo/effect-fn-iife": "error",
+		"effecttsgo/effect-gen-uses-adapter": "error",
+		"effecttsgo/effect-in-failure": "error",
+		"effecttsgo/effect-in-void-success": "error",
+		"effecttsgo/effect-try-without-catch": "error",
+		"effecttsgo/global-error-in-effect-catch": "error",
+		"effecttsgo/global-error-in-effect-failure": "error",
+		"effecttsgo/layer-merge-all-with-dependencies": "error",
+		"effecttsgo/lazy-effect": "error",
+		"effecttsgo/lazy-promise-in-effect-sync": "error",
+		"effecttsgo/leaking-requirements": "error",
+		"effecttsgo/multiple-effect-provide": "error",
+		"effecttsgo/return-effect-in-gen": "error",
+		"effecttsgo/schema-sync-in-effect": "error",
+		"effecttsgo/strict-effect-provide": "error",
+		"effecttsgo/try-catch-in-effect-gen": "error",
+		"effecttsgo/async-function": "error",
+		"effecttsgo/global-console": "error",
+		"effecttsgo/global-console-in-effect": "error",
+		"effecttsgo/global-date": "error",
+		"effecttsgo/global-date-in-effect": "error",
+		"effecttsgo/global-fetch": "error",
+		"effecttsgo/global-fetch-in-effect": "error",
+		"effecttsgo/global-json": "error",
+		"effecttsgo/global-json-in-effect": "error",
+		"effecttsgo/global-random": "error",
+		"effecttsgo/global-random-in-effect": "error",
+		"effecttsgo/global-timers": "error",
+		"effecttsgo/global-timers-in-effect": "error",
+		"effecttsgo/instance-of-schema": "error",
+		"effecttsgo/node-builtin-import": "error",
+		"effecttsgo/prefer-effect-array": "error",
+		"effecttsgo/prefer-effect-record": "error",
+		"effecttsgo/prefer-effect-string": "error",
+		"effecttsgo/process-env": "error",
+		"effecttsgo/process-env-in-effect": "error",
+		"effecttsgo/acquire-release-disposable": "error",
+		"effecttsgo/all-of-map-to-for-each": "error",
+		"effecttsgo/catch-all-tag-dispatch-to-catch-tag": "error",
+		"effecttsgo/catch-all-to-map-error": "error",
+		"effecttsgo/catch-chain-to-first-success-of": "error",
+		"effecttsgo/catch-conditional-refail-to-catch-if": "error",
+		"effecttsgo/catch-if-tag-to-catch-tag": "error",
+		"effecttsgo/catch-refail-to-tap-error": "error",
+		"effecttsgo/catch-tag-to-catch-reason": "error",
+		"effecttsgo/catch-to-or-else-succeed": "error",
+		"effecttsgo/deterministic-keys": "error",
+		"effecttsgo/effect-do-notation": "error",
+		"effecttsgo/effect-fn-opportunity": "error",
+		"effecttsgo/effect-map-flatten": "error",
+		"effecttsgo/effect-map-void": "error",
+		"effecttsgo/effect-sleep-zero-to-yield-now": "error",
+		"effecttsgo/effect-succeed-with-undefined": "error",
+		"effecttsgo/effect-succeed-with-void": "error",
+		"effecttsgo/fail-cause-to-constructor": "error",
+		"effecttsgo/flat-map-conditional-to-filter-or-fail": "error",
+		"effecttsgo/flat-map-identity-to-flatten": "error",
+		"effecttsgo/flat-map-ignored-param-to-and-then": "error",
+		"effecttsgo/flat-map-to-map": "error",
+		"effecttsgo/flat-map-to-tap": "error",
+		"effecttsgo/manual-metric-tap-to-track": "error",
+		"effecttsgo/map-const-to-as": "error",
+		"effecttsgo/map-map-error-to-map-both": "error",
+		"effecttsgo/map-some-catch-no-such-element": "error",
+		"effecttsgo/map-some-to-as-some": "error",
+		"effecttsgo/match-boolean-to-is-success": "error",
+		"effecttsgo/match-effect-to-map-both": "error",
+		"effecttsgo/match-effect-to-match": "error",
+		"effecttsgo/match-to-result-or-option": "error",
+		"effecttsgo/multiple-catch-tag": "error",
+		"effecttsgo/nested-effect-gen-yield": "error",
+		"effecttsgo/new-schema-class": "error",
+		"effecttsgo/option-match-to-from-option": "error",
+		"effecttsgo/prefer-schema-type-property": "error",
+		"effecttsgo/prefer-succeed-some-or-none": "error",
+		"effecttsgo/prefer-typed-schema-decoder": "error",
+		"effecttsgo/provide-layer-succeed-to-provide-service": "error",
+		"effecttsgo/provide-merge-all-to-array": "error",
+		"effecttsgo/race-first-with-sleep-to-timeout": "error",
+		"effecttsgo/redundant-map-error": "error",
+		"effecttsgo/redundant-or-die": "error",
+		"effecttsgo/redundant-schema-tag-identifier": "error",
+		"effecttsgo/result-match-to-from-result": "error",
+		"effecttsgo/run-of-exit-to-run-exit": "error",
+		"effecttsgo/schema-number": "error",
+		"effecttsgo/schema-struct-with-tag": "error",
+		"effecttsgo/service-not-as-class": "error",
+		"effecttsgo/suspend-fail-to-fail-sync": "error",
+		"effecttsgo/sync-to-succeed": "error",
+		"effecttsgo/timeout-catch-tag-to-timeout-or-else": "error",
+		"effecttsgo/type-union-to-schema-union": "error",
+		"effecttsgo/unnecessary-effect-gen": "error",
+		"effecttsgo/unnecessary-fail-yieldable-error": "error",
+		"effecttsgo/unnecessary-pipe": "error",
+		"effecttsgo/unnecessary-pipe-chain": "error",
+		"effecttsgo/unnecessary-typeof-type": "error",
 		"eslint/arrow-body-style": ["error", "as-needed"],
 		"eslint/constructor-super": "error",
 		"eslint/curly": [
@@ -5736,7 +5851,6 @@ const lint = {
 		"eslint/no-with": "error",
 		"eslint/object-shorthand": "error",
 		"eslint/prefer-arrow-callback": "error",
-		"eslint/prefer-const": ["error", { destructuring: "all" }],
 		"eslint/prefer-template": "error",
 		"eslint/preserve-caught-error": "error",
 		"eslint/require-yield": "error",
@@ -5948,7 +6062,7 @@ const lint = {
 		"typescript/no-explicit-any": "error",
 		"typescript/no-extraneous-class": "error",
 		"typescript/no-import-type-side-effects": "error",
-		"typescript/no-inferrable-types": "error",
+		"typescript/no-inferrable-types": ["error", { ignoreParameters: true }],
 		"typescript/no-misused-new": "error",
 		"typescript/no-namespace": ["error", { allowDeclarations: true }],
 		"typescript/no-non-null-assertion": "error",
@@ -5975,6 +6089,47 @@ const lint = {
 		"typescript/prefer-function-type": "error",
 		"typescript/triple-slash-reference": "error",
 		"typescript/unified-signatures": "error",
+		"typescript/await-thenable": "error",
+		"typescript/consistent-type-exports": "error",
+		"typescript/dot-notation": "error",
+		"typescript/no-array-delete": "error",
+		"typescript/no-base-to-string": "error",
+		"typescript/no-confusing-void-expression": ["error", { ignoreVoidReturningFunctions: true }],
+		"typescript/no-deprecated": "error",
+		"typescript/no-duplicate-type-constituents": "error",
+		"typescript/no-floating-promises": "error",
+		"typescript/no-for-in-array": "error",
+		"typescript/no-generated-empty-object-type": "error",
+		"typescript/no-misused-promises": ["error", { checksVoidReturn: { attributes: false } }],
+		"typescript/no-misused-spread": "error",
+		"typescript/no-redundant-type-constituents": "error",
+		"typescript/no-unnecessary-boolean-literal-compare": "error",
+		"typescript/no-unnecessary-condition": "error",
+		"typescript/no-unnecessary-qualifier": "error",
+		"typescript/no-unnecessary-template-expression": "error",
+		"typescript/no-unnecessary-type-arguments": "error",
+		"typescript/no-unnecessary-type-assertion": "error",
+		"typescript/no-unnecessary-type-conversion": "error",
+		"typescript/no-unnecessary-type-parameters": "error",
+		"typescript/no-unsafe-argument": "error",
+		"typescript/no-unsafe-assignment": "error",
+		"typescript/no-unsafe-call": "error",
+		"typescript/no-unsafe-member-access": "error",
+		"typescript/no-unsafe-return": "error",
+		"typescript/no-unsafe-unary-minus": "error",
+		"typescript/no-useless-default-assignment": "error",
+		"typescript/prefer-nullish-coalescing": ["error", { ignoreTernaryTests: true }],
+		"typescript/prefer-optional-chain": "error",
+		"typescript/restrict-plus-operands": "error",
+		"typescript/restrict-template-expressions": "error",
+		"typescript/strict-boolean-expressions": ["error", {
+			allowNullableObject: false,
+			allowNullableString: true,
+			allowNumber: false,
+			allowString: true
+		}],
+		"typescript/strict-void-return": "error",
+		"typescript/unbound-method": "error",
 		"unicorn/consistent-function-scoping": "error",
 		"unicorn/filename-case": "error",
 		"unicorn/no-abusive-eslint-disable": "error",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deslop/coding-standards",
-  "version": "0.1.1243",
+  "version": "0.1.1245",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/MP281X/deslop.git",
@@ -36,11 +36,11 @@
     "oxlint-plugin-react-doctor": "latest"
   },
   "peerDependencies": {
+    "@effect/tsgo": ">=0.67",
     "vite-plus": "^1.3"
   },
   "scripts": {
     "build": "vp pack",
-    "test": "vp test --config ../../vite.config.ts",
-    "typecheck": "tsrs --checkerAssignment go --pretty false"
+    "test": "vp test --config ../../vite.config.ts"
   }
 }

package/tsconfig.json

@@ -24,190 +24,6 @@
 		"noUncheckedSideEffectImports": true,
 		"noEmit": true,
 		"incremental": false,
-		"plugins": [
-			{
-				"name": "@effect/language-service",
-				"effectFn": ["span", "untraced"],
-				"diagnosticSeverity": {
-					"abortControllerInEffect": "off",
-					"acquireReleaseDisposable": "error",
-					"allOfMapToForEach": "error",
-					"anyUnknownInErrorContext": "error",
-					"apiStabilityLeak": "off",
-					"asyncFunction": "error",
-					"catchAllTagDispatchToCatchTag": "error",
-					"catchAllToMapError": "error",
-					"catchChainToFirstSuccessOf": "error",
-					"catchConditionalRefailToCatchIf": "error",
-					"catchDieToOrDie": "off",
-					"catchIfTagToCatchTag": "error",
-					"catchRefailToTapError": "error",
-					"catchTagToCatchReason": "error",
-					"catchToIgnore": "off",
-					"catchToOrElseSucceed": "error",
-					"catchUnfailableEffect": "error",
-					"classSelfMismatch": "error",
-					"cryptoRandomUUID": "off",
-					"cryptoRandomUUIDInEffect": "off",
-					"deterministicKeys": "error",
-					"duplicatePackage": "error",
-					"effectDoNotation": "error",
-					"effectFnIife": "error",
-					"effectFnImplicitAny": "error",
-					"effectFnOpportunity": "error",
-					"effectGenUsesAdapter": "error",
-					"effectInFailure": "error",
-					"effectInVoidSuccess": "error",
-					"effectMapFlatten": "error",
-					"effectMapVoid": "error",
-					"effectSleepZeroToYieldNow": "error",
-					"effectSucceedWithUndefined": "error",
-					"effectSucceedWithVoid": "error",
-					"effectTryWithoutCatch": "error",
-					"errorPayloadShadowsName": "error",
-					"experimentalApiUsage": "off",
-					"extendsNativeError": "off",
-					"failCauseToConstructor": "error",
-					"flatMapConditionalToFilterOrFail": "error",
-					"flatMapIdentityToFlatten": "error",
-					"flatMapIgnoredParamToAndThen": "error",
-					"flatMapToMap": "error",
-					"flatMapToTap": "error",
-					"floatingEffect": "error",
-					"floatingEffectInVitest": "error",
-					"globalConsole": "error",
-					"globalConsoleInEffect": "error",
-					"globalDate": "error",
-					"globalDateInEffect": "error",
-					"globalErrorInEffectCatch": "error",
-					"globalErrorInEffectFailure": "error",
-					"globalFetch": "error",
-					"globalFetchInEffect": "error",
-					"globalJson": "error",
-					"globalJsonInEffect": "error",
-					"globalRandom": "error",
-					"globalRandomInEffect": "error",
-					"globalTimers": "error",
-					"globalTimersInEffect": "error",
-					"instanceOfSchema": "error",
-					"layerMergeAllWithDependencies": "error",
-					"lazyEffect": "error",
-					"lazyPromiseInEffectSync": "error",
-					"leakingRequirements": "error",
-					"manualMetricTapToTrack": "error",
-					"mapConstToAs": "error",
-					"mapMapErrorToMapBoth": "error",
-					"mapSomeCatchNoSuchElement": "error",
-					"mapSomeToAsSome": "error",
-					"matchBooleanToIsSuccess": "error",
-					"matchEffectToMapBoth": "error",
-					"matchEffectToMatch": "error",
-					"missedPipeableOpportunity": "off",
-					"missingEffectContext": "error",
-					"missingEffectError": "error",
-					"missingLayerContext": "error",
-					"missingPipeableSignature": "off",
-					"missingReturnYieldStar": "error",
-					"missingStarInYieldEffectGen": "error",
-					"multipleCatchTag": "error",
-					"multipleEffectProvide": "error",
-					"nestedEffectGenYield": "error",
-					"newPromise": "off",
-					"newSchemaClass": "error",
-					"nodeBuiltinImport": "error",
-					"obsoleteMatchImport": "error",
-					"obsoleteSchemaImport": "error",
-					"optionMatchToFromOption": "error",
-					"outdatedApi": "error",
-					"overriddenSchemaConstructor": "error",
-					"preferBarrelImport": "off",
-					"preferEffectArray": "error",
-					"preferEffectRecord": "error",
-					"preferEffectString": "error",
-					"preferNamespaceImport": "off",
-					"preferSchemaTaggedError": "off",
-					"preferSchemaTypeProperty": "error",
-					"preferSucceedSomeOrNone": "error",
-					"preferTypedSchemaDecoder": "error",
-					"preferUnsafeConstructor": "off",
-					"processEnv": "error",
-					"processEnvInEffect": "error",
-					"promiseInEffectSuccess": "error",
-					"provideLayerSucceedToProvideService": "error",
-					"provideMergeAllToArray": "error",
-					"raceFirstWithSleepToTimeout": "error",
-					"redundantMapError": "error",
-					"redundantOrDie": "error",
-					"redundantSchemaTagIdentifier": "error",
-					"resultMatchToFromResult": "error",
-					"returnEffectInGen": "error",
-					"runEffectInsideEffect": "off",
-					"runOfExitToRunExit": "error",
-					"schemaClassMissingBrand": "off",
-					"schemaClassObjectLiteral": "error",
-					"schemaLiteralNonFinite": "error",
-					"schemaNumber": "error",
-					"schemaOpaqueInstanceMember": "off",
-					"schemaStructWithTag": "error",
-					"schemaSync": "off",
-					"schemaSyncInEffect": "error",
-					"serviceNotAsClass": "error",
-					"strictBooleanExpressions": "error",
-					"strictEffectProvide": "error",
-					"suspendFailToFailSync": "error",
-					"syncToSucceed": "error",
-					"timeoutCatchTagToTimeoutOrElse": "error",
-					"tryCatchInEffectGen": "error",
-					"typeUnionToSchemaUnion": "error",
-					"unknownInEffectCatch": "off",
-					"unnecessaryArrowBlock": "off",
-					"unnecessaryEffectGen": "error",
-					"unnecessaryFailYieldableError": "error",
-					"unnecessaryPipe": "error",
-					"unnecessaryPipeChain": "error",
-					"unnecessaryTypeofType": "error",
-					"unsafeEffectTypeAssertion": "error",
-					"unstableApiUsage": "off",
-					"unusedDirective": "error",
-					// no-single-use-value inlines a single-use yield into its call instead.
-					"yieldInCallArgument": "off"
-				},
-				"ignoreEffectErrorsInTscExitCode": false,
-				"ignoreEffectWarningsInTscExitCode": false,
-				"ignoreEffectSuggestionsInTscExitCode": false,
-				"overrides": [
-					{
-						// Absolute globs survive extends; the explicit dot component also covers hidden worktrees.
-						"include": ["/**/*.tsx", "/**/.*/**/*.tsx"],
-						"options": {"diagnosticSeverity": {"asyncFunction": "off"}}
-					},
-					{
-						// shadcn's components stay exactly what its CLI writes, so Effect's style checks do not apply to them.
-						"include": [
-							"/**/components-web/src/ui/**/*.ts",
-							"/**/components-web/src/ui/**/*.tsx",
-							"/**/.*/**/components-web/src/ui/**/*.ts",
-							"/**/.*/**/components-web/src/ui/**/*.tsx"
-						],
-						"options": {
-							"diagnosticSeverity": {
-								"globalRandom": "off",
-								"globalTimers": "off",
-								"preferEffectArray": "off",
-								"preferEffectRecord": "off",
-								"preferEffectString": "off",
-								"strictBooleanExpressions": "off"
-							}
-						}
-					},
-					{
-						// The directive scan reads string literals too, and test fixtures hold source text with directives.
-						"include": ["/**/*.test.ts", "/**/.*/**/*.test.ts"],
-						"options": {"diagnosticSeverity": {"unusedDirective": "off"}}
-					}
-				]
-			}
-		],
 		"noUnusedLocals": true,
 		"noUnusedParameters": true
 	},