@desklink/host 0.5.2 → 0.5.4

package/docs/BOUNDARY.md

@@ -141,7 +141,10 @@ address, port, code or certificate reaches the user, and the engine's session is
 started by the host that already serves the terminal. A consumer with no channel
 of its own is not left to invent one — `desklink-host bridge` re-serves the same
 protocol over a WebSocket and serves a reference client that needs no build step,
-so a stranger's first run is one command and one URL.
+so a stranger's first run is one command and one URL. Its bounded reattach window
+is in-memory only: no durable store, new pairing authority, lease renewal or
+restart-after-process-exit guarantee. Consumers close revoked pairing sessions
+explicitly; a missing signaling carrier is not itself revocation.
 
 The same substitution is therefore available to both: the packages carry no muxr
 concept, and muxr's contribution is one file that adapts its own channel to the

package/docs/PROTOCOL.md

@@ -346,7 +346,16 @@ re-offers — a fresh offer with a new ICE generation — as a new
 `session.description` event, which the client answers as usual. The session
 and its generation survive; only the ICE generation turns over. Fresh
 candidates from the restart trickle through `session.candidate` on both sides
-exactly as the initial ones do.
+exactly as the initial ones do. If a local offer is still unanswered, the
+engine re-emits that pending offer instead: queued restarts share its ICE
+credentials until the answer arrives.
+
+The WebSocket bridge retains the session after its last signaling socket leaves
+for `reattachMs` (default 30000 ms; CLI `--reattach-ms`; 0 closes immediately).
+A token-authenticated socket attaching within that window cancels the deadline;
+it may restart ICE with the held session id without a new `session.open`.
+This does not replay offers or automatically reconnect a client, extend its
+lease, or guarantee recovery within 2 seconds. Engine-side ends remain terminal.
 
 ```jsonc
 {"id":7,"method":"session.restart_ice","params":{"session_id":"…","generation":1}}
@@ -421,9 +430,13 @@ The session ended on the engine's side; there is nothing further to drain.
 | `error` | The engine could not keep serving it, such as an encoder refusing a frame | end and report |
 
 A session the consumer closes or replaces (`session.close`, a new
-`session.open`, the consumer leaving) sends no `session.revoked`: the consumer
-asked for it, and signaling sees `session.state` with `capture` `ended`. Only
-its control channel is told, with code `closed` (below).
+`session.open`, engine stdin EOF, or the bridge's detach deadline) sends no
+`session.revoked`: signaling sees `session.state` with `capture` `ended`. Only
+its control channel is told, with code `closed` (below). A signaling socket
+leaving alone does not end the session during the bridge's reattach window.
+If the held session is revoked while detached, the bridge remembers its last
+`session.revoked`, replays it once to the next authenticated attacher, then
+forgets it. In particular, a spent lease cannot be revived by reattachment.
 
 A code a client does not know is terminal. Engines before this field sent no
 `code`; treat its absence as terminal too.
@@ -906,4 +919,6 @@ anything to show.
   and input; audio is a different product decision.
 - It does not arbitrate between two controllers. One session, one controller.
 - It does not auto-reconnect with authority it no longer holds: after a lease
-  expiry or owner disconnect it requires a fresh `session.open`.
+  expiry or an engine-side end it requires a fresh `session.open`. A brief
+  signaling-carrier loss within the bridge's reattach window is not owner
+  revocation; the application must close revoked pairing sessions explicitly.

package/engine/Cargo.lock

@@ -536,7 +536,7 @@ checksum = "7cd812cc2bc1d69d4764bd80df88b4317eaef9e773c75226407d9bc0876b211c"
 
 [[package]]
 name = "desklink-host"
-version = "0.5.2"
+version = "0.5.4"
 dependencies = [
  "anyhow",
  "ashpd",
@@ -1942,8 +1942,6 @@ dependencies = [
 [[package]]
 name = "rtc-ice"
 version = "0.21.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "4f437cc58721fdb3f0a2ab8b90660d3c19ea2817bc4e2117b2d80f3f6cfba5f3"
 dependencies = [
  "bytes",
  "crc",
@@ -2024,9 +2022,9 @@ dependencies = [
 
 [[package]]
 name = "rtc-sctp"
-version = "0.21.0"
+version = "0.21.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "161e3eb55695d4ce7492a690b6a27dc43bfeee43fd5d4af0423de1ace49456c1"
+checksum = "2eb430b379d90e7984306036d1646454a26b300c9c3256009eb8f7e0615e90b9"
 dependencies = [
  "bytes",
  "crc32c",
@@ -2051,9 +2049,9 @@ dependencies = [
 
 [[package]]
 name = "rtc-shared"
-version = "0.21.0"
+version = "0.21.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "24d32c3e91a0eec814e093f415f5848f5c3c497d8b1140965bf26f81101691ee"
+checksum = "1250e81796ac6d3d67bd04ecdb891b8371ff97c8a2ce0a5a1c1321f2e12b657b"
 dependencies = [
  "bitflags 1.3.2",
  "bytes",
@@ -2426,7 +2424,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "32497e9a4c7b38532efcdebeef879707aa9f794296a4f0244f6f69e9bc8574bd"
 dependencies = [
  "fastrand",
- "getrandom 0.4.3",
+ "getrandom 0.3.4",
  "once_cell",
  "rustix",
  "windows-sys 0.61.2",

package/engine/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "desklink-host"
-version = "0.5.2"
+version = "0.5.4"
 edition = "2021"
 rust-version = "1.97.1"
 license = "Apache-2.0"
@@ -21,6 +21,10 @@ anyhow = "1"
 tokio = { version = "1", features = ["rt-multi-thread", "macros", "io-util", "io-std", "sync", "time", "signal"] }
 libc = "0.2"
 bytes = "1"
+# rtc-sctp 0.21.1 is required through this stack: 0.21.0 replaces an
+# expired-but-unhandled T3 retransmission deadline, so the data channel stalls
+# on the new nominated pair after an ICE restart and the client reopens the
+# session. Cargo.lock pins 0.21.1; drop the pin when a later release carries it.
 webrtc = { version = "0.21", default-features = false, features = ["runtime-tokio", "crypto-ring"] }
 rtc = { version = "0.21", default-features = false, features = ["crypto-ring"] }
 log = "0.4"
@@ -64,3 +68,11 @@ cc = "1"
 [profile.release]
 lto = "thin"
 opt-level = 2
+
+# The engine needs an ICE restart that does not interrupt media already flowing
+# on the current selected pair (roam persistence, < 200 ms gap). rtc-ice 0.21.0
+# clears the selected pair and every candidate pair in `Agent::apply_restart`,
+# and exposes no setting to keep them, so a patched copy is vendored here. See
+# vendor/rtc-ice/DESKLINK-PATCH.md for what changed and how to drop it.
+[patch.crates-io]
+rtc-ice = { path = "vendor/rtc-ice" }

package/engine/src/clipboard.rs

@@ -270,37 +270,3 @@ pub fn x11_read(display: &str) -> Result<(String, bool)> {
         std::thread::sleep(std::time::Duration::from_millis(5));
     }
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn an_oversized_clipboard_is_cut_cleanly_and_reported() {
-        let mut raw = vec![b'a'; 4];
-        raw.extend_from_slice("\u{e9}".as_bytes());
-        raw.extend_from_slice(b"zzzz");
-        let (text, truncated) =
-            bounded_text(&raw, 5).expect("a character-boundary cut is valid text");
-        assert!(truncated, "a cut past the limit must be reported");
-        assert_eq!(
-            text, "aaaa",
-            "the partial character is dropped, not invented"
-        );
-
-        // A byte that is not valid UTF-8 before the cut is not a partial
-        // character; the whole read is refused.
-        let mut invalid = vec![b'a'; 4];
-        invalid.push(0xff);
-        invalid.extend_from_slice(b"zzzz");
-        assert!(bounded_text(&invalid, 5).is_err());
-
-        let (text, truncated) = bounded_text(b"hello", 5).unwrap();
-        assert!(!truncated);
-        assert_eq!(text, "hello");
-
-        let (text, truncated) = bounded_text(b"hello world", 5).unwrap();
-        assert!(truncated);
-        assert_eq!(text, "hello");
-    }
-}

package/engine/src/convert.rs

@@ -408,173 +408,3 @@ fn pack(
         (*u, *v) = chroma(sum(0), sum(1), sum(2));
     }
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn downscale_keeps_average_colour_and_plane_sizes() {
-        // 4x4 opaque red desktop in BGRx, downscaled to 2x2.
-        let mut src = vec![0u8; 4 * 16];
-        for px in src.chunks_exact_mut(4) {
-            px[0] = 0; // B
-            px[1] = 0; // G
-            px[2] = 255; // R
-            px[3] = 255; // X
-        }
-        let out = to_i420(&src, 4, 4, 16, PixelFormat::Bgrx, 2, 2).unwrap();
-        assert_eq!(out.data.len(), 4 + 2 * 1);
-        assert!(
-            out.y_plane().iter().all(|&y| y > 70),
-            "red luma should be high"
-        );
-        assert!(out.u_plane().iter().all(|&u| u < 128), "red has low Cb");
-        assert!(out.v_plane().iter().all(|&v| v > 200), "red has high Cr");
-    }
-
-    #[test]
-    fn odd_destination_is_clamped_to_whole_chroma_blocks() {
-        let src = vec![255u8; 4 * 16];
-        let out = to_i420(&src, 4, 4, 16, PixelFormat::Bgrx, 3, 3).unwrap();
-        assert_eq!((out.width, out.height), (2, 2));
-        assert_eq!(out.data.len(), 4 + 2 * 1);
-    }
-
-    #[test]
-    fn a_stream_a_few_pixels_off_the_encoders_size_is_converted_to_exactly_that_size() {
-        // A fractional-scaled display reports one size to the portal and
-        // streams another; the encoder only accepts its own.
-        let src = vec![200u8; 4 * 1704 * 1066];
-        let out = to_i420(&src, 1704, 1066, 1704 * 4, PixelFormat::Bgrx, 1706, 1066).unwrap();
-        assert_eq!((out.width, out.height), (1706, 1066));
-        let out = to_i420(&src, 1704, 1066, 1704 * 4, PixelFormat::Bgrx, 1702, 1064).unwrap();
-        assert_eq!((out.width, out.height), (1702, 1064));
-    }
-
-    #[test]
-    fn still_pixels_keep_exact_source_colours_before_encoding() {
-        let src = [1, 2, 3, 0, 4, 5, 6, 0];
-        assert_eq!(
-            to_bgrx(&src, 2, 1, 8, PixelFormat::Bgrx, 2, 1).unwrap(),
-            src
-        );
-        assert_eq!(
-            to_bgrx(&src, 2, 1, 8, PixelFormat::Rgbx, 2, 1).unwrap(),
-            [3, 2, 1, 255, 6, 5, 4, 255]
-        );
-    }
-
-    /// The per-pixel conversion this module used to run, kept as the definition
-    /// the fast paths must reproduce bit for bit.
-    fn reference(
-        src: &[u8],
-        sw: usize,
-        sh: usize,
-        stride: usize,
-        format: PixelFormat,
-        dw: usize,
-        dh: usize,
-    ) -> Vec<u8> {
-        let (bpp, o) = layout(format).unwrap();
-        let rgb = |x: usize, y: usize| {
-            let p = &src[y * stride + x * bpp..];
-            (p[o[0]] as i32, p[o[1]] as i32, p[o[2]] as i32)
-        };
-        let sample = |dx: usize, dy: usize| {
-            let x0 = dx * sw / dw;
-            let x1 = ((dx + 1) * sw).div_ceil(dw).clamp(x0 + 1, sw);
-            let y0 = dy * sh / dh;
-            let y1 = ((dy + 1) * sh).div_ceil(dh).clamp(y0 + 1, sh);
-            let (mut r, mut g, mut b) = (0, 0, 0);
-            for y in y0..y1 {
-                for x in x0..x1 {
-                    let p = rgb(x, y);
-                    (r, g, b) = (r + p.0, g + p.1, b + p.2);
-                }
-            }
-            let n = ((x1 - x0) * (y1 - y0)) as i32;
-            (r / n, g / n, b / n)
-        };
-        let (mut y, mut u, mut v) = (vec![0; dw * dh], vec![], vec![]);
-        for cy in 0..dh / 2 {
-            for cx in 0..dw / 2 {
-                let px = [(0, 0), (1, 0), (0, 1), (1, 1)]
-                    .map(|(i, j)| (cx * 2 + i, cy * 2 + j, sample(cx * 2 + i, cy * 2 + j)));
-                for (x, yy, p) in px {
-                    y[yy * dw + x] = luma(p.0, p.1, p.2);
-                }
-                let s = |f: fn(&(i32, i32, i32)) -> i32| {
-                    (px.iter().map(|p| f(&p.2)).sum::<i32>() + 2) >> 2
-                };
-                let (cu, cv) = chroma(s(|p| p.0), s(|p| p.1), s(|p| p.2));
-                u.push(cu);
-                v.push(cv);
-            }
-        }
-        [y, u, v].concat()
-    }
-
-    #[test]
-    fn every_path_matches_the_per_pixel_definition_exactly() {
-        let mut seed = 0x9e3779b9u32;
-        let mut noise = |n: usize| {
-            (0..n)
-                .map(|_| {
-                    seed ^= seed << 13;
-                    seed ^= seed >> 17;
-                    seed ^= seed << 5;
-                    seed as u8
-                })
-                .collect::<Vec<u8>>()
-        };
-        let formats = [
-            PixelFormat::Bgrx,
-            PixelFormat::Rgba,
-            PixelFormat::Bgr,
-            PixelFormat::Rgb,
-        ];
-        // Native, a few pixels off, box downscales, and boxes near and past the
-        // largest area the reciprocal table covers.
-        for (sw, sh, dw, dh) in [
-            (256, 126, 4, 2),
-            (400, 200, 4, 2),
-            (64, 36, 64, 36),
-            (67, 41, 66, 40),
-            (100, 60, 38, 22),
-            (90, 50, 92, 50),
-            (33, 17, 8, 6),
-        ] {
-            for format in formats {
-                let bpp = layout(format).unwrap().0;
-                let stride = sw * bpp + 12;
-                let src = noise(stride * sh);
-                let fast = to_i420(&src, sw, sh, stride, format, dw, dh).unwrap();
-                assert!(
-                    fast.data == reference(&src, sw, sh, stride, format, dw & !1, dh & !1),
-                    "{format:?} {sw}x{sh} -> {dw}x{dh}"
-                );
-            }
-        }
-    }
-
-    #[test]
-    fn padded_bgra_rows_remain_aligned_in_stills_and_video() {
-        // ScreenCaptureKit pads 3420 BGRA pixels from 13680 to 13696 bytes/row.
-        let src = [
-            0, 0, 255, 255, 0, 0, 255, 255, 0, 255, 0, 0, // red row + green padding
-            255, 0, 0, 255, 255, 0, 0, 255, 0, 255, 0, 0, // blue row + green padding
-        ];
-        assert_eq!(
-            to_bgrx(&src, 2, 2, 12, PixelFormat::Bgra, 2, 2).unwrap(),
-            [src[0..8].to_vec(), src[12..20].to_vec()].concat()
-        );
-        let video = to_i420(&src, 2, 2, 12, PixelFormat::Bgra, 2, 2).unwrap();
-        assert_eq!(video.y_plane(), &[82, 82, 41, 41]);
-    }
-
-    #[test]
-    fn unsupported_format_is_reported_not_guessed() {
-        assert!(to_i420(&vec![0u8; 64], 4, 4, 16, PixelFormat::Unsupported, 2, 2).is_none());
-    }
-}

package/engine/src/cursor.rs

@@ -32,26 +32,3 @@ impl Reporter {
         });
     }
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    #[test]
-    fn reports_initial_motion_and_visibility_but_not_unchanged_polls() {
-        let (tx, rx) = std::sync::mpsc::channel();
-        let mut reporter = Reporter::new(Box::new(move |p| {
-            tx.send(p).unwrap();
-        }));
-        reporter.update(10, 20, true);
-        reporter.update(10, 20, true);
-        reporter.update(30, 40, true);
-        reporter.update(30, 40, false);
-        let notices: Vec<_> = rx.try_iter().collect();
-        assert_eq!(notices.len(), 3);
-        assert_eq!((notices[1].x, notices[1].y), (30, 40));
-        assert!(!notices[2].visible);
-        assert!(notices
-            .windows(2)
-            .all(|p| p[0].timestamp_us <= p[1].timestamp_us));
-    }
-}

package/engine/src/input.rs

@@ -300,68 +300,3 @@ impl Drop for InputDevices {
         }
     }
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn button_numbers_map_to_the_expected_pointer_buttons() {
-        assert_eq!(Button::from_number(1), Button::Left);
-        assert_eq!(Button::from_number(2), Button::Middle);
-        assert_eq!(Button::from_number(3), Button::Right);
-        assert_eq!(Button::from_number(9), Button::Left);
-    }
-
-    #[test]
-    fn held_state_releases_exactly_what_this_session_pressed() {
-        let mut held = HeldState::default();
-        held.key(29, true); // left ctrl
-        held.key(46, true); // c
-        held.button(Button::Left, true);
-        // A repeat press is the same press, not a second one, so the plan still
-        // releases it exactly once.
-        held.key(29, true);
-
-        let (buttons, keys) = held.release_plan();
-        assert_eq!(buttons, vec![Button::Left]);
-        assert_eq!(keys, vec![29, 46]);
-        assert!(
-            held.release_plan().1.is_empty(),
-            "releasing twice releases nothing"
-        );
-    }
-
-    #[test]
-    fn an_explicit_release_leaves_only_what_is_still_pressed() {
-        let mut held = HeldState::default();
-        held.key(29, true);
-        held.key(46, true);
-        held.key(46, false);
-        let (buttons, keys) = held.release_plan();
-        assert!(buttons.is_empty());
-        assert_eq!(keys, vec![29]);
-    }
-
-    /// Proving the backend is really available here is the point: if this host
-    /// cannot create the devices, the engine must say so rather than offer a
-    /// control surface that does nothing.
-    #[test]
-    fn this_host_can_create_and_destroy_the_virtual_devices() {
-        // This touches the real desktop when uinput is writable. Ordinary
-        // suites must never create devices on the owner's active session.
-        if std::env::var("DESKLINK_TEST_UINPUT").as_deref() != Ok("1") {
-            return;
-        }
-        match InputDevices::create(2560, 1440) {
-            Ok(_devices) => {}
-            Err(error) => {
-                let unavailable = probe().unwrap_err();
-                assert!(
-                    error.to_string().contains(&unavailable.reason),
-                    "a creation failure must be the reported availability problem"
-                );
-            }
-        }
-    }
-}

package/engine/src/input_mac.rs

@@ -299,14 +299,3 @@ impl InputDevices {
         }
     }
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn command_key_uses_quartz_command_flag() {
-        assert_eq!(modifier_flag(keycode::LEFT_META), 0x100000);
-        assert_eq!(modifier_flag(0), 0);
-    }
-}

package/engine/src/keeper.rs

@@ -483,140 +483,3 @@ fn fatal(out: &mut impl Write, error: &str) -> Result<()> {
     write_line(out, &serde_json::json!({ "error": error }).to_string())?;
     Err(anyhow!("{error}"))
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn content_fills_the_screen_and_helpers_are_parked() {
-        assert_eq!(kiosk_geometry(1240, 760, 1280, 800), (0, 0, 1280, 800));
-        // Exactly at the limit is content; one pixel under is not.
-        assert_eq!(kiosk_geometry(120, 120, 1280, 800), (0, 0, 1280, 800));
-        assert_eq!(
-            kiosk_geometry(119, 800, 1280, 800),
-            (i32::from(PARKED_XY), i32::from(PARKED_XY), 119, 800)
-        );
-        assert_eq!(
-            kiosk_geometry(1000, 24, 1280, 800),
-            (i32::from(PARKED_XY), i32::from(PARKED_XY), 1000, 24)
-        );
-    }
-
-    #[test]
-    fn wm_class_reads_the_class_not_the_instance() {
-        assert_eq!(
-            decode_wm_class(b"google-chrome\0Google-chrome\0"),
-            Some(String::from("Google-chrome"))
-        );
-        assert_eq!(decode_wm_class(b"instance-only\0"), None);
-        assert_eq!(decode_wm_class(b""), None);
-    }
-
-    #[test]
-    fn titles_come_from_either_name_property_and_blank_is_none() {
-        assert_eq!(
-            decode_title("Pricing — Acme Store"),
-            Some(String::from("Pricing — Acme Store"))
-        );
-        assert_eq!(
-            decode_title("PPF probe - Google Chrome"),
-            Some(String::from("PPF probe - Google Chrome"))
-        );
-        assert_eq!(decode_title("   "), None);
-        assert_eq!(decode_title(""), None);
-        assert_eq!(
-            decode_title(&latin1(b"Gr\xf6\xdfe")),
-            Some(String::from("Gr\u{00f6}\u{00df}e"))
-        );
-    }
-
-    #[test]
-    fn the_report_line_is_exactly_the_promised_shape() {
-        let line = window_line(&[KeeperWindow {
-            id: 0x0040_0001,
-            title: Some(String::from("PPF probe - Google Chrome")),
-            class: Some(String::from("Google-chrome")),
-            pid: Some(1003571),
-            width: 1280,
-            height: 800,
-        }]);
-        let parsed: serde_json::Value = serde_json::from_str(&line).unwrap();
-        assert_eq!(
-            parsed,
-            serde_json::json!({
-                "windows": [{
-                    "id": 0x40_0001_u64,
-                    "title": "PPF probe - Google Chrome",
-                    "class": "Google-chrome",
-                    "pid": 1003571,
-                    "width": 1280,
-                    "height": 800,
-                }]
-            })
-        );
-        assert_eq!(window_line(&[]), r#"{"windows":[]}"#);
-    }
-
-    #[test]
-    fn missing_fields_are_null_not_absent() {
-        let line = window_line(&[KeeperWindow {
-            id: 7,
-            title: None,
-            class: None,
-            pid: None,
-            width: 100,
-            height: 100,
-        }]);
-        let parsed: serde_json::Value = serde_json::from_str(&line).unwrap();
-        let window = &parsed["windows"][0];
-        assert_eq!(window["title"], serde_json::Value::Null);
-        assert_eq!(window["class"], serde_json::Value::Null);
-        assert_eq!(window["pid"], serde_json::Value::Null);
-        assert!(window.get("width").is_some());
-    }
-
-    #[test]
-    fn an_unopenable_display_is_refused_in_one_error_line() {
-        let mut out = Vec::new();
-        assert!(keep(Some("not a display"), &mut out).is_err());
-        let line: serde_json::Value =
-            serde_json::from_str(&String::from_utf8(out).unwrap()).unwrap();
-        assert!(line["error"]
-            .as_str()
-            .is_some_and(|error| !error.is_empty()));
-    }
-
-    #[test]
-    fn a_refused_keeper_says_why_in_its_error_line() {
-        let mut out = Vec::new();
-        let error = fatal(&mut out, "another window manager").unwrap_err();
-        assert_eq!(error.to_string(), "another window manager");
-        assert_eq!(
-            String::from_utf8(out).unwrap(),
-            "{\"error\":\"another window manager\"}\n"
-        );
-    }
-
-    #[test]
-    fn the_display_flag_has_one_spelling() {
-        let flag = |args: &[&str]| {
-            display_argument(
-                &args
-                    .iter()
-                    .map(|arg| String::from(*arg))
-                    .collect::<Vec<_>>(),
-            )
-        };
-        assert_eq!(flag(&["--display", ":42"]), Some(String::from(":42")));
-        assert_eq!(
-            flag(&["--display", ":42", "--x"]),
-            Some(String::from(":42"))
-        );
-        assert_eq!(flag(&[]), None);
-        assert_eq!(flag(&["--display"]), None);
-        // The undocumented `--display=:42` spelling is not a display: `keep`
-        // refuses it rather than guessing what was meant.
-        assert_eq!(flag(&["--display=:42"]), None);
-    }
-}