@designcrowd/library.brand-page 6.2.12-publish-2 → 6.2.13

package/src/clients/ai-assistant-client.test.ts

@@ -0,0 +1,135 @@
+import axios from 'axios';
+import { createPinia, setActivePinia } from 'pinia';
+import { beforeEach, describe, expect, test, vi } from 'vitest';
+import {
+  getInstance,
+  getWebsiteCreateThreadEndpoint,
+  getWebsiteSendMessageEndpoint,
+  getWebsiteToolSubmissionEndpoint,
+  type WebsiteCreateThreadRequest,
+  type WebsiteSendMessageRequest,
+  type WebsiteToolSubmissionRequest,
+  type WebsiteCreateThreadBuildRequest,
+  type WebsiteSendMessageBuildRequest,
+} from './ai-assistant-client';
+
+vi.mock('axios');
+
+const THREAD_ID = 'thread-1';
+
+beforeEach(() => {
+  setActivePinia(createPinia());
+  vi.clearAllMocks();
+  vi.mocked(axios.post).mockResolvedValue({
+    data: { threadId: THREAD_ID, buildId: 'build-1' },
+    headers: {},
+  } as any);
+});
+
+// BP-6193: the client, not the caller, names the agent — tool results sent to a
+// different agent than the one running the thread fail the build
+// (ai-v2-tool-submission-routing.md).
+describe('AiAssistantClient — every website call names the V2 builder', () => {
+  test('the three build methods post agentType: V2', async () => {
+    const client = getInstance();
+
+    await client.createWebsiteThreadBuildAsync({
+      message: 'hello',
+      connectionId: 'conn-1',
+    } as WebsiteCreateThreadBuildRequest);
+    await client.sendWebsiteMessageBuildAsync(THREAD_ID, {
+      message: 'hello',
+      connectionId: 'conn-1',
+    } as WebsiteSendMessageBuildRequest);
+    await client.submitToolResultsBuildAsync(THREAD_ID, {
+      toolCalls: [],
+    } as WebsiteToolSubmissionRequest);
+
+    vi.mocked(axios.post).mock.calls.forEach(([, body]) => {
+      expect(body).toMatchObject({ agentType: 'website_builder_v2' });
+    });
+  });
+
+  test('the three unused V1-era methods also post agentType: V2', async () => {
+    const client = getInstance();
+
+    await client.createWebsiteThreadAndSendMessageAsync({
+      message: 'hello',
+    } as WebsiteCreateThreadRequest);
+    await client.sendWebsiteMessageAsync(THREAD_ID, {
+      message: 'hello',
+    } as WebsiteSendMessageRequest);
+    await client.submitWebsiteToolCallOutputAsync(THREAD_ID, {
+      toolCalls: [],
+    } as WebsiteToolSubmissionRequest);
+
+    vi.mocked(axios.post).mock.calls.forEach(([, body]) => {
+      expect(body).toMatchObject({ agentType: 'website_builder_v2' });
+    });
+  });
+
+  test('a caller-supplied agentType cannot override V2', async () => {
+    const client = getInstance();
+
+    await client.createWebsiteThreadBuildAsync({
+      message: 'hello',
+      connectionId: 'conn-1',
+      agentType: 'website_builder',
+    } as never);
+
+    const [, body] = vi.mocked(axios.post).mock.calls[0];
+
+    expect(body).toMatchObject({ agentType: 'website_builder_v2' });
+  });
+
+  test('each method posts to its own endpoint and keeps the caller fields', async () => {
+    const client = getInstance();
+
+    await client.createWebsiteThreadBuildAsync({
+      message: 'hello',
+      connectionId: 'conn-1',
+      userPlan: 'premium',
+      locale: 'en-US',
+    } as WebsiteCreateThreadBuildRequest);
+    await client.sendWebsiteMessageBuildAsync(THREAD_ID, {
+      message: 'follow-up',
+      connectionId: 'conn-1',
+      userPlan: 'free',
+      locale: 'en-US',
+    } as WebsiteSendMessageBuildRequest);
+    await client.submitToolResultsBuildAsync(THREAD_ID, {
+      toolCalls: [{ toolId: 't1', success: 'success' }],
+      connectionId: 'conn-1',
+      retryCount: 1,
+      userPlan: 'free',
+      locale: 'en-US',
+    } as WebsiteToolSubmissionRequest);
+
+    const calls = vi.mocked(axios.post).mock.calls;
+
+    expect(calls[0][0]).toBe(getWebsiteCreateThreadEndpoint());
+    expect(calls[0][1]).toMatchObject({
+      message: 'hello',
+      connectionId: 'conn-1',
+      userPlan: 'premium',
+      locale: 'en-US',
+    });
+
+    expect(calls[1][0]).toBe(getWebsiteSendMessageEndpoint(THREAD_ID));
+    expect(calls[1][1]).toMatchObject({
+      message: 'follow-up',
+      connectionId: 'conn-1',
+      userPlan: 'free',
+      locale: 'en-US',
+    });
+
+    expect(calls[2][0]).toBe(getWebsiteToolSubmissionEndpoint(THREAD_ID));
+    expect(calls[2][1]).toMatchObject({
+      toolCalls: [{ toolId: 't1', success: 'success' }],
+      connectionId: 'conn-1',
+      retryCount: 1,
+      userPlan: 'free',
+      locale: 'en-US',
+    });
+  });
+});

package/src/clients/ai-assistant-client.ts

@@ -29,7 +29,6 @@ export interface WebsiteContext {
 
 // Agent types
 export const AI_ASSISTANT_AGENT_TYPES = {
-  WEBSITE_BUILDER: 'website_builder',
   WEBSITE_BUILDER_V2: 'website_builder_v2',
 } as const;
 
@@ -67,18 +66,15 @@ export interface WebsiteCreateThreadRequest {
   message: string;
   websiteContext?: WebsiteContext;
   websiteSnapshot?: string;
-  agentType: AiAssistantAgentType;
 }
 
 export interface WebsiteSendMessageRequest {
   message: string;
   websiteContext?: WebsiteContext;
   websiteSnapshot?: string;
-  agentType: AiAssistantAgentType;
 }
 
 export interface WebsiteToolSubmissionRequest {
-  agentType: AiAssistantAgentType;
   toolCalls: AiAssistantToolResult[];
   runId?: string | null;
   message?: string;
@@ -95,7 +91,6 @@ export interface WebsiteCreateThreadBuildRequest {
   message: string;
   websiteContext?: WebsiteContext;
   websiteSnapshot?: string;
-  agentType: AiAssistantAgentType;
   userPlan?: UserPlan;
   connectionId: string;
   // TCI-1349: dedicated LLM-gateway locale attribution (cost tag only).
@@ -106,7 +101,6 @@ export interface WebsiteSendMessageBuildRequest {
   message: string;
   websiteContext?: WebsiteContext;
   websiteSnapshot?: string;
-  agentType: AiAssistantAgentType;
   userPlan?: UserPlan;
   connectionId: string;
   // TCI-1349: dedicated LLM-gateway locale attribution (cost tag only).
@@ -177,6 +171,18 @@ export class AiAssistantClient {
     };
   }
 
+  // The agent spread last, so no caller can override it. Tool results sent to a
+  // different agent than the one running the thread fail the build
+  // (ai-v2-tool-submission-routing.md).
+  private withAgentType<T extends object>(
+    request: T,
+  ): T & { agentType: AiAssistantAgentType } {
+    return {
+      ...request,
+      agentType: AI_ASSISTANT_AGENT_TYPES.WEBSITE_BUILDER_V2,
+    };
+  }
+
   /**
    * Create a new Website AI Assistant thread
    */
@@ -189,7 +195,7 @@ export class AiAssistantClient {
     try {
       const response = await axios.post<AiAssistantResponse>(
         getWebsiteCreateThreadEndpoint(),
-        request,
+        this.withAgentType(request),
         {
           withCredentials: true,
           headers: this.getRequestHeaders(),
@@ -225,7 +231,7 @@ export class AiAssistantClient {
     try {
       const response = await axios.post<AiAssistantResponse>(
         getWebsiteSendMessageEndpoint(threadId),
-        request,
+        this.withAgentType(request),
         {
           withCredentials: true,
           headers: this.getRequestHeaders(),
@@ -261,7 +267,7 @@ export class AiAssistantClient {
     try {
       const response = await axios.post<AiAssistantResponse>(
         getWebsiteToolSubmissionEndpoint(threadId),
-        request,
+        this.withAgentType(request),
         {
           withCredentials: true,
           headers: this.getRequestHeaders(),
@@ -286,7 +292,7 @@ export class AiAssistantClient {
     try {
       const response = await axios.post<AiAssistantBuildResponse>(
         getWebsiteCreateThreadEndpoint(),
-        request,
+        this.withAgentType(request),
         {
           withCredentials: true,
           headers: this.getRequestHeaders(),
@@ -311,7 +317,7 @@ export class AiAssistantClient {
     try {
       const response = await axios.post<AiAssistantBuildResponse>(
         getWebsiteSendMessageEndpoint(threadId),
-        request,
+        this.withAgentType(request),
         {
           withCredentials: true,
           headers: this.getRequestHeaders(),
@@ -336,7 +342,7 @@ export class AiAssistantClient {
     try {
       const response = await axios.post<AiAssistantBuildResponse>(
         getWebsiteToolSubmissionEndpoint(threadId),
-        request,
+        this.withAgentType(request),
         {
           withCredentials: true,
           headers: this.getRequestHeaders(),

package/src/shared/background-settings/store/background-settings-store.ts

@@ -24,7 +24,9 @@ import type {
 } from '../models';
 import { backgroundSettingsTabId } from '../models';
 import { defineStore } from 'pinia';
-import { useUiStore, useVideoStore } from '@brand-page-maker/stores';
+// Direct paths, not the stores barrel: it sits in an import cycle with this store.
+import { useUiStore } from '@brand-page-maker/stores/ui/ui-store';
+import { useVideoStore } from '@brand-page-maker/stores/video/video-store';
 import type {
   GettyVideoMediaSelectedPayload,
   MediaBaseSelectedPayload,

package/lib/src/brand-page-maker/composables/ai-chat/ai-builder-experiment.d.ts

@@ -1,10 +0,0 @@
-import type { AbTestResult } from '../../../brand-page/models/brand-page-context.model';
-import { type AiAssistantAgentType } from '../../../clients/ai-assistant-client';
-/**
- * A/B test: control keeps the V1 AI website builder, variation-1 gets V2.
- *
- * bc-net (WebsiteMakerInteractor) buckets post-purchase users who get the AI tab at
- * editor load and sends the arm in `abTests`. No arm, control and excluded all stay
- * on V1, so a missing value is today's production behaviour.
- */
-export declare const aiBuilderAgentTypeForArm: (arm: AbTestResult | undefined) => AiAssistantAgentType;

package/lib/src/brand-page-maker/composables/ai-chat/ai-builder-experiment.js

@@ -1,11 +0,0 @@
-import { AI_ASSISTANT_AGENT_TYPES, } from '../../../clients/ai-assistant-client';
-/**
- * A/B test: control keeps the V1 AI website builder, variation-1 gets V2.
- *
- * bc-net (WebsiteMakerInteractor) buckets post-purchase users who get the AI tab at
- * editor load and sends the arm in `abTests`. No arm, control and excluded all stay
- * on V1, so a missing value is today's production behaviour.
- */
-export const aiBuilderAgentTypeForArm = (arm) => arm?.isVariation
-    ? AI_ASSISTANT_AGENT_TYPES.WEBSITE_BUILDER_V2
-    : AI_ASSISTANT_AGENT_TYPES.WEBSITE_BUILDER;

package/src/brand-page-maker/composables/ai-chat/ai-builder-experiment.test.ts

@@ -1,82 +0,0 @@
-import { describe, it, expect, beforeEach } from 'vitest';
-import { createPinia, setActivePinia } from 'pinia';
-import { aiBuilderAgentTypeForArm } from './ai-builder-experiment';
-import { getAbTestResults } from '../../../brand-page/models/brand-page-context.model';
-import { useAiWebsiteBuilderThreadStore } from '../../stores';
-
-// Must match `Bp6136V2AiBuilderStrategy` in bc-net and the LaunchDarkly flag.
-const CAMPAIGN = 'bc-bp-6136-v2-ai-builder';
-
-// The arm arrives as the raw bc-net campaign string, so go through the real parser.
-const armFor = (value?: string) =>
-  getAbTestResults(value ? ({ [CAMPAIGN]: value } as never) : {})
-    .bp_6136_v2_ai_builder;
-
-describe('BP-6136 arm to AI builder agent type', () => {
-  it('variation-1 gets the V2 builder', () => {
-    expect(aiBuilderAgentTypeForArm(armFor('bp-6136-variation-1'))).toBe(
-      'website_builder_v2',
-    );
-  });
-
-  it('control stays on V1', () => {
-    expect(aiBuilderAgentTypeForArm(armFor('bp-6136-control'))).toBe(
-      'website_builder',
-    );
-  });
-
-  it('excluded stays on V1', () => {
-    expect(aiBuilderAgentTypeForArm(armFor('bp-6136-excluded'))).toBe(
-      'website_builder',
-    );
-  });
-
-  it('no arm at all (pre-purchase, AI tab off, older bc-net) stays on V1', () => {
-    expect(aiBuilderAgentTypeForArm(armFor(undefined))).toBe('website_builder');
-    expect(aiBuilderAgentTypeForArm(undefined)).toBe('website_builder');
-  });
-});
-
-describe('thread store agent type', () => {
-  beforeEach(() => {
-    setActivePinia(createPinia());
-  });
-
-  it('starts on V1, the production default', () => {
-    expect(useAiWebsiteBuilderThreadStore().agentType).toBe('website_builder');
-  });
-
-  it('switching before any thread exists keeps the pending prompt and does not reset', () => {
-    const threadStore = useAiWebsiteBuilderThreadStore();
-
-    threadStore.promptText = 'draft the user is typing';
-
-    threadStore.setAgentType('website_builder_v2');
-
-    expect(threadStore.agentType).toBe('website_builder_v2');
-    expect(threadStore.promptText).toBe('draft the user is typing');
-    expect(threadStore.resetToken).toBe(0);
-  });
-
-  it('switching under a running thread drops that thread', () => {
-    const threadStore = useAiWebsiteBuilderThreadStore();
-
-    threadStore.threadId = 'thread-on-v1';
-
-    threadStore.setAgentType('website_builder_v2');
-
-    expect(threadStore.threadId).toBeNull();
-    expect(threadStore.resetToken).toBe(1);
-  });
-
-  it('setting the same agent again is a no-op', () => {
-    const threadStore = useAiWebsiteBuilderThreadStore();
-
-    threadStore.threadId = 'thread-on-v1';
-
-    threadStore.setAgentType('website_builder');
-
-    expect(threadStore.threadId).toBe('thread-on-v1');
-    expect(threadStore.resetToken).toBe(0);
-  });
-});

package/src/brand-page-maker/composables/ai-chat/ai-builder-experiment.ts

@@ -1,19 +0,0 @@
-import type { AbTestResult } from '../../../brand-page/models/brand-page-context.model';
-import {
-  AI_ASSISTANT_AGENT_TYPES,
-  type AiAssistantAgentType,
-} from '../../../clients/ai-assistant-client';
-
-/**
- * A/B test: control keeps the V1 AI website builder, variation-1 gets V2.
- *
- * bc-net (WebsiteMakerInteractor) buckets post-purchase users who get the AI tab at
- * editor load and sends the arm in `abTests`. No arm, control and excluded all stay
- * on V1, so a missing value is today's production behaviour.
- */
-export const aiBuilderAgentTypeForArm = (
-  arm: AbTestResult | undefined,
-): AiAssistantAgentType =>
-  arm?.isVariation
-    ? AI_ASSISTANT_AGENT_TYPES.WEBSITE_BUILDER_V2
-    : AI_ASSISTANT_AGENT_TYPES.WEBSITE_BUILDER;