@designcrowd/library.brand-page 5.19.1-id-based-items-1 → 5.19.1

package/lib/src/metadata-builder/parsers/section-tool-arguments.d.ts

@@ -92,15 +92,10 @@ export interface ProfileSectionArguments {
     background_color?: string | null;
 }
 export interface TextSectionItem {
-    /** Stable id of the existing item to update or move. Omit to ADD a new item. */
-    item_id?: string;
-    /**
-     * Id of an existing item to position this item before (insert for new items,
-     * move for existing ones). Use "__end__" for the end of the list. Omit to
-     * leave an existing item in place / append a new item. Mirrors the
-     * section-level move_before_content_id.
-     */
-    move_before_item_id?: string;
+    /** 0-based index of existing item to update in-place */
+    item_index?: number;
+    /** 0-based position to insert a new item at */
+    insert_at?: number;
     text?: RichTextField;
     text_style?: TextStyleArguments;
 }
@@ -113,8 +108,10 @@ export interface TextSectionArguments {
     /** Multiple text items (BrandSite) */
     items?: TextSectionItem[];
     _replace_items?: boolean;
-    /** Stable ids of items to remove. Order-independent (no index shifting). */
-    _remove_item_ids?: string[];
+    /** 0-based indices of items to remove */
+    _remove_item_indices?: number[];
+    /** New order as array of current 0-based indices */
+    _reorder_items?: number[];
     background_color?: string | null;
 }
 export interface ImageSectionArguments {
@@ -122,15 +119,10 @@ export interface ImageSectionArguments {
     image_title?: string;
 }
 export interface ImageGalleryItem {
-    /** Stable id of the existing item to update or move. Omit to ADD a new item. */
-    item_id?: string;
-    /**
-     * Id of an existing item to position this item before (insert for new items,
-     * move for existing ones). Use "__end__" for the end of the list. Omit to
-     * leave an existing item in place / append a new item. Mirrors the
-     * section-level move_before_content_id.
-     */
-    move_before_item_id?: string;
+    /** 0-based index of existing item to update in-place */
+    item_index?: number;
+    /** 0-based position to insert a new item at */
+    insert_at?: number;
     image_url?: string;
     caption?: string;
 }
@@ -139,8 +131,10 @@ export interface ImageGallerySectionArguments {
     gallery_type?: 'grid' | 'carousel' | 'masonry';
     is_full_width?: boolean;
     _replace_items?: boolean;
-    /** Stable ids of items to remove. Order-independent (no index shifting). */
-    _remove_item_ids?: string[];
+    /** 0-based indices of items to remove */
+    _remove_item_indices?: number[];
+    /** New order as array of current 0-based indices */
+    _reorder_items?: number[];
 }
 export interface GeneralLinkSectionArguments {
     title?: string;
@@ -195,15 +189,10 @@ export interface TiktokSectionArguments {
     url?: string;
 }
 export interface SocialLink {
-    /** Stable id of the existing item to update or move. Omit to ADD a new item. */
-    item_id?: string;
-    /**
-     * Id of an existing item to position this item before (insert for new items,
-     * move for existing ones). Use "__end__" for the end of the list. Omit to
-     * leave an existing item in place / append a new item. Mirrors the
-     * section-level move_before_content_id.
-     */
-    move_before_item_id?: string;
+    /** 0-based index of existing item to update in-place */
+    item_index?: number;
+    /** 0-based position to insert a new item at */
+    insert_at?: number;
     platform?: 'facebook' | 'x' | 'instagram' | 'youtube' | 'linkedin' | 'pinterest' | 'twitch' | 'tiktok';
     url?: string;
 }
@@ -215,8 +204,10 @@ export interface SocialLinksSectionArguments {
     /** Style for the icon container background (used when icon_style is 'square' or 'circle'). */
     icon_background_style?: TextStyleArguments;
     _replace_items?: boolean;
-    /** Stable ids of items to remove. Order-independent (no index shifting). */
-    _remove_item_ids?: string[];
+    /** 0-based indices of items to remove */
+    _remove_item_indices?: number[];
+    /** New order as array of current 0-based indices */
+    _reorder_items?: number[];
 }
 export interface MailingListSectionArguments {
     title?: RichTextField;
@@ -277,15 +268,10 @@ export interface AboutSectionArguments {
     background_color?: string | null;
 }
 export interface ImagesSectionItem {
-    /** Stable id of the existing item to update or move. Omit to ADD a new item. */
-    item_id?: string;
-    /**
-     * Id of an existing item to position this item before (insert for new items,
-     * move for existing ones). Use "__end__" for the end of the list. Omit to
-     * leave an existing item in place / append a new item. Mirrors the
-     * section-level move_before_content_id.
-     */
-    move_before_item_id?: string;
+    /** 0-based index of existing item to update in-place */
+    item_index?: number;
+    /** 0-based position to insert a new item at */
+    insert_at?: number;
     image_url?: string;
     heading?: string;
     text?: string;
@@ -297,8 +283,10 @@ export interface ImagesSectionArguments {
     items?: ImagesSectionItem[];
     display_style?: 'left-aligned' | 'right-aligned' | 'centered' | 'media-only' | 'center-card-aligned-image' | 'alternate-image';
     _replace_items?: boolean;
-    /** Stable ids of items to remove. Order-independent (no index shifting). */
-    _remove_item_ids?: string[];
+    /** 0-based indices of items to remove */
+    _remove_item_indices?: number[];
+    /** New order as array of current 0-based indices */
+    _reorder_items?: number[];
     title_style?: TextStyleArguments;
     description_style?: TextStyleArguments;
     heading_style?: TextStyleArguments;
@@ -310,15 +298,10 @@ export interface ImagesSectionArguments {
     card_style?: CardStyleArguments;
 }
 export interface TestimonialItem {
-    /** Stable id of the existing item to update or move. Omit to ADD a new item. */
-    item_id?: string;
-    /**
-     * Id of an existing item to position this item before (insert for new items,
-     * move for existing ones). Use "__end__" for the end of the list. Omit to
-     * leave an existing item in place / append a new item. Mirrors the
-     * section-level move_before_content_id.
-     */
-    move_before_item_id?: string;
+    /** 0-based index of existing item to update in-place */
+    item_index?: number;
+    /** 0-based position to insert a new item at */
+    insert_at?: number;
     testimonial?: string;
     name?: string;
     position?: string;
@@ -331,8 +314,10 @@ export interface TestimonialSectionArguments {
     items?: TestimonialItem[];
     display_style?: 'centered' | 'big-image' | 'columns';
     _replace_items?: boolean;
-    /** Stable ids of items to remove. Order-independent (no index shifting). */
-    _remove_item_ids?: string[];
+    /** 0-based indices of items to remove */
+    _remove_item_indices?: number[];
+    /** New order as array of current 0-based indices */
+    _reorder_items?: number[];
     title_style?: TextStyleArguments;
     testimonial_style?: TextStyleArguments;
     name_style?: TextStyleArguments;
@@ -341,15 +326,10 @@ export interface TestimonialSectionArguments {
     card_style?: CardStyleArguments;
 }
 export interface ShapesSectionItem {
-    /** Stable id of the existing item to update or move. Omit to ADD a new item. */
-    item_id?: string;
-    /**
-     * Id of an existing item to position this item before (insert for new items,
-     * move for existing ones). Use "__end__" for the end of the list. Omit to
-     * leave an existing item in place / append a new item. Mirrors the
-     * section-level move_before_content_id.
-     */
-    move_before_item_id?: string;
+    /** 0-based index of existing item to update in-place */
+    item_index?: number;
+    /** 0-based position to insert a new item at */
+    insert_at?: number;
     icon_image_url?: string;
     shape_url?: string;
     color_theme?: string;
@@ -362,8 +342,10 @@ export interface ShapesSectionArguments {
     items?: ShapesSectionItem[];
     display_style?: 'left-aligned' | 'right-aligned' | 'centered' | 'media-only' | 'center-card-aligned-image' | 'alternate-image';
     _replace_items?: boolean;
-    /** Stable ids of items to remove. Order-independent (no index shifting). */
-    _remove_item_ids?: string[];
+    /** 0-based indices of items to remove */
+    _remove_item_indices?: number[];
+    /** New order as array of current 0-based indices */
+    _reorder_items?: number[];
     title_style?: TextStyleArguments;
     description_style?: TextStyleArguments;
     heading_style?: TextStyleArguments;

package/lib/src/shared/page-settings/components/page-settings/PageSettings.mixin.d.ts

@@ -2866,7 +2866,6 @@ declare const _default: import("vue").DefineComponent<{}, {
                 logoImageBase64Url?: string | undefined;
                 socialLinks: {
                     url: string;
-                    id?: string | undefined;
                     imageUrl: string;
                     size?: string | undefined;
                     imageTitle: string;
@@ -3091,7 +3090,6 @@ declare const _default: import("vue").DefineComponent<{}, {
                 logoImageBase64Url?: string | undefined;
                 socialLinks: {
                     url: string;
-                    id?: string | undefined;
                     imageUrl: string;
                     size?: string | undefined;
                     imageTitle: string;

package/lib/src/shared/page-settings/components/page-settings-section-styles/PageSettingsSectionStyles.mixin.d.ts

@@ -2824,7 +2824,6 @@ declare const _default: import("vue").DefineComponent<import("vue").ExtractPropT
                 logoImageBase64Url?: string | undefined;
                 socialLinks: {
                     url: string;
-                    id?: string | undefined;
                     imageUrl: string;
                     size?: string | undefined;
                     imageTitle: string;
@@ -3049,7 +3048,6 @@ declare const _default: import("vue").DefineComponent<import("vue").ExtractPropT
                 logoImageBase64Url?: string | undefined;
                 socialLinks: {
                     url: string;
-                    id?: string | undefined;
                     imageUrl: string;
                     size?: string | undefined;
                     imageTitle: string;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@designcrowd/library.brand-page",
   "description": "A collection of Maker/Designer applications",
-  "version": "5.19.1-id-based-items-1",
+  "version": "5.19.1",
   "author": "Design.com Eng",
   "license": "UNLICENSED",
   "type": "module",

package/src/brand-page/components/image-gallery/masonry/MasonryGallery.mixin.ts

@@ -7,8 +7,7 @@ import type { ImageGalleryImageClickPayload } from '../models';
 import type { BrandPageContext, ImageGalleryItem } from '../../../models';
 import { getImageAltText } from '../../../utils';
 
-interface IndexedImageGalleryItem extends Omit<ImageGalleryItem, 'id'> {
-  // Local rendering index, distinct from the stable string `id` on ImageItem.
+interface IndexedImageGalleryItem extends ImageGalleryItem {
   id: number;
 }
 

package/src/brand-page/models/index.ts

@@ -234,13 +234,6 @@ export interface ImageContent extends Content {
 }
 
 export interface ImageItem {
-  /**
-   * Stable per-item identifier. Mirrors the section-level `Content.id` one
-   * level deeper so AI tool calls can reference items by id rather than by
-   * positional index. Optional for backward compatibility with persisted data
-   * that predates item ids — backfilled on load (see ensureItemIds).
-   */
-  id?: string;
   imageUrl: string;
   imageTitle: string;
   width: number;
@@ -473,8 +466,6 @@ export interface ShapeItem extends ImageItem {
 }
 
 export interface TestimonialItems {
-  /** Stable per-item identifier. See ImageItem.id. */
-  id?: string;
   imageUrl: string;
   name: string;
   position: string;
@@ -492,8 +483,6 @@ export interface TestimonialItems {
 }
 
 export interface TextItem {
-  /** Stable per-item identifier. See ImageItem.id. */
-  id?: string;
   text: string;
   textStyle: TextStyleDeclaration;
 
@@ -563,7 +552,6 @@ export interface AboutSectionContent extends Content {
 }
 
 export interface LinksItem {
-  id?: string;
   imageUrl: string;
   url: string;
   size?: string;

package/src/metadata-builder/builders/footer-builder.test.ts

@@ -14,10 +14,6 @@ import { FooterBuilder } from './footer-builder';
  * The fix routes copyright style writes through `applyDetachedStyleOverride`,
  * which resolves the preset in and clears `textStyleType` so the per-element
  * override sticks.
- *
- * BP-5603: social link mutations converted from index-based to id-based
- * (item_id / move_before_item_id / _remove_social_link_ids), mirroring the
- * section-level move_before_content_id contract one level deeper.
  */
 
 const textStyleOptions = {
@@ -46,37 +42,6 @@ const makeModel = (copyrightStyle: Record<string, unknown>): BrandPageModel =>
     pageFooterMobile: { copyrightStyle: { ...copyrightStyle } },
   }) as unknown as BrandPageModel;
 
-const makeModelWithLinks = (
-  links: { id?: string; imageUrl: string; url: string }[],
-): BrandPageModel =>
-  ({
-    styles: { textStyles: { textStyleOptions } },
-    pageFooterDesktop: {
-      copyrightStyle: {},
-      socialLinks: links.map((l) => ({
-        id: l.id,
-        imageUrl: l.imageUrl,
-        url: l.url,
-        imageTitle: '',
-        width: 0,
-        height: 0,
-        imageLink: '',
-      })),
-    },
-    pageFooterMobile: {
-      copyrightStyle: {},
-      socialLinks: links.map((l) => ({
-        id: l.id,
-        imageUrl: l.imageUrl,
-        url: l.url,
-        imageTitle: '',
-        width: 0,
-        height: 0,
-        imageLink: '',
-      })),
-    },
-  }) as unknown as BrandPageModel;
-
 const run = (args: UpdateFooterArguments, model: BrandPageModel) =>
   new FooterBuilder({
     id: 'f1',
@@ -84,10 +49,6 @@ const run = (args: UpdateFooterArguments, model: BrandPageModel) =>
     payload: args,
   }).buildAsync(model);
 
-// ---------------------------------------------------------------------------
-// Copyright font (BP-5420)
-// ---------------------------------------------------------------------------
-
 describe('FooterBuilder — copyright font vs global style', () => {
   it('detaches from the global preset: applies the font, clears textStyleType, retains preset values', async () => {
     const model = makeModel({
@@ -113,262 +74,3 @@ describe('FooterBuilder — copyright font vs global style', () => {
     expect(style.textAlign).toBe('center');
   });
 });
-
-// ---------------------------------------------------------------------------
-// Social links — id-based mutations (BP-5603)
-// ---------------------------------------------------------------------------
-
-describe('FooterBuilder — social links id-based mutations', () => {
-  it('backfills ids on legacy links that have none', async () => {
-    // Links without ids (legacy persisted data)
-    const model = makeModelWithLinks([
-      { imageUrl: 'facebook', url: 'https://fb.com' },
-      { imageUrl: 'instagram', url: 'https://ig.com' },
-    ]);
-
-    const { model: out } = await run({}, model);
-
-    const links = out.pageFooterDesktop!.socialLinks;
-
-    expect(links[0].id).toBeTruthy();
-    expect(links[1].id).toBeTruthy();
-    expect(links[0].id).not.toBe(links[1].id);
-  });
-
-  it('updates an existing link in place by item_id', async () => {
-    const model = makeModelWithLinks([
-      { id: 'link-1', imageUrl: 'facebook', url: 'https://fb.com' },
-      { id: 'link-2', imageUrl: 'instagram', url: 'https://ig.com' },
-    ]);
-
-    const { model: out } = await run(
-      {
-        social_links: [
-          { item_id: 'link-1', url: 'https://facebook.com/mybrand' },
-        ],
-      },
-      model,
-    );
-
-    const links = out.pageFooterDesktop!.socialLinks;
-
-    expect(links).toHaveLength(2);
-    expect(links[0].url).toBe('https://facebook.com/mybrand');
-    expect(links[0].id).toBe('link-1');
-    // untouched link unchanged
-    expect(links[1].id).toBe('link-2');
-    expect(links[1].url).toBe('https://ig.com');
-  });
-
-  it('updates social_link_icon on an existing link', async () => {
-    const model = makeModelWithLinks([
-      { id: 'link-1', imageUrl: 'facebook', url: 'https://fb.com' },
-    ]);
-
-    const { model: out } = await run(
-      {
-        social_links: [{ item_id: 'link-1', social_link_icon: 'facebook-v2' }],
-      },
-      model,
-    );
-
-    expect(out.pageFooterDesktop!.socialLinks[0].imageUrl).toBe('facebook-v2');
-  });
-
-  it('skips unknown item_id silently', async () => {
-    const model = makeModelWithLinks([
-      { id: 'link-1', imageUrl: 'facebook', url: 'https://fb.com' },
-    ]);
-
-    const { model: out } = await run(
-      {
-        social_links: [{ item_id: 'no-such-id', url: 'https://nowhere.com' }],
-      },
-      model,
-    );
-
-    const links = out.pageFooterDesktop!.socialLinks;
-
-    expect(links).toHaveLength(1);
-    expect(links[0].url).toBe('https://fb.com');
-  });
-
-  it('inserts a new link (no item_id) appended by default', async () => {
-    const model = makeModelWithLinks([
-      { id: 'link-1', imageUrl: 'facebook', url: 'https://fb.com' },
-    ]);
-
-    const { model: out } = await run(
-      {
-        social_links: [
-          { social_link_icon: 'instagram', url: 'https://ig.com' },
-        ],
-      },
-      model,
-    );
-
-    const links = out.pageFooterDesktop!.socialLinks;
-
-    expect(links).toHaveLength(2);
-    expect(links[1].imageUrl).toBe('instagram');
-    expect(links[1].id).toBeTruthy();
-  });
-
-  it('inserts a new link before an anchor via move_before_item_id', async () => {
-    const model = makeModelWithLinks([
-      { id: 'link-1', imageUrl: 'facebook', url: 'https://fb.com' },
-      { id: 'link-2', imageUrl: 'instagram', url: 'https://ig.com' },
-    ]);
-
-    const { model: out } = await run(
-      {
-        social_links: [
-          {
-            social_link_icon: 'x',
-            url: 'https://x.com',
-            move_before_item_id: 'link-2',
-          },
-        ],
-      },
-      model,
-    );
-
-    const links = out.pageFooterDesktop!.socialLinks;
-
-    expect(links).toHaveLength(3);
-    expect(links[0].id).toBe('link-1');
-    expect(links[1].imageUrl).toBe('x');
-    expect(links[2].id).toBe('link-2');
-  });
-
-  it('inserts a new link at end via move_before_item_id "__end__"', async () => {
-    const model = makeModelWithLinks([
-      { id: 'link-1', imageUrl: 'facebook', url: 'https://fb.com' },
-      { id: 'link-2', imageUrl: 'instagram', url: 'https://ig.com' },
-    ]);
-
-    const { model: out } = await run(
-      {
-        social_links: [
-          {
-            social_link_icon: 'x',
-            url: 'https://x.com',
-            move_before_item_id: '__end__',
-          },
-        ],
-      },
-      model,
-    );
-
-    const links = out.pageFooterDesktop!.socialLinks;
-
-    expect(links).toHaveLength(3);
-    expect(links[2].imageUrl).toBe('x');
-  });
-
-  it('moves an existing link before an anchor via move_before_item_id', async () => {
-    const model = makeModelWithLinks([
-      { id: 'link-1', imageUrl: 'facebook', url: 'https://fb.com' },
-      { id: 'link-2', imageUrl: 'instagram', url: 'https://ig.com' },
-      { id: 'link-3', imageUrl: 'x', url: 'https://x.com' },
-    ]);
-
-    const { model: out } = await run(
-      {
-        social_links: [{ item_id: 'link-3', move_before_item_id: 'link-1' }],
-      },
-      model,
-    );
-
-    const links = out.pageFooterDesktop!.socialLinks;
-
-    expect(links.map((l) => l.id)).toEqual(['link-3', 'link-1', 'link-2']);
-  });
-
-  it('removes links by id', async () => {
-    const model = makeModelWithLinks([
-      { id: 'link-1', imageUrl: 'facebook', url: 'https://fb.com' },
-      { id: 'link-2', imageUrl: 'instagram', url: 'https://ig.com' },
-      { id: 'link-3', imageUrl: 'x', url: 'https://x.com' },
-    ]);
-
-    const { model: out } = await run(
-      { _remove_social_link_ids: ['link-1', 'link-3'] },
-      model,
-    );
-
-    const links = out.pageFooterDesktop!.socialLinks;
-
-    expect(links).toHaveLength(1);
-    expect(links[0].id).toBe('link-2');
-  });
-
-  it('_replace_social_links rebuilds the entire list and assigns fresh ids', async () => {
-    const model = makeModelWithLinks([
-      { id: 'old-1', imageUrl: 'facebook', url: 'https://fb.com' },
-    ]);
-
-    const { model: out } = await run(
-      {
-        _replace_social_links: true,
-        social_links: [
-          { social_link_icon: 'instagram', url: 'https://ig.com' },
-          { social_link_icon: 'x', url: 'https://x.com' },
-        ],
-      },
-      model,
-    );
-
-    const links = out.pageFooterDesktop!.socialLinks;
-
-    expect(links).toHaveLength(2);
-    expect(links[0].imageUrl).toBe('instagram');
-    expect(links[1].imageUrl).toBe('x');
-    // fresh ids assigned, not the old one
-    expect(links[0].id).toBeTruthy();
-    expect(links[0].id).not.toBe('old-1');
-  });
-
-  it('_replace_social_links with empty social_links clears all', async () => {
-    const model = makeModelWithLinks([
-      { id: 'link-1', imageUrl: 'facebook', url: 'https://fb.com' },
-    ]);
-
-    const { model: out } = await run({ _replace_social_links: true }, model);
-
-    expect(out.pageFooterDesktop!.socialLinks).toHaveLength(0);
-  });
-
-  it('normalises mailto: and tel: prefixes on new links', async () => {
-    const model = makeModelWithLinks([]);
-
-    const { model: out } = await run(
-      {
-        social_links: [
-          { social_link_icon: 'email', url: 'mailto:me@example.com' },
-          { social_link_icon: 'phone', url: 'tel:+1234567890' },
-        ],
-      },
-      model,
-    );
-
-    const links = out.pageFooterDesktop!.socialLinks;
-
-    expect(links[0].url).toBe('me@example.com');
-    expect(links[1].url).toBe('+1234567890');
-  });
-
-  it('applies mutations to both desktop and mobile footers', async () => {
-    const model = makeModelWithLinks([
-      { id: 'link-1', imageUrl: 'facebook', url: 'https://fb.com' },
-    ]);
-
-    const { model: out } = await run(
-      { _remove_social_link_ids: ['link-1'] },
-      model,
-    );
-
-    expect(out.pageFooterDesktop!.socialLinks).toHaveLength(0);
-    expect(out.pageFooterMobile!.socialLinks).toHaveLength(0);
-  });
-});