@designcrowd/library.brand-page 5.18.7-ast-padding-1 → 5.18.7

package/src/utils/minify-brand-page-metadata.ts

@@ -205,17 +205,7 @@ const minifyContent = (
   editor: Editor,
   assets?: AssetEntry[],
 ): MinifiedContent => {
-  const base: MinifiedContent = {
-    id: content.id,
-    type: content.type,
-    // Padding Control (BP-5687) — shared across every block, persist when set.
-    ...(typeof content.topPadding === 'number' && {
-      topPadding: content.topPadding,
-    }),
-    ...(typeof content.bottomPadding === 'number' && {
-      bottomPadding: content.bottomPadding,
-    }),
-  };
+  const base: MinifiedContent = { id: content.id, type: content.type };
   const c = content as any;
 
   // Helper: include imageUrl and its asset key if available

package/lib/src/brand-page/utils/content-padding.util.d.ts

@@ -1,13 +0,0 @@
-/**
- * Block top/bottom padding (BP-5687) as a bindable CSS style object. Defaults
- * live in the data — `content-settings` for new content, a migration for
- * existing — so this just reads the stored value (`?? 0` covers content from
- * before the field existed).
- */
-export declare const contentPaddingStyle: (content: {
-    topPadding?: number;
-    bottomPadding?: number;
-}) => {
-    paddingTop: string;
-    paddingBottom: string;
-};

package/lib/src/brand-page/utils/content-padding.util.js

@@ -1,10 +0,0 @@
-/**
- * Block top/bottom padding (BP-5687) as a bindable CSS style object. Defaults
- * live in the data — `content-settings` for new content, a migration for
- * existing — so this just reads the stored value (`?? 0` covers content from
- * before the field existed).
- */
-export const contentPaddingStyle = (content) => ({
-    paddingTop: `${content.topPadding ?? 0}px`,
-    paddingBottom: `${content.bottomPadding ?? 0}px`,
-});

package/lib/src/brand-page/utils/migration/migration-17.d.ts

@@ -1,2 +0,0 @@
-import type { MigrationData } from '../migration.util';
-export declare const migration17: (migrationResult: MigrationData) => Promise<MigrationData>;

package/lib/src/brand-page/utils/migration/migration-17.js

@@ -1,48 +0,0 @@
-import { CONTACT_FORM_LAYOUT_DEFAULT_PADDING, bannerDisplayStyleDefaultPadding, } from '../../constants';
-/**
- * Padding Control backfill (BP-5699 Tier 2, BP-5700 Store): blocks that already
- * had hard-coded top/bottom spacing. Backfill that spacing as the block's explicit
- * topPadding/bottomPadding so existing pages render unchanged once the spacing
- * moves to the Padding Control sliders. Type-scoped and idempotent — only the
- * listed types, and only when the value isn't already set.
- */
-const BLOCK_DEFAULT_PADDING = {
-    text: 12,
-    'images-section': 32,
-    'social-links': 32,
-    'shapes-section': 32,
-    'booking-section': 32,
-    'shop-section': 16,
-    'about-section': 32,
-};
-export const migration17 = async (migrationResult) => {
-    const { brandPageModel } = migrationResult;
-    brandPageModel.pages.forEach((page) => {
-        page.contents.forEach((content) => {
-            // Contact Form and Banner previously varied their hard-coded spacing by
-            // layout/display style (full-bleed image layouts had no outer padding), so they're
-            // keyed by that rather than a single per-type value.
-            let value;
-            if (content.type === 'contact-form') {
-                value =
-                    CONTACT_FORM_LAYOUT_DEFAULT_PADDING[content.layoutStyle ?? ''];
-            }
-            else if (content.type === 'banner-section') {
-                value = bannerDisplayStyleDefaultPadding(content.displayStyle);
-            }
-            else {
-                value = BLOCK_DEFAULT_PADDING[content.type];
-            }
-            if (value === undefined) {
-                return;
-            }
-            if (content.topPadding === undefined) {
-                content.topPadding = value;
-            }
-            if (content.bottomPadding === undefined) {
-                content.bottomPadding = value;
-            }
-        });
-    });
-    return migrationResult;
-};

package/src/brand-page/utils/content-padding.util.test.ts

@@ -1,29 +0,0 @@
-import { describe, test, expect } from 'vitest';
-import { contentPaddingStyle } from './content-padding.util';
-
-describe('content-padding.util', () => {
-  test('contentPaddingStyle should map stored padding to px values', () => {
-    expect(contentPaddingStyle({ topPadding: 53, bottomPadding: 24 })).toEqual({
-      paddingTop: '53px',
-      paddingBottom: '24px',
-    });
-  });
-
-  test('contentPaddingStyle should default missing values to 0 for content created before the field existed', () => {
-    expect(contentPaddingStyle({})).toEqual({
-      paddingTop: '0px',
-      paddingBottom: '0px',
-    });
-    expect(contentPaddingStyle({ topPadding: 16 })).toEqual({
-      paddingTop: '16px',
-      paddingBottom: '0px',
-    });
-  });
-
-  test('contentPaddingStyle should keep an explicit 0 rather than treating it as unset', () => {
-    expect(contentPaddingStyle({ topPadding: 0, bottomPadding: 0 })).toEqual({
-      paddingTop: '0px',
-      paddingBottom: '0px',
-    });
-  });
-});

package/src/brand-page/utils/content-padding.util.ts

@@ -1,13 +0,0 @@
-/**
- * Block top/bottom padding (BP-5687) as a bindable CSS style object. Defaults
- * live in the data — `content-settings` for new content, a migration for
- * existing — so this just reads the stored value (`?? 0` covers content from
- * before the field existed).
- */
-export const contentPaddingStyle = (content: {
-  topPadding?: number;
-  bottomPadding?: number;
-}): { paddingTop: string; paddingBottom: string } => ({
-  paddingTop: `${content.topPadding ?? 0}px`,
-  paddingBottom: `${content.bottomPadding ?? 0}px`,
-});

package/src/brand-page/utils/migration/migration-17.ts

@@ -1,65 +0,0 @@
-import type { MigrationData } from '../migration.util';
-import type { BannerSectionContent, ContactFormContent } from '../../models';
-import {
-  CONTACT_FORM_LAYOUT_DEFAULT_PADDING,
-  bannerDisplayStyleDefaultPadding,
-} from '../../constants';
-
-/**
- * Padding Control backfill (BP-5699 Tier 2, BP-5700 Store): blocks that already
- * had hard-coded top/bottom spacing. Backfill that spacing as the block's explicit
- * topPadding/bottomPadding so existing pages render unchanged once the spacing
- * moves to the Padding Control sliders. Type-scoped and idempotent — only the
- * listed types, and only when the value isn't already set.
- */
-const BLOCK_DEFAULT_PADDING: Partial<Record<string, number>> = {
-  text: 12,
-  'images-section': 32,
-  'social-links': 32,
-  'shapes-section': 32,
-  'booking-section': 32,
-  'shop-section': 16,
-  'about-section': 32,
-};
-
-export const migration17 = async (
-  migrationResult: MigrationData,
-): Promise<MigrationData> => {
-  const { brandPageModel } = migrationResult;
-
-  brandPageModel.pages.forEach((page) => {
-    page.contents.forEach((content) => {
-      // Contact Form and Banner previously varied their hard-coded spacing by
-      // layout/display style (full-bleed image layouts had no outer padding), so they're
-      // keyed by that rather than a single per-type value.
-      let value: number | undefined;
-
-      if (content.type === 'contact-form') {
-        value =
-          CONTACT_FORM_LAYOUT_DEFAULT_PADDING[
-            (content as ContactFormContent).layoutStyle ?? ''
-          ];
-      } else if (content.type === 'banner-section') {
-        value = bannerDisplayStyleDefaultPadding(
-          (content as BannerSectionContent).displayStyle,
-        );
-      } else {
-        value = BLOCK_DEFAULT_PADDING[content.type];
-      }
-
-      if (value === undefined) {
-        return;
-      }
-
-      if (content.topPadding === undefined) {
-        content.topPadding = value;
-      }
-
-      if (content.bottomPadding === undefined) {
-        content.bottomPadding = value;
-      }
-    });
-  });
-
-  return migrationResult;
-};

package/src/brand-page-maker/convertors/contact-layout-style.convertor.test.ts

@@ -1,50 +0,0 @@
-import { describe, test, expect } from 'vitest';
-import { contactLayoutStyleConvertor } from './contact-layout-style.convertor';
-import {
-  ALIGN_CENTERED,
-  ALIGN_CARD_CENTER,
-  ALIGN_CARD_CENTER_IMAGE,
-  ALIGN_LEFT_FULL_IMAGE,
-  TEXT_ONLY,
-} from '@brand-page/constants';
-
-const configWithSelected = (selected: string) => ({
-  options: contactLayoutStyleConvertor
-    .convert(selected)
-    .options.map((option) => ({
-      ...option,
-      isSelected: option.value === selected,
-    })),
-});
-
-describe('contact-layout-style.convertor', () => {
-  test.each([
-    [ALIGN_CARD_CENTER, 32, 'center'],
-    [ALIGN_CENTERED, 32, 'center'],
-    [ALIGN_CARD_CENTER_IMAGE, 0, 'center'],
-    [TEXT_ONLY, 32, 'left'],
-    [ALIGN_LEFT_FULL_IMAGE, 0, 'left'],
-  ])(
-    'convertBack should apply the default padding and text alignment for %s',
-    (layoutStyle, padding, textAlign) => {
-      const result = contactLayoutStyleConvertor.convertBack(
-        configWithSelected(layoutStyle),
-      );
-
-      expect(result).toStrictEqual({
-        layoutStyle,
-        topPadding: padding,
-        bottomPadding: padding,
-        titleStyle: {
-          textAlign,
-        },
-        descriptionStyle: {
-          textAlign,
-        },
-        buttonTextStyle: {
-          textAlign: 'center',
-        },
-      });
-    },
-  );
-});