@design-core/core 0.0.6 → 50.1.0

package/.eslintrc.json

@@ -9,10 +9,14 @@
         "ecmaVersion": "latest",
         "sourceType": "module"
     },
+    "plugins": [
+        "import"
+    ],
     "rules": {
         "require-jsdoc": 2,
         "valid-jsdoc": 2,
         "max-len": 0,
+        "import/first": "error",
         "function-paren-newline": "warn",
         "object-curly-spacing": [
             "error",

package/.github/workflows/DesignCoreQA.yml

@@ -27,6 +27,9 @@ jobs:
         node-version: ${{ matrix.node-version }}
         cache: 'npm'
 
+    - name: Spell Check
+      run: npx cspell "**/*.{js,md}" --no-progress
+
     - name: Circular Dependency Check
       run: npx madge --circular --extensions js .
 

package/TODO.md

@@ -1,12 +1,6 @@
 # Design-Core TODO list
 
 ## Beta
-### UNDO / REDO
-
-### Printing
-
-### Export PDF
-
 ### Paperspace
 
 ### Entity Editing
@@ -17,3 +11,52 @@
 - Radial Dimension
 - Diametric Dimension
 
+### Text sizing
+- Text size - need a non-hacky glyph-advance measuring API on each the renderer
+- ArcAlignedText characterSpacing=0 overlap — Cairo's cap-height correction scales glyph advances wider than getApproximateWidth predicts;
+
+### performance optimisation
+
+#### 1. `LType.getPattern(scale)` — cache the scaled array (easy)
+Called once per entity per frame. Currently allocates a new array every call via `.map()`.
+A two-field cache (`#lastScale`, `#cachedPattern`) returns the existing array when scale hasn't changed.
+
+- **Effort**: ~10 lines, isolated to `ltype.js`
+- **Expected gain**: small but consistent; removes N allocations per frame where N = entity count
+
+#### 2. State dedup in renderers — skip no-op `setColour`/`setLineWidth`/`setDash` calls (medium)
+`setContext` is called unconditionally for every entity. For entities sharing colour and line width (the common case), the underlying Canvas/Cairo API calls are redundant.
+Track the last-set value in each renderer and return early when unchanged.
+
+- **Effort**: ~20 lines per renderer, self-contained
+- **Expected gain**: meaningful for large scenes with many same-layer entities; could save 10–30% of state-setting overhead
+
+#### 3. Skip `save()`/`restore()` for leaf entities (medium)
+`#paintEntity` wraps every entity in `save()`/`restore()` even though only container entities (Insert, BaseDimension) actually change the transform. Requires an `entity.isContainer` flag or restructuring to save lazily.
+
+- **Effort**: entity API change + `#paintEntity` refactor
+- **Expected gain**: ~1 `save`/`restore` pair eliminated per leaf entity per frame; measurable at high entity counts
+
+#### 4. Offscreen canvas for static scene (large, architectural)
+The full scene repaints on every mouse move (hover detection, rubber band, cursor). Splitting into a static layer (repaint on data change only) and a dynamic overlay (hover, preview, selection) would eliminate most per-frame work.
+
+- **Effort**: significant — touches `canvas.js`, rendering pipeline, and UI integration
+- **Expected gain**: potentially 3–5× frame rate improvement during mouse movement over a complex scene
+
+#### 5. Viewport culling — skip entities outside the visible area (medium, high impact when zoomed in)
+Every entity already has `boundingBox()` and `canvas.getSceneOffset()` returns the visible scene rectangle.
+A simple AABB overlap test in `#paintEntities` would skip entities outside the viewport before calling `#paintEntity`.
+
+- **Effort**: ~10 lines in `#paintEntities`; call `getSceneOffset()` once per `paint()` and pass it in
+
+- **Caveat — bounding box caching**: `Hatch.boundingBox()` and `Block.boundingBox()` iterate all child entities on every call. Per-frame culling cost could exceed draw cost for those types unless bboxes are cached on the entity and invalidated on edit. Simple entity types (Line, Circle, Arc) have trivial bbox cost and benefit immediately.
+
+- **Caveat — Text**: `Text.boundingBox()` depends on `boundingRect` which is only populated after the first `draw()` call — needs a fallback to avoid incorrectly culling undrawn text.
+
+- **Expected gain**: negligible when fully zoomed out; potentially 5–50× reduction in draw calls when working zoomed into a small area of a large drawing
+
+### Test clean up
+- Have the renderer changes provided any opportunity to clean up tests
+- Is there opportunity for extended testing with the mock renderer
+
+

package/core/core/core.js

@@ -24,9 +24,6 @@ import { Logging } from '../lib/logging.js';
 
 import { DesignCore } from '../designCore.js';
 
-// re-export core components for external use
-export { Patterns } from '../lib/patterns.js';
-
 /** Class representing design core. This is the primary entry point */
 export class Core {
   /** Create a core object */

package/core/designCore.js

@@ -11,7 +11,7 @@
    import {Core} from "core.js";
    import {DesignCore} from "designCore.js";
 
-   // Core must be instanciated and activated before use:
+   // Core must be instantiated and activated before use:
    const core = new Core()
    core.activate()
 

package/core/dimensions/alignedDimension.js

@@ -4,16 +4,17 @@ import { Input, PromptOptions } from '../lib/inputManager.js';
 import { Logging } from '../lib/logging.js';
 import { DXFFile } from '../lib/dxf/dxfFile.js';
 import { Point } from '../entities/point.js';
-import { BaseLinearDimension } from './baseLinearDimension.js';
+import { LinearDimensionBase } from './linearDimensionBase.js';
 
 import { DesignCore } from '../designCore.js';
+import { Property } from '../properties/property.js';
 
 
 /**
  * Aligned Dimension Entity Class
  * @extends LinearDimension
  */
-export class AlignedDimension extends BaseLinearDimension {
+export class AlignedDimension extends LinearDimensionBase {
   /**
    * Create an Aligned Dimension
    * @param {Array} data
@@ -42,7 +43,7 @@ export class AlignedDimension extends BaseLinearDimension {
   async execute() {
     try {
       DesignCore.Scene.selectionManager.reset();
-      this.dimensionStyle = DesignCore.DimStyleManager.getCstyle();
+      this.setProperty(Property.Names.DIMENSIONSTYLE, DesignCore.DimStyleManager.getCstyle());
       this.dimType.setDimType(1); // Aligned dimension
 
       const op = new PromptOptions(Strings.Input.START, [Input.Type.POINT]);
@@ -71,19 +72,19 @@ export class AlignedDimension extends BaseLinearDimension {
 
   /**
      * Get sequenced points from user selection
-     * @param {any} items
+     * @param {any} entities
      * @param {Point} textPos
      * @return {Array} array of points
      */
-  static getPointsFromSelection(items, textPos) {
+  static getPointsFromSelection(entities, textPos) {
     const points = [];
-    const item = items[0];
+    const entity = entities[0];
 
-    const Pt13 = item.points[0];
+    const Pt13 = entity.points[0];
     Pt13.sequence = 13;
     points.push(Pt13);
 
-    const Pt14 = item.points[1];
+    const Pt14 = entity.points[1];
     Pt14.sequence = 14;
     points.push(Pt14);
 
@@ -118,10 +119,10 @@ export class AlignedDimension extends BaseLinearDimension {
     const Pt14 = this.getPointBySequence(this.points, 14);
 
     file.writeGroupCode('0', 'DIMENSION');
-    file.writeGroupCode('5', this.handle, DXFFile.Version.R2000); // Handle
+    file.writeGroupCode('5', this.getProperty(Property.Names.HANDLE), DXFFile.Version.R2000); // Handle
     file.writeGroupCode('100', 'AcDbEntity', DXFFile.Version.R2000);
     file.writeGroupCode('100', 'AcDbDimension', DXFFile.Version.R2000);
-    file.writeGroupCode('8', this.layer);
+    file.writeGroupCode('8', this.getProperty(Property.Names.LAYER));
     // file.writeGroupCode('2', this.blockName);  // Block not required
     file.writeGroupCode('10', Pt10.x); // X - definition / arrow point
     file.writeGroupCode('20', Pt10.y); // Y
@@ -130,7 +131,7 @@ export class AlignedDimension extends BaseLinearDimension {
     file.writeGroupCode('21', Pt11.y); // Y
     file.writeGroupCode('31', '0.0'); // Z
     file.writeGroupCode('70', this.dimType.getDimType()); // DIMENSION TYPE
-    file.writeGroupCode('3', this.dimensionStyle); // DIMENSION STYLE
+    file.writeGroupCode('3', this.getProperty(Property.Names.DIMENSIONSTYLE)); // DIMENSION STYLE
     file.writeGroupCode('100', 'AcDbAlignedDimension', DXFFile.Version.R2000);
     file.writeGroupCode('13', Pt13.x); // X - start point of first extension line
     file.writeGroupCode('23', Pt13.y); // Y

package/core/dimensions/angularDimension.js

@@ -2,24 +2,25 @@
 import { Utils } from '../lib/utils.js';
 import { Strings } from '../lib/strings.js';
 import { Arc } from '../entities/arc.js';
-import { BasePolyline } from '../entities/basePolyline.js';
+import { PolylineBase } from '../entities/polylineBase.js';
 import { Line } from '../entities/line.js';
 import { Input, PromptOptions } from '../lib/inputManager.js';
 import { Logging } from '../lib/logging.js';
 import { DXFFile } from '../lib/dxf/dxfFile.js';
-import { BaseDimension } from './baseDimension.js';
+import { DimensionBase } from './dimensionBase.js';
 import { Intersection } from '../lib/intersect.js';
 import { Point } from '../entities/point.js';
 
 import { Text } from '../entities/text.js'; // used to debug the dimension points
 
 import { DesignCore } from '../designCore.js';
+import { Property } from '../properties/property.js';
 
 /**
  * Angular Dimension Entity Class
- * @extends BaseDimension
+ * @extends DimensionBase
  */
-export class AngularDimension extends BaseDimension {
+export class AngularDimension extends DimensionBase {
   /**
    * Create an Angular Dimension
    * @param {Array} data
@@ -47,7 +48,7 @@ export class AngularDimension extends BaseDimension {
    */
   async execute() {
     try {
-      this.dimensionStyle = DesignCore.DimStyleManager.getCstyle();
+      this.setProperty(Property.Names.DIMENSIONSTYLE, DesignCore.DimStyleManager.getCstyle());
       this.dimType.setDimType(2); // Angular dimension
 
       let Pt10;
@@ -61,25 +62,25 @@ export class AngularDimension extends BaseDimension {
 
         const op = new PromptOptions(Strings.Input.SELECT, [Input.Type.SINGLESELECTION]);
         const selection = await DesignCore.Scene.inputManager.requestInput(op);
-        let selectedItem = DesignCore.Scene.entities.get(selection.selectedItemIndex);
+        let selectedEntity = DesignCore.Scene.entities.get(selection.selectedEntityIndex);
 
-        if ([Line, BasePolyline].some((entity) => selectedItem instanceof entity)) {
-          if (selectedItem instanceof BasePolyline) {
+        if ([Line, PolylineBase].some((entity) => selectedEntity instanceof entity)) {
+          if (selectedEntity instanceof PolylineBase) {
             // get the segment closest to the mouse point
-            const segment = selectedItem.getClosestSegment(selection.selectedPoint);
+            const segment = selectedEntity.getClosestSegment(selection.selectedPoint);
 
             if (segment instanceof Line) {
-              // update the selected item to be the polyline arc segment
-              selectedItem = segment;
+              // update the selected entity to be the polyline arc segment
+              selectedEntity = segment;
             }
           }
 
-          if (selectedItem instanceof Line) {
-            Pt15 = selectedItem.points[0];
+          if (selectedEntity instanceof Line) {
+            Pt15 = selectedEntity.points[0];
             Pt15.sequence = 15;
             this.points.push(Pt15);
 
-            Pt10 = selectedItem.points[1];
+            Pt10 = selectedEntity.points[1];
             Pt10.sequence = 10;
             this.points.push(Pt10);
           }
@@ -90,24 +91,24 @@ export class AngularDimension extends BaseDimension {
         DesignCore.Scene.selectionManager.reset();
         const op1 = new PromptOptions(Strings.Input.SELECT, [Input.Type.SINGLESELECTION]);
         const selection2 = await DesignCore.Scene.inputManager.requestInput(op1);
-        let selectedItem = DesignCore.Scene.entities.get(selection2.selectedItemIndex);
+        let selectedEntity = DesignCore.Scene.entities.get(selection2.selectedEntityIndex);
 
-        if ([Line, BasePolyline].some((entity) => selectedItem instanceof entity)) {
-          if (selectedItem instanceof BasePolyline) {
+        if ([Line, PolylineBase].some((entity) => selectedEntity instanceof entity)) {
+          if (selectedEntity instanceof PolylineBase) {
             // get the segment closest to the mouse point
-            const segment = selectedItem.getClosestSegment(selection2.selectedPoint);
+            const segment = selectedEntity.getClosestSegment(selection2.selectedPoint);
 
             if (segment instanceof Line) {
-              // update the selected item to be the polyline arc segment
-              selectedItem = segment;
+              // update the selected entity to be the polyline arc segment
+              selectedEntity = segment;
             }
           }
-          if (selectedItem instanceof Line) {
-            Pt13 = selectedItem.points[0];
+          if (selectedEntity instanceof Line) {
+            Pt13 = selectedEntity.points[0];
             Pt13.sequence = 13;
             this.points.push(Pt13);
 
-            Pt14 = selectedItem.points[1];
+            Pt14 = selectedEntity.points[1];
             Pt14.sequence = 14;
             this.points.push(Pt14);
           }
@@ -146,29 +147,29 @@ export class AngularDimension extends BaseDimension {
 
       const points = AngularDimension.getPointsFromSelection([tempLineOne, tempLineTwo], Pt11);
 
-      DesignCore.Scene.tempEntities.create(this.type, { points: points, dimensionStyle: this.dimensionStyle });
+      DesignCore.Scene.previewEntities.create(this.type, { points: points, dimensionStyle: this.getProperty(Property.Names.DIMENSIONSTYLE) });
     }
   }
 
   /**
    * Get sequenced points from user selection
-   * @param {any} items
+   * @param {any} entities
    * @param {Point} textPos
    * @return {Array} array of points
    */
-  static getPointsFromSelection(items, textPos) {
-  // Transform the items into points
-  // Do nothing more than transform the items into points
+  static getPointsFromSelection(entities, textPos) {
+  // Transform the entities into points
+  // Do nothing more than transform the entities into points
 
     const points = [];
-    const item1 = items[0];
-    const item2 = items[1];
+    const entity1 = entities[0];
+    const entity2 = entities[1];
 
-    const tempPt15 = item1.points[0];
-    const tempPt10 = item1.points[1];
+    const tempPt15 = entity1.points[0];
+    const tempPt10 = entity1.points[1];
 
-    const tempPt13 = item2.points[0];
-    const tempPt14 = item2.points[1];
+    const tempPt13 = entity2.points[0];
+    const tempPt14 = entity2.points[1];
 
     // Check the lines intersect
     const intersect = Intersection.intersectSegmentSegment(tempPt15, tempPt10, tempPt13, tempPt14, false, true);
@@ -520,10 +521,10 @@ export class AngularDimension extends BaseDimension {
     const Pt16 = this.getPointBySequence(this.points, 16);
 
     file.writeGroupCode('0', 'DIMENSION');
-    file.writeGroupCode('5', this.handle, DXFFile.Version.R2000); // Handle
+    file.writeGroupCode('5', this.getProperty(Property.Names.HANDLE), DXFFile.Version.R2000); // Handle
     file.writeGroupCode('100', 'AcDbEntity', DXFFile.Version.R2000);
     file.writeGroupCode('100', 'AcDbDimension', DXFFile.Version.R2000);
-    file.writeGroupCode('8', this.layer);
+    file.writeGroupCode('8', this.getProperty(Property.Names.LAYER));
     // file.writeGroupCode('2', this.blockName); // Block not required
     file.writeGroupCode('10', Pt10.x); // X - Start of Dimension Line
     file.writeGroupCode('20', Pt10.y); // Y
@@ -532,7 +533,7 @@ export class AngularDimension extends BaseDimension {
     file.writeGroupCode('21', Pt11.y); // Y
     file.writeGroupCode('31', '0.0'); // Z
     file.writeGroupCode('70', this.dimType.getDimType()); // DIMENSION TYPE
-    file.writeGroupCode('3', this.dimensionStyle); // DIMENSION STYLE
+    file.writeGroupCode('3', this.getProperty(Property.Names.DIMENSIONSTYLE)); // DIMENSION STYLE
     file.writeGroupCode('100', 'AcDb2LineAngularDimension', DXFFile.Version.R2000);
     file.writeGroupCode('13', Pt13.x); // X
     file.writeGroupCode('23', Pt13.y); // Y

package/core/dimensions/{baseCircularDimension.js → circularDimensionBase.js}

@@ -1,23 +1,24 @@
 import { Strings } from '../lib/strings.js';
 import { Circle } from '../entities/circle.js';
 import { Arc } from '../entities/arc.js';
-import { BasePolyline } from '../entities/basePolyline.js';
+import { PolylineBase } from '../entities/polylineBase.js';
 import { Line } from '../entities/line.js';
 import { Text } from '../entities/text.js';
 import { Point } from '../entities/point.js';
 import { Intersection } from '../lib/intersect.js';
 import { Input, PromptOptions } from '../lib/inputManager.js';
 import { Logging } from '../lib/logging.js';
-import { BaseDimension } from './baseDimension.js';
+import { DimensionBase } from './dimensionBase.js';
 
 import { DesignCore } from '../designCore.js';
+import { Property } from '../properties/property.js';
 
 
 /**
  * Base Class for Circular Dimensions - Radius and Diameter
- * @extends BaseDimension
+ * @extends DimensionBase
  */
-export class BaseCircularDimension extends BaseDimension {
+export class CircularDimensionBase extends DimensionBase {
   /**
    * Circular Dimension Constructor
    * @param {Array} data
@@ -32,7 +33,7 @@ export class BaseCircularDimension extends BaseDimension {
    */
   async execute() {
     try {
-      this.dimensionStyle = DesignCore.DimStyleManager.getCstyle();
+      this.setProperty(Property.Names.DIMENSIONSTYLE, DesignCore.DimStyleManager.getCstyle());
 
       let Pt10;
       let Pt15;
@@ -43,25 +44,25 @@ export class BaseCircularDimension extends BaseDimension {
         const op = new PromptOptions(Strings.Input.SELECT, [Input.Type.SINGLESELECTION]);
         const selection = await DesignCore.Scene.inputManager.requestInput(op);
 
-        let selectedItem = DesignCore.Scene.entities.get(selection.selectedItemIndex);
+        let selectedEntity = DesignCore.Scene.entities.get(selection.selectedEntityIndex);
 
-        if ([Circle, Arc, BasePolyline].some((entity) => selectedItem instanceof entity)) {
-          if (selectedItem instanceof BasePolyline) {
+        if ([Circle, Arc, PolylineBase].some((entity) => selectedEntity instanceof entity)) {
+          if (selectedEntity instanceof PolylineBase) {
             // get the segment closest to the mouse point
-            const segment = selectedItem.getClosestSegment(selection.selectedPoint);
+            const segment = selectedEntity.getClosestSegment(selection.selectedPoint);
 
             if (segment instanceof Arc) {
-              // update the selected item to be the polyline arc segment
-              selectedItem = segment;
+              // update the selected entity to be the polyline arc segment
+              selectedEntity = segment;
             }
           }
 
-          if (selectedItem instanceof Circle || selectedItem instanceof Arc) {
-            Pt15 = selectedItem.points[1];
+          if (selectedEntity instanceof Circle || selectedEntity instanceof Arc) {
+            Pt15 = selectedEntity.points[1];
             Pt15.sequence = 15;
             this.points.push(Pt15);
 
-            Pt10 = selectedItem.points[0];
+            Pt10 = selectedEntity.points[0];
             Pt10.sequence = 10;
             this.points.push(Pt10);
           }
@@ -96,7 +97,7 @@ export class BaseCircularDimension extends BaseDimension {
       const tempCircle = new Circle({ points: [Pt10, Pt15] });
       const points = this.constructor.getPointsFromSelection([tempCircle], Pt11);
 
-      DesignCore.Scene.tempEntities.create(this.type, { points: points });
+      DesignCore.Scene.previewEntities.create(this.type, { points: points });
     }
   }
 
@@ -110,7 +111,7 @@ export class BaseCircularDimension extends BaseDimension {
     const entities = [];
 
     const Pt15 = this.getPointBySequence(this.points, 15); // radius point
-    const Pt10 = this.getPointBySequence(this.points, 10); // center point for radial dim or radial point for diameteric dim
+    const Pt10 = this.getPointBySequence(this.points, 10); // centre point for radial dim or radial point for diametric dim
     let Pt11 = this.getPointBySequence(this.points, 11); // text position
 
     // Style values
@@ -191,7 +192,7 @@ export class BaseCircularDimension extends BaseDimension {
 
     // DIMTAD - Text vertical position
     switch (DIMTAD) {
-      case 0: // 0 = Centers the dimension text between the extension lines.
+      case 0: // 0 = Centres the dimension text between the extension lines.
         break;
       case 1: // 1 = Places the dimension text above the dimension line except when the dimension line is not horizontal and text inside the extension lines is forced horizontal ( DIMTIH = 1).
         textPosition = textPosition.project(textAboveDirection, textAboveDistance);
@@ -230,13 +231,13 @@ export class BaseCircularDimension extends BaseDimension {
     if (!DIMTOFL) {
     // Add the centre mark for circular dimensions
 
-      let center = Pt10;
+      let centre = Pt10;
 
-      // center point is mid point for diametric dimensions
+      // centre point is mid point for diametric dimensions
       if (this.dimType.getBaseDimType() === 3) {
-        center = Pt10.midPoint(Pt15);
+        centre = Pt10.midPoint(Pt15);
       }
-      entities.push(...this.getCentreMark(center));
+      entities.push(...this.getCentreMark(centre));
     }
 
     return entities;

package/core/dimensions/diametricDimension.js

@@ -1,11 +1,12 @@
 import { DXFFile } from '../lib/dxf/dxfFile.js';
-import { BaseCircularDimension } from './baseCircularDimension.js';
+import { CircularDimensionBase } from './circularDimensionBase.js';
+import { Property } from '../properties/property.js';
 
 /**
  * Diametric Dimension Entity Class
- * @extends BaseCircularDimension
+ * @extends CircularDimensionBase
  */
-export class DiametricDimension extends BaseCircularDimension {
+export class DiametricDimension extends CircularDimensionBase {
   /**
    * Create a Diametric Dimension
    * @param {Array} data
@@ -29,22 +30,22 @@ export class DiametricDimension extends BaseCircularDimension {
 
   /**
    * Get sequenced points from user selection
-   * @param {any} items
+   * @param {any} entities
    * @param {Point} textPos
    * @return {Array} array of points
    */
-  static getPointsFromSelection(items, textPos) {
-    const item = items[0];
-    const center = item.points[0];
+  static getPointsFromSelection(entities, textPos) {
+    const entity = entities[0];
+    const centre = entity.points[0];
 
     const Pt11 = textPos;
     Pt11.sequence = 11;
 
-    const angle = Pt11.angle(center);
-    const Pt10 = center.project(angle, item.getRadius());
+    const angle = Pt11.angle(centre);
+    const Pt10 = centre.project(angle, entity.getRadius());
     Pt10.sequence = 10;
     // Pt15 should be closest point to the text position
-    const Pt15 = center.project(angle - Math.PI, item.getRadius());
+    const Pt15 = centre.project(angle - Math.PI, entity.getRadius());
     Pt15.sequence = 15;
 
     const points = [Pt10, Pt15, Pt11];
@@ -61,10 +62,10 @@ export class DiametricDimension extends BaseCircularDimension {
     const Pt15 = this.getPointBySequence(this.points, 15);
 
     file.writeGroupCode('0', 'DIMENSION');
-    file.writeGroupCode('5', this.handle, DXFFile.Version.R2000); // Handle
+    file.writeGroupCode('5', this.getProperty(Property.Names.HANDLE), DXFFile.Version.R2000); // Handle
     file.writeGroupCode('100', 'AcDbEntity', DXFFile.Version.R2000);
     file.writeGroupCode('100', 'AcDbDimension', DXFFile.Version.R2000);
-    file.writeGroupCode('8', this.layer);
+    file.writeGroupCode('8', this.getProperty(Property.Names.LAYER));
     // file.writeGroupCode('2', this.blockName); // Block not required
     file.writeGroupCode('10', Pt10.x); // X - Start of Dimension Line
     file.writeGroupCode('20', Pt10.y); // Y
@@ -73,7 +74,7 @@ export class DiametricDimension extends BaseCircularDimension {
     file.writeGroupCode('21', Pt11.y); // Y
     file.writeGroupCode('31', '0.0'); // Z
     file.writeGroupCode('70', this.dimType.getDimType()); // DIMENSION TYPE
-    file.writeGroupCode('3', this.dimensionStyle); // DIMENSION STYLE
+    file.writeGroupCode('3', this.getProperty(Property.Names.DIMENSIONSTYLE)); // DIMENSION STYLE
     file.writeGroupCode('100', 'AcDbDiametricDimension', DXFFile.Version.R2000);
     file.writeGroupCode('15', Pt15.x); // X - End of Dimension Line
     file.writeGroupCode('25', Pt15.y); // Y