@design-core/core 0.0.6 → 0.0.7

package/.eslintrc.json

@@ -9,10 +9,14 @@
         "ecmaVersion": "latest",
         "sourceType": "module"
     },
+    "plugins": [
+        "import"
+    ],
     "rules": {
         "require-jsdoc": 2,
         "valid-jsdoc": 2,
         "max-len": 0,
+        "import/first": "error",
         "function-paren-newline": "warn",
         "object-curly-spacing": [
             "error",

package/TODO.md

@@ -1,12 +1,6 @@
 # Design-Core TODO list
 
 ## Beta
-### UNDO / REDO
-
-### Printing
-
-### Export PDF
-
 ### Paperspace
 
 ### Entity Editing
@@ -17,3 +11,52 @@
 - Radial Dimension
 - Diametric Dimension
 
+### Text sizing
+- Text size - need a non-hacky glyph-advance measuring API on each the renderer
+- ArcAlignedText characterSpacing=0 overlap — Cairo's cap-height correction scales glyph advances wider than getApproximateWidth predicts;
+
+### performance optimisation
+
+#### 1. `LType.getPattern(scale)` — cache the scaled array (easy)
+Called once per entity per frame. Currently allocates a new array every call via `.map()`.
+A two-field cache (`#lastScale`, `#cachedPattern`) returns the existing array when scale hasn't changed.
+
+- **Effort**: ~10 lines, isolated to `ltype.js`
+- **Expected gain**: small but consistent; removes N allocations per frame where N = entity count
+
+#### 2. State dedup in renderers — skip no-op `setColour`/`setLineWidth`/`setDash` calls (medium)
+`setContext` is called unconditionally for every entity. For entities sharing colour and line width (the common case), the underlying Canvas/Cairo API calls are redundant.
+Track the last-set value in each renderer and return early when unchanged.
+
+- **Effort**: ~20 lines per renderer, self-contained
+- **Expected gain**: meaningful for large scenes with many same-layer entities; could save 10–30% of state-setting overhead
+
+#### 3. Skip `save()`/`restore()` for leaf entities (medium)
+`#paintEntity` wraps every entity in `save()`/`restore()` even though only container entities (Insert, BaseDimension) actually change the transform. Requires an `entity.isContainer` flag or restructuring to save lazily.
+
+- **Effort**: entity API change + `#paintEntity` refactor
+- **Expected gain**: ~1 `save`/`restore` pair eliminated per leaf entity per frame; measurable at high entity counts
+
+#### 4. Offscreen canvas for static scene (large, architectural)
+The full scene repaints on every mouse move (hover detection, rubber band, cursor). Splitting into a static layer (repaint on data change only) and a dynamic overlay (hover, preview, selection) would eliminate most per-frame work.
+
+- **Effort**: significant — touches `canvas.js`, rendering pipeline, and UI integration
+- **Expected gain**: potentially 3–5× frame rate improvement during mouse movement over a complex scene
+
+#### 5. Viewport culling — skip entities outside the visible area (medium, high impact when zoomed in)
+Every entity already has `boundingBox()` and `canvas.getSceneOffset()` returns the visible scene rectangle.
+A simple AABB overlap test in `#paintEntities` would skip entities outside the viewport before calling `#paintEntity`.
+
+- **Effort**: ~10 lines in `#paintEntities`; call `getSceneOffset()` once per `paint()` and pass it in
+
+- **Caveat — bounding box caching**: `Hatch.boundingBox()` and `Block.boundingBox()` iterate all child entities on every call. Per-frame culling cost could exceed draw cost for those types unless bboxes are cached on the entity and invalidated on edit. Simple entity types (Line, Circle, Arc) have trivial bbox cost and benefit immediately.
+
+- **Caveat — Text**: `Text.boundingBox()` depends on `boundingRect` which is only populated after the first `draw()` call — needs a fallback to avoid incorrectly culling undrawn text.
+
+- **Expected gain**: negligible when fully zoomed out; potentially 5–50× reduction in draw calls when working zoomed into a small area of a large drawing
+
+### Test clean up
+- Have the renderer changes provided any opportunity to clean up tests
+- Is there opportunity for extended testing with the mock renderer
+
+

package/core/core/core.js

@@ -24,9 +24,6 @@ import { Logging } from '../lib/logging.js';
 
 import { DesignCore } from '../designCore.js';
 
-// re-export core components for external use
-export { Patterns } from '../lib/patterns.js';
-
 /** Class representing design core. This is the primary entry point */
 export class Core {
   /** Create a core object */

package/core/dimensions/alignedDimension.js

@@ -7,6 +7,7 @@ import { Point } from '../entities/point.js';
 import { BaseLinearDimension } from './baseLinearDimension.js';
 
 import { DesignCore } from '../designCore.js';
+import { Property } from '../properties/property.js';
 
 
 /**
@@ -42,7 +43,7 @@ export class AlignedDimension extends BaseLinearDimension {
   async execute() {
     try {
       DesignCore.Scene.selectionManager.reset();
-      this.dimensionStyle = DesignCore.DimStyleManager.getCstyle();
+      this.setProperty(Property.Names.DIMENSIONSTYLE, DesignCore.DimStyleManager.getCstyle());
       this.dimType.setDimType(1); // Aligned dimension
 
       const op = new PromptOptions(Strings.Input.START, [Input.Type.POINT]);
@@ -118,10 +119,10 @@ export class AlignedDimension extends BaseLinearDimension {
     const Pt14 = this.getPointBySequence(this.points, 14);
 
     file.writeGroupCode('0', 'DIMENSION');
-    file.writeGroupCode('5', this.handle, DXFFile.Version.R2000); // Handle
+    file.writeGroupCode('5', this.getProperty(Property.Names.HANDLE), DXFFile.Version.R2000); // Handle
     file.writeGroupCode('100', 'AcDbEntity', DXFFile.Version.R2000);
     file.writeGroupCode('100', 'AcDbDimension', DXFFile.Version.R2000);
-    file.writeGroupCode('8', this.layer);
+    file.writeGroupCode('8', this.getProperty(Property.Names.LAYER));
     // file.writeGroupCode('2', this.blockName);  // Block not required
     file.writeGroupCode('10', Pt10.x); // X - definition / arrow point
     file.writeGroupCode('20', Pt10.y); // Y
@@ -130,7 +131,7 @@ export class AlignedDimension extends BaseLinearDimension {
     file.writeGroupCode('21', Pt11.y); // Y
     file.writeGroupCode('31', '0.0'); // Z
     file.writeGroupCode('70', this.dimType.getDimType()); // DIMENSION TYPE
-    file.writeGroupCode('3', this.dimensionStyle); // DIMENSION STYLE
+    file.writeGroupCode('3', this.getProperty(Property.Names.DIMENSIONSTYLE)); // DIMENSION STYLE
     file.writeGroupCode('100', 'AcDbAlignedDimension', DXFFile.Version.R2000);
     file.writeGroupCode('13', Pt13.x); // X - start point of first extension line
     file.writeGroupCode('23', Pt13.y); // Y

package/core/dimensions/angularDimension.js

@@ -14,6 +14,7 @@ import { Point } from '../entities/point.js';
 import { Text } from '../entities/text.js'; // used to debug the dimension points
 
 import { DesignCore } from '../designCore.js';
+import { Property } from '../properties/property.js';
 
 /**
  * Angular Dimension Entity Class
@@ -47,7 +48,7 @@ export class AngularDimension extends BaseDimension {
    */
   async execute() {
     try {
-      this.dimensionStyle = DesignCore.DimStyleManager.getCstyle();
+      this.setProperty(Property.Names.DIMENSIONSTYLE, DesignCore.DimStyleManager.getCstyle());
       this.dimType.setDimType(2); // Angular dimension
 
       let Pt10;
@@ -146,7 +147,7 @@ export class AngularDimension extends BaseDimension {
 
       const points = AngularDimension.getPointsFromSelection([tempLineOne, tempLineTwo], Pt11);
 
-      DesignCore.Scene.tempEntities.create(this.type, { points: points, dimensionStyle: this.dimensionStyle });
+      DesignCore.Scene.previewEntities.create(this.type, { points: points, dimensionStyle: this.getProperty(Property.Names.DIMENSIONSTYLE) });
     }
   }
 
@@ -520,10 +521,10 @@ export class AngularDimension extends BaseDimension {
     const Pt16 = this.getPointBySequence(this.points, 16);
 
     file.writeGroupCode('0', 'DIMENSION');
-    file.writeGroupCode('5', this.handle, DXFFile.Version.R2000); // Handle
+    file.writeGroupCode('5', this.getProperty(Property.Names.HANDLE), DXFFile.Version.R2000); // Handle
     file.writeGroupCode('100', 'AcDbEntity', DXFFile.Version.R2000);
     file.writeGroupCode('100', 'AcDbDimension', DXFFile.Version.R2000);
-    file.writeGroupCode('8', this.layer);
+    file.writeGroupCode('8', this.getProperty(Property.Names.LAYER));
     // file.writeGroupCode('2', this.blockName); // Block not required
     file.writeGroupCode('10', Pt10.x); // X - Start of Dimension Line
     file.writeGroupCode('20', Pt10.y); // Y
@@ -532,7 +533,7 @@ export class AngularDimension extends BaseDimension {
     file.writeGroupCode('21', Pt11.y); // Y
     file.writeGroupCode('31', '0.0'); // Z
     file.writeGroupCode('70', this.dimType.getDimType()); // DIMENSION TYPE
-    file.writeGroupCode('3', this.dimensionStyle); // DIMENSION STYLE
+    file.writeGroupCode('3', this.getProperty(Property.Names.DIMENSIONSTYLE)); // DIMENSION STYLE
     file.writeGroupCode('100', 'AcDb2LineAngularDimension', DXFFile.Version.R2000);
     file.writeGroupCode('13', Pt13.x); // X
     file.writeGroupCode('23', Pt13.y); // Y

package/core/dimensions/baseCircularDimension.js

@@ -11,6 +11,7 @@ import { Logging } from '../lib/logging.js';
 import { BaseDimension } from './baseDimension.js';
 
 import { DesignCore } from '../designCore.js';
+import { Property } from '../properties/property.js';
 
 
 /**
@@ -32,7 +33,7 @@ export class BaseCircularDimension extends BaseDimension {
    */
   async execute() {
     try {
-      this.dimensionStyle = DesignCore.DimStyleManager.getCstyle();
+      this.setProperty(Property.Names.DIMENSIONSTYLE, DesignCore.DimStyleManager.getCstyle());
 
       let Pt10;
       let Pt15;
@@ -96,7 +97,7 @@ export class BaseCircularDimension extends BaseDimension {
       const tempCircle = new Circle({ points: [Pt10, Pt15] });
       const points = this.constructor.getPointsFromSelection([tempCircle], Pt11);
 
-      DesignCore.Scene.tempEntities.create(this.type, { points: points });
+      DesignCore.Scene.previewEntities.create(this.type, { points: points });
     }
   }
 

package/core/dimensions/baseDimension.js

@@ -24,91 +24,67 @@ export class BaseDimension extends Entity {
   constructor(data) {
     super(data);
 
-    // hide inherited property
-    // needs to be enumerable=false to not appear in the object props
-    Object.defineProperty(this, 'lineType', {
-      enumerable: false,
+    // lineType and lineWidth not applicable to dimensions
+    this.properties.remove(Property.Names.LINETYPE);
+    this.properties.remove(Property.Names.LINEWIDTH);
+
+    // DXF Groupcode 1 - Dimension text override
+    this.properties.add(Property.Names.TEXTOVERRIDE, {
+      type: Property.Type.STRING,
+      value: Property.loadValue([data?.[1], data?.textOverride], ''),
+      dxfCode: 1,
     });
 
-    // hide inherited property
-    Object.defineProperty(this, 'lineWidth', {
-      enumerable: false,
+    // DXF Groupcode 2 - Block name
+    this.properties.add(Property.Names.BLOCKNAME, {
+      type: Property.Type.STRING,
+      value: Property.loadValue([data?.blockName, data?.[2]], ''),
+      dxfCode: 2,
+      visible: false,
     });
 
-    Object.defineProperty(this, 'blockName', {
-      value: '',
-      writable: true,
-    });
-
-    Object.defineProperty(this, 'block', {
-      value: new Block({ points: [new Point(), new Point()] }),
-      writable: true,
-    });
-
-    /*
-    Object.defineProperty(this, 'text', {
-      value: new Text(),
-      writable: true,
+    // DXF Groupcode 3 - Dimension Style Name
+    this.properties.add(Property.Names.DIMENSIONSTYLE, {
+      type: Property.Type.LIST,
+      value: Property.loadValue([data?.dimensionStyle, data?.[3]], 'STANDARD'),
+      dxfCode: 3,
     });
-    */
 
-    Object.defineProperty(this, 'textOverride', {
-      value: '',
-      writable: true,
-      enumerable: true,
+    // DXF Groupcode 40 - Leader length for radius and diameter dimensions
+    this.properties.add(Property.Names.LEADERLENGTH, {
+      type: Property.Type.NUMBER,
+      value: Property.loadValue([data?.[40], data?.leaderLength], 0),
+      dxfCode: 40,
+      visible: false,
     });
 
-    Object.defineProperty(this, 'dimType', {
-      value: new DimType(),
-      writable: true,
+    // DXF Groupcode 50 - Angle of rotated, horizontal, or vertical dimensions
+    this.properties.add(Property.Names.LINEARDIMANGLE, {
+      type: Property.Type.NUMBER,
+      value: Property.loadValue([data?.[50], data?.linearDimAngle], 0),
+      dxfCode: 50,
+      visible: false,
     });
 
-    Object.defineProperty(this, 'dimensionStyle', {
-      value: 'STANDARD',
-      writable: true,
-      enumerable: true,
+    // DXF Groupcode 53 - Rotation angle of dimension text away from default orientation
+    this.properties.add(Property.Names.ANGLE, {
+      type: Property.Type.NUMBER,
+      value: Property.loadValue([data?.[53], data?.angle], 0),
+      dxfCode: 53,
+      visible: false,
     });
 
-    Object.defineProperty(this, 'leaderLength', {
-      value: 0,
+    Object.defineProperty(this, 'block', {
+      value: new Block({ points: [new Point(), new Point()] }),
       writable: true,
     });
 
-    Object.defineProperty(this, 'linearDimAngle', {
-      value: 0,
+    Object.defineProperty(this, 'dimType', {
+      value: new DimType(),
       writable: true,
     });
 
     if (data) {
-      if (data.hasOwnProperty('1')) {
-        // DXF Groupcode 1 - Dimension text
-        // The string explicitly entered by the user.
-        // Optional; default is the measurement. If null or “<>”, the dimension measurement is drawn as the text,
-        // if ““ (one blank space), the text is suppressed. Anything else is drawn as the text
-        this.textOverride = Property.loadValue([data[1], data.textOverride], '');
-      }
-
-      /*
-      if (data.hasOwnProperty('block')) {
-        // Reference to block that contains the entities that make up this dimension
-        this.block = data.block;
-      }*/
-
-      if (data.hasOwnProperty('blockName') || data.hasOwnProperty('2')) {
-        // DXF Groupcode 2 - Blockname
-        this.blockName = Property.loadValue([data.blockName, data[2]], '');
-      }
-
-      if (data.hasOwnProperty('dimensionStyle') || data.hasOwnProperty('3')) {
-        // DXF Groupcode 3 - Dimension Style Name
-        this.dimensionStyle = Property.loadValue([data.dimensionStyle, data[3]], 'STANDARD');
-      }
-
-      if (data.hasOwnProperty('40')) {
-        // DXF Groupcode 40 - Leader length for radius and diameter dimensions
-        this.leaderLength = data[40];
-      }
-
       if (data.hasOwnProperty('41')) {
         // DXF Groupcode 41 - Line Spacing Factor
         // Percentage of default (3-on-5) line spacing to be applied.
@@ -124,11 +100,6 @@ export class BaseDimension extends Entity {
         Logging.instance.debug(`${this.type} - ${err}`);
       }
 
-      if (data.hasOwnProperty('50')) {
-        // DXF Groupcode 50 - Angle of rotated, horizontal, or vertical dimensions
-        this.linearDimAngle = Property.loadValue([data[50]], 0);
-      }
-
       if (data.hasOwnProperty('51')) {
         // DXF Groupcode 51 - Horizontal Direction
         // All dimension types have an optional 51 group code, which indicates the horizontal direction
@@ -140,12 +111,6 @@ export class BaseDimension extends Entity {
         Logging.instance.warn(`${this.type} - ${err}`);
       }
 
-      if (data.hasOwnProperty('angle') || data.hasOwnProperty('53')) {
-        // DXF Groupcode 53 - Rotation
-        // rotation angle of the dimension text away from its default orientation
-        this.angle = Property.loadValue([data.angle, data[53]], 0);
-      }
-
       if (data.hasOwnProperty('dimType') || data.hasOwnProperty('70')) {
         // DXF Groupcode 70 - Dimension Type
         // Values 0-6 are integer values that represent the dimension type. Values 32, 64, and 128
@@ -197,10 +162,6 @@ export class BaseDimension extends Entity {
         const err = 'Groupcode 72 not implemented';
         Logging.instance.debug(`${this.type} - ${err}`);
       }
-
-      if (data.leaderLength) {
-        this.leaderLength = data.leaderLength;
-      }
     }
   }
 
@@ -280,8 +241,9 @@ export class BaseDimension extends Entity {
     }
 
     // Handle textOverride
-    if (this.textOverride !== '') {
-      formattedDimensionValue = this.textOverride.replace(/<>/g, formattedDimensionValue);
+    const textOverride = this.getProperty(Property.Names.TEXTOVERRIDE);
+    if (textOverride !== '') {
+      formattedDimensionValue = textOverride.replace(/<>/g, formattedDimensionValue);
     }
 
     // TODO: Implement prefix and postsuffix - DIMPOST
@@ -338,13 +300,13 @@ export class BaseDimension extends Entity {
     // get the text height
     const textHeight = this.getDimensionStyle().getValue('DIMTXT');
     // set the text height
-    text.height = textHeight;
+    text.setProperty(Property.Names.HEIGHT, textHeight);
     // Always set text horizontal alignment to center
-    text.horizontalAlignment = 1;
+    text.setProperty(Property.Names.HORIZONTALALIGNMENT, 1);
     // Always set text vertical alignment to middle
-    text.verticalAlignment = 2;
+    text.setProperty(Property.Names.VERTICALALIGNMENT, 2);
     // set the text value
-    text.string = this.getDimensionValue(textValue);
+    text.setProperty(Property.Names.STRING, this.getDimensionValue(textValue));
     // set the text position
     text.points = [textPosition];
     // set the text rotation
@@ -385,7 +347,7 @@ export class BaseDimension extends Entity {
    * @return {Object} - the dimension style object
    */
   getDimensionStyle() {
-    return DesignCore.DimStyleManager.getItemByName(this.dimensionStyle);
+    return DesignCore.DimStyleManager.getItemByName(this.getProperty(Property.Names.DIMENSIONSTYLE));
   }
 
   /**
@@ -470,15 +432,15 @@ export class BaseDimension extends Entity {
 
   /**
    * Draw the entity
-   * @param {Object} ctx - context
-   * @param {number} scale
+   * @param {Object} renderer
+   * @return {Array} block items for the canvas to render recursively
    */
-  draw(ctx, scale) {
+  draw(renderer) {
     if (this.block.items.length === 0) {
       this.refresh();
     }
 
-    this.block.draw(ctx, scale, this);
+    return this.block.items;
   }
 
   /**
@@ -538,7 +500,7 @@ export class BaseDimension extends Entity {
 
       entities.forEach((element) => {
         // For colour BYBLOCK for dimensions
-        element.setColour('BYBLOCK');
+        element.setProperty(Property.Names.COLOUR, 'BYBLOCK');
         this.block.addItem(element);
       });
     }
@@ -550,6 +512,10 @@ export class BaseDimension extends Entity {
    * @param {any} value
    */
   setProperty(property, value) {
+    if (this.properties.has(property)) {
+      super.setProperty(property, value);
+      return;
+    }
     if (this.hasOwnProperty(property)) {
       this[property] = value;
       this.refresh();

package/core/dimensions/baseLinearDimension.js

@@ -7,7 +7,9 @@ import { BaseDimension } from './baseDimension.js';
 import { Point } from '../entities/point.js';
 
 import { DesignCore } from '../designCore.js';
+import { Property } from '../properties/property.js';
 import { Utils } from '../lib/utils.js';
+import { RubberBand } from '../lib/auxiliary/rubberBand.js';
 
 /**
  * Aligned Dimension Entity Class
@@ -29,7 +31,7 @@ export class BaseLinearDimension extends BaseDimension {
   async execute() {
     try {
       DesignCore.Scene.selectionManager.reset();
-      this.dimensionStyle = DesignCore.DimStyleManager.getCstyle();
+      this.setProperty(Property.Names.DIMENSIONSTYLE, DesignCore.DimStyleManager.getCstyle());
       this.dimType.setDimType(0); // Rotated dimension
 
       const op = new PromptOptions(Strings.Input.START, [Input.Type.POINT]);
@@ -62,8 +64,7 @@ export class BaseLinearDimension extends BaseDimension {
   preview() {
     if (this.points.length == 1) {
       const mousePoint = DesignCore.Mouse.pointOnScene();
-      const points = [this.points.at(0), mousePoint];
-      DesignCore.Scene.tempEntities.create('Line', { points: points });
+      DesignCore.Scene.auxiliaryEntities.add(new RubberBand([this.points.at(0), mousePoint]));
     }
 
     if (this.points.length > 1) {
@@ -71,7 +72,7 @@ export class BaseLinearDimension extends BaseDimension {
       pt11.sequence = 11;
       const tempLine = new Line({ points: [...this.points] });
       const points = this.constructor.getPointsFromSelection([tempLine], pt11);
-      DesignCore.Scene.tempEntities.create(this.type, { points: points, dimensionStyle: this.dimensionStyle });
+      DesignCore.Scene.previewEntities.create(this.type, { points: points, dimensionStyle: this.getProperty(Property.Names.DIMENSIONSTYLE) });
     }
   }
 
@@ -155,7 +156,7 @@ export class BaseLinearDimension extends BaseDimension {
     const midPoint = Pt13e.midPoint(Pt14e);
 
     // set the dimension line angle. This is required for rotated dimension dxf definition
-    this.linearDimAngle = Utils.radians2degrees(dimLineAngle);
+    this.setProperty(Property.Names.LINEARDIMANGLE, Utils.radians2degrees(dimLineAngle));
 
     // Approximate text width based on height using the formatted dimension value i.e with units, precision and symbols
     const approxTextWidth = Text.getApproximateWidth(this.getDimensionValue(dimension), DIMTXT);

package/core/dimensions/diametricDimension.js

@@ -1,5 +1,6 @@
 import { DXFFile } from '../lib/dxf/dxfFile.js';
 import { BaseCircularDimension } from './baseCircularDimension.js';
+import { Property } from '../properties/property.js';
 
 /**
  * Diametric Dimension Entity Class
@@ -61,10 +62,10 @@ export class DiametricDimension extends BaseCircularDimension {
     const Pt15 = this.getPointBySequence(this.points, 15);
 
     file.writeGroupCode('0', 'DIMENSION');
-    file.writeGroupCode('5', this.handle, DXFFile.Version.R2000); // Handle
+    file.writeGroupCode('5', this.getProperty(Property.Names.HANDLE), DXFFile.Version.R2000); // Handle
     file.writeGroupCode('100', 'AcDbEntity', DXFFile.Version.R2000);
     file.writeGroupCode('100', 'AcDbDimension', DXFFile.Version.R2000);
-    file.writeGroupCode('8', this.layer);
+    file.writeGroupCode('8', this.getProperty(Property.Names.LAYER));
     // file.writeGroupCode('2', this.blockName); // Block not required
     file.writeGroupCode('10', Pt10.x); // X - Start of Dimension Line
     file.writeGroupCode('20', Pt10.y); // Y
@@ -73,7 +74,7 @@ export class DiametricDimension extends BaseCircularDimension {
     file.writeGroupCode('21', Pt11.y); // Y
     file.writeGroupCode('31', '0.0'); // Z
     file.writeGroupCode('70', this.dimType.getDimType()); // DIMENSION TYPE
-    file.writeGroupCode('3', this.dimensionStyle); // DIMENSION STYLE
+    file.writeGroupCode('3', this.getProperty(Property.Names.DIMENSIONSTYLE)); // DIMENSION STYLE
     file.writeGroupCode('100', 'AcDbDiametricDimension', DXFFile.Version.R2000);
     file.writeGroupCode('15', Pt15.x); // X - End of Dimension Line
     file.writeGroupCode('25', Pt15.y); // Y

package/core/dimensions/dimension.js

@@ -17,6 +17,7 @@ import { Logging } from '../lib/logging.js';
 import { Intersection } from '../lib/intersect.js';
 
 import { DesignCore } from '../designCore.js';
+import { Property } from '../properties/property.js';
 import { SingleSelection } from '../lib/selectionManager.js';
 import { Utils } from '../lib/utils.js';
 import { DimType } from '../properties/dimType.js';
@@ -33,18 +34,24 @@ export class Dimension extends BaseDimension {
   constructor(data) {
     super(data);
 
-    // map dimensions type to the class name
-    this.dimensionMap = {
-      0: RotatedDimension,
-      1: AlignedDimension,
-      2: AngularDimension,
-      3: DiametricDimension,
-      4: RadialDimension,
-      5: null, // 5 = Angular 3 point;
-      6: null, // 6 = Ordinate;
-    };
-
-    this.selectedItems = [];
+    // map dimensions type to the class name — non-enumerable: internal workflow state
+    Object.defineProperty(this, 'dimensionMap', {
+      value: {
+        0: RotatedDimension,
+        1: AlignedDimension,
+        2: AngularDimension,
+        3: DiametricDimension,
+        4: RadialDimension,
+        5: null, // 5 = Angular 3 point;
+        6: null, // 6 = Ordinate;
+      },
+      writable: true,
+    });
+
+    Object.defineProperty(this, 'selectedItems', {
+      value: [],
+      writable: true,
+    });
 
     if (data) {
       const item = new this.dimensionMap[DimType.getBaseType(this.dimType.getBaseDimType())](data);
@@ -80,7 +87,7 @@ export class Dimension extends BaseDimension {
   async execute() {
     try {
       let inputValid = false;
-      this.dimensionStyle = DesignCore.DimStyleManager.getCstyle();
+      this.setProperty(Property.Names.DIMENSIONSTYLE, DesignCore.DimStyleManager.getCstyle());
 
       while (!inputValid) {
         DesignCore.Scene.selectionManager.reset();
@@ -292,7 +299,7 @@ export class Dimension extends BaseDimension {
       // get the points for the dimension
       const points = dimensionType.getPointsFromSelection(this.selectedItems, Pt11);
       // create the temporary dimension
-      DesignCore.Scene.tempEntities.create(dimensionTypeString, { points: points, dimensionStyle: this.dimensionStyle });
+      DesignCore.Scene.previewEntities.create(dimensionTypeString, { points: points, dimensionStyle: this.getProperty(Property.Names.DIMENSIONSTYLE) });
     }
   }
 }

package/core/dimensions/radialDimension.js

@@ -1,6 +1,7 @@
 
 import { DXFFile } from '../lib/dxf/dxfFile.js';
 import { BaseCircularDimension } from './baseCircularDimension.js';
+import { Property } from '../properties/property.js';
 
 /**
  * Radial Dimension Entity Class
@@ -57,10 +58,10 @@ export class RadialDimension extends BaseCircularDimension {
     const Pt15 = this.getPointBySequence(this.points, 15);
 
     file.writeGroupCode('0', 'DIMENSION');
-    file.writeGroupCode('5', this.handle, DXFFile.Version.R2000); // Handle
+    file.writeGroupCode('5', this.getProperty(Property.Names.HANDLE), DXFFile.Version.R2000); // Handle
     file.writeGroupCode('100', 'AcDbEntity', DXFFile.Version.R2000);
     file.writeGroupCode('100', 'AcDbDimension', DXFFile.Version.R2000);
-    file.writeGroupCode('8', this.layer);
+    file.writeGroupCode('8', this.getProperty(Property.Names.LAYER));
     // file.writeGroupCode('2', this.blockName); // Block not required
     file.writeGroupCode('10', Pt10.x); // X - Start of Dimension Line
     file.writeGroupCode('20', Pt10.y); // Y
@@ -69,7 +70,7 @@ export class RadialDimension extends BaseCircularDimension {
     file.writeGroupCode('21', Pt11.y); // Y
     file.writeGroupCode('31', '0.0'); // Z
     file.writeGroupCode('70', this.dimType.getDimType()); // DIMENSION TYPE
-    file.writeGroupCode('3', this.dimensionStyle); // DIMENSION STYLE
+    file.writeGroupCode('3', this.getProperty(Property.Names.DIMENSIONSTYLE)); // DIMENSION STYLE
     file.writeGroupCode('100', 'AcDbRadialDimension', DXFFile.Version.R2000);
     file.writeGroupCode('15', Pt15.x); // X - End of Dimension Line
     file.writeGroupCode('25', Pt15.y); // Y