@design-ai/cli 4.55.0 → 4.56.0

package/tools/audit/smoke_assertions.py

@@ -14,6 +14,7 @@ from doctor_assertions import EXPECTED_DOCTOR_PASS_LABELS, assert_doctor_report_
 
 ANSI_ESCAPE_RE = re.compile(r"\x1b\[[0-?]*[ -/]*[@-~]")
 ROOT = Path(__file__).resolve().parents[2]
+PACKAGE_JSON = ROOT / "package.json"
 PLUGIN_MANIFEST = ROOT / ".claude-plugin" / "plugin.json"
 PLUGIN_INVENTORY_SECTIONS = (
     ("skills", "skill"),
@@ -21,6 +22,7 @@ PLUGIN_INVENTORY_SECTIONS = (
     ("agents", "agent"),
 )
 OUTPUT_FORCE_OVERWRITE_SENTINEL = "__design-ai-smoke-force-overwrite-sentinel__"
+EXPECTED_MCP_INVALID_ARGUMENT_MESSAGE = "design_ai_search.limit must be an integer"
 
 
 def load_plugin_manifest() -> dict[str, object]:
@@ -30,11 +32,70 @@ def load_plugin_manifest() -> dict[str, object]:
         raise SystemExit(f"failed to load plugin manifest for smoke assertions: {PLUGIN_MANIFEST}") from error
 
 
+def load_package_json() -> dict[str, object]:
+    try:
+        return json.loads(PACKAGE_JSON.read_text(encoding="utf-8"))
+    except (OSError, json.JSONDecodeError) as error:
+        raise SystemExit(f"failed to load package metadata for smoke assertions: {PACKAGE_JSON}") from error
+
+
 def count_manifest_section(manifest: dict[str, object], section: str) -> int:
     items = manifest.get(section)
     return len(items) if isinstance(items, list) else 0
 
 
+EXPECTED_RELEASE_VERSION = str(load_package_json().get("version", ""))
+
+
+def mcp_smoke_input() -> str:
+    messages = [
+        {"jsonrpc": "2.0", "id": 1, "method": "initialize", "params": {"protocolVersion": "2025-11-25"}},
+        {"jsonrpc": "2.0", "method": "notifications/initialized"},
+        {"jsonrpc": "2.0", "id": 2, "method": "tools/list"},
+        {
+            "jsonrpc": "2.0",
+            "id": 3,
+            "method": "tools/call",
+            "params": {
+                "name": "design_ai_search",
+                "arguments": {"query": "Pretendard", "limit": "10"},
+            },
+        },
+    ]
+    return "".join(f"{json.dumps(message, separators=(',', ':'))}\n" for message in messages)
+
+
+def assert_design_ai_mcp_protocol_responses(responses: list[object], *, context: str, cmd: list[str]) -> None:
+    by_id = {
+        response.get("id"): response
+        for response in responses
+        if isinstance(response, dict) and "id" in response
+    }
+    init = by_id.get(1)
+    tools = by_id.get(2)
+    invalid_call = by_id.get(3)
+
+    if not (isinstance(init, dict) and init.get("result", {}).get("serverInfo", {}).get("name") == "design-ai"):
+        raise SystemExit(f"{context}: MCP initialize response missing design-ai serverInfo")
+
+    tool_names = [
+        item.get("name")
+        for item in tools.get("result", {}).get("tools", [])
+    ] if isinstance(tools, dict) else []
+    if "design_ai_route" not in tool_names or "design_ai_search" not in tool_names:
+        raise SystemExit(f"{context}: MCP tools/list response missing design-ai tools")
+
+    invalid_error = invalid_call.get("error", {}) if isinstance(invalid_call, dict) else {}
+    invalid_text = str(invalid_error.get("message", "")) if isinstance(invalid_error, dict) else ""
+    if not (
+        isinstance(invalid_call, dict)
+        and isinstance(invalid_error, dict)
+        and invalid_error.get("code") == -32602
+        and EXPECTED_MCP_INVALID_ARGUMENT_MESSAGE in invalid_text
+    ):
+        raise SystemExit(f"{context}: MCP invalid argument response did not preserve invalid params validation")
+
+
 def format_inventory_count(count: int, singular: str) -> str:
     return f"{count} {singular}{'' if count == 1 else 's'}"
 
@@ -327,7 +388,7 @@ EXPECTED_MAIN_HELP_FRAGMENTS = (
 EXPECTED_VERSION_FRAGMENTS = (
     "design-ai CLI:",
     "Plugin / corpus:",
-    "4.55.0",
+    EXPECTED_RELEASE_VERSION,
     "Source:",
 )
 EXPECTED_INSTALL_OUTPUT_FRAGMENTS = (
@@ -367,7 +428,7 @@ EXPECTED_DOCTOR_STRICT_OUTPUT_FRAGMENTS = (
     "Target:",
     "Prefix:",
     "Source layout: complete",
-    "Version alignment: 4.55.0",
+    f"Version alignment: {EXPECTED_RELEASE_VERSION}",
     "Manifest paths: 41 referenced artifact(s) exist",
     "Node runtime:",
     "Python runtime:",
@@ -1508,7 +1569,7 @@ def passing_list_catalog_output(kind: str = "skills") -> str:
         "",
         "  design-ai catalog",
         "",
-        "Plugin: design-ai v4.55.0",
+        f"Plugin: design-ai v{EXPECTED_RELEASE_VERSION}",
         "",
         "",
         f"{kind} ({len(items)})",
@@ -1540,7 +1601,7 @@ def passing_list_catalog_json(kind: str = "skills") -> str:
     return json.dumps(
         {
             "name": "design-ai",
-            "version": "4.55.0",
+            "version": EXPECTED_RELEASE_VERSION,
             "kind": kind,
             "sections": [
                 {
@@ -1961,7 +2022,7 @@ def passing_examples_human_output() -> str:
 def passing_route_json() -> str:
     return json.dumps({
         "brief": EXPECTED_ROUTE_BRIEF,
-        "version": "4.55.0",
+        "version": EXPECTED_RELEASE_VERSION,
         "routes": [
             {
                 "id": EXPECTED_ROUTE_ID,
@@ -2035,7 +2096,7 @@ def passing_route_explain_human_output() -> str:
         f"  {EXPECTED_ROUTE_BRIEF}",
         "",
         "Source: /tmp/design-ai",
-        "Corpus version: 4.55.0",
+        f"Corpus version: {EXPECTED_RELEASE_VERSION}",
         "",
         f"1. {EXPECTED_ROUTE_LABEL} (high, score {len(EXPECTED_ROUTE_MATCHED_KEYWORDS)})",
         f"   id:      {EXPECTED_ROUTE_ID}",
@@ -2124,7 +2185,7 @@ def passing_route_catalog_json() -> str:
         routes.append(route)
 
     return json.dumps({
-        "version": "4.55.0",
+        "version": EXPECTED_RELEASE_VERSION,
         "routes": routes,
     })
 
@@ -2132,7 +2193,7 @@ def passing_route_catalog_json() -> str:
 def passing_prompt_payload() -> dict:
     return {
         "brief": EXPECTED_ROUTE_BRIEF,
-        "version": "4.55.0",
+        "version": EXPECTED_RELEASE_VERSION,
         "route": {
             "id": EXPECTED_ROUTE_ID,
             "label": EXPECTED_ROUTE_LABEL,
@@ -2237,7 +2298,7 @@ def passing_prompt_markdown_output() -> str:
         f"  {EXPECTED_ROUTE_BRIEF}",
         "",
         "Source: /tmp/design",
-        "Corpus version: 4.55.0",
+        f"Corpus version: {EXPECTED_RELEASE_VERSION}",
         "",
         "# design-ai task prompt",
         f"Task: {EXPECTED_ROUTE_BRIEF}",
@@ -2263,7 +2324,7 @@ def passing_prompt_markdown_output() -> str:
 def passing_pack_json() -> str:
     return json.dumps({
         "brief": EXPECTED_ROUTE_BRIEF,
-        "version": "4.55.0",
+        "version": EXPECTED_RELEASE_VERSION,
         "maxBytes": EXPECTED_PACK_MAX_BYTES,
         "usedBytes": EXPECTED_PACK_MAX_BYTES,
         "summary": {
@@ -2311,7 +2372,7 @@ def passing_pack_markdown_output() -> str:
         f"  {EXPECTED_ROUTE_BRIEF}",
         "",
         "Source: /tmp/design",
-        "Corpus version: 4.55.0",
+        f"Corpus version: {EXPECTED_RELEASE_VERSION}",
         f"Context: partial, {EXPECTED_PACK_MAX_BYTES}/{EXPECTED_PACK_MAX_BYTES} bytes, 2 warnings",
         "",
         "# design-ai prompt pack",
@@ -4181,8 +4242,8 @@ def passing_main_help_output() -> str:
 
 def passing_version_output() -> str:
     return "\n".join([
-        "design-ai CLI:    4.55.0",
-        "Plugin / corpus:  4.55.0",
+        f"design-ai CLI:    {EXPECTED_RELEASE_VERSION}",
+        f"Plugin / corpus:  {EXPECTED_RELEASE_VERSION}",
         "Source:           /tmp/design-ai",
         "",
     ])
@@ -4195,8 +4256,8 @@ def passing_version_json() -> str:
                 "sourceRoot": "/tmp/design-ai",
             },
             "versions": {
-                "cli": "4.55.0",
-                "plugin": "4.55.0",
+                "cli": EXPECTED_RELEASE_VERSION,
+                "plugin": EXPECTED_RELEASE_VERSION,
                 "aligned": True,
             },
         },
@@ -4213,7 +4274,7 @@ def passing_workspace_json() -> str:
                 "root": "/tmp/project",
                 "sourceRoot": "/tmp/design-ai",
                 "packageName": "@design-ai/cli",
-                "version": "4.55.0",
+                "version": EXPECTED_RELEASE_VERSION,
             },
             "git": {
                 "isRepo": False,
@@ -4267,7 +4328,7 @@ def passing_workspace_json() -> str:
             "learningRestoreBackups": None,
             "release": {
                 "packageName": "@design-ai/cli",
-                "version": "4.55.0",
+                "version": EXPECTED_RELEASE_VERSION,
                 "scripts": {
                     "test": "node --test cli/lib/*.test.mjs",
                     "audit:strict": "python3 -B tools/audit/run-all.py --strict",
@@ -5568,7 +5629,7 @@ def passing_doctor_strict_output() -> str:
         "ℹ  Prefix: smoke-design-",
         "",
         "✓  Source layout: complete at /tmp/design-ai",
-        "✓  Version alignment: 4.55.0",
+        f"✓  Version alignment: {EXPECTED_RELEASE_VERSION}",
         "✓  Manifest paths: 41 referenced artifact(s) exist",
         "✓  Node runtime: v24.13.1",
         "✓  Python runtime: Python 3.12.12",
@@ -5593,7 +5654,7 @@ def passing_install_output() -> str:
     return "\n".join([
         "",
         "  design-ai installer",
-        "  v4.55.0",
+        f"  v{EXPECTED_RELEASE_VERSION}",
         "",
         "Source: /tmp/design-ai",
         "Target: /tmp/claude-home",
@@ -6022,7 +6083,7 @@ def assert_workspace_json(raw: str, *, context: str, cmd: list[str]) -> None:
     )
     if workspace_context.get("packageName") != "@design-ai/cli":
         raise SystemExit(f"workspace JSON after {context} packageName differs from expected package")
-    if workspace_context.get("version") != "4.55.0":
+    if workspace_context.get("version") != EXPECTED_RELEASE_VERSION:
         raise SystemExit(f"workspace JSON after {context} version differs from expected release version")
     for key in ("cwd", "root", "sourceRoot"):
         if not isinstance(workspace_context.get(key), str) or not workspace_context[key]:
@@ -6355,7 +6416,7 @@ def assert_workspace_json(raw: str, *, context: str, cmd: list[str]) -> None:
         context=context,
         command_label="workspace JSON",
     )
-    if release.get("packageName") != "@design-ai/cli" or release.get("version") != "4.55.0":
+    if release.get("packageName") != "@design-ai/cli" or release.get("version") != EXPECTED_RELEASE_VERSION:
         raise SystemExit(f"workspace JSON after {context} release package metadata differs from expected values")
     if not isinstance(release.get("scripts"), dict):
         raise SystemExit(f"workspace JSON after {context} release scripts is not an object")
@@ -10780,7 +10841,7 @@ def run_self_test() -> None:
     )
     expect_self_test_failure(
         lambda: assert_version_json(
-            passing_version_json().replace('"plugin": "4.55.0"', '"plugin": "unknown"'),
+            passing_version_json().replace(f'"plugin": "{EXPECTED_RELEASE_VERSION}"', '"plugin": "unknown"'),
             context=context,
             cmd=[*version_cmd, "--json"],
         ),