@descope/web-components-ui 3.14.9 → 3.15.0

package/src/components/descope-passcode/descope-passcode-internal/PasscodeInternal.js

@@ -174,6 +174,13 @@ class PasscodeInternal extends BaseInputClass {
 
       const debouncedHandleParseInput = debounce(handleParseInput, 0, { trailing: true });
 
+      // Per-input flag: set in keydown, consumed in the input event.
+      // Fallback for WebKit/Safari, where the native input event can fire
+      // non-composed; proxyInputMixin then re-dispatches it as a plain Event
+      // (no inputType), so the 'deleteContentBackward' check misses the
+      // backspace and navigation is skipped.
+      let lastKeyWasBackspace = false;
+
       // sanitize the input
       input.addEventListener('input', (e) => {
         input.value = sanitizeStr(input.value);
@@ -182,29 +189,50 @@ class PasscodeInternal extends BaseInputClass {
           toggleMaskVisibility(input, input.value[0]);
         }
 
-        setTimeout(() => {
-          if (e?.inputType === 'deleteContentBackward') {
-            focusElement(this.getPrevInput(input));
-          }
-        });
+        // inputType covers iOS (unreliable keydown); the flag covers WebKit
+        // (missing inputType). See flag declaration above.
+        const isBackspace = e?.inputType === 'deleteContentBackward' || lastKeyWasBackspace;
+        lastKeyWasBackspace = false;
+
+        if (isBackspace) {
+          // Navigate synchronously (no setTimeout) to prevent WebKit key-event
+          // leakage: with setTimeout(0), WebKit can dispatch the next key-repeat
+          // backspace event to the newly focused element, deleting a second digit.
+          // Calling focusElement here (inside the input event, not keydown) is safe
+          // because the browser has already finished processing the deletion.
+          focusElement(this.getPrevInput(input));
+        }
+
         debouncedHandleParseInput(input.value);
       });
 
       // we want backspace to focus on the previous digit
-      input.onkeydown = ({ key }) => {
-        // when user deletes a digit, we want to focus the previous digit
+      input.onkeydown = (e) => {
+        const { key } = e;
         if (key === 'Backspace') {
-          // if value is empty then the input element does not fire `input` event
-          // if this is the case, we focus the element here.
-          // otherwise, the focusElement occurs as part of the `input` event listener
           if (!input.value) {
-            setTimeout(() => focusElement(this.getPrevInput(input)), 0);
+            // Empty field: the input event will not fire (nothing to delete),
+            // so we must handle navigation here.
+            // e.preventDefault() stops WebKit from leaking this keypress to
+            // the element that receives focus (key-event leakage).
+            e.preventDefault();
+            lastKeyWasBackspace = false;
+            focusElement(this.getPrevInput(input));
           } else {
+            // Non-empty field: let the browser delete normally so the input
+            // event fires (needed on older iOS where keydown is unreliable).
+            // Move the caret to the end first so Backspace deletes the digit
+            // even if a direct tap left the caret before it (caret at index 0).
             input.setSelectionRange(1, 1);
+            // Fallback signal for the input handler (see flag declaration above).
+            lastKeyWasBackspace = true;
+          }
+        } else {
+          lastKeyWasBackspace = false;
+          if (key.length === 1) {
+            // we want only characters and not command keys
+            input.value = ''; // we are clearing the previous value so we can override it with the new value
           }
-        } else if (key.length === 1) {
-          // we want only characters and not command keys
-          input.value = ''; // we are clearing the previous value so we can override it with the new value
         }
       };
 

package/stories/descope-modal.stories.js

@@ -13,7 +13,7 @@ const template = `
   </descope-container>
 </descope-container>`;
 
-const Template = ({ opened }) => {
+const Template = ({ opened, closeOnOutsideClick }) => {
   const loader = `
     <descope-container direction="column" st-align-items="center" st-horizontal-padding="1.25rem" st-vertical-padding="1.25rem" st-gap="0.75rem" st-background-color="transparent">
       <descope-loader-radial size="sm" mode="primary"></descope-loader-radial>
@@ -21,7 +21,7 @@ const Template = ({ opened }) => {
   `;
 
   return `
-    <descope-modal opened="${opened}">
+    <descope-modal opened="${opened}" close-on-outside-click="${closeOnOutsideClick}">
       ${loader}
     </descope-modal>
     `;
@@ -30,6 +30,16 @@ const Template = ({ opened }) => {
 export default {
   component: componentName,
   title: 'descope-modal',
+  argTypes: {
+    opened: {
+      name: 'Opened',
+      control: { type: 'boolean' },
+    },
+    closeOnOutsideClick: {
+      name: 'Close on outside click',
+      control: { type: 'boolean' },
+    },
+  },
   decorators: [
     (render) => {
       setTimeout(() => {
@@ -45,4 +55,5 @@ export const Default = Template.bind({});
 
 Default.args = {
   opened: true,
+  closeOnOutsideClick: true,
 };