@descix/cli 1.0.6 → 1.0.7

package/lib/wizard/setup.js

@@ -21,9 +21,12 @@
 import chalk from 'chalk';
 import ora from 'ora';
 import inquirer from 'inquirer';
+// "May I prompt?" has ONE OWNER. The wizard is interactive BY NATURE; it still asks the owner.
+import { requireInteractive } from '../interactive.js';
 import { DeSciXApiClient } from '../api-client.js';
 import { ENV_ORIGINS } from '@descix/app-sdk/dev';
 import { requireAuth, isAuthenticated } from '../auth-guard.js';
+import { WorkspaceConfig } from '../workspace-config.js';
 import * as authCommands from '../commands/auth.js';
 import * as fs from 'fs/promises';
 import * as path from 'path';
@@ -179,12 +182,96 @@ function getMcpServerConfig() {
   };
 }
 
+/**
+ * Refuse to run when a workspace already exists here.
+ *
+ * quickstart CREATES a workspace. It has no migration or merge semantics, so running it over a
+ * present one can only destroy information. This is a REFUSAL and deliberately NOT a prompt:
+ * an agent caller hangs forever on a question, and a refusal is machine-readable where a
+ * question is not.
+ *
+ * WHERE THE WORKSPACE ROOT IS has ONE OWNER: WorkspaceConfig.findWorkspaceRoot, which walks UP
+ * from the start directory exactly as load() does. This guard CONSUMES it. It used to derive the
+ * answer a SECOND time by reading the TARGET PATH ONLY, and the two derivations disagreed in the
+ * case that matters: run from a SUBDIRECTORY of an existing workspace, the target-path check saw
+ * nothing, the wizard proceeded, and it wrote a NESTED workspace.json that SHADOWS the parent for
+ * every later load() — because load() walks up and stops at the FIRST one it finds. The second
+ * derivation is DELETED, not left beside the owner.
+ *
+ * A nested workspace is not an unsupported topology, it is the BUG: because resolution walks UP,
+ * a nested file is unreachable by design from below EXCEPT by shadowing its parent. There is no
+ * escape hatch here and no flag to request one.
+ *
+ * findWorkspaceRoot stats the file, so a PRESENT-BUT-UNREADABLE workspace is still FOUND and still
+ * refused — the corrupt-looks-absent case this guard exists to stop is preserved.
+ *
+ * @param {string} startDir - directory the wizard was invoked in
+ * @throws {Error} naming the root it found and what is there, when a workspace exists at or ABOVE
+ *                 startDir
+ */
+async function refuseIfWorkspacePresent(startDir) {
+  const workspaceRoot = await WorkspaceConfig.findWorkspaceRoot(startDir);
+  if (!workspaceRoot) return; // ordinary first run — nothing up the tree to protect
+
+  const configPath = path.join(workspaceRoot, '.descix', 'workspace.json');
+  const nested = path.resolve(workspaceRoot) !== path.resolve(startDir);
+
+  let raw;
+  try {
+    raw = await fs.readFile(configPath, 'utf-8');
+  } catch (err) {
+    if (err.code === 'ENOENT') return; // stat'd a moment ago; it vanished in between
+    throw new Error(
+      `Refusing to run quickstart: ${configPath} exists but could not be read (${err.message}).\n` +
+      (nested ? `It is the workspace root for ${workspaceRoot}, which CONTAINS ${startDir}.\n` : '') +
+      'Quickstart will not write over a file it cannot inspect.'
+    );
+  }
+
+  let found;
+  try {
+    const parsed = JSON.parse(raw);
+    const version = parsed && parsed.version ? parsed.version : 'no version field';
+    found = `version ${version}`;
+  } catch (err) {
+    found = `unparseable JSON (${err.message})`;
+  }
+
+  throw new Error(
+    (nested
+      ? `Refusing to create a workspace here — ${startDir} is already INSIDE the workspace ` +
+        `rooted at ${workspaceRoot}.\n` +
+        `  Existing workspace: ${configPath} (${found})\n` +
+        '\nCreating a second workspace.json in this subdirectory would SHADOW that one: workspace ' +
+        'resolution walks UP and stops at the FIRST file it finds, so every later command run from ' +
+        'here would silently use the new file instead of the real one.\n'
+      : `Refusing to overwrite ${configPath} — a workspace is already configured here (${found}).\n` +
+        '\nquickstart CREATES a workspace; it does not migrate or merge an existing one, and ' +
+        'writing over this file would destroy whatever it holds.\n') +
+    '\nTo change the workspace you already have, use the verbs that own it' +
+    (nested ? ` (run them from ${workspaceRoot}):\n` : ':\n') +
+    '  descix config show                 # what is configured right now\n' +
+    '  descix config init --env <env>     # retarget to a known environment (dev|demo|prod)\n' +
+    '  descix config set-env <name> --url <origin>  # a custom API origin under your own env name\n' +
+    '  descix config set-gateway-port <n> # change the gateway port\n' +
+    '  descix app init                    # register another app in this workspace\n'
+  );
+}
+
 // ============ Main Wizard ============
 
 /**
  * Run the interactive setup wizard
  */
 export async function runSetupWizard(options = {}) {
+  // ONE derivation of the workspace root, shared by the guard and the write it protects.
+  const workspaceRoot = process.cwd();
+
+  // BEFORE the banner and before every side effect: this wizard also writes
+  // .cursor/mcp.json and pulls SDK assets, so a guard placed further down would
+  // refuse only after those had already landed.
+  await refuseIfWorkspacePresent(workspaceRoot);
+
   console.log(chalk.cyan('\n┌─────────────────────────────────────────────────┐'));
   console.log(chalk.cyan('│        Welcome to DeSciX CLI/MCP Setup          │'));
   console.log(chalk.cyan('├─────────────────────────────────────────────────┤'));
@@ -200,7 +287,6 @@ export async function runSetupWizard(options = {}) {
   console.log(chalk.cyan('│  configure your workspace folders.              │'));
   console.log(chalk.cyan('└─────────────────────────────────────────────────┘\n'));
 
-  const workspaceRoot = process.cwd();
   const spinner = ora('Initializing...').start();
 
   try {
@@ -211,6 +297,7 @@ export async function runSetupWizard(options = {}) {
     let apiUrl = options.url || process.env.DESCIX_API_URL;
     
     if (!apiUrl) {
+      requireInteractive({ what: 'descix mcp quickstart', question: 'which environment?', nonInteractiveForm: ['descix mcp quickstart is an interactive wizard and has no non-interactive form. Run it in a terminal.'] });
       const { environment } = await inquirer.prompt([
         {
           type: 'list',
@@ -230,6 +317,7 @@ export async function runSetupWizard(options = {}) {
       } else if (environment === 'local') {
         apiUrl = 'https://localhost:4000';
       } else {
+        requireInteractive({ what: 'descix mcp quickstart', question: 'custom API URL?', nonInteractiveForm: ['descix mcp quickstart is an interactive wizard and has no non-interactive form. Run it in a terminal.'] });
         const { customUrl } = await inquirer.prompt([
           {
             type: 'input',
@@ -265,6 +353,7 @@ export async function runSetupWizard(options = {}) {
     if (!isAuth) {
       console.log(chalk.yellow('⚠️  Authentication is required to use DeSciX CLI/MCP.\n'));
       
+      requireInteractive({ what: 'descix mcp quickstart', question: 'which authentication method?', nonInteractiveForm: ['descix mcp quickstart is an interactive wizard and has no non-interactive form. Run it in a terminal.'] });
       const { authMethod } = await inquirer.prompt([
         {
           type: 'list',
@@ -357,6 +446,7 @@ export async function runSetupWizard(options = {}) {
     // Step 4: MCP Configuration
     console.log(chalk.cyan('\n📋 Step 4: MCP Configuration\n'));
     
+    requireInteractive({ what: 'descix mcp quickstart', question: 'configure MCP now?', nonInteractiveForm: ['descix mcp quickstart is an interactive wizard and has no non-interactive form. Run it in a terminal.'] });
     const { setupMCP } = await inquirer.prompt([
       {
         type: 'confirm',
@@ -437,27 +527,19 @@ export async function runSetupWizard(options = {}) {
     // Step 5: Create workspace config
     spinner.start('Creating workspace configuration...');
     
-    const config = {
-      version: '2.0',
-      primaryCommunity,
-      directoryMappings: {},  // Empty - AI agent will configure after setup
-      additionalContexts: [],
-      defaultContext: {
-        communityId: primaryCommunity,
-        appId: 'daita',
-        kbId: 'General'
-      },
-      apiUrl: apiUrl,
-      environment: apiUrl.includes('localhost') ? 'development' : 'production',
-      _setupStatus: 'mcp_ready',
-      _needsAgentSetup: true,  // Flag for AI agent to help with workspace config
-      _sdkVersion: SDK_VERSION
-    };
-    
-    const descixDir = path.join(workspaceRoot, '.descix');
-    await fs.mkdir(descixDir, { recursive: true });
-    const configPath = path.join(descixDir, 'workspace.json');
-    await fs.writeFile(configPath, JSON.stringify(config, null, 2));
+    // The SHAPE of this file is owned by WorkspaceConfig and it is written ONLY via save().
+    // This used to build a config literal and call fs.writeFile directly — no existence check,
+    // no parse check, no save() — which both clobbered present workspaces and stamped a
+    // version '2.0' shape on a v2.1 platform. The version is the owner's concern now.
+    //
+    // The env NAME comes from the owner's own ENV_MAP rather than being re-derived from the URL
+    // here; an origin the owner does not know is recorded as DEV carrying its explicit URL,
+    // because inventing a label at this call site would be a second derivation of one fact.
+    const envName = (Object.entries(WorkspaceConfig.ENV_MAP)
+      .find(([, entry]) => entry.url === apiUrl) || ['dev'])[0];
+
+    const workspace = new WorkspaceConfig({ type: 'workspace' }, workspaceRoot);
+    const { configPath } = await workspace.setEnvironment(envName, apiUrl);
     
     spinner.succeed('Workspace configured');
     console.log(chalk.gray(`  Created: .descix/workspace.json\n`));