@dereekb/dbx-components-mcp 14.15.0 → 14.16.0

package/dbx-components-mcp.js

@@ -10,7 +10,7 @@ var __export = (target, all) => {
 // packages/dbx-components-mcp/package.json
 var package_default = {
   name: "@dereekb/dbx-components-mcp",
-  version: "14.15.0",
+  version: "14.16.0",
   sideEffects: false,
   type: "module",
   bin: {
@@ -22,8 +22,8 @@ var package_default = {
     "ts-morph": "^21.0.0"
   },
   peerDependencies: {
-    "@dereekb/dbx-cli": "14.15.0",
-    "@dereekb/util": "14.15.0"
+    "@dereekb/dbx-cli": "14.16.0",
+    "@dereekb/util": "14.16.0"
   }
 };
 
@@ -24883,11 +24883,43 @@ var RULE_CATALOG = [
     code: "NOTIF_TEMPLATE_FACTORY_UNLISTED_DELIVERY_METHOD",
     source: "dbx_notification_m_validate_app",
     severity: "warning",
-    title: "A template's message factory returns channel content for a delivery method its `NotificationTemplateTypeInfo` does not list in `userConfigurableDeliveryMethods`",
-    whatItFlags: "A template's message factory returns channel content for a delivery method its `NotificationTemplateTypeInfo` does not list in `userConfigurableDeliveryMethods`.",
-    whenItApplies: "Template types whose info declares an explicit `userConfigurableDeliveryMethods` array and whose handler factory (or the function its `factory:` names) builds an object literal with `emailContent`, `textContent` or `notificationSummaryContent` for a method the array leaves out.",
-    whenItDoesNotApply: "Infos without `userConfigurableDeliveryMethods` (the defaults list email, text and notification summary), lists the scanner cannot read statically, and content built outside the factory's own source \u2014 the send pipeline's runtime warning (`notificationMessageFunctionWithUnlistedDeliveryMethodsWarning`) still covers those.",
-    canonicalFix: "Stop returning the unlisted content from the factory, or add the delivery method to the info's `userConfigurableDeliveryMethods`.",
+    title: "A template's message factory returns channel content for a delivery method its `NotificationTemplateTypeInfo` does not list in `userConfigurableDeliveryMethods` or `forcedDeliveryMethods`",
+    whatItFlags: "A template's message factory returns channel content for a delivery method its `NotificationTemplateTypeInfo` does not list in `userConfigurableDeliveryMethods` or `forcedDeliveryMethods`.",
+    whenItApplies: "Template types whose info declares an explicit `userConfigurableDeliveryMethods` array, or only a `forcedDeliveryMethods` array (forcing a method changes the `userConfigurableDeliveryMethods` default to none), and whose handler factory (or the function its `factory:` names) builds an object literal with `emailContent`, `textContent` or `notificationSummaryContent` for a method neither array lists.",
+    whenItDoesNotApply: "Infos with neither `userConfigurableDeliveryMethods` nor `forcedDeliveryMethods` (the defaults list email, text and notification summary), lists the scanner cannot read statically (including a `forcedDeliveryMethods` it cannot read), and content built outside the factory's own source \u2014 the send pipeline's runtime warning (`notificationMessageFunctionWithUnlistedDeliveryMethodsWarning`) still covers those.",
+    canonicalFix: "Stop returning the unlisted content from the factory, or add the delivery method to the info's `userConfigurableDeliveryMethods` (or `forcedDeliveryMethods`).",
+    seeAlso: [
+      {
+        kind: "artifact",
+        target: "notification-template"
+      }
+    ]
+  },
+  {
+    code: "NOTIF_TEMPLATE_FORCED_DELIVERY_METHOD_EXPLICIT_OPT_IN",
+    source: "dbx_notification_m_validate_app",
+    severity: "error",
+    title: "A `NotificationTemplateTypeInfo` forces a delivery method while `onlySendToExplicitlyEnabledRecipients` is `true`. A forced method is on by default, which an opt-in only type cannot be, and the app throws at startup when the info record is built",
+    whatItFlags: "A `NotificationTemplateTypeInfo` forces a delivery method while `onlySendToExplicitlyEnabledRecipients` is `true`. A forced method is on by default, which an opt-in only type cannot be, and the app throws at startup when the info record is built.",
+    whenItApplies: "Infos with a non-empty statically read `forcedDeliveryMethods` array and `onlySendToExplicitlyEnabledRecipients: true`.",
+    whenItDoesNotApply: "Infos without `forcedDeliveryMethods`, lists the scanner cannot read statically, and `onlySendToExplicitlyEnabledRecipients` values other than a `true` literal.",
+    canonicalFix: "Remove `forcedDeliveryMethods`, or remove `onlySendToExplicitlyEnabledRecipients` from the info.",
+    seeAlso: [
+      {
+        kind: "artifact",
+        target: "notification-template"
+      }
+    ]
+  },
+  {
+    code: "NOTIF_TEMPLATE_FORCED_TEXT_DELIVERY_METHOD",
+    source: "dbx_notification_m_validate_app",
+    severity: "error",
+    title: "A `NotificationTemplateTypeInfo` lists the text delivery method in `forcedDeliveryMethods`. Texts cannot be forced, and the app throws at startup when the info record is built",
+    whatItFlags: "A `NotificationTemplateTypeInfo` lists the text delivery method in `forcedDeliveryMethods`. Texts cannot be forced, and the app throws at startup when the info record is built.",
+    whenItApplies: "Infos whose statically read `forcedDeliveryMethods` array contains `NotificationDeliveryMethod.TEXT`.",
+    whenItDoesNotApply: "Infos without `forcedDeliveryMethods`, and lists the scanner cannot read statically.",
+    canonicalFix: "Remove `NotificationDeliveryMethod.TEXT` from `forcedDeliveryMethods`. Texts stay opt-in for the recipient.",
     seeAlso: [
       {
         kind: "artifact",
@@ -30865,6 +30897,16 @@ function readStringProperty2(obj, name) {
   }
   return void 0;
 }
+function readBooleanProperty2(obj, name) {
+  const init = unwrapAsExpressions(getPropertyInitializer(obj, name));
+  let result;
+  if (init?.getKind() === SyntaxKind11.TrueKeyword) {
+    result = true;
+  } else if (init?.getKind() === SyntaxKind11.FalseKeyword) {
+    result = false;
+  }
+  return result;
+}
 function readIdentifierProperty(obj, name) {
   const init = unwrapAsExpressions(getPropertyInitializer(obj, name));
   if (init && Node26.isIdentifier(init)) {
@@ -31614,6 +31656,8 @@ var TEMPLATE_CONFIGS_ARRAY_TOKEN = "NOTIFICATION_TEMPLATE_SERVICE_CONFIGS_ARRAY_
 var CHECKPOINT_ALIAS_SUFFIX = "NotificationTaskCheckpoint";
 var TASK_DATA_INTERFACE_SUFFIX = "NotificationTaskData";
 var USER_CONFIGURABLE_DELIVERY_METHODS_PROPERTY = "userConfigurableDeliveryMethods";
+var FORCED_DELIVERY_METHODS_PROPERTY = "forcedDeliveryMethods";
+var ONLY_SEND_TO_EXPLICITLY_ENABLED_RECIPIENTS_PROPERTY = "onlySendToExplicitlyEnabledRecipients";
 var DELIVERY_METHOD_ENUM = "NotificationDeliveryMethod";
 var DELIVERY_METHOD_BY_MEMBER = /* @__PURE__ */ new Map([
   ["EMAIL", "EMAIL"],
@@ -31705,7 +31749,8 @@ function extractTemplateTypeInfos(sources) {
         if (!nameMatches && !typeMatches) continue;
         const obj = asObjectLiteral(decl.getInitializer());
         if (!obj) continue;
-        const deliveryMethods = readUserConfigurableDeliveryMethods(obj, sf);
+        const deliveryMethods = readDeliveryMethodsProperty(obj, sf, USER_CONFIGURABLE_DELIVERY_METHODS_PROPERTY);
+        const forcedDeliveryMethods = readDeliveryMethodsProperty(obj, sf, FORCED_DELIVERY_METHODS_PROPERTY);
         const entry = {
           symbolName: name,
           typeConstantName: readIdentifierProperty(obj, "type"),
@@ -31715,6 +31760,9 @@ function extractTemplateTypeInfos(sources) {
           targetModelIdentity: readIdentifierProperty(obj, "targetModelIdentity"),
           userConfigurableDeliveryMethods: deliveryMethods.methods,
           userConfigurableDeliveryMethodsSource: deliveryMethods.source,
+          forcedDeliveryMethods: forcedDeliveryMethods.methods,
+          forcedDeliveryMethodsSource: forcedDeliveryMethods.source,
+          onlySendToExplicitlyEnabledRecipients: readBooleanProperty2(obj, ONLY_SEND_TO_EXPLICITLY_ENABLED_RECIPIENTS_PROPERTY),
           sourceFile: rel,
           line: decl.getStartLineNumber()
         };
@@ -31724,8 +31772,8 @@ function extractTemplateTypeInfos(sources) {
   }
   return out;
 }
-function readUserConfigurableDeliveryMethods(obj, sf) {
-  const value = unwrapAsExpressions(getPropertyInitializer(obj, USER_CONFIGURABLE_DELIVERY_METHODS_PROPERTY));
+function readDeliveryMethodsProperty(obj, sf, propertyName) {
+  const value = unwrapAsExpressions(getPropertyInitializer(obj, propertyName));
   let result;
   if (!value || isNullishLiteral(value)) {
     result = { methods: void 0, source: "default" };
@@ -32489,6 +32537,7 @@ function runRules6(inspection, extracted) {
   checkTemplateInfoRecord(extracted, violations);
   checkTemplateHandlerFactory(extracted, violations);
   checkTemplateDeliveryMethods(extracted, violations);
+  checkTemplateForcedDeliveryMethods(extracted, violations);
   checkTasks(extracted, violations);
   checkDuplicates2(extracted, violations);
   return violations;
@@ -32664,20 +32713,56 @@ function checkTemplateDeliveryMethods(extracted, violations) {
   }
   for (const entry of extracted.templateHandlerEntries) {
     const info = infoByTypeConstant.get(entry.typeIdentifier);
-    const listed = info?.userConfigurableDeliveryMethodsSource === "declared" ? info.userConfigurableDeliveryMethods : void 0;
-    if (!listed) continue;
+    const userConfigurable = info ? staticUserConfigurableDeliveryMethods(info) : void 0;
+    if (!info || !userConfigurable) continue;
+    const forced = info.forcedDeliveryMethods ?? [];
+    const listed = [...userConfigurable, ...forced.filter((method) => !userConfigurable.includes(method))];
     const unlisted = entry.contentDeliveryMethods.filter((method) => !listed.includes(method));
     if (unlisted.length === 0) continue;
     const listedText = listed.length > 0 ? listed.join(", ") : "none";
+    const forcedSuffix = forced.length > 0 ? " and `forcedDeliveryMethods`" : "";
+    const listedIn = info.userConfigurableDeliveryMethodsSource === "declared" ? `\`userConfigurableDeliveryMethods\`${forcedSuffix}` : "`forcedDeliveryMethods` (it leaves `userConfigurableDeliveryMethods` out, so it is only sent by its forced methods)";
     pushViolation8(violations, {
       code: "NOTIF_TEMPLATE_FACTORY_UNLISTED_DELIVERY_METHOD",
       severity: "warning",
-      message: `Template handler factory \`${entry.factoryFunctionName ?? "<anonymous>"}\` for \`${entry.typeIdentifier}\` builds content for ${unlisted.join(", ")}, but \`${info?.symbolName}\` only lists ${listedText} in \`userConfigurableDeliveryMethods\`. This is the build-time counterpart of the send pipeline's runtime unlisted-delivery-method warning.`,
+      message: `Template handler factory \`${entry.factoryFunctionName ?? "<anonymous>"}\` for \`${entry.typeIdentifier}\` builds content for ${unlisted.join(", ")}, but \`${info.symbolName}\` only lists ${listedText} in ${listedIn}. This is the build-time counterpart of the send pipeline's runtime unlisted-delivery-method warning.`,
       side: "api",
       file: entry.sourceFile
     });
   }
 }
+function staticUserConfigurableDeliveryMethods(info) {
+  let result;
+  if (info.forcedDeliveryMethodsSource !== "unresolved") {
+    if (info.userConfigurableDeliveryMethodsSource === "declared") {
+      result = info.userConfigurableDeliveryMethods;
+    } else if (info.userConfigurableDeliveryMethodsSource === "default" && (info.forcedDeliveryMethods ?? []).some((method) => method !== "TEXT")) {
+      result = [];
+    }
+  }
+  return result;
+}
+function checkTemplateForcedDeliveryMethods(extracted, violations) {
+  for (const info of extracted.templateTypeInfos) {
+    const forced = info.forcedDeliveryMethodsSource === "declared" ? info.forcedDeliveryMethods ?? [] : [];
+    if (forced.includes("TEXT")) {
+      pushViolation8(violations, {
+        code: "NOTIF_TEMPLATE_FORCED_TEXT_DELIVERY_METHOD",
+        message: `Info \`${info.symbolName}\` lists TEXT in \`forcedDeliveryMethods\`. Texts cannot be forced; the info record throws at startup.`,
+        side: "component",
+        file: info.sourceFile
+      });
+    }
+    if (forced.length > 0 && info.onlySendToExplicitlyEnabledRecipients === true) {
+      pushViolation8(violations, {
+        code: "NOTIF_TEMPLATE_FORCED_DELIVERY_METHOD_EXPLICIT_OPT_IN",
+        message: `Info \`${info.symbolName}\` forces ${forced.join(", ")} while \`onlySendToExplicitlyEnabledRecipients\` is true. A forced method is on by default, so the info record throws at startup.`,
+        side: "component",
+        file: info.sourceFile
+      });
+    }
+  }
+}
 function checkTasks(extracted, violations) {
   if (extracted.taskTypeConstants.length === 0) return;
   flagTasksMissingFromAllArrays(extracted, violations);
@@ -38203,6 +38288,8 @@ function buildTemplateSummaries(extracted) {
       targetModelIdentity: info?.targetModelIdentity,
       userConfigurableDeliveryMethods: info?.userConfigurableDeliveryMethods,
       userConfigurableDeliveryMethodsSource: info?.userConfigurableDeliveryMethodsSource,
+      forcedDeliveryMethods: info?.forcedDeliveryMethods,
+      forcedDeliveryMethodsSource: info?.forcedDeliveryMethodsSource,
       factoryContentDeliveryMethods: unionContentDeliveryMethods(handlerEntriesByType.get(constant.symbolName) ?? []),
       inInfoRecord: info ? resolved.has(info.symbolName) : false,
       hasFactory: handler !== void 0,
@@ -38352,6 +38439,8 @@ function formatTemplateBlock(t) {
   if (t.targetModelIdentity) parts.push(`- Target model: \`${t.targetModelIdentity}\``);
   const deliveryMethodsText = formatUserConfigurableDeliveryMethods(t);
   if (deliveryMethodsText) parts.push(`- User-configurable delivery methods: ${deliveryMethodsText}`);
+  const forcedDeliveryMethodsText = formatForcedDeliveryMethods(t);
+  if (forcedDeliveryMethodsText) parts.push(`- Forced (always on) delivery methods: ${forcedDeliveryMethodsText}`);
   if (t.factoryContentDeliveryMethods.length > 0) parts.push(`- Factory returns content for: ${t.factoryContentDeliveryMethods.join(", ")}`);
   const infoText = t.infoSymbolName ? code6(t.infoSymbolName) : "_Missing._";
   const factorySuffix = t.factoryFunctionName ? ` (${code6(t.factoryFunctionName)})` : "";
@@ -38365,7 +38454,7 @@ function formatUserConfigurableDeliveryMethods(t) {
       result = t.userConfigurableDeliveryMethods && t.userConfigurableDeliveryMethods.length > 0 ? t.userConfigurableDeliveryMethods.join(", ") : "_none_";
       break;
     case "default":
-      result = "default";
+      result = t.forcedDeliveryMethodsSource === "declared" && (t.forcedDeliveryMethods ?? []).some((method) => method !== "TEXT") ? "_none_ (the default when the info forces a method)" : "default";
       break;
     case "unresolved":
       result = "_unresolved_";
@@ -38376,6 +38465,15 @@ function formatUserConfigurableDeliveryMethods(t) {
   }
   return result;
 }
+function formatForcedDeliveryMethods(t) {
+  let result;
+  if (t.forcedDeliveryMethodsSource === "declared" && t.forcedDeliveryMethods && t.forcedDeliveryMethods.length > 0) {
+    result = t.forcedDeliveryMethods.join(", ");
+  } else if (t.forcedDeliveryMethodsSource === "unresolved") {
+    result = "_unresolved_";
+  }
+  return result;
+}
 function formatTaskBlock(t) {
   const parts = [];
   const heading = t.typeCode ? `### ${t.typeCode} \u2014 \`${t.symbolName}\`` : `### \`${t.symbolName}\``;
@@ -44833,7 +44931,7 @@ var { formatReportAsJson: formatReportAsJson11, formatReportAsMarkdown: formatRe
 var DBX_NOTIFICATION_M_LIST_APP_TOOL = {
   name: "dbx_notification_m_list_app",
   description: [
-    "List every notification template + notification task configured in a downstream `-firebase` component + API app pair. Each entry reports its type code, metadata (human name, description, notification/target model identity), and registration flags \u2014 `inInfoRecord` + `hasFactory` for templates, `inAllArray` + `inValidateList` + `hasHandler` for tasks. Templates also report `userConfigurableDeliveryMethods` (with a `default` / `declared` / `unresolved` source) and `factoryContentDeliveryMethods`, the channels their factory builds content for.",
+    "List every notification template + notification task configured in a downstream `-firebase` component + API app pair. Each entry reports its type code, metadata (human name, description, notification/target model identity), and registration flags \u2014 `inInfoRecord` + `hasFactory` for templates, `inAllArray` + `inValidateList` + `hasHandler` for tasks. Templates also report `userConfigurableDeliveryMethods` (with a `default` / `declared` / `unresolved` source), `forcedDeliveryMethods` (always-on methods, with the same kind of source) and `factoryContentDeliveryMethods`, the channels their factory builds content for.",
     "",
     "Its JSON is the report part of the `notification.manifest.json` that `dbx-cli-generate-notification-manifest` writes at build time; this tool always scans the current source.",
     "",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dereekb/dbx-components-mcp",
-  "version": "14.15.0",
+  "version": "14.16.0",
   "sideEffects": false,
   "type": "module",
   "bin": {
@@ -12,7 +12,7 @@
     "ts-morph": "^21.0.0"
   },
   "peerDependencies": {
-    "@dereekb/dbx-cli": "14.15.0",
-    "@dereekb/util": "14.15.0"
+    "@dereekb/dbx-cli": "14.16.0",
+    "@dereekb/util": "14.16.0"
   }
 }