@depup/webpack 5.106.1-depup.0 → 5.109.2-depup.0

package/lib/sharing/ConsumeSharedFallbackDependency.js

@@ -10,6 +10,7 @@ const makeSerializable = require("../util/makeSerializable");
 
 class ConsumeSharedFallbackDependency extends ModuleDependency {
 	/**
+	 * Creates an instance of ConsumeSharedFallbackDependency.
 	 * @param {string} request the request
 	 */
 	constructor(request) {

package/lib/sharing/ConsumeSharedModule.js

@@ -39,14 +39,15 @@ const fallbackModuleCache = new WeakMap();
 /** @typedef {import("../Module").ExportsType} ExportsType */
 /** @typedef {import("../RequestShortener")} RequestShortener */
 /** @typedef {import("../ResolverFactory").ResolverWithOptions} ResolverWithOptions */
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext} ObjectDeserializerContext */
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext} ObjectSerializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext<[ConsumeOptions]>} ObjectDeserializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext<[ConsumeOptions]>} ObjectSerializerContext */
 /** @typedef {import("../util/Hash")} Hash */
 /** @typedef {import("../util/fs").InputFileSystem} InputFileSystem */
 /** @typedef {import("../util/semver").SemVerRange} SemVerRange */
 /** @typedef {import("../Module").BasicSourceTypes} BasicSourceTypes */
 
 /**
+ * Represents the consume shared module runtime component.
  * @typedef {object} ConsumeOptions
  * @property {string=} import fallback request
  * @property {string=} importResolved resolved fallback request
@@ -61,15 +62,18 @@ const fallbackModuleCache = new WeakMap();
 
 class ConsumeSharedModule extends Module {
 	/**
+	 * Creates an instance of ConsumeSharedModule.
 	 * @param {string} context context
 	 * @param {ConsumeOptions} options consume options
 	 */
 	constructor(context, options) {
 		super(WEBPACK_MODULE_TYPE_CONSUME_SHARED_MODULE, context);
+		/** @type {ConsumeOptions} */
 		this.options = options;
 	}
 
 	/**
+	 * Returns the unique identifier used to reference this module.
 	 * @returns {string} a unique identifier of the module
 	 */
 	identifier() {
@@ -88,6 +92,7 @@ class ConsumeSharedModule extends Module {
 	}
 
 	/**
+	 * Returns a human-readable identifier for this module.
 	 * @param {RequestShortener} requestShortener the request shortener
 	 * @returns {string} a user readable identifier of the module
 	 */
@@ -111,6 +116,7 @@ class ConsumeSharedModule extends Module {
 	}
 
 	/**
+	 * Gets the library identifier.
 	 * @param {LibIdentOptions} options options
 	 * @returns {LibIdent | null} an identifier for library inclusion
 	 */
@@ -124,6 +130,7 @@ class ConsumeSharedModule extends Module {
 	}
 
 	/**
+	 * Checks whether the module needs to be rebuilt for the current build state.
 	 * @param {NeedBuildContext} context context info
 	 * @param {NeedBuildCallback} callback callback function, returns true, if the module needs a rebuild
 	 * @returns {void}
@@ -133,6 +140,7 @@ class ConsumeSharedModule extends Module {
 	}
 
 	/**
+	 * Builds the module using the provided compilation context.
 	 * @param {WebpackOptions} options webpack options
 	 * @param {Compilation} compilation the compilation
 	 * @param {ResolverWithOptions} resolver the resolver
@@ -157,6 +165,7 @@ class ConsumeSharedModule extends Module {
 	}
 
 	/**
+	 * Returns the source types this module can generate.
 	 * @returns {SourceTypes} types available (do not mutate)
 	 */
 	getSourceTypes() {
@@ -177,6 +186,7 @@ class ConsumeSharedModule extends Module {
 	}
 
 	/**
+	 * Get fallback module.
 	 * @param {ModuleGraph} moduleGraph the module graph
 	 * @returns {Module | null} fallback module
 	 */
@@ -213,6 +223,7 @@ class ConsumeSharedModule extends Module {
 	}
 
 	/**
+	 * Returns export type.
 	 * @param {ModuleGraph} moduleGraph the module graph
 	 * @param {boolean | undefined} strict the importing module is strict
 	 * @returns {ExportsType} export type
@@ -228,6 +239,7 @@ class ConsumeSharedModule extends Module {
 	}
 
 	/**
+	 * Returns the estimated size for the requested source type.
 	 * @param {string=} type the source type for which the size should be estimated
 	 * @returns {number} the estimated size of the module (must be non-zero)
 	 */
@@ -236,6 +248,7 @@ class ConsumeSharedModule extends Module {
 	}
 
 	/**
+	 * Updates the hash with the data contributed by this instance.
 	 * @param {Hash} hash the hash used to track dependencies
 	 * @param {UpdateHashContext} context context
 	 * @returns {void}
@@ -246,6 +259,7 @@ class ConsumeSharedModule extends Module {
 	}
 
 	/**
+	 * Generates code and runtime requirements for this module.
 	 * @param {CodeGenerationContext} context context for code generation
 	 * @returns {CodeGenerationResult} result
 	 */
@@ -318,21 +332,21 @@ class ConsumeSharedModule extends Module {
 	}
 
 	/**
+	 * Serializes this instance into the provided serializer context.
 	 * @param {ObjectSerializerContext} context context
 	 */
 	serialize(context) {
-		const { write } = context;
-		write(this.options);
+		context.write(this.options);
 		super.serialize(context);
 	}
 
 	/**
+	 * Restores this instance from the provided deserializer context.
 	 * @param {ObjectDeserializerContext} context context
 	 */
 	deserialize(context) {
-		const { read } = context;
-		this.options = read();
-		super.deserialize(context);
+		this.options = context.read();
+		super.deserialize(context.rest);
 	}
 }
 

package/lib/sharing/ConsumeSharedPlugin.js

@@ -5,10 +5,10 @@
 
 "use strict";
 
-const ModuleNotFoundError = require("../ModuleNotFoundError");
 const RuntimeGlobals = require("../RuntimeGlobals");
-const WebpackError = require("../WebpackError");
 const { parseOptions } = require("../container/options");
+const ModuleNotFoundError = require("../errors/ModuleNotFoundError");
+const WebpackError = require("../errors/WebpackError");
 const LazySet = require("../util/LazySet");
 const { parseRange } = require("../util/semver");
 const ConsumeSharedFallbackDependency = require("./ConsumeSharedFallbackDependency");
@@ -37,14 +37,16 @@ const PLUGIN_NAME = "ConsumeSharedPlugin";
 
 class ConsumeSharedPlugin {
 	/**
+	 * Creates an instance of ConsumeSharedPlugin.
 	 * @param {ConsumeSharedPluginOptions} options options
 	 */
 	constructor(options) {
+		/** @type {ConsumeSharedPluginOptions} */
 		this.options = options;
 	}
 
 	/**
-	 * Apply the plugin
+	 * Applies the plugin by registering its hooks on the compiler.
 	 * @param {Compiler} compiler the compiler instance
 	 * @returns {void}
 	 */
@@ -149,6 +151,7 @@ class ConsumeSharedPlugin {
 				);
 
 				/**
+				 * Creates a consume shared module.
 				 * @param {string} context issuer directory
 				 * @param {string} request request
 				 * @param {ConsumeOptions} config options
@@ -156,6 +159,7 @@ class ConsumeSharedPlugin {
 				 */
 				const createConsumeSharedModule = (context, request, config) => {
 					/**
+					 * Required version warning.
 					 * @param {string} details details
 					 */
 					const requiredVersionWarning = (details) => {
@@ -171,6 +175,7 @@ class ConsumeSharedPlugin {
 					return Promise.all([
 						new Promise(
 							/**
+							 * Handles the callback logic for this hook.
 							 * @param {(value?: string) => void} resolve resolve
 							 */
 							(resolve) => {
@@ -214,6 +219,7 @@ class ConsumeSharedPlugin {
 						),
 						new Promise(
 							/**
+							 * Handles the name callback for this hook.
 							 * @param {(value?: SemVerRange) => void} resolve resolve
 							 */
 							(resolve) => {
@@ -351,15 +357,9 @@ class ConsumeSharedPlugin {
 						) {
 							return Promise.resolve();
 						}
-						const options = resolvedConsumes.get(
-							/** @type {string} */ (resource)
-						);
+						const options = resolvedConsumes.get(resource);
 						if (options !== undefined) {
-							return createConsumeSharedModule(
-								context,
-								/** @type {string} */ (resource),
-								options
-							);
+							return createConsumeSharedModule(context, resource, options);
 						}
 						return Promise.resolve();
 					}

package/lib/sharing/ConsumeSharedRuntimeModule.js

@@ -8,6 +8,7 @@
 const RuntimeGlobals = require("../RuntimeGlobals");
 const RuntimeModule = require("../RuntimeModule");
 const Template = require("../Template");
+const { compareModulesById } = require("../util/comparators");
 const {
 	parseVersionRuntimeCode,
 	rangeToStringRuntimeCode,
@@ -31,10 +32,12 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 	 */
 	constructor(runtimeRequirements) {
 		super("consumes", RuntimeModule.STAGE_ATTACH);
+		/** @type {ReadOnlyRuntimeRequirements} */
 		this._runtimeRequirements = runtimeRequirements;
 	}
 
 	/**
+	 * Generates runtime code for this runtime module.
 	 * @returns {string | null} runtime code
 	 */
 	generate() {
@@ -70,12 +73,14 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 				);
 			}
 		};
+		const byId = compareModulesById(chunkGraph);
 		for (const chunk of /** @type {Chunk} */ (
 			this.chunk
 		).getAllReferencedChunks()) {
-			const modules = chunkGraph.getChunkModulesIterableBySourceType(
+			const modules = chunkGraph.getOrderedChunkModulesIterableBySourceType(
 				chunk,
-				"consume-shared"
+				"consume-shared",
+				byId
 			);
 			if (!modules) continue;
 			addModules(
@@ -87,27 +92,29 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 		for (const chunk of /** @type {Chunk} */ (
 			this.chunk
 		).getAllInitialChunks()) {
-			const modules = chunkGraph.getChunkModulesIterableBySourceType(
+			const modules = chunkGraph.getOrderedChunkModulesIterableBySourceType(
 				chunk,
-				"consume-shared"
+				"consume-shared",
+				byId
 			);
 			if (!modules) continue;
 			addModules(modules, chunk, initialConsumes);
 		}
 		if (moduleIdToSourceMapping.size === 0) return null;
+		const cst = runtimeTemplate.renderConst();
 		return Template.asString([
 			parseVersionRuntimeCode(runtimeTemplate),
 			versionLtRuntimeCode(runtimeTemplate),
 			rangeToStringRuntimeCode(runtimeTemplate),
 			satisfyRuntimeCode(runtimeTemplate),
-			`var exists = ${runtimeTemplate.basicFunction("scope, key", [
+			`${cst} exists = ${runtimeTemplate.basicFunction("scope, key", [
 				`return scope && ${RuntimeGlobals.hasOwnProperty}(scope, key);`
 			])}`,
-			`var get = ${runtimeTemplate.basicFunction("entry", [
+			`${cst} get = ${runtimeTemplate.basicFunction("entry", [
 				"entry.loaded = 1;",
 				"return entry.get()"
 			])};`,
-			`var eagerOnly = ${runtimeTemplate.basicFunction("versions", [
+			`${cst} eagerOnly = ${runtimeTemplate.basicFunction("versions", [
 				`return Object.keys(versions).reduce(${runtimeTemplate.basicFunction(
 					"filtered, version",
 					Template.indent([
@@ -118,10 +125,10 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 					])
 				)}, {});`
 			])};`,
-			`var findLatestVersion = ${runtimeTemplate.basicFunction(
+			`${cst} findLatestVersion = ${runtimeTemplate.basicFunction(
 				"scope, key, eager",
 				[
-					"var versions = eager ? eagerOnly(scope[key]) : scope[key];",
+					`${cst} versions = eager ? eagerOnly(scope[key]) : scope[key];`,
 					`var key = Object.keys(versions).reduce(${runtimeTemplate.basicFunction(
 						"a, b",
 						["return !a || versionLt(a, b) ? b : a;"]
@@ -129,10 +136,10 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 					"return key && versions[key];"
 				]
 			)};`,
-			`var findSatisfyingVersion = ${runtimeTemplate.basicFunction(
+			`${cst} findSatisfyingVersion = ${runtimeTemplate.basicFunction(
 				"scope, key, requiredVersion, eager",
 				[
-					"var versions = eager ? eagerOnly(scope[key]) : scope[key];",
+					`${cst} versions = eager ? eagerOnly(scope[key]) : scope[key];`,
 					`var key = Object.keys(versions).reduce(${runtimeTemplate.basicFunction(
 						"a, b",
 						[
@@ -143,26 +150,26 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 					"return key && versions[key]"
 				]
 			)};`,
-			`var findSingletonVersionKey = ${runtimeTemplate.basicFunction(
+			`${cst} findSingletonVersionKey = ${runtimeTemplate.basicFunction(
 				"scope, key, eager",
 				[
-					"var versions = eager ? eagerOnly(scope[key]) : scope[key];",
+					`${cst} versions = eager ? eagerOnly(scope[key]) : scope[key];`,
 					`return Object.keys(versions).reduce(${runtimeTemplate.basicFunction(
 						"a, b",
 						["return !a || (!versions[a].loaded && versionLt(a, b)) ? b : a;"]
 					)}, 0);`
 				]
 			)};`,
-			`var getInvalidSingletonVersionMessage = ${runtimeTemplate.basicFunction(
+			`${cst} getInvalidSingletonVersionMessage = ${runtimeTemplate.basicFunction(
 				"scope, key, version, requiredVersion",
 				[
 					'return "Unsatisfied version " + version + " from " + (version && scope[key][version].from) + " of shared singleton module " + key + " (required " + rangeToString(requiredVersion) + ")"'
 				]
 			)};`,
-			`var getInvalidVersionMessage = ${runtimeTemplate.basicFunction(
+			`${cst} getInvalidVersionMessage = ${runtimeTemplate.basicFunction(
 				"scope, scopeName, key, requiredVersion, eager",
 				[
-					"var versions = scope[key];",
+					`${cst} versions = scope[key];`,
 					'return "No satisfying version (" + rangeToString(requiredVersion) + ")" + (eager ? " for eager consumption" : "") + " of shared module " + key + " found in shared scope " + scopeName + ".\\n" +',
 					`\t"Available versions: " + Object.keys(versions).map(${runtimeTemplate.basicFunction(
 						"key",
@@ -170,26 +177,29 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 					)}).join(", ");`
 				]
 			)};`,
-			`var fail = ${runtimeTemplate.basicFunction("msg", [
+			`${cst} fail = ${runtimeTemplate.basicFunction("msg", [
 				"throw new Error(msg);"
 			])}`,
-			`var failAsNotExist = ${runtimeTemplate.basicFunction("scopeName, key", [
-				'return fail("Shared module " + key + " doesn\'t exist in shared scope " + scopeName);'
-			])}`,
-			`var warn = /*#__PURE__*/ ${
+			`${cst} failAsNotExist = ${runtimeTemplate.basicFunction(
+				"scopeName, key",
+				[
+					'return fail("Shared module " + key + " doesn\'t exist in shared scope " + scopeName);'
+				]
+			)}`,
+			`${cst} warn = /*#__PURE__*/ ${
 				compilation.outputOptions.ignoreBrowserWarnings
 					? runtimeTemplate.basicFunction("", "")
 					: runtimeTemplate.basicFunction("msg", [
 							'if (typeof console !== "undefined" && console.warn) console.warn(msg);'
 						])
 			};`,
-			`var init = ${runtimeTemplate.returningFunction(
+			`${cst} init = ${runtimeTemplate.returningFunction(
 				Template.asString([
 					"function(scopeName, key, eager, c, d) {",
 					Template.indent([
-						`var promise = ${RuntimeGlobals.initializeSharing}(scopeName);`,
+						`${cst} promise = ${RuntimeGlobals.initializeSharing}(scopeName);`,
 						// if we require eager shared, we expect it to be already loaded before it requested, no need to wait the whole scope loaded.
-						"if (promise && promise.then && !eager) { ",
+						`if (${runtimeTemplate.optionalChaining("promise", "then")} && !eager) { `,
 						Template.indent([
 							`return promise.then(fn.bind(fn, scopeName, ${RuntimeGlobals.shareScopeMap}[scopeName], key, false, c, d));`
 						]),
@@ -201,50 +211,50 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 				"fn"
 			)};`,
 			"",
-			`var useFallback = ${runtimeTemplate.basicFunction(
+			`${cst} useFallback = ${runtimeTemplate.basicFunction(
 				"scopeName, key, fallback",
 				["return fallback ? fallback() : failAsNotExist(scopeName, key);"]
 			)}`,
-			`var load = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
+			`${cst} load = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
 				"scopeName, scope, key, eager, fallback",
 				[
 					"if (!exists(scope, key)) return useFallback(scopeName, key, fallback);",
 					"return get(findLatestVersion(scope, key, eager));"
 				]
 			)});`,
-			`var loadVersion = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
+			`${cst} loadVersion = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
 				"scopeName, scope, key, eager, requiredVersion, fallback",
 				[
 					"if (!exists(scope, key)) return useFallback(scopeName, key, fallback);",
-					"var satisfyingVersion = findSatisfyingVersion(scope, key, requiredVersion, eager);",
+					`${cst} satisfyingVersion = findSatisfyingVersion(scope, key, requiredVersion, eager);`,
 					"if (satisfyingVersion) return get(satisfyingVersion);",
 					"warn(getInvalidVersionMessage(scope, scopeName, key, requiredVersion, eager))",
 					"return get(findLatestVersion(scope, key, eager));"
 				]
 			)});`,
-			`var loadStrictVersion = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
+			`${cst} loadStrictVersion = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
 				"scopeName, scope, key, eager, requiredVersion, fallback",
 				[
 					"if (!exists(scope, key)) return useFallback(scopeName, key, fallback);",
-					"var satisfyingVersion = findSatisfyingVersion(scope, key, requiredVersion, eager);",
+					`${cst} satisfyingVersion = findSatisfyingVersion(scope, key, requiredVersion, eager);`,
 					"if (satisfyingVersion) return get(satisfyingVersion);",
 					"if (fallback) return fallback();",
 					"fail(getInvalidVersionMessage(scope, scopeName, key, requiredVersion, eager));"
 				]
 			)});`,
-			`var loadSingleton = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
+			`${cst} loadSingleton = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
 				"scopeName, scope, key, eager, fallback",
 				[
 					"if (!exists(scope, key)) return useFallback(scopeName, key, fallback);",
-					"var version = findSingletonVersionKey(scope, key, eager);",
+					`${cst} version = findSingletonVersionKey(scope, key, eager);`,
 					"return get(scope[key][version]);"
 				]
 			)});`,
-			`var loadSingletonVersion = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
+			`${cst} loadSingletonVersion = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
 				"scopeName, scope, key, eager, requiredVersion, fallback",
 				[
 					"if (!exists(scope, key)) return useFallback(scopeName, key, fallback);",
-					"var version = findSingletonVersionKey(scope, key, eager);",
+					`${cst} version = findSingletonVersionKey(scope, key, eager);`,
 					"if (!satisfy(requiredVersion, version)) {",
 					Template.indent([
 						"warn(getInvalidSingletonVersionMessage(scope, key, version, requiredVersion));"
@@ -253,11 +263,11 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 					"return get(scope[key][version]);"
 				]
 			)});`,
-			`var loadStrictSingletonVersion = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
+			`${cst} loadStrictSingletonVersion = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
 				"scopeName, scope, key, eager, requiredVersion, fallback",
 				[
 					"if (!exists(scope, key)) return useFallback(scopeName, key, fallback);",
-					"var version = findSingletonVersionKey(scope, key, eager);",
+					`${cst} version = findSingletonVersionKey(scope, key, eager);`,
 					"if (!satisfy(requiredVersion, version)) {",
 					Template.indent([
 						"fail(getInvalidSingletonVersionMessage(scope, key, version, requiredVersion));"
@@ -266,8 +276,8 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 					"return get(scope[key][version]);"
 				]
 			)});`,
-			"var installedModules = {};",
-			"var moduleToHandlerMapping = {",
+			`${cst} installedModules = {};`,
+			`${cst} moduleToHandlerMapping = {`,
 			Template.indent(
 				Array.from(
 					moduleIdToSourceMapping,
@@ -278,7 +288,7 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 
 			initialConsumes.length > 0
 				? Template.asString([
-						`var initialConsumes = ${JSON.stringify(initialConsumes)};`,
+						`${cst} initialConsumes = ${JSON.stringify(initialConsumes)};`,
 						`initialConsumes.forEach(${runtimeTemplate.basicFunction("id", [
 							`${
 								RuntimeGlobals.moduleFactories
@@ -286,7 +296,7 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 								"// Handle case when module is used sync",
 								"installedModules[id] = 0;",
 								`delete ${RuntimeGlobals.moduleCache}[id];`,
-								"var factory = moduleToHandlerMapping[id]();",
+								`${cst} factory = moduleToHandlerMapping[id]();`,
 								'if(typeof factory !== "function") throw new Error("Shared module is not available for eager consumption: " + id);',
 								"module.exports = factory();"
 							])}`
@@ -295,12 +305,12 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 				: "// no consumes in initial chunks",
 			this._runtimeRequirements.has(RuntimeGlobals.ensureChunkHandlers)
 				? Template.asString([
-						`var chunkMapping = ${JSON.stringify(
+						`${cst} chunkMapping = ${JSON.stringify(
 							chunkToModuleMapping,
 							null,
 							"\t"
 						)};`,
-						"var startedInstallModules = {};",
+						`${cst} startedInstallModules = {};`,
 						`${
 							RuntimeGlobals.ensureChunkHandlers
 						}.consumes = ${runtimeTemplate.basicFunction("chunkId, promises", [
@@ -311,7 +321,7 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 									[
 										`if(${RuntimeGlobals.hasOwnProperty}(installedModules, id)) return promises.push(installedModules[id]);`,
 										"if(!startedInstallModules[id]) {",
-										`var onFactory = ${runtimeTemplate.basicFunction(
+										`${cst} onFactory = ${runtimeTemplate.basicFunction(
 											"factory",
 											[
 												"installedModules[id] = 0;",
@@ -324,7 +334,7 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 											]
 										)};`,
 										"startedInstallModules[id] = true;",
-										`var onError = ${runtimeTemplate.basicFunction("error", [
+										`${cst} onError = ${runtimeTemplate.basicFunction("error", [
 											"delete installedModules[id];",
 											`${
 												RuntimeGlobals.moduleFactories
@@ -335,7 +345,7 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 										])};`,
 										"try {",
 										Template.indent([
-											"var promise = moduleToHandlerMapping[id]();",
+											`${cst} promise = moduleToHandlerMapping[id]();`,
 											"if(promise.then) {",
 											Template.indent(
 												"promises.push(installedModules[id] = promise.then(onFactory)['catch'](onError));"

package/lib/sharing/ProvideForSharedDependency.js

@@ -10,6 +10,7 @@ const makeSerializable = require("../util/makeSerializable");
 
 class ProvideForSharedDependency extends ModuleDependency {
 	/**
+	 * Creates an instance of ProvideForSharedDependency.
 	 * @param {string} request request string
 	 */
 	constructor(request) {

package/lib/sharing/ProvideSharedDependency.js

@@ -8,11 +8,12 @@
 const Dependency = require("../Dependency");
 const makeSerializable = require("../util/makeSerializable");
 
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext} ObjectDeserializerContext */
-/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext} ObjectSerializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectDeserializerContext<[string, string, string, string | false, boolean]>} ObjectDeserializerContext */
+/** @typedef {import("../serialization/ObjectMiddleware").ObjectSerializerContext<[string, string, string, string | false, boolean]>} ObjectSerializerContext */
 
 class ProvideSharedDependency extends Dependency {
 	/**
+	 * Creates an instance of ProvideSharedDependency.
 	 * @param {string} shareScope share scope
 	 * @param {string} name module name
 	 * @param {string | false} version version
@@ -21,10 +22,15 @@ class ProvideSharedDependency extends Dependency {
 	 */
 	constructor(shareScope, name, version, request, eager) {
 		super();
+		/** @type {string} */
 		this.shareScope = shareScope;
+		/** @type {string} */
 		this.name = name;
+		/** @type {string | false} */
 		this.version = version;
+		/** @type {string} */
 		this.request = request;
+		/** @type {boolean} */
 		this.eager = eager;
 	}
 
@@ -33,6 +39,7 @@ class ProvideSharedDependency extends Dependency {
 	}
 
 	/**
+	 * Returns an identifier to merge equal requests.
 	 * @returns {string | null} an identifier to merge equal requests
 	 */
 	getResourceIdentifier() {
@@ -42,32 +49,44 @@ class ProvideSharedDependency extends Dependency {
 	}
 
 	/**
+	 * Serializes this instance into the provided serializer context.
 	 * @param {ObjectSerializerContext} context context
 	 */
 	serialize(context) {
-		context.write(this.shareScope);
-		context.write(this.name);
-		context.write(this.request);
-		context.write(this.version);
-		context.write(this.eager);
+		context
+			.write(this.shareScope)
+			.write(this.name)
+			.write(this.request)
+			.write(this.version)
+			.write(this.eager);
 		super.serialize(context);
 	}
 
 	/**
+	 * Restores this instance from the provided deserializer context.
 	 * @param {ObjectDeserializerContext} context context
 	 * @returns {ProvideSharedDependency} deserialize fallback dependency
 	 */
 	static deserialize(context) {
-		const { read } = context;
+		// wire order is shareScope, name, request, version, eager;
+		// reorder into the constructor's (…, version, request, …) signature
+		const shareScope = context.read();
+		const c1 = context.rest;
+		const name = c1.read();
+		const c2 = c1.rest;
+		const request = c2.read();
+		const c3 = c2.rest;
+		const version = c3.read();
+		const c4 = c3.rest;
+		const eager = c4.read();
 		const obj = new ProvideSharedDependency(
-			read(),
-			read(),
-			read(),
-			read(),
-			read()
+			shareScope,
+			name,
+			version,
+			request,
+			eager
 		);
-		this.shareScope = context.read();
-		obj.deserialize(context);
+		obj.deserialize(c4.rest);
 		return obj;
 	}
 }