@depup/nx 23.2.0-depup.2 → 23.2.1-depup.1

package/dist/src/project-graph/plugins/isolation/isolated-plugin.d.ts

@@ -1,3 +1,5 @@
+import { ChildProcess } from 'child_process';
+import { Socket } from 'net';
 import type { PluginConfiguration } from '../../../config/nx-json';
 import type { ProjectGraph } from '../../../config/project-graph';
 import type { RawProjectGraphDependency } from '../../project-graph-builder';
@@ -40,6 +42,13 @@ export declare class IsolatedPlugin implements LoadedNxPlugin {
     static load(plugin: PluginConfiguration, root: string, index?: number): Promise<IsolatedPlugin>;
     private constructor();
     private spawnAndConnect;
+    /**
+     * Drops the worker from service without judging why. The next hook call
+     * respawns it through `ensureAlive`.
+     */
+    private markUnusable;
+    private failPendingRequests;
+    private handleFramingFailure;
     /**
      * Ensures the worker is alive, restarting it if necessary.
      * Called before each hook execution to handle plugins that were
@@ -61,6 +70,7 @@ export declare class IsolatedPlugin implements LoadedNxPlugin {
     private registerProcessMetrics;
 }
 export declare function getPluginWorkerSocketId(): string;
+export declare function connectToWorker(worker: ChildProcess, ipcPath: string, name: string): Promise<Socket>;
 /**
  * Marks a failure to *start or reach* a worker, as distinct from a plugin that
  * loaded and then threw. Only the former can be retried in-process: swallowing
@@ -75,5 +85,11 @@ export declare const PLUGIN_WORKER_STARTUP_FAILURE: unique symbol;
  * also degrading for an OOM kill or a broken install.
  */
 export declare const PLUGIN_WORKER_SOCKET_REFUSED: unique symbol;
+/**
+ * Describes how a worker died for an error message. A `null` code with a signal
+ * is an outside kill rather than anything the worker chose, and SIGKILL is what
+ * an out-of-memory kill looks like, so both are called out by name.
+ */
+export declare function describeWorkerExit(code: number | null, signal: NodeJS.Signals | null): string;
 export declare function isPluginWorkerStartupFailure(error: unknown): boolean;
 export declare function isPluginWorkerSocketRefusal(error: unknown): boolean;

package/dist/src/project-graph/plugins/isolation/isolated-plugin.js

@@ -2,6 +2,8 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.PLUGIN_WORKER_SOCKET_REFUSED = exports.PLUGIN_WORKER_STARTUP_FAILURE = exports.IsolatedPlugin = void 0;
 exports.getPluginWorkerSocketId = getPluginWorkerSocketId;
+exports.connectToWorker = connectToWorker;
+exports.describeWorkerExit = describeWorkerExit;
 exports.isPluginWorkerStartupFailure = isPluginWorkerStartupFailure;
 exports.isPluginWorkerSocketRefusal = isPluginWorkerSocketRefusal;
 const child_process_1 = require("child_process");
@@ -93,32 +95,51 @@ class IsolatedPlugin {
         this.worker = worker;
         this.socket = socket;
         this.registerProcessMetrics();
-        this.exitHandler = () => {
-            this._alive = false;
-            this._connectPromise = null;
-            if (this.worker?.stdout) {
-                this.worker.stdout.unpipe(process.stdout);
-            }
-            if (this.worker?.stderr) {
-                this.worker.stderr.unpipe(process.stderr);
-            }
-            // Reject all pending requests
-            const error = new Error(`Plugin worker "${this.name}" exited unexpectedly.`);
-            for (const { onError } of this.responseHandlers.values()) {
-                onError(error);
-            }
-            this.responseHandlers.clear();
+        this.exitHandler = (code, signal) => {
+            this.markUnusable();
+            this.failPendingRequests(new Error(`Plugin worker "${this.name}" exited unexpectedly ${describeWorkerExit(code, signal)}.`));
         };
         worker.on('exit', this.exitHandler);
         socket.on('data', (0, consume_messages_from_socket_1.consumeMessagesFromSocket)(this.handleSocketData, (err) => {
-            // Nothing else settles the pending hook promises on a framing
-            // failure, so surface it the same way a dead worker would.
-            this.exitHandler?.();
-            socket.destroy();
-            console.error(err.message);
+            // The worker may still be running here; it is the stream that failed, so
+            // reporting this as an exit would send whoever reads it hunting for a
+            // dead process.
+            this.handleFramingFailure(socket, err);
         }));
         return this.sendLoadMessage();
     }
+    /**
+     * Drops the worker from service without judging why. The next hook call
+     * respawns it through `ensureAlive`.
+     */
+    markUnusable() {
+        this._alive = false;
+        this._connectPromise = null;
+        if (this.worker?.stdout) {
+            this.worker.stdout.unpipe(process.stdout);
+        }
+        if (this.worker?.stderr) {
+            this.worker.stderr.unpipe(process.stderr);
+        }
+    }
+    failPendingRequests(error) {
+        for (const { onError } of this.responseHandlers.values()) {
+            onError(error);
+        }
+        this.responseHandlers.clear();
+    }
+    handleFramingFailure(socket, error) {
+        const framingError = new Error(`Plugin worker "${this.name}" sent a message the host could not read, ` +
+            `so its connection was dropped. ${error.message}`);
+        this.markUnusable();
+        socket.destroy();
+        if (this.responseHandlers.size === 0) {
+            console.error(framingError.message);
+        }
+        else {
+            this.failPendingRequests(framingError);
+        }
+    }
     /**
      * Ensures the worker is alive, restarting it if necessary.
      * Called before each hook execution to handle plugins that were
@@ -430,7 +451,7 @@ async function connectToWorker(worker, ipcPath, name) {
     let earlyExitError = null;
     // If the worker exits before we connect, abort polling immediately
     // rather than burning through attempts against a dead socket.
-    worker.once('exit', (code) => {
+    worker.once('exit', (code, signal) => {
         if (!abortController.signal.aborted) {
             // The worker sets this code only after an EPERM/EACCES on its own bind,
             // so it is proof of a refusal rather than an inference from the
@@ -438,7 +459,7 @@ async function connectToWorker(worker, ipcPath, name) {
             // sets no variable `isSandbox()` reads.
             const refused = code === socket_refused_exit_code_1.SOCKET_REFUSED_EXIT_CODE;
             earlyExitError = markWorkerStartupFailure(new Error([
-                `Plugin worker for "${name}" exited with code ${code} before the connection was established.`,
+                `Plugin worker for "${name}" exited ${describeWorkerExit(code, signal)} before the connection was established.`,
                 // The worker's own stderr may be lost with the process, so the
                 // cause and the fix are repeated here.
                 ...(refused || (0, is_sandbox_1.isSandbox)()
@@ -476,6 +497,22 @@ exports.PLUGIN_WORKER_STARTUP_FAILURE = Symbol.for('nx.pluginWorkerStartupFailur
  * also degrading for an OOM kill or a broken install.
  */
 exports.PLUGIN_WORKER_SOCKET_REFUSED = Symbol.for('nx.pluginWorkerSocketRefused');
+/**
+ * Describes how a worker died for an error message. A `null` code with a signal
+ * is an outside kill rather than anything the worker chose, and SIGKILL is what
+ * an out-of-memory kill looks like, so both are called out by name.
+ */
+function describeWorkerExit(code, signal) {
+    if (signal) {
+        return signal === 'SIGKILL'
+            ? `(killed by ${signal}, commonly an out-of-memory kill)`
+            : `(killed by ${signal})`;
+    }
+    if (code !== null) {
+        return `(exit code ${code})`;
+    }
+    return '(no exit code or signal reported)';
+}
 function markWorkerStartupFailure(error, refused = false) {
     error[exports.PLUGIN_WORKER_STARTUP_FAILURE] = true;
     if (refused) {

package/dist/src/tasks-runner/forked-process-task-runner.d.ts

@@ -11,6 +11,8 @@ export declare class ForkedProcessTaskRunner {
     cliPath: string;
     private readonly verbose;
     private processes;
+    private processMessageHandler;
+    private processExitHandler;
     private finishedProcesses;
     private pseudoTerminals;
     constructor(options: DefaultTasksRunnerOptions, tuiEnabled: boolean);
@@ -39,4 +41,5 @@ export declare class ForkedProcessTaskRunner {
     private writeTerminalOutput;
     cleanup(signal?: NodeJS.Signals): Promise<void>;
     private setupProcessEventListeners;
+    removeProcessEventListeners(): void;
 }

package/dist/src/tasks-runner/forked-process-task-runner.js

@@ -269,7 +269,7 @@ class ForkedProcessTaskRunner {
         this.cleanUpBatchProcesses();
     }
     setupProcessEventListeners() {
-        const messageHandler = (message) => {
+        this.processMessageHandler = (message) => {
             this.pseudoTerminals.forEach((p) => {
                 p.sendMessageToChildren(message);
             });
@@ -279,21 +279,30 @@ class ForkedProcessTaskRunner {
                 }
             });
         };
+        this.processExitHandler = () => {
+            this.cleanup();
+            process.off('message', this.processMessageHandler);
+        };
         // When the nx process gets a message, it will be sent into the task's process
-        process.on('message', messageHandler);
+        process.on('message', this.processMessageHandler);
         // Terminate any task processes on exit (sync, last resort).
         // cleanup() is async but the initial signal dispatch is synchronous
         // (killProcessTreeGraceful snapshots and signals before the async
         // grace period). The grace period won't complete here, but each
         // child also has its own sync exit handler as a final fallback.
-        process.once('exit', () => {
-            this.cleanup();
-            process.off('message', messageHandler);
-        });
+        process.once('exit', this.processExitHandler);
         // No SIGINT/SIGTERM/SIGHUP handlers here. The orchestrator's
         // setupSignalHandlers() owns signal dispatch and calls FPTR.cleanup()
         // in the direct path; in the forked path the process is detached
         // and never receives these signals from the OS.
     }
+    // Long-lived processes (Nx Cloud agents) create a runner per invocation;
+    // without this each instance stays reachable from `process` forever.
+    // Call only after cleanup(): the exit handler is the last-resort child
+    // kill, so it must not be removed while children may still be alive.
+    removeProcessEventListeners() {
+        process.off('message', this.processMessageHandler);
+        process.off('exit', this.processExitHandler);
+    }
 }
 exports.ForkedProcessTaskRunner = ForkedProcessTaskRunner;

package/dist/src/tasks-runner/init-tasks-runner.js

@@ -9,6 +9,7 @@ const life_cycle_1 = require("./life-cycle");
 const task_orchestrator_1 = require("./task-orchestrator");
 const create_task_hasher_1 = require("../hasher/create-task-hasher");
 const client_1 = require("../daemon/client/client");
+const shared_running_task_1 = require("./running-tasks/shared-running-task");
 const task_results_life_cycle_1 = require("./life-cycles/task-results-life-cycle");
 async function createOrchestrator(tasks, projectGraph, fullTaskGraph, nxJson, lifeCycle) {
     (0, dotenv_1.loadRootEnvFiles)();
@@ -47,6 +48,11 @@ async function createOrchestrator(tasks, projectGraph, fullTaskGraph, nxJson, li
     orchestrator.processAllScheduledTasks();
     return orchestrator;
 }
+// Nothing awaits the dispose chains below, so an unhandled rejection would take
+// down a long-lived agent process.
+function logDisposeFailure(e) {
+    console.error('Failed to dispose the task orchestrator:', e);
+}
 async function runDiscreteTasks(tasks, projectGraph, fullTaskGraph, nxJson, lifeCycle) {
     const orchestrator = await createOrchestrator(tasks, projectGraph, fullTaskGraph, nxJson, lifeCycle);
     let groupId = 0;
@@ -75,12 +81,36 @@ async function runDiscreteTasks(tasks, projectGraph, fullTaskGraph, nxJson, life
             return [hit];
         return [await orchestrator.runTaskDirectly(true, task, groupId++)];
     });
-    return [...batchResults, ...taskResults];
+    const results = [...batchResults, ...taskResults];
+    // Callers like Nx Cloud agents create an orchestrator per invocation in a
+    // long-lived process; release its process-level listeners once all tasks
+    // settle, otherwise every invocation's orchestrator stays reachable forever.
+    // Not awaited, so callers keep consuming handles as they settle; the forked
+    // runner's exit handler still reaps children until dispose() runs.
+    Promise.allSettled(results)
+        .then(() => orchestrator.dispose())
+        .catch(logDisposeFailure);
+    return results;
 }
 async function runContinuousTasks(tasks, projectGraph, fullTaskGraph, nxJson, lifeCycle) {
     const orchestrator = await createOrchestrator(tasks, projectGraph, fullTaskGraph, nxJson, lifeCycle);
-    return tasks.reduce((current, task, index) => {
+    const runningTasks = tasks.reduce((current, task, index) => {
         current[task.id] = orchestrator.startContinuousTask(task, index);
         return current;
     }, {});
+    // Unlike runDiscreteTasks, this must resolve at task start: callers keep
+    // the RunningTask handles to kill later, so disposal has to be deferred
+    // until every task actually exits.
+    Promise.allSettled(Object.entries(runningTasks).map(async ([taskId, promise]) => {
+        const runningTask = await promise;
+        // A shared task is owned by another nx process; this orchestrator has
+        // no child to protect for it, so disposal does not wait on it.
+        if (runningTask instanceof shared_running_task_1.SharedRunningTask) {
+            return;
+        }
+        await orchestrator.waitForContinuousTaskExit(taskId);
+    }))
+        .then(() => orchestrator.dispose())
+        .catch(logDisposeFailure);
+    return runningTasks;
 }

package/dist/src/tasks-runner/life-cycles/task-history-life-cycle.js

@@ -22,6 +22,8 @@ function getTasksHistoryLifeCycle() {
 class TaskHistoryLifeCycle {
     constructor() {
         this.startTimings = {};
+        // Holds no terminalOutput: this singleton outlives every run in the
+        // process, and agents complete thousands of tasks in one process.
         this.pendingResults = new Map();
         this.taskRuns = new Map();
         this.taskHistory = (0, task_history_1.getTaskHistory)();
@@ -36,25 +38,28 @@ class TaskHistoryLifeCycle {
         }
     }
     async endTasks(taskResults) {
-        for (const taskResult of taskResults) {
-            this.pendingResults.set(taskResult.task.id, taskResult);
+        for (const { task, code, status } of taskResults) {
+            this.pendingResults.set(task.id, { task, code, status });
         }
     }
     async endCommand() {
+        const pendingResults = Array.from(this.pendingResults.values());
+        this.pendingResults.clear();
         if (!this.taskHistory) {
             return;
         }
         // Build TaskRun objects now — task.hash is guaranteed to be set by this point
-        for (const [, taskResult] of this.pendingResults) {
-            this.taskRuns.set(taskResult.task.hash, {
-                hash: taskResult.task.hash,
-                target: taskResult.task.target,
-                code: taskResult.code,
-                status: taskResult.status,
-                start: taskResult.task.startTime ?? this.startTimings[taskResult.task.id],
-                end: taskResult.task.endTime ?? Date.now(),
-                cacheable: taskResult.task.cache === true,
+        for (const { task, code, status } of pendingResults) {
+            this.taskRuns.set(task.hash, {
+                hash: task.hash,
+                target: task.target,
+                code,
+                status,
+                start: task.startTime ?? this.startTimings[task.id],
+                end: task.endTime ?? Date.now(),
+                cacheable: task.cache === true,
             });
+            delete this.startTimings[task.id];
         }
         const runs = [];
         // Only check for flaky tasks among cacheable tasks

package/dist/src/tasks-runner/running-tasks/batch-process.js

@@ -233,6 +233,9 @@ class BatchProcess {
             this.capturedOutputFd = undefined;
         }
     }
+    // Resolves on the CompleteBatchExecution message, not process exit: the
+    // child can outlive its results (open handles keep it alive), so callers
+    // must not treat a settled batch as an exited process.
     async getResults() {
         return Promise.race([
             new Promise((_, rej) => {

package/dist/src/tasks-runner/running-tasks/shared-running-task.d.ts

@@ -3,6 +3,7 @@ import { RunningTasksService } from '../../native';
 export declare class SharedRunningTask implements RunningTask {
     private runningTasksService;
     private exitCallbacks;
+    private detached;
     constructor(runningTasksService: RunningTasksService, taskId: string);
     getResults(): Promise<{
         code: number;

package/dist/src/tasks-runner/running-tasks/shared-running-task.js

@@ -5,7 +5,11 @@ class SharedRunningTask {
     constructor(runningTasksService, taskId) {
         this.runningTasksService = runningTasksService;
         this.exitCallbacks = [];
+        this.detached = false;
         this.waitForTaskToFinish(taskId).then(() => {
+            if (this.detached) {
+                return;
+            }
             // notify exit callbacks
             this.exitCallbacks.forEach((cb) => cb(0));
         });
@@ -13,8 +17,14 @@ class SharedRunningTask {
     async getResults() {
         throw new Error('Results cannot be retrieved from a shared task');
     }
+    // Detaches from the shared task; the owning process keeps running it.
     kill() {
+        if (this.detached) {
+            return;
+        }
+        this.detached = true;
         this.exitCallbacks.forEach((cb) => cb(0));
+        this.exitCallbacks = [];
     }
     onExit(cb) {
         this.exitCallbacks.push(cb);
@@ -24,7 +34,8 @@ class SharedRunningTask {
         // wait for the running task to finish
         do {
             await new Promise((resolve) => setTimeout(resolve, 100));
-        } while (this.runningTasksService.getRunningTasks([taskId]).length);
+        } while (!this.detached &&
+            this.runningTasksService.getRunningTasks([taskId]).length);
     }
 }
 exports.SharedRunningTask = SharedRunningTask;

package/dist/src/tasks-runner/task-orchestrator.d.ts

@@ -56,6 +56,7 @@ export declare class TaskOrchestrator {
     private discreteTaskExitHandled;
     private continuousTaskExitHandled;
     private cleanupPromise;
+    private signalHandlers;
     constructor(hasher: TaskHasher, initiatingProject: string | undefined, initiatingTasks: Task[], projectGraph: ProjectGraph, taskGraph: TaskGraph, nxJson: NxJsonConfiguration, options: NxArgs & DefaultTasksRunnerOptions, bail: boolean, daemon: DaemonClient, outputStyle: string, fullTaskGraph?: TaskGraph);
     init(): Promise<void>;
     run(): Promise<{
@@ -251,6 +252,8 @@ export declare class TaskOrchestrator {
     private cleanup;
     private performCleanup;
     private setupSignalHandlers;
+    waitForContinuousTaskExit(taskId: string): Promise<void>;
+    dispose(): Promise<void>;
     private cleanUpUnneededContinuousTasks;
 }
 export declare function getThreadPoolSize(options: NxArgs & DefaultTasksRunnerOptions, taskGraph: TaskGraph): {

package/dist/src/tasks-runner/task-orchestrator.js

@@ -105,6 +105,7 @@ class TaskOrchestrator {
         this.discreteTaskExitHandled = new Map();
         this.continuousTaskExitHandled = new Map();
         this.cleanupPromise = null;
+        this.signalHandlers = [];
     }
     async init() {
         this.setupSignalHandlers();
@@ -159,6 +160,7 @@ class TaskOrchestrator {
             this.cache.removeOldCacheRecords();
         }
         await this.cleanup();
+        await this.dispose();
         // Public API (defaultTasksRunner) returns a plain object keyed by
         // task id. Internal state is a Map for faster lookup.
         return Object.fromEntries(this.completedTasks);
@@ -1474,9 +1476,35 @@ class TaskOrchestrator {
                 }
             });
         };
-        process.on('SIGINT', () => handleSignal('SIGINT'));
-        process.on('SIGTERM', () => handleSignal('SIGTERM'));
-        process.on('SIGHUP', () => handleSignal('SIGHUP'));
+        for (const signal of ['SIGINT', 'SIGTERM', 'SIGHUP']) {
+            const handler = () => handleSignal(signal);
+            this.signalHandlers.push([signal, handler]);
+            process.on(signal, handler);
+        }
+    }
+    // Registered at child creation, so unlike subscribing to RunningTask.onExit
+    // after the fact it cannot miss an exit that already happened.
+    waitForContinuousTaskExit(taskId) {
+        return this.continuousTaskExitHandled.get(taskId) ?? Promise.resolve();
+    }
+    // Releases the process-level listeners registered by setupSignalHandlers.
+    // Each closes over `this`, so a long-lived caller (an Nx Cloud agent creates
+    // an orchestrator per invocation) leaks whole orchestrators until they run.
+    async dispose() {
+        // The forked runner's exit handler is the last-resort kill for child
+        // processes, and a batch child can outlive its results message. Reap
+        // children first so removing the handler cannot orphan a live one.
+        try {
+            await this.forkedProcessTaskRunner.cleanup();
+        }
+        catch (e) {
+            console.error('Failed to clean up child processes on dispose:', e);
+        }
+        for (const [signal, handler] of this.signalHandlers) {
+            process.off(signal, handler);
+        }
+        this.signalHandlers = [];
+        this.forkedProcessTaskRunner.removeProcessEventListeners();
     }
     cleanUpUnneededContinuousTasks() {
         const incompleteTasks = this.tasksSchedule.getIncompleteTasks();

package/dist/src/utils/min-release-age/behavior/pnpm.js

@@ -9,6 +9,14 @@ const errors_1 = require("../errors");
 const pick_1 = require("../pick");
 // Ordered newest-bound-first so the first matching row applies.
 const PNPM_BEHAVIOR_ROWS = [
+    {
+        minVersion: '12.0.0',
+        major: 12,
+        strictMode: 'default-loose',
+        strictAutoOnWhenExplicit: true,
+        excludeGrammar: 'v2-globs-unions',
+        writesExcludes: true,
+    },
     {
         minVersion: '11.1.3',
         major: 11,
@@ -134,7 +142,7 @@ function toBoolean(value) {
 async function readPnpmPolicy(root, pmVersion) {
     // A pnpm major newer than the table knows can behave differently; defer to a
     // real install rather than guessing.
-    if ((0, semver_1.gte)(pmVersion, '12.0.0')) {
+    if ((0, semver_1.gte)(pmVersion, '13.0.0')) {
         return {
             outcome: 'ambiguous',
             reason: `pnpm ${pmVersion} is newer than the known cooldown behavior table.`,
@@ -155,15 +163,15 @@ async function readPnpmPolicy(root, pmVersion) {
     }
     const { windowMinutes: explicitWindow, excludes, strictExplicit, ignoreMissingTimeExplicit, } = parseCooldownConfig(config);
     // An explicitly configured window (from whatever surface pnpm honors) wins;
-    // otherwise v11 falls back to its built-in 1440-minute (1 day) default, while
-    // v10 has no default (no cooldown).
+    // otherwise v11 and v12 fall back to the built-in 1440-minute (1 day) default,
+    // while v10 has no default (no cooldown).
     let windowMinutes;
     let windowExplicit;
     if (explicitWindow !== undefined) {
         windowMinutes = explicitWindow;
         windowExplicit = true;
     }
-    else if (row.major === 11) {
+    else if (row.major >= 11) {
         windowMinutes = 1440;
         windowExplicit = false;
     }
@@ -178,14 +186,14 @@ async function readPnpmPolicy(root, pmVersion) {
     const cutoffMs = Date.now() - windowMs;
     const sourceDescription = `pnpm minimumReleaseAge (${windowMinutes} min)`;
     const strict = resolveStrict(row, strictExplicit, windowExplicit);
-    // v10 always errors on missing time; v11 defaults to skip unless a surface
-    // explicitly disabled it.
-    const ignoreMissingTime = row.major === 11 ? (ignoreMissingTimeExplicit ?? true) : false;
+    // v10 always errors on missing time; v11 and above default to skip unless a
+    // surface explicitly disabled it.
+    const ignoreMissingTime = row.major >= 11 ? (ignoreMissingTimeExplicit ?? true) : false;
     const behavior = {
         packageManager: 'pnpm',
         strict,
-        // Loose fallback only exists on v11 when strict is off.
-        looseFallback: row.major === 11 && !strict,
+        // Loose fallback only exists from v11 onwards when strict is off.
+        looseFallback: row.major >= 11 && !strict,
         writesExcludes: row.writesExcludes,
         missingTimeMap: row.major === 10 ? 'error' : ignoreMissingTime ? 'skip' : 'error',
     };

package/dist/src/utils/package-json.js

@@ -23,6 +23,7 @@ const target_merging_1 = require("../project-graph/utils/project-configuration/t
 const catalog_1 = require("./catalog");
 const fileutils_1 = require("./fileutils");
 const has_nx_js_plugin_1 = require("./has-nx-js-plugin");
+const path_2 = require("./path");
 const installation_directory_1 = require("./installation-directory");
 const package_manager_1 = require("./package-manager");
 const workspace_root_1 = require("./workspace-root");
@@ -35,15 +36,25 @@ function normalizePackageGroup(packageGroup) {
         }));
 }
 function readNxMigrateConfig(json) {
+    // Registry fetching uses this value to build a temporary extraction path.
+    // Reject unsupported absolute paths and escaping parent traversal before extraction.
+    const assertContained = (migrations) => {
+        if (!(0, path_2.isContainedRelativePath)(migrations)) {
+            throw new Error(`Invalid migrations path "${migrations}" in package "${json.name ?? 'unknown'}@${json.version ?? 'unknown'}": migration paths must not be absolute or escape their base directory through parent traversal.`);
+        }
+        return migrations;
+    };
     const parseNxMigrationsConfig = (fromJson) => {
         if (!fromJson) {
             return {};
         }
         if (typeof fromJson === 'string') {
-            return { migrations: fromJson, packageGroup: [] };
+            return { migrations: assertContained(fromJson), packageGroup: [] };
         }
         return {
-            ...(fromJson.migrations ? { migrations: fromJson.migrations } : {}),
+            ...(fromJson.migrations
+                ? { migrations: assertContained(fromJson.migrations) }
+                : {}),
             ...(fromJson.packageGroup
                 ? { packageGroup: normalizePackageGroup(fromJson.packageGroup) }
                 : {}),

package/dist/src/utils/params.js

@@ -443,7 +443,7 @@ function applyVerbosity(options, schema, isVerbose) {
 }
 function combineOptionsForExecutor(commandLineOpts, config, target, schema, defaultProjectName, relativeCwd, isVerbose = false) {
     const r = convertAliases(coerceTypesInOptions(convertToCamelCase(commandLineOpts, schema), schema), schema, false);
-    let combined = target.options || {};
+    let combined = { ...target.options };
     if (config && target.configurations && target.configurations[config]) {
         Object.assign(combined, target.configurations[config]);
     }

package/dist/src/utils/path.d.ts

@@ -8,6 +8,12 @@ export declare function normalizePath(osSpecificPath: string): string;
  * This should not be used to read files on disk because of the removal of Windows drive letters.
  */
 export declare function joinPathFragments(...fragments: string[]): string;
+/**
+ * True when `relativePath` stays inside the directory it is resolved against.
+ * Absolute paths are rejected because `path.join` silently treats them as
+ * relative, so they would otherwise slip past a `..` check.
+ */
+export declare function isContainedRelativePath(relativePath: string): boolean;
 /**
  * When running a script with the package manager (e.g. `npm run`), the package manager will
  * traverse the directory tree upwards until it finds a `package.json` and will set `process.cwd()`

package/dist/src/utils/path.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.normalizePath = normalizePath;
 exports.joinPathFragments = joinPathFragments;
+exports.isContainedRelativePath = isContainedRelativePath;
 exports.getCwd = getCwd;
 const tslib_1 = require("tslib");
 const path = tslib_1.__importStar(require("path"));
@@ -23,6 +24,20 @@ function normalizePath(osSpecificPath) {
 function joinPathFragments(...fragments) {
     return normalizePath(path.join(...fragments));
 }
+/**
+ * True when `relativePath` stays inside the directory it is resolved against.
+ * Absolute paths are rejected because `path.join` silently treats them as
+ * relative, so they would otherwise slip past a `..` check.
+ */
+function isContainedRelativePath(relativePath) {
+    if (path.isAbsolute(relativePath)) {
+        return false;
+    }
+    const normalized = path.normalize(relativePath);
+    return !(normalized === '..' ||
+        normalized.startsWith(`..${path.sep}`) ||
+        normalized.startsWith(`..${path.posix.sep}`));
+}
 /**
  * When running a script with the package manager (e.g. `npm run`), the package manager will
  * traverse the directory tree upwards until it finds a `package.json` and will set `process.cwd()`