@depup/angular-eslint__eslint-plugin 22.2.0-depup.0 → 22.3.0-depup.0

package/dist/rules/prefer-output-readonly.js

@@ -17,8 +17,8 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
             preferOutputReadonly: 'Prefer to declare `{{type}}` as `readonly` since they are not supposed to be reassigned',
             suggestAddReadonlyModifier: 'Add `readonly` modifier',
         },
+        defaultOptions: [],
     },
-    defaultOptions: [],
     create(context) {
         return {
             [`PropertyDefinition:not([readonly=true]) > ${utils_1.Selectors.OUTPUT_DECORATOR}`]({ parent: { key }, }) {

package/dist/rules/prefer-service-decorator.js

@@ -17,8 +17,8 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
         messages: {
             preferServiceDecorator: "Use the `@Service()` decorator instead of `@Injectable({ providedIn: 'root' })`",
         },
+        defaultOptions: [],
     },
-    defaultOptions: [],
     create(context) {
         return {
             [utils_1.Selectors.INJECTABLE_CLASS_DECORATOR](node) {

package/dist/rules/prefer-signal-model.d.ts

@@ -1,6 +1,12 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+type Options = [
+    {
+        useTypeChecking: boolean;
+    }
+];
 export type MessageIds = 'preferSignalModel';
 export declare const RULE_NAME = "prefer-signal-model";
-declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferSignalModel", [], import("../utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
+declare const _default: ESLintUtils.RuleModule<"preferSignalModel", Options, import("../utils/create-eslint-rule").RuleDocs, ESLintUtils.RuleListener> & {
     name: string;
 };
 export default _default;

package/dist/rules/prefer-signal-model.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-signal-model.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-signal-model.ts"],"names":[],"mappings":"AAUA,MAAM,MAAM,UAAU,GAAG,mBAAmB,CAAC;AAC7C,eAAO,MAAM,SAAS,wBAAwB,CAAC;;;;AAE/C,wBA0EG;AAEH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}
+{"version":3,"file":"prefer-signal-model.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-signal-model.ts"],"names":[],"mappings":"AASA,OAAO,EAAkB,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAIvE,KAAK,OAAO,GAAG;IACb;QACE,eAAe,EAAE,OAAO,CAAC;KAC1B;CACF,CAAC;AAMF,MAAM,MAAM,UAAU,GAAG,mBAAmB,CAAC;AAC7C,eAAO,MAAM,SAAS,wBAAwB,CAAC;;;;AA8B/C,wBAuKG;AAEH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}

package/dist/rules/prefer-signal-model.js

@@ -1,9 +1,25 @@
 "use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.RULE_DOCS_EXTENSION = exports.RULE_NAME = void 0;
 const utils_1 = require("@angular-eslint/utils");
+const utils_2 = require("@typescript-eslint/utils");
+const typescript_1 = __importDefault(require("typescript"));
 const create_eslint_rule_1 = require("../utils/create-eslint-rule");
+const DEFAULT_OPTIONS = {
+    useTypeChecking: false,
+};
 exports.RULE_NAME = 'prefer-signal-model';
+function hasTransformOption(options) {
+    return (options?.type === utils_2.AST_NODE_TYPES.ObjectExpression &&
+        options.properties.some((property) => property.type === utils_2.AST_NODE_TYPES.Property &&
+            ((property.key.type === utils_2.AST_NODE_TYPES.Identifier &&
+                property.key.name === 'transform') ||
+                (property.key.type === utils_2.AST_NODE_TYPES.Literal &&
+                    property.key.value === 'transform'))));
+}
 exports.default = (0, create_eslint_rule_1.createESLintRule)({
     name: exports.RULE_NAME,
     meta: {
@@ -12,54 +28,116 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
             description: 'Use `model` instead of `input` and `output` for two-way bindings',
         },
         fixable: 'code',
-        schema: [],
+        schema: [
+            {
+                type: 'object',
+                properties: {
+                    useTypeChecking: {
+                        type: 'boolean',
+                        default: DEFAULT_OPTIONS.useTypeChecking,
+                    },
+                },
+                additionalProperties: false,
+            },
+        ],
         messages: {
             preferSignalModel: 'Use `model` for two-way bindings instead of `input()` and `output()`',
         },
+        defaultOptions: [{ ...DEFAULT_OPTIONS }],
     },
-    defaultOptions: [],
-    create(context) {
+    create(context, [{ useTypeChecking = DEFAULT_OPTIONS.useTypeChecking }]) {
+        const { sourceCode } = context;
         const inputs = new Map();
         const outputs = new Map();
+        let services;
+        function getTypeServices() {
+            return (services ??= utils_2.ESLintUtils.getParserServices(context));
+        }
+        function createSignalCollector(signals, { hasInitialValueArgument }) {
+            return (node) => {
+                const options = node.arguments[hasInitialValueArgument ? 1 : 0];
+                // `model()` has no transform support.
+                // https://github.com/angular/angular/issues/55166#issuecomment-2032150999
+                if (hasTransformOption(options)) {
+                    return;
+                }
+                const property = node.parent;
+                signals.set(utils_1.ASTUtils.getPropertyDefinitionName(property), {
+                    property,
+                    callee: (node.callee.type === utils_2.AST_NODE_TYPES.MemberExpression
+                        ? node.callee.object
+                        : node.callee),
+                    typeArgument: node.typeArguments?.params[0],
+                    initialValue: hasInitialValueArgument ? node.arguments[0] : undefined,
+                });
+            };
+        }
+        function getValueType({ typeArgument, initialValue }) {
+            const typeServices = getTypeServices();
+            if (typeArgument) {
+                return typeServices.getTypeAtLocation(typeArgument);
+            }
+            if (initialValue) {
+                return typeServices.program
+                    .getTypeChecker()
+                    .getBaseTypeOfLiteralType(typeServices.getTypeAtLocation(initialValue));
+            }
+            return undefined;
+        }
+        function haveEquallyWrittenTypes(input, output) {
+            return (!input.typeArgument ||
+                !output.typeArgument ||
+                sourceCode.getText(input.typeArgument) ===
+                    sourceCode.getText(output.typeArgument));
+        }
+        function haveMergeableTypes(input, output) {
+            if (!useTypeChecking) {
+                return haveEquallyWrittenTypes(input, output);
+            }
+            const inputType = getValueType(input);
+            const outputType = getValueType(output);
+            if (!inputType || !outputType) {
+                return true;
+            }
+            // A type argument that does not resolve becomes the error type, which is
+            // assignable in both directions, so only the written text is trustworthy.
+            if ((inputType.flags | outputType.flags) & typescript_1.default.TypeFlags.Any) {
+                return haveEquallyWrittenTypes(input, output);
+            }
+            // Mutual assignability stands in for the internal `isTypeIdenticalTo`;
+            // the same type written twice yields two distinct `ts.Type` objects.
+            const checker = getTypeServices().program.getTypeChecker();
+            return (checker.isTypeAssignableTo(inputType, outputType) &&
+                checker.isTypeAssignableTo(outputType, inputType));
+        }
         return {
-            "PropertyDefinition > CallExpression[callee.name='input']"(node) {
-                const propertyDef = node.parent;
-                const propertyName = utils_1.ASTUtils.getPropertyDefinitionName(propertyDef);
-                inputs.set(propertyName, propertyDef);
-            },
-            "PropertyDefinition > CallExpression[callee.name='output']"(node) {
-                const propertyDef = node.parent;
-                const propertyName = utils_1.ASTUtils.getPropertyDefinitionName(propertyDef);
-                outputs.set(propertyName, propertyDef);
-            },
+            "PropertyDefinition > CallExpression[callee.name='input']": createSignalCollector(inputs, { hasInitialValueArgument: true }),
+            "PropertyDefinition > CallExpression[callee.object.name='input'][callee.property.name='required']": createSignalCollector(inputs, { hasInitialValueArgument: false }),
+            "PropertyDefinition > CallExpression[callee.name='output']": createSignalCollector(outputs, { hasInitialValueArgument: false }),
             'ClassDeclaration:exit'() {
-                for (const [inputName, inputProperty] of inputs) {
-                    const outputName = `${inputName}Change`;
-                    const outputProperty = outputs.get(outputName);
-                    if (outputProperty) {
-                        // Report on the input property
-                        context.report({
-                            node: inputProperty,
-                            messageId: 'preferSignalModel',
-                            fix: (fixer) => {
-                                const sourceCode = context.sourceCode;
-                                const inputText = sourceCode.getText(inputProperty);
-                                const fixedInputText = inputText.replace(/\binput\b/, 'model');
-                                return [
-                                    utils_1.RuleFixes.getImportAddFix({
-                                        fixer,
-                                        importName: 'model',
-                                        moduleName: '@angular/core',
-                                        node: inputProperty,
-                                    }),
-                                    fixer.replaceText(inputProperty, fixedInputText),
-                                    fixer.remove(outputProperty),
-                                ].filter(utils_1.isNotNullOrUndefined);
-                            },
-                        });
-                    }
+                const twoWayBindings = [...inputs]
+                    .map(([name, input]) => ({
+                    input,
+                    output: outputs.get(`${name}Change`),
+                }))
+                    .filter((binding) => binding.output !== undefined &&
+                    haveMergeableTypes(binding.input, binding.output));
+                for (const { input, output } of twoWayBindings) {
+                    context.report({
+                        node: input.property,
+                        messageId: 'preferSignalModel',
+                        fix: (fixer) => [
+                            utils_1.RuleFixes.getImportAddFix({
+                                fixer,
+                                importName: 'model',
+                                moduleName: '@angular/core',
+                                node: input.property,
+                            }),
+                            fixer.replaceText(input.callee, 'model'),
+                            fixer.remove(output.property),
+                        ].filter(utils_1.isNotNullOrUndefined),
+                    });
                 }
-                // Clear the maps for the next class
                 inputs.clear();
                 outputs.clear();
             },
@@ -67,5 +145,5 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
     },
 });
 exports.RULE_DOCS_EXTENSION = {
-    rationale: "The model() function is Angular's modern API for two-way bindings, combining both input and output into a single signal. When you have an input property paired with an output property that follows the naming pattern of `propertyChange` (e.g., `enabled` input with `enabledChange` output), this is the traditional pattern for two-way binding. The model() function provides a cleaner, more concise way to express this pattern with better type safety and integration with Angular's signal ecosystem. It eliminates the boilerplate of managing separate input and output properties while maintaining the same two-way binding functionality.",
+    rationale: "The model() function is Angular's modern API for two-way bindings, combining both input and output into a single signal. When you have an input property paired with an output property that follows the naming pattern of `propertyChange` (e.g., `enabled` input with `enabledChange` output), this is the traditional pattern for two-way binding. The model() function provides a cleaner, more concise way to express this pattern with better type safety and integration with Angular's signal ecosystem. It eliminates the boilerplate of managing separate input and output properties while maintaining the same two-way binding functionality.\n\nBecause `model()` exposes a single type for both directions, only pairs whose `input` and `output` types match are reported. By default the written type arguments are compared as text, and a pair is assumed compatible when either side has no type argument. Enabling the `useTypeChecking` option compares the types semantically instead, and infers an `input`'s type from its initial value, so `input('')` paired with `output<number>()` is left alone. A type argument that does not resolve falls back to the text comparison.",
 };

package/dist/rules/prefer-signals.js

@@ -67,8 +67,8 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
             preferQuerySignals: 'Use the `{{function}}` function instead of the `{{decorator}}` decorator',
             preferReadonlySignalProperties: 'Properties declared using signals should be marked as `readonly` since they should not be reassigned',
         },
+        defaultOptions: [{ ...DEFAULT_OPTIONS }],
     },
-    defaultOptions: [{ ...DEFAULT_OPTIONS }],
     create(context, [{ preferReadonlySignalProperties = DEFAULT_OPTIONS.preferReadonlySignalProperties, preferInputSignals = DEFAULT_OPTIONS.preferInputSignals, preferQuerySignals = DEFAULT_OPTIONS.preferQuerySignals, additionalSignalCreationFunctions = DEFAULT_OPTIONS.additionalSignalCreationFunctions, useTypeChecking = DEFAULT_OPTIONS.useTypeChecking, },]) {
         let services;
         const listener = {};

package/dist/rules/prefer-standalone.js

@@ -19,8 +19,8 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
             preferStandalone: `Components, Directives and Pipes should not opt out of standalone. Following this guide is highly recommended: ${RECOMMENDED_GUIDE_URL}`,
             removeStandaloneFalse: `Quickly remove 'standalone: false'. NOTE - Following this guide is highly recommended: ${RECOMMENDED_GUIDE_URL}`,
         },
+        defaultOptions: [],
     },
-    defaultOptions: [],
     create(context) {
         const standaloneRuleFactory = (type) => (node) => {
             const standalone = utils_1.ASTUtils.getDecoratorPropertyValue(node, 'standalone');

package/dist/rules/reactive-context-must-read-signal.d.ts

@@ -0,0 +1,16 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+export type Options = [
+    {
+        readonly checkResources?: boolean;
+    }
+];
+export type MessageIds = 'mustReadSignal';
+export declare const RULE_NAME = "reactive-context-must-read-signal";
+declare const _default: ESLintUtils.RuleModule<"mustReadSignal", Options, import("../utils/create-eslint-rule").RuleDocs, ESLintUtils.RuleListener> & {
+    name: string;
+};
+export default _default;
+export declare const RULE_DOCS_EXTENSION: {
+    rationale: string;
+};
+//# sourceMappingURL=reactive-context-must-read-signal.d.ts.map

package/dist/rules/reactive-context-must-read-signal.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"reactive-context-must-read-signal.d.ts","sourceRoot":"","sources":["../../src/rules/reactive-context-must-read-signal.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,WAAW,EAGZ,MAAM,0BAA0B,CAAC;AAMlC,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,QAAQ,CAAC,cAAc,CAAC,EAAE,OAAO,CAAC;KACnC;CACF,CAAC;AACF,MAAM,MAAM,UAAU,GAAG,gBAAgB,CAAC;AAC1C,eAAO,MAAM,SAAS,sCAAsC,CAAC;;;;AA8D7D,wBA2VG;AAEH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}

package/dist/rules/reactive-context-must-read-signal.js

@@ -0,0 +1,357 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RULE_DOCS_EXTENSION = exports.RULE_NAME = void 0;
+const utils_1 = require("@typescript-eslint/utils");
+const tsutils = __importStar(require("ts-api-utils"));
+const typescript_1 = __importDefault(require("typescript"));
+const create_eslint_rule_1 = require("../utils/create-eslint-rule");
+const signals_1 = require("../utils/signals");
+exports.RULE_NAME = 'reactive-context-must-read-signal';
+/**
+ * Reactive contexts that should depend on at least one signal. The tracked
+ * function is the one whose signal reads define the context's dependencies:
+ * - `computed`/`effect`: the first argument.
+ * - `linkedSignal`: the first argument (shorthand) or the `source`/`computation`
+ *   functions of the options object.
+ * - `afterRenderEffect`: the first argument (shorthand) or the phase functions
+ *   of the options object.
+ */
+const DEFAULT_PRIMITIVES = {
+    afterRenderEffect: {
+        args: [0],
+        optionKeys: ['earlyRead', 'write', 'mixedReadWrite', 'read'],
+    },
+    computed: { args: [0], optionKeys: [] },
+    effect: { args: [0], optionKeys: [] },
+    linkedSignal: { args: [0], optionKeys: ['source', 'computation'] },
+};
+/**
+ * For resources, only the `params` (formerly `request`) function defines the
+ * reactive dependencies; reading a signal in the `loader`/`stream` does not make
+ * the resource reload. These are opt-in via the `checkResources` option.
+ */
+const RESOURCE_PRIMITIVES = {
+    resource: { args: [0], optionKeys: ['params', 'request'] },
+    rxResource: { args: [0], optionKeys: ['params', 'request'] },
+};
+function isFunction(node) {
+    return (node?.type === utils_1.AST_NODE_TYPES.FunctionExpression ||
+        node?.type === utils_1.AST_NODE_TYPES.ArrowFunctionExpression);
+}
+exports.default = (0, create_eslint_rule_1.createESLintRule)({
+    name: exports.RULE_NAME,
+    meta: {
+        type: 'problem',
+        docs: {
+            description: 'Ensures that reactive contexts such as computed(), linkedSignal() and effect() read at least one reactive value (a signal). A reactive context with no reactive dependencies never re-runs, which is almost always a mistake.',
+        },
+        schema: [
+            {
+                type: 'object',
+                properties: {
+                    checkResources: {
+                        type: 'boolean',
+                        description: 'Also check that the `params` function of `resource()` and `rxResource()` reads a signal.',
+                    },
+                },
+                additionalProperties: false,
+            },
+        ],
+        messages: {
+            mustReadSignal: '{{primitive}}() must read at least one signal, otherwise it will never re-run when state changes.',
+        },
+    },
+    defaultOptions: [{ checkResources: false }],
+    create(context, [{ checkResources = false }]) {
+        const services = utils_1.ESLintUtils.getParserServices(context);
+        const checker = services.program.getTypeChecker();
+        const primitives = checkResources
+            ? { ...DEFAULT_PRIMITIVES, ...RESOURCE_PRIMITIVES }
+            : DEFAULT_PRIMITIVES;
+        const analyses = new Map();
+        const trackedFnToCall = new Map();
+        const frameStack = [];
+        /**
+         * Returns true if calling `callee` reads a signal, i.e. `callee` has one of
+         * the known signal types. This mirrors the detection used by
+         * `no-uncalled-signals`.
+         */
+        function isSignalRead(callee) {
+            const type = services.getTypeAtLocation(callee);
+            const symbol = type.getSymbol();
+            if (symbol && signals_1.KNOWN_SIGNAL_TYPES.has(symbol.name)) {
+                return true;
+            }
+            // The `Signal` type is a type alias, so it is only reachable via the
+            // alias symbol. Other signal types (e.g. `InputSignal`) are interfaces
+            // and are found through `getSymbol()` above.
+            if (type.aliasSymbol && signals_1.KNOWN_SIGNAL_TYPES.has(type.aliasSymbol.name)) {
+                return true;
+            }
+            return false;
+        }
+        /**
+         * Returns true if the symbol is only declared in TypeScript's default
+         * library files. Those declarations (arrays, strings, `Math`, `JSON`,
+         * `Object`, `console`, DOM APIs, ...) cannot read an Angular signal.
+         */
+        function isDeclaredInDefaultLib(symbol) {
+            const declarations = symbol.getDeclarations();
+            return (!!declarations?.length &&
+                declarations.every((declaration) => services.program.isSourceFileDefaultLibrary(declaration.getSourceFile())));
+        }
+        /**
+         * Returns true if the node is a function-typed value that we cannot look
+         * inside, e.g. `this.transform` in `this.items.map(this.transform)`. The
+         * callee could invoke it, and it could read a signal.
+         */
+        function isOpaqueFunctionValue(node) {
+            if (isFunction(node)) {
+                // Inline functions are visited by this rule, so any signal they read is
+                // attributed to the enclosing reactive context.
+                return false;
+            }
+            if (node.type === utils_1.AST_NODE_TYPES.SpreadElement) {
+                // We cannot tell what a spread expands to, so assume the worst.
+                return true;
+            }
+            const type = services.getTypeAtLocation(node);
+            if (tsutils.isTypeFlagSet(type, typescript_1.default.TypeFlags.Any | typescript_1.default.TypeFlags.Unknown)) {
+                // We know nothing about the value, so it could well be a function
+                // that reads a signal.
+                return true;
+            }
+            return tsutils
+                .unionConstituents(type)
+                .some((constituent) => constituent.getCallSignatures().length > 0);
+        }
+        /**
+         * Returns true if the property with the given name is a getter on any
+         * constituent of the type. A getter runs arbitrary code, so it can read a
+         * signal even though reading the property does not look like a call.
+         */
+        function isGetter(type, name) {
+            return tsutils.unionConstituents(type).some((constituent) => {
+                const property = constituent.getProperty(name);
+                return (property !== undefined &&
+                    tsutils.isSymbolFlagSet(property, typescript_1.default.SymbolFlags.GetAccessor));
+            });
+        }
+        /**
+         * Records what a call, `new` expression or tagged template tells us about
+         * the reactive context we are currently inside. It is only known not to
+         * read a signal when the callee resolves to a declaration in a TypeScript
+         * default library and no argument is an opaque function value.
+         */
+        function analyseCallLike(callee, args, analysis) {
+            let symbol = services.getSymbolAtLocation(callee);
+            if (symbol && tsutils.isSymbolFlagSet(symbol, typescript_1.default.SymbolFlags.Alias)) {
+                symbol = checker.getAliasedSymbol(symbol);
+            }
+            if (!symbol ||
+                !isDeclaredInDefaultLib(symbol) ||
+                args.some(isOpaqueFunctionValue)) {
+                analysis.hasUnknown = true;
+            }
+        }
+        /** The analysis of the reactive context we are currently inside, if any. */
+        function currentAnalysis() {
+            const top = frameStack[frameStack.length - 1];
+            return top && analyses.get(top.call);
+        }
+        function registerTrackedFunction(node, call, analysis) {
+            if (isFunction(node)) {
+                trackedFnToCall.set(node, call);
+                analysis.hasTrackedFn = true;
+            }
+            else {
+                // The tracked slot holds something we cannot look inside, such as a
+                // signal passed directly as `source`, or a reference to a function
+                // declared elsewhere. It may well be reactive, so stay silent.
+                analysis.hasUnknown = true;
+            }
+        }
+        function registerTrackedOptions(options, call, config, analysis) {
+            for (const property of options.properties) {
+                if (property.type === utils_1.AST_NODE_TYPES.SpreadElement) {
+                    // The spread could provide any of the tracked options.
+                    analysis.hasUnknown = true;
+                }
+                else if (!property.computed &&
+                    property.key.type === utils_1.AST_NODE_TYPES.Identifier &&
+                    config.optionKeys.includes(property.key.name)) {
+                    registerTrackedFunction(property.value, call, analysis);
+                }
+            }
+        }
+        function registerTrackedFunctions(call, config, analysis) {
+            for (const index of config.args) {
+                const arg = call.arguments[index];
+                if (arg === undefined) {
+                    continue;
+                }
+                if (config.optionKeys.length > 0 &&
+                    arg.type === utils_1.AST_NODE_TYPES.ObjectExpression) {
+                    registerTrackedOptions(arg, call, config, analysis);
+                }
+                else {
+                    registerTrackedFunction(arg, call, analysis);
+                }
+            }
+        }
+        function enterFunction(node) {
+            const call = trackedFnToCall.get(node);
+            if (call) {
+                frameStack.push({ fn: node, call });
+            }
+        }
+        function exitFunction(node) {
+            const top = frameStack[frameStack.length - 1];
+            if (top?.fn === node) {
+                frameStack.pop();
+            }
+        }
+        return {
+            ArrowFunctionExpression: enterFunction,
+            'ArrowFunctionExpression:exit': exitFunction,
+            FunctionExpression: enterFunction,
+            'FunctionExpression:exit': exitFunction,
+            MemberExpression(node) {
+                const analysis = currentAnalysis();
+                if (!analysis) {
+                    return;
+                }
+                // A getter runs arbitrary code, so `this.name` can read a signal even
+                // though it does not look like a call.
+                const symbol = services.getSymbolAtLocation(node);
+                if (symbol &&
+                    tsutils.isSymbolFlagSet(symbol, typescript_1.default.SymbolFlags.GetAccessor)) {
+                    analysis.hasUnknown = true;
+                }
+            },
+            ObjectPattern(node) {
+                const analysis = currentAnalysis();
+                if (!analysis) {
+                    return;
+                }
+                // Destructuring invokes getters just like a member expression does,
+                // e.g. `const { double } = this`.
+                const type = services.getTypeAtLocation(node);
+                for (const property of node.properties) {
+                    if (property.type !== utils_1.AST_NODE_TYPES.Property ||
+                        property.computed ||
+                        property.key.type !== utils_1.AST_NODE_TYPES.Identifier) {
+                        // A rest element copies every property and a computed or literal
+                        // key can name any property, so assume a getter could be involved.
+                        analysis.hasUnknown = true;
+                    }
+                    else if (isGetter(type, property.key.name)) {
+                        analysis.hasUnknown = true;
+                    }
+                }
+            },
+            NewExpression(node) {
+                const analysis = currentAnalysis();
+                if (analysis) {
+                    analyseCallLike(node.callee, node.arguments, analysis);
+                }
+            },
+            TaggedTemplateExpression(node) {
+                const analysis = currentAnalysis();
+                if (analysis) {
+                    analyseCallLike(node.tag, node.quasi.expressions, analysis);
+                }
+            },
+            CallExpression(node) {
+                // Attribute this call to the tracked function we are currently inside,
+                // if any. This runs before registration below, so a reactive context
+                // nested inside another tracked function is correctly treated as an
+                // (unknown) call of the outer function.
+                const analysis = currentAnalysis();
+                if (analysis) {
+                    if (isSignalRead(node.callee)) {
+                        analysis.hasReactiveRead = true;
+                    }
+                    else {
+                        analyseCallLike(node.callee, node.arguments, analysis);
+                    }
+                }
+                // Register this call if it is one of the reactive contexts.
+                if (node.callee.type !== utils_1.AST_NODE_TYPES.Identifier) {
+                    return;
+                }
+                const config = primitives[node.callee.name];
+                if (!config) {
+                    return;
+                }
+                const newAnalysis = {
+                    call: node,
+                    primitiveName: node.callee.name,
+                    hasTrackedFn: false,
+                    hasReactiveRead: false,
+                    hasUnknown: false,
+                };
+                registerTrackedFunctions(node, config, newAnalysis);
+                analyses.set(node, newAnalysis);
+            },
+            'CallExpression:exit'(node) {
+                const analysis = analyses.get(node);
+                if (!analysis) {
+                    return;
+                }
+                analyses.delete(node);
+                // Only report when we are certain there is no reactivity: there is a
+                // tracked function, no signal was read, and there was nothing that
+                // might have read a signal on our behalf.
+                if (analysis.hasTrackedFn &&
+                    !analysis.hasReactiveRead &&
+                    !analysis.hasUnknown) {
+                    context.report({
+                        node: analysis.call,
+                        messageId: 'mustReadSignal',
+                        data: { primitive: analysis.primitiveName },
+                    });
+                }
+            },
+        };
+    },
+});
+exports.RULE_DOCS_EXTENSION = {
+    rationale: 'Reactive contexts like `computed()`, `linkedSignal()`, `effect()` and `afterRenderEffect()` re-run whenever a signal they read changes. If the relevant function never reads a signal, the context runs once and can never react to anything, so it adds overhead without providing reactivity. This is usually a mistake: either the developer forgot to call a signal (e.g. wrote `firstName` instead of `firstName()`), or the value is actually static and should be a plain constant, a `signal()`, or an `afterNextRender()` in the case of `afterRenderEffect()`. To avoid false positives, the rule only reports when everything the tracked function does is known not to read a signal. Calls into the TypeScript standard library (arrays, strings, `Math`, `JSON`, `console`, DOM APIs, etc.) are known to be safe; anything else keeps the rule silent, including a helper function, a service method, a getter, an unresolved symbol, and any Angular API such as `untracked()`. One known limitation: a standard library call that reaches user code through a protocol method, such as `toJSON()` in `JSON.stringify()` or `toString()` in a template literal, is still treated as safe, so a signal read inside such a method is not detected. For `resource()`/`rxResource()` only the `params` function defines the dependencies, and these are opt-in via the `checkResources` option.',
+};

package/dist/rules/relative-url-prefix.js

@@ -16,8 +16,8 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
         messages: {
             relativeUrlPrefix: `The ./ and ../ prefix is standard syntax for relative URLs.`,
         },
+        defaultOptions: [],
     },
-    defaultOptions: [],
     create(context) {
         return {
             [`${utils_1.Selectors.COMPONENT_CLASS_DECORATOR} Property[key.name='templateUrl']`]({ value, }) {

package/dist/rules/require-lifecycle-on-prototype.js

@@ -25,8 +25,8 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
         messages: {
             defineOnPrototype: `The {{ method }} lifecycle method should be defined on the object's prototype. See more at ${ISSUE_LINK}`,
         },
+        defaultOptions: [],
     },
-    defaultOptions: [],
     create(context) {
         return {
             [propertyDefinitionSelector](node) {