@depup/angular-eslint__eslint-plugin 22.1.0-depup.1 → 22.2.0-depup.0

package/README.md

@@ -13,8 +13,8 @@ npm install @depup/angular-eslint__eslint-plugin
 
 | Field | Value |
 |-------|-------|
-| Original | [@angular-eslint/eslint-plugin](https://www.npmjs.com/package/@angular-eslint/eslint-plugin) @ 22.1.0 |
-| Processed | 2026-07-21 |
+| Original | [@angular-eslint/eslint-plugin](https://www.npmjs.com/package/@angular-eslint/eslint-plugin) @ 22.2.0 |
+| Processed | 2026-08-30 |
 | Smoke test | passed |
 | Deps updated | 1 |
 

package/changes.json

@@ -5,6 +5,6 @@
       "to": "^2.5.0"
     }
   },
-  "timestamp": "2026-07-21T19:23:52.068Z",
+  "timestamp": "2026-08-30T16:08:06.033Z",
   "totalUpdated": 1
 }

package/dist/index.d.ts

@@ -96,7 +96,7 @@ declare const _default: {
         "prefer-inject": import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferInject", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
             name: string;
         };
-        "prefer-on-push-component-change-detection": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/prefer-on-push-component-change-detection").MessageIds, [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
+        "prefer-on-push-component-change-detection": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/prefer-on-push-component-change-detection").MessageIds, import("./rules/prefer-on-push-component-change-detection").Options, import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
             name: string;
         };
         "prefer-output-emitter-ref": import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferOutputEmitterRef", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {

package/dist/rules/no-duplicates-in-metadata-arrays.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"no-duplicates-in-metadata-arrays.d.ts","sourceRoot":"","sources":["../../src/rules/no-duplicates-in-metadata-arrays.ts"],"names":[],"mappings":"AAKA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AACzB,MAAM,MAAM,UAAU,GAAG,8BAA8B,CAAC;AACxD,eAAO,MAAM,SAAS,qCAAqC,CAAC;;;;AAE5D,wBA4CG;AAoBH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}
+{"version":3,"file":"no-duplicates-in-metadata-arrays.d.ts","sourceRoot":"","sources":["../../src/rules/no-duplicates-in-metadata-arrays.ts"],"names":[],"mappings":"AAKA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AACzB,MAAM,MAAM,UAAU,GAAG,8BAA8B,CAAC;AACxD,eAAO,MAAM,SAAS,qCAAqC,CAAC;;;;AAE5D,wBA+CG;AA2BH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}

package/dist/rules/no-duplicates-in-metadata-arrays.js

@@ -30,6 +30,9 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
             // https://angular.dev/api/core/Component
             `${utils_1.Selectors.COMPONENT_CLASS_DECORATOR} Property[key.name=${(0, utils_1.toPattern)([
                 'imports',
+                'providers',
+                'viewProviders',
+                'styleUrls',
             ])}] > ArrayExpression`,
             // https://angular.dev/api/core/Directive
             `${utils_1.Selectors.DIRECTIVE_CLASS_DECORATOR} Property[key.name=${(0, utils_1.toPattern)([
@@ -49,15 +52,17 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
     },
 });
 function getDuplicateItems(elements) {
-    const items = elements.filter(utils_2.ASTUtils.isIdentifier);
-    const uniqueItemNames = new Set();
-    const duplicateItems = [];
+    const items = elements.filter((element) => utils_2.ASTUtils.isIdentifier(element) ||
+        (element?.type === 'Literal' && typeof element.value === 'string'));
+    const uniqueItemKeys = new Set();
+    const duplicateItems = new Array();
     items.forEach((item) => {
-        if (uniqueItemNames.has(item.name)) {
+        const key = item.type === 'Identifier' ? item.name : item.value;
+        if (uniqueItemKeys.has(key)) {
             duplicateItems.push(item);
         }
         else {
-            uniqueItemNames.add(item.name);
+            uniqueItemKeys.add(key);
         }
     });
     return duplicateItems;

package/dist/rules/prefer-on-push-component-change-detection.d.ts

@@ -1,7 +1,10 @@
-export type Options = [];
-export type MessageIds = 'preferOnPushComponentChangeDetection' | 'suggestRemoveChangeDetection';
+import type { TSESLint } from '@typescript-eslint/utils';
+export type Options = [{
+    readonly allowExplicitOnPush: boolean;
+}];
+export type MessageIds = 'preferOnPushComponentChangeDetection' | 'suggestRemoveChangeDetection' | 'redundantOnPushComponentChangeDetection';
 export declare const RULE_NAME = "prefer-on-push-component-change-detection";
-declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<MessageIds, [], import("../utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
+declare const _default: TSESLint.RuleModule<MessageIds, Options, import("../utils/create-eslint-rule").RuleDocs, TSESLint.RuleListener> & {
     name: string;
 };
 export default _default;

package/dist/rules/prefer-on-push-component-change-detection.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-on-push-component-change-detection.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-on-push-component-change-detection.ts"],"names":[],"mappings":"AASA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AACzB,MAAM,MAAM,UAAU,GACpB,sCAAsC,GAAG,8BAA8B,CAAC;AAC1E,eAAO,MAAM,SAAS,8CAA8C,CAAC;;;;AAKrE,wBAoEG;AAEH,eAAO,MAAM,mBAAmB;;CAE/B,CAAC"}
+{"version":3,"file":"prefer-on-push-component-change-detection.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-on-push-component-change-detection.ts"],"names":[],"mappings":"AAMA,OAAO,KAAK,EAAE,QAAQ,EAAY,MAAM,0BAA0B,CAAC;AAGnE,MAAM,MAAM,OAAO,GAAG,CAAC;IAAE,QAAQ,CAAC,mBAAmB,EAAE,OAAO,CAAA;CAAE,CAAC,CAAC;AAClE,MAAM,MAAM,UAAU,GAClB,sCAAsC,GACtC,8BAA8B,GAC9B,yCAAyC,CAAC;AAC9C,eAAO,MAAM,SAAS,8CAA8C,CAAC;;;;AAMrE,wBAoGG;AAEH,eAAO,MAAM,mBAAmB;;CAQ/B,CAAC"}

package/dist/rules/prefer-on-push-component-change-detection.js

@@ -6,6 +6,7 @@ const create_eslint_rule_1 = require("../utils/create-eslint-rule");
 exports.RULE_NAME = 'prefer-on-push-component-change-detection';
 const METADATA_PROPERTY_NAME = 'changeDetection';
 const STRATEGY_ON_PUSH = 'ChangeDetectionStrategy.OnPush';
+const DEFAULT_OPTIONS = { allowExplicitOnPush: true };
 exports.default = (0, create_eslint_rule_1.createESLintRule)({
     name: exports.RULE_NAME,
     meta: {
@@ -14,26 +15,41 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
             description: `Ensures components do not opt out of the default \`${STRATEGY_ON_PUSH}\` change detection strategy`,
             recommended: 'recommended',
         },
+        fixable: 'code',
         hasSuggestions: true,
-        schema: [],
+        schema: [
+            {
+                type: 'object',
+                properties: {
+                    allowExplicitOnPush: {
+                        type: 'boolean',
+                        default: DEFAULT_OPTIONS.allowExplicitOnPush,
+                        description: `Whether to allow a component to set \`${METADATA_PROPERTY_NAME}: ${STRATEGY_ON_PUSH}\` explicitly even though it is now the default.`,
+                    },
+                },
+                additionalProperties: false,
+            },
+        ],
         messages: {
             preferOnPushComponentChangeDetection: `Components should not opt out of the default \`${STRATEGY_ON_PUSH}\` change detection strategy`,
             suggestRemoveChangeDetection: `Remove \`${METADATA_PROPERTY_NAME}\` to use the default (\`${STRATEGY_ON_PUSH}\`)`,
+            redundantOnPushComponentChangeDetection: `\`${METADATA_PROPERTY_NAME}: ${STRATEGY_ON_PUSH}\` is redundant because \`${STRATEGY_ON_PUSH}\` is the default change detection strategy`,
         },
     },
-    defaultOptions: [],
-    create(context) {
+    defaultOptions: [DEFAULT_OPTIONS],
+    create(context, [{ allowExplicitOnPush }]) {
         const sourceCode = context.sourceCode;
         const changeDetectionMetadataProperty = utils_1.Selectors.metadataProperty(METADATA_PROPERTY_NAME);
-        /**
-         * As of Angular v22 OnPush is the default change detection strategy, so a
-         * component only needs to be reported when it explicitly opts out of it by
-         * setting a non-OnPush `ChangeDetectionStrategy` member (e.g. `Eager`, or
-         * the deprecated `Default`). Omitting `changeDetection` entirely, or setting
-         * it to `ChangeDetectionStrategy.OnPush`, is the desired default and is not
-         * reported.
-         */
-        const onPushOptOutProperty = `${utils_1.Selectors.COMPONENT_CLASS_DECORATOR} > CallExpression > ObjectExpression > ${changeDetectionMetadataProperty}[value.object.name='ChangeDetectionStrategy'][value.property.name!='OnPush']`;
+        const changeDetectionStrategyProperty = `${utils_1.Selectors.COMPONENT_CLASS_DECORATOR} > CallExpression > ObjectExpression > ${changeDetectionMetadataProperty}[value.object.name='ChangeDetectionStrategy']`;
+        const onPushOptOutProperty = `${changeDetectionStrategyProperty}[value.property.name!='OnPush']`;
+        const redundantOnPushProperty = `${changeDetectionStrategyProperty}[value.property.name='OnPush']`;
+        function removeChangeDetectionProperty(node, fixer) {
+            const importDeclarations = utils_1.ASTUtils.getImportDeclarations(node, '@angular/core') ?? [];
+            return [
+                utils_1.RuleFixes.getNodeToCommaRemoveFix(sourceCode, node, fixer),
+                utils_1.RuleFixes.getImportRemoveFix(sourceCode, importDeclarations, 'ChangeDetectionStrategy', fixer),
+            ].filter(utils_1.isNotNullOrUndefined);
+        }
         return {
             [onPushOptOutProperty](node) {
                 const { value } = node;
@@ -48,20 +64,34 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
                     suggest: [
                         {
                             messageId: 'suggestRemoveChangeDetection',
-                            fix: (fixer) => {
-                                const importDeclarations = utils_1.ASTUtils.getImportDeclarations(node, '@angular/core') ?? [];
-                                return [
-                                    utils_1.RuleFixes.getNodeToCommaRemoveFix(sourceCode, node, fixer),
-                                    utils_1.RuleFixes.getImportRemoveFix(sourceCode, importDeclarations, 'ChangeDetectionStrategy', fixer),
-                                ].filter(utils_1.isNotNullOrUndefined);
-                            },
+                            fix: (fixer) => removeChangeDetectionProperty(node, fixer),
                         },
                     ],
                 });
             },
+            [redundantOnPushProperty](node) {
+                if (allowExplicitOnPush) {
+                    return;
+                }
+                const { value } = node;
+                if (!utils_1.ASTUtils.isMemberExpression(value)) {
+                    return;
+                }
+                context.report({
+                    node: value.property,
+                    messageId: 'redundantOnPushComponentChangeDetection',
+                    fix: (fixer) => removeChangeDetectionProperty(node, fixer),
+                });
+            },
         };
     },
 });
 exports.RULE_DOCS_EXTENSION = {
-    rationale: `As of Angular v22, \`${STRATEGY_ON_PUSH}\` is the default change detection strategy: a component that does not specify \`${METADATA_PROPERTY_NAME}\` is checked using OnPush. This brings new code in line with zoneless being the default and with Angular's goal of performance by default, and means it is no longer necessary to set \`${STRATEGY_ON_PUSH}\` explicitly. The previous default, \`ChangeDetectionStrategy.Default\`, has been renamed to \`ChangeDetectionStrategy.Eager\`. When you run \`ng update\`, the v22 migration adds an explicit \`ChangeDetectionStrategy.Eager\` to existing components that relied on the old implicit default, so that they keep behaving as before.\n\nBecause omitting \`${METADATA_PROPERTY_NAME}\` (or setting it to \`${STRATEGY_ON_PUSH}\`) already gives you OnPush, this rule does not require you to declare it. Instead it reports components that explicitly opt out of OnPush by setting \`ChangeDetectionStrategy.Eager\` (or the deprecated \`ChangeDetectionStrategy.Default\`) — including the components the migration marked as \`Eager\` — so you can review them and adopt OnPush where it is safe to do so. The suggestion removes the \`${METADATA_PROPERTY_NAME}\` property entirely (along with the now-unused \`ChangeDetectionStrategy\` import), relying on the v22 default rather than setting \`${STRATEGY_ON_PUSH}\` explicitly. Note that switching a component from eager checking to OnPush can change its runtime behaviour, so apply the suggestion deliberately and make sure the component uses immutable data patterns (creating new object references when data changes).`,
+    rationale: `As of Angular v22, \`${STRATEGY_ON_PUSH}\` is the default change detection strategy: a component that does not specify \`${METADATA_PROPERTY_NAME}\` is checked using OnPush. \
+This brings new code in line with zoneless being the default and with Angular's goal of performance by default, and means it is no longer necessary to set \`${STRATEGY_ON_PUSH}\` explicitly. \
+The previous default, \`ChangeDetectionStrategy.Default\`, has been renamed to \`ChangeDetectionStrategy.Eager\`. \
+When you run \`ng update\`, the v22 migration adds an explicit \`ChangeDetectionStrategy.Eager\` to existing components that relied on the old implicit default, so that they keep behaving as before.\n\n\
+By default the rule reports components that explicitly opt out of OnPush by setting \`${METADATA_PROPERTY_NAME}\` to \`ChangeDetectionStrategy.Eager\` (or the deprecated \`ChangeDetectionStrategy.Default\`) — including the components the migration marked as \`Eager\` — so you can review them and adopt OnPush where it is safe to do so. \
+Because omitting \`${METADATA_PROPERTY_NAME}\` already gives you OnPush, declaring \`${STRATEGY_ON_PUSH}\` explicitly is redundant; set \`allowExplicitOnPush\` to \`false\` to have the rule flag and autofix that too. \
+Note that switching a component from eager checking to OnPush can change its runtime behaviour, so apply the suggestion deliberately and make sure the component uses immutable data patterns (creating new object references when data changes).`,
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@depup/angular-eslint__eslint-plugin",
-  "version": "22.1.0-depup.1",
+  "version": "22.2.0-depup.0",
   "description": "ESLint plugin for Angular applications, following https://angular.dev/style-guide (with updated dependencies)",
   "license": "MIT",
   "main": "dist/index.js",
@@ -21,11 +21,11 @@
   ],
   "dependencies": {
     "ts-api-utils": "^2.5.0",
-    "@angular-eslint/bundled-angular-compiler": "22.1.0",
-    "@angular-eslint/utils": "22.1.0"
+    "@angular-eslint/bundled-angular-compiler": "22.2.0",
+    "@angular-eslint/utils": "22.2.0"
   },
   "devDependencies": {
-    "@angular-eslint/test-utils": "22.1.0"
+    "@angular-eslint/test-utils": "22.2.0"
   },
   "peerDependencies": {
     "@typescript-eslint/utils": "^8.0.0",
@@ -50,8 +50,8 @@
     },
     "depsUpdated": 1,
     "originalPackage": "@angular-eslint/eslint-plugin",
-    "originalVersion": "22.1.0",
-    "processedAt": "2026-07-21T19:24:01.669Z",
+    "originalVersion": "22.2.0",
+    "processedAt": "2026-08-30T16:08:13.663Z",
     "smokeTest": "passed"
   }
 }