@deployfoundation/foundation-deploy 0.1.2 → 0.1.3

package/dist/bin/foundation-deploy.js

@@ -422,6 +422,10 @@ async function ensureEndpoint(runner, opts) {
   return "created";
 }
 async function promoteEndpoint(runner, opts) {
+  if (opts.dryRun !== true && await endpointState(runner, opts.id, opts.name) === undefined) {
+    await ensureEndpoint(runner, opts);
+    return;
+  }
   await runner.mutate([
     "bedrock-agentcore-control",
     "update-agent-runtime-endpoint",
@@ -1837,6 +1841,15 @@ ${USAGE}`);
   }
   if (command === "slack-manifest") {
     const paths = loadInstanceContext(resolveInstanceFilePath(args, process.env));
+    if (process.env.EVENTS_REQUEST_URL === undefined)
+      console.error([
+        "warning: EVENTS_REQUEST_URL is not set, so this manifest has NO event",
+        "subscriptions, slash commands or interactivity. Applying it to an existing",
+        "app removes them. Set EVENTS_REQUEST_URL to the <Prefix>Api stack's EventsUrl",
+        "output (commands and interactivity are derived from it) unless you are",
+        "creating the app for the first time."
+      ].join(`
+`));
     console.log(JSON.stringify(slackManifestFor(paths.instance, {
       ...process.env.EVENTS_REQUEST_URL === undefined ? {} : { EVENTS_REQUEST_URL: process.env.EVENTS_REQUEST_URL },
       ...process.env.COMMANDS_REQUEST_URL === undefined ? {} : { COMMANDS_REQUEST_URL: process.env.COMMANDS_REQUEST_URL },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deployfoundation/foundation-deploy",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "description": "Deploys one Foundation instance from a published, signed release: the CDK app and the deploy tool.",
   "license": "UNLICENSED",
   "private": false,

package/src/deploy/cli.ts

@@ -116,6 +116,20 @@ export async function main(argv: readonly string[] = process.argv.slice(2)): Pro
   // print a banner into it; every other command announces its target first.
   if (command === "slack-manifest") {
     const paths = loadInstanceContext(resolveInstanceFilePath(args, process.env));
+    // Without the request URLs the manifest omits event subscriptions, slash
+    // commands and interactivity. That is right for creating a brand-new app,
+    // and destructive for an existing one: applying it strips the app's
+    // wiring. Say so on stderr, so stdout stays a clean manifest.
+    if (process.env.EVENTS_REQUEST_URL === undefined)
+      console.error(
+        [
+          "warning: EVENTS_REQUEST_URL is not set, so this manifest has NO event",
+          "subscriptions, slash commands or interactivity. Applying it to an existing",
+          "app removes them. Set EVENTS_REQUEST_URL to the <Prefix>Api stack's EventsUrl",
+          "output (commands and interactivity are derived from it) unless you are",
+          "creating the app for the first time.",
+        ].join("\n"),
+      );
     console.log(
       JSON.stringify(
         slackManifestFor(paths.instance, {

package/src/deploy/endpoint.ts

@@ -140,11 +140,25 @@ export async function ensureEndpoint(
   return "created";
 }
 
-/** Point an existing endpoint at `version` and wait for it to be READY there. */
+/**
+ * Point the endpoint at `version` and wait for it to be READY there, creating
+ * it at that version when it does not exist yet.
+ *
+ * Only `setup` used to create `live`; `deploy` and `post-deploy` could only
+ * update it. An instance brought up the documented way, `foundation-deploy
+ * deploy` from npm, therefore reached promotion with no `live` to update, and
+ * the gateway's invoker, which calls `live`, had nothing to call: the first
+ * Slack message after a fresh install would have failed. Found by migrating
+ * Olivia.
+ */
 export async function promoteEndpoint(
   runner: EndpointRunner,
   opts: EndpointOptions,
 ): Promise<void> {
+  if (opts.dryRun !== true && (await endpointState(runner, opts.id, opts.name)) === undefined) {
+    await ensureEndpoint(runner, opts);
+    return;
+  }
   await runner.mutate([
     "bedrock-agentcore-control",
     "update-agent-runtime-endpoint",