@deneb-ui/cli 2.0.47 → 2.0.48

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deneb-ui/cli",
-  "version": "2.0.47",
+  "version": "2.0.48",
   "description": "Official DENEB CLI — scaffold, convert, validate, and package Fivora-ready storefront templates.",
   "bin": {
     "deneb": "bin/index.js",
@@ -49,7 +49,7 @@
   "license": "MIT",
   "dependencies": {
     "@babel/parser": "^7.28.0",
-    "@deneb-ui/core": "^2.0.47",
+    "@deneb-ui/core": "^2.0.48",
     "@octokit/rest": "^22.0.1",
     "adm-zip": "^0.6.0",
     "dotenv": "^17.4.2",

package/src/arc/__tests__/arc.test.cjs

@@ -15,6 +15,7 @@ const { enrichSchemasFromContent } = require('../manifest.cjs');
 const { runDenebArc } = require('../index.cjs');
 const { parseSource } = require('../ast.cjs');
 const { loadFingerprintBoost } = require('../learning.cjs');
+const { classifyActionIntent } = require('../adapters.cjs');
 
 test('field-paths recognizes list action CTA keys', () => {
   assert.equal(isListActionCtaKey('preOrderCta'), true);
@@ -701,3 +702,176 @@ export function BrandMarquee() {
   assert.doesNotThrow(() => parseSource(result.code, 'BrandMarquee.tsx'));
 });
 
+test('classifyActionIntent identifies action keywords and assigns correct fallback URLs', () => {
+  const wa = classifyActionIntent('Order on WhatsApp', null);
+  assert.equal(wa?.action, 'whatsapp');
+  assert.equal(wa?.defaultUrl, 'https://wa.me/1234567890');
+  assert.equal(wa?.external, true);
+
+  const call = classifyActionIntent('Call Us', null);
+  assert.equal(call?.action, 'phone');
+  assert.equal(call?.defaultUrl, 'tel:+1234567890');
+
+  const dir = classifyActionIntent('Get Directions', null);
+  assert.equal(dir?.action, 'directions');
+  assert.equal(dir?.defaultUrl, 'https://maps.google.com/?q=store+location');
+  assert.equal(dir?.external, true);
+
+  const loc = classifyActionIntent('Our Location', null);
+  assert.equal(loc?.action, 'location');
+  assert.equal(loc?.defaultUrl, 'https://maps.google.com/?q=store+location');
+  assert.equal(loc?.external, true);
+
+  const shop = classifyActionIntent('Shop Now', null);
+  assert.equal(shop?.action, 'shop');
+  assert.equal(shop?.defaultUrl, '/shop');
+  assert.equal(shop?.external, false);
+
+  const nonAction = classifyActionIntent('Submit Form', null);
+  assert.equal(nonAction, null);
+});
+
+test('semantic engine recognizes <button> with action text as split-action-contract', () => {
+  const code = `
+export function ContactBar() {
+  return (
+    <div className="contact-bar">
+      <button className="btn-primary">Order on WhatsApp</button>
+      <button className="btn-secondary">Get Directions</button>
+      <button type="submit">Submit Feedback</button>
+    </div>
+  );
+}
+`;
+  const profile = {
+    root: os.tmpdir(),
+    framework: 'nextjs',
+    router: 'next-app',
+    language: 'typescript',
+    cssSystems: ['tailwind'],
+    hasSrc: true,
+  };
+
+  const analysis = analyzeFile({
+    code,
+    relativeFile: 'src/components/ContactBar.tsx',
+    profile,
+    graph: { sharedFiles: [] },
+    ownerScope: 'home',
+    componentMeta: { name: 'ContactBar', role: 'contact' },
+  });
+
+  const waSplit = analysis.candidates.find((c) => c.operation === 'split-action-contract' && c.label === 'Order on WhatsApp');
+  assert.ok(waSplit, 'expected split-action-contract for WhatsApp button');
+  assert.equal(waSplit.extra.action, 'whatsapp');
+  assert.equal(waSplit.value, 'https://wa.me/1234567890');
+
+  const dirSplit = analysis.candidates.find((c) => c.operation === 'split-action-contract' && c.label === 'Get Directions');
+  assert.ok(dirSplit, 'expected split-action-contract for Directions button');
+  assert.equal(dirSplit.extra.action, 'directions');
+
+  // Submit button should NOT be split into a redirect link
+  const submitSplit = analysis.candidates.find((c) => c.label === 'Submit Feedback' && c.operation === 'split-action-contract');
+  assert.equal(submitSplit, undefined, 'submit button must not be an action redirect');
+});
+
+test('AST transformer converts <button> action to <a> with redirect URL and editable text label', () => {
+  const code = `
+export function ActionPanel() {
+  return (
+    <div className="panel">
+      <button className="px-4 py-2 bg-green-600 text-white rounded">Order on WhatsApp</button>
+    </div>
+  );
+}
+`;
+  const profile = {
+    root: os.tmpdir(),
+    framework: 'nextjs',
+    router: 'next-app',
+    language: 'typescript',
+    cssSystems: ['tailwind'],
+    hasSrc: true,
+    aliasMap: { '@/*': ['src/*'] },
+  };
+
+  const analysis = analyzeFile({
+    code,
+    relativeFile: 'src/components/ActionPanel.tsx',
+    profile,
+    graph: { sharedFiles: [] },
+    ownerScope: 'home',
+    componentMeta: { name: 'ActionPanel', role: 'hero' },
+  });
+  analysis.code = code;
+  analysis.relativeFile = 'src/components/ActionPanel.tsx';
+
+  const plan = planTransformations({ profile, analyses: [analysis] });
+  const result = applyFilePlan(plan.files[0], profile);
+
+  assert.equal(result.changed, true);
+  // Converted from <button> to <a ...>
+  assert.match(result.code, /<a\s+[^>]*href=\{siteData\?\.content\?\.home\?\.hero\?\.whatsappUrl \?\? "https:\/\/wa\.me\/1234567890"\}/);
+  assert.match(result.code, /target="_blank"/);
+  assert.match(result.code, /rel="noopener noreferrer"/);
+  assert.match(result.code, /data-preview-static="action-link"/);
+  // Text label wrapped in editable span
+  assert.match(result.code, /<span\s+data-preview-field-path="home\.hero\.whatsappLabel"[^>]*>\{siteData\?\.content\?\.home\?\.hero\?\.whatsappLabel \?\? "Order on WhatsApp"\}<\/span>/);
+  // Hidden URL span present for Fivora contract
+  assert.match(result.code, /<span hidden aria-hidden="true" data-preview-field-path="home\.hero\.whatsappUrl">/);
+  // No parse errors
+  assert.doesNotThrow(() => parseSource(result.code, 'ActionPanel.tsx'));
+});
+
+test('end-to-end ARC conversion transforms action buttons and passes strict Fivora audit', () => {
+  const dir = copyOf(FIXTURE);
+  const actionPagePath = path.join(dir, 'src', 'components', 'ActionPage.tsx');
+  fs.writeFileSync(
+    actionPagePath,
+    `
+export function ActionPage() {
+  return (
+    <div className="action-page p-8">
+      <h1>Connect & Visit</h1>
+      <button className="btn-wa">Order on WhatsApp</button>
+      <button className="btn-call">Call Us</button>
+      <button className="btn-dir">Get Directions</button>
+      <button className="btn-loc">Our Location</button>
+      <button className="btn-shop">Shop Now</button>
+    </div>
+  );
+}
+`
+  );
+
+  // Link ActionPage in page.tsx
+  const pageFile = path.join(dir, 'src', 'app', 'page.tsx');
+  const pageSrc = fs.readFileSync(pageFile, 'utf8');
+  fs.writeFileSync(
+    pageFile,
+    `import { ActionPage } from '../components/ActionPage';\n` +
+      pageSrc.replace('</main>', '  <ActionPage />\n    </main>')
+  );
+
+  silence(() => runDenebArc(dir, 'actions-fixture', { telemetry: 'off' }));
+
+  const transformed = fs.readFileSync(actionPagePath, 'utf8');
+  // All 5 buttons converted to <a> tags with href
+  assert.match(transformed, /<a\s+[^>]*href=\{siteData\?\.content\?\.home\?\.contact\?\.whatsappUrl/);
+  assert.match(transformed, /<a\s+[^>]*href=\{siteData\?\.content\?\.home\?\.contact\?\.phoneUrl/);
+  assert.match(transformed, /<a\s+[^>]*href=\{siteData\?\.content\?\.home\?\.contact\?\.getDirectionsUrl/);
+  assert.match(transformed, /<a\s+[^>]*href=\{siteData\?\.content\?\.home\?\.contact\?\.ourLocationUrl/);
+  assert.match(transformed, /<a\s+[^>]*href=\{siteData\?\.content\?\.home\?\.shop\?\.shopNowUrl/);
+
+  // All 5 buttons have editable labels
+  assert.match(transformed, /data-preview-field-path="home\.contact\.whatsappLabel"/);
+  assert.match(transformed, /data-preview-field-path="home\.contact\.phoneLabel"/);
+  assert.match(transformed, /data-preview-field-path="home\.contact\.getDirectionsLabel"/);
+  assert.match(transformed, /data-preview-field-path="home\.contact\.ourLocationLabel"/);
+  assert.match(transformed, /data-preview-field-path="home\.shop\.shopNowLabel"/);
+
+  // Strict Fivora audit passes with 0 errors
+  const { errors } = auditFivora(dir);
+  assert.deepEqual(errors, []);
+});
+

package/src/arc/adapters.cjs

@@ -188,6 +188,79 @@ function isLikelyCtaClass(className) {
   return /\b(btn|button|cta|action|rounded|bg-|hero[-_]?cta)\b/i.test(className || '');
 }
 
+function classifyActionIntent(text, href) {
+  const t = String(text || '').trim().toLowerCase();
+  const h = String(href || '').trim().toLowerCase();
+
+  // 1. WhatsApp
+  if (/wa\.me|whatsapp/i.test(h) || /\b(?:whatsapp|wa\.me)\b/i.test(t) || /order on whatsapp|chat on whatsapp|message on whatsapp/i.test(t)) {
+    return {
+      action: 'whatsapp',
+      defaultUrl: /^https?:\/\//i.test(h) && !h.includes('#') ? href : 'https://wa.me/1234567890',
+      external: true,
+    };
+  }
+
+  // 2. Phone / Call
+  if (/^tel:/i.test(h) || /\b(?:call\s*(?:me|us|now)?|phone\s*(?:me|us|now)?|direct\s*line|ring\s*us)\b/i.test(t)) {
+    return {
+      action: 'phone',
+      defaultUrl: /^tel:/i.test(h) ? href : 'tel:+1234567890',
+      external: false,
+    };
+  }
+
+  // 3. Directions
+  if (/maps\.google|goo\.gl\/maps|map\.apple/i.test(h) || /\b(?:directions?|get\s*directions?|route|navigate)\b/i.test(t)) {
+    return {
+      action: 'directions',
+      defaultUrl: /^https?:\/\//i.test(h) && !h.includes('#') ? href : 'https://maps.google.com/?q=store+location',
+      external: true,
+    };
+  }
+
+  // 4. Location / Map
+  if (/\b(?:locations?|our\s*location|store\s*location|view\s*location|find\s*us|visit\s*us|locate\s*us|map)\b/i.test(t)) {
+    return {
+      action: 'location',
+      defaultUrl: /^https?:\/\//i.test(h) && !h.includes('#') ? href : 'https://maps.google.com/?q=store+location',
+      external: true,
+    };
+  }
+
+  // 5. Shop / Order / Catalog / Menu
+  if (/\b(?:shop(?:\s*now)?|order(?:\s*now)?|buy(?:\s*now)?|explore\s*(?:shop|products|offerings|collection|menu)|browse\s*(?:menu|catalog|shop)|view\s*(?:menu|catalog)|menu)\b/i.test(t) || /^\/(?:shop|products|menu|catalog)/i.test(h)) {
+    return {
+      action: 'shop',
+      defaultUrl: h && !['#', ''].includes(h) ? href : '/shop',
+      external: false,
+    };
+  }
+
+  // 6. Email
+  if (/^mailto:/i.test(h) || /\b(?:email\s*us|send\s*(?:us\s*)?email|contact\s*by\s*email)\b/i.test(t)) {
+    return {
+      action: 'email',
+      defaultUrl: /^mailto:/i.test(h) ? href : 'mailto:info@example.com',
+      external: false,
+    };
+  }
+
+  // 7. Check href using existing classifyHref
+  if (h && !['#', ''].includes(h)) {
+    const fromHref = classifyHref(href);
+    if (fromHref && fromHref !== 'link') {
+      return {
+        action: fromHref,
+        defaultUrl: href,
+        external: ['instagram', 'facebook', 'tiktok', 'twitter', 'youtube', 'linkedin', 'pinterest'].includes(fromHref),
+      };
+    }
+  }
+
+  return null;
+}
+
 module.exports = {
   ADAPTERS,
   activeAdapters,
@@ -195,6 +268,7 @@ module.exports = {
   resolveActionWithAdapters,
   isIconComponent,
   classifyHref,
+  classifyActionIntent,
   isLikelyCtaClass,
   DECORATIVE_TAGS,
   SKIP_TAGS,

package/src/arc/field-paths.cjs

@@ -71,14 +71,14 @@ function inferFieldName(kind, tag, text, extra = {}) {
     if (extra.action === 'email') return 'emailUrl';
     if (extra.cta) return extra.cta === 'primary' ? 'primaryCtaUrl' : `${extra.cta}Url`;
     const fromText = toCamel([text || '', 'url']);
-    return fromText || 'ctaUrl';
+    return fromText || (extra.action ? `${extra.action}Url` : 'ctaUrl');
   }
   if (kind === 'label' && extra.paired) {
     if (extra.action === 'whatsapp') return 'whatsappLabel';
     if (extra.action === 'phone') return 'phoneLabel';
     if (extra.action === 'email') return 'emailLabel';
     if (extra.cta) return extra.cta === 'primary' ? 'primaryCtaLabel' : `${extra.cta}Label`;
-    return toCamel([text || '', 'label']) || 'ctaLabel';
+    return toCamel([text || '', 'label']) || (extra.action ? `${extra.action}Label` : 'ctaLabel');
   }
   if (kind === 'image') return extra.alt ? toCamel([extra.alt, 'image']) || 'image' : 'image';
   if (kind === 'alt') return extra.imageField ? extra.imageField.replace(/Image$/, 'ImageAlt').replace(/image$/, 'imageAlt') : 'imageAlt';

package/src/arc/planner.cjs

@@ -230,9 +230,12 @@ function sectionForAction(scope, section, extra) {
   if (scope === 'common' && (extra.social || ['instagram', 'facebook', 'twitter', 'tiktok', 'youtube', 'linkedin'].includes(extra.action))) {
     return 'footer';
   }
-  if (extra.action === 'whatsapp' || extra.action === 'phone' || extra.action === 'email') {
+  if (['whatsapp', 'phone', 'email', 'directions', 'location'].includes(extra.action)) {
     return section || 'contact';
   }
+  if (extra.action === 'shop') {
+    return section || 'shop';
+  }
   return section;
 }
 

package/src/arc/semantic.cjs

@@ -16,6 +16,7 @@ const {
   resolveActionWithAdapters,
   isIconComponent,
   classifyHref,
+  classifyActionIntent,
   isLikelyCtaClass,
   SKIP_TAGS,
   HEADING_TAGS,
@@ -474,22 +475,30 @@ function analyzeFile({ code, relativeFile, profile, graph, ownerScope, component
       }
 
       const actionableHref = href || (name === 'Button' ? getJsxAttributeLiteral(node, 'href') : null);
-      const isAction = Boolean(actionableHref) && ACTION_TAGS.has(name);
-      if (isAction && actionableHref) {
-        const action = classifyHref(actionableHref);
-        const innerText = textInfo.dynamic ? '' : textInfo.text;
-        const looksCta = isLikelyCtaClass(className) || ['whatsapp', 'phone', 'email'].includes(action) || Boolean(innerText);
+      const innerText = textInfo.dynamic ? '' : textInfo.text;
+      const typeAttr = getJsxAttributeLiteral(node, 'type');
+      const isSubmit = typeAttr === 'submit';
+
+      // Check for action intent via classifyActionIntent (covers WhatsApp, Call/Phone, Directions, Location, Shop, Email)
+      const actionIntent = !isSubmit && !apiOwned ? classifyActionIntent(innerText, actionableHref) : null;
+      const isAction = (Boolean(actionableHref) || Boolean(actionIntent)) && (ACTION_TAGS.has(name) || isLikelyCtaClass(className));
+
+      if (isAction && (actionableHref || actionIntent)) {
+        const action = actionIntent ? actionIntent.action : classifyHref(actionableHref);
+        const resolvedHref = actionableHref || (actionIntent ? actionIntent.defaultUrl : '#');
+        const looksCta = isLikelyCtaClass(className) || ['whatsapp', 'phone', 'email', 'directions', 'location', 'shop'].includes(action) || Boolean(innerText);
         if (looksCta && innerText && !textInfo.dynamic && !apiOwned) {
           usedLocs.add(loc);
           candidates.push({
             ...baseMeta,
             kind: 'split-action-contract',
             operation: 'split-action-contract',
-            value: actionableHref,
+            value: resolvedHref,
             label: innerText,
             extra: {
               action,
-              social: !['whatsapp', 'phone', 'email', 'link'].includes(action),
+              external: actionIntent ? actionIntent.external : false,
+              social: !['whatsapp', 'phone', 'email', 'directions', 'location', 'shop', 'link'].includes(action),
               platform: ['instagram', 'facebook', 'tiktok', 'twitter', 'youtube', 'linkedin', 'pinterest'].includes(action) ? action : undefined,
             },
             confidence: confidenceFor('split-action-contract', { action, social: action !== 'link' }),
@@ -500,7 +509,7 @@ function analyzeFile({ code, relativeFile, profile, graph, ownerScope, component
           return;
         }
 
-        if (action !== 'link' && !innerText) {
+        if (action !== 'link' && !innerText && actionableHref) {
           usedLocs.add(loc);
           candidates.push({
             ...baseMeta,

package/src/arc/transformer.cjs

@@ -142,14 +142,48 @@ function wrapHiddenUrlSibling(pathNode, urlField, fallback) {
     [b.jsxExpressionContainer(siteDataBinding(urlParts, fallback, 'url'))],
     false
   );
-  pathNode.insertAfter(hiddenUrl);
+  if (pathNode.parent && Array.isArray(pathNode.parent.node?.children)) {
+    pathNode.insertAfter(hiddenUrl);
+  } else if (pathNode.node && Array.isArray(pathNode.node.children)) {
+    pathNode.node.children = [hiddenUrl, ...(pathNode.node.children || [])];
+  }
 }
 
 function applyTransformToElement(pathNode, transform) {
   const node = pathNode.node;
   if (transform.operation === 'split-action-contract') {
+    const tagName = getJsxName(node);
+    if (tagName === 'button') {
+      node.openingElement.name = b.jsxIdentifier('a');
+      if (node.closingElement) {
+        node.closingElement.name = b.jsxIdentifier('a');
+      }
+      node.openingElement.attributes = (node.openingElement.attributes || []).filter(
+        (attr) => !(attr.type === 'JSXAttribute' && attr.name && attr.name.name === 'type')
+      );
+    }
+
     const urlParts = transform.urlField.split('.');
     replaceAttrValue(node, 'href', siteDataBinding(urlParts, transform.fallback, 'url'));
+
+    const isExternal =
+      transform.extra?.external ||
+      ['whatsapp', 'directions', 'location'].includes(transform.extra?.action) ||
+      /^https?:\/\//i.test(String(transform.fallback || ''));
+
+    if (isExternal && (tagName === 'button' || tagName === 'a')) {
+      if (!hasJsxAttribute(node, 'target')) {
+        node.openingElement.attributes.push(
+          b.jsxAttribute(b.jsxIdentifier('target'), b.stringLiteral('_blank'))
+        );
+      }
+      if (!hasJsxAttribute(node, 'rel')) {
+        node.openingElement.attributes.push(
+          b.jsxAttribute(b.jsxIdentifier('rel'), b.stringLiteral('noopener noreferrer'))
+        );
+      }
+    }
+
     if (!hasJsxAttribute(node, 'data-preview-static')) {
       node.openingElement.attributes.push(
         b.jsxAttribute(b.jsxIdentifier('data-preview-static'), b.stringLiteral('action-link'))