@dench.com/cli 2.2.3 → 2.2.4

package/ads.ts

@@ -936,9 +936,16 @@ function spinnerVerbFromCache(): string | null {
 function refreshClaudeSpinnerVerb(): void {
   if (!claudeInstalled()) return;
   const verb = spinnerVerbFromCache();
-  if (!verb) return;
   const settings = readJson<Record<string, unknown>>(CLAUDE_SETTINGS, {});
-  settings.spinnerVerbs = { mode: "replace", verbs: [verb] };
+  if (verb) {
+    settings.spinnerVerbs = { mode: "replace", verbs: [verb] };
+  } else if (settings.spinnerVerbs) {
+    // No live ad → drop the sponsored thinking verb so Claude Code stops
+    // showing a stale ad on every spin.
+    delete settings.spinnerVerbs;
+  } else {
+    return;
+  }
   atomicWrite(CLAUDE_SETTINGS, `${JSON.stringify(settings, null, 2)}\n`);
 }
 
@@ -1138,47 +1145,26 @@ function shellSnippet(
 ): string {
   if (kind === "fish") {
     return `${SHELL_MARK_START}
-# Prints one sponsored line above each prompt — shows in any terminal
-# (Codex, Cursor, openclaw, hermes, …). Remove this block to disable.
-function _dench_ads
-  set -l line (${nodeBin()} ${RENDER_SCRIPT} 2>/dev/null | string collect)
-  test -n "$line"; and printf '%s\\n' "$line"
-end
-if not functions -q _dench_ads_original_prompt
-  if functions -q fish_prompt
-    functions -c fish_prompt _dench_ads_original_prompt
-  else if functions -q fish_default_prompt
-    functions -c fish_default_prompt _dench_ads_original_prompt
-  end
-end
-if functions -q _dench_ads_original_prompt
-  function fish_prompt
-    _dench_ads
-    _dench_ads_original_prompt
-  end
-else
-  function fish_prompt
-    _dench_ads
-  end
+# Prints one sponsored line ONCE when a new interactive shell opens (not on
+# every prompt) — shows in any terminal (Codex, Cursor, plain shell, …).
+# Remove this block to disable.
+if status is-interactive
+  set -l _dench_line (${nodeBin()} ${RENDER_SCRIPT} 2>/dev/null | string collect)
+  test -n "$_dench_line"; and printf '%s\\n' "$_dench_line"
 end
 ${SHELL_MARK_END}`;
   }
   return `${SHELL_MARK_START}
-# Prints one sponsored line above each prompt — shows in any terminal
-# (Codex, Cursor, openclaw, hermes, …). Remove this block to disable.
-_dench_ads() {
-  local line
-  line="$(${nodeBin()} ${RENDER_SCRIPT} 2>/dev/null)"
-  [ -n "$line" ] && printf '%s\\n' "$line"
-}
-if [ -n "$ZSH_VERSION" ]; then
-  autoload -Uz add-zsh-hook 2>/dev/null && add-zsh-hook precmd _dench_ads
-elif [ -n "$BASH_VERSION" ]; then
-  case "$PROMPT_COMMAND" in
-    *_dench_ads*) ;;
-    *) PROMPT_COMMAND="_dench_ads;$PROMPT_COMMAND" ;;
-  esac
-fi
+# Prints one sponsored line ONCE when a new interactive shell opens (not on
+# every prompt) — shows in any terminal (Codex, Cursor, plain shell, …).
+# Remove this block to disable.
+case "$-" in
+  *i*)
+    _dench_line="$(${nodeBin()} ${RENDER_SCRIPT} 2>/dev/null)"
+    [ -n "$_dench_line" ] && printf '%s\\n' "$_dench_line"
+    unset _dench_line
+    ;;
+esac
 ${SHELL_MARK_END}`;
 }
 
@@ -1595,7 +1581,7 @@ async function refresh(authToken?: string): Promise<string> {
   saveAdSource(); // let the detached background worker know where to refetch
   let ad: Ad | null = null;
   let flushed = 0;
-  let src: "live" | "demo" = "demo";
+  let src: "live" | "demo" | "none" = "none";
   let keepExistingCache = false;
   if (endpoint) {
     const previousAd = loadAd({ allowExpired: true });
@@ -1604,14 +1590,33 @@ async function refresh(authToken?: string): Promise<string> {
     const fetched = await fetchAd(endpoint);
     ad = fetched.ad;
     flushed = await flushImpressions(endpoint, authToken, ad ?? previousAd);
-    if (ad) src = "live";
-    else if (previousAd) {
-      ad = previousAd;
-      src = isDemoAdId(previousAd.id) ? "demo" : "live";
-      keepExistingCache = true;
+    if (ad) {
+      src = "live";
+    } else if (previousAd && !isDemoAdId(previousAd.id)) {
+      // The endpoint had no campaign this poll — keep a recently-live creative
+      // briefly so the line doesn't flicker between fetches, but ONLY if it
+      // hasn't expired. Past expiry with no live campaign → clear it (below).
+      if (previousAd.expiresAt && Date.now() <= previousAd.expiresAt) {
+        ad = previousAd;
+        src = "live";
+        keepExistingCache = true;
+      }
     }
+    // CRITICAL: when pointed at a real endpoint that returns NO campaign, show
+    // NOTHING. Never fall back to bundled demo ads in production — that would
+    // display a fake "Linear"/"Vercel" line nobody paid for. Demo ads are only
+    // for the no-endpoint (offline/local) path below.
+    if (!ad) {
+      clearAdCache();
+      refreshClaudeSpinnerVerb();
+      return "No live campaign — nothing to show.";
+    }
+  } else {
+    // No endpoint configured at all (offline/dev) → bundled demo rotation so
+    // the feature is demonstrable with zero backend.
+    ad = pickDemoAd();
+    src = "demo";
   }
-  if (!ad) ad = pickDemoAd();
   if (!keepExistingCache) {
     ad.expiresAt = Date.now() + DEFAULT_TTL_MS;
     atomicWrite(AD_CACHE, JSON.stringify(ad));
@@ -1622,6 +1627,17 @@ async function refresh(authToken?: string): Promise<string> {
   return `Cached ${src} ad: ${ad.label}${flushMsg}`;
 }
 
+// Remove the cached ad so the hooks/render print nothing when no campaign is
+// live. Best-effort; the render script already treats a missing cache as
+// "print nothing".
+function clearAdCache(): void {
+  try {
+    if (existsSync(AD_CACHE)) unlinkSync(AD_CACHE);
+  } catch {
+    // best-effort
+  }
+}
+
 // ---------------------------------------------------------------------------
 // status
 // ---------------------------------------------------------------------------
@@ -1998,7 +2014,7 @@ Usage:
           claude   → Claude Code's official statusLine hook (~/.claude/settings.json)
           codex    → Codex CLI lifecycle hooks (~/.codex/hooks.json); shows the
                      line as a systemMessage on SessionStart + after each turn
-          shell    → a precmd line for any terminal (zsh/bash/fish); needs --apply
+          shell    → one line at shell startup, any terminal (zsh/bash/fish); needs --apply
           agentmd  → append an instruction block to ./CLAUDE.md and ./AGENTS.md
                      so the agent runs \`dench ads show\` during its turn
           all      → all of the above

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dench.com/cli",
-  "version": "2.2.3",
+  "version": "2.2.4",
   "description": "Dench agent workspace CLI. v2 unifies auth behind `dench signin`; the legacy `dench login` / `dench onboard` / `dench setup` / `dench what-can-i-do` / `dench register` commands now error with a redirect.",
   "type": "module",
   "bin": {