@delt/claude-alarm 1.3.0 → 1.4.1

package/dist/dashboard/index.html

@@ -1286,13 +1286,20 @@
   }
 
   function showUploadRejected(msg) {
-    state.waitingReply[msg.sessionId] = false;
-    const label = msg.withText ? 'Image and message not delivered' : 'Image not delivered';
-    if (state.selectedSession === msg.sessionId) {
+    showNotDelivered(msg.sessionId, msg.withText ? 'Image and message not delivered' : 'Image not delivered', msg.reason);
+  }
+
+  function showMessageRejected(msg) {
+    showNotDelivered(msg.sessionId, 'Message not delivered', msg.reason);
+  }
+
+  function showNotDelivered(sessionId, label, reason) {
+    state.waitingReply[sessionId] = false;
+    if (state.selectedSession === sessionId) {
       renderMessages();
-      showMentionError(`${label}: ${msg.reason}`);
+      showMentionError(`${label}: ${reason}`);
     }
-    state.notifications.unshift({ sessionId: msg.sessionId, title: label, message: msg.reason, level: 'warning', time: Date.now() });
+    state.notifications.unshift({ sessionId, title: label, message: reason, level: 'warning', time: Date.now() });
     renderNotifications();
   }
 
@@ -1462,32 +1469,15 @@
       case 'upload_rejected':
         showUploadRejected(msg);
         break;
+      case 'message_rejected':
+        showMessageRejected(msg);
+        break;
       case 'notification':
         state.notifications.unshift({ sessionId: msg.sessionId, title: msg.title, message: msg.message, level: msg.level || 'info', time: msg.timestamp });
         renderNotifications();
         break;
       case 'permission_request':
-        if (!state.permissionRequests[msg.sessionId]) state.permissionRequests[msg.sessionId] = [];
-        state.permissionRequests[msg.sessionId].unshift({
-          requestId: msg.requestId,
-          toolName: msg.toolName,
-          description: msg.description,
-          inputPreview: msg.inputPreview,
-          timestamp: msg.timestamp,
-          resolved: false,
-          behavior: null,
-          choices: msg.choices || null,
-          sent: null,
-          outcome: null,
-        });
-        // Auto-select session if none selected
-        if (!state.selectedSession && state.sessions[msg.sessionId]) selectSession(msg.sessionId);
-        if (state.selectedSession === msg.sessionId) { renderMessages(); renderPermissionBar(); }
-        // Also show in notifications with permission info
-        state.notifications.unshift({ sessionId: msg.sessionId, title: 'Permission Request', message: `${msg.toolName}: ${msg.description}`, level: 'warning', time: msg.timestamp, permRequestId: msg.requestId });
-        renderNotifications();
-        // Play notification sound effect via title flash
-        flashTitle('Permission Request');
+        showPermissionRequest(msg);
         break;
       case 'permission_response':
         // Another source (Telegram, other dashboard) resolved a permission request
@@ -1501,11 +1491,7 @@
         }
         break;
       case 'permission_pending':
-        for (const m of applyPendingChoices(state.permissionRequests, msg.requests || [])) {
-          handleMessage({ type: 'permission_request', ...m });
-        }
-        renderPermissionBar();
-        renderNotifications();
+        restorePendingRequests(msg.requests || []);
         break;
       case 'codex_adapters': {
         state.codexAdapters = msg.adapters || [];
@@ -2128,6 +2114,46 @@
     return missing;
   }
 
+  function addPermissionRequest(msg) {
+    if (!state.permissionRequests[msg.sessionId]) state.permissionRequests[msg.sessionId] = [];
+    state.permissionRequests[msg.sessionId].unshift({
+      requestId: msg.requestId,
+      toolName: msg.toolName,
+      description: msg.description,
+      inputPreview: msg.inputPreview,
+      timestamp: msg.timestamp,
+      resolved: false,
+      behavior: null,
+      choices: msg.choices || null,
+      sent: null,
+      outcome: null,
+    });
+    if (!state.selectedSession && state.sessions[msg.sessionId]) selectSession(msg.sessionId);
+    if (state.selectedSession === msg.sessionId) { renderMessages(); renderPermissionBar(); }
+  }
+
+  function showPermissionRequest(msg) {
+    addPermissionRequest(msg);
+    state.notifications.unshift({ sessionId: msg.sessionId, title: 'Permission Request', message: `${msg.toolName}: ${msg.description}`, level: 'warning', time: msg.timestamp, permRequestId: msg.requestId });
+    renderNotifications();
+    flashTitle('Permission Request');
+  }
+
+  // A reconnect can bring back many requests at once; one row and one flash keep them from burying the notifications.
+  function restorePendingRequests(requests) {
+    const restored = applyPendingChoices(state.permissionRequests, requests);
+    for (const m of restored) addPermissionRequest(m);
+    if (restored.length) {
+      const label = `${restored.length} approval request(s) waiting`;
+      const listed = restored.slice(0, 3).map(m => `${m.toolName}: ${m.description}`).join(' · ');
+      const message = restored.length > 3 ? `${listed} …and ${restored.length - 3} more` : listed;
+      state.notifications.unshift({ sessionId: restored[0].sessionId, title: label, message, level: 'warning', time: Date.now() });
+      flashTitle(label);
+    }
+    renderPermissionBar();
+    renderNotifications();
+  }
+
   function sendPermissionChoice(sessionId, requestId, choiceId) {
     if (!state.ws || state.ws.readyState !== WebSocket.OPEN) return;
     state.ws.send(JSON.stringify({ type: 'permission_response', sessionId, requestId, choiceId }));
@@ -2211,23 +2237,28 @@
   }, true);
 
   // Flash title for attention
-  let flashInterval = null;
+  let flash = null;
   function flashTitle(msg) {
-    const original = document.title;
-    let on = true;
-    clearInterval(flashInterval);
-    flashInterval = setInterval(() => {
-      document.title = on ? `** ${msg} **` : original;
-      on = !on;
-    }, 500);
-    const stopFlash = () => {
-      clearInterval(flashInterval);
-      flashInterval = null;
-      document.title = original;
-      window.removeEventListener('focus', stopFlash);
+    // While flashing, document.title may hold the flash text, so only a flash that starts from rest reads the real title.
+    if (flash) {
+      flash.msg = msg;
+      return;
+    }
+    const current = { msg, original: document.title, on: true, interval: null, timeout: null };
+    const stop = () => {
+      clearInterval(current.interval);
+      clearTimeout(current.timeout);
+      window.removeEventListener('focus', stop);
+      document.title = current.original;
+      flash = null;
     };
-    window.addEventListener('focus', stopFlash);
-    setTimeout(stopFlash, 30000);
+    current.interval = setInterval(() => {
+      document.title = current.on ? `** ${current.msg} **` : current.original;
+      current.on = !current.on;
+    }, 500);
+    current.timeout = setTimeout(stop, 30000);
+    window.addEventListener('focus', stop);
+    flash = current;
   }
 
   // Clear all notifications

package/dist/hub/server.js

@@ -249,6 +249,7 @@ var MAX_SELECTIONS = 20;
 var MAX_VISIBLE_CHARS = 4e3;
 var TRUNCATED = "\u2026(truncated)";
 var MAX_PHOTO_BYTES = 10 * 1024 * 1024;
+var NO_LONGER_CONNECTED = "the session is no longer connected";
 function visibleLength(html) {
   return html.replace(/<[^>]*>/g, "").replace(/&(?:amp|lt|gt);/g, "&").length;
 }
@@ -422,13 +423,7 @@ ${TRUNCATED}`);
           this.selections.delete(latest);
           const session = this.pendingSession(pending, parseInt(selectMatch[1], 10) - 1);
           if (session) {
-            let delivered = true;
-            if (pending.photoFileId) {
-              delivered = await this.deliverPhotoToSessionByFileId(session.id, pending.photoFileId, pending.caption);
-            } else if (pending.text) {
-              this.deliverToSession(session.id, pending.text);
-            }
-            if (delivered) this.sendMessage(`Sent to [${this.getLabel(session)}]`);
+            if (await this.deliverPending(session.id, pending)) this.sendMessage(`Sent to [${this.getLabel(session)}]`);
           } else {
             this.sendMessage("Invalid session number.");
           }
@@ -470,9 +465,13 @@ ${TRUNCATED}`);
     this.sendMessage("Multiple sessions active. Select one:", void 0, { inline_keyboard: rows });
   }
   deliverToSession(sessionId, content) {
-    if (this.onMessageToSession) {
-      this.onMessageToSession(sessionId, content);
-    }
+    const delivered = this.onMessageToSession?.(sessionId, content) === true;
+    if (!delivered) void this.sendMessage(`Not delivered: ${NO_LONGER_CONNECTED}`);
+    return delivered;
+  }
+  async deliverPending(sessionId, pending) {
+    if (pending.photoFileId) return this.deliverPhotoToSessionByFileId(sessionId, pending.photoFileId, pending.caption);
+    return pending.text ? this.deliverToSession(sessionId, pending.text) : false;
   }
   async deliverPhotoToSession(sessionId, photos, caption) {
     const largest = photos[photos.length - 1];
@@ -504,8 +503,19 @@ ${TRUNCATED}`);
       const filePath = path2.join(UPLOADS_DIR, filename);
       fs.writeFileSync(filePath, buffer);
       logger.info(`Telegram photo saved: ${filename} (${buffer.length} bytes)`);
-      if (this.onImageToSession) {
-        this.onImageToSession(sessionId, filePath, mimeType, caption);
+      let accepted = false;
+      try {
+        accepted = this.onImageToSession?.(sessionId, filePath, mimeType, caption) === true;
+      } catch (err) {
+        logger.warn(`Telegram photo hand-off failed: ${err.message}`);
+      }
+      if (!accepted) {
+        try {
+          fs.unlinkSync(filePath);
+        } catch {
+        }
+        this.photoNotDelivered(NO_LONGER_CONNECTED);
+        return false;
       }
       setTimeout(() => {
         try {
@@ -513,7 +523,7 @@ ${TRUNCATED}`);
         } catch {
         }
       }, 5 * 60 * 1e3).unref();
-      return this.onImageToSession !== void 0;
+      return true;
     } catch (err) {
       logger.warn(`Telegram photo download failed: ${err.message}`);
       this.photoNotDelivered("the download failed");
@@ -708,15 +718,10 @@ ${label}`);
       return;
     }
     this.selections.delete(selectionId);
-    if (pending.photoFileId) {
-      const delivered = await this.deliverPhotoToSessionByFileId(session.id, pending.photoFileId, pending.caption);
-      if (!delivered) {
-        await this.answerCallbackQuery(query.id, "Photo not delivered");
-        if (query.message) await this.removeButtons(query.message.chat.id, query.message.message_id);
-        return;
-      }
-    } else if (pending.text) {
-      this.deliverToSession(session.id, pending.text);
+    if (!await this.deliverPending(session.id, pending)) {
+      await this.answerCallbackQuery(query.id, pending.photoFileId ? "Photo not delivered" : "Not delivered");
+      if (query.message) await this.removeButtons(query.message.chat.id, query.message.message_id);
+      return;
     }
     await this.answerCallbackQuery(query.id, `Sent to ${this.getLabel(session)}`);
     if (query.message) {
@@ -841,6 +846,11 @@ ${bodyLines.join("\n")}`;
 import { spawn } from "child_process";
 import fs2 from "fs";
 import path3 from "path";
+
+// src/codex/shutdown.ts
+var SUPERVISOR_STOP_GRACE_MS = 3e4;
+
+// src/hub/codex-supervisor.ts
 var HEALTHY_RUN_MS = 6e4;
 function resolveAdapterScript(baseDir) {
   return [path3.join(baseDir, "..", "codex", "main.js"), path3.join(baseDir, "codex", "main.js")].find((p) => fs2.existsSync(p));
@@ -856,7 +866,7 @@ var CodexSupervisor = class {
     this.spawnFn = opts.spawnFn ?? spawn;
     this.minDelayMs = opts.minDelayMs ?? 2e3;
     this.maxDelayMs = opts.maxDelayMs ?? 6e4;
-    this.stopGraceMs = opts.stopGraceMs ?? 3e3;
+    this.stopGraceMs = opts.stopGraceMs ?? SUPERVISOR_STOP_GRACE_MS;
     this.env = opts.env;
     this.delay = this.minDelayMs;
   }
@@ -879,11 +889,22 @@ var CodexSupervisor = class {
     this.timer = void 0;
     const child = this.child;
     this.child = void 0;
-    if (!child) return;
-    child.stdin?.end();
-    const force = setTimeout(() => child.kill(), this.stopGraceMs);
-    force.unref();
-    child.once("exit", () => clearTimeout(force));
+    if (!child) return Promise.resolve();
+    return new Promise((resolve) => {
+      const done = () => {
+        clearTimeout(force);
+        child.removeListener("exit", done);
+        resolve();
+      };
+      const force = setTimeout(() => {
+        logger.warn(`Codex adapter did not exit within ${this.stopGraceMs}ms of stop; killing it`);
+        child.kill();
+        done();
+      }, this.stopGraceMs);
+      force.unref();
+      child.once("exit", done);
+      child.stdin?.end();
+    });
   }
   launch() {
     const startedAt = Date.now();
@@ -1193,9 +1214,9 @@ var HubServer = class {
     });
   }
   stop() {
-    return new Promise((resolve) => {
-      this.codexSupervisor?.stop();
-      this.codexSupervisor = void 0;
+    const adapterStopped = this.codexSupervisor?.stop();
+    this.codexSupervisor = void 0;
+    const serverStopped = new Promise((resolve) => {
       if (this.heartbeatInterval) clearInterval(this.heartbeatInterval);
       if (this.telegramBot) this.telegramBot.stopPolling();
       for (const ws of this.channelSockets.values()) ws.terminate();
@@ -1215,6 +1236,8 @@ var HubServer = class {
         resolve();
       }, 3e3);
     });
+    return Promise.all([serverStopped, adapterStopped]).then(() => {
+    });
   }
   // --- HTTP Handler ---
   handleHttp(req, res) {
@@ -1471,7 +1494,16 @@ var HubServer = class {
         this.sessions.updateActivity(msg.sessionId);
         const notifySession = this.sessions.get(msg.sessionId);
         const notifyLabel = this.getSessionLabel(notifySession);
-        this.notifier.notifyWithSession(msg.sessionId, notifyLabel, `[${notifyLabel}] ${msg.title}`, msg.message, msg.level ?? "info");
+        const notifyTitle = `[${notifyLabel}] ${msg.title}`;
+        if (msg.to === "api") {
+          logger.info(`${notifyTitle}: ${msg.message}`);
+          break;
+        }
+        if (msg.to === "telegram") {
+          void this.telegramBot?.sendNotification(msg.sessionId, notifyLabel, notifyTitle, msg.message);
+          break;
+        }
+        if (msg.to !== "dashboard") this.notifier.notifyWithSession(msg.sessionId, notifyLabel, notifyTitle, msg.message, msg.level ?? "info");
         this.broadcastToDashboards({
           type: "notification",
           sessionId: msg.sessionId,
@@ -1673,6 +1705,11 @@ var HubServer = class {
           const channelWs = this.channelSockets.get(msg.sessionId);
           if (channelWs?.readyState === WebSocket.OPEN) {
             channelWs.send(JSON.stringify({ ...msg, source: "dashboard" }));
+          } else {
+            const reason = "the session is not connected";
+            logger.warn(`Message rejected for ${msg.sessionId}: ${reason}`);
+            const rejected = { type: "message_rejected", sessionId: msg.sessionId, reason };
+            if (ws.readyState === WebSocket.OPEN) ws.send(JSON.stringify(rejected));
           }
         } else if (msg.type === "image_upload") {
           this.handleImageUpload(ws, msg);
@@ -1798,19 +1835,25 @@ var HubServer = class {
     this.telegramBot.getSessions = () => this.sessions.getAll();
     this.telegramBot.onMessageToSession = (sessionId, content) => {
       const channelWs = this.channelSockets.get(sessionId);
-      if (channelWs?.readyState === WebSocket.OPEN) {
-        const msg = { type: "message_to_session", sessionId, content, source: "telegram" };
-        channelWs.send(JSON.stringify(msg));
-        logger.info(`Telegram message forwarded to session: ${sessionId}`);
+      if (channelWs?.readyState !== WebSocket.OPEN) {
+        logger.warn(`Telegram message not delivered to ${sessionId}: the session is not connected`);
+        return false;
       }
+      const msg = { type: "message_to_session", sessionId, content, source: "telegram" };
+      channelWs.send(JSON.stringify(msg));
+      logger.info(`Telegram message forwarded to session: ${sessionId}`);
+      return true;
     };
     this.telegramBot.onImageToSession = (sessionId, imagePath, mimeType, caption) => {
       const channelWs = this.channelSockets.get(sessionId);
-      if (channelWs?.readyState === WebSocket.OPEN) {
-        const msg = { type: "image_to_session", sessionId, imagePath, mimeType, content: caption, source: "telegram" };
-        channelWs.send(JSON.stringify(msg));
-        logger.info(`Telegram photo forwarded to session: ${sessionId}`);
+      if (channelWs?.readyState !== WebSocket.OPEN) {
+        logger.warn(`Telegram photo not delivered to ${sessionId}: the session is not connected`);
+        return false;
       }
+      const msg = { type: "image_to_session", sessionId, imagePath, mimeType, content: caption, source: "telegram" };
+      channelWs.send(JSON.stringify(msg));
+      logger.info(`Telegram photo forwarded to session: ${sessionId}`);
+      return true;
     };
     this.telegramBot.onPermissionVerdict = (sessionId, requestId, behavior) => {
       if (this.forwardPermissionResponse({ sessionId, requestId, behavior })) {