@delmaredigital/payload-experiments 0.4.0-rc.1 → 0.4.0-rc.3

package/dist/collections/experiments/config.js

@@ -1,3 +1,4 @@
+import { SURFACE_COPY } from '../../admin/copy/surface.js';
 import * as paths from '../../admin/paths.js';
 import { managedAccess } from '../access.js';
 import { serializeAttributeKeys, serializeFlagPoints } from '../serialize.js';
@@ -37,6 +38,10 @@ export function experimentsCollection(options) {
             drafts: false,
             maxPerDoc: 50
         },
+        labels: {
+            singular: SURFACE_COPY.test,
+            plural: SURFACE_COPY.navAllTests
+        },
         access: {
             ...managedAccess(options),
             delete: async ({ req })=>await options.access.manage({
@@ -51,8 +56,7 @@ export function experimentsCollection(options) {
                 } : false
         },
         admin: {
-            // group:false hides navigation while keeping custom view routes reachable (hidden causes 404s).
-            group: false,
+            group: SURFACE_COPY.title,
             useAsTitle: 'name',
             defaultColumns: [
                 'name',
@@ -63,7 +67,7 @@ export function experimentsCollection(options) {
             components: {
                 views: {
                     list: {
-                        Component: paths.XP_TESTS_LIST_REDIRECT
+                        Component: paths.XP_TESTS_COLLECTION_LIST
                     },
                     edit: {
                         default: {
@@ -101,8 +105,8 @@ export function experimentsCollection(options) {
             ],
             afterError: [
                 ({ error })=>{
-                    // Payload preserves public Error status/message, but omits custom codes.
-                    if (error instanceof XpRefusal && error.code === 'stale-edit') {
+                    // Payload preserves public Error status/message, but omits custom codes; the admin maps refusals by code.
+                    if (error instanceof XpRefusal) {
                         return {
                             status: error.status,
                             response: {

package/dist/collections/metrics.js

@@ -1,5 +1,6 @@
+import { SURFACE_COPY } from '../admin/copy/surface.js';
 import { CLICK_KEY, isClickSource, validClickSource } from '../goals/key.js';
-import { XP_METRIC_SOURCE_SELECT } from '../admin/paths.js';
+import { XP_METRIC_SOURCE_SELECT, XP_GOALS_COLLECTION_LIST, XP_GOAL_EDIT_REDIRECT } from '../admin/paths.js';
 import { managedAccess } from './access.js';
 import { serializeMetricSources } from './serialize.js';
 import { validateCappingType, validateCappingValue } from './metricValidation.js';
@@ -11,14 +12,25 @@ export function metricsCollection(options) {
         graphQL: false,
         disableDuplicate: true,
         versions: false,
-        // group:false hides navigation while keeping collection routes reachable (hidden causes 404s).
         labels: {
             singular: 'Goal',
             plural: 'Goals'
         },
         admin: {
-            group: false,
-            useAsTitle: 'name'
+            group: SURFACE_COPY.title,
+            useAsTitle: 'name',
+            components: {
+                views: {
+                    list: {
+                        Component: XP_GOALS_COLLECTION_LIST
+                    },
+                    edit: {
+                        default: {
+                            Component: XP_GOAL_EDIT_REDIRECT
+                        }
+                    }
+                }
+            }
         },
         access: managedAccess(options),
         hooks: {

package/dist/exports/adminRsc.d.ts

@@ -2,3 +2,6 @@ export { ExperimentsRootView } from '../admin/views/ExperimentsRootView.js';
 export { CollectionListRedirect } from '../admin/views/CollectionListRedirect.js';
 export { CollectionEditRedirect } from '../admin/views/CollectionEditRedirect.js';
 export { TestsNavLinkServer } from '../admin/views/TestsNavLinkServer.js';
+export { TestsCollectionListView } from '../admin/views/TestsCollectionListView.js';
+export { GoalsCollectionListView } from '../admin/views/GoalsCollectionListView.js';
+export { GoalEditRedirect } from '../admin/views/GoalEditRedirect.js';

package/dist/exports/adminRsc.js

@@ -2,3 +2,6 @@ export { ExperimentsRootView } from '../admin/views/ExperimentsRootView.js';
 export { CollectionListRedirect } from '../admin/views/CollectionListRedirect.js';
 export { CollectionEditRedirect } from '../admin/views/CollectionEditRedirect.js';
 export { TestsNavLinkServer } from '../admin/views/TestsNavLinkServer.js';
+export { TestsCollectionListView } from '../admin/views/TestsCollectionListView.js';
+export { GoalsCollectionListView } from '../admin/views/GoalsCollectionListView.js';
+export { GoalEditRedirect } from '../admin/views/GoalEditRedirect.js';

package/dist/fields/xpGoal.js

@@ -1,8 +1,5 @@
 import { XP_GOAL_FIELD } from '../admin/paths.js';
-import { definedClickKeys } from '../db/clickGoals.js';
-import { pooledExecutor } from '../db/executor.js';
-import { clickKeys } from '../goals/cache.js';
-import { CLICK_KEY } from '../goals/key.js';
+import { validateClickGoal } from '../goals/validate.js';
 /** The host renders this value as data-xp-goal on its interactive element. */ export function xpGoalField() {
     return {
         name: 'xpGoal',
@@ -14,15 +11,6 @@ import { CLICK_KEY } from '../goals/key.js';
                 Field: XP_GOAL_FIELD
             }
         },
-        validate: async (value, { req })=>{
-            if (!value) return true;
-            if (!CLICK_KEY.test(value)) return 'Use a click goal short name.';
-            const options = req.payload.config.custom?.xp;
-            if (!options || await options.access.manage({
-                req
-            }) !== true) return true;
-            const keys = await clickKeys(req.payload);
-            return !keys || keys.has(value) || (await definedClickKeys(pooledExecutor(req.payload))).has(value) || 'No click goal has this name yet. Create it with "+ New click goal".';
-        }
+        validate: (value, { req })=>validateClickGoal(value, req)
     };
 }

package/dist/goals/picker/copy.d.ts

@@ -10,7 +10,9 @@ export declare const CLICK_GOAL_COPY: {
     readonly createGoal: "Create goal";
     readonly cancel: "Cancel";
     readonly undefinedKey: "No click goal has this name yet. Create it with \"+ New click goal\".";
+    readonly invalidKey: "Use a click goal short name.";
     readonly slugRule: "Use 1–64 lowercase letters, numbers, underscores or hyphens, starting with a letter or number.";
     readonly duplicateSlug: "Another goal already uses this short name. Change it under Advanced.";
     readonly saveError: "Couldn't save the goal. Try again.";
 };
+export declare function puckGoalRefusal(rawKey: string, block: string, malformed: boolean, more?: number): string;

package/dist/goals/picker/copy.js

@@ -9,7 +9,14 @@
     createGoal: 'Create goal',
     cancel: 'Cancel',
     undefinedKey: 'No click goal has this name yet. Create it with "+ New click goal".',
+    invalidKey: 'Use a click goal short name.',
     slugRule: 'Use 1–64 lowercase letters, numbers, underscores or hyphens, starting with a letter or number.',
     duplicateSlug: 'Another goal already uses this short name. Change it under Advanced.',
     saveError: "Couldn't save the goal. Try again."
 };
+export function puckGoalRefusal(rawKey, block, malformed, more = 0) {
+    // A malformed key can be any length; keep the dialog readable.
+    const key = rawKey.length > 64 ? `${rawKey.slice(0, 64)}…` : rawKey;
+    const sentence = malformed ? `Click goal "${key}" on the ${block} block isn't a valid short name. Use lowercase letters, numbers, - and _, then publish.` : `Click goal "${key}" doesn't exist yet. Create it with "+ New click goal" on the ${block} block, then publish.`;
+    return sentence + (more > 0 ? ` (and ${more} more)` : '');
+}

package/dist/goals/validate.d.ts

@@ -0,0 +1,3 @@
+import type { PayloadRequest } from 'payload';
+/** Shared publish validation for Payload fields and Puck JSON props. */
+export declare function validateClickGoal(value: string | null | undefined, req: PayloadRequest): Promise<true | string>;

package/dist/goals/validate.js

@@ -0,0 +1,15 @@
+import { definedClickKeys } from '../db/clickGoals.js';
+import { pooledExecutor } from '../db/executor.js';
+import { clickKeys } from './cache.js';
+import { CLICK_KEY } from './key.js';
+import { CLICK_GOAL_COPY } from './picker/copy.js';
+/** Shared publish validation for Payload fields and Puck JSON props. */ export async function validateClickGoal(value, req) {
+    if (!value) return true;
+    if (!CLICK_KEY.test(value)) return CLICK_GOAL_COPY.invalidKey;
+    const options = req.payload.config.custom?.xp;
+    if (!options || await options.access.manage({
+        req
+    }) !== true) return true;
+    const keys = await clickKeys(req.payload);
+    return !keys || keys.has(value) || (await definedClickKeys(pooledExecutor(req.payload))).has(value) || CLICK_GOAL_COPY.undefinedKey;
+}

package/dist/hooks/puckGoals.d.ts

@@ -0,0 +1,5 @@
+import { type CollectionBeforeChangeHook } from 'payload';
+/** Host component labels are not passed to the plugin; display their type as words. */
+export declare function puckBlockName(rawType: string): string;
+/** Validate only the Puck JSON included in a publishing write. */
+export declare function puckGoalsBeforeChange(field: string): CollectionBeforeChangeHook;

package/dist/hooks/puckGoals.js

@@ -0,0 +1,62 @@
+import { ValidationError } from 'payload';
+import { validateClickGoal } from '../goals/validate.js';
+import { CLICK_KEY } from '../goals/key.js';
+import { puckGoalRefusal } from '../goals/picker/copy.js';
+/** Host component labels are not passed to the plugin; display their type as words. */ export function puckBlockName(rawType) {
+    // Cap before any regex: the type comes from saved page JSON and the first pattern backtracks on long capital runs.
+    const type = rawType.slice(0, 64);
+    const words = type.replace(/([A-Z]+)([A-Z][a-z])/g, '$1 $2').replace(/([a-z0-9])([A-Z])/g, '$1 $2').replace(/([A-Za-z])([0-9])/g, '$1 $2').replace(/[\s_-]+/g, ' ').trim();
+    return words ? words[0].toUpperCase() + words.slice(1) : 'Page';
+}
+/** Validate only the Puck JSON included in a publishing write. */ export function puckGoalsBeforeChange(field) {
+    return async function validatePuckGoals({ collection, data, originalDoc, req }) {
+        const drafts = Boolean(collection.versions && collection.versions.drafts);
+        if (drafts && data._status !== 'published') return data;
+        // Publishing a stored draft without resending its JSON publishes the draft's JSON.
+        let value = data[field] !== undefined ? data[field] : drafts ? originalDoc?.[field] : undefined;
+        if (value === undefined) return data;
+        if (typeof value === 'string') {
+            try {
+                value = JSON.parse(value);
+            } catch  {
+                return data;
+            }
+        }
+        const errors = [];
+        let first;
+        // Holds the raw component type; it is humanised once, for the first refusal only.
+        async function walk(value, path, block = '') {
+            if (!value || typeof value !== 'object') return;
+            const item = value;
+            if (typeof item.type === 'string' && item.props && typeof item.props === 'object' && !Array.isArray(item.props)) {
+                block = item.type;
+            }
+            for (const [key, prop] of Object.entries(value)){
+                const propPath = `${path}.${key}`;
+                if (key === 'xpGoal' && typeof prop === 'string') {
+                    const result = await validateClickGoal(prop, req);
+                    if (result !== true) {
+                        first ??= {
+                            key: prop,
+                            block
+                        };
+                        errors.push({
+                            path: propPath,
+                            message: result
+                        });
+                    }
+                } else await walk(prop, propPath, block);
+            }
+        }
+        await walk(value, field);
+        if (first) {
+            const error = new ValidationError({
+                collection: collection.slug,
+                errors
+            });
+            error.message = puckGoalRefusal(first.key, first.block ? puckBlockName(first.block) : 'Page', !CLICK_KEY.test(first.key), errors.length - 1);
+            throw error;
+        }
+        return data;
+    };
+}

package/dist/plugin.js

@@ -1,6 +1,7 @@
 import { buildCollections } from './collections/index.js';
 import { buildEndpoints } from './endpoints/index.js';
 import { contentChangesBeforeHook, contentChangesHook } from './hooks/contentChanges.js';
+import { puckGoalsBeforeChange } from './hooks/puckGoals.js';
 import { pageGuardAfterChange, pageGuardAfterOperation, pageGuardBeforeChange, pageGuardBeforeDelete, pageGuardBeforeOperation } from './hooks/pageGuard.js';
 import { createOnInit } from './onInit.js';
 import { puckCollections, resolveOptions } from './options.js';
@@ -23,8 +24,6 @@ export function createExperimentsPlugin(input) {
         // Erase the user subtype only at this non-generic factory boundary.
         const { collections, globals } = buildCollections(options);
         const onInit = createOnInit(options);
-        const beforeDashboard = config.admin?.components?.beforeDashboard ?? [];
-        const beforeNavLinks = config.admin?.components?.beforeNavLinks ?? [];
         return {
             ...config,
             admin: {
@@ -34,10 +33,6 @@ export function createExperimentsPlugin(input) {
                     xpTestsSurface: {
                         path: paths.XP_TESTS_SURFACE,
                         type: 'component'
-                    },
-                    xpTestsNav: {
-                        path: paths.XP_TESTS_NAV_CLIENT,
-                        type: 'component'
                     }
                 },
                 components: {
@@ -48,20 +43,16 @@ export function createExperimentsPlugin(input) {
                             Component: paths.XP_TESTS_VIEW,
                             path: '/experiments/:segments*'
                         }
-                    },
-                    beforeDashboard: beforeDashboard.includes(paths.XP_TESTS_DASHBOARD_CARDS) ? beforeDashboard : [
-                        ...beforeDashboard,
-                        paths.XP_TESTS_DASHBOARD_CARDS
-                    ],
-                    beforeNavLinks: beforeNavLinks.includes(paths.XP_TESTS_NAV_LINK) ? beforeNavLinks : [
-                        ...beforeNavLinks,
-                        paths.XP_TESTS_NAV_LINK
-                    ]
+                    }
                 }
             },
             collections: [
+                ...[
+                    'xp-experiments',
+                    'xp-metrics'
+                ].map((slug)=>collections.find((collection)=>collection.slug === slug)),
                 ...(config.collections ?? []).map((collection)=>{
-                    const puck = options.puck?.enabled && registrations.some((entry)=>entry.slug === collection.slug);
+                    const puck = options.puck?.enabled && registrations.find((entry)=>entry.slug === collection.slug);
                     const page = options.pages?.collections.some((entry)=>entry.slug === collection.slug);
                     const blocks = options.blocks?.collections.find((entry)=>entry.slug === collection.slug);
                     if (!puck && !page && !blocks) return collection;
@@ -87,7 +78,10 @@ export function createExperimentsPlugin(input) {
                             beforeChange: [
                                 ...collection.hooks?.beforeChange ?? [],
                                 pageGuardBeforeChange,
-                                contentChangesBeforeHook
+                                contentChangesBeforeHook,
+                                ...puck ? [
+                                    puckGoalsBeforeChange(puck.field)
+                                ] : []
                             ],
                             beforeOperation: [
                                 ...collection.hooks?.beforeOperation ?? [],
@@ -109,7 +103,7 @@ export function createExperimentsPlugin(input) {
                         }
                     };
                 }),
-                ...collections
+                ...collections.filter((collection)=>collection.slug !== 'xp-experiments' && collection.slug !== 'xp-metrics')
             ],
             globals: [
                 ...config.globals ?? [],

package/dist/puck/editor/editor.chrome.css

@@ -120,3 +120,16 @@
 .xp-slot-readout > .xp-ui-button { justify-self: start; }
 .xp-slot-editor .xp-ui-tablist { flex: 1 1 auto; min-width: 0; flex-wrap: wrap; }
 .xp-slot-root.xp-puck-field { display: grid; gap: var(--xp-space-3); min-width: 0; }
+
+/* Puck's inline field sidebar stays light, including under Payload's dark-mode text overrides. */
+[class*="_PuckFields"] .xp-slot-root .xp-ui-button--secondary { color: var(--xp-text); }
+[class*="_PuckFields"] .xp-slot-root .xp-ui-button--primary { color: var(--xp-accent-fg); }
+[class*="_PuckFields"] .xp-slot-root .xp-ui-error { color: var(--xp-error); }
+[class*="_PuckFields"] .xp-slot-root .xp-ui-help { color: var(--xp-text-2); }
+[class*="_PuckFields"] .xp-slot-root .xp-ui-field label { color: var(--xp-text); }
+[class*="_PuckFields"] .xp-puck-field .xp-ui-button:disabled {
+  opacity: 1;
+  background: var(--xp-surface-3);
+  border-color: var(--xp-border-strong);
+  color: var(--xp-text-2);
+}

package/dist/puck/editor/editor.css

@@ -55,6 +55,7 @@
   --xp-space-3: 12px;
   --xp-space-4: 16px;
   --xp-space-5: 20px;
+  --xp-field-gap: calc((20 / 13) * 1rem);
   --xp-space-6: 24px;
   --xp-space-7: 28px;
   --xp-space-8: 32px;
@@ -141,6 +142,7 @@
   --xp-space-3: 12px;
   --xp-space-4: 16px;
   --xp-space-5: 20px;
+  --xp-field-gap: calc((20 / 13) * 1rem);
   --xp-space-6: 24px;
   --xp-space-7: 28px;
   --xp-space-8: 32px;
@@ -170,6 +172,92 @@
   --xp-font-size-body: 15px;
 }
 
+[class*="_PuckFields"] .xp-slot-root {
+  --xp-bg: rgb(245, 245, 245);
+  --xp-surface: rgb(255, 255, 255);
+  --xp-surface-2: rgb(235, 235, 235);
+  --xp-surface-3: rgb(221, 221, 221);
+  --xp-border: rgb(235, 235, 235);
+  --xp-border-strong: rgb(195, 195, 195);
+  --xp-text: rgb(34, 34, 34);
+  --xp-text-2: rgb(87, 87, 87);
+  --xp-text-3: rgb(141, 141, 141);
+  --xp-accent: rgb(47, 47, 47);
+  --xp-accent-hover: rgb(20, 20, 20);
+  --xp-accent-active: rgb(7, 7, 7);
+  --xp-accent-subtle: rgb(208, 208, 208);
+  --xp-accent-fg: rgb(255, 255, 255);
+  --xp-accent-text: rgb(34, 34, 34);
+  --xp-accent-text-decoration: none;
+  --xp-focus: rgb(47, 47, 47);
+  --xp-series-muted: rgb(181, 181, 181);
+  --xp-success: #1a6a3a;
+  --xp-success-bg: #e8f4ec;
+  --xp-success-border: #bddfc9;
+  --xp-warning: #8a5a0b;
+  --xp-warning-bg: #fbf3e1;
+  --xp-warning-border: #ecd6a2;
+  --xp-error: #a63030;
+  --xp-error-bg: #fbeaea;
+  --xp-error-border: #efc3c3;
+  --xp-series-a: #2a78d6;
+  --xp-series-b: #eb6834;
+  --xp-series-c: #8056b3;
+  --xp-radius-control: 8px;
+  --xp-radius-card: 12px;
+  --xp-radius-chip: 6px;
+  --xp-font: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, 'Helvetica Neue', Arial, sans-serif;
+  --xp-mono: 'SF Mono', Menlo, Consolas, Monaco, monospace;
+  --xp-text-display: 600 28px/32px -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, 'Helvetica Neue', Arial, sans-serif;
+  --xp-text-title: 600 20px/28px -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, 'Helvetica Neue', Arial, sans-serif;
+  --xp-text-body: 400 15px/22px -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, 'Helvetica Neue', Arial, sans-serif;
+  --xp-text-small: 400 13px/18px -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, 'Helvetica Neue', Arial, sans-serif;
+  --xp-motion: 120ms;
+  --xp-space-half: 2px;
+  --xp-space-one-half: 6px;
+  --xp-version-share-width: 96px;
+  --xp-version-share-width-mobile: 84px;
+  --xp-version-state-width: 192px;
+  --xp-version-remove-width: 128px;
+  --xp-targeting-attribute-width: 150px;
+  --xp-targeting-comparison-width: 140px;
+  --xp-legend-key-size: 10px;
+  --xp-legend-key-radius: 3px;
+  --xp-space-1: 4px;
+  --xp-space-2: 8px;
+  --xp-space-3: 12px;
+  --xp-space-4: 16px;
+  --xp-space-5: 20px;
+  --xp-field-gap: calc((20 / 13) * 1rem);
+  --xp-space-6: 24px;
+  --xp-space-7: 28px;
+  --xp-space-8: 32px;
+  --xp-surface-raised: rgb(235, 235, 235);
+  --xp-border-control: rgb(195, 195, 195);
+  --xp-input-border: rgb(181, 181, 181);
+  --xp-border-accent: rgb(154, 154, 154);
+  --xp-text-muted: rgb(87, 87, 87);
+  --xp-text-strong: rgb(34, 34, 34);
+  --xp-text-emphasis: rgb(34, 34, 34);
+  --xp-input-bg: rgb(255, 255, 255);
+  --xp-overlay: rgba(5, 5, 5, 0.5);
+  --xp-success-surface: #e8f4ec;
+  --xp-success-text: #1a6a3a;
+  --xp-success-text-strong: #1a6a3a;
+  --xp-warning-surface: #fbf3e1;
+  --xp-warning-text: #8a5a0b;
+  --xp-warning-text-strong: #8a5a0b;
+  --xp-error-surface: #fbeaea;
+  --xp-error-text: #a63030;
+  --xp-radius: 8px;
+  --xp-radius-large: 12px;
+  --xp-dash-card-gap: 12px;
+  --xp-dash-card-gap-small: 8px;
+  --xp-font-body: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, 'Helvetica Neue', Arial, sans-serif;
+  --xp-font-size-small: 13px;
+  --xp-font-size-body: 15px;
+}
+
 /* Shared primitives: no host palette references, and no global element resets. */
 .xp-ui-chips, .xp-ui-chips-control, .xp-ui-chips-item, .xp-ui-button, .xp-ui-input, .xp-ui-toggle, .xp-ui-tab, .xp-ui-dialog, .xp-ui-card { box-sizing: border-box; }
 .xp-ui-button { display: inline-flex; align-items: center; justify-content: center; gap: 8px; min-height: 36px; padding: 7px 14px; border-radius: var(--xp-radius-control); border: 1px solid transparent; font: 500 14px/20px var(--xp-font); color: var(--xp-text); background: transparent; cursor: pointer; white-space: normal; overflow-wrap: anywhere; max-width: 100%; min-width: 0; text-decoration: none; transition: background-color var(--xp-motion), border-color var(--xp-motion), color var(--xp-motion); }
@@ -246,6 +334,10 @@
 .xp-ui-chips p:not(.xp-ui-error) { margin: 0; color: var(--xp-text-muted); font-size: var(--xp-font-size-small); }
 /* Quiet actions and breadcrumb links stay neutral; only the selected tab takes the text accent. */
 .xp-ui-button-group { display: flex; flex-wrap: wrap; gap: 8px; min-width: 0; max-width: 100%; }
+.xp-ui-inline-row { display: flex; flex-wrap: wrap; align-items: end; gap: var(--xp-space-3); min-width: 0; }
+.xp-ui-inline-row > .xp-ui-field { flex: 1 1 auto; min-width: 0; }
+.xp-ui-inline-row > .xp-ui-button { flex: 0 0 auto; }
+.xp-ui-subpanel { display: grid; gap: var(--xp-space-3); border: 1px solid var(--xp-border); border-radius: var(--xp-radius-card); padding: var(--xp-space-4); }
 @media (prefers-reduced-motion: reduce) {
   .xp-ui-button, .xp-ui-input, .xp-ui-toggle, .xp-ui-toggle::before, .xp-ui-chips-control { transition: none; }
 }
@@ -385,3 +477,16 @@
 .xp-slot-readout > .xp-ui-button { justify-self: start; }
 .xp-slot-editor .xp-ui-tablist { flex: 1 1 auto; min-width: 0; flex-wrap: wrap; }
 .xp-slot-root.xp-puck-field { display: grid; gap: var(--xp-space-3); min-width: 0; }
+
+/* Puck's inline field sidebar stays light, including under Payload's dark-mode text overrides. */
+[class*="_PuckFields"] .xp-slot-root .xp-ui-button--secondary { color: var(--xp-text); }
+[class*="_PuckFields"] .xp-slot-root .xp-ui-button--primary { color: var(--xp-accent-fg); }
+[class*="_PuckFields"] .xp-slot-root .xp-ui-error { color: var(--xp-error); }
+[class*="_PuckFields"] .xp-slot-root .xp-ui-help { color: var(--xp-text-2); }
+[class*="_PuckFields"] .xp-slot-root .xp-ui-field label { color: var(--xp-text); }
+[class*="_PuckFields"] .xp-puck-field .xp-ui-button:disabled {
+  opacity: 1;
+  background: var(--xp-surface-3);
+  border-color: var(--xp-border-strong);
+  color: var(--xp-text-2);
+}

package/dist/puck/editor/xpGoalPuckEditorField.js

@@ -30,22 +30,32 @@ function XpGoalPuckEditor({ value, onChange, api, readOnly }) {
             }),
             picker.canManage && !readOnly ? /*#__PURE__*/ _jsxs(_Fragment, {
                 children: [
-                    /*#__PURE__*/ _jsxs(Select, {
-                        id: `${id}-picker`,
-                        label: C.choose,
-                        value: picker.goals.some((goal)=>goal.slug === value) ? value : '',
-                        onChange: (event)=>{
-                            if (event.currentTarget.value) onChange(event.currentTarget.value);
-                        },
+                    /*#__PURE__*/ _jsxs("div", {
+                        className: "xp-ui-inline-row",
                         children: [
-                            /*#__PURE__*/ _jsx("option", {
-                                value: "",
-                                children: C.choose
+                            /*#__PURE__*/ _jsxs(Select, {
+                                id: `${id}-picker`,
+                                label: C.choose,
+                                value: picker.goals.some((goal)=>goal.slug === value) ? value : '',
+                                onChange: (event)=>{
+                                    if (event.currentTarget.value) onChange(event.currentTarget.value);
+                                },
+                                children: [
+                                    /*#__PURE__*/ _jsx("option", {
+                                        value: "",
+                                        children: C.choose
+                                    }),
+                                    picker.goals.map((goal)=>/*#__PURE__*/ _jsx("option", {
+                                            value: goal.slug,
+                                            children: goal.name
+                                        }, goal.id))
+                                ]
                             }),
-                            picker.goals.map((goal)=>/*#__PURE__*/ _jsx("option", {
-                                    value: goal.slug,
-                                    children: goal.name
-                                }, goal.id))
+                            !picker.panel.open ? /*#__PURE__*/ _jsx(Button, {
+                                type: "button",
+                                onClick: picker.open,
+                                children: C.newGoal
+                            }) : null
                         ]
                     }),
                     picker.undefinedKey(value ?? '') ? /*#__PURE__*/ _jsx("p", {
@@ -53,11 +63,8 @@ function XpGoalPuckEditor({ value, onChange, api, readOnly }) {
                         role: "status",
                         children: C.undefinedKey
                     }) : null,
-                    !picker.panel.open ? /*#__PURE__*/ _jsx(Button, {
-                        type: "button",
-                        onClick: picker.open,
-                        children: C.newGoal
-                    }) : /*#__PURE__*/ _jsxs("section", {
+                    picker.panel.open ? /*#__PURE__*/ _jsxs("section", {
+                        className: "xp-ui-subpanel",
                         "aria-labelledby": `${id}-title`,
                         children: [
                             /*#__PURE__*/ _jsx("h3", {
@@ -100,6 +107,7 @@ function XpGoalPuckEditor({ value, onChange, api, readOnly }) {
                                 children: [
                                     /*#__PURE__*/ _jsx(Button, {
                                         type: "button",
+                                        variant: "primary",
                                         disabled: picker.panel.pending || !picker.panel.name.trim(),
                                         onClick: ()=>void picker.create(),
                                         children: C.createGoal
@@ -113,7 +121,7 @@ function XpGoalPuckEditor({ value, onChange, api, readOnly }) {
                                 ]
                             })
                         ]
-                    })
+                    }) : null
                 ]
             }) : null
         ]

package/dist/sanitizeReadinessDetail.js

@@ -63,6 +63,8 @@ const failure = (value)=>value === 'placements-failed' || value === 'forbidden'
             } : undefined;
         case 'no-placements':
             return failure(detail) ? detail : undefined;
+        case 'placement-removed':
+            return undefined;
         case 'page-in-use':
             {
                 if (!object(detail) || !Array.isArray(detail.paths)) return undefined;

package/dist/transitions/checkStart.d.ts

@@ -2,13 +2,14 @@ import { type GoalContent } from '../goals/fairness.js';
 import type { Arm, DocId, ExperimentKind, ExposurePolicy, FlagPoint, MetricSource, ResolvedOptions, Status, TargetingRule, UnitType } from '../types/contracts.js';
 import type { ArmIssueCode, PreflightResult } from '../types/endpoints.js';
 import type { BlockPlacement, FlagPlacement } from './placements.js';
-export type ReadinessCode = ArmIssueCode | 'goal-in-some-versions' | 'placement-unchecked' | 'invalid-status' | 'no-planned-duration' | 'no-primary-metric' | 'no-reach-per-day' | 'placement-unpublished' | 'duplicate-version-row' | 'interacting-tests' | 'version-identical' | 'version-same-address' | 'unknown-collection' | 'page-no-targets' | 'page-in-use' | 'page-target-unpublished' | 'page-targets-unchecked' | 'version-page-unavailable' | 'version-page-unchecked' | 'page-user-unit' | 'flag-no-point' | 'flag-params-invalid' | 'flag-point-busy' | 'flag-placement-missing' | 'no-placements' | 'empty-slot' | 'make-content-unsupported' | 'layer-unit-mismatch' | 'layer-full' | 'unknown-metric-source' | 'unit-source-mismatch' | 'block-path-rule' | 'undeclared-targeting-key' | 'invalid-targeting-rule';
+export type ReadinessCode = ArmIssueCode | 'goal-in-some-versions' | 'placement-unchecked' | 'invalid-status' | 'no-planned-duration' | 'no-primary-metric' | 'no-reach-per-day' | 'placement-unpublished' | 'duplicate-version-row' | 'interacting-tests' | 'version-identical' | 'version-same-address' | 'unknown-collection' | 'page-no-targets' | 'page-in-use' | 'page-target-unpublished' | 'page-targets-unchecked' | 'version-page-unavailable' | 'version-page-unchecked' | 'page-user-unit' | 'flag-no-point' | 'flag-params-invalid' | 'flag-point-busy' | 'flag-placement-missing' | 'no-placements' | 'placement-removed' | 'empty-slot' | 'make-content-unsupported' | 'layer-unit-mismatch' | 'layer-full' | 'unknown-metric-source' | 'unit-source-mismatch' | 'block-path-rule' | 'undeclared-targeting-key' | 'invalid-targeting-rule';
 export interface StartExperiment {
     id: DocId;
     slug: string;
     status: Status;
     kind: ExperimentKind;
     unitType: UnitType;
+    phase?: number;
     pageCollection?: string | null;
     arms: Arm[];
     allocation: number;

package/dist/transitions/checkStart.js

@@ -114,7 +114,9 @@ function invalidParams(arms, point) {
             }))
     });
     const placements = input.placements ?? [];
-    add('no-placements', e.kind !== 'block' || !input.placementError && placements.length > 0, input.placementError);
+    const placementRemoved = e.kind === 'block' && e.status === 'stopped' && (e.phase ?? 0) >= 1 && placements.length === 0 && input.placementError === undefined;
+    add('no-placements', placementRemoved || e.kind !== 'block' || !input.placementError && placements.length > 0, input.placementError);
+    add('placement-removed', !placementRemoved);
     const unpublished = placements.filter((p)=>!p.published && !placements.some((other)=>other.published && other.collection === p.collection && String(other.id) === String(p.id)));
     add('placement-unpublished', unpublished.length === 0, unpublished.map(placementDetail));
     const duplicates = placements.filter((p)=>p.published && p.duplicateRows);

package/dist/transitions/decide.js

@@ -57,6 +57,7 @@ export async function decide(req, { experimentId, winnerArm, note, confirmation
                 ...current,
                 arms: test.arms
             }, placements);
+            if (rescan.placements.length === 0) refuse('placement-removed');
             await refreshPlacementDocs(exec, experimentId, test.phase, rescan.docs);
         }
         if (current.kind === 'page' && current.status === 'stopped') {

package/dist/transitions/start.js

@@ -5,7 +5,7 @@ import { lockPagePaths } from '../db/locks.js';
 import { lockMetricsForFreeze } from '../db/metricUsage.js';
 import { DEFAULT_SEQUENTIAL_TUNING_PARAMETER } from '../constants.js';
 import { claimSlices } from '../db/slices.js';
-import { asymmetricGoalsCopy, sameAddressCopy, interactingTestsCopy, pageInUseCopy, unpublishedPageCopy } from '../admin/copy/readiness.js';
+import { READINESS_COPY, asymmetricGoalsCopy, sameAddressCopy, interactingTestsCopy, pageInUseCopy, unpublishedPageCopy } from '../admin/copy/readiness.js';
 import { GROUP_LABELS } from '../admin/copy/arms.js';
 import { XpRefusal } from '../errors.js';
 import { isOpValid } from '../targeting/ops.js';
@@ -43,6 +43,7 @@ export function refuse(code, detail) {
             return d ? interactingTestsCopy(d.path, d.status, d.name, d.version) : 'Finish one of the tests first.';
         })(),
         'unknown-collection': "That page type isn't set up for tests.",
+        'placement-removed': READINESS_COPY.placementRemoved,
         'page-in-use': pageInUseCopy(detail?.paths?.[0] ?? 'this page'),
         'version-same-address': (()=>{
             const d = detail;

package/dist/types/endpoints.d.ts

@@ -7,7 +7,7 @@ import type { Snapshot, VerdictCode } from './snapshot.js';
 export type ArmIssueCode = 'weights-total' | 'control-count' | 'control-first' | 'holdout-last' | 'holdout-count' | 'variant-count' | 'duplicate-key' | 'duplicate-slot' | 'slot-required' | 'invalid-key';
 /** Content-report dismiss/restore refusals (CORE-44). */
 export type ContentEntryRefusal = 'not-decided' | 'entry-not-found' | 'entry-ok' | 'entry-dismissed' | 'entry-not-dismissed';
-export type RefusalCode = ArmIssueCode | 'goal-in-some-versions' | 'placement-unchecked' | 'placement-unpublished' | 'duplicate-version-row' | 'interacting-tests' | 'placements-changed' | 'page-busy' | 'wrap-target-missing' | 'version-identical' | 'version-same-address' | 'unknown-collection' | 'not-found' | ContentEntryRefusal | 'no-planned-duration' | 'no-primary-metric' | 'no-placements' | 'empty-slot' | 'page-in-use' | 'page-no-targets' | 'page-target-unpublished' | 'page-user-unit' | 'version-page-unavailable' | 'version-page-unchecked' | 'flag-no-point' | 'flag-params-invalid' | 'flag-point-busy' | 'flag-placement-missing' | 'layer-full' | 'layer-unit-mismatch' | 'unknown-metric-source' | 'unit-source-mismatch' | 'no-reach-per-day' | 'invalid-status' | 'stale-draft' | 'stale-edit' | 'commit-unverified' | 'allocation-lower' | 'confirmation-required' | 'invalid-winner' | 'slices-taken' | 'locked-placement' | 'not-implemented' | 'forbidden' | 'unauthenticated' | 'body-too-large' | 'invalid-body' | 'too-many-ids' | 'invalid-phase' | 'invalid-ids' | 'recompute-failed' | 'analysis-failed' | 'undeclared-targeting-key' | 'invalid-targeting-rule' | 'block-path-rule' | 'duplicate-metric';
+export type RefusalCode = ArmIssueCode | 'goal-in-some-versions' | 'placement-unchecked' | 'placement-unpublished' | 'duplicate-version-row' | 'interacting-tests' | 'placements-changed' | 'page-busy' | 'wrap-target-missing' | 'version-identical' | 'version-same-address' | 'unknown-collection' | 'not-found' | ContentEntryRefusal | 'no-planned-duration' | 'no-primary-metric' | 'no-placements' | 'placement-removed' | 'empty-slot' | 'page-in-use' | 'page-no-targets' | 'page-target-unpublished' | 'page-user-unit' | 'version-page-unavailable' | 'version-page-unchecked' | 'flag-no-point' | 'flag-params-invalid' | 'flag-point-busy' | 'flag-placement-missing' | 'layer-full' | 'layer-unit-mismatch' | 'unknown-metric-source' | 'unit-source-mismatch' | 'no-reach-per-day' | 'invalid-status' | 'stale-draft' | 'stale-edit' | 'commit-unverified' | 'allocation-lower' | 'confirmation-required' | 'invalid-winner' | 'slices-taken' | 'locked-placement' | 'not-implemented' | 'forbidden' | 'unauthenticated' | 'body-too-large' | 'invalid-body' | 'too-many-ids' | 'invalid-phase' | 'invalid-ids' | 'recompute-failed' | 'analysis-failed' | 'undeclared-targeting-key' | 'invalid-targeting-rule' | 'block-path-rule' | 'duplicate-metric';
 export type ErrorEnvelope = {
     errors: Array<{
         code: RefusalCode;