@delmaredigital/payload-experiments 0.3.0-rc.4 → 0.4.0-rc.2

package/dist/admin/goals/XpGoalField.d.ts

@@ -0,0 +1,4 @@
+import type { TextFieldClientProps } from 'payload';
+import '../theme.css';
+import './xpGoalField.css';
+export declare function XpGoalField({ path, field, readOnly }: TextFieldClientProps): import("react").JSX.Element;

package/dist/admin/goals/XpGoalField.js

@@ -0,0 +1,168 @@
+'use client';
+import { jsx as _jsx, jsxs as _jsxs, Fragment as _Fragment } from "react/jsx-runtime";
+import { Button, FieldError, FieldLabel, SelectInput, TextInput, useAuth, useConfig, useField } from '@payloadcms/ui';
+import { useId } from 'react';
+import { useClickGoalPicker } from '../../goals/picker/useClickGoalPicker.js';
+import { CLICK_GOAL_COPY as C } from '../../goals/picker/copy.js';
+import '../theme.css';
+import './xpGoalField.css';
+export function XpGoalField({ path, field, readOnly }) {
+    const { value, setValue, showError } = useField({
+        path
+    });
+    const { permissions } = useAuth();
+    const { config } = useConfig();
+    const access = permissions?.collections?.['xp-experiments'];
+    const locked = Boolean(readOnly || field.admin?.readOnly);
+    const picker = useClickGoalPicker(config.routes.api, {
+        enabled: access?.update === true,
+        onSelect: setValue
+    });
+    const id = useId(), namePath = `${id}-name`, slugPath = `${id}-slug`;
+    const stopEnter = (event)=>{
+        if (event.key === 'Enter') {
+            event.preventDefault();
+            event.stopPropagation();
+        }
+    };
+    return /*#__PURE__*/ _jsxs("div", {
+        className: "field-type xp-goal-field",
+        children: [
+            /*#__PURE__*/ _jsx(TextInput, {
+                path: path,
+                label: field.label ?? C.label,
+                description: field.admin?.description,
+                required: field.required,
+                readOnly: locked,
+                value: value ?? '',
+                showError: showError,
+                Error: /*#__PURE__*/ _jsx(FieldError, {
+                    path: path,
+                    showError: showError
+                }),
+                onChange: (event)=>{
+                    if (!locked) setValue(event.currentTarget.value);
+                }
+            }),
+            picker.canManage && !locked ? /*#__PURE__*/ _jsxs(_Fragment, {
+                children: [
+                    /*#__PURE__*/ _jsxs("div", {
+                        className: "xp-goal-field__row",
+                        children: [
+                            /*#__PURE__*/ _jsx(SelectInput, {
+                                name: `${path}__xpGoalPicker`,
+                                path: `${path}__xpGoalPicker`,
+                                className: "xp-goal-field__select",
+                                value: picker.goals.some((goal)=>goal.slug === value) ? value : undefined,
+                                options: picker.goals.map((goal)=>({
+                                        value: goal.slug,
+                                        label: goal.name
+                                    })),
+                                placeholder: C.choose,
+                                isClearable: false,
+                                label: C.choose,
+                                onChange: (option)=>{
+                                    if (option && !Array.isArray(option)) setValue(String(option.value));
+                                }
+                            }),
+                            !picker.panel.open ? /*#__PURE__*/ _jsx(Button, {
+                                type: "button",
+                                margin: false,
+                                buttonStyle: "secondary",
+                                onClick: picker.open,
+                                children: C.newGoal
+                            }) : null
+                        ]
+                    }),
+                    picker.undefinedKey(value ?? '') ? /*#__PURE__*/ _jsx("p", {
+                        role: "status",
+                        children: C.undefinedKey
+                    }) : null,
+                    picker.panel.open ? /*#__PURE__*/ _jsxs("section", {
+                        className: "xp-goal-field__panel",
+                        "aria-labelledby": `${id}-title`,
+                        children: [
+                            /*#__PURE__*/ _jsx("h3", {
+                                id: `${id}-title`,
+                                children: C.title
+                            }),
+                            /*#__PURE__*/ _jsxs("div", {
+                                className: "field-type text",
+                                children: [
+                                    /*#__PURE__*/ _jsx(FieldLabel, {
+                                        path: namePath,
+                                        label: C.name
+                                    }),
+                                    /*#__PURE__*/ _jsx("input", {
+                                        id: `field-${namePath}`,
+                                        value: picker.panel.name,
+                                        disabled: picker.panel.pending,
+                                        onKeyDown: stopEnter,
+                                        onChange: (event)=>picker.setName(event.currentTarget.value)
+                                    })
+                                ]
+                            }),
+                            /*#__PURE__*/ _jsxs("details", {
+                                open: picker.panel.advanced,
+                                onToggle: (event)=>picker.setAdvanced(event.currentTarget.open),
+                                children: [
+                                    /*#__PURE__*/ _jsx("summary", {
+                                        children: C.advanced
+                                    }),
+                                    /*#__PURE__*/ _jsxs("div", {
+                                        className: "field-type text",
+                                        children: [
+                                            /*#__PURE__*/ _jsx(FieldLabel, {
+                                                path: slugPath,
+                                                label: C.slug
+                                            }),
+                                            /*#__PURE__*/ _jsx("input", {
+                                                id: `field-${slugPath}`,
+                                                value: picker.panel.slug,
+                                                disabled: picker.panel.pending,
+                                                onKeyDown: stopEnter,
+                                                "aria-invalid": Boolean(picker.panel.errors.slug) || undefined,
+                                                "aria-describedby": picker.panel.errors.slug ? `${id}-slug-error` : undefined,
+                                                onChange: (event)=>picker.setSlug(event.currentTarget.value)
+                                            }),
+                                            picker.panel.errors.slug ? /*#__PURE__*/ _jsx("p", {
+                                                id: `${id}-slug-error`,
+                                                role: "alert",
+                                                children: picker.panel.errors.slug
+                                            }) : null
+                                        ]
+                                    })
+                                ]
+                            }),
+                            picker.panel.errors.general ? /*#__PURE__*/ _jsx("p", {
+                                role: "alert",
+                                children: picker.panel.errors.general
+                            }) : null,
+                            /*#__PURE__*/ _jsxs("div", {
+                                className: "xp-goal-field__actions",
+                                children: [
+                                    /*#__PURE__*/ _jsx(Button, {
+                                        type: "button",
+                                        margin: false,
+                                        buttonStyle: "primary",
+                                        disabled: picker.panel.pending || !picker.panel.name.trim(),
+                                        onClick: ()=>void picker.create(),
+                                        children: C.createGoal
+                                    }),
+                                    /*#__PURE__*/ _jsx(Button, {
+                                        type: "button",
+                                        margin: false,
+                                        buttonStyle: "secondary",
+                                        disabled: picker.panel.pending,
+                                        onClick: picker.cancel,
+                                        children: C.cancel
+                                    })
+                                ]
+                            })
+                        ]
+                    }) : null
+                ]
+            }) : null
+        ]
+    });
+}

package/dist/admin/goals/xpGoalField.css

@@ -0,0 +1,48 @@
+.xp-goal-field {
+  display: grid;
+  gap: var(--xp-field-gap);
+}
+
+.xp-goal-field__row {
+  display: flex;
+  flex-wrap: wrap;
+  align-items: end;
+  gap: var(--xp-space-2);
+}
+
+.xp-goal-field__select {
+  flex: 1 1 auto;
+  min-width: 0;
+}
+
+.xp-goal-field__panel {
+  display: grid;
+  gap: var(--xp-field-gap);
+  border: 1px solid var(--xp-border);
+  border-radius: var(--xp-radius-control);
+  padding: var(--xp-space-4);
+}
+
+.xp-goal-field > p,
+.xp-goal-field__panel > h3,
+.xp-goal-field__panel > p {
+  margin: 0;
+}
+
+.xp-goal-field__panel details[open] > summary {
+  margin-bottom: var(--xp-field-gap);
+}
+
+.xp-goal-field__actions {
+  display: flex;
+  flex-wrap: wrap;
+  gap: var(--xp-space-2);
+}
+
+/* Payload halves the gap between fields below 768px; match it inside the field. */
+@media (max-width: 768px) {
+  .xp-goal-field,
+  .xp-goal-field__panel {
+    gap: calc(var(--xp-field-gap) / 2);
+  }
+}

package/dist/admin/metricSource.model.d.ts

@@ -5,3 +5,5 @@ export declare function metricSourceOptions(sources: readonly SerializedMetricSo
     badge: "count" | "yes/no" | "amount";
 }[];
 export declare function metricSourceHint(source?: SerializedMetricSource): string | null;
+/** Click goal definitions share the serialized click-source option. */
+export declare function sourceFor(sourceId: string | undefined, metricSources: readonly SerializedMetricSource[]): SerializedMetricSource | undefined;

package/dist/admin/metricSource.model.js

@@ -9,3 +9,7 @@ export function metricSourceOptions(sources) {
 export function metricSourceHint(source) {
     return source?.kind === 'revenue' ? METRICS_COPY.revenueHint : null;
 }
+/** Click goal definitions share the serialized click-source option. */ export function sourceFor(sourceId, metricSources) {
+    const id = sourceId?.startsWith('click:') ? 'click:' : sourceId;
+    return metricSources.find((source)=>source.id === id);
+}

package/dist/admin/pageCollections.d.ts

@@ -0,0 +1,10 @@
+import type { PayloadRequest } from 'payload';
+import type { ExperimentsPageCollection } from '../types/contracts.js';
+export declare function serializePageCollections(collections: ExperimentsPageCollection[], req: PayloadRequest): {
+    copyUrl: string;
+    copyLabel: string;
+    copyHint?: string | undefined;
+    slug: string;
+    label: string;
+    contentChecks: boolean;
+}[];

package/dist/admin/pageCollections.js

@@ -0,0 +1,20 @@
+import { formatAdminURL } from 'payload/shared';
+import { collectionLabel } from '../collections/labels.js';
+export function serializePageCollections(collections, req) {
+    return collections.map((entry)=>{
+        const label = collectionLabel(req.payload.config.collections.find((collection)=>collection.slug === entry.slug)?.labels.plural, entry.slug, req);
+        return {
+            slug: entry.slug,
+            label,
+            contentChecks: typeof entry.contentOf === 'function',
+            ...entry.copyHint ? {
+                copyHint: entry.copyHint
+            } : {},
+            copyUrl: entry.copyUrl ?? formatAdminURL({
+                adminRoute: req.payload.config.routes.admin,
+                path: `/collections/${entry.slug}`
+            }),
+            copyLabel: entry.copyLabel ?? `Open ${label}`
+        };
+    });
+}

package/dist/admin/paths.d.ts

@@ -8,3 +8,12 @@ export declare const XP_TESTS_NAV_LINK = "@delmaredigital/payload-experiments/ad
 export declare const XP_TESTS_NAV_CLIENT = "@delmaredigital/payload-experiments/admin/client#TestsNavLink";
 export declare const XP_TESTS_SURFACE = "@delmaredigital/payload-experiments/admin/client#TestsSurface";
 export declare const XP_TESTS_DASHBOARD_CARDS = "@delmaredigital/payload-experiments/admin/client#TestsDashboardCards";
+export declare const XP_PLACEMENT_STATUS = "@delmaredigital/payload-experiments/admin/client#PlacementStatus";
+export declare const XP_TEST_BLOCK = "@delmaredigital/payload-experiments/admin/client#TestBlockField";
+export declare const XP_BLOCK_STATUS = "@delmaredigital/payload-experiments/admin/client#BlockStatusField";
+export declare const XP_BLOCK_ROW_LABEL = "@delmaredigital/payload-experiments/admin/client#BlockSlotRowLabel";
+export declare const XP_COPY_ORIGINAL = "@delmaredigital/payload-experiments/admin/client#CopyOriginalField";
+export declare const XP_GOAL_FIELD = "@delmaredigital/payload-experiments/admin/client#XpGoalField";
+export declare const XP_TESTS_COLLECTION_LIST = "@delmaredigital/payload-experiments/admin/rsc#TestsCollectionListView";
+export declare const XP_GOALS_COLLECTION_LIST = "@delmaredigital/payload-experiments/admin/rsc#GoalsCollectionListView";
+export declare const XP_GOAL_EDIT_REDIRECT = "@delmaredigital/payload-experiments/admin/rsc#GoalEditRedirect";

package/dist/admin/paths.js

@@ -8,3 +8,12 @@ export const XP_TESTS_NAV_LINK = '@delmaredigital/payload-experiments/admin/rsc#
 export const XP_TESTS_NAV_CLIENT = '@delmaredigital/payload-experiments/admin/client#TestsNavLink';
 export const XP_TESTS_SURFACE = '@delmaredigital/payload-experiments/admin/client#TestsSurface';
 export const XP_TESTS_DASHBOARD_CARDS = '@delmaredigital/payload-experiments/admin/client#TestsDashboardCards';
+export const XP_PLACEMENT_STATUS = '@delmaredigital/payload-experiments/admin/client#PlacementStatus';
+export const XP_TEST_BLOCK = '@delmaredigital/payload-experiments/admin/client#TestBlockField';
+export const XP_BLOCK_STATUS = '@delmaredigital/payload-experiments/admin/client#BlockStatusField';
+export const XP_BLOCK_ROW_LABEL = '@delmaredigital/payload-experiments/admin/client#BlockSlotRowLabel';
+export const XP_COPY_ORIGINAL = '@delmaredigital/payload-experiments/admin/client#CopyOriginalField';
+export const XP_GOAL_FIELD = '@delmaredigital/payload-experiments/admin/client#XpGoalField';
+export const XP_TESTS_COLLECTION_LIST = '@delmaredigital/payload-experiments/admin/rsc#TestsCollectionListView';
+export const XP_GOALS_COLLECTION_LIST = '@delmaredigital/payload-experiments/admin/rsc#GoalsCollectionListView';
+export const XP_GOAL_EDIT_REDIRECT = '@delmaredigital/payload-experiments/admin/rsc#GoalEditRedirect';

package/dist/admin/placementStatus.model.d.ts

@@ -0,0 +1,2 @@
+import type { PageTestStatus } from '../types/endpoints.js';
+export declare function pageStatusCopy(test: PageTestStatus): string | null;

package/dist/admin/placementStatus.model.js

@@ -0,0 +1,19 @@
+export function pageStatusCopy(test) {
+    if (test.pagesReleased) return null;
+    const winner = `${test.winnerLabel ?? 'the winner'}${test.winnerTitle ? ` (${test.winnerTitle})` : ''}`;
+    switch(test.status){
+        case 'draft':
+            return `This page is ${test.armLabel} in the draft test ${test.name}.`;
+        case 'stopped':
+            {
+                const visitors = test.role === 'original' ? 'Visitors see this page.' : !test.originalPath ? 'Visitors see the Original.' : `Visitors to ${test.originalPath === '/' ? 'the homepage (/)' : test.originalPath} see the Original.`;
+                return `This page is ${test.armLabel} in the stopped test ${test.name}. ${visitors}`;
+            }
+        case 'running':
+            return `This page is the ${test.armLabel} of a running test: ${test.name}.`;
+        case 'decided':
+            return `This page is ${test.armLabel} of a decided test; ${test.rollout ? `most visitors see ${winner}; a holdout still sees the Original` : `visitors see ${winner}`}.`;
+        case 'archived':
+            return test.winner ? `This page is also shown at the other versions' addresses because test ${test.name} made it the winner. To free it, open the test and choose "Release pages".` : test.role === 'original' ? `This page's address now shows the winner of test ${test.name}. To free it, open the test and choose "Release pages".` : `This page's address now shows ${winner}. To show this page again, open the test and choose "Release pages".`;
+    }
+}

package/dist/admin/placements/placementLabels.d.ts

@@ -0,0 +1,11 @@
+import type { DocId } from '../../types/contracts.js';
+import type { PreflightResult } from '../../types/endpoints.js';
+export { placementDetailKey, placementDetail, fallbackPlacementLabel } from './placementLabels.model.js';
+export type { PlacementLabel } from './placementLabels.model.js';
+import type { PlacementLabel } from './placementLabels.model.js';
+export declare function resolvedPlacementLabel(value: unknown, match: {
+    id?: DocId | null;
+    title?: string;
+    editorUrl?: string;
+} | undefined, adminRoute: string): PlacementLabel;
+export declare function preflightPlacementLabel(value: unknown, preflight: PreflightResult, adminRoute: string): PlacementLabel;

package/dist/admin/placements/placementLabels.js

@@ -0,0 +1,21 @@
+import { formatAdminURL } from 'payload/shared';
+import { placementDetail } from './placementLabels.model.js';
+export { placementDetailKey, placementDetail, fallbackPlacementLabel } from './placementLabels.model.js';
+export function resolvedPlacementLabel(value, match, adminRoute) {
+    const detail = placementDetail(value);
+    const id = match?.id ?? detail.id;
+    return {
+        title: match?.title?.trim() || detail.path || 'This page',
+        ...id != null && detail.collection ? {
+            href: match?.editorUrl || formatAdminURL({
+                adminRoute,
+                path: `/collections/${encodeURIComponent(detail.collection)}/${encodeURIComponent(String(id))}`
+            })
+        } : {}
+    };
+}
+export function preflightPlacementLabel(value, preflight, adminRoute) {
+    const detail = placementDetail(value);
+    const match = detail.collection ? detail.id != null ? preflight.placements.find((item)=>item.collection === detail.collection && String(item.id) === String(detail.id)) : typeof detail.path === 'string' ? preflight.pagePlacements?.find((item)=>item.collection === detail.collection && item.path === detail.path) : undefined : undefined;
+    return resolvedPlacementLabel(value, match, adminRoute);
+}

package/dist/admin/placements/placementLabels.model.d.ts

@@ -0,0 +1,13 @@
+import type { DocId } from '../../types/contracts.js';
+export type PlacementDetail = {
+    collection?: string;
+    id?: DocId;
+    path?: string;
+};
+export type PlacementLabel = {
+    title: string;
+    href?: string;
+};
+export declare const placementDetail: (detail: unknown) => PlacementDetail;
+export declare function placementDetailKey(value: unknown): string;
+export declare const fallbackPlacementLabel: (value: unknown) => PlacementLabel;

package/dist/admin/placements/placementLabels.model.js

@@ -0,0 +1,12 @@
+export const placementDetail = (detail)=>detail && typeof detail === 'object' && !Array.isArray(detail) ? detail : {};
+export function placementDetailKey(value) {
+    const detail = placementDetail(value);
+    return JSON.stringify([
+        detail.collection,
+        detail.id == null ? null : String(detail.id),
+        detail.path
+    ]);
+}
+export const fallbackPlacementLabel = (value)=>({
+        title: placementDetail(value).path || 'This page'
+    });

package/dist/admin/placements/usePlacementLabels.d.ts

@@ -0,0 +1,12 @@
+import type { PreflightResult } from '../../types/endpoints.js';
+import type { PlacementLabel } from './placementLabels.js';
+export { placementDetailKey } from './placementLabels.js';
+/** The view owns a cache, including misses, so repeated warnings never repeat reads. */
+export declare function usePlacementLabels({ details, preflight, apiRoute, adminRoute, canManage, collectionTitles }: {
+    details: unknown[];
+    preflight?: PreflightResult | null;
+    apiRoute: string;
+    adminRoute: string;
+    canManage: boolean;
+    collectionTitles?: Record<string, string>;
+}): Map<string, PlacementLabel>;

package/dist/admin/placements/usePlacementLabels.js

@@ -0,0 +1,102 @@
+'use client';
+import { useEffect, useMemo, useRef, useState } from 'react';
+import { createApi } from '../api.js';
+import { placementDetail, placementDetailKey, preflightPlacementLabel, resolvedPlacementLabel } from './placementLabels.js';
+export { placementDetailKey } from './placementLabels.js';
+/** The view owns a cache, including misses, so repeated warnings never repeat reads. */ export function usePlacementLabels({ details, preflight, apiRoute, adminRoute, canManage, collectionTitles }) {
+    const titlesSignature = JSON.stringify(collectionTitles);
+    const cache = useMemo(()=>new Map(), [
+        apiRoute,
+        adminRoute,
+        titlesSignature
+    ]);
+    const mounted = useRef(true);
+    useEffect(()=>{
+        mounted.current = true;
+        return ()=>{
+            mounted.current = false;
+        };
+    }, []);
+    const [, refresh] = useState(0);
+    const signature = JSON.stringify(details.map(placementDetail));
+    useEffect(()=>{
+        if (!canManage || preflight) return;
+        const pending = [
+            ...new Map(JSON.parse(signature).map((detail)=>[
+                    placementDetailKey(detail),
+                    detail
+                ])).values()
+        ].filter((detail)=>!cache.has(placementDetailKey(detail)));
+        const blocks = new Map();
+        const jobs = [];
+        const save = (value, label)=>{
+            cache.set(placementDetailKey(value), label);
+        };
+        for (const value of pending){
+            const detail = placementDetail(value);
+            // Reserve immediately: repeated renders do not issue duplicate requests.
+            save(value, resolvedPlacementLabel(value, undefined, adminRoute));
+            if (!detail.collection) continue;
+            if (detail.id != null) {
+                blocks.set(detail.collection, [
+                    ...blocks.get(detail.collection) ?? [],
+                    value
+                ]);
+                continue;
+            }
+            if (!detail.path) continue;
+            jobs.push(createApi(apiRoute).pages({
+                collection: detail.collection,
+                path: detail.path
+            }).then((result)=>{
+                if (result.ok) save(value, resolvedPlacementLabel(value, result.data?.docs[0], adminRoute));
+            }));
+        }
+        for (const [collection, values] of blocks)jobs.push((async ()=>{
+            try {
+                const ids = [
+                    ...new Set(values.map((value)=>String(placementDetail(value).id)))
+                ];
+                const query = new URLSearchParams({
+                    'where[id][in]': ids.join(','),
+                    depth: '0',
+                    limit: String(ids.length)
+                });
+                const response = await fetch(`${apiRoute.replace(/\/$/, '')}/${encodeURIComponent(collection)}?${query}`, {
+                    credentials: 'include'
+                });
+                if (!response.ok) return;
+                const data = await response.json();
+                const titleField = collectionTitles?.[collection];
+                for (const value of values){
+                    const doc = data.docs?.find((doc)=>String(doc.id) === String(placementDetail(value).id));
+                    if (doc) save(value, resolvedPlacementLabel(value, {
+                        id: placementDetail(value).id,
+                        title: titleField && typeof doc[titleField] === 'string' ? doc[titleField] : undefined
+                    }, adminRoute));
+                }
+            } catch  {}
+        })());
+        void Promise.all(jobs).then(()=>{
+            if (mounted.current && jobs.length) refresh((value)=>value + 1);
+        });
+    }, [
+        signature,
+        preflight,
+        apiRoute,
+        adminRoute,
+        canManage,
+        collectionTitles,
+        cache
+    ]);
+    return new Map(details.map((detail)=>{
+        const label = preflight ? preflightPlacementLabel(detail, preflight, adminRoute) : cache.get(placementDetailKey(detail)) ?? resolvedPlacementLabel(detail, undefined, adminRoute);
+        // Results-only readers may not be able to open the collection, so they get the name without a link.
+        return [
+            placementDetailKey(detail),
+            canManage ? label : {
+                title: label.title
+            }
+        ];
+    }));
+}

package/dist/admin/results/DataQualityPanel.js

@@ -41,7 +41,10 @@ export function DataQualityPanel({ items, problem = false }) {
                             }) : null,
                             /*#__PURE__*/ _jsx("p", {
                                 className: "xp-quality-next",
-                                children: item.nextStep
+                                children: item.href ? /*#__PURE__*/ _jsx("a", {
+                                    href: item.href,
+                                    children: item.nextStep
+                                }) : item.nextStep
                             })
                         ]
                     }, item.id)) : /*#__PURE__*/ _jsx("p", {

package/dist/admin/results/results.model.d.ts

@@ -2,6 +2,7 @@ import type { DocId, Status } from '../../types/contracts.js';
 import type { PhaseSummary, ResultsResponse } from '../../types/endpoints.js';
 import type { Snapshot } from '../../types/snapshot.js';
 import { type DisplaySnapshot } from './snapshot.js';
+import type { PlacementLabel } from '../placements/placementLabels.model.js';
 type Metric = Snapshot['metrics'][number];
 type Arm = Metric['perArm'][number];
 type Decision = {
@@ -88,6 +89,7 @@ interface RoundLineInput {
 }
 export declare function powerLine({ snapshot, phaseKind, status }: RoundLineInput): string | null;
 export interface ResultsContext {
+    placementLabels?: Map<string, PlacementLabel>;
     status?: string;
     phase?: PhaseSummary;
     minExposuresPerArm?: number;
@@ -102,6 +104,7 @@ export interface DataQualityItem {
     message: string;
     detail?: string;
     nextStep: string;
+    href?: string;
     shares?: string[];
 }
 export declare function dataQuality(snapshot: DisplaySnapshot, ctx?: ResultsContext): DataQualityItem[];

package/dist/admin/results/results.model.js

@@ -1,9 +1,10 @@
-import { READINESS_COPY, versionPageUnavailableCopy, versionPageUncheckedCopy } from '../copy/readiness.js';
+import { READINESS_COPY, placementUncheckedCopy, versionPageUnavailableCopy, versionPageUncheckedCopy } from '../copy/readiness.js';
 import { armLabel, phaseKindLabel, verdictCodeLabel } from '../labels.js';
 import { RESULTS_COPY, cappedCount, collectingCopy, conflictCopy, decidedTitle, exclusionCopy, ignoredCopy, metricUnavailable, moreDays, roundLabel, shareCopy, shippingTitle, srmP, uncappedTotal } from '../copy/results.js';
 import { formatCI, formatCount, formatMetric, formatPercent, formatProbability } from './format.js';
 import { legacyMinimum, legacyRolloutLine, legacyTooFew } from './legacy.js';
 import { isLegacySnapshot } from './snapshot.js';
+import { placementDetailKey } from '../placements/placementLabels.model.js';
 export function defaultRound({ phases, decision, status }) {
     if ((status === 'decided' || status === 'archived') && decision) return decision.phase;
     return phases.reduce((latest, phase)=>latest === null || phase.phase > latest ? phase.phase : latest, null);
@@ -132,9 +133,12 @@ function smallest(values) {
 }
 export function dataQuality(snapshot, ctx = {}) {
     const items = (snapshot.health ?? []).map((item)=>({
-            id: `${item.code}:${item.path}`,
-            message: READINESS_COPY.needsAttention,
-            nextStep: item.code === 'version-page-unavailable' ? versionPageUnavailableCopy(item.path, ctx.status) : versionPageUncheckedCopy(item.path, ctx.status)
+            id: item.code === 'placement-unchecked' ? `${item.code}:${JSON.stringify(item.detail)}` : `${item.code}:${'path' in item ? item.path : item.metricId}`,
+            message: item.code === 'placement-unchecked' ? placementUncheckedCopy(ctx.placementLabels?.get(placementDetailKey(item.detail))?.title ?? item.detail.path ?? 'This page') : item.code === 'goal-in-some-versions' ? `${item.name} now appears in some versions but not all, so this result is no longer a fair comparison. Add it to every version, or remove it.` : READINESS_COPY.needsAttention,
+            ...item.code === 'placement-unchecked' ? {
+                href: ctx.placementLabels?.get(placementDetailKey(item.detail))?.href
+            } : {},
+            nextStep: item.code === 'placement-unchecked' ? `Open ${ctx.placementLabels?.get(placementDetailKey(item.detail))?.title ?? item.detail.path ?? 'the page'}` : item.code === 'goal-in-some-versions' ? 'Edit the versions' : item.code === 'version-page-unavailable' ? versionPageUnavailableCopy(item.path, ctx.status) : versionPageUncheckedCopy(item.path, ctx.status)
         }));
     // Test snapshots store null by design; only rollout snapshots record the shipped winner.
     if (!isLegacySnapshot(snapshot) && snapshot.phaseKind === 'rollout' && snapshot.winnerArm === null) items.push({