@deliciousmonster/datadog-agent-binary 7.82.1-next.2 → 7.82.1-next.4

package/README.md

@@ -43,6 +43,7 @@ Configuration is the environment; `datadog.yaml` is rewritten on every start, so
 | `DD_ENV` | The `env` tag on everything sent. |
 | `DD_APM_RECEIVER_PORT` | Where `dd-trace` posts spans. Default 8126. |
 | `DD_EXPVAR_PORT`, `DD_APM_DEBUG_PORT` | The agents' expvar ports, 5000 and 5012. Verification reads them; `0` turns one off and verification refuses. |
+| `DD_LOGS_ENABLED` | `true` ships Harper's own log, `<rootPath>/log/hdb.log`, as service `harper`. Off by default. |
 
 `GET /DatadogStatus/`, under Harper's own auth, reports which supervision is in charge, whether the API key is set, whether each agent verified and why not, and how far a span got: `delivery.verdict` is `delivering`, `rejected`, `traces-unconfirmed` or `idle`. Its counters are the trace-agent's own one-minute window, so read it twice.
 

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@deliciousmonster/datadog-agent-binary",
-	"version": "7.82.1-next.2",
+	"version": "7.82.1-next.4",
 	"description": "Harper component that runs the Datadog trace-agent and core-agent alongside a node, with pre-built binaries installed per platform",
 	"type": "module",
 	"scripts": {
@@ -27,7 +27,7 @@
 		"test:windows": "npm run build && node scripts/windows-gate.mjs",
 		"test:live": "npm run build && node --test \"test/live/**/*.test.js\"",
 		"// test:binaries": "requires real binaries already built at build/<platform>/bin, from a prior `npm run build-agent` or a CI step that already built them; this script itself only runs `npm run build` (tsc), same as test:live for the same real-binaries dependency; excluded from `test` for that reason",
-		"test:binaries": "npm run build && node --test \"test/binaries/**/*.test.js\""
+		"test:binaries": "npm run build && node --test --test-concurrency=1 --test-timeout=120000 \"test/binaries/**/*.test.js\""
 	},
 	"keywords": [
 		"datadog",
@@ -38,7 +38,7 @@
 	"author": "",
 	"license": "Apache-2.0",
 	"dependencies": {
-		"@deliciousmonster/harper-process-guard": "0.1.0-next.2"
+		"@deliciousmonster/harper-process-guard": "0.1.0-next.3"
 	},
 	"devDependencies": {
 		"@types/node": "^26.0.0",
@@ -68,10 +68,10 @@
 	},
 	"homepage": "https://github.com/deliciousmonster/datadog-agent-binary#readme",
 	"optionalDependencies": {
-		"@deliciousmonster/datadog-agent-binary-linux-x86_64": "7.82.1-next.2",
-		"@deliciousmonster/datadog-agent-binary-linux-arm64": "7.82.1-next.2",
-		"@deliciousmonster/datadog-agent-binary-macos-arm64": "7.82.1-next.2",
-		"@deliciousmonster/datadog-agent-binary-windows-x86_64": "7.82.1-next.2"
+		"@deliciousmonster/datadog-agent-binary-linux-x86_64": "7.82.1-next.4",
+		"@deliciousmonster/datadog-agent-binary-linux-arm64": "7.82.1-next.4",
+		"@deliciousmonster/datadog-agent-binary-macos-arm64": "7.82.1-next.4",
+		"@deliciousmonster/datadog-agent-binary-windows-x86_64": "7.82.1-next.4"
 	},
 	"lint-staged": {
 		"*.{ts,js,json}": [

package/runtime/config.js

@@ -92,6 +92,22 @@ function renderDatadogYaml(paths, ports) {
 	].join("\n");
 }
 
+const HARPER_LOG_CHECK = "harper.d";
+
+/** A logs source for Harper's own log file: `logging.root` is `log` under the root path unless a node moved it. */
+function renderHarperLogSource(logFile) {
+	return [
+		"# GENERATED by resources.js on every Harper worker start. Edits are overwritten.",
+		"# Tailed only while logs are enabled (DD_LOGS_ENABLED=true).",
+		"logs:",
+		"  - type: file",
+		`    path: ${yamlString(logFile)}`,
+		"    service: harper",
+		"    source: harper",
+		"",
+	].join("\n");
+}
+
 /** The shipped core checks that apply here; an optional `platforms` file beside a check gates it, absent means everywhere. */
 function collectCoreChecks(packageConfd) {
 	const checks = [];
@@ -162,7 +178,15 @@ export function prepareRuntime(componentDir, { ports, log }) {
 			configFiles[join(paths.confd, check.dir, "conf.yaml.default")] =
 				check.body;
 		}
-		removeStaleDefaults(paths.confd, new Set(checks.map((check) => check.dir)));
+		const owned = new Set(checks.map((check) => check.dir));
+		// Harper's own log as a log source, written whenever the root is known. The agent tails it only
+		// when logs are on, which is DD_LOGS_ENABLED=true in the environment; off, this file costs nothing.
+		if (root) {
+			configFiles[join(paths.confd, HARPER_LOG_CHECK, "conf.yaml.default")] =
+				renderHarperLogSource(join(root, "log", "hdb.log"));
+			owned.add(HARPER_LOG_CHECK);
+		}
+		removeStaleDefaults(paths.confd, owned);
 	} catch (error) {
 		log.warn(
 			`Datadog supervisor: no core check configuration was collected (${error.message}), so the agent ` +

package/runtime/supervisor.js

@@ -1,11 +1,17 @@
 // Who holds the agents up. Released Harper has no sidecar API, so the bundled guard is the other half; one
 // agent per node comes from a PID lock either way and only the holder changes.
 
+import { readFileSync, unlinkSync } from "node:fs";
 import { join } from "node:path";
 
 // Pinned to one exact version, never a range: Harper runs `npm install` when it installs a component, so a
 // caret here would let a customer's node resolve a guard no test in this repo has run against.
-import { fingerprint, guard } from "@deliciousmonster/harper-process-guard";
+import {
+	argvOf,
+	fingerprint,
+	guard,
+	identify as identifyPid,
+} from "@deliciousmonster/harper-process-guard";
 import { describeSpawnFailure } from "./agent-exit.js";
 import { writeConfigFiles } from "./config.js";
 
@@ -99,12 +105,66 @@ const harperSupervisor = (scope, log) => ({
 // directory would collide on; this one names the package rather than taking the guard's generic default.
 const REAPER_NAME = "datadog-agent-reaper";
 
+/**
+ * Harper's own spawn keeps a pid file per process name under <root>/pids and, when the file names a pid
+ * that answers kill(pid, 0), returns that pid instead of spawning. After a restart the kernel reissues
+ * pids, and a thread of Harper itself answers for one, so the file has to go before the guard asks.
+ * Removing it signals nothing. A file naming the real process, or a dead one, is Harper's to keep.
+ *
+ * @param {string | null} root @param {Array<{ name: string; argv?: readonly string[]; script?: string }>} named
+ * @param {import("./log.js").Log} log
+ */
+export function clearStaleHarperPidFiles(root, named, log) {
+	if (!root) return;
+	for (const { name, argv, script } of named) {
+		const file = join(root, "pids", `${name}.pid`);
+		let pid;
+		try {
+			pid = Number.parseInt(readFileSync(file, "utf-8"), 10);
+		} catch {
+			continue;
+		}
+		if (!Number.isInteger(pid) || pid <= 0) continue;
+		const running = argvOf(pid);
+		if (running === null) continue;
+		const ours = argv
+			? identifyPid(pid, argv) === "match"
+			: running.some((argument) => argument.endsWith(script ?? "\u0000"));
+		if (ours) continue;
+		try {
+			unlinkSync(file);
+			log.warn(
+				`Datadog supervisor: removed ${file}, Harper's own pid file for ${name}: it named pid ${pid}, which ` +
+					`is running \`${running.join(" ")}\`, and Harper would have handed that pid back as the ${name} ` +
+					`instead of starting one.`
+			);
+		} catch (error) {
+			log.error(
+				`Datadog supervisor: could not remove ${file}, which names pid ${pid} running something else: ` +
+					`${error.message}. Harper will hand that pid back as the ${name} rather than start one.`
+			);
+		}
+	}
+}
+
 /** The bundled guard, one call for both agents. `spawn` is the entry module's own, which is the one Harper constrains. */
 const guardSupervisor = (log, spawn) => ({
 	kind: "guard",
 	async start(agents, { runtime, configFiles, fingerprintParts }) {
 		// Harper's start() writes these itself; on this path nothing else will, and both agents read them.
 		writeConfigFiles(configFiles, log);
+		clearStaleHarperPidFiles(
+			runtime.root,
+			[
+				...agents.map((agent) => ({
+					name: agent.name,
+					argv: [agent.command, ...agent.args],
+				})),
+				// The guard builds the reaper's own argv; its script name is the one stable thing to match on.
+				{ name: REAPER_NAME, script: "/reaper.js" },
+			],
+			log
+		);
 		let result;
 		try {
 			result = await guard({