@delegance/claude-autopilot 2.5.0 → 5.0.0-alpha.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +40 -0
- package/README.md +164 -106
- package/bin/_launcher.js +77 -0
- package/bin/claude-autopilot.js +3 -0
- package/bin/guardrail.js +3 -0
- package/package.json +15 -9
- package/presets/generic/guardrail.config.yaml +35 -0
- package/presets/generic/stack.md +40 -0
- package/presets/nextjs-supabase/{autopilot.config.yaml → guardrail.config.yaml} +7 -0
- package/scripts/autoregress.ts +27 -11
- package/skills/autopilot/SKILL.md +170 -0
- package/skills/claude-autopilot.md +80 -0
- package/skills/guardrail.md +39 -0
- package/skills/migrate/SKILL.md +83 -0
- package/src/adapters/council/claude.ts +41 -0
- package/src/adapters/council/openai.ts +40 -0
- package/src/adapters/council/types.ts +7 -0
- package/src/adapters/loader.ts +7 -7
- package/src/adapters/review-engine/auto.ts +2 -2
- package/src/adapters/review-engine/claude.ts +9 -11
- package/src/adapters/review-engine/codex.ts +9 -11
- package/src/adapters/review-engine/gemini.ts +9 -11
- package/src/adapters/review-engine/openai-compatible.ts +10 -12
- package/src/adapters/review-engine/parse-output.ts +32 -6
- package/src/adapters/review-engine/prompt-builder.ts +19 -0
- package/src/adapters/review-engine/types.ts +1 -1
- package/src/adapters/vcs-host/commit-status.ts +39 -0
- package/src/adapters/vcs-host/github.ts +2 -2
- package/src/cli/baseline.ts +125 -0
- package/src/cli/ci.ts +11 -8
- package/src/cli/costs.ts +2 -2
- package/src/cli/council.ts +96 -0
- package/src/cli/detector.ts +21 -5
- package/src/cli/explain.ts +197 -0
- package/src/cli/fix.ts +173 -111
- package/src/cli/hook.ts +72 -27
- package/src/cli/ignore-helper.ts +116 -0
- package/src/cli/index.ts +272 -31
- package/src/cli/init.ts +12 -12
- package/src/cli/lsp.ts +200 -0
- package/src/cli/mcp.ts +206 -0
- package/src/cli/pr-comment.ts +5 -5
- package/src/cli/pr-desc.ts +168 -0
- package/src/cli/pr-review-comments.ts +3 -3
- package/src/cli/pr.ts +76 -0
- package/src/cli/preflight.ts +15 -32
- package/src/cli/report.ts +186 -0
- package/src/cli/run.ts +140 -36
- package/src/cli/scan.ts +233 -0
- package/src/cli/setup.ts +121 -15
- package/src/cli/test-gen.ts +125 -0
- package/src/cli/triage.ts +137 -0
- package/src/cli/watch.ts +52 -31
- package/src/cli/worker.ts +109 -0
- package/src/core/cache/review-cache.ts +2 -2
- package/src/core/chunking/index.ts +2 -2
- package/src/core/config/loader.ts +10 -10
- package/src/core/config/preset-resolver.ts +6 -6
- package/src/core/config/schema.ts +103 -2
- package/src/core/config/types.ts +57 -2
- package/src/core/council/config.ts +71 -0
- package/src/core/council/context.ts +17 -0
- package/src/core/council/runner.ts +83 -0
- package/src/core/council/types.ts +45 -0
- package/src/core/detect/llm-key.ts +89 -0
- package/src/core/detect/workspaces.ts +103 -0
- package/src/core/errors.ts +4 -4
- package/src/core/fix/generator.ts +149 -0
- package/src/core/ignore/index.ts +4 -4
- package/src/core/mcp/concurrency.ts +16 -0
- package/src/core/mcp/handlers/fix-finding.ts +126 -0
- package/src/core/mcp/handlers/get-capabilities.ts +62 -0
- package/src/core/mcp/handlers/get-findings.ts +36 -0
- package/src/core/mcp/handlers/review-diff.ts +65 -0
- package/src/core/mcp/handlers/scan-files.ts +65 -0
- package/src/core/mcp/handlers/validate-fix.ts +41 -0
- package/src/core/mcp/run-store.ts +85 -0
- package/src/core/mcp/workspace.ts +35 -0
- package/src/core/persist/baseline.ts +112 -0
- package/src/core/persist/cost-log.ts +1 -1
- package/src/core/persist/findings-cache.ts +1 -1
- package/src/core/persist/triage.ts +112 -0
- package/src/core/phases/static-rules.ts +18 -5
- package/src/core/pipeline/review-phase.ts +65 -26
- package/src/core/pipeline/run.ts +42 -10
- package/src/core/runtime/lock.ts +2 -2
- package/src/core/runtime/state.ts +2 -2
- package/src/core/schema-alignment/detector.ts +59 -0
- package/src/core/schema-alignment/extractor/index.ts +24 -0
- package/src/core/schema-alignment/extractor/prisma.ts +21 -0
- package/src/core/schema-alignment/extractor/sql.ts +99 -0
- package/src/core/schema-alignment/llm-check.ts +91 -0
- package/src/core/schema-alignment/scanner.ts +107 -0
- package/src/core/schema-alignment/types.ts +43 -0
- package/src/core/shell.ts +3 -3
- package/src/core/static-rules/registry.ts +17 -8
- package/src/core/static-rules/rules/brand-tokens.ts +145 -0
- package/src/core/static-rules/rules/hardcoded-secrets.ts +27 -1
- package/src/core/static-rules/rules/insecure-redirect.ts +67 -0
- package/src/core/static-rules/rules/missing-auth.ts +70 -0
- package/src/core/static-rules/rules/schema-alignment.ts +132 -0
- package/src/core/static-rules/rules/sql-injection.ts +71 -0
- package/src/core/static-rules/rules/ssrf.ts +63 -0
- package/src/core/static-rules/tailwind-extractor.ts +38 -0
- package/src/core/test-gen/coverage-analyzer.ts +93 -0
- package/src/core/test-gen/framework-detector.ts +21 -0
- package/src/core/test-gen/test-writer.ts +33 -0
- package/src/core/ui/design-context-loader.ts +87 -0
- package/src/core/worker/client.ts +46 -0
- package/src/core/worker/lockfile.ts +38 -0
- package/src/core/worker/server.ts +81 -0
- package/src/formatters/junit.ts +52 -0
- package/src/formatters/sarif.ts +2 -2
- package/src/index.ts +1 -2
- package/tests/snapshots/baselines/src-formatters-sarif.json +4 -4
- package/tests/snapshots/index.json +3 -3
- package/tests/snapshots/src-formatters-sarif.snap.ts +1 -1
- package/tests/snapshots/src-snapshots-impact-selector.snap.ts +3 -3
- package/tests/snapshots/src-snapshots-import-scanner.snap.ts +3 -3
- package/tests/snapshots/src-snapshots-serializer.snap.ts +2 -2
- package/bin/autopilot.js +0 -20
- package/skills/autopilot.md +0 -157
- /package/presets/go/{autopilot.config.yaml → guardrail.config.yaml} +0 -0
- /package/presets/python-fastapi/{autopilot.config.yaml → guardrail.config.yaml} +0 -0
- /package/presets/rails-postgres/{autopilot.config.yaml → guardrail.config.yaml} +0 -0
- /package/presets/t3/{autopilot.config.yaml → guardrail.config.yaml} +0 -0
- /package/{src → scripts}/snapshots/impact-selector.ts +0 -0
- /package/{src → scripts}/snapshots/import-scanner.ts +0 -0
- /package/{src → scripts}/snapshots/serializer.ts +0 -0
package/src/core/ignore/index.ts
CHANGED
|
@@ -2,7 +2,7 @@ import * as fs from 'node:fs';
|
|
|
2
2
|
import * as path from 'node:path';
|
|
3
3
|
import { minimatch } from 'minimatch';
|
|
4
4
|
import type { Finding } from '../findings/types.ts';
|
|
5
|
-
import type {
|
|
5
|
+
import type { GuardrailConfig } from '../config/types.ts';
|
|
6
6
|
|
|
7
7
|
export interface IgnoreRule {
|
|
8
8
|
ruleId: string | '*'; // finding id prefix or '*' for any
|
|
@@ -10,7 +10,7 @@ export interface IgnoreRule {
|
|
|
10
10
|
}
|
|
11
11
|
|
|
12
12
|
export function loadIgnoreRules(cwd: string): IgnoreRule[] {
|
|
13
|
-
const filePath = path.join(cwd, '.
|
|
13
|
+
const filePath = path.join(cwd, '.guardrail-ignore');
|
|
14
14
|
if (!fs.existsSync(filePath)) return [];
|
|
15
15
|
|
|
16
16
|
const rules: IgnoreRule[] = [];
|
|
@@ -37,8 +37,8 @@ function matchesRule(finding: Finding, rule: IgnoreRule): boolean {
|
|
|
37
37
|
return minimatch(finding.file.replace(/\\/g, '/'), rule.pathGlob, { matchBase: true });
|
|
38
38
|
}
|
|
39
39
|
|
|
40
|
-
/** Convert `ignore:` entries from
|
|
41
|
-
export function parseConfigIgnore(entries:
|
|
40
|
+
/** Convert `ignore:` entries from guardrail.config.yaml into IgnoreRules. */
|
|
41
|
+
export function parseConfigIgnore(entries: GuardrailConfig['ignore']): IgnoreRule[] {
|
|
42
42
|
if (!entries || entries.length === 0) return [];
|
|
43
43
|
return entries.map(entry => {
|
|
44
44
|
if (typeof entry === 'string') {
|
|
@@ -0,0 +1,16 @@
|
|
|
1
|
+
const mutexes = new Map<string, Promise<void>>();
|
|
2
|
+
|
|
3
|
+
export async function withWriteLock<T>(workspace: string, fn: () => Promise<T>): Promise<T> {
|
|
4
|
+
let unlock!: () => void;
|
|
5
|
+
const current = new Promise<void>(resolve => { unlock = resolve; });
|
|
6
|
+
const prev = mutexes.get(workspace) ?? Promise.resolve();
|
|
7
|
+
mutexes.set(workspace, current);
|
|
8
|
+
|
|
9
|
+
await prev;
|
|
10
|
+
try {
|
|
11
|
+
return await fn();
|
|
12
|
+
} finally {
|
|
13
|
+
unlock();
|
|
14
|
+
if (mutexes.get(workspace) === current) mutexes.delete(workspace);
|
|
15
|
+
}
|
|
16
|
+
}
|
|
@@ -0,0 +1,126 @@
|
|
|
1
|
+
// src/core/mcp/handlers/fix-finding.ts
|
|
2
|
+
import * as fs from 'node:fs';
|
|
3
|
+
import * as path from 'node:path';
|
|
4
|
+
import { resolveWorkspace, assertInWorkspace } from '../workspace.ts';
|
|
5
|
+
import { loadRun, checksumFile } from '../run-store.ts';
|
|
6
|
+
import { withWriteLock } from '../concurrency.ts';
|
|
7
|
+
import { generateFix, buildUnifiedDiff } from '../../fix/generator.ts';
|
|
8
|
+
import type { ReviewEngine } from '../../../adapters/review-engine/types.ts';
|
|
9
|
+
import type { GuardrailConfig } from '../../config/types.ts';
|
|
10
|
+
|
|
11
|
+
export interface FixFindingResult {
|
|
12
|
+
schema_version: 1;
|
|
13
|
+
status: 'fixed' | 'reverted' | 'human_required' | 'skipped';
|
|
14
|
+
reason?: string;
|
|
15
|
+
patch?: string;
|
|
16
|
+
commitSha?: string;
|
|
17
|
+
appliedFiles: string[];
|
|
18
|
+
}
|
|
19
|
+
|
|
20
|
+
export async function handleFixFinding(
|
|
21
|
+
input: { run_id: string; finding_id: string; cwd?: string; dry_run?: boolean },
|
|
22
|
+
config: GuardrailConfig,
|
|
23
|
+
engine: ReviewEngine,
|
|
24
|
+
): Promise<FixFindingResult> {
|
|
25
|
+
const workspace = resolveWorkspace(input.cwd);
|
|
26
|
+
|
|
27
|
+
const record = loadRun(workspace, input.run_id);
|
|
28
|
+
if (!record) {
|
|
29
|
+
throw Object.assign(
|
|
30
|
+
new Error(`run_not_found: no run with id "${input.run_id}"`),
|
|
31
|
+
{ code: 'run_not_found' },
|
|
32
|
+
);
|
|
33
|
+
}
|
|
34
|
+
|
|
35
|
+
const finding = record.findings.find(f => f.id === input.finding_id);
|
|
36
|
+
if (!finding) {
|
|
37
|
+
throw Object.assign(
|
|
38
|
+
new Error(`finding_not_found: no finding with id "${input.finding_id}"`),
|
|
39
|
+
{ code: 'finding_not_found' },
|
|
40
|
+
);
|
|
41
|
+
}
|
|
42
|
+
|
|
43
|
+
// Protected path check
|
|
44
|
+
if (finding.protectedPath) {
|
|
45
|
+
return { schema_version: 1, status: 'human_required', reason: 'protected_path', appliedFiles: [] };
|
|
46
|
+
}
|
|
47
|
+
|
|
48
|
+
// Validate finding.file against workspace boundary (run records could be tampered)
|
|
49
|
+
const absFile = assertInWorkspace(workspace, finding.file);
|
|
50
|
+
|
|
51
|
+
// Look up checksum under both the raw finding.file and its relative form,
|
|
52
|
+
// so the drift check works whether older runs stored absolute or relative keys.
|
|
53
|
+
const relKey = path.relative(workspace, absFile);
|
|
54
|
+
const savedChecksum = record.fileChecksums[finding.file] ?? record.fileChecksums[relKey] ?? '';
|
|
55
|
+
|
|
56
|
+
// Dry-run path: generate fix, return patch, no mutations
|
|
57
|
+
if (input.dry_run) {
|
|
58
|
+
const currentChecksum = checksumFile(absFile);
|
|
59
|
+
if (savedChecksum && currentChecksum !== savedChecksum) {
|
|
60
|
+
return { schema_version: 1, status: 'human_required', reason: 'file_changed', appliedFiles: [] };
|
|
61
|
+
}
|
|
62
|
+
const genResult = await generateFix(finding, engine, workspace);
|
|
63
|
+
if (genResult.status !== 'ok') {
|
|
64
|
+
return { schema_version: 1, status: 'human_required', reason: genResult.reason, appliedFiles: [] };
|
|
65
|
+
}
|
|
66
|
+
const patch = buildUnifiedDiff(
|
|
67
|
+
genResult.originalLines!,
|
|
68
|
+
genResult.replacementLines!,
|
|
69
|
+
finding.file,
|
|
70
|
+
genResult.startLine!,
|
|
71
|
+
{ color: false }, // MCP clients parse patch text — no ANSI
|
|
72
|
+
);
|
|
73
|
+
return { schema_version: 1, status: 'skipped', reason: 'dry_run', patch, appliedFiles: [] };
|
|
74
|
+
}
|
|
75
|
+
|
|
76
|
+
// Apply path: checksum validation + fix generation run INSIDE the lock to
|
|
77
|
+
// prevent TOCTOU between two concurrent fix_finding calls on the same file.
|
|
78
|
+
return withWriteLock(workspace, async () => {
|
|
79
|
+
const currentChecksum = checksumFile(absFile);
|
|
80
|
+
if (savedChecksum && currentChecksum !== savedChecksum) {
|
|
81
|
+
return { schema_version: 1 as const, status: 'human_required' as const, reason: 'file_changed', appliedFiles: [] };
|
|
82
|
+
}
|
|
83
|
+
|
|
84
|
+
const genResult = await generateFix(finding, engine, workspace);
|
|
85
|
+
if (genResult.status !== 'ok') {
|
|
86
|
+
return { schema_version: 1 as const, status: 'human_required' as const, reason: genResult.reason, appliedFiles: [] };
|
|
87
|
+
}
|
|
88
|
+
|
|
89
|
+
const patch = buildUnifiedDiff(
|
|
90
|
+
genResult.originalLines!,
|
|
91
|
+
genResult.replacementLines!,
|
|
92
|
+
finding.file,
|
|
93
|
+
genResult.startLine!,
|
|
94
|
+
{ color: false },
|
|
95
|
+
);
|
|
96
|
+
|
|
97
|
+
const originalContent = fs.readFileSync(absFile, 'utf8');
|
|
98
|
+
const allLines = originalContent.split('\n');
|
|
99
|
+
const newLines = [
|
|
100
|
+
...allLines.slice(0, genResult.startLine! - 1),
|
|
101
|
+
...genResult.replacementLines!,
|
|
102
|
+
...allLines.slice(genResult.endLine!),
|
|
103
|
+
];
|
|
104
|
+
|
|
105
|
+
const tmpFile = absFile + '.guardrail.tmp';
|
|
106
|
+
fs.writeFileSync(tmpFile, newLines.join('\n'), 'utf8');
|
|
107
|
+
fs.renameSync(tmpFile, absFile);
|
|
108
|
+
|
|
109
|
+
// Test verification
|
|
110
|
+
if (config.testCommand) {
|
|
111
|
+
const { spawnSync } = await import('node:child_process');
|
|
112
|
+
const testResult = spawnSync('/bin/sh', ['-c', config.testCommand], {
|
|
113
|
+
cwd: workspace,
|
|
114
|
+
shell: false,
|
|
115
|
+
timeout: 120_000,
|
|
116
|
+
encoding: 'utf8',
|
|
117
|
+
});
|
|
118
|
+
if (testResult.status !== 0) {
|
|
119
|
+
fs.writeFileSync(absFile, originalContent, 'utf8');
|
|
120
|
+
return { schema_version: 1 as const, status: 'reverted' as const, patch, appliedFiles: [] };
|
|
121
|
+
}
|
|
122
|
+
}
|
|
123
|
+
|
|
124
|
+
return { schema_version: 1 as const, status: 'fixed' as const, patch, appliedFiles: [finding.file] };
|
|
125
|
+
});
|
|
126
|
+
}
|
|
@@ -0,0 +1,62 @@
|
|
|
1
|
+
import * as fs from 'node:fs';
|
|
2
|
+
import * as path from 'node:path';
|
|
3
|
+
import * as child_process from 'node:child_process';
|
|
4
|
+
import { fileURLToPath } from 'node:url';
|
|
5
|
+
import { resolveWorkspace } from '../workspace.ts';
|
|
6
|
+
import type { GuardrailConfig, StaticRuleReference } from '../../config/types.ts';
|
|
7
|
+
|
|
8
|
+
export interface CapabilitiesResult {
|
|
9
|
+
schema_version: 1;
|
|
10
|
+
adapter: string;
|
|
11
|
+
enabledRules: string[];
|
|
12
|
+
writeable: boolean;
|
|
13
|
+
gitAvailable: boolean;
|
|
14
|
+
testCommandConfigured: boolean;
|
|
15
|
+
guardrailVersion: string;
|
|
16
|
+
}
|
|
17
|
+
|
|
18
|
+
function readVersion(): string {
|
|
19
|
+
try {
|
|
20
|
+
const pkgPath = path.join(path.dirname(fileURLToPath(import.meta.url)), '../../../../package.json');
|
|
21
|
+
return (JSON.parse(fs.readFileSync(pkgPath, 'utf8')) as { version: string }).version;
|
|
22
|
+
} catch {
|
|
23
|
+
return 'unknown';
|
|
24
|
+
}
|
|
25
|
+
}
|
|
26
|
+
|
|
27
|
+
function isGitAvailable(workspace: string): boolean {
|
|
28
|
+
try {
|
|
29
|
+
// Safe: no user input, static arguments only
|
|
30
|
+
child_process.execFileSync('git', ['rev-parse', '--git-dir'], {
|
|
31
|
+
cwd: workspace,
|
|
32
|
+
stdio: 'ignore',
|
|
33
|
+
});
|
|
34
|
+
return true;
|
|
35
|
+
} catch {
|
|
36
|
+
return false;
|
|
37
|
+
}
|
|
38
|
+
}
|
|
39
|
+
|
|
40
|
+
function extractRuleName(rule: StaticRuleReference): string {
|
|
41
|
+
return typeof rule === 'string' ? rule : rule.adapter;
|
|
42
|
+
}
|
|
43
|
+
|
|
44
|
+
export async function handleGetCapabilities(
|
|
45
|
+
input: { cwd?: string },
|
|
46
|
+
config: GuardrailConfig,
|
|
47
|
+
adapterName: string,
|
|
48
|
+
): Promise<CapabilitiesResult> {
|
|
49
|
+
const workspace = resolveWorkspace(input.cwd);
|
|
50
|
+
const staticRules = config.staticRules ?? [];
|
|
51
|
+
const enabledRules = staticRules.map(extractRuleName);
|
|
52
|
+
|
|
53
|
+
return {
|
|
54
|
+
schema_version: 1,
|
|
55
|
+
adapter: adapterName,
|
|
56
|
+
enabledRules,
|
|
57
|
+
writeable: true,
|
|
58
|
+
gitAvailable: isGitAvailable(workspace),
|
|
59
|
+
testCommandConfigured: !!config.testCommand,
|
|
60
|
+
guardrailVersion: readVersion(),
|
|
61
|
+
};
|
|
62
|
+
}
|
|
@@ -0,0 +1,36 @@
|
|
|
1
|
+
import { resolveWorkspace } from '../workspace.ts';
|
|
2
|
+
import { loadRun } from '../run-store.ts';
|
|
3
|
+
import type { Finding, Severity } from '../../findings/types.ts';
|
|
4
|
+
|
|
5
|
+
export interface GetFindingsResult {
|
|
6
|
+
schema_version: 1;
|
|
7
|
+
run_id: string;
|
|
8
|
+
findings: Finding[];
|
|
9
|
+
cachedAt: string;
|
|
10
|
+
}
|
|
11
|
+
|
|
12
|
+
// Severity order: index 0 = highest priority
|
|
13
|
+
const SEVERITY_ORDER = ['critical', 'warning', 'note'] as const;
|
|
14
|
+
|
|
15
|
+
export async function handleGetFindings(input: {
|
|
16
|
+
run_id: string;
|
|
17
|
+
severity?: Severity;
|
|
18
|
+
cwd?: string;
|
|
19
|
+
}): Promise<GetFindingsResult> {
|
|
20
|
+
const workspace = resolveWorkspace(input.cwd);
|
|
21
|
+
const record = loadRun(workspace, input.run_id);
|
|
22
|
+
if (!record) {
|
|
23
|
+
throw Object.assign(
|
|
24
|
+
new Error(`run_not_found: no run with id "${input.run_id}"`),
|
|
25
|
+
{ code: 'run_not_found' }
|
|
26
|
+
);
|
|
27
|
+
}
|
|
28
|
+
|
|
29
|
+
let findings = record.findings;
|
|
30
|
+
if (input.severity) {
|
|
31
|
+
const minIdx = SEVERITY_ORDER.indexOf(input.severity);
|
|
32
|
+
findings = findings.filter(f => SEVERITY_ORDER.indexOf(f.severity) <= minIdx);
|
|
33
|
+
}
|
|
34
|
+
|
|
35
|
+
return { schema_version: 1, run_id: input.run_id, findings, cachedAt: record.createdAt };
|
|
36
|
+
}
|
|
@@ -0,0 +1,65 @@
|
|
|
1
|
+
import * as crypto from 'node:crypto';
|
|
2
|
+
import * as path from 'node:path';
|
|
3
|
+
import { resolveWorkspace } from '../workspace.ts';
|
|
4
|
+
import { saveRun, checksumFile, pruneOldRuns } from '../run-store.ts';
|
|
5
|
+
import { runGuardrail } from '../../pipeline/run.ts';
|
|
6
|
+
import { resolveGitTouchedFiles } from '../../git/touched-files.ts';
|
|
7
|
+
import { loadRulesFromConfig } from '../../static-rules/registry.ts';
|
|
8
|
+
import { detectGitContext } from '../../detect/git-context.ts';
|
|
9
|
+
import type { ReviewEngine } from '../../../adapters/review-engine/types.ts';
|
|
10
|
+
import type { GuardrailConfig } from '../../config/types.ts';
|
|
11
|
+
import type { Finding } from '../../findings/types.ts';
|
|
12
|
+
|
|
13
|
+
export interface ReviewDiffResult {
|
|
14
|
+
schema_version: 1;
|
|
15
|
+
run_id: string;
|
|
16
|
+
findings: Finding[];
|
|
17
|
+
human_summary: string;
|
|
18
|
+
usage?: { costUSD?: number };
|
|
19
|
+
}
|
|
20
|
+
|
|
21
|
+
export async function handleReviewDiff(
|
|
22
|
+
input: { base?: string; cwd?: string; static_only?: boolean },
|
|
23
|
+
config: GuardrailConfig,
|
|
24
|
+
engine: ReviewEngine,
|
|
25
|
+
): Promise<ReviewDiffResult> {
|
|
26
|
+
const workspace = resolveWorkspace(input.cwd);
|
|
27
|
+
pruneOldRuns(workspace, 24 * 60 * 60 * 1000);
|
|
28
|
+
|
|
29
|
+
const touchedFiles = resolveGitTouchedFiles({ cwd: workspace, base: input.base });
|
|
30
|
+
const staticRules = config.staticRules ? await loadRulesFromConfig(config.staticRules) : [];
|
|
31
|
+
const gitCtx = detectGitContext(workspace);
|
|
32
|
+
|
|
33
|
+
const result = await runGuardrail({
|
|
34
|
+
touchedFiles,
|
|
35
|
+
config,
|
|
36
|
+
reviewEngine: engine,
|
|
37
|
+
staticRules,
|
|
38
|
+
cwd: workspace,
|
|
39
|
+
gitSummary: gitCtx.summary ?? undefined,
|
|
40
|
+
base: input.base,
|
|
41
|
+
skipReview: input.static_only ?? false,
|
|
42
|
+
});
|
|
43
|
+
|
|
44
|
+
const run_id = crypto.randomUUID();
|
|
45
|
+
const fileChecksums: Record<string, string> = {};
|
|
46
|
+
for (const f of touchedFiles) {
|
|
47
|
+
const abs = path.isAbsolute(f) ? f : path.resolve(workspace, f);
|
|
48
|
+
fileChecksums[f] = checksumFile(abs);
|
|
49
|
+
}
|
|
50
|
+
saveRun(workspace, run_id, result.allFindings, fileChecksums);
|
|
51
|
+
|
|
52
|
+
const critCount = result.allFindings.filter(f => f.severity === 'critical').length;
|
|
53
|
+
const warnCount = result.allFindings.filter(f => f.severity === 'warning').length;
|
|
54
|
+
const human_summary = result.allFindings.length === 0
|
|
55
|
+
? 'No findings — looks clean.'
|
|
56
|
+
: `${result.allFindings.length} finding${result.allFindings.length !== 1 ? 's' : ''}: ${critCount} critical, ${warnCount} warning.`;
|
|
57
|
+
|
|
58
|
+
return {
|
|
59
|
+
schema_version: 1,
|
|
60
|
+
run_id,
|
|
61
|
+
findings: result.allFindings,
|
|
62
|
+
human_summary,
|
|
63
|
+
usage: result.totalCostUSD !== undefined ? { costUSD: result.totalCostUSD } : undefined,
|
|
64
|
+
};
|
|
65
|
+
}
|
|
@@ -0,0 +1,65 @@
|
|
|
1
|
+
import * as crypto from 'node:crypto';
|
|
2
|
+
import * as path from 'node:path';
|
|
3
|
+
import { resolveWorkspace, assertInWorkspace } from '../workspace.ts';
|
|
4
|
+
import { saveRun, checksumFile, pruneOldRuns } from '../run-store.ts';
|
|
5
|
+
import { runReviewPhase } from '../../pipeline/review-phase.ts';
|
|
6
|
+
import { detectStack } from '../../detect/stack.ts';
|
|
7
|
+
import type { ReviewEngine } from '../../../adapters/review-engine/types.ts';
|
|
8
|
+
import type { GuardrailConfig } from '../../config/types.ts';
|
|
9
|
+
import type { Finding } from '../../findings/types.ts';
|
|
10
|
+
|
|
11
|
+
export interface ScanFilesResult {
|
|
12
|
+
schema_version: 1;
|
|
13
|
+
run_id: string;
|
|
14
|
+
findings: Finding[];
|
|
15
|
+
human_summary: string;
|
|
16
|
+
}
|
|
17
|
+
|
|
18
|
+
export async function handleScanFiles(
|
|
19
|
+
input: { files: string[]; cwd?: string; ask?: string },
|
|
20
|
+
config: GuardrailConfig,
|
|
21
|
+
engine: ReviewEngine,
|
|
22
|
+
): Promise<ScanFilesResult> {
|
|
23
|
+
const workspace = resolveWorkspace(input.cwd);
|
|
24
|
+
pruneOldRuns(workspace, 24 * 60 * 60 * 1000);
|
|
25
|
+
|
|
26
|
+
// Validate all paths before any I/O
|
|
27
|
+
const resolvedFiles = input.files.map(f => assertInWorkspace(workspace, f));
|
|
28
|
+
|
|
29
|
+
const stack = detectStack(workspace) ?? config.stack;
|
|
30
|
+
const effectiveConfig: GuardrailConfig = input.ask
|
|
31
|
+
? { ...config, stack: `${stack ?? 'unknown'}\n\nFocus: ${input.ask}` }
|
|
32
|
+
: config;
|
|
33
|
+
|
|
34
|
+
const result = await runReviewPhase({
|
|
35
|
+
touchedFiles: resolvedFiles,
|
|
36
|
+
config: effectiveConfig,
|
|
37
|
+
engine,
|
|
38
|
+
cwd: workspace,
|
|
39
|
+
});
|
|
40
|
+
|
|
41
|
+
const run_id = crypto.randomUUID();
|
|
42
|
+
const fileChecksums: Record<string, string> = {};
|
|
43
|
+
for (const f of resolvedFiles) {
|
|
44
|
+
// Store relative key so fix_finding's finding.file lookup matches
|
|
45
|
+
const relKey = path.relative(workspace, f);
|
|
46
|
+
fileChecksums[relKey] = checksumFile(f);
|
|
47
|
+
}
|
|
48
|
+
// Normalize finding.file to relative paths so downstream lookups against
|
|
49
|
+
// fileChecksums (keyed by relative paths) work regardless of whether the
|
|
50
|
+
// review engine echoed absolute or relative paths.
|
|
51
|
+
const normalizedFindings = result.findings.map(f => {
|
|
52
|
+
if (!f.file) return f;
|
|
53
|
+
const rel = path.isAbsolute(f.file) ? path.relative(workspace, f.file) : f.file;
|
|
54
|
+
return rel === f.file ? f : { ...f, file: rel };
|
|
55
|
+
});
|
|
56
|
+
saveRun(workspace, run_id, normalizedFindings, fileChecksums);
|
|
57
|
+
|
|
58
|
+
const critCount = result.findings.filter(f => f.severity === 'critical').length;
|
|
59
|
+
const warnCount = result.findings.filter(f => f.severity === 'warning').length;
|
|
60
|
+
const human_summary = result.findings.length === 0
|
|
61
|
+
? 'No findings.'
|
|
62
|
+
: `${result.findings.length} finding${result.findings.length !== 1 ? 's' : ''}: ${critCount} critical, ${warnCount} warning.`;
|
|
63
|
+
|
|
64
|
+
return { schema_version: 1, run_id, findings: normalizedFindings, human_summary };
|
|
65
|
+
}
|
|
@@ -0,0 +1,41 @@
|
|
|
1
|
+
import { spawnSync } from 'node:child_process';
|
|
2
|
+
import { resolveWorkspace } from '../workspace.ts';
|
|
3
|
+
import { withWriteLock } from '../concurrency.ts';
|
|
4
|
+
import type { GuardrailConfig } from '../../config/types.ts';
|
|
5
|
+
|
|
6
|
+
export interface ValidateFixResult {
|
|
7
|
+
schema_version: 1;
|
|
8
|
+
passed: boolean;
|
|
9
|
+
output: string;
|
|
10
|
+
durationMs: number;
|
|
11
|
+
}
|
|
12
|
+
|
|
13
|
+
export async function handleValidateFix(
|
|
14
|
+
input: { cwd?: string; files?: string[] },
|
|
15
|
+
config: GuardrailConfig,
|
|
16
|
+
): Promise<ValidateFixResult> {
|
|
17
|
+
const workspace = resolveWorkspace(input.cwd);
|
|
18
|
+
|
|
19
|
+
if (!config.testCommand) {
|
|
20
|
+
return { schema_version: 1, passed: true, output: '', durationMs: 0 };
|
|
21
|
+
}
|
|
22
|
+
|
|
23
|
+
return withWriteLock(workspace, async () => {
|
|
24
|
+
const start = Date.now();
|
|
25
|
+
const result = spawnSync('/bin/sh', ['-c', config.testCommand!], {
|
|
26
|
+
cwd: workspace,
|
|
27
|
+
shell: false,
|
|
28
|
+
timeout: 120_000,
|
|
29
|
+
encoding: 'utf8',
|
|
30
|
+
});
|
|
31
|
+
const durationMs = Date.now() - start;
|
|
32
|
+
const raw = ((result.stdout ?? '') + (result.stderr ?? '')).slice(0, 4000);
|
|
33
|
+
|
|
34
|
+
return {
|
|
35
|
+
schema_version: 1 as const,
|
|
36
|
+
passed: result.status === 0,
|
|
37
|
+
output: raw,
|
|
38
|
+
durationMs,
|
|
39
|
+
};
|
|
40
|
+
});
|
|
41
|
+
}
|
|
@@ -0,0 +1,85 @@
|
|
|
1
|
+
import * as fs from 'node:fs';
|
|
2
|
+
import * as path from 'node:path';
|
|
3
|
+
import * as crypto from 'node:crypto';
|
|
4
|
+
import type { Finding } from '../findings/types.ts';
|
|
5
|
+
|
|
6
|
+
const RUNS_DIR = '.guardrail-cache/runs';
|
|
7
|
+
|
|
8
|
+
export interface RunRecord {
|
|
9
|
+
run_id: string;
|
|
10
|
+
createdAt: string;
|
|
11
|
+
findings: Finding[];
|
|
12
|
+
fileChecksums: Record<string, string>;
|
|
13
|
+
}
|
|
14
|
+
|
|
15
|
+
function runsDir(cwd: string): string {
|
|
16
|
+
return path.join(cwd, RUNS_DIR);
|
|
17
|
+
}
|
|
18
|
+
|
|
19
|
+
// Reject any run_id that isn't a safe filename component — path separators,
|
|
20
|
+
// relative segments, hidden files, or empty strings.
|
|
21
|
+
// run_ids are generated server-side as UUIDs (crypto.randomUUID) so strict
|
|
22
|
+
// validation here is safe. MCP clients that fabricate run_ids get a clear
|
|
23
|
+
// rejection instead of silently reading outside RUNS_DIR.
|
|
24
|
+
const VALID_RUN_ID = /^[A-Za-z0-9_-]+$/;
|
|
25
|
+
|
|
26
|
+
function assertValidRunId(runId: string): void {
|
|
27
|
+
if (!runId || typeof runId !== 'string' || !VALID_RUN_ID.test(runId)) {
|
|
28
|
+
throw Object.assign(
|
|
29
|
+
new Error(`invalid run_id: "${runId}" (expected alphanumeric + dash/underscore)`),
|
|
30
|
+
{ code: 'invalid_run_id' },
|
|
31
|
+
);
|
|
32
|
+
}
|
|
33
|
+
}
|
|
34
|
+
|
|
35
|
+
function runFilePath(cwd: string, runId: string): string {
|
|
36
|
+
assertValidRunId(runId);
|
|
37
|
+
return path.join(runsDir(cwd), `${runId}.json`);
|
|
38
|
+
}
|
|
39
|
+
|
|
40
|
+
export function saveRun(
|
|
41
|
+
cwd: string,
|
|
42
|
+
runId: string,
|
|
43
|
+
findings: Finding[],
|
|
44
|
+
fileChecksums: Record<string, string>,
|
|
45
|
+
): void {
|
|
46
|
+
const dir = runsDir(cwd);
|
|
47
|
+
fs.mkdirSync(dir, { recursive: true });
|
|
48
|
+
const record: RunRecord = { run_id: runId, createdAt: new Date().toISOString(), findings, fileChecksums };
|
|
49
|
+
const tmp = runFilePath(cwd, runId) + '.tmp';
|
|
50
|
+
fs.writeFileSync(tmp, JSON.stringify(record, null, 2), 'utf8');
|
|
51
|
+
fs.renameSync(tmp, runFilePath(cwd, runId));
|
|
52
|
+
}
|
|
53
|
+
|
|
54
|
+
export function loadRun(cwd: string, runId: string): RunRecord | null {
|
|
55
|
+
const p = runFilePath(cwd, runId);
|
|
56
|
+
if (!fs.existsSync(p)) return null;
|
|
57
|
+
try {
|
|
58
|
+
return JSON.parse(fs.readFileSync(p, 'utf8')) as RunRecord;
|
|
59
|
+
} catch {
|
|
60
|
+
return null;
|
|
61
|
+
}
|
|
62
|
+
}
|
|
63
|
+
|
|
64
|
+
export function checksumFile(filePath: string): string {
|
|
65
|
+
try {
|
|
66
|
+
const content = fs.readFileSync(filePath);
|
|
67
|
+
return crypto.createHash('sha256').update(content).digest('hex');
|
|
68
|
+
} catch {
|
|
69
|
+
return '';
|
|
70
|
+
}
|
|
71
|
+
}
|
|
72
|
+
|
|
73
|
+
export function pruneOldRuns(cwd: string, maxAgeMs: number): void {
|
|
74
|
+
const dir = runsDir(cwd);
|
|
75
|
+
if (!fs.existsSync(dir)) return;
|
|
76
|
+
const cutoff = Date.now() - maxAgeMs;
|
|
77
|
+
for (const entry of fs.readdirSync(dir)) {
|
|
78
|
+
if (!entry.endsWith('.json')) continue;
|
|
79
|
+
const full = path.join(dir, entry);
|
|
80
|
+
try {
|
|
81
|
+
const stat = fs.statSync(full);
|
|
82
|
+
if (stat.mtimeMs < cutoff) fs.unlinkSync(full);
|
|
83
|
+
} catch { /* ignore */ }
|
|
84
|
+
}
|
|
85
|
+
}
|
|
@@ -0,0 +1,35 @@
|
|
|
1
|
+
import * as fs from 'node:fs';
|
|
2
|
+
import * as path from 'node:path';
|
|
3
|
+
|
|
4
|
+
export function resolveWorkspace(cwd?: string): string {
|
|
5
|
+
return fs.realpathSync(cwd ?? process.cwd());
|
|
6
|
+
}
|
|
7
|
+
|
|
8
|
+
export function assertInWorkspace(workspace: string, filePath: string): string {
|
|
9
|
+
const resolvedWorkspace = fs.realpathSync(workspace);
|
|
10
|
+
const abs = path.isAbsolute(filePath)
|
|
11
|
+
? filePath
|
|
12
|
+
: path.resolve(resolvedWorkspace, filePath);
|
|
13
|
+
|
|
14
|
+
let resolved: string;
|
|
15
|
+
try {
|
|
16
|
+
resolved = fs.realpathSync(abs);
|
|
17
|
+
} catch {
|
|
18
|
+
// File doesn't exist yet — check the directory
|
|
19
|
+
const dir = path.dirname(abs);
|
|
20
|
+
let resolvedDir: string;
|
|
21
|
+
try {
|
|
22
|
+
resolvedDir = fs.realpathSync(dir);
|
|
23
|
+
} catch {
|
|
24
|
+
// Parent directory doesn't exist — resolve what we can
|
|
25
|
+
resolvedDir = path.resolve(dir);
|
|
26
|
+
}
|
|
27
|
+
resolved = path.join(resolvedDir, path.basename(abs));
|
|
28
|
+
}
|
|
29
|
+
|
|
30
|
+
const root = resolvedWorkspace.endsWith(path.sep) ? resolvedWorkspace : resolvedWorkspace + path.sep;
|
|
31
|
+
if (!resolved.startsWith(root) && resolved !== resolvedWorkspace) {
|
|
32
|
+
throw new Error(`Path "${filePath}" is outside workspace "${workspace}"`);
|
|
33
|
+
}
|
|
34
|
+
return resolved;
|
|
35
|
+
}
|
|
@@ -0,0 +1,112 @@
|
|
|
1
|
+
import * as fs from 'node:fs';
|
|
2
|
+
import * as path from 'node:path';
|
|
3
|
+
import type { Finding } from '../findings/types.ts';
|
|
4
|
+
|
|
5
|
+
const BASELINE_FILE = '.guardrail-baseline.json';
|
|
6
|
+
|
|
7
|
+
export interface BaselineEntry {
|
|
8
|
+
id: string;
|
|
9
|
+
file: string;
|
|
10
|
+
line?: number;
|
|
11
|
+
severity: string;
|
|
12
|
+
message: string;
|
|
13
|
+
pinnedAt: string;
|
|
14
|
+
note?: string;
|
|
15
|
+
}
|
|
16
|
+
|
|
17
|
+
export interface Baseline {
|
|
18
|
+
version: 1;
|
|
19
|
+
createdAt: string;
|
|
20
|
+
updatedAt: string;
|
|
21
|
+
note?: string;
|
|
22
|
+
entries: BaselineEntry[];
|
|
23
|
+
}
|
|
24
|
+
|
|
25
|
+
/** Stable key for matching a finding against a baseline entry. */
|
|
26
|
+
function baselineKey(f: { id: string; file: string; line?: number }): string {
|
|
27
|
+
return `${f.id}::${f.file}::${f.line ?? ''}`;
|
|
28
|
+
}
|
|
29
|
+
|
|
30
|
+
export function baselineFilePath(cwd: string, overridePath?: string): string {
|
|
31
|
+
return overridePath
|
|
32
|
+
? path.isAbsolute(overridePath) ? overridePath : path.join(cwd, overridePath)
|
|
33
|
+
: path.join(cwd, BASELINE_FILE);
|
|
34
|
+
}
|
|
35
|
+
|
|
36
|
+
export function loadBaseline(cwd: string, overridePath?: string): Baseline | null {
|
|
37
|
+
const p = baselineFilePath(cwd, overridePath);
|
|
38
|
+
if (!fs.existsSync(p)) return null;
|
|
39
|
+
try {
|
|
40
|
+
return JSON.parse(fs.readFileSync(p, 'utf8')) as Baseline;
|
|
41
|
+
} catch {
|
|
42
|
+
return null;
|
|
43
|
+
}
|
|
44
|
+
}
|
|
45
|
+
|
|
46
|
+
export function saveBaseline(cwd: string, findings: Finding[], options: { note?: string; overridePath?: string } = {}): Baseline {
|
|
47
|
+
const existing = loadBaseline(cwd, options.overridePath);
|
|
48
|
+
const now = new Date().toISOString();
|
|
49
|
+
const baseline: Baseline = {
|
|
50
|
+
version: 1,
|
|
51
|
+
createdAt: existing?.createdAt ?? now,
|
|
52
|
+
updatedAt: now,
|
|
53
|
+
note: options.note ?? existing?.note,
|
|
54
|
+
entries: findings.map(f => ({
|
|
55
|
+
id: f.id,
|
|
56
|
+
file: f.file,
|
|
57
|
+
line: f.line,
|
|
58
|
+
severity: f.severity,
|
|
59
|
+
message: f.message,
|
|
60
|
+
pinnedAt: now,
|
|
61
|
+
})),
|
|
62
|
+
};
|
|
63
|
+
const p = baselineFilePath(cwd, options.overridePath);
|
|
64
|
+
const tmp = p + '.tmp';
|
|
65
|
+
fs.writeFileSync(tmp, JSON.stringify(baseline, null, 2), 'utf8');
|
|
66
|
+
fs.renameSync(tmp, p);
|
|
67
|
+
return baseline;
|
|
68
|
+
}
|
|
69
|
+
|
|
70
|
+
export function clearBaseline(cwd: string, overridePath?: string): void {
|
|
71
|
+
const p = baselineFilePath(cwd, overridePath);
|
|
72
|
+
if (fs.existsSync(p)) fs.unlinkSync(p);
|
|
73
|
+
}
|
|
74
|
+
|
|
75
|
+
export interface BaselineFilterResult {
|
|
76
|
+
newFindings: Finding[];
|
|
77
|
+
baselinedFindings: Finding[];
|
|
78
|
+
baselinedCount: number;
|
|
79
|
+
}
|
|
80
|
+
|
|
81
|
+
/** Returns findings NOT present in the baseline (new findings only). */
|
|
82
|
+
export function filterBaselined(findings: Finding[], baseline: Baseline): BaselineFilterResult {
|
|
83
|
+
const pinned = new Set(baseline.entries.map(baselineKey));
|
|
84
|
+
const newFindings: Finding[] = [];
|
|
85
|
+
const baselinedFindings: Finding[] = [];
|
|
86
|
+
for (const f of findings) {
|
|
87
|
+
if (pinned.has(baselineKey(f))) {
|
|
88
|
+
baselinedFindings.push(f);
|
|
89
|
+
} else {
|
|
90
|
+
newFindings.push(f);
|
|
91
|
+
}
|
|
92
|
+
}
|
|
93
|
+
return { newFindings, baselinedFindings, baselinedCount: baselinedFindings.length };
|
|
94
|
+
}
|
|
95
|
+
|
|
96
|
+
export interface BaselineDiff {
|
|
97
|
+
added: Finding[]; // in current but not in baseline
|
|
98
|
+
resolved: BaselineEntry[]; // in baseline but not in current
|
|
99
|
+
unchanged: Finding[]; // in both
|
|
100
|
+
}
|
|
101
|
+
|
|
102
|
+
/** Diff current findings against a baseline snapshot. */
|
|
103
|
+
export function diffAgainstBaseline(current: Finding[], baseline: Baseline): BaselineDiff {
|
|
104
|
+
const currentKeys = new Set(current.map(baselineKey));
|
|
105
|
+
const baselineKeys = new Set(baseline.entries.map(baselineKey));
|
|
106
|
+
|
|
107
|
+
return {
|
|
108
|
+
added: current.filter(f => !baselineKeys.has(baselineKey(f))),
|
|
109
|
+
resolved: baseline.entries.filter(e => !currentKeys.has(baselineKey(e))),
|
|
110
|
+
unchanged: current.filter(f => baselineKeys.has(baselineKey(f))),
|
|
111
|
+
};
|
|
112
|
+
}
|