@delacour/react-native-charts 0.2.0-alpha.20261021211439 → 0.2.0-alpha.20261022200024

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@delacour/react-native-charts",
-	"version": "0.2.0-alpha.20261021211439",
+	"version": "0.2.0-alpha.20261022200024",
 	"description": "Headless Skia charting primitives for React Native \u2014 no tokens, no className",
 	"type": "module",
 	"license": "MIT",
@@ -43,7 +43,7 @@
 		"d3-shape": "^3.2.0"
 	},
 	"peerDependencies": {
-		"react-native-skia": ">=3",
+		"react-native-skia": ">=3.7.3",
 		"react": ">=19",
 		"react-native": ">=0.81",
 		"react-native-gesture-handler": ">=2.28",

package/src/cartesian/cartesian-chart.tsx

@@ -2,7 +2,6 @@ import { type ReactElement, useEffect, useMemo } from "react";
 import { StyleSheet, View } from "react-native";
 import { useSharedValue } from "react-native-reanimated";
 import { Canvas } from "react-native-skia";
-import "../skia/native-id";
 import type { ChartRow } from "../core/chart.types";
 import { buildLinePath } from "../core/curve/build-line";
 import { toCurvePath } from "../core/interaction/path-segments";

package/src/polar/polar-chart.tsx

@@ -2,7 +2,6 @@ import { type ReactElement, useMemo, useRef } from "react";
 import { StyleSheet, View } from "react-native";
 import { Gesture, type GestureType } from "react-native-gesture-handler";
 import { Canvas } from "react-native-skia";
-import "../skia/native-id";
 import { useCanvasSize } from "../cartesian/hooks/use-canvas-size";
 import type { ChartRow } from "../core/chart.types";
 import { sliceIndexAt } from "../core/polar/slice-index-at";

package/src/skia/AGENTS.md

@@ -13,8 +13,6 @@ files and nothing else.
 | --- | --- |
 | `build-path.ts` | An SVG path string from `core/curve` into an `SkPath` |
 | `font.ts` | A system font, label advance widths, and line height |
-| `native-id.ts` | Seeds Skia's canvas-id counter per JS runtime, imported for its effect by both chart roots |
-| `native-id.test.ts` | The seed: floor, spacing between runtimes, idempotence, the 32-bit bound |
 
 ## Design
 
@@ -39,11 +37,3 @@ files and nothing else.
 - **Line height comes from the font's metrics, not its point size.** An axis
   gutter has to reserve the full glyph box — ascent plus descent — and the
   nominal size is neither.
-
-- **Each JS runtime numbers its canvases from somewhere new.** Skia's counter restarts at 1000 on
-  every reload while its native view registry outlives the runtime, so the reloaded app's first
-  canvases reused ids the old views had tombstoned and drew nothing until they re-rendered — a
-  chart came up empty after a dev reload or an OTA `Updates.reloadAsync`. `native-id.ts` moves the
-  counter to a random range on import, before any canvas asks for an id. It reaches
-  `SkiaViewNativeId` by path because the package root does not export it; `react-native-ui` holds
-  an identical copy for `Flow` and `Sketch`.

package/src/skia/native-id.test.ts

@@ -1,29 +0,0 @@
-import { describe, expect, test } from "bun:test";
-import { resolveSkiaNativeId, SKIA_NATIVE_ID_FLOOR } from "./native-id";
-
-describe("resolveSkiaNativeId", () => {
-	test("moves a fresh runtime's counter off Skia's starting id", () => {
-		expect(resolveSkiaNativeId(1000, 0)).toBe(SKIA_NATIVE_ID_FLOOR);
-		expect(resolveSkiaNativeId(1000, 0.5)).toBeGreaterThan(SKIA_NATIVE_ID_FLOOR);
-	});
-
-	test("keeps the ids a runtime already handed out behind the new counter", () => {
-		expect(resolveSkiaNativeId(1003, 0)).toBe(SKIA_NATIVE_ID_FLOOR + 3);
-	});
-
-	test("leaves a counter that is already seeded alone, so two copies seed once", () => {
-		const seeded = resolveSkiaNativeId(1000, 0.25);
-		expect(resolveSkiaNativeId(seeded, 0.75)).toBe(seeded);
-		expect(resolveSkiaNativeId(seeded + 12, 0.75)).toBe(seeded + 12);
-	});
-
-	test("spreads runtimes far enough apart that one's ids never reach the next's", () => {
-		const a = resolveSkiaNativeId(1000, 0.1);
-		const b = resolveSkiaNativeId(1000, 0.1 + 1 / 100_000);
-		expect(b - a).toBeGreaterThanOrEqual(10_000);
-	});
-
-	test("stays inside a signed 32-bit int, which Skia's native side casts ids to", () => {
-		expect(resolveSkiaNativeId(1000, 0.999_999_999)).toBeLessThan(2 ** 31 - 1_000_000);
-	});
-});

package/src/skia/native-id.ts

@@ -1,42 +0,0 @@
-import { SkiaViewNativeId } from "react-native-skia/src/views/SkiaViewNativeId";
-
-/** Skia's counter starts at 1000; anything at or above this has been seeded. */
-export const SKIA_NATIVE_ID_FLOOR = 10_000;
-
-/** Ids a runtime may hand out before it reaches the next runtime's range. */
-const SKIA_NATIVE_ID_SPAN = 10_000;
-
-/** How many ranges a runtime can land in — 1e9 at the top, inside a signed 32-bit int. */
-const SKIA_NATIVE_ID_SLOTS = 100_000;
-
-/**
- * Where a JS runtime's Skia canvas ids should start, given the counter as it stands and a number
- * in `[0, 1)`. A counter already at or above the floor is returned as it is, so every copy of this
- * module in an app can run it and only the first moves anything.
- */
-export function resolveSkiaNativeId(current: number, random: number): number {
-	if (current >= SKIA_NATIVE_ID_FLOOR) return current;
-	const slot = Math.floor(random * SKIA_NATIVE_ID_SLOTS);
-	return SKIA_NATIVE_ID_FLOOR + slot * SKIA_NATIVE_ID_SPAN + (current - 1000);
-}
-
-/**
- * Starts this runtime's canvas ids somewhere the last runtime's never were.
- *
- * **A canvas mounted after a JS reload drew nothing until it re-rendered.** Skia numbers canvases
- * from a module-level counter that restarts at 1000 in every runtime, while its native
- * `ViewRegistry` is a process-wide singleton that outlives the reload. The old runtime's views are
- * torn down after the new one has started, and each leaves a tombstone for its id; the new
- * runtime's first canvases reuse those ids, their pictures are handed to a throwaway entry, and the
- * view registers to an empty one. Nothing draws until the next React commit sends the picture again.
- * A dev-menu reload hits it, and so does `Updates.reloadAsync` after an OTA update.
- * Reported upstream as wcandillon/react-native-skia#4312; drop this once a release fixes it.
- *
- * Evaluated once per runtime, on import, before any canvas has asked for an id. `SkiaViewNativeId`
- * is not exported from the package root, so this reaches it by path — the same file Metro resolves
- * `Canvas` from through the package's `react-native` field.
- *
- * `@delacour/react-native-ui` keeps an identical copy in `src/lib/skia-native-id.ts` for `Flow` and
- * `Sketch`, which do not depend on this package; change both together.
- */
-SkiaViewNativeId.current = resolveSkiaNativeId(SkiaViewNativeId.current, Math.random());