@deksden-com/dd-flow-cli 0.9.0-beta.7 → 0.9.0-beta.74

package/dist/services/stage-pause.js

@@ -2,6 +2,8 @@ import crypto from "node:crypto";
 import fs from "node:fs";
 import os from "node:os";
 import path from "node:path";
+import { quote } from "shell-quote";
+import { lifecycleRetryCommands, managedLifecycleCommand } from "./lifecycle-invocations.js";
 import { AppError } from "../shared/errors.js";
 import { resolveProjectRoot } from "../storage/paths.js";
 import { findRecentMatchingHookEvent, claimStageResumeHookEvent, stageResumeMatchKey } from "./hooks.js";
@@ -25,7 +27,7 @@ export function pauseStageForUser(context, input) {
     fs.mkdirSync(pauseRoot, { recursive: true });
     fs.writeFileSync(questionPath, question);
     const now = context.now();
-    context.db.exec("BEGIN IMMEDIATE");
+    context.db.beginWriteTransaction();
     try {
         const paused = context.db.run("UPDATE works SET status = 'paused', updated_at = ? WHERE work_id = ? AND status = 'running'", [now, work.work_id]);
         if (paused.changes !== 1)
@@ -71,16 +73,22 @@ export function resumeStageAfterUser(context, input) {
         errorCode: "trusted_stage_resume_required",
         operation: "stage resume"
     }).eventKey;
-    const answerPath = path.join(path.dirname(stage.pause.question_path), "answer.md");
-    fs.writeFileSync(answerPath, input.answer);
     const now = context.now();
     const workSession = context.db.get("SELECT id, session_id, prompt_path, result_path, status FROM work_sessions WHERE work_id = ? AND status = 'running' ORDER BY created_at DESC LIMIT 1", [work.work_id]);
     if (!workSession)
         throw new AppError("runtime_missing", "Paused Work has no open Session link", 1, { work_id: work.work_id });
-    context.db.exec("BEGIN IMMEDIATE");
+    const answerPath = path.join(path.dirname(stage.pause.question_path), `answer-${crypto.createHash("sha256").update(`${stage.pause.id}\0${input.answer}`).digest("hex")}.md`);
+    context.db.beginWriteTransaction();
     let identity;
     try {
         identity = claimStageResumeHookEvent(context, { projectId: project.id, runId: run.id, stage: stage.stage, workId: work.work_id, projectRoot, eventKey: hookEventId });
+        try {
+            fs.writeFileSync(answerPath, input.answer, { flag: "wx", mode: 0o600 });
+        }
+        catch (error) {
+            if (error.code !== "EEXIST" || fs.readFileSync(answerPath, "utf8") !== input.answer)
+                throw error;
+        }
         if (workSession.session_id !== identity.sessionId) {
             bindSessionForResume(context, work.work_id, identity, now);
             context.db.run("UPDATE work_sessions SET status = 'completed', updated_at = ?, completed_at = ? WHERE id = ?", [now, now, workSession.id]);
@@ -99,6 +107,7 @@ export function resumeStageAfterUser(context, input) {
     refreshRunWorkProjection(context, project.id, run.id);
     appendFlowRunTimelineEvent(context, project.id, run.id, { type: "stage_resume_session_bound", stage: stage.stage, work_id: work.work_id, session_id: identity.sessionId });
     const prompt = fs.readFileSync(workSession.prompt_path, "utf8");
+    const retryCommands = lifecycleRetryCommands(context, stage.stage);
     const continuation = [
         prompt.trimEnd(),
         "",
@@ -107,6 +116,7 @@ export function resumeStageAfterUser(context, input) {
         `- Question source: ${stage.pause.question_path}`,
         `- Answer source: ${answerPath}`,
         "- Continue the same stage, Work and attempt. Do not call stage start or repeat completed preparation.",
+        ...(retryCommands.length ? ["- A prior no-effect lifecycle rejection now has these authoritative replacement commands; use only these replacements, never invent an invocation id:", ...retryCommands.map(command => `  ${command}`)] : []),
         "",
         "<user_question>",
         fs.readFileSync(stage.pause.question_path, "utf8"),
@@ -121,7 +131,7 @@ export function resumeStageAfterUser(context, input) {
     return { ok: true, outcome: "resumed", run_id: run.id, work_id: work.work_id, stage: stage.stage, pause_id: stage.pause.id, question_path: stage.pause.question_path, answer_path: answerPath, prompt_path: workSession.prompt_path, worker_prompt_markdown: continuation, next_action: `continue_${stage.stage}` };
 }
 export function stagePauseCommand(context, input) {
-    return `${flowCommand(context)} stage pause ${input.runId} --stage ${input.stage} --work ${input.workId} --question-stdin --project-root ${JSON.stringify(input.projectRoot)} --json`;
+    return managedLifecycleCommand(context, `${flowCommand(context)} stage pause ${input.runId} --stage ${input.stage} --work ${input.workId} --question-stdin --project-root ${JSON.stringify(input.projectRoot)} --json`);
 }
 /**
  * The only shell form allowed for an agent-owned HITL pause.  Supplying a
@@ -147,9 +157,11 @@ Effect on scope or acceptance:
 USER_QUESTION`;
 }
 function stageResumeCommand(context, input) {
-    return `${flowCommand(context)} stage resume ${input.runId} --stage ${input.stage} --work ${input.workId} --answer-stdin --project-root ${JSON.stringify(input.projectRoot)} --json`;
+    return managedLifecycleCommand(context, `${flowCommand(context)} stage resume ${input.runId} --stage ${input.stage} --work ${input.workId} --answer-stdin --project-root ${JSON.stringify(input.projectRoot)} --json`);
 }
 export function flowCommand(context) {
+    const scope = context.env.DD_FLOW_INVOCATION_SCOPE;
+    const prefix = scope ? `DD_FLOW_INVOCATION_SCOPE=${quote([scope])} ` : "";
     const defaultHome = path.resolve(path.join(os.homedir(), ".dd-flow"));
     // Desktop/ACP tool processes are not required to inherit the environment of
     // the adapter that created their Session.  In an isolated runtime, a bare
@@ -158,16 +170,16 @@ export function flowCommand(context) {
     // make every generated lifecycle command self-contained.
     const executable = context.env.DD_FLOW_BIN;
     if (executable && path.isAbsolute(executable)) {
-        return `DD_FLOW_HOME=${JSON.stringify(context.ddFlowHome)} ${JSON.stringify(executable)}`;
+        return `${prefix}DD_FLOW_HOME=${JSON.stringify(context.ddFlowHome)} ${JSON.stringify(executable)}`;
     }
     const isolatedExecutable = path.join(context.ddFlowHome, "bin", "dd-flow");
     if (context.ddFlowHome !== defaultHome && fs.existsSync(isolatedExecutable)) {
-        return `DD_FLOW_HOME=${JSON.stringify(context.ddFlowHome)} ${JSON.stringify(isolatedExecutable)}`;
+        return `${prefix}DD_FLOW_HOME=${JSON.stringify(context.ddFlowHome)} ${JSON.stringify(isolatedExecutable)}`;
     }
-    return context.ddFlowHome === defaultHome ? "dd-flow" : `DD_FLOW_HOME=${JSON.stringify(context.ddFlowHome)} dd-flow`;
+    return context.ddFlowHome === defaultHome ? `${prefix}dd-flow` : `${prefix}DD_FLOW_HOME=${JSON.stringify(context.ddFlowHome)} dd-flow`;
 }
 function requireRun(context, projectId, id) {
-    const rows = context.db.all("SELECT id, short_id, project_id, project_root, run_home_path, index_json FROM runs WHERE project_id = ? AND (id = ? OR short_id = ?)", [projectId, id, id]);
+    const rows = context.db.all("SELECT id, short_id, project_id, project_root, run_root, index_json FROM runs WHERE project_id = ? AND (id = ? OR short_id = ?)", [projectId, id, id]);
     if (rows.length !== 1)
         throw new AppError(rows.length ? "ambiguous_alias" : "not_found", rows.length ? "RUN alias is ambiguous" : "RUN is not registered", 1, { run_id: id });
     return rows[0];
@@ -186,9 +198,9 @@ function requireStage(run, stage, status) {
     return found;
 }
 function requireRunHome(run) {
-    if (!run.run_home_path)
-        throw new AppError("runtime_missing", "RUN has no artifact home", 1, { run_id: run.id });
-    return run.run_home_path;
+    if (!run.run_root)
+        throw new AppError("runtime_missing", "RUN has no artifact root", 1, { run_id: run.id });
+    return run.run_root;
 }
 function nextPauseId(runHome) {
     const root = path.join(runHome, "intake", "hitl");

package/dist/services/usage.js

@@ -4,6 +4,8 @@ import { parseJsonObject } from "../shared/json.js";
 import { resolveProjectRoot } from "../storage/paths.js";
 import { registerProject, requireProjectByRoot } from "./projects.js";
 import { publicSessionIdentity } from "./session-identity.js";
+import { runObservations } from "./run-observations.js";
+import { ToolObservations, codexToolObservation } from "../harness-runtime/lib/tool-observations.mjs";
 export function ingestZcodeUsage(context, input) {
     return ingestHarnessUsage(context, input, { harness: "zcode-acp", label: "ZCode", idPrefix: "ZUSG", sourceKind: "zcode_session_usage_v1" });
 }
@@ -19,6 +21,14 @@ export function ingestOpenCodeUsage(context, input) {
 export function ingestAgyUsage(context, input) {
     return ingestHarnessUsage(context, input, { harness: "antigravity-cli", label: "Antigravity", idPrefix: "AUSG", sourceKind: "antigravity_cli_session_usage_v1" });
 }
+/** Droid counters must describe one physical Session; inclusive roots double-count children. */
+export function ingestDroidUsage(context, input) {
+    const payload = parseJsonObject(input.stdin || "{}", "Droid usage snapshot");
+    if (payload.usage_scope !== "physical_session" || !["complete", "partial"].includes(String(payload.completeness))) {
+        throw new Error("Droid usage requires physical_session scope and complete or partial completeness");
+    }
+    return ingestHarnessUsage(context, input, { harness: "droid-cli", label: "Droid", idPrefix: "DUSG", sourceKind: "droid_session_usage_v1" });
+}
 function ingestHarnessUsage(context, input, harness) {
     const payload = parseJsonObject(input.stdin || "{}", `${harness.label} usage snapshot`);
     const usage = object(payload.usage);
@@ -157,7 +167,7 @@ export function recalculateRunUsage(context, input) {
     const usageFinal = final && unsettledSessions.length === 0;
     const persistRunProjection = !input.sessionId && !input.stage;
     if (persistRunProjection) {
-        context.db.exec("BEGIN IMMEDIATE");
+        context.db.exec("SAVEPOINT run_usage");
         try {
             context.db.run("DELETE FROM usage WHERE project_id = ? AND run_id = ?", [input.projectId, input.runId]);
             for (const row of rows) {
@@ -177,13 +187,16 @@ export function recalculateRunUsage(context, input) {
             AND status = 'idle'
             AND NOT EXISTS (SELECT 1 FROM work_sessions WHERE session_id = ? AND status = 'running')`, [observedAt, session.completed_at, input.projectId, input.runId, session.session_id, session.session_id]);
             }
-            context.db.exec("COMMIT");
+            context.db.exec("RELEASE run_usage");
         }
         catch (error) {
-            context.db.exec("ROLLBACK");
+            context.db.exec("ROLLBACK TO run_usage");
+            context.db.exec("RELEASE run_usage");
             throw error;
         }
     }
+    const observations = persistRunProjection ? runObservations(context, input.projectId, input.runId) : null;
+    const legacyTools = toolCallsForLinks(context, links, accountingAt);
     return {
         ok: true,
         schema_id: "dd-flow/run-usage@2",
@@ -198,7 +211,8 @@ export function recalculateRunUsage(context, input) {
             stopped: publicSessionIdentities(context, input.projectId, settledSessions.map((session) => session.session_id)),
             unsettled: publicSessionIdentities(context, input.projectId, unsettledSessions)
         },
-        tool_calls: toolCallsForLinks(context, links, accountingAt),
+        tool_calls: observations?.tools.observed_sessions ? observations.tools : legacyTools,
+        ...(observations ? { observations, legacy_tool_calls: legacyTools } : {}),
         coverage: rows.reduce((coverage, row) => ({ ...coverage, [row.status]: (coverage[row.status] ?? 0) + 1 }), {})
     };
 }
@@ -241,6 +255,7 @@ function publicSessionIdentities(context, projectId, storageIds) {
 }
 function toolCallsForLinks(context, links, observedAt) {
     const result = { status: "unavailable", total: 0, failures: 0, by_tool: {}, observed_sessions: 0, unavailable_sessions: [] };
+    let incomplete = false;
     const sessions = new Map();
     for (const link of links)
         sessions.set(link.session_id, [...(sessions.get(link.session_id) ?? []), link]);
@@ -253,18 +268,20 @@ function toolCallsForLinks(context, links, observedAt) {
             result.unavailable_sessions.push(sessionId);
             continue;
         }
+        if ("completeness" in parsed && parsed.completeness !== "complete")
+            incomplete = true;
         result.observed_sessions += 1;
         result.total += parsed.total;
         result.failures += parsed.failures;
         for (const [name, count] of Object.entries(parsed.by_tool))
             result.by_tool[name] = (result.by_tool[name] ?? 0) + count;
     }
-    result.status = result.observed_sessions === 0 ? "unavailable" : result.unavailable_sessions.length ? "partial" : "measured";
+    result.status = result.observed_sessions === 0 ? "unavailable" : result.unavailable_sessions.length || incomplete ? "partial" : "measured";
     return result;
 }
-function isExternalHarness(harness) { return harness === "zcode-acp" || harness === "grok-acp" || harness === "opencode-server" || harness === "antigravity-cli"; }
+function isExternalHarness(harness) { return harness === "droid-cli" || harness === "zcode-acp" || harness === "grok-acp" || harness === "opencode-server" || harness === "antigravity-cli"; }
 function harnessSourceKind(harness) {
-    return harness === "grok-acp" ? "grok_session_usage_v1" : harness === "zcode-acp" ? "zcode_session_usage_v1" : harness === "antigravity-cli" ? "antigravity_cli_session_usage_v1" : "opencode_session_usage_v1";
+    return harness === "droid-cli" ? "droid_session_usage_v1" : harness === "grok-acp" ? "grok_session_usage_v1" : harness === "zcode-acp" ? "zcode_session_usage_v1" : harness === "antigravity-cli" ? "antigravity_cli_session_usage_v1" : "opencode_session_usage_v1";
 }
 function readHarnessToolCallsWindow(context, harness, projectId, providerSessionId, startedAt, endedAt, observedAt) {
     if (!providerSessionId)
@@ -302,9 +319,7 @@ function readToolCallsForWindows(transcriptPath, expectedSessionId, windows, obs
         return null;
     try {
         let sessionId;
-        let total = 0;
-        let failures = 0;
-        const byTool = {};
+        const tools = new ToolObservations();
         for (const line of fs.readFileSync(transcriptPath, "utf8").split(/\r?\n/)) {
             if (!line.trim())
                 continue;
@@ -313,6 +328,7 @@ function readToolCallsForWindows(transcriptPath, expectedSessionId, windows, obs
                 event = JSON.parse(line);
             }
             catch {
+                tools.gaps.add("journal_invalid_record");
                 continue;
             }
             const payload = object(event.payload);
@@ -321,20 +337,13 @@ function readToolCallsForWindows(transcriptPath, expectedSessionId, windows, obs
             if (event.type !== "response_item" || !payload)
                 continue;
             const eventAt = stringValue(event.timestamp);
-            if (eventAt && !windows.some((window) => eventInsideWindow(eventAt, window, observedAt)))
+            if (eventAt && windows.length && !windows.some((window) => eventInsideWindow(eventAt, window, observedAt)))
                 continue;
-            const type = stringValue(payload.type);
-            if (type === "function_call" || type === "custom_tool_call") {
-                const name = stringValue(payload.name) ?? "unknown";
-                byTool[name] = (byTool[name] ?? 0) + 1;
-                total += 1;
-            }
-            if ((type === "function_call_output" || type === "custom_tool_call_output") && outputIndicatesFailure(payload))
-                failures += 1;
+            tools.add(codexToolObservation(event, expectedSessionId));
         }
         if (sessionId && sessionId !== expectedSessionId)
             return null;
-        return { total, failures, by_tool: Object.fromEntries(Object.entries(byTool).sort(([left], [right]) => left.localeCompare(right))) };
+        return tools.summary();
     }
     catch {
         return null;
@@ -346,37 +355,6 @@ function eventInsideWindow(eventAt, window, observedAt) {
     const end = Date.parse(window.completed_at ?? observedAt);
     return Number.isFinite(at) && (!Number.isFinite(start) || at >= start) && (!Number.isFinite(end) || at <= end);
 }
-function outputIndicatesFailure(payload) {
-    if (payload.error === true || typeof payload.error === "string")
-        return true;
-    return containsFailure(payload.output);
-}
-function containsFailure(value) {
-    if (Array.isArray(value))
-        return value.some(containsFailure);
-    if (typeof value === "string") {
-        if (/(?:^|\n)exit=(?:[1-9]\d*)\b|Process exited with code [1-9]\d*/.test(value))
-            return true;
-        const trimmed = value.trim();
-        if (trimmed.startsWith("{") || trimmed.startsWith("[")) {
-            try {
-                return containsFailure(JSON.parse(trimmed));
-            }
-            catch {
-                return false;
-            }
-        }
-        return false;
-    }
-    const item = object(value);
-    if (!item)
-        return false;
-    if (item.ok === false || item.is_error === true || item.isError === true || item.error === true || typeof item.error === "string")
-        return true;
-    if (typeof item.exit_code === "number" && item.exit_code !== 0)
-        return true;
-    return Object.values(item).some(containsFailure);
-}
 /** RUN accounting belongs to the physical provider Session, not to every Work link. */
 function usageRowsForPhysicalSessions(context, links, observedAt, stage) {
     const sessions = new Map();
@@ -425,7 +403,7 @@ function hasInclusiveUsageSnapshot(context, projectId, harness, providerSessionI
 function readHarnessUsageWindow(context, harness, projectId, providerSessionId, startedAt, endedAt, observedAt) {
     if (!providerSessionId)
         return { status: "not_observable", diagnostic: "provider_session_id_missing" };
-    const snapshots = context.db.all(`SELECT observed_at, total_tokens, input_tokens, cache_read_input_tokens, cache_write_input_tokens, output_tokens, reasoning_output_tokens
+    const snapshots = context.db.all(`SELECT completeness, observed_at, total_tokens, input_tokens, cache_read_input_tokens, cache_write_input_tokens, output_tokens, reasoning_output_tokens
        FROM harness_usage_snapshots
       WHERE project_id = ? AND harness = ? AND provider_session_id = ? AND observed_at <= ?
       ORDER BY observed_at, id`, [projectId, harness, providerSessionId, observedAt]);
@@ -434,6 +412,8 @@ function readHarnessUsageWindow(context, harness, projectId, providerSessionId,
     const before = snapshots.filter((snapshot) => Date.parse(snapshot.observed_at) <= Date.parse(startedAt)).at(-1);
     if (!last || !before || last === before)
         return { status: "not_yet_emitted", diagnostic: `${harness}_usage_window_incomplete` };
+    if (harness === "droid-cli" && (last.completeness !== "complete" || before.completeness !== "complete"))
+        return { status: "not_observable", diagnostic: "droid-cli_usage_window_partial" };
     const delta = (value, baseline) => value === null || baseline === null ? null : Math.max(0, value - baseline);
     const input = delta(last.input_tokens, before.input_tokens);
     const cacheRead = delta(last.cache_read_input_tokens, before.cache_read_input_tokens);
@@ -575,62 +555,26 @@ function usageReport(context, input, refresh) {
 }
 function toolCallsForSessions(sessions) {
     const result = { status: "unavailable", total: 0, failures: 0, by_tool: {}, observed_sessions: 0, unavailable_sessions: [] };
+    let incomplete = false;
     for (const session of sessions) {
         const parsed = readToolCalls(session.transcript_path, nativeSessionId(session));
         if (!parsed) {
             result.unavailable_sessions.push(session.session_id);
             continue;
         }
+        if (parsed.completeness !== "complete")
+            incomplete = true;
         result.observed_sessions += 1;
         result.total += parsed.total;
         result.failures += parsed.failures;
         for (const [name, count] of Object.entries(parsed.by_tool))
             result.by_tool[name] = (result.by_tool[name] ?? 0) + count;
     }
-    result.status = result.observed_sessions === 0 ? "unavailable" : result.unavailable_sessions.length === 0 ? "measured" : "partial";
+    result.status = result.observed_sessions === 0 ? "unavailable" : result.unavailable_sessions.length || incomplete ? "partial" : "measured";
     return result;
 }
 function readToolCalls(transcriptPath, expectedSessionId) {
-    if (!transcriptPath || !fs.existsSync(transcriptPath))
-        return null;
-    try {
-        let sessionId;
-        const byTool = {};
-        let total = 0;
-        let failures = 0;
-        for (const line of fs.readFileSync(transcriptPath, "utf8").split(/\r?\n/)) {
-            if (!line.trim())
-                continue;
-            let event;
-            try {
-                event = JSON.parse(line);
-            }
-            catch {
-                continue;
-            }
-            const payload = object(event.payload);
-            if (!payload)
-                continue;
-            if (event.type === "session_meta")
-                sessionId = stringValue(payload.id) ?? sessionId;
-            if (event.type !== "response_item")
-                continue;
-            const type = stringValue(payload.type);
-            if (type === "function_call" || type === "custom_tool_call") {
-                const name = stringValue(payload.name) ?? "unknown";
-                byTool[name] = (byTool[name] ?? 0) + 1;
-                total += 1;
-            }
-            if ((type === "function_call_output" || type === "custom_tool_call_output") && outputIndicatesFailure(payload))
-                failures += 1;
-        }
-        if (sessionId && sessionId !== expectedSessionId)
-            return null;
-        return { total, failures, by_tool: Object.fromEntries(Object.entries(byTool).sort(([left], [right]) => left.localeCompare(right))) };
-    }
-    catch {
-        return null;
-    }
+    return readToolCallsForWindows(transcriptPath, expectedSessionId, [], new Date().toISOString());
 }
 function segmentUsage(context, session, segment) {
     if (!session)