@deksden-com/dd-flow-cli 0.9.0-beta.16 → 0.9.0-beta.160

package/dist/services/stage-lifecycle.js

@@ -2,22 +2,27 @@ import crypto from "node:crypto";
 import fs from "node:fs";
 import path from "node:path";
 import { spawnSync } from "node:child_process";
+import { commandResult } from '../harness-runtime/lib/process-json.mjs';
+import { SETUP_STARTUP_MS } from '../harness-runtime/lib/setup-progress.mjs';
 import { requireProjectByRoot } from "./projects.js";
 import { appendAudit } from "./audit.js";
 import { persistProtocolState, requireProtocol, readProtocolRuntimeState } from "./protocols.js";
-import { attachFlowRunStage, completeFlowRunStage, getFlowRunStatus, startFlowRun } from "./runs.js";
+import { attachFlowRunStage, prepareFlowRunStart, prepareFlowRunStageAttachment, prepareStageDirectory, completeFlowRunStage, getFlowRunStatus, startFlowRun } from "./runs.js";
 import { validateSchema } from "./schema-validation.js";
 import { reconcileSessionCoverage, registerFlowSession } from "./sessions.js";
 import { usageForRun } from "./usage.js";
-import { boundCanonicalPlan } from "./plan-runtime.js";
-import { AppError } from "../shared/errors.js";
-import { planJsonPath, resolveProjectRoot } from "../storage/paths.js";
+import { boundCanonicalPlan, prepareCanonicalPlan } from "./plan-runtime.js";
+import { prepareJsonFile, prepareJsonSchema, prepareOutputDirectory, prepareOutputFile, prepareTextFile } from "../cli/input-preparation.js";
+import { AppError, errorRecord, processEvidence, diagnosticJson } from "../shared/errors.js";
+import { planJsonPath, projectHome, resolveProjectRoot } from "../storage/paths.js";
 import { resolveCanonRoot } from "./canon.js";
 import { preflightMemoryPermissions } from "./memory-permissions.js";
 import { registerProject } from "./projects.js";
 import { registerProtocol } from "./protocols.js";
 import { previewNextEntityId } from "./ids.js";
 import { hookSessionIdentity, sessionIdForHookEvent } from "./hooks.js";
+import { assignedSessionIdentity, lifecycleSessionIdentity } from "./assigned-lifecycle.js";
+import { assertRunMutationAllowed } from "./run-recovery.js";
 const stagePromptSections = [
     "stage_identity",
     "authoritative_runtime_facts",
@@ -28,63 +33,30 @@ const stagePromptSections = [
     "work_contract",
     "completion_contract"
 ];
-function bootstrapStageRun(context, projectRoot, input) {
-    if (input.stage !== "specify") {
-        throw new AppError("validation", "--bootstrap currently starts the initial specify stage only", 2, { stage: input.stage });
-    }
-    const subject = input.bootstrap?.subject.trim();
-    if (!subject)
-        throw new AppError("usage", "--bootstrap requires --subject", 2);
+function bootstrapStageRun(context, projectRoot, bootstrap, intakeMarkdown) {
     registerProject(context, { root: projectRoot });
-    const preview = previewNextEntityId(context, { projectRoot, type: "protocol", slug: subject });
-    const protocolId = preview.entity.id;
-    registerProtocol(context, { handshakeId: protocolId, projectRoot });
-    const started = startFlowRun(context, {
-        projectRoot,
-        flowKind: "mb_sdlc",
-        subjectType: "protocol",
-        subjectId: protocolId,
-        slug: subject,
-        nextAction: "run_specify"
-    });
-    const intakeFile = input.bootstrap?.intakeFile;
-    if (intakeFile) {
-        const source = path.resolve(intakeFile);
-        if (!fs.existsSync(source) || !fs.statSync(source).isFile()) {
-            throw new AppError("not_found", "--intake-file must point to an existing file", 1, { intake_file: intakeFile });
-        }
+    registerProtocol(context, { handshakeId: bootstrap.protocolId, projectRoot });
+    const started = startFlowRun(context, bootstrap.startInput, bootstrap.start);
+    if (intakeMarkdown !== undefined) {
         if (!started.run.run_root)
             throw new AppError("runtime_missing", "New RUN has no artifact root", 1, { run_id: started.run.id });
         const intakeDir = path.join(started.run.run_root, "intake");
         fs.mkdirSync(intakeDir, { recursive: true });
-        fs.copyFileSync(source, path.join(intakeDir, "user-request.md"));
+        fs.writeFileSync(path.join(intakeDir, "user-request.md"), intakeMarkdown);
     }
     return started.run.id;
 }
-function stagePreflight(projectRoot, stageRoot) {
+function stagePreflight(projectRoot) {
     const memoryBank = preflightMemoryPermissions({
         root: projectRoot,
         memoryBank: ".memory-bank",
         flow: "custom",
-        mode: "write",
+        mode: "read",
         targets: [{ path: ".memory-bank", mode: "read" }]
     });
-    const probe = path.join(stageRoot, `.dd-flow-permission-${crypto.randomUUID()}`);
-    try {
-        fs.writeFileSync(probe, "");
-        fs.renameSync(probe, `${probe}.renamed`);
-        fs.rmSync(`${probe}.renamed`);
-        return { ...memoryBank, ok: memoryBank.ok === true, stage_workspace: { path: stageRoot, status: "passed" } };
-    }
-    catch (error) {
-        for (const candidate of [probe, `${probe}.renamed`]) {
-            try {
-                fs.rmSync(candidate, { force: true });
-            }
-            catch { /* best effort */ }
-        }
-        return { ...memoryBank, ok: false, stage_workspace: { path: stageRoot, status: "failed", message: String(error) } };
-    }
+    if (memoryBank.ok !== true)
+        throw new AppError("permission_preflight_failed", "Stage project context is not readable", 1, { preflight: memoryBank });
+    return memoryBank;
 }
 function flowKindForStage(stage) {
     return ["code", "implementation", "readiness", "merge"].includes(stage) ? "implementation" : "planning";
@@ -103,23 +75,57 @@ function runtimeFacts(view, projectRoot) {
         git: view.index.execution?.git ?? { branch: null, head: null, status: "unavailable" }
     };
 }
-export function startStage(context, input) {
-    if (input.requireSessionBinding && !input.hookEventId) {
+export function prepareLegacyStageStart(context, input, intakeMarkdown) {
+    if (input.bootstrap && input.stage !== "specify")
+        throw new AppError("validation", "--bootstrap currently starts the initial specify stage only", 2);
+    if (input.bootstrap && !input.bootstrap.subject?.trim())
+        throw new AppError("usage", "--bootstrap requires --subject", 2);
+    if (!input.bootstrap && !input.runId)
+        throw new AppError("usage", "stage start requires a RUN id or --bootstrap", 2);
+    if (input.dir !== undefined)
+        prepareStageDirectory(input.dir);
+    const intake = intakeMarkdown ?? (input.bootstrap?.intakeFile ? prepareTextFile(input.bootstrap.intakeFile, "SPECIFY intake").text : undefined);
+    const projectRoot = resolveProjectRoot(input.projectRoot);
+    const retained = !input.bootstrap && input.runId ? runView(getFlowRunStatus(context, { projectRoot, runId: input.runId })) : null;
+    const dir = input.dir ?? defaultStageDir(input.stage, retained?.run.flow_kind ?? "mb_sdlc");
+    if (retained) {
+        prepareFlowRunStageAttachment(context, { projectRoot, runId: retained.run.id, stage: input.stage, dir, status: "running", dataSchemaId: dataSchemaForStage(input.stage) });
+        const root = path.join(runHomePath(retained.run), dir);
+        for (const name of ["stage-prompt.md", "stage-prompt.json", "stage-start.json", "stage-input.json"])
+            prepareOutputFile(path.join(root, name));
+        if (retained.run.subject.type === "protocol")
+            readProtocolRuntimeState(context, requireProtocol(context, retained.run.subject.id, retained.run.project_id));
+    }
+    const preflight = stagePreflight(projectRoot);
+    const sources = stageInstructionSources(context, projectRoot, retained?.run.flow_kind ?? "mb_sdlc", input.stage).map(source => ({ ...source, text: fs.existsSync(source.absolute) ? fs.readFileSync(source.absolute, "utf8").trim() : "(unavailable)" }));
+    let bootstrap;
+    if (input.bootstrap) {
+        const project = context.db.get("SELECT id FROM projects WHERE root = ?", [projectRoot]);
+        prepareOutputDirectory(project ? projectHome(context.ddFlowHome, project.id) : path.join(context.ddFlowHome, "projects"));
+        const preview = previewNextEntityId(context, { projectRoot, type: "protocol", slug: input.bootstrap.subject });
+        const startInput = { projectRoot, flowKind: "mb_sdlc", subjectType: "protocol", subjectId: preview.entity.id, slug: input.bootstrap.subject, nextAction: "run_specify" };
+        bootstrap = { protocolId: preview.entity.id, startInput, start: prepareFlowRunStart(context, startInput) };
+    }
+    return { intakeMarkdown: intake, projectRoot, retained, dir, preflight, sources, bootstrap };
+}
+export function startStage(context, input, prepared = prepareLegacyStageStart(context, input)) {
+    if (input.requireSessionBinding && !input.hookEventId && !assignedSessionIdentity(context)) {
         throw new AppError("trusted_session_binding_required", "This stage requires a trusted harness lifecycle binding; run it from a controlled Session with the dd-flow adapter enabled", 1);
     }
-    const projectRoot = resolveProjectRoot(input.projectRoot);
+    const { projectRoot, retained, dir, preflight, sources } = prepared;
+    if (retained)
+        prepareFlowRunStageAttachment(context, { projectRoot, runId: retained.run.id, stage: input.stage, dir: input.dir ?? defaultStageDir(input.stage, retained.run.flow_kind), status: "running", dataSchemaId: dataSchemaForStage(input.stage) });
     let requiredSessionId = null;
     let requiredIdentity = null;
     if (input.requireSessionBinding) {
-        registerProject(context, { root: projectRoot });
-        requiredIdentity = hookSessionIdentity(context, requireProjectByRoot(context, projectRoot).id, input.hookEventId);
+        requiredIdentity = lifecycleSessionIdentity(context, requireProjectByRoot(context, projectRoot).id, input.hookEventId);
         requiredSessionId = requiredIdentity.sessionId;
     }
-    const runId = input.bootstrap ? bootstrapStageRun(context, projectRoot, input) : input.runId;
+    const runId = prepared.bootstrap ? bootstrapStageRun(context, projectRoot, prepared.bootstrap, prepared.intakeMarkdown) : input.runId;
     if (!runId)
         throw new AppError("usage", "stage start requires a RUN id or --bootstrap", 2);
-    const before = runView(getFlowRunStatus(context, { projectRoot, runId }));
-    const dir = input.dir ?? defaultStageDir(input.stage, before.run.flow_kind);
+    const before = retained ?? runView(getFlowRunStatus(context, { projectRoot, runId }));
+    assertRunMutationAllowed(context, before.run.project_id, before.run.id);
     const attached = runView(attachFlowRunStage(context, {
         projectRoot,
         runId,
@@ -132,17 +138,14 @@ export function startStage(context, input) {
     const stageRoot = path.join(runHome, dir);
     ensureWithin(runHome, stageRoot, "stage root");
     fs.mkdirSync(stageRoot, { recursive: true });
-    const preflight = stagePreflight(projectRoot, stageRoot);
-    if (preflight.ok !== true)
-        throw new AppError("permission_preflight_failed", "Stage workspace is not writable", 1, { preflight });
     if (attached.run.subject.type === "protocol") {
         syncProtocolLifecycle(context, attached.run.project_id, attached.run.subject.id, input.stage, "running");
     }
-    const sessionId = requiredSessionId ?? (input.hookEventId ? sessionIdForHookEvent(context, attached.run.project_id, input.hookEventId) : null);
+    const sessionId = requiredSessionId ?? assignedSessionIdentity(context)?.sessionId ?? (input.hookEventId ? sessionIdForHookEvent(context, attached.run.project_id, input.hookEventId) : null);
     if (sessionId) {
         const identity = requiredIdentity ?? (input.hookEventId ? hookSessionIdentity(context, attached.run.project_id, input.hookEventId) : null);
         registerFlowSession(context, {
-            sessionId,
+            hookEventId: input.hookEventId,
             payloadJson: JSON.stringify({
                 project_root: projectRoot,
                 harness: identity?.harness ?? "codex-desktop",
@@ -162,12 +165,12 @@ export function startStage(context, input) {
                 continuation_policy: "go_router",
                 session_kind: "orchestrator",
                 current_stage: input.stage,
-                cwd: attached.run.workspace_root
+                cwd: identity?.cwd ?? null
             })
         });
     }
     const promptPath = path.join(stageRoot, "stage-prompt.md");
-    const prompt = composeStagePrompt(context, projectRoot, before, attached, input.stage, dir, preflight);
+    const prompt = composeStagePrompt(context, projectRoot, before, attached, input.stage, dir, preflight, sources);
     atomicWrite(promptPath, prompt);
     const semanticInputPath = path.join(stageRoot, "stage-input.json");
     if (!fs.existsSync(semanticInputPath)) {
@@ -178,7 +181,6 @@ export function startStage(context, input) {
     const aspectMapPath = path.join(stageRoot, "aspect-map.json");
     const attempt = attached.index.stage_runs?.find((stage) => stage.stage === input.stage)?.attempt ?? "try-001";
     const attemptNumber = Number(attempt.replace("try-", "")) || 1;
-    const sources = stageInstructionSources(context, projectRoot, attached.run.flow_kind, input.stage);
     atomicWrite(promptDataPath, {
         schema_id: "dd-flow/stage-prompt@2",
         run_id: attached.run.id,
@@ -257,12 +259,13 @@ export function startStage(context, input) {
         lifecycle: "stage start -> semantic work -> stage finish"
     };
 }
-export function finishStage(context, input) {
+export function prepareStageFinish(context, input) {
     const projectRoot = resolveProjectRoot(input.projectRoot);
     if (!input.runId)
         throw new AppError("usage", "stage finish requires a RUN id", 2);
     const runId = input.runId;
     const view = runView(getFlowRunStatus(context, { projectRoot, runId }));
+    assertRunMutationAllowed(context, view.run.project_id, view.run.id);
     const existing = view.index.stage_runs?.find((stage) => stage.stage === input.stage);
     if (!existing) {
         throw new AppError("not_found", `Run stage is not attached: ${input.stage}`, 1, { run_id: view.run.id, stage: input.stage });
@@ -271,31 +274,37 @@ export function finishStage(context, input) {
     const runHome = runHomePath(view.run);
     const stageRoot = path.join(runHome, dir);
     ensureWithin(runHome, stageRoot, "stage root");
-    fs.mkdirSync(stageRoot, { recursive: true });
     const semanticFile = resolveStageFile(input.semanticFile ?? "@stage/stage-input.json", stageRoot, runHome);
-    const receipt = beginFinishReceipt(context, stageRoot, semanticFile, view.run.id, input.stage);
+    ensureWithin(runHome, semanticFile, "semantic file");
+    const source = prepareJsonSchema(semanticFile, "Stage finish input", { schemaName: "stage-finish-input", projectRoot, runId, runRoot: runHome, ddFlowHome: context.ddFlowHome });
+    const semantic = source.value;
+    const status = stringValue(semantic.status) ?? "done";
+    if (!["done", "waiting_for_user", "blocked", "failed"].includes(status)) {
+        throw new AppError("validation", "Stage finish status must be done, waiting_for_user, blocked, or failed", 2, { status });
+    }
+    validateStageOutcome(input.stage, status, semantic);
+    const planFinish = input.stage === "plan" ? preparePlanFinish(context, projectRoot, view, stageRoot) : undefined;
+    return { projectRoot, runId, view, existing, runHome, stageRoot, semanticFile, semantic, status, source, planFinish };
+}
+export async function finishStage(context, input, prepared = prepareStageFinish(context, input)) {
+    const { projectRoot, runId, view, runHome, stageRoot, semanticFile, semantic, status, source, planFinish } = prepared;
+    assertRunMutationAllowed(context, view.run.project_id, view.run.id);
+    fs.mkdirSync(stageRoot, { recursive: true });
+    const receipt = beginFinishReceipt(context, stageRoot, semanticFile, view.run.id, input.stage, source.text);
     try {
-        validateSchema({ schemaName: "stage-finish-input", file: semanticFile, projectRoot, runId, runRoot: runHome, ddFlowHome: context.ddFlowHome });
-        const semantic = readSemanticFile(semanticFile, runHome);
-        const status = stringValue(semantic.status) ?? "done";
-        if (!["done", "waiting_for_user", "blocked", "failed"].includes(status)) {
-            throw new AppError("validation", "Stage finish status must be done, waiting_for_user, blocked, or failed", 2, { status });
-        }
-        validateStageOutcome(input.stage, status, semantic);
         const coverage = workerCoverage(context, view.run.project_id, view.run.id);
         if (coverage.jobs.missing?.length) {
             throw new AppError("worker_jobs_incomplete", "Stage finish requires all declared worker jobs", 1, { coverage });
         }
-        const lint = runTargetedMemoryBankLint(projectRoot);
-        const planFinish = input.stage === "plan"
-            ? preparePlanFinish(context, projectRoot, view, stageRoot)
-            : undefined;
+        const lint = await runTargetedMemoryBankLint(projectRoot, undefined, path.join(stageRoot, "diagnostics"));
+        if (planFinish)
+            boundCanonicalPlan(context, { projectId: view.run.project_id, protocolId: view.run.subject.id, planPath: planFinish.plan_path }, planFinish.canonical);
         const report = buildStageReport(context, view, input.stage, status, semantic, stageRoot, lint, planFinish);
         const dataPath = path.join(stageRoot, "stage-report.json");
         const reportPath = path.join(stageRoot, "stage-report.md");
         const htmlPath = path.join(stageRoot, "stage-report.html");
+        validateSchema({ schemaName: stageReportSchemaName(input.stage, planFinish), file: dataPath, data: report, projectRoot, runId, runRoot: runHome, ddFlowHome: context.ddFlowHome });
         atomicWrite(dataPath, report);
-        validateSchema({ schemaName: stageReportSchemaName(input.stage, planFinish), file: dataPath, projectRoot, runId, runRoot: runHome, ddFlowHome: context.ddFlowHome });
         atomicWrite(reportPath, renderMarkdown(report));
         atomicWrite(htmlPath, renderHtml(projectRoot, report));
         if (view.run.subject.type === "protocol") {
@@ -480,12 +489,10 @@ function semanticInputTemplate(stage) {
         next_action: waiting ? "waiting_for_user: obtain the clarification packet" : "Continue to the next approved stage."
     };
 }
-function composeStagePrompt(context, projectRoot, before, current, stage, dir, preflight) {
+function composeStagePrompt(context, projectRoot, before, current, stage, dir, preflight, sources) {
     const project = requireProjectByRoot(context, projectRoot);
     const runHome = runHomePath(current.run);
-    const instructions = stageInstructionSources(context, projectRoot, current.run.flow_kind, stage).map(({ label, absolute }) => {
-        return fs.existsSync(absolute) ? `### ${label}\n\n${fs.readFileSync(absolute, "utf8").trim()}` : `### ${label}\n\n(unavailable)`;
-    }).join("\n\n");
+    const instructions = sources.map(({ label, text }) => `### ${label}\n\n${text}`).join("\n\n");
     const protocol = safeProtocolState(context, current.run.project_id, current.run.subject.id);
     return [
         "<stage_identity>",
@@ -508,7 +515,7 @@ function composeStagePrompt(context, projectRoot, before, current, stage, dir, p
         "</authoritative_runtime_facts>",
         "",
         "<preflight>",
-        `- Permission probe: ${String(preflight.ok === true ? "passed" : "failed")}.`,
+        `- Read-only permission check: ${String(preflight.ok === true ? "passed" : "failed")}.`,
         "- CLI compatibility was checked before this state-changing command.",
         "</preflight>",
         "",
@@ -581,16 +588,6 @@ function safeProtocolState(context, projectId, protocolId) {
         return undefined;
     }
 }
-function readSemanticFile(file, runHome) {
-    const resolved = path.resolve(file);
-    ensureWithin(runHome, resolved, "semantic file");
-    if (!fs.existsSync(resolved))
-        throw new AppError("not_found", "Semantic input file is missing", 1, { path: file });
-    const value = JSON.parse(fs.readFileSync(resolved, "utf8"));
-    if (!value || typeof value !== "object" || Array.isArray(value))
-        throw new AppError("validation", "Semantic input must be a JSON object", 2);
-    return value;
-}
 function validateStageOutcome(stage, status, semantic) {
     if (stage !== "specify")
         return;
@@ -602,17 +599,12 @@ function validateStageOutcome(stage, status, semantic) {
         throw new AppError("semantic_status_inconsistent", "SPECIFY done cannot contain unresolved structured questions", 2);
     }
 }
-function beginFinishReceipt(context, stageRoot, semanticFile, runId, stage) {
+function beginFinishReceipt(context, stageRoot, semanticFile, runId, stage, raw) {
     const receiptDir = path.join(stageRoot, "finish-receipts");
     fs.mkdirSync(receiptDir, { recursive: true });
     const number = fs.readdirSync(receiptDir).filter((file) => /^\d{3}\.json$/u.test(file)).length + 1;
     const receiptPath = path.join(receiptDir, `${String(number).padStart(3, "0")}.json`);
-    let raw = null;
-    try {
-        raw = fs.readFileSync(semanticFile, "utf8");
-    }
-    catch { /* receipt records the missing input below */ }
-    const semanticSha = raw === null ? null : crypto.createHash("sha256").update(raw).digest("hex");
+    const semanticSha = crypto.createHash("sha256").update(raw).digest("hex");
     atomicWrite(receiptPath, {
         schema_id: "dd-flow/stage-finish-receipt@1",
         run_id: runId,
@@ -750,7 +742,8 @@ function buildStageReport(context, view, stage, status, semantic, stageRoot, lin
             next_action: stringValue(semantic.next_action) ?? "Resolve the stage result before continuing.",
             ...(Array.isArray(semantic.questions) ? { questions: semantic.questions } : {}),
             ...(Array.isArray(semantic.reviewer_findings) ? { reviewer_findings: semantic.reviewer_findings } : {}),
-            ...(Array.isArray(semantic.def_outcomes) ? { def_outcomes: semantic.def_outcomes } : {})
+            ...(Array.isArray(semantic.def_outcomes) ? { def_outcomes: semantic.def_outcomes } : {}),
+            ...(semantic.materialization !== undefined ? { materialization: semantic.materialization } : {})
         },
         mechanical: {
             started_at: startedAt,
@@ -775,17 +768,13 @@ function buildStageReport(context, view, stage, status, semantic, stageRoot, lin
 }
 function preparePlanFinish(context, projectRoot, view, stageRoot) {
     const planPath = planJsonPath(projectRoot, view.run.subject.id);
-    const canonical = boundCanonicalPlan(context, {
+    const canonical = prepareCanonicalPlan(context, {
         projectId: view.run.project_id,
         protocolId: view.run.subject.id,
         planPath
     });
     const aspectMapPath = path.join(stageRoot, "aspect-map.json");
-    if (!fs.existsSync(aspectMapPath)) {
-        throw new AppError("not_found", "PLAN aspect-map.json is missing", 1, { path: aspectMapPath });
-    }
-    const raw = fs.readFileSync(aspectMapPath, "utf8");
-    const value = JSON.parse(raw);
+    const { text: raw, value } = prepareJsonFile(aspectMapPath, "PLAN aspect map");
     if (!value || typeof value !== "object" || Array.isArray(value)) {
         throw new AppError("validation", "PLAN aspect-map.json must be a JSON object", 2, { path: aspectMapPath });
     }
@@ -848,7 +837,7 @@ function workerCoverage(context, projectId, runId) {
         jobs: { expected: jobs.map((job) => job.job_id), missing: missingJobs }
     };
 }
-export function runTargetedMemoryBankLint(projectRoot, selectedFiles) {
+export async function runTargetedMemoryBankLint(projectRoot, selectedFiles, diagnosticRoot) {
     const files = [...new Set((selectedFiles ?? gitChangedFiles(projectRoot)).filter((file) => file.startsWith(".memory-bank/") && file.toLowerCase().endsWith(".md") && !file.split(/[\\/]/u).some((part) => part === ".." || part.startsWith(".env"))))];
     for (const file of files)
         ensureWithin(projectRoot, path.resolve(projectRoot, file), "lint target");
@@ -856,23 +845,71 @@ export function runTargetedMemoryBankLint(projectRoot, selectedFiles) {
         return { ok: true, status: "not_applicable_no_changed_docs", files, finding_count: 0 };
     }
     const binary = process.env.MB_LINT_BIN ?? "mb-lint";
-    const result = spawnSync(binary, ["--root", projectRoot, "--files", ...files, "--format", "json"], { cwd: projectRoot, encoding: "utf8" });
-    if (result.error || result.status === null) {
-        throw new AppError("lint_gate_unavailable", "Selected-file mb-lint is unavailable", 1, { binary, files, cause: String(result.error ?? "process did not start") });
+    const fail = (code, message, details) => {
+        const error = new AppError(code, message, 1, { binary, files, ...details });
+        if (diagnosticRoot) {
+            try {
+                fs.mkdirSync(diagnosticRoot, { recursive: true });
+                const file = path.join(diagnosticRoot, `lint-${crypto.randomUUID()}.json`);
+                if (details.report) {
+                    const reportFile = file.replace(/\.json$/, ".report.json"), report = diagnosticJson(details.report);
+                    const reportBytes = Buffer.from(report);
+                    fs.writeFileSync(reportFile, reportBytes.length <= 1024 * 1024 ? report : JSON.stringify({ truncated: true, bytes: reportBytes.length, excerpt: reportBytes.subarray(0, 128 * 1024).toString("utf8") }), { flag: "wx", mode: 0o600 });
+                    error.details.report_path = reportFile;
+                }
+                delete error.details.report;
+                fs.writeFileSync(file, diagnosticJson(errorRecord(error)), { flag: "wx", mode: 0o600 });
+                error.details.diagnostic_path = file;
+            }
+            catch (capture) {
+                delete error.details.report;
+                error.details.capture_error = errorRecord(capture);
+            }
+        }
+        delete error.details.report;
+        throw error;
+    };
+    let result;
+    try {
+        result = await commandResult(binary, ["--root", projectRoot, "--files", ...files, "--format", "json"], { cwd: projectRoot, startupMs: SETUP_STARTUP_MS });
     }
-    let parsed = {};
+    catch (cause) {
+        const recorded = errorRecord(cause), unavailable = ["ENOENT", "EACCES", "ENOEXEC"].includes(recorded.code);
+        fail(unavailable ? "lint_gate_unavailable" : "lint_gate_tool_failed", "Selected-file mb-lint could not execute", { cause: recorded });
+    }
+    const evidence = processEvidence(result);
+    if (result.signal || result.exit_code !== 0 && result.exit_code !== 1)
+        fail("lint_gate_tool_failed", "Selected-file mb-lint did not complete normally", { process: evidence });
+    let parsed;
     try {
-        parsed = result.stdout ? JSON.parse(result.stdout) : {};
+        parsed = JSON.parse(result.stdout);
     }
     catch {
-        throw new AppError("lint_gate_invalid_output", "Selected-file mb-lint did not return JSON", 1, { binary, files });
+        fail(result.exit_code === 0 ? "lint_gate_invalid_output" : "lint_gate_tool_failed", "Selected-file mb-lint did not return a report", { process: evidence });
     }
-    if (result.status !== 0) {
-        throw new AppError("lint_gate_failed", "Selected-file mb-lint reported blocking findings", 1, { binary, files, result: parsed });
+    const report = parsed;
+    const severities = { error: "errors", warning: "warnings", info: "info", suggestion: "suggestions" };
+    const matchingRoot = () => { try {
+        return typeof report?.root === "string" && fs.realpathSync(path.resolve(projectRoot, report.root)) === fs.realpathSync(projectRoot);
     }
-    const findingCount = parsed && typeof parsed === "object" && Array.isArray(parsed.findings)
-        ? parsed.findings.length
-        : 0;
+    catch {
+        return false;
+    } };
+    const valid = report && report.tool === "mb-lint" && typeof report.version === "string" && report.version.trim()
+        && matchingRoot()
+        && report.memoryBank === ".memory-bank" && report.summary && Array.isArray(report.findings)
+        && report.findings.every(finding => finding && typeof finding === "object" && typeof finding.severity === "string" && Object.hasOwn(severities, finding.severity)
+            && [finding.ruleId, finding.file, finding.message].every(value => typeof value === "string" && value.trim()))
+        && Object.entries(severities).every(([severity, key]) => Number.isSafeInteger(report.summary[key]) && Number(report.summary[key]) >= 0
+            && report.summary[key] === report.findings.filter(finding => finding.severity === severity).length);
+    if (!valid)
+        fail(result.exit_code === 0 ? "lint_gate_invalid_output" : "lint_gate_tool_failed", "Selected-file mb-lint returned an invalid report", { process: evidence });
+    const errors = Number(report.summary.errors);
+    if ((errors > 0 ? 1 : 0) !== result.exit_code)
+        fail("lint_gate_invalid_output", "Selected-file mb-lint report contradicts its exit status", { process: evidence });
+    if (errors > 0)
+        fail("lint_gate_failed", "Selected-file mb-lint reported blocking findings", { process: evidence, report: parsed, summary: report.summary, finding_count: report.findings.length });
+    const findingCount = report.findings.length;
     return { ok: true, status: "passed", binary, files, finding_count: findingCount, result: parsed };
 }
 function renderMarkdown(report) {