@deksden-com/dd-flow-cli 0.9.0-beta.137 → 0.9.0-beta.139

package/dist/services/memory-review-inputs.js

@@ -0,0 +1,200 @@
+import { AppError } from "../shared/errors.js";
+import { RetainedExecutionBundle } from "./execution-bundles.js";
+import { assertPreparedRunBundleSqlAuthority } from "./runs.js";
+import { readDescriptorRootWork } from "./descriptor-root-work.js";
+import { readAcceptedStageData } from "./stage-report-renderer.js";
+import { PreparedAcceptedMemoryComposition } from "./memory-accepted-composition.js";
+import { PreparedAcceptedMemoryVerification } from "./memory-verification-receipt.js";
+import { PreparedMemoryBaselinePreservation } from "./memory-baseline-preservation.js";
+import { ObservedMemorySources } from "./memory-source-observations.js";
+import { memorySourceKey } from "./memory-stage-results.js";
+import { hybridDigest } from "./hybrid-contracts.js";
+import { reviewEnvironmentAllowed, reviewSourcePaths, reviewSourceHash } from "./review-copy.js";
+import { assertRunMutationAllowed } from "./run-recovery-guard.js";
+import { PreparedDescriptorStageCoordinator } from "./descriptor-stage-coordinator.js";
+import { readDescriptorCoordinatorSession } from "./descriptor-coordinator-session.js";
+import { readMemoryInitBootstrapReadiness } from "./memory-init-bootstrap-readiness.js";
+/** Exact inherited evidence only; current artifact bytes remain independently observed. */
+export function memoryReviewEvidenceTriples(units) {
+    return new Set(units.flatMap(unit => unit.evidence.map(ref => `${memorySourceKey(ref.root, ref.path)}\0${ref.sha256}`)));
+}
+function refuse(reason) {
+    throw new AppError("memory_review_input_invalid", "Memory reviewer input lacks accepted unit and document custody", 2, { reason, effect: "no_effect" });
+}
+/** Derives exact per-unit assignments. Source aliases from the original project
+ * are read through the assigned workspace, whose baseline is independently
+ * preserved. This function alone supplies neither acceptance nor SQL authority.
+ */
+export function memoryReviewUnitAssignments(units, historicalEvidence = new Set()) {
+    if (!Array.isArray(units) || !units.length || units.length > 256
+        || units.some(unit => !unit || typeof unit.id !== "string" || !unit.id || typeof unit.aspect !== "string" || !unit.aspect)
+        || new Set(units.map(unit => unit.id)).size !== units.length)
+        refuse("invalid_unit_inventory");
+    return units.filter(unit => {
+        if (!["applicable", "not-applicable"].includes(unit.applicability))
+            refuse("unresolved_unit_applicability");
+        return unit.applicability === "applicable";
+    }).map(unit => {
+        if (typeof unit.id !== "string" || !unit.id || typeof unit.aspect !== "string" || !unit.aspect
+            || !Array.isArray(unit.evidence) || !Array.isArray(unit.artifacts) || !unit.artifacts.length)
+            refuse("invalid_unit_assignment");
+        const references = new Map();
+        for (const [role, refs] of [["evidence", unit.evidence], ["artifacts", unit.artifacts]])
+            for (const ref of refs) {
+                if (!ref || !["project", "workspace", "canon", "run"].includes(ref.root) || typeof ref.path !== "string" || !ref.path
+                    || ref.path.startsWith("/") || /^[A-Za-z]:/.test(ref.path) || ref.path.includes("\\") || ref.path.includes("\0")
+                    || ref.path.split("/").some((part) => !part || part === "." || part === "..")
+                    || typeof ref.sha256 !== "string" || !/^[a-f0-9]{64}$/.test(ref.sha256))
+                    refuse("invalid_unit_source");
+                const input = { root: ref.root === "run" ? "run" : "workspace",
+                    path: ref.root === "canon" ? `.memory-bank/${ref.path}` : ref.path, sha256: ref.sha256 };
+                if (role === "evidence" && historicalEvidence.has(`${memorySourceKey(ref.root, ref.path)}\0${ref.sha256}`)
+                    && units.flatMap(item => item.artifacts).some(artifact => (artifact.root === "run" ? "run" : "workspace") === input.root
+                        && (artifact.root === "canon" ? `.memory-bank/${artifact.path}` : artifact.path) === input.path && artifact.sha256 !== ref.sha256))
+                    continue;
+                const key = memorySourceKey(input.root, input.path), prior = references.get(key);
+                if (prior && prior.sha256 !== ref.sha256)
+                    refuse("conflicting_unit_sources");
+                references.set(key, input);
+            }
+        if (references.size > 4096)
+            refuse("unbounded_unit_sources");
+        return { unit: structuredClone(unit), inputs: [...references.values()].sort((a, b) => a.path.localeCompare(b.path, "en")) };
+    });
+}
+export function readMemoryReviewPhase(context, scope, bundle) {
+    const run = assertPreparedRunBundleSqlAuthority(context, scope, bundle), index = JSON.parse(run.index_json);
+    const stage = index.stage_runs?.find((item) => item.stage === "review");
+    const root = readDescriptorRootWork(context, scope, bundle);
+    if (run.status !== "running" || index.current_stage !== "review" || stage?.status !== "running"
+        || root.status !== "running" || !/^try-[0-9]{3,}$/.test(stage.attempt)
+        || !/^[a-f0-9]{64}$/.test(stage.input_sha256))
+        refuse("active_review_required");
+    return { project_id: scope.projectId, run_id: scope.runId, stage: "review",
+        attempt: stage.attempt, input_sha256: stage.input_sha256, parent_work_id: root.workId,
+        execution_sha256: bundle.execution.sha256, bundle_sha256: bundle.sha256 };
+}
+const phase = readMemoryReviewPhase;
+/** Initial-wave owner, not a repair view. Every applicable unit gets a separate
+ * immutable assignment while the wave shares one document/copy baseline for
+ * cross-file review. No allocation, publication, provider or Work claim occurs.
+ */
+export class PreparedMemoryInitialReviewInputs {
+    sha256;
+    #scope;
+    #bundle;
+    #phase;
+    #composition;
+    #verification;
+    #preservation;
+    #observed;
+    #view;
+    #generation;
+    #coordinator;
+    #coordinatorSession;
+    constructor(scope, bundle, selected, composition, verification, preservation, observed, view, generation, coordinator, coordinatorSession) {
+        this.#scope = { ...scope };
+        this.#bundle = bundle;
+        this.#phase = selected;
+        this.#composition = composition;
+        this.#verification = verification;
+        this.#preservation = preservation;
+        this.#observed = observed;
+        this.#view = structuredClone(view);
+        this.#generation = generation;
+        this.sha256 = hybridDigest(view);
+        Object.freeze(this);
+        this.#coordinator = coordinator;
+        this.#coordinatorSession = coordinatorSession;
+    }
+    static prepare(context, input) {
+        const { scope, bundle } = input;
+        if (!(bundle instanceof RetainedExecutionBundle) || bundle.descriptor.descriptor.id !== "mb-init")
+            refuse("registered_memory_bundle_required");
+        const generation = assertRunMutationAllowed(context, scope.projectId, scope.runId);
+        const workerSchema = JSON.parse(bundle.engine().schema("memory-review-work-result").toString("utf8"));
+        if (workerSchema.$id !== "dd-flow/memory-review-work-result@1")
+            refuse("frozen_review_worker_schema_required");
+        const selected = phase(context, scope, bundle);
+        const coordinator = PreparedDescriptorStageCoordinator.prepare(context, { projectRoot: bundle.execution.snapshot().scope.projectRoot, runId: scope.runId, stage: "review" });
+        coordinator.assertAllocatedCustody(context);
+        const coordinatorSession = readDescriptorCoordinatorSession(context, { scope: { ...scope, stage: "review" }, bundle, workId: selected.parent_work_id }, refuse);
+        const preservation = PreparedMemoryBaselinePreservation.prepare(context, bundle.execution);
+        const composition = PreparedAcceptedMemoryComposition.prepare(context, { scope, bundle });
+        const compose = readAcceptedStageData(context, { ...scope, stage: "compose" });
+        const verify = readAcceptedStageData(context, { ...scope, stage: "verify" });
+        const verification = PreparedAcceptedMemoryVerification.prepare(context, { ...scope, bytes: verify.bytes });
+        const unitInventory = composition.result().value().units;
+        const assignments = memoryReviewUnitAssignments(unitInventory, composition.historicalEvidence());
+        const diagnosticFindings = verification.qualityPassed(context) ? [] : verification.diagnosticFindings(context).filter(finding => finding.status === "open" && finding.severity !== "minor");
+        for (const finding of diagnosticFindings) {
+            const assignment = assignments.find(item => item.unit.id === finding.unit_id);
+            if (!assignment)
+                refuse("diagnostic_finding_outside_units");
+            for (const ref of finding.evidence)
+                if (ref.root === "run" && !assignment.inputs.some(input => input.root === ref.root && input.path === ref.path))
+                    assignment.inputs.push({ ...ref, root: "run" });
+        }
+        const inputs = new Map();
+        const frozenScope = bundle.execution.snapshot().scope;
+        const bootstrap = readMemoryInitBootstrapReadiness(context, { requestId: frozenScope.requestId,
+            projectRoot: frozenScope.projectRoot, workspaceRoot: frozenScope.workspace });
+        const lintSha256 = bootstrap?.authority.binding.target.generated_lint_config_sha256;
+        if (lintSha256)
+            inputs.set(memorySourceKey("workspace", ".mb-lint.json"), { root: "workspace", path: ".mb-lint.json", sha256: lintSha256 });
+        for (const ref of [{ root: "run", ...compose.result }, { root: "run", ...verify.result }, ...assignments.flatMap(item => item.inputs)]) {
+            const key = memorySourceKey(ref.root, ref.path), previous = inputs.get(key);
+            if (previous && previous.sha256 !== ref.sha256)
+                refuse("conflicting_wave_sources");
+            inputs.set(key, ref);
+        }
+        if (inputs.size > 4096)
+            refuse("unbounded_wave_sources");
+        const runInputs = [...inputs.values()].sort((a, b) => `${a.root}:${a.path}`.localeCompare(`${b.root}:${b.path}`, "en"));
+        const paths = runInputs.filter(ref => ref.root === "workspace").map(ref => ref.path);
+        if (paths.some(path => !reviewEnvironmentAllowed(path)))
+            refuse("private_or_unavailable_review_sources");
+        const run = assertPreparedRunBundleSqlAuthority(context, scope, bundle), index = JSON.parse(run.index_json);
+        const roots = { run: run.run_root ?? run.run_dir, workspace: bundle.execution.snapshot().scope.workspace };
+        const observed = ObservedMemorySources.capture(roots, runInputs.map(({ root, path }) => ({ root, path }))), hashes = observed.hashes();
+        if (runInputs.some(ref => hashes.get(memorySourceKey(ref.root, ref.path)) !== ref.sha256))
+            refuse("changed_review_source");
+        const base = index.workspace?.base && index.workspace.base !== "unknown" ? index.workspace.base : "HEAD";
+        const retained = reviewSourcePaths(roots.workspace, paths, base);
+        if (retained === null || paths.some(path => !retained.includes(path)))
+            refuse("private_or_unavailable_review_sources");
+        const instruction = bundle.descriptor.stageBlob("review", "instruction");
+        const view = { schema_id: "dd-flow/memory-review-inputs@1", wave: 0, scope: selected,
+            source_policy: "review-inputs@1", source_sha256: reviewSourceHash(roots.workspace, paths, base), base,
+            run_inputs: runInputs, unit_inventory: structuredClone(unitInventory), assignments,
+            ...(diagnosticFindings.length ? { diagnostic_findings: diagnosticFindings } : {}),
+            instruction: { sha256: bundle.descriptor.stage("review").instruction.sha256, base64: instruction.toString("base64") } };
+        if (Buffer.byteLength(JSON.stringify(view)) > 1024 * 1024)
+            refuse("unbounded_review_input");
+        const prepared = new PreparedMemoryInitialReviewInputs(scope, bundle, selected, composition, verification, preservation, observed, view, generation, coordinator, coordinatorSession);
+        prepared.assertCustody(context);
+        return prepared;
+    }
+    value() { return structuredClone(this.#view); }
+    assertCustody(context) {
+        assertRunMutationAllowed(context, this.#scope.projectId, this.#scope.runId, this.#generation);
+        this.#coordinator.assertAllocatedCustody(context);
+        if (readDescriptorCoordinatorSession(context, { scope: { ...this.#scope, stage: "review" }, bundle: this.#bundle, workId: this.#phase.parent_work_id }, refuse) !== this.#coordinatorSession)
+            refuse("coordinator_changed");
+        if (hybridDigest(phase(context, this.#scope, this.#bundle)) !== hybridDigest(this.#phase))
+            refuse("review_phase_changed");
+        this.#preservation.assertCustody(context);
+        this.#composition.assertCustody(context);
+        this.#verification.assertCustody(context);
+    }
+    revalidate(context) {
+        this.#preservation.revalidate(context);
+        this.#composition.revalidate(context);
+        this.#verification.revalidate(context);
+        this.#observed.revalidate();
+        const paths = this.#view.run_inputs.filter(ref => ref.root === "workspace").map(ref => ref.path);
+        if (reviewSourceHash(this.#bundle.execution.snapshot().scope.workspace, paths, this.#view.base) !== this.#view.source_sha256)
+            refuse("review_copy_source_changed");
+        this.assertCustody(context);
+    }
+}

package/dist/services/memory-review-receipt.js

@@ -0,0 +1,180 @@
+import { Ajv2020 } from "ajv/dist/2020.js";
+import { AppError } from "../shared/errors.js";
+import { appendAudit } from "./audit.js";
+import { hybridDigest } from "./hybrid-contracts.js";
+import { RetainedExecutionBundle } from "./execution-bundles.js";
+import { assertPreparedRunBundleSqlAuthority } from "./runs.js";
+import { readAcceptedStageData } from "./stage-report-renderer.js";
+import { PreparedMemoryStageResult, memorySourceKey } from "./memory-stage-results.js";
+import { PreparedMemoryInitialReviewAcceptance, assertMemoryInitialReviewProjection, readMemoryReviewWorkSettlement } from "./memory-review-acceptance.js";
+import { readRegisteredMemoryReview, memoryReviewBatch } from "./memory-review-registration.js";
+import { validateMemoryReviewWorkResult } from "./memory-review-work-results.js";
+import { PreparedAcceptedMemoryVerification } from "./memory-verification-receipt.js";
+import { ObservedMemorySources } from "./memory-source-observations.js";
+import { runtimeHarness } from "./execution-policy.js";
+const event = "memory.review_acceptance", token = Symbol("memory-review-acceptance-receipt");
+function refuse(reason) {
+    throw new AppError("memory_review_receipt_invalid", "Review lacks independently accepted wave custody", 2, { reason, effect: "no_effect" });
+}
+function stage(context, scope) {
+    const run = context.db.get("SELECT index_json FROM runs WHERE project_id=? AND id=?", [scope.projectId, scope.runId]);
+    if (!run)
+        refuse("run_missing");
+    const index = JSON.parse(run.index_json), selected = index.stage_runs?.find((item) => item.stage === "review");
+    if (!selected || typeof selected.attempt !== "string" || !/^try-[0-9]{3,}$/.test(selected.attempt)
+        || typeof selected.input_sha256 !== "string" || !/^[a-f0-9]{64}$/.test(selected.input_sha256))
+        refuse("review_identity_missing");
+    return { current: index.current_stage, status: selected.status, attempt: selected.attempt, input_sha256: selected.input_sha256 };
+}
+function rows(context, scope) {
+    return context.db.all("SELECT payload_json FROM audit_events WHERE project_id=? AND event_type=? AND json_extract(payload_json,'$.run_id')=? LIMIT 2", [scope.projectId, event, scope.runId]);
+}
+function noCorrections(context, scope, proof) {
+    if (context.db.get("SELECT 1 FROM audit_events WHERE project_id=? AND event_type='memory.repair_registration' AND json_extract(payload_json,'$.run_id')=? AND json_extract(payload_json,'$.scope.attempt')=? AND json_extract(payload_json,'$.scope.parent_work_id')=? LIMIT 1", [scope.projectId, scope.runId, proof.registration_scope.attempt, proof.registration_scope.parent_work_id]))
+        refuse("initial_acceptance_cannot_close_corrections");
+}
+function makeReceipt(scope, selected, resultSha256, proof) {
+    if (proof.registration_scope.project_id !== scope.projectId || proof.registration_scope.run_id !== scope.runId
+        || proof.registration_scope.stage !== "review" || proof.registration_scope.attempt !== selected.attempt
+        || proof.registration_scope.input_sha256 !== selected.input_sha256 || proof.wave !== 0)
+        refuse("foreign_initial_wave");
+    const value = { schema_id: "dd-flow/memory-review-acceptance@1", project_id: scope.projectId, run_id: scope.runId,
+        stage: "review", attempt: selected.attempt, input_sha256: selected.input_sha256, result_sha256: resultSha256, ...structuredClone(proof) };
+    if (Buffer.byteLength(JSON.stringify(value)) > 2 * 1024 * 1024)
+        refuse("unbounded_review_receipt");
+    return value;
+}
+/** Independent wave-zero receipt commits with generic Stage acceptance.
+ * It cannot close a correction graph or substitute for a later review wave. */
+export class PreparedMemoryInitialReviewReceipt {
+    #scope;
+    #wave;
+    #result;
+    #receipt;
+    constructor(key, scope, wave, result, receipt) {
+        if (key !== token)
+            refuse("receipt_token_required");
+        this.#scope = { ...scope };
+        this.#wave = wave;
+        this.#result = result;
+        this.#receipt = structuredClone(receipt);
+        Object.freeze(this);
+    }
+    static prepare(context, input) {
+        if (!PreparedMemoryInitialReviewAcceptance.isPrepared(input.wave) || !(input.result instanceof PreparedMemoryStageResult))
+            refuse("prepared_initial_wave_required");
+        const proof = input.wave.settlementProof(context, input.result), selected = stage(context, input.scope);
+        if (selected.current !== "review" || selected.status !== "running" || input.result.value().outcome !== "accepted")
+            refuse("accepted_active_review_required");
+        noCorrections(context, input.scope, proof);
+        if (rows(context, input.scope).length)
+            refuse("fresh_receipt_already_exists");
+        return new PreparedMemoryInitialReviewReceipt(token, input.scope, input.wave, input.result, makeReceipt(input.scope, selected, input.result.sha256, proof));
+    }
+    record(context) {
+        const scope = this.#scope;
+        if (!context.db.isOwnedWriteTransaction?.())
+            refuse("owned_acceptance_writer_required");
+        const proof = this.#wave.settlementProof(context, this.#result), selected = stage(context, this.#scope);
+        noCorrections(context, this.#scope, proof);
+        if (selected.current !== "review" || selected.status !== "running" || rows(context, this.#scope).length
+            || hybridDigest(makeReceipt(this.#scope, selected, this.#result.sha256, proof)) !== hybridDigest(this.#receipt))
+            refuse("fresh_review_custody_changed");
+        appendAudit(context, { projectId: scope.projectId, eventType: event, payload: this.#receipt });
+        const retained = rows(context, this.#scope);
+        if (retained.length !== 1 || hybridDigest(JSON.parse(retained[0].payload_json)) !== hybridDigest(this.#receipt))
+            refuse("review_receipt_readback_failed");
+    }
+}
+function accepted(context, scope, bundle) {
+    assertPreparedRunBundleSqlAuthority(context, scope, bundle);
+    const selected = stage(context, scope), data = readAcceptedStageData(context, { ...scope, stage: "review" }), records = rows(context, scope);
+    if (selected.status !== "done" || records.length !== 1 || Buffer.byteLength(records[0].payload_json) > 2 * 1024 * 1024)
+        refuse("accepted_receipt_missing");
+    let receipt;
+    try {
+        receipt = JSON.parse(records[0].payload_json);
+    }
+    catch {
+        return refuse("invalid_receipt_json");
+    }
+    if (!receipt || typeof receipt !== "object" || Array.isArray(receipt) || !receipt.registration_scope
+        || receipt.registration_scope.bundle_sha256 !== bundle.sha256 || receipt.registration_scope.execution_sha256 !== bundle.execution.sha256
+        || receipt.wave !== 0 || data.data_schema_id !== "dd-flow/mb-init-review-result@1" || data.input_sha256 !== selected.input_sha256)
+        refuse("accepted_review_changed");
+    const registration = readRegisteredMemoryReview(context, receipt.registration_scope, 0);
+    const batch = memoryReviewBatch(registration.view), harness = runtimeHarness(bundle.execution.work("review").worker);
+    const workers = batch.works.map(item => readMemoryReviewWorkSettlement(context, registration, registration.work_ids[item.key], harness));
+    const proof = { registration_scope: registration.scope, registration_sha256: hybridDigest(registration), wave: 0,
+        workers: workers.map(worker => ({ work_id: worker.workId, authority_sha256: worker.authority, result: worker.result })) };
+    noCorrections(context, scope, proof);
+    if (hybridDigest(receipt) !== hybridDigest(makeReceipt(scope, selected, data.result.sha256, proof)))
+        refuse("accepted_review_custody_changed");
+    const verify = readAcceptedStageData(context, { ...scope, stage: "verify" });
+    const value = JSON.parse(data.bytes.toString("utf8"));
+    if (value.schema_id !== data.data_schema_id || value.run_id !== scope.runId || value.stage !== "review" || value.outcome !== "accepted"
+        || value.input_sha256 !== selected.input_sha256 || hybridDigest(value.predecessors) !== hybridDigest([{ stage: "verify", result: verify.result, input_sha256: verify.input_sha256 }]))
+        refuse("accepted_review_result_changed");
+    return { data, verify, registration, workers, batch, receipt, value };
+}
+/** Historical acceptance replay uses retained reviewer/check/result custody,
+ * not today's project policy, MB bytes or obsolete read-only copies. */
+export class PreparedAcceptedMemoryInitialReview {
+    #scope;
+    #bundle;
+    #authority;
+    #verification;
+    #observed;
+    constructor(key, scope, bundle, authority, verification, observed) {
+        if (key !== token)
+            refuse("receipt_token_required");
+        this.#scope = { ...scope };
+        this.#bundle = bundle;
+        this.#authority = authority;
+        this.#verification = verification;
+        this.#observed = observed;
+        Object.freeze(this);
+    }
+    static prepare(context, input) {
+        if (!(input.bundle instanceof RetainedExecutionBundle) || input.bundle.descriptor.descriptor.id !== "mb-init"
+            || !(input.bytes instanceof Uint8Array) || !input.bytes.length || input.bytes.length > 1024 * 1024)
+            refuse("registered_memory_result_required");
+        if (context.db.isOwnedWriteTransaction?.())
+            refuse("preparation_outside_writer_required");
+        const value = context.db.readSnapshot(() => accepted(context, input.scope, input.bundle));
+        if (!value.data.bytes.equals(Buffer.from(input.bytes)))
+            refuse("accepted_result_bytes_changed");
+        const schema = JSON.parse(input.bundle.descriptor.stageBlob("review", "result_schema").toString("utf8"));
+        if (!new Ajv2020({ strict: true, strictRequired: false, validateFormats: false }).compile(schema)(value.value))
+            refuse("accepted_result_schema_changed");
+        const results = value.workers.map((worker, index) => validateMemoryReviewWorkResult(worker.bytes, input.bundle.engine(), { workId: worker.workId, packet: value.batch.works[index].payload.memory_review, references: value.registration.view.run_inputs }));
+        const references = value.workers.map(worker => ({ reviewer_work_id: worker.workId, input_sha256: value.registration.input_sha256,
+            result: worker.result, unit_ids: [results.find(result => result.work_id === worker.workId).unit_id] }));
+        assertMemoryInitialReviewProjection(value.value, value.registration.view, results, references);
+        const verification = PreparedAcceptedMemoryVerification.prepare(context, { ...input.scope, bytes: value.verify.bytes });
+        const run = assertPreparedRunBundleSqlAuthority(context, input.scope, input.bundle), root = run.run_root ?? run.run_dir;
+        // Generic settlement owns exact restoration of its own accepted result
+        // projection after a committed-but-unpublished outcome. Requiring that
+        // file here would prevent recovery of precisely that owned interruption.
+        const refs = value.workers.map(worker => worker.result);
+        const observed = ObservedMemorySources.capture({ run: root }, refs.map(ref => ({ root: "run", path: ref.path })));
+        const hashes = observed.hashes();
+        if (refs.some(ref => hashes.get(memorySourceKey("run", ref.path)) !== ref.sha256))
+            refuse("accepted_result_artifact_changed");
+        const prepared = new PreparedAcceptedMemoryInitialReview(token, input.scope, input.bundle, hybridDigest(value), verification, observed);
+        prepared.assertCustody(context);
+        return prepared;
+    }
+    assertCustody(context) {
+        this.#verification.assertCustody(context);
+        if (hybridDigest(accepted(context, this.#scope, this.#bundle)) !== this.#authority)
+            refuse("accepted_review_custody_changed");
+    }
+    /** Retained reviewer inputs, not a recapture of today's workspace. */
+    reviewedSources(context) {
+        this.assertCustody(context);
+        return structuredClone(accepted(context, this.#scope, this.#bundle).registration.view.run_inputs);
+    }
+    finalChecks(context) { this.assertCustody(context); return this.#verification.finalChecks(context); }
+    revalidate(context) { this.assertCustody(context); this.#verification.revalidate(context); this.#observed.revalidate(); this.assertCustody(context); }
+}

package/dist/services/memory-review-registration.js

@@ -0,0 +1,108 @@
+import { AppError } from "../shared/errors.js";
+import { appendAudit } from "./audit.js";
+import { hybridDigest } from "./hybrid-contracts.js";
+import { PreparedMemoryInitialReviewInputs } from "./memory-review-inputs.js";
+import { addWorkBatch, prepareWorkBatch, readWorkBatchCustody } from "./work-registry.js";
+export const memoryReviewWorkerSchema = "dd-flow/memory-review-work-result@1";
+const event = "memory.review_registration";
+function refuse(reason) {
+    throw new AppError("memory_review_registration_invalid", "Memory reviewer allocation lacks immutable wave custody", 2, { reason, effect: "no_effect" });
+}
+/** One receipt per wave/attempt/root, never chosen by an agent-supplied request
+ * key. Generic Work membership retains the Stage cycle; wave identity is owned
+ * here and cannot impersonate the SDLC repair-cycle mechanism.
+ */
+function selected(context, scope, wave) {
+    const rows = context.db.all("SELECT payload_json FROM audit_events WHERE project_id=? AND event_type=? AND json_extract(payload_json,'$.run_id')=? AND json_extract(payload_json,'$.scope.attempt')=? AND json_extract(payload_json,'$.scope.parent_work_id')=? AND json_extract(payload_json,'$.wave')=? LIMIT 2", [scope.project_id, event, scope.run_id, scope.attempt, scope.parent_work_id, wave]);
+    if (!rows.length)
+        return null;
+    if (rows.length !== 1 || Buffer.byteLength(rows[0].payload_json) > 2 * 1024 * 1024)
+        refuse("ambiguous_or_unbounded_registration");
+    try {
+        const receipt = JSON.parse(rows[0].payload_json);
+        if (receipt.schema_id !== "dd-flow/memory-review-registration@1" || receipt.run_id !== scope.run_id
+            || hybridDigest(receipt.scope) !== hybridDigest(scope) || receipt.wave !== wave || receipt.view.wave !== wave
+            || hybridDigest(receipt.view.scope) !== hybridDigest(scope) || hybridDigest(receipt.view) !== receipt.input_sha256
+            || !receipt.work_ids || typeof receipt.work_ids !== "object" || Array.isArray(receipt.work_ids)
+            || Object.keys(receipt.work_ids).length > 256 || Object.values(receipt.work_ids).some(id => typeof id !== "string")
+            || new Set(Object.values(receipt.work_ids)).size !== Object.keys(receipt.work_ids).length)
+            refuse("changed_registration");
+        const batch = memoryReviewBatch(receipt.view);
+        if (hybridDigest(batch.works) !== receipt.batch_sha256 || batch.works.length !== Object.keys(receipt.work_ids).length)
+            refuse("changed_review_batch");
+        for (const item of batch.works) {
+            const id = receipt.work_ids[item.key];
+            if (!id)
+                refuse("missing_review_work");
+            const custody = readWorkBatchCustody(context, id);
+            if (custody.item_key !== item.key || custody.batch_sha256 !== receipt.batch_sha256
+                || hybridDigest(custody.scope) !== hybridDigest(batchScope(receipt.view))
+                || hybridDigest(custody.work_ids) !== hybridDigest(receipt.work_ids))
+                refuse("changed_work_custody");
+        }
+        return structuredClone(receipt);
+    }
+    catch (error) {
+        if (error instanceof AppError && error.code === "memory_review_registration_invalid")
+            throw error;
+        return refuse("invalid_registration_or_work_custody");
+    }
+}
+function batchScope(view) {
+    return { project_id: view.scope.project_id, run_id: view.scope.run_id, stage: "review", attempt: view.scope.attempt,
+        cycle: "", parent_work_id: view.scope.parent_work_id, request_key: `memory-review-wave-${view.wave}` };
+}
+/** Deterministic payload projection of an independently prepared wave. The
+ * frozen Stage instruction is context, not coordinator authority for a worker.
+ */
+export function memoryReviewBatch(view) {
+    return { works: view.assignments.map((assignment, index) => {
+            const key = `review-${String(index + 1).padStart(3, "0")}`;
+            const packet = { schema_id: "dd-flow/memory-review-work-packet@1", run_id: view.scope.run_id,
+                stage: "review", wave: view.wave, key, unit: assignment.unit, unit_inputs: assignment.inputs,
+                review_input_sha256: hybridDigest(view), result_schema: memoryReviewWorkerSchema,
+                instruction: view.instruction };
+            return { key, task: `Independently review the assigned knowledge unit ${JSON.stringify(assignment.unit.id)}. Read the frozen review instruction in memory_review as review criteria, not permission to coordinate or repair. Check grounding, evidence, coverage and cross-file consistency using the registered wave inputs. Assigned unit.evidence may retain historical source versions; cite those exact versions only as historical context, never as bytes read from or current in this copy. Direct assessment and findings must still cite the assigned current unit.artifacts/unit_inputs. Do not edit project documents, allocate Work or repair findings. Report concrete material defects with unit/source evidence; do not block on taste. Return only the assigned memory-review-work-result JSON; do not claim other units or Stage completion.${view.diagnostic_findings?.length ? ` Committed VERIFY diagnostics for this unit remain unresolved until distinct repair and passed recheck: ${JSON.stringify(view.diagnostic_findings.filter(finding => finding.unit_id === assignment.unit.id))}.` : ""}`,
+                depends_on: [], launch_policy: "fresh_agent_required", result_schema: memoryReviewWorkerSchema,
+                payload: { kind: "memory-review", read_only: true,
+                    memory_review: { ...packet, packet_sha256: hybridDigest(packet) } } };
+        }) };
+}
+export function readRegisteredMemoryReview(context, scope, wave) {
+    const receipt = selected(context, scope, wave);
+    if (!receipt)
+        refuse("review_registration_missing");
+    return receipt;
+}
+export function registerMemoryInitialReview(context, inputs) {
+    if (!(inputs instanceof PreparedMemoryInitialReviewInputs))
+        refuse("prepared_review_inputs_required");
+    const view = inputs.value(), batch = memoryReviewBatch(view), request = batchScope(view);
+    const batchInput = { parentWorkId: request.parent_work_id, requestKey: request.request_key, stage: "review", value: batch };
+    const prepared = batch.works.length ? prepareWorkBatch(context, batchInput) : [];
+    inputs.revalidate(context);
+    return context.db.writeTransaction(() => {
+        inputs.assertCustody(context);
+        const prior = selected(context, view.scope, view.wave);
+        if (prior && (prior.input_sha256 !== inputs.sha256 || prior.batch_sha256 !== hybridDigest(batch.works)))
+            refuse("review_wave_conflict");
+        if (!prior && context.db.get("SELECT 1 FROM works w JOIN stage_work_memberships m ON m.work_id=w.work_id WHERE w.project_id=? AND w.run_id=? AND w.parent_work_id=? AND m.stage='review' AND m.attempt=? AND json_extract(w.payload_json,'$.kind')='memory-review' AND json_extract(w.payload_json,'$.memory_review.wave')=? LIMIT 1", [request.project_id, request.run_id, request.parent_work_id, request.attempt, view.wave]))
+            refuse("review_registration_missing");
+        const allocated = batch.works.length ? addWorkBatch(context, { ...batchInput, prepared }) : { work_ids: {}, replayed: Boolean(prior) };
+        const workIds = allocated.work_ids;
+        if (prior) {
+            if (hybridDigest(prior.work_ids) !== hybridDigest(workIds))
+                refuse("changed_allocation");
+        }
+        else {
+            if (allocated.replayed)
+                refuse("review_registration_missing");
+            const receipt = { schema_id: "dd-flow/memory-review-registration@1", run_id: request.run_id,
+                scope: view.scope, wave: view.wave, input_sha256: inputs.sha256, view,
+                batch_sha256: hybridDigest(batch.works), work_ids: workIds };
+            appendAudit(context, { projectId: request.project_id, eventType: event, payload: receipt });
+        }
+        const retained = readRegisteredMemoryReview(context, view.scope, view.wave);
+        return { input_sha256: retained.input_sha256, wave: view.wave, work_ids: { ...retained.work_ids }, replayed: Boolean(prior) };
+    });
+}

package/dist/services/memory-review-work-custody.js

@@ -0,0 +1,124 @@
+import { createHash } from "node:crypto";
+import { AppError } from "../shared/errors.js";
+import { appendAudit } from "./audit.js";
+import { hybridDigest } from "./hybrid-contracts.js";
+import { runtimeHarness } from "./execution-policy.js";
+import { recoveryGuard } from "./run-recovery-guard.js";
+import { prepareMemoryReviewWorkInput } from "./memory-review-work-input.js";
+import { memoryReviewWorkerSchema } from "./memory-review-registration.js";
+import { validateMemoryReviewWorkResult } from "./memory-review-work-results.js";
+import { readWorkBatchCustody } from "./work-registry.js";
+const hash = (bytes) => createHash("sha256").update(bytes).digest("hex");
+function refuse(reason) {
+    throw new AppError("memory_review_work_custody_invalid", "Reviewer settlement lacks independent Work and Session custody", 1, { reason, effect: "no_effect" });
+}
+/** Current physical settlement proof. All reads are SQL-only; the external
+ * copied workspace is rechecked separately before the settlement writer.
+ */
+function physical(context, work, owner, harness) {
+    const scope = owner.registration().scope;
+    const rows = context.db.all("SELECT ws.id,ws.session_id,ws.hook_event_id,ws.start_receipt_json,s.harness,s.provider_session_id FROM work_sessions ws JOIN sessions s ON s.session_id=ws.session_id AND s.project_id=? JOIN runs r ON r.id=s.run_id AND r.project_id=s.project_id WHERE ws.work_id=? AND ws.status='running' AND s.run_id=? AND s.worker_id=? AND s.harness=? AND s.status='active' AND s.current_stage='work' AND s.project_root=r.project_root AND s.workspace_path=r.workspace_root LIMIT 2", [work.project_id, work.work_id, work.run_id, work.work_id, harness]);
+    if (rows.length !== 1 || !rows[0].provider_session_id || typeof rows[0].start_receipt_json !== "string"
+        || Buffer.byteLength(rows[0].start_receipt_json) > 8 * 1024 * 1024)
+        refuse("active_reviewer_session_required");
+    const selected = rows[0];
+    if (!context.db.get("SELECT 1 FROM works WHERE project_id=? AND run_id=? AND work_id=? AND status='running'", [work.project_id, work.run_id, work.work_id]))
+        refuse("review_work_not_running");
+    if (!context.db.get("SELECT 1 FROM hook_events WHERE project_id=? AND event_key=? AND session_id=? AND harness=? AND provider_session_id=? AND status='claimed' AND event_name='PreToolUse'", [work.project_id, selected.hook_event_id, selected.session_id, selected.harness, selected.provider_session_id]))
+        refuse("review_start_hook_missing");
+    // Check physical identity, not just distinct internal keys or an agent's
+    // assertion that it did not author the documents.
+    if (context.db.get("SELECT 1 FROM work_sessions ws JOIN works w ON w.work_id=ws.work_id JOIN sessions s ON s.session_id=ws.session_id AND s.project_id=w.project_id WHERE w.project_id=? AND w.run_id=? AND w.work_id<>? AND s.harness=? AND s.provider_session_id=? LIMIT 1", [work.project_id, work.run_id, work.work_id, harness, selected.provider_session_id]))
+        refuse("reviewer_session_not_independent");
+    try {
+        const receipt = JSON.parse(selected.start_receipt_json);
+        if (receipt.version !== 2 || typeof receipt.context !== "string" || receipt.context_sha256 !== hash(receipt.context)
+            || receipt.generation !== owner.input.generation)
+            refuse("review_start_receipt_changed");
+        const input = JSON.parse(receipt.context);
+        if (input.run_id !== work.run_id || input.work_id !== work.work_id || input.parent_work_id !== scope.parent_work_id
+            || input.read_only !== true || input.result_schema !== memoryReviewWorkerSchema
+            || hybridDigest(input.review_input) !== hybridDigest(owner.input))
+            refuse("review_start_input_changed");
+    }
+    catch (error) {
+        if (error instanceof AppError && error.code === "memory_review_work_custody_invalid")
+            throw error;
+        return refuse("invalid_review_start_receipt");
+    }
+    return selected;
+}
+/** Registered reviewer result owner. Corrected waves consume their separately
+ * admitted current view and check receipt, never original compose byte custody.
+ * This class writes no files and dispatches no provider.
+ */
+export class PreparedRegisteredMemoryReviewWorkResult {
+    workId;
+    sha256;
+    #bytes;
+    #value;
+    #work;
+    #owner;
+    #allocation;
+    #physical;
+    #harness;
+    constructor(bytes, value, work, owner, allocation, selected, harness) {
+        this.#bytes = Buffer.from(bytes);
+        this.#value = structuredClone(value);
+        this.#work = { ...work };
+        this.#owner = owner;
+        this.#allocation = structuredClone(allocation);
+        this.#physical = { ...selected };
+        this.#harness = harness;
+        this.workId = work.work_id;
+        this.sha256 = hash(bytes);
+        Object.freeze(this);
+    }
+    static prepare(context, input) {
+        if (!(input.bytes instanceof Uint8Array) || !input.bytes.byteLength || input.bytes.byteLength > 1024 * 1024)
+            refuse("invalid_result_bytes");
+        const work = context.db.get("SELECT * FROM works WHERE work_id=?", [input.workId]);
+        if (!work || work.result_schema !== memoryReviewWorkerSchema)
+            refuse("registered_reviewer_work_required");
+        const run = context.db.get("SELECT project_root FROM runs WHERE project_id=? AND id=?", [work.project_id, work.run_id]);
+        if (!run)
+            refuse("owned_run_required");
+        const generation = recoveryGuard(context, work.project_id, work.run_id)?.generation ?? 0;
+        const owner = prepareMemoryReviewWorkInput(context, work, run, generation);
+        const bytes = Buffer.from(input.bytes), value = validateMemoryReviewWorkResult(bytes, owner.bundle.engine(), {
+            workId: work.work_id, packet: owner.packet(), references: owner.input.run_inputs
+        });
+        const harness = runtimeHarness(owner.bundle.execution.work("review").worker);
+        const allocation = readWorkBatchCustody(context, work.work_id), selected = physical(context, work, owner, harness);
+        const prepared = new PreparedRegisteredMemoryReviewWorkResult(bytes, value, work, owner, allocation, selected, harness);
+        prepared.assertCustody(context);
+        return prepared;
+    }
+    bytes() { return Buffer.from(this.#bytes); }
+    value() { return structuredClone(this.#value); }
+    assertCustody(context) {
+        this.#owner.assertCustody(context);
+        if (hybridDigest(readWorkBatchCustody(context, this.workId)) !== hybridDigest(this.#allocation)
+            || hybridDigest(physical(context, this.#work, this.#owner, this.#harness)) !== hybridDigest(this.#physical))
+            refuse("review_work_custody_changed");
+    }
+    revalidate(context) { this.#owner.revalidate(context); this.assertCustody(context); }
+    assertSettlementScope(context, sessionId, workSessionId) {
+        this.assertCustody(context);
+        if (sessionId !== this.#physical.session_id || workSessionId !== this.#physical.id)
+            refuse("foreign_reviewer_session");
+    }
+    recordSettlement(context, sessionId, workSessionId) {
+        this.assertSettlementScope(context, sessionId, workSessionId);
+        const receipt = this.#owner.registration();
+        if (context.db.get("SELECT 1 FROM audit_events WHERE project_id=? AND event_type='memory.review_work_settlement' AND json_extract(payload_json,'$.run_id')=? AND json_extract(payload_json,'$.work_id')=? LIMIT 1", [this.#work.project_id, this.#work.run_id, this.workId]))
+            refuse("review_settlement_already_recorded");
+        appendAudit(context, { projectId: this.#work.project_id, eventType: "memory.review_work_settlement", payload: {
+                schema_id: "dd-flow/memory-review-work-settlement@1", run_id: this.#work.run_id, work_id: this.workId,
+                work_session_id: workSessionId, session_id: sessionId, harness: this.#harness, provider_session_id: this.#physical.provider_session_id,
+                scope: receipt.scope, wave: receipt.wave, unit_id: this.#value.unit_id,
+                input_sha256: receipt.input_sha256, registration_sha256: hybridDigest(receipt), allocation_sha256: hybridDigest(this.#allocation),
+                start_receipt_sha256: hash(this.#physical.start_receipt_json), result_sha256: this.sha256
+            } });
+    }
+}