@deksden-com/dd-flow-cli 0.9.0-beta.1 → 0.9.0-beta.100

package/dist/services/stage-lifecycle.js

@@ -5,19 +5,31 @@ import { spawnSync } from "node:child_process";
 import { requireProjectByRoot } from "./projects.js";
 import { appendAudit } from "./audit.js";
 import { persistProtocolState, requireProtocol, readProtocolRuntimeState } from "./protocols.js";
-import { attachFlowRunStage, completeFlowRunStage, getFlowRunStatus, startFlowRun } from "./runs.js";
+import { attachFlowRunStage, prepareFlowRunStart, prepareFlowRunStageAttachment, prepareStageDirectory, completeFlowRunStage, getFlowRunStatus, startFlowRun } from "./runs.js";
 import { validateSchema } from "./schema-validation.js";
 import { reconcileSessionCoverage, registerFlowSession } from "./sessions.js";
-import { usageForRun } from "./usage.js";
-import { boundCanonicalPlan } from "./plan-runtime.js";
+import { recalculateRunUsage, usageForRun } from "./usage.js";
+import { boundCanonicalPlan, prepareCanonicalPlan } from "./plan-runtime.js";
+import { prepareJsonFile, prepareJsonSchema, prepareOutputDirectory, prepareOutputFile, prepareTextFile } from "../cli/input-preparation.js";
 import { AppError } from "../shared/errors.js";
-import { planJsonPath, resolveProjectRoot } from "../storage/paths.js";
+import { planJsonPath, projectHome, resolveProjectRoot } from "../storage/paths.js";
 import { resolveCanonRoot } from "./canon.js";
 import { preflightMemoryPermissions } from "./memory-permissions.js";
 import { registerProject } from "./projects.js";
 import { registerProtocol } from "./protocols.js";
 import { previewNextEntityId } from "./ids.js";
 import { hookSessionIdentity, sessionIdForHookEvent } from "./hooks.js";
+import { assertRunMutationAllowed } from "./run-recovery.js";
+function stageUsageProjection(context, view, stage, startedAt) {
+    if (!startedAt)
+        return { status: "unavailable", input_tokens: null, cached_input_tokens: null, output_tokens: null, total_tokens: null, session_count: 0, observed_at: context.now() };
+    const value = recalculateRunUsage(context, { projectId: view.run.project_id, runId: view.run.id, stage: { name: stage, startedAt, completedAt: context.now() } });
+    const totals = value.totals, coverage = value.coverage;
+    const count = (name) => typeof coverage?.[name] === "number" ? coverage[name] : 0;
+    const measured = count("measured"), other = Object.values(coverage ?? {}).reduce((total, item) => total + (typeof item === "number" ? item : 0), 0) - measured;
+    const tokens = (name) => typeof totals?.[name] === "number" ? totals[name] : null;
+    return { status: measured === 0 ? "unavailable" : other > 0 || ["input_tokens", "cache_read_input_tokens", "output_tokens", "total_tokens"].some(name => tokens(name) === null) ? "partial" : "measured", input_tokens: tokens("input_tokens"), cached_input_tokens: tokens("cache_read_input_tokens"), output_tokens: tokens("output_tokens"), total_tokens: tokens("total_tokens"), session_count: Array.isArray(value.sessions) ? value.sessions.length : 0, observed_at: typeof value.observed_at === "string" ? value.observed_at : context.now() };
+}
 const stagePromptSections = [
     "stage_identity",
     "authoritative_runtime_facts",
@@ -28,61 +40,30 @@ const stagePromptSections = [
     "work_contract",
     "completion_contract"
 ];
-function bootstrapStageRun(context, projectRoot, input) {
-    if (input.stage !== "specify") {
-        throw new AppError("validation", "--bootstrap currently starts the initial specify stage only", 2, { stage: input.stage });
-    }
-    const subject = input.bootstrap?.subject.trim();
-    if (!subject)
-        throw new AppError("usage", "--bootstrap requires --subject", 2);
+function bootstrapStageRun(context, projectRoot, bootstrap, intakeMarkdown) {
     registerProject(context, { root: projectRoot });
-    const preview = previewNextEntityId(context, { projectRoot, type: "protocol", slug: subject });
-    const protocolId = preview.entity.id;
-    registerProtocol(context, { handshakeId: protocolId, projectRoot });
-    const started = startFlowRun(context, {
-        projectRoot,
-        flowKind: "mb_sdlc",
-        subjectType: "protocol",
-        subjectId: protocolId,
-        slug: subject,
-        nextAction: "run_specify"
-    });
-    const intakeFile = input.bootstrap?.intakeFile;
-    if (intakeFile) {
-        const source = path.resolve(intakeFile);
-        if (!fs.existsSync(source) || !fs.statSync(source).isFile()) {
-            throw new AppError("not_found", "--intake-file must point to an existing file", 1, { intake_file: intakeFile });
-        }
-        const intakeDir = path.join(started.run.run_home_path ?? path.dirname(started.run.id), "intake");
+    registerProtocol(context, { handshakeId: bootstrap.protocolId, projectRoot });
+    const started = startFlowRun(context, bootstrap.startInput, bootstrap.start);
+    if (intakeMarkdown !== undefined) {
+        if (!started.run.run_root)
+            throw new AppError("runtime_missing", "New RUN has no artifact root", 1, { run_id: started.run.id });
+        const intakeDir = path.join(started.run.run_root, "intake");
         fs.mkdirSync(intakeDir, { recursive: true });
-        fs.copyFileSync(source, path.join(intakeDir, "user-request.md"));
+        fs.writeFileSync(path.join(intakeDir, "user-request.md"), intakeMarkdown);
     }
     return started.run.id;
 }
-function stagePreflight(projectRoot, stageRoot) {
+function stagePreflight(projectRoot) {
     const memoryBank = preflightMemoryPermissions({
         root: projectRoot,
         memoryBank: ".memory-bank",
         flow: "custom",
-        mode: "write",
+        mode: "read",
         targets: [{ path: ".memory-bank", mode: "read" }]
     });
-    const probe = path.join(stageRoot, `.dd-flow-permission-${crypto.randomUUID()}`);
-    try {
-        fs.writeFileSync(probe, "");
-        fs.renameSync(probe, `${probe}.renamed`);
-        fs.rmSync(`${probe}.renamed`);
-        return { ...memoryBank, ok: memoryBank.ok === true, stage_workspace: { path: stageRoot, status: "passed" } };
-    }
-    catch (error) {
-        for (const candidate of [probe, `${probe}.renamed`]) {
-            try {
-                fs.rmSync(candidate, { force: true });
-            }
-            catch { /* best effort */ }
-        }
-        return { ...memoryBank, ok: false, stage_workspace: { path: stageRoot, status: "failed", message: String(error) } };
-    }
+    if (memoryBank.ok !== true)
+        throw new AppError("permission_preflight_failed", "Stage project context is not readable", 1, { preflight: memoryBank });
+    return memoryBank;
 }
 function flowKindForStage(stage) {
     return ["code", "implementation", "readiness", "merge"].includes(stage) ? "implementation" : "planning";
@@ -101,23 +82,57 @@ function runtimeFacts(view, projectRoot) {
         git: view.index.execution?.git ?? { branch: null, head: null, status: "unavailable" }
     };
 }
-export function startStage(context, input) {
+export function prepareLegacyStageStart(context, input, intakeMarkdown) {
+    if (input.bootstrap && input.stage !== "specify")
+        throw new AppError("validation", "--bootstrap currently starts the initial specify stage only", 2);
+    if (input.bootstrap && !input.bootstrap.subject?.trim())
+        throw new AppError("usage", "--bootstrap requires --subject", 2);
+    if (!input.bootstrap && !input.runId)
+        throw new AppError("usage", "stage start requires a RUN id or --bootstrap", 2);
+    if (input.dir !== undefined)
+        prepareStageDirectory(input.dir);
+    const intake = intakeMarkdown ?? (input.bootstrap?.intakeFile ? prepareTextFile(input.bootstrap.intakeFile, "SPECIFY intake").text : undefined);
+    const projectRoot = resolveProjectRoot(input.projectRoot);
+    const retained = !input.bootstrap && input.runId ? runView(getFlowRunStatus(context, { projectRoot, runId: input.runId })) : null;
+    const dir = input.dir ?? defaultStageDir(input.stage, retained?.run.flow_kind ?? "mb_sdlc");
+    if (retained) {
+        prepareFlowRunStageAttachment(context, { projectRoot, runId: retained.run.id, stage: input.stage, dir, status: "running", dataSchemaId: dataSchemaForStage(input.stage) });
+        const root = path.join(runHomePath(retained.run), dir);
+        for (const name of ["stage-prompt.md", "stage-prompt.json", "stage-start.json", "stage-input.json"])
+            prepareOutputFile(path.join(root, name));
+        if (retained.run.subject.type === "protocol")
+            readProtocolRuntimeState(context, requireProtocol(context, retained.run.subject.id, retained.run.project_id));
+    }
+    const preflight = stagePreflight(projectRoot);
+    const sources = stageInstructionSources(context, projectRoot, retained?.run.flow_kind ?? "mb_sdlc", input.stage).map(source => ({ ...source, text: fs.existsSync(source.absolute) ? fs.readFileSync(source.absolute, "utf8").trim() : "(unavailable)" }));
+    let bootstrap;
+    if (input.bootstrap) {
+        const project = context.db.get("SELECT id FROM projects WHERE root = ?", [projectRoot]);
+        prepareOutputDirectory(project ? projectHome(context.ddFlowHome, project.id) : path.join(context.ddFlowHome, "projects"));
+        const preview = previewNextEntityId(context, { projectRoot, type: "protocol", slug: input.bootstrap.subject });
+        const startInput = { projectRoot, flowKind: "mb_sdlc", subjectType: "protocol", subjectId: preview.entity.id, slug: input.bootstrap.subject, nextAction: "run_specify" };
+        bootstrap = { protocolId: preview.entity.id, startInput, start: prepareFlowRunStart(context, startInput) };
+    }
+    return { intakeMarkdown: intake, projectRoot, retained, dir, preflight, sources, bootstrap };
+}
+export function startStage(context, input, prepared = prepareLegacyStageStart(context, input)) {
     if (input.requireSessionBinding && !input.hookEventId) {
         throw new AppError("trusted_session_binding_required", "This stage requires a trusted harness lifecycle binding; run it from a controlled Session with the dd-flow adapter enabled", 1);
     }
-    const projectRoot = resolveProjectRoot(input.projectRoot);
+    const { projectRoot, retained, dir, preflight, sources } = prepared;
+    if (retained)
+        prepareFlowRunStageAttachment(context, { projectRoot, runId: retained.run.id, stage: input.stage, dir: input.dir ?? defaultStageDir(input.stage, retained.run.flow_kind), status: "running", dataSchemaId: dataSchemaForStage(input.stage) });
     let requiredSessionId = null;
     let requiredIdentity = null;
     if (input.requireSessionBinding) {
-        registerProject(context, { root: projectRoot });
         requiredIdentity = hookSessionIdentity(context, requireProjectByRoot(context, projectRoot).id, input.hookEventId);
         requiredSessionId = requiredIdentity.sessionId;
     }
-    const runId = input.bootstrap ? bootstrapStageRun(context, projectRoot, input) : input.runId;
+    const runId = prepared.bootstrap ? bootstrapStageRun(context, projectRoot, prepared.bootstrap, prepared.intakeMarkdown) : input.runId;
     if (!runId)
         throw new AppError("usage", "stage start requires a RUN id or --bootstrap", 2);
-    const before = runView(getFlowRunStatus(context, { projectRoot, runId }));
-    const dir = input.dir ?? defaultStageDir(input.stage, before.run.flow_kind);
+    const before = retained ?? runView(getFlowRunStatus(context, { projectRoot, runId }));
+    assertRunMutationAllowed(context, before.run.project_id, before.run.id);
     const attached = runView(attachFlowRunStage(context, {
         projectRoot,
         runId,
@@ -130,9 +145,6 @@ export function startStage(context, input) {
     const stageRoot = path.join(runHome, dir);
     ensureWithin(runHome, stageRoot, "stage root");
     fs.mkdirSync(stageRoot, { recursive: true });
-    const preflight = stagePreflight(projectRoot, stageRoot);
-    if (preflight.ok !== true)
-        throw new AppError("permission_preflight_failed", "Stage workspace is not writable", 1, { preflight });
     if (attached.run.subject.type === "protocol") {
         syncProtocolLifecycle(context, attached.run.project_id, attached.run.subject.id, input.stage, "running");
     }
@@ -140,7 +152,7 @@ export function startStage(context, input) {
     if (sessionId) {
         const identity = requiredIdentity ?? (input.hookEventId ? hookSessionIdentity(context, attached.run.project_id, input.hookEventId) : null);
         registerFlowSession(context, {
-            sessionId,
+            hookEventId: input.hookEventId,
             payloadJson: JSON.stringify({
                 project_root: projectRoot,
                 harness: identity?.harness ?? "codex-desktop",
@@ -165,7 +177,7 @@ export function startStage(context, input) {
         });
     }
     const promptPath = path.join(stageRoot, "stage-prompt.md");
-    const prompt = composeStagePrompt(context, projectRoot, before, attached, input.stage, dir, preflight);
+    const prompt = composeStagePrompt(context, projectRoot, before, attached, input.stage, dir, preflight, sources);
     atomicWrite(promptPath, prompt);
     const semanticInputPath = path.join(stageRoot, "stage-input.json");
     if (!fs.existsSync(semanticInputPath)) {
@@ -176,7 +188,6 @@ export function startStage(context, input) {
     const aspectMapPath = path.join(stageRoot, "aspect-map.json");
     const attempt = attached.index.stage_runs?.find((stage) => stage.stage === input.stage)?.attempt ?? "try-001";
     const attemptNumber = Number(attempt.replace("try-", "")) || 1;
-    const sources = stageInstructionSources(context, projectRoot, attached.run.flow_kind, input.stage);
     atomicWrite(promptDataPath, {
         schema_id: "dd-flow/stage-prompt@2",
         run_id: attached.run.id,
@@ -216,7 +227,7 @@ export function startStage(context, input) {
         })),
         worker_prompt_markdown: prompt
     });
-    validateSchema({ schemaName: "stage-prompt", file: promptDataPath, projectRoot, runId: attached.run.id, ddFlowHome: context.ddFlowHome });
+    validateSchema({ schemaName: "stage-prompt", file: promptDataPath, projectRoot, runId: attached.run.id, runRoot: runHome, ddFlowHome: context.ddFlowHome });
     atomicWrite(path.join(stageRoot, "stage-start.json"), {
         schema_id: "dd-flow/stage-start@2",
         run_id: attached.run.id,
@@ -255,12 +266,13 @@ export function startStage(context, input) {
         lifecycle: "stage start -> semantic work -> stage finish"
     };
 }
-export function finishStage(context, input) {
+export function prepareStageFinish(context, input) {
     const projectRoot = resolveProjectRoot(input.projectRoot);
     if (!input.runId)
         throw new AppError("usage", "stage finish requires a RUN id", 2);
     const runId = input.runId;
     const view = runView(getFlowRunStatus(context, { projectRoot, runId }));
+    assertRunMutationAllowed(context, view.run.project_id, view.run.id);
     const existing = view.index.stage_runs?.find((stage) => stage.stage === input.stage);
     if (!existing) {
         throw new AppError("not_found", `Run stage is not attached: ${input.stage}`, 1, { run_id: view.run.id, stage: input.stage });
@@ -269,31 +281,38 @@ export function finishStage(context, input) {
     const runHome = runHomePath(view.run);
     const stageRoot = path.join(runHome, dir);
     ensureWithin(runHome, stageRoot, "stage root");
-    fs.mkdirSync(stageRoot, { recursive: true });
     const semanticFile = resolveStageFile(input.semanticFile ?? "@stage/stage-input.json", stageRoot, runHome);
-    const receipt = beginFinishReceipt(context, stageRoot, semanticFile, view.run.id, input.stage);
+    ensureWithin(runHome, semanticFile, "semantic file");
+    const source = prepareJsonSchema(semanticFile, "Stage finish input", { schemaName: "stage-finish-input", projectRoot, runId, runRoot: runHome, ddFlowHome: context.ddFlowHome });
+    const semantic = source.value;
+    const status = stringValue(semantic.status) ?? "done";
+    if (!["done", "waiting_for_user", "blocked", "failed"].includes(status)) {
+        throw new AppError("validation", "Stage finish status must be done, waiting_for_user, blocked, or failed", 2, { status });
+    }
+    validateStageOutcome(input.stage, status, semantic);
+    const planFinish = input.stage === "plan" ? preparePlanFinish(context, projectRoot, view, stageRoot) : undefined;
+    return { projectRoot, runId, view, existing, runHome, stageRoot, semanticFile, semantic, status, source, planFinish };
+}
+export function finishStage(context, input, prepared = prepareStageFinish(context, input)) {
+    const { projectRoot, runId, view, existing, runHome, stageRoot, semanticFile, semantic, status, source, planFinish } = prepared;
+    assertRunMutationAllowed(context, view.run.project_id, view.run.id);
+    fs.mkdirSync(stageRoot, { recursive: true });
+    const receipt = beginFinishReceipt(context, stageRoot, semanticFile, view.run.id, input.stage, source.text);
     try {
-        validateSchema({ schemaName: "stage-finish-input", file: semanticFile, projectRoot, runId, ddFlowHome: context.ddFlowHome });
-        const semantic = readSemanticFile(semanticFile, runHome);
-        const status = stringValue(semantic.status) ?? "done";
-        if (!["done", "waiting_for_user", "blocked", "failed"].includes(status)) {
-            throw new AppError("validation", "Stage finish status must be done, waiting_for_user, blocked, or failed", 2, { status });
-        }
-        validateStageOutcome(input.stage, status, semantic);
         const coverage = workerCoverage(context, view.run.project_id, view.run.id);
         if (coverage.jobs.missing?.length) {
             throw new AppError("worker_jobs_incomplete", "Stage finish requires all declared worker jobs", 1, { coverage });
         }
         const lint = runTargetedMemoryBankLint(projectRoot);
-        const planFinish = input.stage === "plan"
-            ? preparePlanFinish(context, projectRoot, view, stageRoot)
-            : undefined;
+        if (planFinish)
+            boundCanonicalPlan(context, { projectId: view.run.project_id, protocolId: view.run.subject.id, planPath: planFinish.plan_path }, planFinish.canonical);
+        const stageUsage = stageUsageProjection(context, view, input.stage, existing.started_at);
         const report = buildStageReport(context, view, input.stage, status, semantic, stageRoot, lint, planFinish);
         const dataPath = path.join(stageRoot, "stage-report.json");
         const reportPath = path.join(stageRoot, "stage-report.md");
         const htmlPath = path.join(stageRoot, "stage-report.html");
+        validateSchema({ schemaName: stageReportSchemaName(input.stage, planFinish), file: dataPath, data: report, projectRoot, runId, runRoot: runHome, ddFlowHome: context.ddFlowHome });
         atomicWrite(dataPath, report);
-        validateSchema({ schemaName: stageReportSchemaName(input.stage, planFinish), file: dataPath, projectRoot, runId, ddFlowHome: context.ddFlowHome });
         atomicWrite(reportPath, renderMarkdown(report));
         atomicWrite(htmlPath, renderHtml(projectRoot, report));
         if (view.run.subject.type === "protocol") {
@@ -308,7 +327,8 @@ export function finishStage(context, input) {
             stageReport: htmlPath,
             data: dataPath,
             dataSchemaId: String(report.schema_id),
-            report: reportPath
+            report: reportPath,
+            usage: stageUsage
         });
         finishReceipt(receipt, { outcome: "accepted", result: { status, report: dataPath } });
         appendAudit(context, {
@@ -410,7 +430,12 @@ function nextActionForProtocolStage(stage) {
     return `continue_${stage}`;
 }
 function runHomePath(run) {
-    return run.run_home_path ?? path.dirname(run.run_index_path);
+    if (!run.run_root)
+        throw new AppError("runtime_missing", "RUN has no artifact root", 1, { run_id: run.id });
+    return run.run_root;
+}
+function runStatePath(run) {
+    return path.join(runHomePath(run), "run.json");
 }
 export function defaultStageDir(stage, flowKind) {
     const normalized = stage === "implementation" ? "code" : stage;
@@ -473,12 +498,10 @@ function semanticInputTemplate(stage) {
         next_action: waiting ? "waiting_for_user: obtain the clarification packet" : "Continue to the next approved stage."
     };
 }
-function composeStagePrompt(context, projectRoot, before, current, stage, dir, preflight) {
+function composeStagePrompt(context, projectRoot, before, current, stage, dir, preflight, sources) {
     const project = requireProjectByRoot(context, projectRoot);
     const runHome = runHomePath(current.run);
-    const instructions = stageInstructionSources(context, projectRoot, current.run.flow_kind, stage).map(({ label, absolute }) => {
-        return fs.existsSync(absolute) ? `### ${label}\n\n${fs.readFileSync(absolute, "utf8").trim()}` : `### ${label}\n\n(unavailable)`;
-    }).join("\n\n");
+    const instructions = sources.map(({ label, text }) => `### ${label}\n\n${text}`).join("\n\n");
     const protocol = safeProtocolState(context, current.run.project_id, current.run.subject.id);
     return [
         "<stage_identity>",
@@ -501,7 +524,7 @@ function composeStagePrompt(context, projectRoot, before, current, stage, dir, p
         "</authoritative_runtime_facts>",
         "",
         "<preflight>",
-        `- Permission probe: ${String(preflight.ok === true ? "passed" : "failed")}.`,
+        `- Read-only permission check: ${String(preflight.ok === true ? "passed" : "failed")}.`,
         "- CLI compatibility was checked before this state-changing command.",
         "</preflight>",
         "",
@@ -574,16 +597,6 @@ function safeProtocolState(context, projectId, protocolId) {
         return undefined;
     }
 }
-function readSemanticFile(file, runHome) {
-    const resolved = path.resolve(file);
-    ensureWithin(runHome, resolved, "semantic file");
-    if (!fs.existsSync(resolved))
-        throw new AppError("not_found", "Semantic input file is missing", 1, { path: file });
-    const value = JSON.parse(fs.readFileSync(resolved, "utf8"));
-    if (!value || typeof value !== "object" || Array.isArray(value))
-        throw new AppError("validation", "Semantic input must be a JSON object", 2);
-    return value;
-}
 function validateStageOutcome(stage, status, semantic) {
     if (stage !== "specify")
         return;
@@ -595,17 +608,12 @@ function validateStageOutcome(stage, status, semantic) {
         throw new AppError("semantic_status_inconsistent", "SPECIFY done cannot contain unresolved structured questions", 2);
     }
 }
-function beginFinishReceipt(context, stageRoot, semanticFile, runId, stage) {
+function beginFinishReceipt(context, stageRoot, semanticFile, runId, stage, raw) {
     const receiptDir = path.join(stageRoot, "finish-receipts");
     fs.mkdirSync(receiptDir, { recursive: true });
     const number = fs.readdirSync(receiptDir).filter((file) => /^\d{3}\.json$/u.test(file)).length + 1;
     const receiptPath = path.join(receiptDir, `${String(number).padStart(3, "0")}.json`);
-    let raw = null;
-    try {
-        raw = fs.readFileSync(semanticFile, "utf8");
-    }
-    catch { /* receipt records the missing input below */ }
-    const semanticSha = raw === null ? null : crypto.createHash("sha256").update(raw).digest("hex");
+    const semanticSha = crypto.createHash("sha256").update(raw).digest("hex");
     atomicWrite(receiptPath, {
         schema_id: "dd-flow/stage-finish-receipt@1",
         run_id: runId,
@@ -702,7 +710,7 @@ function buildStageReport(context, view, stage, status, semantic, stageRoot, lin
     if (stage === "code" || stage === "implementation") {
         return {
             schema_id: "dd-flow/code-stage-report@2",
-            run: { run_id: view.run.id, run_state: view.run.run_index_path },
+            run: { run_id: view.run.id, run_state: runStatePath(view.run) },
             stage: { name: stage, dir: path.basename(stageRoot), status },
             project: { id: view.run.project_id, title: path.basename(view.run.project_root) },
             subject: { id: view.run.subject.id, title: view.run.subject.id },
@@ -712,7 +720,7 @@ function buildStageReport(context, view, stage, status, semantic, stageRoot, lin
                 summary: result,
                 next_action: stringValue(semantic.next_action) ?? "Proceed to readiness."
             },
-            breadcrumbs: [{ label: "RUN", href: view.run.run_index_path, status: "available" }],
+            breadcrumbs: [{ label: "RUN", href: runStatePath(view.run), status: "available" }],
             implemented_goals: [{ title: `Stage ${stage}`, summary: result }],
             acceptance_scenarios: acceptance.map((summary, index) => ({
                 id: `SCN-${stage}-${index + 1}`,
@@ -763,22 +771,18 @@ function buildStageReport(context, view, stage, status, semantic, stageRoot, lin
             memory_bank_scope: "changed_files_and_links_only",
             status: "passed"
         },
-        breadcrumbs: [{ label: "RUN", href: view.run.run_index_path, status: "available" }]
+        breadcrumbs: [{ label: "RUN", href: runStatePath(view.run), status: "available" }]
     };
 }
 function preparePlanFinish(context, projectRoot, view, stageRoot) {
     const planPath = planJsonPath(projectRoot, view.run.subject.id);
-    const canonical = boundCanonicalPlan(context, {
+    const canonical = prepareCanonicalPlan(context, {
         projectId: view.run.project_id,
         protocolId: view.run.subject.id,
         planPath
     });
     const aspectMapPath = path.join(stageRoot, "aspect-map.json");
-    if (!fs.existsSync(aspectMapPath)) {
-        throw new AppError("not_found", "PLAN aspect-map.json is missing", 1, { path: aspectMapPath });
-    }
-    const raw = fs.readFileSync(aspectMapPath, "utf8");
-    const value = JSON.parse(raw);
+    const { text: raw, value } = prepareJsonFile(aspectMapPath, "PLAN aspect map");
     if (!value || typeof value !== "object" || Array.isArray(value)) {
         throw new AppError("validation", "PLAN aspect-map.json must be a JSON object", 2, { path: aspectMapPath });
     }