@deksden-com/dd-flow-cli 0.9.0-beta.0 → 0.9.0-beta.7

package/dist/services/usage.js

@@ -3,6 +3,7 @@ import fs from "node:fs";
 import { parseJsonObject } from "../shared/json.js";
 import { resolveProjectRoot } from "../storage/paths.js";
 import { registerProject, requireProjectByRoot } from "./projects.js";
+import { publicSessionIdentity } from "./session-identity.js";
 export function ingestZcodeUsage(context, input) {
     return ingestHarnessUsage(context, input, { harness: "zcode-acp", label: "ZCode", idPrefix: "ZUSG", sourceKind: "zcode_session_usage_v1" });
 }
@@ -55,11 +56,11 @@ function ingestHarnessUsage(context, input, harness) {
         values.input, values.cacheRead, values.cacheWrite, values.output, values.reasoning, values.requests, values.errors,
         values.toolCalls, values.toolFailures, values.toolByName ? JSON.stringify(values.toolByName) : null, harness.sourceKind,
         stringValue(payload.usage_scope) ?? "physical_session", stringValue(payload.completeness) ?? "complete", context.now()]);
-    return { ok: true, observed: inserted.changes === 1, duplicate: inserted.changes === 0, snapshot_id: id, provider_session_id: providerSessionId, harness: harness.harness };
+    return { ok: true, observed: inserted.changes === 1, duplicate: inserted.changes === 0, snapshot_id: id, session: publicSessionIdentity({ harness: harness.harness, provider_session_id: providerSessionId, session_id: providerSessionId }) };
 }
 export function checkpointSessionUsage(context, session, input) {
     const observedAt = context.now();
-    const result = readCodexTranscript(session.transcript_path, session.session_id);
+    const result = readCodexTranscript(session.transcript_path, nativeSessionId(session));
     const source = sourceFacts(session.transcript_path);
     const snapshot = {
         id: `USG-${crypto.randomUUID()}`,
@@ -114,7 +115,7 @@ export function checkpointSessionUsage(context, session, input) {
     return snapshotForOutput(snapshot);
 }
 export function checkpointRunUsage(context, input) {
-    const sessions = context.db.all(`SELECT session_id, project_id, run_id, transcript_path, parent_session_id, role, aspect_id, plan_item_id, session_kind
+    const sessions = context.db.all(`SELECT session_id, project_id, run_id, transcript_path, provider_session_id, parent_session_id, role, aspect_id, plan_item_id, session_kind
      FROM sessions WHERE project_id = ? AND run_id = ?`, [input.projectId, input.runId]);
     return sessions.map((session) => checkpointSessionUsage(context, session, input));
 }
@@ -131,11 +132,12 @@ export function storedUsageForRun(context, input) {
  */
 export function recalculateRunUsage(context, input) {
     const observedAt = context.now();
-    const runRow = context.db.get("SELECT index_json FROM runs WHERE project_id = ? AND id = ?", [input.projectId, input.runId]);
-    const runCompletedAt = runRow ? terminalTimestamp(runRow.index_json) : null;
-    const accountingAt = input.stage?.completedAt ?? runCompletedAt ?? observedAt;
+    // Provider completion, not the controller's later lifecycle write, is the
+    // accounting boundary. A final refresh must therefore see tokens emitted
+    // after `work finish` but before the agent's actual terminal event.
+    const accountingAt = observedAt;
     const links = context.db.all(`SELECT ws.id, ws.work_id, ws.session_id, ws.created_at, ws.completed_at,
-            w.project_id, s.harness, s.transcript_path, s.parent_session_id, s.agent_id, s.provider_session_id
+            w.project_id, s.harness, s.transcript_path, s.parent_session_id, s.provider_parent_session_id, s.agent_id, s.provider_session_id
        FROM work_sessions ws
        JOIN works w ON w.work_id = ws.work_id
        LEFT JOIN sessions s ON s.project_id = w.project_id AND s.session_id = ws.session_id
@@ -153,31 +155,34 @@ export function recalculateRunUsage(context, input) {
     const settledSessions = settledRunSessions(context, links, observedAt);
     const unsettledSessions = [...new Set(links.map((link) => link.session_id))].filter((sessionId) => !settledSessions.some((session) => session.session_id === sessionId));
     const usageFinal = final && unsettledSessions.length === 0;
-    context.db.exec("BEGIN IMMEDIATE");
-    try {
-        context.db.run("DELETE FROM usage WHERE project_id = ? AND run_id = ?", [input.projectId, input.runId]);
-        for (const row of rows) {
-            context.db.run(`INSERT INTO usage (id, project_id, run_id, session_id, checkpoint, stage, stage_attempt, observed_at, total_tokens, input_tokens, cached_input_tokens, cache_read_input_tokens, cache_write_input_tokens, uncached_input_tokens, output_tokens, reasoning_output_tokens, source_kind, source_locator, source_sha256, source_size_bytes, source_mtime_ms, token_event_at, turn_id, turn_attribution, parser_version, extraction_status, diagnostic_code, created_at)
+    const persistRunProjection = !input.sessionId && !input.stage;
+    if (persistRunProjection) {
+        context.db.exec("BEGIN IMMEDIATE");
+        try {
+            context.db.run("DELETE FROM usage WHERE project_id = ? AND run_id = ?", [input.projectId, input.runId]);
+            for (const row of rows) {
+                context.db.run(`INSERT INTO usage (id, project_id, run_id, session_id, checkpoint, stage, stage_attempt, observed_at, total_tokens, input_tokens, cached_input_tokens, cache_read_input_tokens, cache_write_input_tokens, uncached_input_tokens, output_tokens, reasoning_output_tokens, source_kind, source_locator, source_sha256, source_size_bytes, source_mtime_ms, token_event_at, turn_id, turn_attribution, parser_version, extraction_status, diagnostic_code, created_at)
          VALUES (?, ?, ?, ?, ?, ?, NULL, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, NULL, NULL, 'windowed_work_session', 1, ?, ?, ?)`, [
-                `USG-${crypto.randomUUID()}`, input.projectId, input.runId, row.session_id, usageFinal ? "final" : "provisional", input.stage?.name ?? null, row.observed_at,
-                row.tokens?.total_tokens ?? null, row.tokens?.input_tokens ?? null, row.tokens?.cache_read_input_tokens ?? null,
-                row.tokens?.cache_read_input_tokens ?? null, row.tokens?.cache_write_input_tokens ?? null, row.tokens?.uncached_input_tokens ?? null,
-                row.tokens?.output_tokens ?? null, row.tokens?.reasoning_output_tokens ?? null, row.source_kind, row.source.locator, row.source.sha256, row.source.size, row.source.mtime,
-                row.status, row.diagnostic, observedAt
-            ]);
-        }
-        for (const session of settledSessions) {
-            context.db.run(`UPDATE sessions
+                    `USG-${crypto.randomUUID()}`, input.projectId, input.runId, row.session_id, usageFinal ? "final" : "provisional", input.stage?.name ?? null, row.observed_at,
+                    row.tokens?.total_tokens ?? null, row.tokens?.input_tokens ?? null, row.tokens?.cache_read_input_tokens ?? null,
+                    row.tokens?.cache_read_input_tokens ?? null, row.tokens?.cache_write_input_tokens ?? null, row.tokens?.uncached_input_tokens ?? null,
+                    row.tokens?.output_tokens ?? null, row.tokens?.reasoning_output_tokens ?? null, row.source_kind, row.source.locator, row.source.sha256, row.source.size, row.source.mtime,
+                    row.status, row.diagnostic, observedAt
+                ]);
+            }
+            for (const session of settledSessions) {
+                context.db.run(`UPDATE sessions
             SET status = 'stopped', stop_reason = 'provider_turn_complete', updated_at = ?, stopped_at = ?
           WHERE project_id = ? AND run_id = ? AND session_id = ?
             AND status = 'idle'
             AND NOT EXISTS (SELECT 1 FROM work_sessions WHERE session_id = ? AND status = 'running')`, [observedAt, session.completed_at, input.projectId, input.runId, session.session_id, session.session_id]);
+            }
+            context.db.exec("COMMIT");
+        }
+        catch (error) {
+            context.db.exec("ROLLBACK");
+            throw error;
         }
-        context.db.exec("COMMIT");
-    }
-    catch (error) {
-        context.db.exec("ROLLBACK");
-        throw error;
     }
     return {
         ok: true,
@@ -186,16 +191,28 @@ export function recalculateRunUsage(context, input) {
         status: usageFinal ? "final" : "provisional",
         scope: input.stage ? { kind: "stage", stage: input.stage.name, started_at: input.stage.startedAt, completed_at: input.stage.completedAt } : { kind: "run" },
         observed_at: observedAt,
+        persisted: persistRunProjection,
         totals: outputUsageTotals(totals),
-        sessions: rows,
+        sessions: publicUsageRows(context, input.projectId, rows),
         session_reconciliation: {
-            stopped: settledSessions.map((session) => session.session_id),
-            unsettled: unsettledSessions
+            stopped: publicSessionIdentities(context, input.projectId, settledSessions.map((session) => session.session_id)),
+            unsettled: publicSessionIdentities(context, input.projectId, unsettledSessions)
         },
         tool_calls: toolCallsForLinks(context, links, accountingAt),
         coverage: rows.reduce((coverage, row) => ({ ...coverage, [row.status]: (coverage[row.status] ?? 0) + 1 }), {})
     };
 }
+function publicUsageRows(context, projectId, rows) {
+    const identityFor = (storageId) => {
+        const row = context.db.get("SELECT harness, provider_session_id FROM sessions WHERE project_id = ? AND session_id = ?", [projectId, storageId]);
+        return row ? publicSessionIdentity({ harness: row.harness, provider_session_id: row.provider_session_id, session_id: storageId }) : null;
+    };
+    return rows.map(({ session_id, provider_session_id: _providerSessionId, parent_session_id, ...row }) => ({
+        ...row,
+        session: identityFor(session_id),
+        ...(parent_session_id ? { parent_session: identityFor(parent_session_id) } : {})
+    }));
+}
 function overlapsStage(link, stage, observedAt) {
     const linkStart = Date.parse(link.created_at);
     const linkEnd = Date.parse(link.completed_at ?? observedAt);
@@ -211,6 +228,17 @@ function clipToStage(link, stage, observedAt) {
     const completedAt = Date.parse(naturalEnd) > Date.parse(stageEnd) ? stageEnd : naturalEnd;
     return { ...link, created_at: startedAt, completed_at: completedAt };
 }
+function nativeSessionId(session) {
+    return session.provider_session_id ?? session.session_id;
+}
+function publicSessionIdentities(context, projectId, storageIds) {
+    if (storageIds.length === 0)
+        return [];
+    const marks = storageIds.map(() => "?").join(", ");
+    const rows = context.db.all(`SELECT session_id, harness, provider_session_id FROM sessions WHERE project_id = ? AND session_id IN (${marks})`, [projectId, ...storageIds]);
+    const byStorage = new Map(rows.map((row) => [row.session_id, publicSessionIdentity(row)]));
+    return storageIds.flatMap((id) => byStorage.get(id) ?? []);
+}
 function toolCallsForLinks(context, links, observedAt) {
     const result = { status: "unavailable", total: 0, failures: 0, by_tool: {}, observed_sessions: 0, unavailable_sessions: [] };
     const sessions = new Map();
@@ -220,7 +248,7 @@ function toolCallsForLinks(context, links, observedAt) {
         const first = windows[0];
         const parsed = isExternalHarness(first.harness)
             ? readHarnessToolCallsWindow(context, first.harness, first.project_id, first.provider_session_id, windows.map((item) => item.created_at).sort()[0], windows.map((item) => item.completed_at ?? observedAt).sort().at(-1), observedAt)
-            : readToolCallsForWindows(first.transcript_path, sessionId, windows, observedAt);
+            : readToolCallsForWindows(first.transcript_path, nativeSessionId(first), windows, observedAt);
         if (!parsed) {
             result.unavailable_sessions.push(sessionId);
             continue;
@@ -356,15 +384,15 @@ function usageRowsForPhysicalSessions(context, links, observedAt, stage) {
         sessions.set(link.session_id, [...(sessions.get(link.session_id) ?? []), link]);
     const physicalSessions = [...sessions.values()].filter((sessionLinks) => {
         const link = sessionLinks[0];
-        if (!link.parent_session_id)
+        if (!link.provider_parent_session_id)
             return true;
-        const parent = links.find((candidate) => candidate.session_id === link.parent_session_id);
+        const parent = links.find((candidate) => candidate.session_id === link.provider_parent_session_id);
         return !parent || !hasInclusiveUsageSnapshot(context, parent.project_id, parent.harness, parent.provider_session_id, observedAt);
     });
     return physicalSessions.map((sessionLinks) => {
         const link = sessionLinks[0];
         const startedAt = stage?.startedAt ?? sessionLinks.map((item) => item.created_at).sort()[0];
-        const completedTurn = stage ? null : completedProviderTurn(link.transcript_path, link.session_id);
+        const completedTurn = stage ? null : completedProviderTurn(link.transcript_path, nativeSessionId(link));
         const naturalEnd = isExternalHarness(link.harness)
             ? observedAt
             : completedTurn?.completed_at ?? sessionLinks.map((item) => item.completed_at ?? observedAt).sort().at(-1);
@@ -372,7 +400,7 @@ function usageRowsForPhysicalSessions(context, links, observedAt, stage) {
         const harnessUsage = isExternalHarness(link.harness)
             ? readHarnessUsageWindow(context, link.harness, link.project_id, link.provider_session_id, startedAt, endedAt, observedAt)
             : null;
-        const parsed = harnessUsage ?? readCodexTranscriptWindow(link.transcript_path, link.session_id, startedAt, endedAt);
+        const parsed = harnessUsage ?? readCodexTranscriptWindow(link.transcript_path, nativeSessionId(link), startedAt, endedAt);
         return {
             work_session_id: link.id,
             work_id: link.work_id,
@@ -427,15 +455,6 @@ function readHarnessUsageWindow(context, harness, projectId, providerSessionId,
         }
     };
 }
-function terminalTimestamp(indexJson) {
-    try {
-        const index = JSON.parse(indexJson);
-        return ["done", "blocked", "cancelled", "failed"].includes(index.status ?? "") && typeof index.completed_at === "string" ? index.completed_at : null;
-    }
-    catch {
-        return null;
-    }
-}
 function settledRunSessions(context, links, observedAt) {
     const sessions = new Map();
     for (const link of links)
@@ -444,16 +463,17 @@ function settledRunSessions(context, links, observedAt) {
         if (sessionLinks.some((link) => !link.completed_at))
             return [];
         const link = sessionLinks[0];
-        const latestWorkFinish = sessionLinks.map((item) => Date.parse(item.completed_at)).filter(Number.isFinite).sort((left, right) => right - left)[0];
-        if (isExternalHarness(link.harness) && link.provider_session_id && latestWorkFinish !== undefined) {
+        const sessionStartedAt = sessionLinks.map((item) => item.created_at).sort()[0];
+        const workCompletedAt = sessionLinks.map((item) => item.completed_at).sort().at(-1);
+        if (isExternalHarness(link.harness) && link.provider_session_id) {
             const snapshot = context.db.get(`SELECT observed_at FROM harness_usage_snapshots
           WHERE project_id = ? AND harness = ? AND provider_session_id = ?
-            AND observed_at >= ? AND observed_at <= ?
-          ORDER BY observed_at DESC, id DESC LIMIT 1`, [link.project_id, link.harness, link.provider_session_id, new Date(latestWorkFinish).toISOString(), observedAt]);
+            AND completeness = 'complete' AND observed_at >= ? AND observed_at <= ?
+          ORDER BY observed_at DESC, id DESC LIMIT 1`, [link.project_id, link.harness, link.provider_session_id, workCompletedAt, observedAt]);
             return snapshot ? [{ session_id: sessionId, completed_at: snapshot.observed_at }] : [];
         }
-        const completed = completedProviderTurn(sessionLinks[0].transcript_path, sessionId);
-        if (!completed || (latestWorkFinish !== undefined && Date.parse(completed.completed_at) < latestWorkFinish))
+        const completed = completedProviderTurn(sessionLinks[0].transcript_path, nativeSessionId(sessionLinks[0]));
+        if (!completed || Date.parse(completed.completed_at) < Date.parse(workCompletedAt) || Date.parse(completed.completed_at) < Date.parse(sessionStartedAt))
             return [];
         return [{ session_id: sessionId, completed_at: completed.completed_at }];
     });
@@ -492,10 +512,10 @@ function completedProviderTurn(transcriptPath, expectedSessionId) {
     }
 }
 function usageReport(context, input, refresh) {
-    const sessions = context.db.all(`SELECT DISTINCT session_id, project_id, ? AS run_id, transcript_path, parent_session_id, role, aspect_id, plan_item_id, session_kind
+    const sessions = context.db.all(`SELECT DISTINCT session_id, project_id, ? AS run_id, transcript_path, harness, provider_session_id, parent_session_id, role, aspect_id, plan_item_id, session_kind
      FROM sessions WHERE project_id = ? AND run_id = ?
      UNION
-     SELECT DISTINCT f.session_id, f.project_id, ? AS run_id, f.transcript_path, f.parent_session_id, f.role, f.aspect_id, f.plan_item_id, f.session_kind
+     SELECT DISTINCT f.session_id, f.project_id, ? AS run_id, f.transcript_path, f.harness, f.provider_session_id, f.parent_session_id, f.role, f.aspect_id, f.plan_item_id, f.session_kind
      FROM flow_session_segments s JOIN sessions f ON f.project_id = s.project_id AND f.session_id = s.session_id
      WHERE s.project_id = ? AND s.run_id = ?`, [input.runId, input.projectId, input.runId, input.runId, input.projectId, input.runId]);
     const selectedSessions = input.sessionId ? sessions.filter((session) => session.session_id === input.sessionId) : sessions;
@@ -508,13 +528,15 @@ function usageReport(context, input, refresh) {
      LEFT JOIN sessions f ON f.project_id = s.project_id AND f.session_id = s.session_id
      WHERE s.project_id = ? AND s.run_id = ? ORDER BY s.session_id, s.observed_at, s.id`, [input.projectId, input.runId]);
     const selectedRows = input.sessionId ? rows.filter((row) => row.session_id === input.sessionId) : rows;
-    const deltas = usageDeltas(selectedRows);
+    const publicSessions = new Map(sessions.map((session) => [session.session_id, publicSessionIdentity({ harness: session.harness ?? "codex-desktop", provider_session_id: session.provider_session_id ?? null, session_id: session.session_id })]));
+    const rawDeltas = usageDeltas(selectedRows);
+    const deltas = rawDeltas.map(({ session_id, ...delta }) => ({ ...delta, session: publicSessions.get(session_id) ?? null }));
     const segments = context.db.all(`SELECT id, session_id, run_id, protocol_id, started_at, ended_at, cwd, tool_name
      FROM flow_session_segments WHERE project_id = ? AND run_id = ? ORDER BY started_at, id`, [input.projectId, input.runId]);
     const supported = new Set(["session", "role", "aspect", "plan-item", "stage", "protocol"]);
     const groupBy = supported.has(input.groupBy) ? input.groupBy : "session";
     const groups = new Map();
-    for (const delta of deltas) {
+    for (const delta of rawDeltas) {
         const key = groupKey(delta, groupBy);
         const group = groups.get(key) ?? { tokens: emptyUsage(), snapshots: 0, statuses: {}, transition_buckets: 0 };
         group.snapshots += 1;
@@ -531,7 +553,9 @@ function usageReport(context, input, refresh) {
         run_id: input.runId,
         source: { kind: "codex_transcript_v1", parser_version: 1, refreshed_sessions: refreshed.length, checkpoint_source: refresh ? "refreshed" : "stored" },
         sessions: selectedSessions.map((session) => ({
-            session_id: session.session_id, parent_session_id: session.parent_session_id ?? null, role: session.role ?? null,
+            session: publicSessionIdentity({ harness: session.harness ?? "codex-desktop", provider_session_id: session.provider_session_id ?? null, session_id: session.session_id }),
+            ...(session.parent_session_id ? { parent_session: publicSessions.get(session.parent_session_id) ?? null } : {}),
+            role: session.role ?? null,
             aspect_id: session.aspect_id ?? null, plan_item_id: session.plan_item_id ?? null, session_kind: session.session_kind ?? null
         })),
         groups: [...groups.entries()].map(([key, group]) => ({ key, ...group, tokens: outputUsageTotals(group.tokens) })),
@@ -539,7 +563,7 @@ function usageReport(context, input, refresh) {
         tool_calls: toolCallsForSessions(sessions),
         segments: segments.map((segment) => ({
             segment_id: segment.id,
-            session_id: segment.session_id,
+            session: publicSessions.get(segment.session_id) ?? null,
             run_id: segment.run_id,
             protocol_id: segment.protocol_id,
             started_at: segment.started_at,
@@ -552,7 +576,7 @@ function usageReport(context, input, refresh) {
 function toolCallsForSessions(sessions) {
     const result = { status: "unavailable", total: 0, failures: 0, by_tool: {}, observed_sessions: 0, unavailable_sessions: [] };
     for (const session of sessions) {
-        const parsed = readToolCalls(session.transcript_path, session.session_id);
+        const parsed = readToolCalls(session.transcript_path, nativeSessionId(session));
         if (!parsed) {
             result.unavailable_sessions.push(session.session_id);
             continue;
@@ -611,7 +635,7 @@ function readToolCalls(transcriptPath, expectedSessionId) {
 function segmentUsage(context, session, segment) {
     if (!session)
         return { status: "unavailable", diagnostic: "session_record_missing" };
-    const result = readCodexTranscriptWindow(session.transcript_path, session.session_id, segment.started_at, segment.ended_at ?? context.now());
+    const result = readCodexTranscriptWindow(session.transcript_path, nativeSessionId(session), segment.started_at, segment.ended_at ?? context.now());
     return result.counter ? { status: result.status, tokens: result.counter.usage, token_event_at: result.counter.token_event_at } : { status: result.status, diagnostic: result.diagnostic ?? null };
 }
 function readCodexTranscript(transcriptPath, expectedSessionId) {

package/dist/services/vnext-code-review.js

@@ -10,14 +10,15 @@ import { validateSchema } from "./schema-validation.js";
 import { flowCommand } from "./stage-pause.js";
 import { assertStageStartHookEvent } from "./hooks.js";
 import { requireVnextWorkspaceRoute } from "./vnext-workspace-policy.js";
-import { addVnextCodeRepair, writeProtocolFlowStatus } from "./vnext-code.js";
-import { finalCodeCheckDeclarations, runCodeChecks, unchangedFinalGateFailures } from "./code-checks.js";
+import { addVnextCodeRepair } from "./vnext-code.js";
+import { finalCodeCheckDeclarations, runCodeChecks, unchangedFinalGateFailures, workspaceFingerprint } from "./code-checks.js";
 import { addWorkBatch, bindStageCoordinatorWork, finishWork, refreshRunWorkProjection } from "./work-registry.js";
 import { vnextStageDirectory } from "../domain/stage-catalog.js";
 import { writeStageReport } from "./stage-report-renderer.js";
 import { applyExternalStageContext } from "./stage-context.js";
 import { readFanoutDescriptor, writeFanoutDescriptor } from "./vnext-fanout.js";
 import { ensureVnextMergeRequest } from "./vnext-merge.js";
+import { validateVnextCodeHandoff } from "./vnext-plan.js";
 const stage = "code-review";
 const stageDir = vnextStageDirectory(stage);
 const baselineAspects = ["goal_traceability", "coding_standards_design_review", "verification_evidence_review"];
@@ -46,8 +47,10 @@ export function startVnextCodeReview(context, input) {
         const orchestration = readFanoutDescriptor(root);
         return { ok: true, resumed: true, run_id: run.id, stage, stage_status: prior, id: binding.work_session_id, prompt_path: existingPrompt, worker_prompt_markdown: prompt, ...(externalContext ? { external_context: externalContext } : {}), ...(orchestration ? { orchestration } : {}), next: { finish_command: finishCommand(context, run.id, projectRoot, path.join(root, "decision.json")) } };
     }
-    const mode = effectiveMode(run, changedPaths(run.workspace_root));
+    const mode = effectiveMode(run, acceptedCodeChangedPaths(home));
     const promptPath = path.join(root, "stage-prompt.md");
+    const reviewContextPath = path.join(root, "review-context.json");
+    fs.writeFileSync(reviewContextPath, `${JSON.stringify({ schema_id: "dd-flow/code-review-context@1", mode, workspace_fingerprint: workspaceFingerprint(run.workspace_root), code_report_sha256: sha256File(path.join(home, "05-code", "stage-report.json")) }, null, 2)}\n`);
     if (mode === "off") {
         const prompt = `<stage_identity>\n- RUN: ${run.id}\n- stage: code-review\n- mode: off\n</stage_identity>\n\nCODE-REVIEW is disabled by the frozen RUN configuration. Finish with: ${finishCommand(context, run.id, projectRoot, path.join(root, "decision.json"))}\n`;
         fs.writeFileSync(promptPath, prompt);
@@ -96,6 +99,8 @@ export function addVnextCodeReviewRepair(context, input) {
     if (unknown.length)
         throw new AppError("review_check_reference_unknown", "CODE-REVIEW finding cites a check absent from the accepted CODE handoff", 2, { check_refs: unknown });
     const reviewChecks = requestedCheckRefs.map((ref) => checks.get(ref)).filter((check) => check.run_at !== "external");
+    if (!reviewChecks.length)
+        throw new AppError("review_repair_executable_check_required", "CODE-REVIEW repair requires at least one executable causal check; external-only evidence cannot validate a repair Work", 2, { finding_ids: input.findingIds, check_refs: requestedCheckRefs });
     return addVnextCodeRepair(context, {
         projectRoot,
         runId: run.id,
@@ -113,7 +118,15 @@ export async function finishVnextCodeReview(context, input) {
     const run = requireRun(context, project.id, input.runId);
     const home = requireHome(run);
     const root = path.join(home, stageDir);
-    const mode = effectiveMode(run, changedPaths(run.workspace_root));
+    const reviewContext = readJson(path.join(root, "review-context.json"));
+    const mode = reviewContext.mode;
+    if (!mode)
+        throw new AppError("runtime_missing", "CODE-REVIEW effective mode was not frozen at stage start", 1);
+    if (reviewContext.code_report_sha256 !== sha256File(path.join(home, "05-code", "stage-report.json")))
+        throw new AppError("code_review_input_changed", "Accepted CODE report changed after CODE-REVIEW start", 2);
+    const handoffFailures = validateVnextCodeHandoff(context, { projectRoot, workspaceRoot: run.workspace_root, runId: run.id, home });
+    if (handoffFailures.length)
+        throw new AppError("validation", "CODE-REVIEW handoff no longer matches the accepted PLAN", 2, { errors: handoffFailures });
     const reportPath = path.join(root, "stage-report.json");
     if (stageStatus(run, stage) === "done" && fs.existsSync(reportPath)) {
         const report = readJson(reportPath);
@@ -157,10 +170,10 @@ export async function finishVnextCodeReview(context, input) {
     const outcome = decision.findings.some((item) => item.disposition === "defer") ? "accepted_with_DEF" : "accepted";
     const repairs = reviewRepairWorks(context, project.id, run.id, root);
     const finalChecks = finalCodeCheckDeclarations(run.workspace_root, codeWorks(context, project.id, run.id).flatMap((work) => { const payload = readJsonString(work.payload_json); return Array.isArray(payload.checks) ? payload.checks : []; }));
-    const unchangedFailures = repairs.length ? unchangedFinalGateFailures(context, { projectId: project.id, runId: run.id, workspaceRoot: run.workspace_root, declarations: finalChecks }) : [];
+    const unchangedFailures = unchangedFinalGateFailures(context, { projectId: project.id, runId: run.id, workspaceRoot: run.workspace_root, declarations: finalChecks });
     if (unchangedFailures.length)
         throw new AppError("code_review_gate_repair_required", "CODE-REVIEW final gate already failed for the unchanged workspace; repair the evidenced failure before retrying", 2, { outcome: "repair_required", retry_after_workspace_change: true, workspace_fingerprint: unchangedFailures[0].workspace_fingerprint, failures: unchangedFailures });
-    const receipts = repairs.length ? await runCodeChecks(context, { projectId: project.id, runId: run.id, runHome: home, workspaceRoot: run.workspace_root, artifactDir: stageDir, scope: "aggregate", checks: finalChecks, ...(input.progress ? { progress: input.progress } : {}) }) : [];
+    const receipts = await runCodeChecks(context, { projectId: project.id, runId: run.id, runHome: home, workspaceRoot: run.workspace_root, artifactDir: stageDir, scope: "aggregate", checks: finalChecks, ...(input.progress ? { progress: input.progress } : {}) });
     const failed = receipts.filter((receipt) => receipt.status !== "passed");
     if (failed.length)
         throw new AppError("code_review_gate_failed", "CODE-REVIEW repair changed the project but the aggregate gate failed", 2, {
@@ -174,8 +187,11 @@ export async function finishVnextCodeReview(context, input) {
     const nextAction = stopTarget === "merge_completed" ? "start_merge" : "code_review_completed";
     const now = context.now();
     const startedAt = stageStartedAt(run, now);
-    writeProtocolFlowStatus(run.workspace_root, home, run.id, nextAction === "start_merge" ? "CODE-REVIEW complete; MERGE is queued." : "CODE-REVIEW complete; this RUN reached its configured terminal boundary.");
-    const report = { schema_id: "dd-flow/stage-report@1", run_id: run.id, stage, generated_at: now, verdict: "done", semantic: { result: `Independent CODE review completed: ${reviewers.length} reviewer Work(s), ${repairs.length} repair Work(s).`, acceptance: ["all_selected_review_groups_completed", "all_material_findings_classified", ...(repairs.length ? ["all_accepted_repairs_completed", "post_repair_final_gate_passed"] : [])], run_changed_files: changedPaths(run.workspace_root), checks: receipts.map((receipt) => receipt.command), evidence: [...reviewers.flatMap((work) => readJsonString(work.result).findings.flatMap((finding) => finding.evidence_refs)), ...receipts.map((receipt) => runRef(run.id, home, receipt.receipt_path))], next_action: nextAction, code_review: { mode, reviewer_work_ids: reviewers.map((work) => work.work_id), repair_work_ids: repairs.map((work) => work.work_id), decision } }, mechanical: { started_at: startedAt, finished_at: now, wall_clock_ms: Math.max(0, Date.parse(now) - Date.parse(startedAt)), git: gitFacts(run.workspace_root), session_stats_command: `${flowCommand(context)} stat run sessions ls --run ${run.id} --project-root ${JSON.stringify(projectRoot)} --json`, usage_stats_command: `${flowCommand(context)} stat usage --run ${run.id} --project-root ${JSON.stringify(projectRoot)} --json` }, artifacts: { json: "stage-report.json", markdown: "stage-report.md", html: "stage-report.html" }, validation: { status: "passed" } };
+    const report = { schema_id: "dd-flow/stage-report@1", run_id: run.id, stage, generated_at: now, verdict: "done", semantic: { result: `Independent CODE review completed: ${reviewers.length} reviewer Work(s), ${repairs.length} repair Work(s).`, acceptance: ["all_selected_review_groups_completed", "all_material_findings_classified", ...(repairs.length ? ["all_accepted_repairs_completed"] : []), "current_final_gate_passed"], run_changed_files: changedPaths(run.workspace_root), checks: receipts.map((receipt) => receipt.command), evidence: [...reviewers.flatMap((work) => readJsonString(work.result).findings.flatMap((finding) => finding.evidence_refs)), ...receipts.map((receipt) => runRef(run.id, home, receipt.receipt_path))], next_action: nextAction, code_review: { mode, reviewer_work_ids: reviewers.map((work) => work.work_id), repair_work_ids: repairs.map((work) => work.work_id), decision } }, mechanical: { started_at: startedAt, finished_at: now, wall_clock_ms: Math.max(0, Date.parse(now) - Date.parse(startedAt)), git: gitFacts(run.workspace_root), session_stats_command: `${flowCommand(context)} stat run sessions ls --run ${run.id} --project-root ${JSON.stringify(projectRoot)} --json`, usage_stats_command: `${flowCommand(context)} stat usage --run ${run.id} --project-root ${JSON.stringify(projectRoot)} --json` }, artifacts: { json: "stage-report.json", markdown: "stage-report.md", html: "stage-report.html" }, validation: { status: "passed" } };
+    // The request must exist before CODE-REVIEW becomes terminal. Otherwise a
+    // merge-gate error creates an irrecoverable `done` report with no MRG-*.
+    const acceptedPaths = changedPaths(run.workspace_root);
+    const mergeRequest = nextAction === "start_merge" ? ensureVnextMergeRequest(context, { projectRoot, runId: run.id, acceptedPaths }) : null;
     writeReport(root, report);
     completeFlowRunStage(context, { projectRoot, runId: run.id, stage, status: "done", data: "stage-report.json", dataSchemaId: "dd-flow/stage-report@1", report: "stage-report.md", stageReport: "stage-report.html" });
     appendFlowRunTimelineEvent(context, project.id, run.id, { type: "code_review_completed", work_id: rootWork.work_id, outcome });
@@ -186,7 +202,6 @@ export async function finishVnextCodeReview(context, input) {
         completeFlowRun(context, { projectRoot, runId: run.id, status: "done", verdict: "code_review_completed", nextAction: undefined });
     }
     refreshRunWorkProjection(context, project.id, run.id);
-    const mergeRequest = nextAction === "start_merge" ? ensureVnextMergeRequest(context, { projectRoot, runId: run.id }) : null;
     return { ok: true, run_id: run.id, stage, outcome, report_path: path.join(root, "stage-report.json"), next_action: nextAction, ...(mergeRequest ? { merge_request: mergeRequest, next: { kind: "start_stage", stage: "merge", command: `${flowCommand(context)} stage start ${run.id} --stage merge --project-root ${JSON.stringify(projectRoot)} --json --progress-jsonl` } } : {}) };
 }
 function reviewGroups(run, home, mode) {
@@ -202,7 +217,7 @@ function reviewGroups(run, home, mode) {
     const chunk = mode === "deep" ? 1 : 3;
     return Array.from({ length: Math.ceil(all.length / chunk) }, (_, index) => ({ key: `group-${index + 1}`, aspect_ids: all.slice(index * chunk, (index + 1) * chunk) }));
 }
-function reviewerTask(home, group) { return `Read-only independent CODE review for ${group.key}. Assess every assigned aspect exactly once: ${group.aspect_ids.join(", ")}. Read the accepted PLAN, ${path.join(home, "05-code", "stage-report.json")}, and any files needed under the bounded CODE evidence root ${path.join(home, "05-code")}. Report only material, evidenced defects: a violated obligation or rule, direct evidence, impact, and minimum required outcome. Do not report taste, cosmetics, or untargeted refactoring. Finding ids must use the unique prefix FIND-${group.key}-. Return dd-flow/code-review-result@1.`; }
+function reviewerTask(home, group) { return `Read-only independent CODE review for ${group.key}. Assess every assigned aspect exactly once: ${group.aspect_ids.join(", ")}. Read the accepted PLAN, ${path.join(home, "05-code", "stage-report.json")}, and any files needed under the bounded CODE evidence root ${path.join(home, "05-code")}. Report only material, evidenced defects: a violated obligation or rule, direct evidence, impact, and minimum required outcome. Do not report taste, cosmetics, or untargeted refactoring. Use local finding ids FIND-001, FIND-002, and so on; dd-flow adds the Work-qualified canonical reference. Return dd-flow/code-review-result@1.`; }
 function orchestratorPrompt(context, input) { const template = read(path.join(input.run.workspace_root, ".memory-bank", "dd-flow", "vnext", "code-review.md")); const decision = path.join(input.root, "decision.json"); const checks = acceptedCodeChecks(context, input.run.project_id, input.run.id).map(({ id, purpose }) => ({ id, purpose })); return ["<stage_identity>", `- RUN: ${input.run.id}`, `- root Work: ${input.rootWork.work_id}`, `- stage: ${stage}`, `- mode: ${input.mode}`, "</stage_identity>", "", "<trusted_runtime_context>", `- project root: ${input.projectRoot}`, `- immutable write workspace: ${input.run.workspace_root}`, `- stage workspace: ${input.root}`, `- bounded CODE evidence root: ${path.join(input.run.run_home_path, "05-code")}`, "CODE is already semantically verified and all declared checks passed. Do not redo CODE verification; conduct independent quality review.", "</trusted_runtime_context>", "", "<review_groups>", ...input.groups.map((group) => `- ${group.key}: ${group.aspect_ids.join(", ")}`), "</review_groups>", "", "<execution_commands>", "Each reviewer Work must run in one fresh child session. The coordinator must never claim a reviewer Work itself. Start each ready Work with its exact start_command from the work graph; it receives the task and result schema. Reviewers are read-only and must not create subagents. Do not interrupt a quiet worker.", `Ready reviewer Works: ${flowCommand(context)} work ls --run ${input.run.id} --ready --project-root ${JSON.stringify(input.projectRoot)} --json`, `Finish only after every reviewer Work settles and you have written ${decision}: ${finishCommand(context, input.run.id, input.projectRoot, decision)}`, "Reviewer results use local FIND-NNN ids. Classify them by the canonical WRK-.../FIND-NNN finding_ref returned by dd-flow. Fix P0/P1. Fix bounded safe P2 by default; defer only a legitimate P2 with a named DEF. P3 is an observation or a reasoned rejection, not automatic repair/DEF. For every disposition fix, check_refs is mandatory: choose the one or more causal checks from the accepted list below that the repair must rerun. Do not guess a CHK id or copy every check. The first successful Finish freezes this decision and creates one repair Work when needed. Run it, then call the same Finish command again. Review is not repeated.", "If the post-repair aggregate gate fails, do not stop after `code_review_gate_failed`: that rejected finish does not create a repair Work. In the same coordinator Turn, use the returned repair command with the failed receipt, a relevant completed origin Work ID, and a concise repair objective; then stop so the runner can dispatch the new repair. Do not edit invisibly in the root orchestrator.", `Accepted repair checks: ${JSON.stringify(checks)}`, "```json", JSON.stringify({ schema_id: "dd-flow/code-review-decision@3", summary: "Evidence-backed conclusion.", findings: [{ finding_ref: "WRK-001-review/FIND-001", disposition: "fix | defer | reject | duplicate", reason: "Why this classification is correct.", check_refs: ["CHK-CAUSAL-CHECK only when disposition is fix"], def_id: "DEF-0001 only for an allowed P2 deferral", duplicate_of: "canonical finding_ref only for duplicate" }] }, null, 2), "```", "</execution_commands>", "", "<stage_instructions>", template, "</stage_instructions>", ""].join("\n"); }
 function canonicalReviewEvidence(decision, reviewers) {
     const known = new Set(canonicalCodeFindings(reviewers).map((item) => item.finding_ref));
@@ -278,8 +293,20 @@ function validateDecision(context, input) {
         if (!known.has(item.finding_ref))
             throw new AppError("review_evidence_invalid", "Decision references an unknown reviewer finding", 2, { finding_ref: item.finding_ref });
 }
-function validateReviewerResult(context, work, run) { if (!work.result)
-    throw new AppError("review_evidence_invalid", "Reviewer Work has no result", 2, { work_id: work.work_id }); const file = path.join(requireHome(run), stageDir, `${work.work_id}.result.json`); fs.writeFileSync(file, work.result); validateSchema({ schemaName: "code-review-result", file, projectRoot: run.workspace_root, ddFlowHome: context.ddFlowHome, runId: run.id }); }
+function validateReviewerResult(_context, work, _run) {
+    if (!work.result)
+        throw new AppError("review_evidence_invalid", "Reviewer Work has no result", 2, { work_id: work.work_id });
+    // Schema, group identity and portable evidence references were validated
+    // before this Work was accepted. This fan-in guard only checks semantic
+    // relationships that depend on the aggregate review decision.
+    const result = readJsonString(work.result);
+    if (result.verdict === "blocked")
+        throw new AppError("review_blocked", "A blocked reviewer result cannot be accepted as completed review evidence", 2, { work_id: work.work_id });
+    if (result.verdict === "pass" && result.findings.length)
+        throw new AppError("review_evidence_invalid", "A passing reviewer result cannot contain material findings", 2, { work_id: work.work_id });
+    if (result.aspects.some((aspect) => aspect.verdict === "blocked"))
+        throw new AppError("review_blocked", "A blocked review aspect must be resolved before CODE-REVIEW can finish", 2, { work_id: work.work_id });
+}
 function reviewerWorks(context, projectId, runId) { return context.db.all("SELECT * FROM works WHERE project_id = ? AND run_id = ? ORDER BY created_at, work_id", [projectId, runId]).filter((work) => { const p = readJsonString(work.payload_json); return Boolean(p && p.kind === "code-review"); }); }
 function codeWorks(context, projectId, runId) { return context.db.all("SELECT * FROM works WHERE project_id = ? AND run_id = ? AND status = 'completed' ORDER BY created_at, work_id", [projectId, runId]).filter((work) => readJsonString(work.payload_json).schema_id === "dd-flow/code-work-packet@5" && !reviewFindingIds(work).length); }
 function acceptedCodeChecks(context, projectId, runId) { return codeWorks(context, projectId, runId).flatMap((work) => { const payload = readJsonString(work.payload_json); return Array.isArray(payload.checks) ? payload.checks : []; }); }
@@ -311,6 +338,13 @@ function reviewCheckRefs(work) { const repair = readJsonString(work.payload_json
     return []; const refs = repair.review_check_refs; return Array.isArray(refs) ? refs.filter((value) => typeof value === "string") : []; }
 function canonicalCodeFindings(works) { return works.flatMap((work) => readJsonString(work.result).findings.map((finding) => ({ finding_ref: `${work.work_id}/${finding.finding_id}`, finding }))); }
 function effectiveMode(run, paths) { const index = JSON.parse(run.index_json); const requested = index.settings?.code_review?.mode ?? "auto"; return requested === "auto" ? (paths.length ? "standard" : "off") : requested; }
+function acceptedCodeChangedPaths(home) { try {
+    const report = readJson(path.join(home, "05-code", "stage-report.json"));
+    return Array.isArray(report.semantic?.changed_files) ? report.semantic.changed_files.filter((item) => typeof item === "string") : [];
+}
+catch {
+    return [];
+} }
 function executionStopTarget(run) { return JSON.parse(run.index_json).execution_profile?.settings?.stop_target ?? "code_review_completed"; }
 function changedPaths(workspaceRoot) { try {
     return execFileSync("git", ["status", "--porcelain=v1", "--untracked-files=all"], { cwd: workspaceRoot, encoding: "utf8", stdio: ["ignore", "pipe", "ignore"] }).split(/\r?\n/).filter(Boolean).map((line) => line.slice(3).replace(/^.* -> /, ""));