@deftai/directive-core 0.90.0 → 0.91.0

package/dist/init-deposit/init-deposit.js

@@ -7,12 +7,14 @@
  */
 import { existsSync, mkdirSync, readFileSync } from "node:fs";
 import { homedir, platform } from "node:os";
-import { join, resolve } from "node:path";
+import { basename, join, resolve } from "node:path";
 import { assertDepositContained } from "../deposit/contain.js";
 import { copyTree } from "../deposit/copy-tree.js";
 import { prunePythonArtifactsFromDeposit } from "../deposit/python-free.js";
 import { resolveInstalledContentRoot } from "../deposit/resolve-content.js";
 import { readCorePackageVersion } from "../engine-version.js";
+import { renderProjectDefinition } from "../render/project-render.js";
+import { removeStaleMigratedFrameworkNarrative } from "../xbrief-migrate/migrate-project.js";
 import { writeAgentHookDeposit } from "./agent-hooks.js";
 import { ensureInitGitignoreLines, reconstituteDepositFromContent } from "./gitignore.js";
 import { depositStagePaths, printCommitGuidance } from "./hygiene.js";
@@ -20,6 +22,7 @@ import { buildLegacyRefusalJson, buildLegacyRefusalMessage, detectLegacyLayout,
 import { printMigrateNudgeIfNeeded } from "./migrate.js";
 import { ensurePrettierIgnoreLines } from "./prettierignore.js";
 import { CANONICAL_INSTALL_ROOT, depositNeutralization, ensureTaskfile, writeAgentsMd, writeAgentsSkills, writeConsumerGitHooks, writeConsumerVbrief, writeInstallManifest, } from "./scaffold.js";
+import { syncBareVersionMarker } from "./xbrief-projections.js";
 export function parseInitArgv(canonicalArgv, userArgv = []) {
     const args = [...canonicalArgv, ...userArgv];
     let projectDir = process.cwd();
@@ -113,10 +116,36 @@ export function printNextSteps(result, io) {
     io.printf(`  1. Open your AI coding assistant in ${result.projectDir}\n`);
     io.printf("  2. Deft skill auto-discovery is partially implemented — if your agent doesn't\n");
     io.printf('     start setup automatically, tell it: "Use AGENTS.md"\n');
-    io.printf("  3. On first session, the agent will guide you through creating USER.md and PROJECT-DEFINITION.vbrief.json\n");
+    io.printf("  3. On first session, the agent will guide you through USER.md (if missing).\n");
+    io.printf("  4. PROJECT-DEFINITION is seeded at init (#3013) — run `task project:render` once to refresh items from lifecycle folders; do not multi-turn invent project identity.\n");
     printMigrateNudgeIfNeeded(result.projectDir, io);
     io.printf("\n");
 }
+/**
+ * Ensure a minimal render-ready PROJECT-DEFINITION exists after lifecycle dirs
+ * are deposited (#3013 / epic #3009). Idempotent: never overwrites existing identity.
+ */
+export function seedMinimalProjectDefinition(projectDir, io) {
+    const xbriefDir = join(projectDir, "xbrief");
+    const legacyDir = join(projectDir, "vbrief");
+    const root = existsSync(xbriefDir) ? xbriefDir : existsSync(legacyDir) ? legacyDir : null;
+    if (root === null) {
+        return false;
+    }
+    const isXbrief = basename(root) === "xbrief";
+    const projectDefPath = join(root, isXbrief ? "PROJECT-DEFINITION.xbrief.json" : "PROJECT-DEFINITION.vbrief.json");
+    if (existsSync(projectDefPath)) {
+        io.printf("PROJECT-DEFINITION already present — leaving identity intact (#3013).\n");
+        return false;
+    }
+    const [ok, message] = renderProjectDefinition(root);
+    if (ok) {
+        io.printf(`${message} (minimal seed for one-shot project:render; #3013)\n`);
+        return true;
+    }
+    io.printf(`PROJECT-DEFINITION seed skipped: ${message}\n`);
+    return false;
+}
 export async function runInitDeposit(args, io, seams = {}) {
     const projectDir = args.projectDir;
     const deftDir = join(projectDir, CANONICAL_INSTALL_ROOT);
@@ -154,6 +183,12 @@ export async function runInitDeposit(args, io, seams = {}) {
     const skillsCreated = writeAgentsSkills(projectDir, io);
     await depositNeutralization(projectDir, io);
     await writeConsumerVbrief(projectDir, deftDir, io);
+    seedMinimalProjectDefinition(projectDir, io);
+    // Seeding PROJECT-DEFINITION.xbrief.json makes resolveLifecycleRoot succeed.
+    // Align the same consumer derivatives update repairs (#2595 / #2806) so
+    // init + git add -A is already clean under core.autocrlf=true (#2118 / #3013).
+    syncBareVersionMarker(projectDir, version);
+    removeStaleMigratedFrameworkNarrative(projectDir);
     writeConsumerGitHooks(projectDir, deftDir, io, seams.gitHooks);
     writeAgentHookDeposit(projectDir, io);
     let taskfileWired = false;

package/dist/intake/github-auth-modes.d.ts

@@ -1,4 +1,4 @@
-import { type CompletedProcess } from "../scm/call.js";
+import type { CompletedProcess } from "../scm/call.js";
 import { probeRuntimeCapabilities, type RuntimeCapabilityReport } from "./platform-capabilities.js";
 export declare const GITHUB_AUTH_MODE_INJECTED_TOKEN = "injected-token";
 export declare const GITHUB_AUTH_MODE_HOST_GH = "host-gh";

package/dist/intake/github-auth-modes.js

@@ -1,4 +1,4 @@
-import { call } from "../scm/call.js";
+import { spawnSync } from "node:child_process";
 import { pyRepr } from "../scm/py-format.js";
 import { getPlatformCapabilities, probeRuntimeCapabilities, RUNTIME_MODE_CLOUD_HEADLESS, RUNTIME_MODE_CURSOR_NATIVE_SANDBOX, } from "./platform-capabilities.js";
 export const GITHUB_AUTH_MODE_INJECTED_TOKEN = "injected-token";
@@ -37,9 +37,31 @@ export function inferGithubAuthMode(runtimeReport) {
     }
     return GITHUB_AUTH_MODE_HOST_GH;
 }
+/**
+ * Prefer live `gh` for auth/API validation. Do not route through scm.call /
+ * BINARY_PREFERENCE (ghx-first): ghx is a cached GET proxy and rejects multi-arg
+ * `api user --jq .login` forms used here (#2275 Greptile P1 / #954).
+ */
 function defaultRunGh(args, environ) {
-    const verb = args[0];
-    return call("github-issue", verb, args.slice(1), { env: environ, timeout: 30 });
+    const binary = "gh";
+    try {
+        const result = spawnSync(binary, [...args], {
+            env: environ,
+            encoding: "utf8",
+            timeout: 30_000,
+            stdio: ["ignore", "pipe", "pipe"],
+        });
+        return {
+            args: [binary, ...args],
+            returncode: result.status ?? 1,
+            stdout: typeof result.stdout === "string" ? result.stdout : "",
+            stderr: typeof result.stderr === "string" ? result.stderr : "",
+        };
+    }
+    catch (err) {
+        const message = err instanceof Error ? err.message : String(err);
+        return { args: [binary, ...args], returncode: 1, stdout: "", stderr: message };
+    }
 }
 function splitRepo(repo) {
     const idx = repo.indexOf("/");

package/dist/intake/issue-ingest-cli.js

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 import { fileURLToPath } from "node:url";
+import { ScmStubError } from "../scm/errors.js";
+import { requireScmReady } from "../scm/readiness.js";
 import { issueIngestMain } from "./issue-ingest.js";
 function parseArgs(argv) {
     const out = {};
@@ -25,6 +27,17 @@ function parseArgs(argv) {
     return out;
 }
 export function mainEntry(argv = process.argv.slice(2)) {
+    // #2275: fail loud when gh/auth is missing in this execution env.
+    try {
+        requireScmReady();
+    }
+    catch (err) {
+        if (err instanceof ScmStubError) {
+            process.stderr.write(`error: ${err.message}\n`);
+            return 2;
+        }
+        throw err;
+    }
     return issueIngestMain(parseArgs(argv));
 }
 if (process.argv[1] !== undefined && fileURLToPath(import.meta.url) === process.argv[1]) {

package/dist/intake/reconcile-issues-cli.js

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 import { fileURLToPath } from "node:url";
+import { ScmStubError } from "../scm/errors.js";
+import { requireScmReady } from "../scm/readiness.js";
 import { reconcileMain } from "./reconcile-issues.js";
 function parseArgs(argv) {
     const out = {};
@@ -23,6 +25,17 @@ function parseArgs(argv) {
     return out;
 }
 export function mainEntry(argv = process.argv.slice(2)) {
+    // #2275: fail loud when gh/auth is missing in this execution env.
+    try {
+        requireScmReady();
+    }
+    catch (err) {
+        if (err instanceof ScmStubError) {
+            process.stderr.write(`error: ${err.message}\n`);
+            return 2;
+        }
+        throw err;
+    }
     return reconcileMain(parseArgs(argv));
 }
 if (process.argv[1] !== undefined && fileURLToPath(import.meta.url) === process.argv[1]) {

package/dist/policy/plan-extensions.d.ts

@@ -17,6 +17,14 @@
 export declare const PLAN_POLICY_KEY = "x-directive/policy";
 /** Namespaced directive scope-completion note key. */
 export declare const PLAN_COMPLETED_NOTE_KEY = "x-directive/completedNote";
+/**
+ * Namespaced onboarding decision-provenance block (#1694 / #1695).
+ *
+ * Holds facts that must NOT be smuggled through policy value fields (e.g.
+ * `plan.policy.wipCap` presence must not mean "operator decided a WIP cap").
+ * Out-of-band from `x-directive/policy` so value and decision stay orthogonal.
+ */
+export declare const PLAN_ONBOARDING_KEY = "x-directive/onboarding";
 /** Legacy bare policy key (pre-#1650); read-side fallback / write-side migration source. */
 export declare const LEGACY_PLAN_POLICY_KEY = "policy";
 /** Legacy bare completedNote key (pre-#1650); read-side fallback / write-side migration source. */
@@ -25,6 +33,8 @@ export declare const LEGACY_PLAN_COMPLETED_NOTE_KEY = "completedNote";
 export declare function readPlanPolicy(plan: unknown): unknown;
 /** Read the directive completedNote from a plan (namespaced first, bare fallback). */
 export declare function readPlanCompletedNote(plan: unknown): unknown;
+/** Read the namespaced onboarding decision-provenance block (#1694). */
+export declare function readPlanOnboarding(plan: unknown): unknown;
 /**
  * Rename a legacy bare `policy` key to the namespaced key in place when only
  * the bare key is present. No-op when the namespaced key already exists or no

package/dist/policy/plan-extensions.js

@@ -17,6 +17,14 @@
 export const PLAN_POLICY_KEY = "x-directive/policy";
 /** Namespaced directive scope-completion note key. */
 export const PLAN_COMPLETED_NOTE_KEY = "x-directive/completedNote";
+/**
+ * Namespaced onboarding decision-provenance block (#1694 / #1695).
+ *
+ * Holds facts that must NOT be smuggled through policy value fields (e.g.
+ * `plan.policy.wipCap` presence must not mean "operator decided a WIP cap").
+ * Out-of-band from `x-directive/policy` so value and decision stay orthogonal.
+ */
+export const PLAN_ONBOARDING_KEY = "x-directive/onboarding";
 /** Legacy bare policy key (pre-#1650); read-side fallback / write-side migration source. */
 export const LEGACY_PLAN_POLICY_KEY = "policy";
 /** Legacy bare completedNote key (pre-#1650); read-side fallback / write-side migration source. */
@@ -42,6 +50,14 @@ export function readPlanPolicy(plan) {
 export function readPlanCompletedNote(plan) {
     return readPlanExtension(plan, PLAN_COMPLETED_NOTE_KEY, LEGACY_PLAN_COMPLETED_NOTE_KEY);
 }
+/** Read the namespaced onboarding decision-provenance block (#1694). */
+export function readPlanOnboarding(plan) {
+    const planObj = asPlanObject(plan);
+    if (planObj === null) {
+        return undefined;
+    }
+    return planObj[PLAN_ONBOARDING_KEY];
+}
 /**
  * Rename a legacy bare `policy` key to the namespaced key in place when only
  * the bare key is present. No-op when the namespaced key already exists or no

package/dist/pr-closing-keywords/detect.d.ts

@@ -1,5 +1,18 @@
 import type { Hit } from "./types.js";
 export declare const CLOSING_KEYWORD_RE: RegExp;
 export declare function renderHit(hit: Hit): string;
+/** Layer 0 FP hits only (#737): keyword in negation / quotation / example / code-block / blockquote. */
 export declare function findHits(text: string, source: string): Hit[];
+/**
+ * Intent-mode hits (#3015 class D): every closing-keyword + `#N` match, regardless of
+ * surrounding prose. GitHub closes on token presence; conditional English is ignored.
+ * reason is the FP category when present, otherwise `intent`.
+ */
+export declare function findAllClosingKeywordHits(text: string, source: string): Hit[];
+/**
+ * Body trailer `deft-close-intent: full` is intentionally NOT an authorization path.
+ * Intent-mode allowlist is CLI `--allow-close N,M` only (#3015 / Greptile class-D gate).
+ * Markdown examples must never suppress real closing-keyword findings.
+ */
+export declare function hasFullCloseIntent(_text: string): boolean;
 //# sourceMappingURL=detect.d.ts.map

package/dist/pr-closing-keywords/detect.js

@@ -21,7 +21,8 @@ const EXAMPLE_MARKERS = [
     /\blike\b/i,
 ];
 const BLOCKQUOTE_RE = /^\s*>\s/m;
-const CODE_FENCE_RE = /^```/m;
+/** CommonMark fenced code opener/closer at line start: 3+ backticks or 3+ tildes. */
+const CODE_FENCE_LINE_RE = /^(?:`{3,}|~{3,})/;
 function findAllMatches(text, re) {
     const flags = re.flags.includes("g") ? re.flags : `${re.flags}g`;
     const pattern = new RegExp(re.source, flags);
@@ -41,10 +42,41 @@ function lineStartingAt(text, offset) {
     }
     return text.slice(lineStart, lineEnd);
 }
+/**
+ * CommonMark fence stack: open and close must use the same character, and the
+ * closer length must be >= opener length. Mixed ``` / ~~~ or shorter closers
+ * do not pop the open fence.
+ */
 function isInsideCodeFence(text, offset) {
-    const prefix = text.slice(0, offset);
-    const matches = prefix.match(CODE_FENCE_RE);
-    return matches !== null && matches.length % 2 === 1;
+    let openChar = null;
+    let openLen = 0;
+    let lineStart = 0;
+    while (lineStart < offset) {
+        let lineEnd = text.indexOf("\n", lineStart);
+        if (lineEnd === -1 || lineEnd > offset) {
+            lineEnd = Math.min(text.length, offset);
+        }
+        const line = text.slice(lineStart, lineEnd);
+        const m = CODE_FENCE_LINE_RE.exec(line);
+        if (m !== null) {
+            const fence = m[0] ?? "";
+            const ch = fence[0];
+            const len = fence.length;
+            if (openChar === null) {
+                openChar = ch;
+                openLen = len;
+            }
+            else if (ch === openChar && len >= openLen) {
+                openChar = null;
+                openLen = 0;
+            }
+        }
+        if (lineEnd >= offset) {
+            break;
+        }
+        lineStart = lineEnd + 1;
+    }
+    return openChar !== null;
 }
 function classifyHit(text, match) {
     const start = match.index ?? 0;
@@ -88,6 +120,12 @@ export function renderHit(hit) {
     return (`  [${hit.source}] ${hit.reason}: ` +
         `"...${hit.context}..." -> ${hit.keyword} #${hit.issueNumber}`);
 }
+function snippetAround(text, match) {
+    const snippetStart = Math.max(0, (match.index ?? 0) - 30);
+    const snippetEnd = Math.min(text.length, (match.index ?? 0) + match[0].length + 30);
+    return text.slice(snippetStart, snippetEnd).replace(/\n/g, " ");
+}
+/** Layer 0 FP hits only (#737): keyword in negation / quotation / example / code-block / blockquote. */
 export function findHits(text, source) {
     const hits = [];
     const re = new RegExp(CLOSING_KEYWORD_RE.source, CLOSING_KEYWORD_RE.flags);
@@ -95,14 +133,11 @@ export function findHits(text, source) {
     while (match !== null) {
         const category = classifyHit(text, match);
         if (category !== null) {
-            const snippetStart = Math.max(0, (match.index ?? 0) - 30);
-            const snippetEnd = Math.min(text.length, (match.index ?? 0) + match[0].length + 30);
-            const context = text.slice(snippetStart, snippetEnd).replace(/\n/g, " ");
             hits.push({
                 source,
                 keyword: match[1] ?? "",
                 issueNumber: Number(match[2]),
-                context,
+                context: snippetAround(text, match),
                 reason: category,
             });
         }
@@ -110,4 +145,34 @@ export function findHits(text, source) {
     }
     return hits;
 }
+/**
+ * Intent-mode hits (#3015 class D): every closing-keyword + `#N` match, regardless of
+ * surrounding prose. GitHub closes on token presence; conditional English is ignored.
+ * reason is the FP category when present, otherwise `intent`.
+ */
+export function findAllClosingKeywordHits(text, source) {
+    const hits = [];
+    const re = new RegExp(CLOSING_KEYWORD_RE.source, CLOSING_KEYWORD_RE.flags);
+    let match = re.exec(text);
+    while (match !== null) {
+        const category = classifyHit(text, match);
+        hits.push({
+            source,
+            keyword: match[1] ?? "",
+            issueNumber: Number(match[2]),
+            context: snippetAround(text, match),
+            reason: category ?? "intent",
+        });
+        match = re.exec(text);
+    }
+    return hits;
+}
+/**
+ * Body trailer `deft-close-intent: full` is intentionally NOT an authorization path.
+ * Intent-mode allowlist is CLI `--allow-close N,M` only (#3015 / Greptile class-D gate).
+ * Markdown examples must never suppress real closing-keyword findings.
+ */
+export function hasFullCloseIntent(_text) {
+    return false;
+}
 //# sourceMappingURL=detect.js.map

package/dist/pr-closing-keywords/index.d.ts

@@ -1,7 +1,7 @@
 export { EXIT_CONFIG_ERROR, EXIT_HITS_FOUND, EXIT_OK, GH_TIMEOUT_S, WINDOW_RADIUS, } from "./constants.js";
-export { findHits, renderHit } from "./detect.js";
+export { findAllClosingKeywordHits, findHits, hasFullCloseIntent, renderHit, } from "./detect.js";
 export { defaultRunGh, fetchPrBody, fetchPrCommitMessages } from "./gh.js";
 export { readCommitsFile, readTextFile } from "./io.js";
 export { cmdPrCheckClosingKeywords, parseAllowList, parseArgs, run } from "./main.js";
-export type { Hit, ParsedArgs, RunGhFn, RunGhResult } from "./types.js";
+export type { ClosingKeywordMode, Hit, ParsedArgs, RunGhFn, RunGhResult } from "./types.js";
 //# sourceMappingURL=index.d.ts.map

package/dist/pr-closing-keywords/index.js

@@ -1,5 +1,5 @@
 export { EXIT_CONFIG_ERROR, EXIT_HITS_FOUND, EXIT_OK, GH_TIMEOUT_S, WINDOW_RADIUS, } from "./constants.js";
-export { findHits, renderHit } from "./detect.js";
+export { findAllClosingKeywordHits, findHits, hasFullCloseIntent, renderHit, } from "./detect.js";
 export { defaultRunGh, fetchPrBody, fetchPrCommitMessages } from "./gh.js";
 export { readCommitsFile, readTextFile } from "./io.js";
 export { cmdPrCheckClosingKeywords, parseAllowList, parseArgs, run } from "./main.js";