@deftai/directive-core 0.87.0 → 0.89.0

package/dist/hooks/fixtures/cases.js

@@ -0,0 +1,595 @@
+/**
+ * Shared host × OS × tool fixture corpus (#2950 Phase A skeleton, Phase B matrix expansion).
+ *
+ * Cases are pure data: raw stdin or structured payload → expected classification.
+ * Core tests and CLI hook-dispatch tests import this module (shared corpus collapse).
+ */
+const freeFormAddPosix = [
+    "*** Begin Patch",
+    "*** Add File: xbrief/proposed/_probe-applypatch-only.txt",
+    "+probe",
+    "*** End Patch",
+].join("\n");
+const freeFormUpdateWin32 = [
+    "*** Begin Patch",
+    "*** Update File: src\\example.ts",
+    "@@",
+    "-old",
+    "+new",
+    "*** End Patch",
+].join("\n");
+const freeFormUpdatePosix = [
+    "*** Begin Patch",
+    "*** Update File: src/example.ts",
+    "@@",
+    "-old",
+    "+new",
+    "*** End Patch",
+].join("\n");
+const freeFormAddWin32 = [
+    "*** Begin Patch",
+    "*** Add File: xbrief\\proposed\\_probe-win32.txt",
+    "+probe",
+    "*** End Patch",
+].join("\n");
+/**
+ * Cursor × {win32, posix} × {Write, ApplyPatch, Task, StrReplace}
+ * plus recent regression classes (BOM, free-form, missing tool name, outside-root).
+ * Phase B expands Write/ApplyPatch depth and shares this corpus with CLI tests.
+ */
+export const HOOK_FIXTURE_CASES = [
+    // --- Cursor × posix × Write ---
+    {
+        id: "cursor-posix-write-structured",
+        host: "cursor",
+        os: "posix",
+        tool: "Write",
+        regression: ["#2669", "#2950"],
+        payload: {
+            tool_name: "Write",
+            tool_input: { contents: "hello", path: "src/a.ts" },
+            cwd: "/project",
+        },
+        expected: {
+            toolName: "Write",
+            writeIntent: "direct-write",
+            writeTargetPath: "src/a.ts",
+        },
+    },
+    {
+        id: "cursor-posix-write-infer-name",
+        host: "cursor",
+        os: "posix",
+        tool: "Write",
+        regression: ["#2628", "#2669"],
+        payload: {
+            arguments: { contents: "x", path: "a.py" },
+        },
+        expected: {
+            toolName: "Write",
+            writeIntent: "direct-write",
+            writeTargetPath: "a.py",
+        },
+        notes: "Cursor omits tool_name; infer from contents+path",
+    },
+    {
+        id: "cursor-posix-write-outside-root",
+        host: "cursor",
+        os: "posix",
+        tool: "Write",
+        regression: ["#2885"],
+        payload: {
+            tool_name: "Write",
+            tool_input: {
+                file_path: "/home/user/.claude/projects/slug/memory/note.md",
+            },
+            cwd: "/project",
+        },
+        expected: {
+            toolName: "Write",
+            writeIntent: "direct-write",
+            writeTargetPath: "/home/user/.claude/projects/slug/memory/note.md",
+        },
+    },
+    {
+        id: "cursor-posix-write-filePath-camel",
+        host: "cursor",
+        os: "posix",
+        tool: "Write",
+        regression: ["#2625", "#2950"],
+        payload: {
+            tool_name: "Write",
+            tool_input: { content: "body", filePath: "docs/note.md" },
+            cwd: "/project",
+        },
+        expected: {
+            toolName: "Write",
+            writeIntent: "direct-write",
+            writeTargetPath: "docs/note.md",
+        },
+        notes: "camelCase filePath spelling on tool_input",
+    },
+    {
+        id: "cursor-posix-write-text-field-infer",
+        host: "cursor",
+        os: "posix",
+        tool: "Write",
+        regression: ["#2628", "#2669"],
+        payload: {
+            tool_input: { text: "hello", path: "scratch/out.txt" },
+        },
+        expected: {
+            toolName: "Write",
+            writeIntent: "direct-write",
+            writeTargetPath: "scratch/out.txt",
+        },
+        notes: "Cursor omits tool_name; infer Write from text+path",
+    },
+    {
+        id: "cursor-posix-write-edit-alias",
+        host: "cursor",
+        os: "posix",
+        tool: "Write",
+        regression: ["#2669", "#2950"],
+        payload: {
+            tool_name: "Edit",
+            tool_input: { path: "src/legacy.ts", contents: "x" },
+            cwd: "/project",
+        },
+        expected: {
+            toolName: "Edit",
+            writeIntent: "direct-write",
+            writeTargetPath: "src/legacy.ts",
+        },
+        notes: "Edit is a direct-write host spelling (Cursor maps Claude Edit → Write)",
+    },
+    // --- Cursor × win32 × Write ---
+    {
+        id: "cursor-win32-write-structured",
+        host: "cursor",
+        os: "win32",
+        tool: "Write",
+        regression: ["#2787", "#2950"],
+        payload: {
+            tool_name: "Write",
+            tool_input: {
+                contents: "x",
+                path: "C:\\Repos\\deft\\statusreport\\src\\a.ts",
+            },
+            workspace_roots: ["C:\\Repos\\deft\\statusreport"],
+        },
+        expected: {
+            toolName: "Write",
+            writeIntent: "direct-write",
+            writeTargetPath: "C:\\Repos\\deft\\statusreport\\src\\a.ts",
+        },
+    },
+    {
+        id: "cursor-win32-write-statusreport-shape",
+        host: "cursor",
+        os: "win32",
+        tool: "Write",
+        regression: ["#2787"],
+        payload: {
+            tool_name: "Write",
+            tool_input: { content: "x", file_path: "notes.md" },
+            workspace_roots: ["C:\\Repos\\deft\\statusreport"],
+            cwd: "C:\\Repos\\deft\\statusreport",
+        },
+        expected: {
+            toolName: "Write",
+            writeIntent: "direct-write",
+            writeTargetPath: "notes.md",
+        },
+        notes: "Ritual-root normalization is dispatcher-owned; classify keeps raw path",
+    },
+    {
+        id: "cursor-win32-write-bom-raw",
+        host: "cursor",
+        os: "win32",
+        tool: "Write",
+        regression: ["#2734"],
+        raw: `\uFEFF${JSON.stringify({
+            tool_name: "Write",
+            tool_input: { content: "x", file_path: "a.txt" },
+            workspace_roots: ["C:\\\\Repos\\\\deft"],
+        })}`,
+        expected: {
+            toolName: "Write",
+            writeIntent: "direct-write",
+            writeTargetPath: "a.txt",
+            stdinEmpty: false,
+            parseFailed: false,
+        },
+    },
+    {
+        id: "cursor-win32-write-mixed-separators",
+        host: "cursor",
+        os: "win32",
+        tool: "Write",
+        regression: ["#2787", "#2950"],
+        payload: {
+            tool_name: "Write",
+            tool_input: {
+                content: "x",
+                file_path: "C:/Repos/deft/statusreport/src/b.ts",
+            },
+            workspace_roots: ["C:\\Repos\\deft\\statusreport"],
+        },
+        expected: {
+            toolName: "Write",
+            writeIntent: "direct-write",
+            writeTargetPath: "C:/Repos/deft/statusreport/src/b.ts",
+        },
+        notes: "Forward-slash Windows path kept raw at classify layer",
+    },
+    {
+        id: "cursor-win32-write-infer-content",
+        host: "cursor",
+        os: "win32",
+        tool: "Write",
+        regression: ["#2628", "#2669"],
+        payload: {
+            tool_input: {
+                content: "x",
+                file_path: "C:\\Repos\\proj\\notes.md",
+            },
+            workspace_roots: ["C:\\Repos\\proj"],
+        },
+        expected: {
+            toolName: "Write",
+            writeIntent: "direct-write",
+            writeTargetPath: "C:\\Repos\\proj\\notes.md",
+        },
+        notes: "Cursor omits tool_name; infer Write from content+file_path",
+    },
+    {
+        id: "cursor-win32-write-doubled-drive-raw",
+        host: "cursor",
+        os: "win32",
+        tool: "Write",
+        regression: ["#2787", "#2764"],
+        payload: {
+            tool_name: "Write",
+            tool_input: {
+                content: "x",
+                file_path: "C:\\c:\\Repos\\deft\\statusreport\\src\\a.ts",
+            },
+            workspace_roots: ["C:\\Repos\\deft\\statusreport"],
+        },
+        expected: {
+            toolName: "Write",
+            writeIntent: "direct-write",
+            writeTargetPath: "C:\\c:\\Repos\\deft\\statusreport\\src\\a.ts",
+        },
+        notes: "Doubled-drive prefix stays raw here; normalizeHookProjectRoot is dispatcher-owned",
+    },
+    // --- Cursor × posix × ApplyPatch ---
+    {
+        id: "cursor-posix-applypatch-structured",
+        host: "cursor",
+        os: "posix",
+        tool: "ApplyPatch",
+        regression: ["#2738", "#2790"],
+        payload: {
+            tool_name: "ApplyPatch",
+            tool_input: {
+                path: "xbrief/proposed/a.xbrief.json",
+                patch: "*** Begin Patch\n*** Add File: x\n+probe\n*** End Patch",
+            },
+        },
+        expected: {
+            toolName: "ApplyPatch",
+            writeIntent: "direct-write",
+            writeTargetPath: "xbrief/proposed/a.xbrief.json",
+        },
+    },
+    {
+        id: "cursor-posix-applypatch-freeform",
+        host: "cursor",
+        os: "posix",
+        tool: "ApplyPatch",
+        regression: ["#2738"],
+        raw: freeFormAddPosix,
+        expected: {
+            toolName: "ApplyPatch",
+            writeIntent: "direct-write",
+            writeTargetPath: "xbrief/proposed/_probe-applypatch-only.txt",
+            parseFailed: false,
+        },
+    },
+    {
+        id: "cursor-posix-applypatch-infer-from-patch-field",
+        host: "cursor",
+        os: "posix",
+        tool: "ApplyPatch",
+        regression: ["#2669"],
+        payload: {
+            tool_input: { path: "src/a.ts", patch: "diff" },
+        },
+        expected: {
+            toolName: "ApplyPatch",
+            writeIntent: "direct-write",
+            writeTargetPath: "src/a.ts",
+        },
+    },
+    {
+        id: "cursor-posix-applypatch-freeform-update",
+        host: "cursor",
+        os: "posix",
+        tool: "ApplyPatch",
+        regression: ["#2738", "#2950"],
+        raw: freeFormUpdatePosix,
+        expected: {
+            toolName: "ApplyPatch",
+            writeIntent: "direct-write",
+            writeTargetPath: "src/example.ts",
+            parseFailed: false,
+        },
+    },
+    {
+        id: "cursor-posix-applypatch-unified-diff-key",
+        host: "cursor",
+        os: "posix",
+        tool: "ApplyPatch",
+        regression: ["#2669", "#2950"],
+        payload: {
+            tool_input: {
+                path: "lib/b.ts",
+                unified_diff: "*** Begin Patch\n*** Update File: lib/b.ts\n*** End Patch",
+            },
+        },
+        expected: {
+            toolName: "ApplyPatch",
+            writeIntent: "direct-write",
+            writeTargetPath: "lib/b.ts",
+        },
+        notes: "Cursor omits tool_name; infer ApplyPatch from unified_diff",
+    },
+    {
+        id: "cursor-posix-applypatch-delete-only-fail-closed",
+        host: "cursor",
+        os: "posix",
+        tool: "ApplyPatch",
+        regression: ["#2738"],
+        raw: ["*** Begin Patch", "*** Delete File: src/a.ts", "*** End Patch"].join("\n"),
+        expected: {
+            toolName: null,
+            writeIntent: "unknown",
+            writeTargetPath: null,
+            parseFailed: true,
+        },
+        notes: "Delete-only free-form is fail-closed at parse (no synthesize)",
+    },
+    // --- Cursor × win32 × ApplyPatch ---
+    {
+        id: "cursor-win32-applypatch-structured",
+        host: "cursor",
+        os: "win32",
+        tool: "ApplyPatch",
+        regression: ["#2738", "#2790"],
+        payload: {
+            tool_name: "ApplyPatch",
+            tool_input: {
+                path: "C:\\Repos\\proj\\src\\a.ts",
+                patch: "*** Begin Patch",
+            },
+            workspace_roots: ["C:\\Repos\\proj"],
+        },
+        expected: {
+            toolName: "ApplyPatch",
+            writeIntent: "direct-write",
+            writeTargetPath: "C:\\Repos\\proj\\src\\a.ts",
+        },
+    },
+    {
+        id: "cursor-win32-applypatch-freeform",
+        host: "cursor",
+        os: "win32",
+        tool: "ApplyPatch",
+        regression: ["#2738"],
+        raw: freeFormUpdateWin32,
+        expected: {
+            toolName: "ApplyPatch",
+            writeIntent: "direct-write",
+            writeTargetPath: "src\\example.ts",
+            parseFailed: false,
+        },
+    },
+    {
+        id: "cursor-win32-applypatch-freeform-add",
+        host: "cursor",
+        os: "win32",
+        tool: "ApplyPatch",
+        regression: ["#2738", "#2950"],
+        raw: freeFormAddWin32,
+        expected: {
+            toolName: "ApplyPatch",
+            writeIntent: "direct-write",
+            writeTargetPath: "xbrief\\proposed\\_probe-win32.txt",
+            parseFailed: false,
+        },
+    },
+    {
+        id: "cursor-win32-applypatch-infer-from-patch",
+        host: "cursor",
+        os: "win32",
+        tool: "ApplyPatch",
+        regression: ["#2669", "#2950"],
+        payload: {
+            tool_input: {
+                path: "C:\\Repos\\proj\\src\\patch-me.ts",
+                patch: "diff",
+            },
+            workspace_roots: ["C:\\Repos\\proj"],
+        },
+        expected: {
+            toolName: "ApplyPatch",
+            writeIntent: "direct-write",
+            writeTargetPath: "C:\\Repos\\proj\\src\\patch-me.ts",
+        },
+    },
+    {
+        id: "cursor-win32-applypatch-multifile-fail-closed",
+        host: "cursor",
+        os: "win32",
+        tool: "ApplyPatch",
+        regression: ["#2738"],
+        raw: [
+            "*** Begin Patch",
+            "*** Add File: a.txt",
+            "+a",
+            "*** Add File: b.txt",
+            "+b",
+            "*** End Patch",
+        ].join("\n"),
+        expected: {
+            toolName: null,
+            writeIntent: "unknown",
+            writeTargetPath: null,
+            parseFailed: true,
+        },
+    },
+    // --- Cursor × posix × Task ---
+    {
+        id: "cursor-posix-task-spawn",
+        host: "cursor",
+        os: "posix",
+        tool: "Task",
+        regression: ["#1185", "#2864", "#2950"],
+        payload: {
+            tool_name: "Task",
+            tool_input: { description: "explore", prompt: "scan hooks" },
+            cwd: "/project",
+        },
+        expected: {
+            toolName: "Task",
+            writeIntent: "spawn",
+            writeTargetPath: null,
+        },
+    },
+    // --- Cursor × win32 × Task ---
+    {
+        id: "cursor-win32-task-spawn",
+        host: "cursor",
+        os: "win32",
+        tool: "Task",
+        regression: ["#1185", "#2864", "#2950"],
+        payload: {
+            tool_name: "Task",
+            tool_input: { description: "implement", prompt: "fix write path" },
+            workspace_roots: ["C:\\Repos\\deft\\statusreport"],
+        },
+        expected: {
+            toolName: "Task",
+            writeIntent: "spawn",
+            writeTargetPath: null,
+        },
+    },
+    // --- Cursor × posix/win32 × StrReplace (direct-write family) ---
+    {
+        id: "cursor-posix-strreplace-infer",
+        host: "cursor",
+        os: "posix",
+        tool: "StrReplace",
+        regression: ["#2628", "#2669", "#2950"],
+        payload: {
+            tool_input: {
+                path: "src/edit-me.ts",
+                old_string: "a",
+                new_string: "b",
+            },
+        },
+        expected: {
+            toolName: "StrReplace",
+            writeIntent: "direct-write",
+            writeTargetPath: "src/edit-me.ts",
+        },
+    },
+    {
+        id: "cursor-win32-strreplace-structured",
+        host: "cursor",
+        os: "win32",
+        tool: "StrReplace",
+        regression: ["#2628", "#2950"],
+        payload: {
+            tool_name: "StrReplace",
+            tool_input: {
+                file_path: "C:\\Repos\\proj\\src\\edit-me.ts",
+                old_string: "a",
+                new_string: "b",
+            },
+            workspace_roots: ["C:\\Repos\\proj"],
+        },
+        expected: {
+            toolName: "StrReplace",
+            writeIntent: "direct-write",
+            writeTargetPath: "C:\\Repos\\proj\\src\\edit-me.ts",
+        },
+    },
+    // --- Regression: empty / missing tool name ---
+    {
+        id: "cursor-posix-stdin-empty",
+        host: "cursor",
+        os: "posix",
+        tool: "other",
+        regression: ["#2864"],
+        raw: "",
+        expected: {
+            toolName: null,
+            writeIntent: "unknown",
+            writeTargetPath: null,
+            stdinEmpty: true,
+        },
+    },
+    {
+        id: "cursor-posix-missing-tool-name-keys",
+        host: "cursor",
+        os: "posix",
+        tool: "other",
+        regression: ["#2669", "#2864"],
+        payload: { host_version: "1.2.3" },
+        expected: {
+            toolName: null,
+            writeIntent: "unknown",
+            writeTargetPath: null,
+        },
+    },
+    {
+        id: "cursor-posix-applypatch-multifile-fail-closed",
+        host: "cursor",
+        os: "posix",
+        tool: "ApplyPatch",
+        regression: ["#2738"],
+        raw: [
+            "*** Begin Patch",
+            "*** Add File: a.txt",
+            "+a",
+            "*** Add File: b.txt",
+            "+b",
+            "*** End Patch",
+        ].join("\n"),
+        expected: {
+            toolName: null,
+            writeIntent: "unknown",
+            writeTargetPath: null,
+            parseFailed: true,
+        },
+    },
+];
+export function fixtureCasesFor(filter) {
+    return HOOK_FIXTURE_CASES.filter((c) => {
+        if (filter.host !== undefined && c.host !== filter.host)
+            return false;
+        if (filter.os !== undefined && c.os !== filter.os)
+            return false;
+        if (filter.tool !== undefined && c.tool !== filter.tool)
+            return false;
+        return true;
+    });
+}
+/** Look up a single case by stable id (CLI/core shared helpers). */
+export function fixtureCaseById(id) {
+    return HOOK_FIXTURE_CASES.find((c) => c.id === id);
+}
+//# sourceMappingURL=cases.js.map

package/dist/hooks/fixtures/index.d.ts

@@ -0,0 +1,2 @@
+export { type FixtureOs, type FixtureToolFamily, fixtureCaseById, fixtureCasesFor, HOOK_FIXTURE_CASES, type HookFixtureCase, } from "./cases.js";
+//# sourceMappingURL=index.d.ts.map

package/dist/hooks/fixtures/index.js

@@ -0,0 +1,2 @@
+export { fixtureCaseById, fixtureCasesFor, HOOK_FIXTURE_CASES, } from "./cases.js";
+//# sourceMappingURL=index.js.map

package/dist/hooks/index.d.ts

@@ -1,4 +1,6 @@
+export * from "./classify/index.js";
 export * from "./cursor-hooks.js";
 export * from "./dispatcher.js";
+export * from "./fixtures/index.js";
 export * from "./scope.js";
 //# sourceMappingURL=index.d.ts.map

package/dist/hooks/index.js

@@ -1,4 +1,6 @@
+export * from "./classify/index.js";
 export * from "./cursor-hooks.js";
 export * from "./dispatcher.js";
+export * from "./fixtures/index.js";
 export * from "./scope.js";
 //# sourceMappingURL=index.js.map

package/dist/hooks/tools.d.ts

@@ -2,10 +2,41 @@
 export declare const DIRECT_WRITE_TOOL_NAMES: readonly ["Edit", "Write", "WriteFile", "CreateFile", "MultiEdit", "NotebookEdit", "StrReplace", "SearchReplace", "Delete", "DeleteFile", "ApplyPatch", "apply_patch"];
 /** PreToolUse spawn / sub-agent dispatch tools (#1185 / #2437). */
 export declare const SPAWN_TOOL_NAMES: readonly ["Task", "SubagentStart", "spawn_subagent", "start_agent", "CreateAgent"];
+/**
+ * Host spellings for Shell/Bash execution tools (#2711).
+ * Used for runtimeAuthority scopes.push / scopes.merge classification.
+ */
+export declare const SHELL_TOOL_NAMES: readonly ["Shell", "Bash", "BashTool", "shell", "bash"];
 /** Env override forcing hook-level read-only write denial (#1185). */
 export declare const READ_ONLY_HOOK_ENV = "DEFT_HOOK_READ_ONLY";
 export declare function isDirectWriteTool(toolName: string): boolean;
 export declare function isSpawnTool(toolName: string): boolean;
+/** True for host Shell/Bash-class tools that carry a command string (#2711). */
+export declare function isShellTool(toolName: string): boolean;
+/**
+ * Best-effort MCP tool detection for runtimeAuthority push/merge scopes (#2711).
+ * Host spellings vary (`mcp__*`, `server__tool`, bare MCP-looking names).
+ * Unclassifiable MCP tools fail open at the operation classifier.
+ *
+ * Bare push/merge names (e.g. `merge_pull_request`) are NOT detected here —
+ * they are classified by `classifyMcpTool` and routed from `decideHook` so
+ * tools.ts stays free of policy imports (#2711 Greptile conf holdout).
+ */
+export declare function isMcpTool(toolName: string): boolean;
+/**
+ * Bare tool names that hosts may emit without mcp__/server__ prefixes and that
+ * `classifyMcpTool` treats as push or merge (#2711).
+ * Keep in sync with classifyMcpTool name patterns (narrow list for PreToolUse matchers).
+ */
+export declare const MCP_PUSH_MERGE_BARE_NAMES: readonly ["merge_pull_request", "merge-pull-request", "pull_request_merge", "pull-request-merge", "merge_pr", "pr_merge", "pr-merge", "git_push", "git-push", "push_branch", "push-branch"];
 export declare const DIRECT_WRITE_HOOK_MATCHER: string;
 export declare const SPAWN_HOOK_MATCHER: string;
+export declare const SHELL_HOOK_MATCHER: string;
+/**
+ * PreToolUse matcher for MCP-class push/merge tools (#2711).
+ * Regex-friendly for Claude/nested hosts. Prefer broad install match +
+ * fail-open classify in the dispatcher over missing a classifiable push/merge
+ * tool name (e.g. `server__push_to_remote` via push+remote).
+ */
+export declare const MCP_HOOK_MATCHER: string;
 //# sourceMappingURL=tools.d.ts.map