@defra-fish/sales-api-service 1.77.0-rc.13 → 1.77.0-rc.14

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@defra-fish/sales-api-service",
-  "version": "1.77.0-rc.13",
+  "version": "1.77.0-rc.14",
   "description": "Rod Licensing Sales API",
   "type": "module",
   "engines": {
@@ -35,9 +35,9 @@
     "test": "echo \"Error: run tests from root\" && exit 1"
   },
   "dependencies": {
-    "@defra-fish/business-rules-lib": "1.77.0-rc.13",
-    "@defra-fish/connectors-lib": "1.77.0-rc.13",
-    "@defra-fish/dynamics-lib": "1.77.0-rc.13",
+    "@defra-fish/business-rules-lib": "1.77.0-rc.14",
+    "@defra-fish/connectors-lib": "1.77.0-rc.14",
+    "@defra-fish/dynamics-lib": "1.77.0-rc.14",
     "@hapi/boom": "9.1.2",
     "@hapi/hapi": "20.1.3",
     "@hapi/inert": "6.0.3",
@@ -53,5 +53,5 @@
     "moment-timezone": "0.5.34",
     "uuid": "8.3.2"
   },
-  "gitHead": "9b50785aff2de19747492c70fcda9b64aad4ca40"
+  "gitHead": "c6cf6a1e30e4336d164902820c5fae0c08123821"
 }

package/src/services/transactions/__tests__/process-transaction-queue.spec.js

@@ -436,16 +436,22 @@ describe('transaction service', () => {
     })
 
     describe('when persisting throws an PermissionReferenceNumber_Key error', () => {
+      const permissionReferenceKeyError = () => {
+        const e = new Error()
+        e.error = {
+          message:
+            'Entity Key PermissionReferenceNumber_Key violated. A record with the same value for Permission Reference Number already exists. A duplicate record cannot be created. Select one or more unique values and try again.'
+        }
+        return e
+      }
+
       it('does not throw an error', async () => {
         const transactionFilename = 'test-file.xml'
         const mockRecord = mockFinalisedTransactionRecord()
         mockRecord.transactionFile = transactionFilename
         retrieveStagedTransaction.mockResolvedValueOnce(mockRecord)
 
-        const error = new Error(
-          'Entity Key PermissionReferenceNumber_Key violated. A record with the same value for Permission Reference Number already exists. A duplicate record cannot be created. Select one or more unique values and try again.'
-        )
-        persist.mockRejectedValueOnce(error)
+        persist.mockRejectedValueOnce(permissionReferenceKeyError())
 
         await expect(processQueue({ id: mockRecord.id })).resolves.not.toThrow()
       })
@@ -456,10 +462,7 @@ describe('transaction service', () => {
         mockRecord.transactionFile = transactionFilename
         retrieveStagedTransaction.mockResolvedValueOnce(mockRecord)
 
-        const error = new Error(
-          'Entity Key PermissionReferenceNumber_Key violated. A record with the same value for Permission Reference Number already exists. A duplicate record cannot be created. Select one or more unique values and try again.'
-        )
-        persist.mockRejectedValueOnce(error)
+        persist.mockRejectedValueOnce(permissionReferenceKeyError())
 
         await processQueue({ id: mockRecord.id })
 
@@ -472,10 +475,7 @@ describe('transaction service', () => {
         mockRecord.transactionFile = transactionFilename
         retrieveStagedTransaction.mockResolvedValueOnce(mockRecord)
 
-        const error = new Error(
-          'Entity Key PermissionReferenceNumber_Key violated. A record with the same value for Permission Reference Number already exists. A duplicate record cannot be created. Select one or more unique values and try again.'
-        )
-        persist.mockRejectedValueOnce(error)
+        persist.mockRejectedValueOnce(permissionReferenceKeyError())
 
         await processQueue({ id: mockRecord.id })
 
@@ -493,10 +493,7 @@ describe('transaction service', () => {
         mockRecord.transactionFile = transactionFilename
         retrieveStagedTransaction.mockResolvedValueOnce(mockRecord)
 
-        const error = new Error(
-          'Entity Key PermissionReferenceNumber_Key violated. A record with the same value for Permission Reference Number already exists. A duplicate record cannot be created. Select one or more unique values and try again.'
-        )
-        persist.mockRejectedValueOnce(error)
+        persist.mockRejectedValueOnce(permissionReferenceKeyError())
 
         await processQueue({ id: mockRecord.id })
 

package/src/services/transactions/process-transaction-queue.js

@@ -180,7 +180,7 @@ const persistEntities = async (entities, transactionRecord, id) => {
   try {
     await persist(entities, transactionRecord.createdBy)
   } catch (e) {
-    if (e.message.match(ALREADY_PERSISTED_ERROR)) {
+    if (e?.error?.message.match(ALREADY_PERSISTED_ERROR)) {
       debug('Permission for staging id %s has already been persisted', id)
     } else {
       throw e